• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

opendefensecloud / solution-arsenal / 24823711879

23 Apr 2026 07:54AM UTC coverage: 72.226% (-0.8%) from 73.044%
24823711879

push

github

web-flow
bugfix: fix error reporting (#446)

solves #350 

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Updated project `.gitignore` to exclude additional build artifacts,
test fixtures, and dependency directories.

* **Improvements**
* Enhanced Kubernetes event logging to include detailed error
information, providing better visibility for troubleshooting and
monitoring issues during task reconciliation and cleanup.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

1 of 4 new or added lines in 1 file covered. (25.0%)

26 existing lines in 2 files now uncovered.

2031 of 2812 relevant lines covered (72.23%)

26.31 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.56
/pkg/controller/rendertask_controller.go
1
// Copyright 2026 BWI GmbH and Solution Arsenal contributors
2
// SPDX-License-Identifier: Apache-2.0
3

4
package controller
5

6
import (
7
        "context"
8
        "encoding/json"
9
        "fmt"
10
        "strings"
11
        "time"
12

13
        batchv1 "k8s.io/api/batch/v1"
14
        corev1 "k8s.io/api/core/v1"
15
        apierrors "k8s.io/apimachinery/pkg/api/errors"
16
        apimeta "k8s.io/apimachinery/pkg/api/meta"
17
        metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
18
        "k8s.io/apimachinery/pkg/runtime"
19
        "k8s.io/client-go/tools/events"
20
        ctrl "sigs.k8s.io/controller-runtime"
21
        "sigs.k8s.io/controller-runtime/pkg/client"
22
        "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
23

24
        solarv1alpha1 "go.opendefense.cloud/solar/api/solar/v1alpha1"
25
)
26

27
const (
28
        annotationJobName    = "solar.opendefense.cloud/job-name"
29
        annotationSecretName = "solar.opendefense.cloud/secret-name"
30

31
        // Condition types
32
        ConditionTypeJobScheduled = "JobScheduled"
33
        ConditionTypeJobSucceeded = "JobSucceeded"
34
        ConditionTypeJobFailed    = "JobFailed"
35

36
        ConditionTypeTaskCompleted = "TaskCompleted"
37
        ConditionTypeTaskFailed    = "TaskFailed"
38
)
39

40
// RenderTaskReconciler reconciles a RenderTask object.
41
// Each RenderTask carries its own BaseURL and PushSecretRef for the target registry.
42
type RenderTaskReconciler struct {
43
        client.Client
44
        Scheme              *runtime.Scheme
45
        Recorder            events.EventRecorder
46
        RendererImage       string
47
        RendererCommand     string
48
        RendererArgs        []string
49
        RendererCAConfigMap string
50
}
51

52
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=rendertasks,verbs=get;list;watch;create;update;patch;delete
53
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=rendertasks/status,verbs=get;update;patch
54
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=rendertasks/finalizers,verbs=update
55
//+kubebuilder:rbac:groups=batch,resources=jobs,verbs=get;list;watch;create;update;patch;delete
56
//+kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch;create;update;patch;delete
57
//+kubebuilder:rbac:groups=core,resources=events,verbs=create;patch
58
//+kubebuilder:rbac:groups=events.k8s.io,resources=events,verbs=create;patch
59

60
// Reconcile moves the current state of the cluster closer to the desired state
61
func (r *RenderTaskReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
376✔
62
        log := ctrl.LoggerFrom(ctx)
376✔
63
        ctrlResult := ctrl.Result{}
376✔
64

376✔
65
        log.V(1).Info("RenderTask is being reconciled", "req", req)
376✔
66

376✔
67
        // Fetch the RenderTask instance
376✔
68
        res := &solarv1alpha1.RenderTask{}
376✔
69
        if err := r.Get(ctx, req.NamespacedName, res); err != nil {
397✔
70
                if apierrors.IsNotFound(err) {
42✔
71
                        return ctrlResult, nil
21✔
72
                }
21✔
73

74
                return ctrlResult, errLogAndWrap(log, err, "failed to get object")
×
75
        }
76

77
        // RenderTask instance marked for deletion, stop reconciling
78
        if !res.DeletionTimestamp.IsZero() {
355✔
79
                log.V(1).Info("RenderTask is being deleted")
×
80
                r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "Deleting", "Delete", "RenderTask is being deleted, cleaning up secret and job")
×
81

×
82
                return ctrlResult, nil
×
83
        }
×
84

85
        // Check if renderjob has already completed successfully
86
        sc := apimeta.FindStatusCondition(res.Status.Conditions, ConditionTypeJobSucceeded)
355✔
87
        if sc != nil && sc.ObservedGeneration >= res.Generation && sc.Status == metav1.ConditionTrue {
358✔
88
                log.V(1).Info("RenderTask has already completed successfully, no further action needed")
3✔
89

3✔
90
                return ctrlResult, nil
3✔
91
        }
3✔
92

93
        // Determine the namespace for Jobs/Secrets — use the RenderTask's namespace
94
        jobNS := r.taskNamespace(res)
352✔
95

352✔
96
        // Reconcile Config Secret
352✔
97
        configSecret := &corev1.Secret{}
352✔
98
        err := r.Get(ctx, r.configSecretKey(res, jobNS), configSecret)
352✔
99
        if err != nil && apierrors.IsNotFound(err) {
595✔
100
                createdSecret, err := r.createConfigSecret(ctx, res, jobNS)
243✔
101
                if err != nil {
244✔
102
                        r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "CreateSecretFailed", "CreateConfigSecret", "Failed to create config secret: %s", err)
1✔
103

1✔
104
                        return ctrlResult, errLogAndWrap(log, err, "failed to create secret")
1✔
105
                }
1✔
106

107
                configSecret = createdSecret
242✔
108
        } else if err != nil {
109✔
109
                return ctrlResult, errLogAndWrap(log, err, "could not get secret")
×
110
        }
×
111

112
        // Resolve push secret from the RenderTask's PushSecretRef
113
        var pushSecret *corev1.Secret
351✔
114
        if res.Spec.PushSecretRef != nil {
702✔
115
                pushSecret = &corev1.Secret{}
351✔
116
                if err := r.Get(ctx, client.ObjectKey{Name: res.Spec.PushSecretRef.Name, Namespace: jobNS}, pushSecret); err != nil {
394✔
117
                        return ctrlResult, errLogAndWrap(log, err, "failed to get push secret")
43✔
118
                }
43✔
119
        }
120

121
        // Reconcile Job
122
        job := &batchv1.Job{}
308✔
123
        err = r.Get(ctx, r.renderJobKey(res, jobNS), job)
308✔
124
        if err != nil && apierrors.IsNotFound(err) {
324✔
125
                err := r.createRenderJob(ctx, res, configSecret, pushSecret, jobNS)
16✔
126
                if err != nil {
16✔
NEW
127
                        r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "CreateJobFailed", "CreateJob", "Failed to create job: %s", err)
×
UNCOV
128

×
UNCOV
129
                        return ctrlResult, errLogAndWrap(log, err, "failed to create job")
×
UNCOV
130
                }
×
131
        } else if err != nil {
292✔
132
                return ctrlResult, errLogAndWrap(log, err, "could not get job")
×
133
        }
×
134

135
        // Update Status
136
        if changed := r.updateResourceStatusFromJob(ctx, res, job); changed {
333✔
137
                if err := r.Status().Update(ctx, res); err != nil {
29✔
138
                        return ctrlResult, errLogAndWrap(log, err, "failed to update status")
4✔
139
                }
4✔
140
        }
141

142
        ttlDuration := time.Duration(ttlSeconds(res.Spec.FailedJobTTL)) * time.Second
304✔
143

304✔
144
        switch {
304✔
145
        case job.Status.Succeeded > 0:
3✔
146
                cleanupRenderResources(ctx, r, res, job, jobNS)
3✔
147
                log.V(1).Info("Cleaned up after successful job")
3✔
148

3✔
149
                return ctrlResult, nil
3✔
150

151
        case job.Status.Failed > 0:
268✔
152
                if shouldCleanupSecrets(res, ttlDuration) {
532✔
153
                        cleanupSecrets(ctx, r, res, jobNS)
264✔
154
                        log.V(1).Info("Cleaned up secrets after failed job TTL")
264✔
155

264✔
156
                        return ctrlResult, nil
264✔
157
                }
264✔
158

159
                remaining := remainingTTL(res, ttlDuration)
4✔
160
                log.V(1).Info("Waiting for TTL to expire before cleaning up secrets", "remainingSeconds", remaining.Seconds())
4✔
161

4✔
162
                return ctrl.Result{RequeueAfter: remaining + time.Second}, nil
4✔
163
        }
164

165
        return ctrlResult, nil
33✔
166
}
167

168
// taskNamespace returns the namespace to use for Jobs/Secrets.
169
func (r *RenderTaskReconciler) taskNamespace(res *solarv1alpha1.RenderTask) string {
352✔
170
        return res.Namespace
352✔
171
}
352✔
172

173
// updateResourceStatusFromJob updates the resource status based on job status
174
func (r *RenderTaskReconciler) updateResourceStatusFromJob(ctx context.Context, res *solarv1alpha1.RenderTask, job *batchv1.Job) (changed bool) {
308✔
175
        log := ctrl.LoggerFrom(ctx)
308✔
176

308✔
177
        if job == nil {
308✔
178
                changed = apimeta.SetStatusCondition(&res.Status.Conditions, metav1.Condition{
×
179
                        Type:               ConditionTypeJobScheduled,
×
180
                        Status:             metav1.ConditionFalse,
×
181
                        ObservedGeneration: res.Generation,
×
182
                        Reason:             "DoesNotExist",
×
183
                        Message:            "Renderer job does not exist",
×
184
                })
×
185

×
186
                return changed
×
187
        }
×
188

189
        if job.Status.Succeeded > 0 {
311✔
190
                changed = apimeta.SetStatusCondition(&res.Status.Conditions, metav1.Condition{
3✔
191
                        Type:               ConditionTypeJobSucceeded,
3✔
192
                        Status:             metav1.ConditionTrue,
3✔
193
                        ObservedGeneration: res.Generation,
3✔
194
                        Reason:             "JobSucceeded",
3✔
195
                        Message:            fmt.Sprintf("Renderer job completed successfully at %v", job.Status.CompletionTime),
3✔
196
                })
3✔
197

3✔
198
                chartURL := r.reference(res.Spec.BaseURL, res.Spec.Repository, res.Spec.Tag)
3✔
199
                if res.Status.ChartURL != chartURL {
6✔
200
                        res.Status.ChartURL = chartURL
3✔
201
                        changed = true
3✔
202
                }
3✔
203

204
                r.Recorder.Eventf(res, job, corev1.EventTypeNormal, "JobSucceeded", "RunJob", "Renderer job completed successfully")
3✔
205
                log.V(1).Info("Job succeeded", "name", job.Name)
3✔
206

3✔
207
                return changed
3✔
208
        }
209

210
        if job.Status.Failed > 0 {
573✔
211
                changed = apimeta.SetStatusCondition(&res.Status.Conditions, metav1.Condition{
268✔
212
                        Type:               ConditionTypeJobFailed,
268✔
213
                        Status:             metav1.ConditionTrue,
268✔
214
                        ObservedGeneration: res.Generation,
268✔
215
                        Reason:             "JobFailed",
268✔
216
                        Message:            "Renderer job failed",
268✔
217
                })
268✔
218
                r.Recorder.Eventf(res, job, corev1.EventTypeWarning, "JobFailed", "RunJob", "Renderer job failed")
268✔
219
                log.V(1).Info("Job failed", "name", job.Name)
268✔
220

268✔
221
                return changed
268✔
222
        }
268✔
223

224
        return apimeta.SetStatusCondition(&res.Status.Conditions, metav1.Condition{
37✔
225
                Type:               ConditionTypeJobScheduled,
37✔
226
                Status:             metav1.ConditionTrue,
37✔
227
                ObservedGeneration: res.Generation,
37✔
228
                Reason:             "JobScheduled",
37✔
229
                Message:            fmt.Sprintf("Renderer job is running (active: %d, succeeded: %d, failed: %d)", job.Status.Active, job.Status.Succeeded, job.Status.Failed),
37✔
230
        })
37✔
231
}
232

233
func (r *RenderTaskReconciler) deleteRenderJob(ctx context.Context, res *solarv1alpha1.RenderTask, jobNS string) error {
3✔
234
        job := &batchv1.Job{}
3✔
235
        if err := r.Get(ctx, r.renderJobKey(res, jobNS), job); err != nil {
3✔
236
                return err
×
237
        }
×
238

239
        return r.Delete(ctx, job, client.PropagationPolicy(metav1.DeletePropagationBackground))
3✔
240
}
241

242
func (r *RenderTaskReconciler) deleteConfigSecret(ctx context.Context, res *solarv1alpha1.RenderTask, jobNS string) error {
267✔
243
        secret := &corev1.Secret{}
267✔
244
        if err := r.Get(ctx, r.configSecretKey(res, jobNS), secret); err != nil {
273✔
245
                return err
6✔
246
        }
6✔
247

248
        return r.Delete(ctx, secret, client.PropagationPolicy(metav1.DeletePropagationBackground))
261✔
249
}
250

251
func (r *RenderTaskReconciler) createRenderJob(ctx context.Context, res *solarv1alpha1.RenderTask, configSecret, pushSecret *corev1.Secret, jobNS string) error {
16✔
252
        log := ctrl.LoggerFrom(ctx)
16✔
253

16✔
254
        jobKey := r.renderJobKey(res, jobNS)
16✔
255
        jobName := jobKey.Name
16✔
256
        backoffLimit := int32(3)
16✔
257
        ttlSecondsAfterFinished := int32(3600)
16✔
258
        if res.Spec.FailedJobTTL != nil {
18✔
259
                ttlSecondsAfterFinished = *res.Spec.FailedJobTTL
2✔
260
        }
2✔
261

262
        volumes := []corev1.Volume{
16✔
263
                {
16✔
264
                        Name: "config",
16✔
265
                        VolumeSource: corev1.VolumeSource{
16✔
266
                                Secret: &corev1.SecretVolumeSource{
16✔
267
                                        SecretName: configSecret.Name,
16✔
268
                                        Items: []corev1.KeyToPath{
16✔
269
                                                {
16✔
270
                                                        Key:  "config.json",
16✔
271
                                                        Path: "config.json",
16✔
272
                                                },
16✔
273
                                        },
16✔
274
                                },
16✔
275
                        },
16✔
276
                },
16✔
277
        }
16✔
278
        volumeMounts := []corev1.VolumeMount{
16✔
279
                {
16✔
280
                        Name:      "config",
16✔
281
                        MountPath: "/etc/renderer/config.json",
16✔
282
                        SubPath:   "config.json",
16✔
283
                        ReadOnly:  true,
16✔
284
                },
16✔
285
        }
16✔
286
        envVars := []corev1.EnvVar{
16✔
287
                {
16✔
288
                        Name: "POD_NAMESPACE",
16✔
289
                        ValueFrom: &corev1.EnvVarSource{
16✔
290
                                FieldRef: &corev1.ObjectFieldSelector{
16✔
291
                                        FieldPath: "metadata.namespace",
16✔
292
                                },
16✔
293
                        },
16✔
294
                },
16✔
295
                {
16✔
296
                        Name: "POD_NAME",
16✔
297
                        ValueFrom: &corev1.EnvVarSource{
16✔
298
                                FieldRef: &corev1.ObjectFieldSelector{
16✔
299
                                        FieldPath: "metadata.name",
16✔
300
                                },
16✔
301
                        },
16✔
302
                },
16✔
303
        }
16✔
304

16✔
305
        if r.RendererCAConfigMap != "" {
32✔
306
                volumes = append(volumes, corev1.Volume{
16✔
307
                        Name: "ca-bundle",
16✔
308
                        VolumeSource: corev1.VolumeSource{
16✔
309
                                ConfigMap: &corev1.ConfigMapVolumeSource{
16✔
310
                                        LocalObjectReference: corev1.LocalObjectReference{
16✔
311
                                                Name: r.RendererCAConfigMap,
16✔
312
                                        },
16✔
313
                                        Items: []corev1.KeyToPath{
16✔
314
                                                {
16✔
315
                                                        Key:  "trust-bundle.pem",
16✔
316
                                                        Path: "ca-bundle.pem",
16✔
317
                                                },
16✔
318
                                        },
16✔
319
                                },
16✔
320
                        },
16✔
321
                })
16✔
322
                volumeMounts = append(volumeMounts, corev1.VolumeMount{
16✔
323
                        Name:      "ca-bundle",
16✔
324
                        MountPath: "/etc/ssl/certs",
16✔
325
                        ReadOnly:  true,
16✔
326
                })
16✔
327
                envVars = append(envVars, corev1.EnvVar{
16✔
328
                        Name:  "SSL_CERT_FILE",
16✔
329
                        Value: "/etc/ssl/certs/ca-bundle.pem",
16✔
330
                })
16✔
331
        }
16✔
332

333
        pushURL := r.reference(res.Spec.BaseURL, res.Spec.Repository, res.Spec.Tag)
16✔
334

16✔
335
        job := &batchv1.Job{
16✔
336
                ObjectMeta: metav1.ObjectMeta{
16✔
337
                        Name:      jobName,
16✔
338
                        Namespace: jobKey.Namespace,
16✔
339
                        Annotations: map[string]string{
16✔
340
                                annotationJobName: jobName,
16✔
341
                        },
16✔
342
                },
16✔
343
                Spec: batchv1.JobSpec{
16✔
344
                        BackoffLimit:            &backoffLimit,
16✔
345
                        TTLSecondsAfterFinished: &ttlSecondsAfterFinished,
16✔
346
                        Template: corev1.PodTemplateSpec{
16✔
347
                                Spec: corev1.PodSpec{
16✔
348
                                        RestartPolicy: corev1.RestartPolicyNever,
16✔
349
                                        Containers: []corev1.Container{
16✔
350
                                                {
16✔
351
                                                        Name:    "renderer",
16✔
352
                                                        Image:   r.RendererImage,
16✔
353
                                                        Command: []string{r.RendererCommand},
16✔
354
                                                        Args: append(r.RendererArgs,
16✔
355
                                                                "/etc/renderer/config.json",
16✔
356
                                                                fmt.Sprintf("--url=%s", pushURL),
16✔
357
                                                        ),
16✔
358
                                                        Env:          envVars,
16✔
359
                                                        VolumeMounts: volumeMounts,
16✔
360
                                                },
16✔
361
                                        },
16✔
362
                                        Volumes: volumes,
16✔
363
                                },
16✔
364
                        },
16✔
365
                },
16✔
366
        }
16✔
367

16✔
368
        if pushSecret != nil {
32✔
369
                switch pushSecret.Type {
16✔
370
                case corev1.SecretTypeBasicAuth:
1✔
371
                        job.Spec.Template.Spec.Containers[0].Env = append(job.Spec.Template.Spec.Containers[0].Env,
1✔
372
                                corev1.EnvVar{
1✔
373
                                        Name: "REGISTRY_USERNAME",
1✔
374
                                        ValueFrom: &corev1.EnvVarSource{
1✔
375
                                                SecretKeyRef: &corev1.SecretKeySelector{
1✔
376
                                                        LocalObjectReference: corev1.LocalObjectReference{
1✔
377
                                                                Name: pushSecret.Name,
1✔
378
                                                        },
1✔
379
                                                        Key: "username",
1✔
380
                                                },
1✔
381
                                        },
1✔
382
                                },
1✔
383
                                corev1.EnvVar{
1✔
384
                                        Name: "REGISTRY_PASSWORD",
1✔
385
                                        ValueFrom: &corev1.EnvVarSource{
1✔
386
                                                SecretKeyRef: &corev1.SecretKeySelector{
1✔
387
                                                        LocalObjectReference: corev1.LocalObjectReference{
1✔
388
                                                                Name: pushSecret.Name,
1✔
389
                                                        },
1✔
390
                                                        Key: "password",
1✔
391
                                                },
1✔
392
                                        },
1✔
393
                                },
1✔
394
                        )
1✔
395

396
                case corev1.SecretTypeDockerConfigJson:
1✔
397
                        job.Spec.Template.Spec.Volumes = append(job.Spec.Template.Spec.Volumes, corev1.Volume{
1✔
398
                                Name: "dockerconfig",
1✔
399
                                VolumeSource: corev1.VolumeSource{
1✔
400
                                        Secret: &corev1.SecretVolumeSource{
1✔
401
                                                SecretName: pushSecret.Name,
1✔
402
                                                Items: []corev1.KeyToPath{
1✔
403
                                                        {
1✔
404
                                                                Key:  ".dockerconfigjson",
1✔
405
                                                                Path: "dockerconfig.json",
1✔
406
                                                        },
1✔
407
                                                },
1✔
408
                                        },
1✔
409
                                },
1✔
410
                        })
1✔
411

1✔
412
                        job.Spec.Template.Spec.Containers[0].VolumeMounts = append(job.Spec.Template.Spec.Containers[0].VolumeMounts, corev1.VolumeMount{
1✔
413
                                Name:      "dockerconfig",
1✔
414
                                MountPath: "/etc/renderer/dockerconfig.json",
1✔
415
                                SubPath:   "dockerconfig.json",
1✔
416
                                ReadOnly:  true,
1✔
417
                        })
1✔
418

1✔
419
                        job.Spec.Template.Spec.Containers[0].Env = append(job.Spec.Template.Spec.Containers[0].Env, corev1.EnvVar{
1✔
420
                                Name:  "DOCKER_CONFIG",
1✔
421
                                Value: "/etc/renderer/dockerconfig.json",
1✔
422
                        })
1✔
423
                default:
14✔
424
                }
425
        }
426

427
        // Set owner references
428
        if err := controllerutil.SetControllerReference(res, job, r.Scheme); err != nil {
16✔
429
                return errLogAndWrap(log, err, "failed to set controller reference")
×
430
        }
×
431

432
        if err := r.Create(ctx, job); err != nil {
16✔
433
                r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "CreationFailed", "Create", "Failed to create job: %s", err)
×
434

×
435
                return errLogAndWrap(log, err, "job creation failed")
×
436
        }
×
437

438
        res.Status.JobRef = &corev1.ObjectReference{
16✔
439
                APIVersion: batchv1.SchemeGroupVersion.String(),
16✔
440
                Kind:       "Job",
16✔
441
                Namespace:  job.Namespace,
16✔
442
                Name:       job.Name,
16✔
443
        }
16✔
444

16✔
445
        if err := r.Status().Update(ctx, res); err != nil {
16✔
UNCOV
446
                return errLogAndWrap(log, err, "failed to update status")
×
UNCOV
447
        }
×
448

449
        return nil
16✔
450
}
451

452
func (r *RenderTaskReconciler) createConfigSecret(ctx context.Context, res *solarv1alpha1.RenderTask, jobNS string) (*corev1.Secret, error) {
243✔
453
        log := ctrl.LoggerFrom(ctx)
243✔
454

243✔
455
        cfgJson, err := json.Marshal(res.Spec.RendererConfig)
243✔
456
        if err != nil {
243✔
457
                return nil, err
×
458
        }
×
459

460
        secretKey := r.configSecretKey(res, jobNS)
243✔
461
        secret := &corev1.Secret{
243✔
462
                ObjectMeta: metav1.ObjectMeta{
243✔
463
                        Name:      secretKey.Name,
243✔
464
                        Namespace: secretKey.Namespace,
243✔
465
                        Annotations: map[string]string{
243✔
466
                                annotationSecretName: secretKey.Name,
243✔
467
                        },
243✔
468
                },
243✔
469
                Type: corev1.SecretTypeOpaque,
243✔
470
                Data: map[string][]byte{
243✔
471
                        "config.json": cfgJson,
243✔
472
                },
243✔
473
        }
243✔
474

243✔
475
        // Set owner references
243✔
476
        if err := controllerutil.SetControllerReference(res, secret, r.Scheme); err != nil {
243✔
477
                return nil, errLogAndWrap(log, err, "failed to set controller reference")
×
478
        }
×
479

480
        if err := r.Create(ctx, secret); err != nil {
243✔
481
                r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "CreationFailed", "Create", "Failed to create secret: %s", err)
×
482

×
483
                return nil, errLogAndWrap(log, err, "secret creation failed")
×
484
        }
×
485

486
        res.Status.ConfigSecretRef = &corev1.ObjectReference{
243✔
487
                APIVersion: corev1.SchemeGroupVersion.String(),
243✔
488
                Kind:       "Secret",
243✔
489
                Namespace:  secret.Namespace,
243✔
490
                Name:       secret.Name,
243✔
491
        }
243✔
492

243✔
493
        if err := r.Status().Update(ctx, res); err != nil {
244✔
494
                return nil, errLogAndWrap(log, err, "failed to update status")
1✔
495
        }
1✔
496

497
        return secret, nil
242✔
498
}
499

500
func (r *RenderTaskReconciler) configSecretKey(res *solarv1alpha1.RenderTask, jobNS string) client.ObjectKey {
862✔
501
        return client.ObjectKey{
862✔
502
                Name:      truncateName(fmt.Sprintf("render-%s", res.Name), maxK8sLabelValueLen),
862✔
503
                Namespace: jobNS,
862✔
504
        }
862✔
505
}
862✔
506

507
func (r *RenderTaskReconciler) renderJobKey(res *solarv1alpha1.RenderTask, jobNS string) client.ObjectKey {
327✔
508
        return client.ObjectKey{
327✔
509
                Name:      truncateName(fmt.Sprintf("render-%s", res.Name), maxK8sLabelValueLen),
327✔
510
                Namespace: jobNS,
327✔
511
        }
327✔
512
}
327✔
513

514
func (r *RenderTaskReconciler) reference(baseURL, repo, tag string) string {
19✔
515
        base := baseURL
19✔
516
        if !strings.HasPrefix(base, "oci://") {
38✔
517
                base = fmt.Sprintf("oci://%s", base)
19✔
518
        }
19✔
519

520
        base = strings.TrimSuffix(base, "/")
19✔
521

19✔
522
        return fmt.Sprintf("%s/%s:%s", base, repo, tag)
19✔
523
}
524

525
func ttlSeconds(ttl *int32) int32 {
304✔
526
        if ttl != nil {
574✔
527
                return *ttl
270✔
528
        }
270✔
529

530
        return 3600
34✔
531
}
532

533
func shouldCleanupSecrets(res *solarv1alpha1.RenderTask, ttl time.Duration) bool {
268✔
534
        cond := apimeta.FindStatusCondition(res.Status.Conditions, ConditionTypeJobFailed)
268✔
535

268✔
536
        return cond != nil && time.Since(cond.LastTransitionTime.Time) >= ttl
268✔
537
}
268✔
538

539
func remainingTTL(res *solarv1alpha1.RenderTask, ttl time.Duration) time.Duration {
4✔
540
        cond := apimeta.FindStatusCondition(res.Status.Conditions, ConditionTypeJobFailed)
4✔
541
        if cond == nil {
4✔
542
                return ttl
×
543
        }
×
544

545
        remaining := ttl - time.Since(cond.LastTransitionTime.Time)
4✔
546
        if remaining < 0 {
4✔
547
                return 0
×
548
        }
×
549

550
        return remaining
4✔
551
}
552

553
func cleanupSecrets(ctx context.Context, r *RenderTaskReconciler, res *solarv1alpha1.RenderTask, jobNS string) {
267✔
554
        if err := r.deleteConfigSecret(ctx, res, jobNS); err != nil && !apierrors.IsNotFound(err) {
267✔
NEW
555
                r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "DeletionFailed", "Delete", "Failed to delete config secret: %s", err)
×
556
        }
×
557
}
558

559
func cleanupRenderResources(ctx context.Context, r *RenderTaskReconciler, res *solarv1alpha1.RenderTask, job *batchv1.Job, jobNS string) {
3✔
560
        cleanupSecrets(ctx, r, res, jobNS)
3✔
561
        if err := r.deleteRenderJob(ctx, res, jobNS); err != nil && !apierrors.IsNotFound(err) {
3✔
NEW
562
                r.Recorder.Eventf(res, job, corev1.EventTypeWarning, "DeletionFailed", "Delete", "Failed to delete job: %s", err)
×
563
        }
×
564
}
565

566
// SetupWithManager sets up the controller with the Manager.
567
func (r *RenderTaskReconciler) SetupWithManager(mgr ctrl.Manager) error {
1✔
568
        return ctrl.NewControllerManagedBy(mgr).
1✔
569
                For(&solarv1alpha1.RenderTask{}).
1✔
570
                Owns(&batchv1.Job{}).
1✔
571
                Owns(&corev1.Secret{}).
1✔
572
                Complete(r)
1✔
573
}
1✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc