kubernetes-sigs / cloud-provider-azure / 24760862859

Build # 24760862859

Build Type

push

github

Committed by web-flow

Commit Message

fix(multi-slb): support IP sharing across multiple services (#9937)

* fix(multi-slb): support IP sharing across multiple services

- Select load balancer based on where IP resides
- Block conflicting LB and IP configurations
- Block service if IP resides on an ineligible load balancer
- Block LB migration if frontend IP is shared with other services
- Reconcile multi-slb config status when using multi-slb and LB rules changed
- Clean up orphaned frontend IPs and stale LB resources during migration
- Add case-insensitive check for eligible load balancers
- Reverse load balancer loop to avoid panic after deletion

* test(multi-slb): add unit tests for IP sharing and LB migration

* test(e2e): add e2e tests for multi-slb IP sharing

* fix(multi-slb): update removeStaleServiceLBResources to return deletedPLS

* fix(multi-slb): return error from getLoadBalancerNameByPublicIP

* fix(multi-slb): address comments

- Remove error logs before returning errors per logging conventions
- Wrap errors with context using fmt.Errorf
- Return error instead of continue on isFrontendIPConfigUnsafeToDelete failure
- Add deletedLBName check before backend pool cleanup in stale path
- Use StringInSliceIgnoreCase in getMostEligibleLBForService
- Improve migration blocked message to cover other FIP reference types
- Add test case for stale resource cleanup with local service backend pool

* fix(multi-slb): skip shared probe in lbHasServiceOwnedResources

lbHasServiceOwnedResources incorrectly returned true when the LB had a
shared health probe but no service-owned rules. This caused unnecessary
calls to removeStaleServiceLBResources and reconcileMultipleStandardLoadBalancerConfigurationStatus.

Skip the shared probe in the ownership check: if the service uses it,
there must also be a service-owned rule referencing it, which the rule
check already catches. Service-specific probes are still checked as a
defensive measure against orphaned probes.

Add tests for TestLbHasService... (continued)

Coverage Stats

14529 of 19337 relevant lines covered (75.14%)

846.3 hits per line

Source File

Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available