stacklok / toolhive / 24748888455

Build # 24748888455

Build Type

push

github

Committed by web-flow

Commit Message

Add no-op companion for API Compatibility required check (#4995)

Branch protection on main requires the CRD Schema Compatibility check
to pass. The real workflow (api-compat.yml, introduced in #4980 and
refined in #4987, #4991, #4993) has a paths filter that limits it to
PRs touching cmd/thv-operator/api/**, files/crds/**, or the workflow
itself — correct in isolation, but deadlocks every PR that doesn't
touch those paths: the workflow never fires, the required check
never reports, GitHub marks it as expected-but-waiting forever, and
the PR cannot merge.

Add a companion workflow with paths-ignore set to the inverse path
list, reusing the same workflow name and job name so the check-run
context string is identical (CRD Schema Compatibility). On PRs that
don't touch the api surface, the companion runs in a few seconds,
echoes a short message, and reports success — satisfying branch
protection.

Broaden the real workflow's self-watch from .github/workflows/
api-compat.yml to .github/workflows/api-compat*.yml so edits to
either file fire the real check and keep the companion from firing
on its own edits.

Keep the paths and paths-ignore lists mutually exclusive. A path
that moves from one list needs to move from the other or the
deadlock (or a double-fire) returns.

Currently-open PRs blocked by this deadlock need to resync with
main (rebase, merge, or any fresh push) after this lands to pick
up the companion workflow. The fix does not unblock them
retroactively.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

58561 of 88443 relevant lines covered (66.21%)

62.72 hits per line

Source File

Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available