PDLPorters / pdl-graphics-plplot / 24637036594

coverage: 75.82% (+0.5%) from 75.279%
24637036594

push

github

web-flow 
Remove non-include paths from INC in pre-build checks (#17)

* Remove non-include paths from INC in pre-build checks

While trying to get `PDL::Graphics::PLplot` to install, I found it kept
telling me that it needed a plplot library compiled with the
`--with-double` option:

```
$ perl Makefile.PL
Use of uninitialized value $size in numeric eq (==) at Makefile.PL line 46.
Sizeof(PLFLT) must be 8.
PLplot must be compiled --with-double (IE ./configure --with-double).

Please either:
- Install PLplot using your package manager then reinstall Alien::PLplot
  or
- Reinstall Alien::PLplot from CPAN with environment variable
  ALIEN_INSTALL_TYPE=share.
```

After having tried the advice about reinstalling `Alien::PLplot` and
failing, and having checked that `libplplot` had been installed using
double precision, I happened to stumble upon the issue that the option
`-pthread` was appearing in the `$plplot_include_path` variable.  I
noticed this by replacing the call to `check_lib` (from
`Devel::CheckLib`) with `check_lib_or_exit`.  When using this function,
the error output was this instead:

```
$ perl Makefile.PL
INC argument badly-formed: -pthread
```

Upon reading the docs for `Devel::CheckLib`, it turns out that the `INC`
option to both `check_lib` and `check_lib_or_exit` needs to be a
space-delimited list of options, all of which start with `-I`.  Since
`-pthread` doesn't start with `-I` the argument was badly formed, hence
the `analyze_binary` callback was never called.  Thus no check code was
compiled which then resulted in `$size` being set to `undef`.  Because
`$size` was `undef`, the uninitialized value warning mentioned in the
first error message mentione above and the check for a double precision
library failed.  In other words, because `-pthread` was turning up in
the `$plplot_include_path` string, the test for a library compiled with
the `--with-double` option was failing and hence `PDL::Graphics::PLplot`
failed to install.

By filtering only fo... (continued)

4970 of 6555 relevant lines covered (75.82%)

1061.12 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

71.56
/PLplot.xs


Source Not Available

The file "PLplot.xs" isn't available on github. Either it's been removed, or the repo root directory needs to be updated.