• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

opendefensecloud / artifact-conduit / 24517958955

16 Apr 2026 03:08PM UTC coverage: 84.267% (-0.3%) from 84.591%
24517958955

push

github

web-flow
chore(deps): update dependency kubernetes-sigs/controller-tools to v0.20.1 (#284)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[kubernetes-sigs/controller-tools](https://redirect.github.com/kubernetes-sigs/controller-tools)
| minor | `v0.19.0` → `v0.20.1` |

---

### Release Notes

<details>
<summary>kubernetes-sigs/controller-tools
(kubernetes-sigs/controller-tools)</summary>

###
[`v0.20.1`](https://redirect.github.com/kubernetes-sigs/controller-tools/releases/tag/v0.20.1)

[Compare
Source](https://redirect.github.com/kubernetes-sigs/controller-tools/compare/v0.20.0...v0.20.1)

#### What's Changed

- ✨ Support nested pointer to type-aliased slices by
[@&#8203;k8s-infra-cherrypick-robot](https://redirect.github.com/k8s-infra-cherrypick-robot)
in
[#&#8203;1336](https://redirect.github.com/kubernetes-sigs/controller-tools/pull/1336)

**Full Changelog**:
<https://github.com/kubernetes-sigs/controller-tools/compare/v0.20.0...v0.20.1>

###
[`v0.20.0`](https://redirect.github.com/kubernetes-sigs/controller-tools/releases/tag/v0.20.0)

[Compare
Source](https://redirect.github.com/kubernetes-sigs/controller-tools/compare/v0.19.0...v0.20.0)

#### What's Changed

- ⚠️ Bump to k8s.io/\* v0.35.0 by
[@&#8203;sbueringer](https://redirect.github.com/sbueringer) in
[#&#8203;1318](https://redirect.github.com/kubernetes-sigs/controller-tools/pull/1318)
- ⚠️ Start from local type declaration when applying schema by
[@&#8203;JoelSpeed](https://redirect.github.com/JoelSpeed) in
[#&#8203;1270](https://redirect.github.com/kubernetes-sigs/controller-tools/pull/1270)
- ⚠️ Revert local override breaking behavioural change by
[@&#8203;JoelSpeed](https://redirect.github.com/JoelSpeed) in
[#&#8203;1310](https://redirect.github.com/kubernetes-sigs/controller-tools/pull/1310)
- ✨ Allow title to be set on a type by
[@&#8203;cbandy](https://redirect.github.com/cbandy) in
[#&#8203;1282](https://redirect.github.com/kubernetes-sigs/controller-... (continued)

782 of 928 relevant lines covered (84.27%)

557.92 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

81.36
/pkg/controller/workflow_handler.go
1
// Copyright 2025 BWI GmbH and Artifact Conduit contributors
2
// SPDX-License-Identifier: Apache-2.0
3

4
package controller
5

6
import (
7
        "context"
8
        "fmt"
9

10
        wfv1alpha1 "github.com/argoproj/argo-workflows/v3/pkg/apis/workflow/v1alpha1"
11
        "github.com/go-logr/logr"
12
        corev1 "k8s.io/api/core/v1"
13
        metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
14
        "sigs.k8s.io/controller-runtime/pkg/client"
15
        "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
16

17
        arcv1alpha1 "go.opendefense.cloud/arc/api/arc/v1alpha1"
18
)
19

20
type WorkflowHandler interface {
21
        DeleteArgoResources(ctx context.Context) error
22
        CreateArgoResources(ctx context.Context) error
23
        CheckArgoResources(ctx context.Context) error
24
}
25

26
var _ WorkflowHandler = &SingleWorkflowHandler{}
27

28
type SingleWorkflowHandler struct {
29
        *ArtifactWorkflowReconciler
30
        log logr.Logger
31
        aw  *arcv1alpha1.ArtifactWorkflow
32
}
33

34
func NewSingleWorkflowHandler(r *ArtifactWorkflowReconciler, log logr.Logger, aw *arcv1alpha1.ArtifactWorkflow) *SingleWorkflowHandler {
1,544✔
35
        return &SingleWorkflowHandler{r, log, aw}
1,544✔
36
}
1,544✔
37

38
func (h *SingleWorkflowHandler) DeleteArgoResources(ctx context.Context) error {
9✔
39
        wf := wfv1alpha1.Workflow{
9✔
40
                ObjectMeta: metav1.ObjectMeta{
9✔
41
                        Namespace: h.aw.Namespace,
9✔
42
                        Name:      h.aw.Name,
9✔
43
                },
9✔
44
        }
9✔
45
        if err := h.Delete(ctx, &wf); client.IgnoreNotFound(err) != nil {
9✔
46
                h.Recorder.Eventf(h.aw, nil, corev1.EventTypeWarning, "DeletionFailed", "Delete", fmt.Sprintf("Failed to delete associated workflow '%s': %v", h.aw.Name, err))
×
47
                return errLogAndWrap(h.log, err, "workflow deletion failed")
×
48
        }
×
49
        h.Recorder.Eventf(h.aw, nil, corev1.EventTypeNormal, "Deleted", "Delete", fmt.Sprintf("Deleted workflow '%s'", h.aw.Name))
9✔
50

9✔
51
        return nil
9✔
52
}
53

54
func (h *SingleWorkflowHandler) CreateArgoResources(ctx context.Context) error {
862✔
55
        srcSecret, dstSecret, err := h.retrieveSecrets(ctx, h.aw)
862✔
56
        if err != nil {
862✔
57
                return errLogAndWrap(h.log, err, "failed to fetch secrets for artifact workflow")
×
58
        }
×
59

60
        wf := hydrateArgoWorkflow(h.aw, srcSecret, dstSecret)
862✔
61

862✔
62
        if err := controllerutil.SetControllerReference(h.aw, wf, h.Scheme); err != nil {
862✔
63
                return errLogAndWrap(h.log, err, "failed to set controller reference")
×
64
        }
×
65

66
        if err := h.Create(ctx, wf); client.IgnoreAlreadyExists(err) != nil {
1,082✔
67
                h.Recorder.Eventf(h.aw, nil, corev1.EventTypeWarning, "CreationFailed", "Create", fmt.Sprintf("Failed to create workflow '%s': %v", wf.GetName(), err))
220✔
68
                return errLogAndWrap(h.log, err, "failed to create argo workflow")
220✔
69
        }
220✔
70
        h.Recorder.Eventf(h.aw, nil, corev1.EventTypeNormal, "Created", "Create", fmt.Sprintf("Created workflow '%s'", wf.GetName()))
642✔
71

642✔
72
        h.aw.Status.Phase = arcv1alpha1.WorkflowPending
642✔
73
        if err := h.Status().Update(ctx, h.aw); err != nil {
649✔
74
                return errLogAndWrap(h.log, err, "failed to update status")
7✔
75
        }
7✔
76

77
        return nil
635✔
78
}
79

80
func (h *SingleWorkflowHandler) CheckArgoResources(ctx context.Context) error {
638✔
81
        wf := wfv1alpha1.Workflow{}
638✔
82
        if err := h.Get(ctx, namespacedName(h.aw.Namespace, h.aw.Name), &wf); err != nil {
639✔
83
                return errLogAndWrap(h.log, err, "failed to get workflow")
1✔
84
        }
1✔
85

86
        if updated := h.setStatusFromWorkflow(ctx, h.log, h.aw, &wf); !updated {
639✔
87
                return nil // nothing updated
2✔
88
        }
2✔
89

90
        if err := h.Status().Update(ctx, h.aw); err != nil {
635✔
91
                return errLogAndWrap(h.log, err, "failed to update status")
×
92
        }
×
93

94
        return nil
635✔
95
}
96

97
var _ WorkflowHandler = &CronWorkflowHandler{}
98

99
type CronWorkflowHandler struct {
100
        *ArtifactWorkflowReconciler
101
        log logr.Logger
102
        aw  *arcv1alpha1.ArtifactWorkflow
103
}
104

105
func NewCronWorkflowHandler(r *ArtifactWorkflowReconciler, log logr.Logger, aw *arcv1alpha1.ArtifactWorkflow) *CronWorkflowHandler {
20✔
106
        return &CronWorkflowHandler{r, log, aw}
20✔
107
}
20✔
108

109
func (h *CronWorkflowHandler) DeleteArgoResources(ctx context.Context) error {
×
110
        cwf := wfv1alpha1.CronWorkflow{
×
111
                ObjectMeta: metav1.ObjectMeta{
×
112
                        Namespace: h.aw.Namespace,
×
113
                        Name:      h.aw.Name,
×
114
                },
×
115
        }
×
116
        if err := h.Delete(ctx, &cwf); client.IgnoreNotFound(err) != nil {
×
117
                h.Recorder.Eventf(h.aw, nil, corev1.EventTypeWarning, "DeletionFailed", "Delete", fmt.Sprintf("Failed to delete associated cron workflow '%s': %v", h.aw.Name, err))
×
118
                return errLogAndWrap(h.log, err, "cron workflow deletion failed")
×
119
        }
×
120
        h.Recorder.Eventf(h.aw, nil, corev1.EventTypeNormal, "Deleted", "Delete", fmt.Sprintf("Deleted cron workflow '%s'", h.aw.Name))
×
121

×
122
        return nil
×
123
}
124

125
func (h *CronWorkflowHandler) CreateArgoResources(ctx context.Context) error {
2✔
126
        srcSecret, dstSecret, err := h.retrieveSecrets(ctx, h.aw)
2✔
127
        if err != nil {
2✔
128
                return errLogAndWrap(h.log, err, "failed to fetch secrets for artifact workflow")
×
129
        }
×
130

131
        cwf := hydrateArgoCronWorkflow(h.aw, srcSecret, dstSecret)
2✔
132

2✔
133
        if err := controllerutil.SetControllerReference(h.aw, cwf, h.Scheme); err != nil {
2✔
134
                return errLogAndWrap(h.log, err, "failed to set controller reference")
×
135
        }
×
136

137
        if err := h.Create(ctx, cwf); err != nil {
2✔
138
                if client.IgnoreAlreadyExists(err) != nil {
×
139
                        h.Recorder.Eventf(h.aw, nil, corev1.EventTypeWarning, "CreationFailed", "Create", fmt.Sprintf("Failed to create cron workflow '%s': %v", cwf.GetName(), err))
×
140
                        return errLogAndWrap(h.log, err, "failed to create argo cron workflow")
×
141
                }
×
142
        } else {
2✔
143
                h.Recorder.Eventf(h.aw, nil, corev1.EventTypeNormal, "Created", "Create", fmt.Sprintf("Created cron workflow '%s'", cwf.GetName()))
2✔
144
        }
2✔
145

146
        h.aw.Status.Phase = arcv1alpha1.WorkflowPending
2✔
147
        if err := h.Status().Update(ctx, h.aw); err != nil {
2✔
148
                return errLogAndWrap(h.log, err, "failed to update status")
×
149
        }
×
150

151
        return nil
2✔
152
}
153

154
func (h *CronWorkflowHandler) CheckArgoResources(ctx context.Context) error {
16✔
155
        cwf := wfv1alpha1.CronWorkflow{}
16✔
156
        if err := h.Get(ctx, namespacedName(h.aw.Namespace, h.aw.Name), &cwf); err != nil {
16✔
157
                return errLogAndWrap(h.log, err, "failed to get cron workflow")
×
158
        }
×
159

160
        updated := false
16✔
161

16✔
162
        if !h.aw.Status.LastScheduled.Equal(cwf.Status.LastScheduledTime) {
17✔
163
                h.aw.Status.LastScheduled = cwf.Status.LastScheduledTime
1✔
164
                updated = true
1✔
165
        }
1✔
166
        if h.aw.Status.Failed != cwf.Status.Failed {
17✔
167
                h.aw.Status.Failed = cwf.Status.Failed
1✔
168
                updated = true
1✔
169
        }
1✔
170
        if h.aw.Status.Succeeded != cwf.Status.Succeeded {
17✔
171
                h.aw.Status.Succeeded = cwf.Status.Succeeded
1✔
172
                updated = true
1✔
173
        }
1✔
174

175
        // If the active workflow is not the same as the current one, update the reference
176
        if len(cwf.Status.Active) > 0 {
29✔
177
                // Should only contain a single element at most (expected to be in the same namespace!)
13✔
178
                ref := cwf.Status.Active[len(cwf.Status.Active)-1]
13✔
179

13✔
180
                if h.aw.Status.ActiveWorkflowRef.Name != ref.Name {
23✔
181
                        h.log.V(1).Info("Updating reference for cron workflow", "cronWorkflow", cwf.Name, "activeWorkflow", ref.Name)
10✔
182

10✔
183
                        // Get the active workflow
10✔
184
                        wf := wfv1alpha1.Workflow{}
10✔
185
                        if err := h.Get(ctx, namespacedName(h.aw.Namespace, ref.Name), &wf); err != nil {
10✔
186
                                return errLogAndWrap(h.log, err, "failed to fetch active workflow")
×
187
                        }
×
188

189
                        h.aw.Status.ActiveWorkflowRef = corev1.LocalObjectReference{
10✔
190
                                Name: wf.Name,
10✔
191
                        }
10✔
192
                        h.aw.Status.Message = ""
10✔
193
                        h.aw.Status.Phase = arcv1alpha1.WorkflowActive
10✔
194

10✔
195
                        updated = updated || h.setStatusFromWorkflow(ctx, h.log, h.aw, &wf)
10✔
196
                }
197
        }
198

199
        // If there is an active workflow, check its status
200
        if h.aw.Status.ActiveWorkflowRef.Name != "" {
29✔
201
                wf := wfv1alpha1.Workflow{}
13✔
202
                if err := h.Get(ctx, namespacedName(h.aw.Namespace, h.aw.Status.ActiveWorkflowRef.Name), &wf); err != nil {
13✔
203
                        return errLogAndWrap(h.log, err, "failed to fetch active workflow")
×
204
                }
×
205

206
                updated = updated || h.setStatusFromWorkflow(ctx, h.log, h.aw, &wf)
13✔
207

13✔
208
                if wf.Status.Phase.Completed() {
23✔
209
                        h.aw.Status.ActiveWorkflowRef.Name = ""
10✔
210
                        updated = true
10✔
211
                }
10✔
212
        }
213

214
        if !updated {
20✔
215
                return nil
4✔
216
        }
4✔
217

218
        h.log.V(1).Info("Updating status from active workflow", "cronWorkflow", cwf.Name)
12✔
219

12✔
220
        if err := h.Status().Update(ctx, h.aw); err != nil {
12✔
221
                return errLogAndWrap(h.log, err, "failed to update status")
×
222
        }
×
223

224
        return nil
12✔
225
}
226

227
func hydrateArgoWorkflowSpec(aw *arcv1alpha1.ArtifactWorkflow, srcSecret *corev1.Secret, dstSecret *corev1.Secret) wfv1alpha1.WorkflowSpec {
864✔
228
        srcVolume := corev1.Volume{
864✔
229
                Name: "src-secret-vol",
864✔
230
                VolumeSource: corev1.VolumeSource{
864✔
231
                        EmptyDir: &corev1.EmptyDirVolumeSource{},
864✔
232
                },
864✔
233
        }
864✔
234
        if srcSecret.Name != "" {
1,420✔
235
                srcVolume.VolumeSource = corev1.VolumeSource{
556✔
236
                        Secret: &corev1.SecretVolumeSource{
556✔
237
                                SecretName: srcSecret.Name,
556✔
238
                        },
556✔
239
                }
556✔
240
        }
556✔
241

242
        dstVolume := corev1.Volume{
864✔
243
                Name: "dst-secret-vol",
864✔
244
                VolumeSource: corev1.VolumeSource{
864✔
245
                        EmptyDir: &corev1.EmptyDirVolumeSource{},
864✔
246
                },
864✔
247
        }
864✔
248
        if dstSecret.Name != "" {
1,420✔
249
                dstVolume.VolumeSource = corev1.VolumeSource{
556✔
250
                        Secret: &corev1.SecretVolumeSource{
556✔
251
                                SecretName: dstSecret.Name,
556✔
252
                        },
556✔
253
                }
556✔
254
        }
556✔
255

256
        parameters := []wfv1alpha1.Parameter{}
864✔
257
        for _, p := range aw.Spec.Parameters {
5,645✔
258
                parameters = append(parameters, wfv1alpha1.Parameter{
4,781✔
259
                        Name:  p.Name,
4,781✔
260
                        Value: (*wfv1alpha1.AnyString)(&p.Value),
4,781✔
261
                })
4,781✔
262
        }
4,781✔
263

264
        return wfv1alpha1.WorkflowSpec{
864✔
265
                WorkflowTemplateRef: &wfv1alpha1.WorkflowTemplateRef{
864✔
266
                        Name:         aw.Spec.WorkflowTemplateRef.Name,
864✔
267
                        ClusterScope: aw.Spec.WorkflowTemplateRef.ClusterScope,
864✔
268
                },
864✔
269
                Volumes: []corev1.Volume{
864✔
270
                        srcVolume,
864✔
271
                        dstVolume,
864✔
272
                },
864✔
273
                Arguments: wfv1alpha1.Arguments{
864✔
274
                        Parameters: parameters,
864✔
275
                },
864✔
276
        }
864✔
277
}
278

279
func hydrateArgoWorkflow(aw *arcv1alpha1.ArtifactWorkflow, srcSecret *corev1.Secret, dstSecret *corev1.Secret) *wfv1alpha1.Workflow {
862✔
280
        return &wfv1alpha1.Workflow{
862✔
281
                ObjectMeta: workflowObjectMeta(aw),
862✔
282
                Spec:       hydrateArgoWorkflowSpec(aw, srcSecret, dstSecret),
862✔
283
        }
862✔
284
}
862✔
285

286
func hydrateArgoCronWorkflow(aw *arcv1alpha1.ArtifactWorkflow, srcSecret *corev1.Secret, dstSecret *corev1.Secret) *wfv1alpha1.CronWorkflow {
2✔
287
        om := workflowObjectMeta(aw)
2✔
288
        wf := &wfv1alpha1.CronWorkflow{
2✔
289
                ObjectMeta: om,
2✔
290
                Spec: wfv1alpha1.CronWorkflowSpec{
2✔
291
                        WorkflowSpec:               hydrateArgoWorkflowSpec(aw, srcSecret, dstSecret),
2✔
292
                        Schedules:                  aw.Spec.Cron.Schedules,
2✔
293
                        ConcurrencyPolicy:          wfv1alpha1.ReplaceConcurrent,
2✔
294
                        StartingDeadlineSeconds:    aw.Spec.Cron.StartingDeadlineSeconds,
2✔
295
                        Timezone:                   aw.Spec.Cron.Timezone,
2✔
296
                        When:                       aw.Spec.Cron.When,
2✔
297
                        SuccessfulJobsHistoryLimit: new(int32(1)),
2✔
298
                        FailedJobsHistoryLimit:     new(int32(1)),
2✔
299
                        WorkflowMetadata:           &om,
2✔
300
                },
2✔
301
        }
2✔
302

2✔
303
        return wf
2✔
304
}
2✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc