stacklok / toolhive / 24469088566

push

github

Split OTLP endpoint path to fix Langfuse/LangSmith integration (#4815)

* Split OTLP endpoint path to fix Langfuse/LangSmith integration

The OTLP HTTP SDK's WithEndpoint() only accepts host:port, but users
need to include a path for platforms like Langfuse and LangSmith. The
path component was being URL-encoded, breaking requests. Parse the
endpoint into host:port and path, using WithURLPath() for the path.

Fixes #4811

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address review feedback on OTLP endpoint path fix

- Strip http:// and https:// prefixes defensively in splitEndpointPath
  so the CLI path (which skips NormalizeTelemetryConfig) works correctly
- Extract "/v1/traces" and "/v1/metrics" as package-level constants
- Add test cases: bare trailing slash, scheme-prefixed endpoints
- Restore error-path coverage for metrics exporter (invalid CA cert)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Document OTLP path suffix constants with spec reference

Link to the OTLP/HTTP spec and explain why we need to append
these suffixes manually when a custom base path is provided.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

21 of 21 new or added lines in 3 files covered. (100.0%)

57228 of 87021 relevant lines covered (65.76%)

62.7 hits per line