stacklok / toolhive / 24423712742

push

github

Remove deprecated inline telemetry field from CRDs (#4819)

* Remove deprecated inline telemetry field from CRDs

The inline `telemetry` field on MCPServerSpec and MCPRemoteProxySpec,
along with the `config.telemetry`/`telemetryConfigRef` mutual-exclusivity
CEL rule on VirtualMCPServer, was deprecated in favor of TelemetryConfigRef
which references a shared MCPTelemetryConfig resource. This removes all
backward-compatibility shim code, CEL rules, deprecated utility functions,
and the TelemetryConfig/OpenTelemetryConfig CRD types ahead of the
v1beta1 API promotion.

Existing CRs using the deprecated inline telemetry field will need to
migrate to TelemetryConfigRef before upgrading.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address PR review feedback for telemetry removal

- Add stderr warning in thv export when telemetry config is detected
  but cannot be exported inline, matching the existing secrets warning
- Fix stale comment claiming CEL enforces config.telemetry /
  telemetryConfigRef mutual exclusivity (CEL rule was removed)
- Fix normalizeTelemetry doc comment to mention the config.telemetry
  fallback path used by standalone CLI deployments
- Fix stale call-site comment referencing deprecated inline Telemetry

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Stop reading Config.Telemetry in operator converter (D4)

The operator-side converter no longer falls back to Config.Telemetry
for VirtualMCPServer. Operator-managed vMCPs must use TelemetryConfigRef
to configure telemetry. The Config.Telemetry field remains valid for
standalone CLI deployments which read it directly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Regenerate CRD API reference docs

Removed deprecated TelemetryConfig, OpenTelemetryConfig, and related
inline telemetry type documentation from the generated CRD API reference.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* U... (continued)

4 of 8 new or added lines in 4 files covered. (50.0%)

57349 of 87295 relevant lines covered (65.7%)

62.71 hits per line