e1ad1ca2-a8ed-4ae0-abbb-adbf5f5ba160

Committed 14 Apr 2026 04:41PM UTC coverage: 0.454% (-95.0%) from 95.439%

Build # e1ad1ca2-a8ed-4ae0-abbb-adbf5f5ba160

Build Type

push

circleci

Committed by

web-flow

Commit Message

Remove Preservation Conservation work order type check (#5765)

Make sure description and enum is not an empty string

The specific issue appears for items in East Asian with bad data in Alma that fail the eligibility check for the Illiad service.
The problem was only revealed now after the changes in https://github.com/pulibrary/bibdata/pull/3178.

For the East Asian items the enum and description values are empty strings, so the specific  method returns that are present and not nil . The next Illiad eligibility check is the Preservation Conservation which does not exist anymore as a status label.
So the Illiad service eligibility check fails.

related to [#5755]

Coverage Stats

0 of 7 new or added lines in 4 files covered. (0.0%)

9770 existing lines in 228 files now uncovered.

46 of 10128 relevant lines covered (0.45%)

0.01 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/app/services/event_processor/delete_processor.rb

1	# frozen_string_literal: true
2
UNCOV 3	class EventProcessor	×
UNCOV 4	class DeleteProcessor < Processor	×
5	# rubocop:disable Naming/PredicateMethod
UNCOV 6	def process	×
UNCOV 7	index.delete_by_query "id:#{RSolr.solr_escape(id)}"	×
UNCOV 8	index.commit unless bulk?	×
UNCOV 9	true	×
UNCOV 10	end	×
11	# rubocop:enable Naming/PredicateMethod
UNCOV 12	end	×
UNCOV 13	end	×

pulibrary / orangelight / e1ad1ca2-a8ed-4ae0-abbb-adbf5f5ba160

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous