• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

devonfw / IDEasy / 24390630150

14 Apr 2026 09:07AM UTC coverage: 70.432% (-0.02%) from 70.455%
24390630150

Pull #1819

github

web-flow
Merge 75b7e9157 into 2a5e16034
Pull Request #1819: Soft-delete corrupted .git dir after confirmation on 'ide update'

4265 of 6696 branches covered (63.69%)

Branch coverage included in aggregate %.

11068 of 15074 relevant lines covered (73.42%)

3.09 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

80.29
cli/src/main/java/com/devonfw/tools/ide/commandlet/AbstractUpdateCommandlet.java
1
package com.devonfw.tools.ide.commandlet;
2

3
import java.io.IOException;
4
import java.nio.file.Files;
5
import java.nio.file.Path;
6
import java.util.HashSet;
7
import java.util.Iterator;
8
import java.util.List;
9
import java.util.Set;
10
import java.util.stream.Stream;
11

12
import org.slf4j.Logger;
13
import org.slf4j.LoggerFactory;
14

15
import com.devonfw.tools.ide.cli.CliException;
16
import com.devonfw.tools.ide.context.AbstractIdeContext;
17
import com.devonfw.tools.ide.context.IdeContext;
18
import com.devonfw.tools.ide.context.IdeStartContextImpl;
19
import com.devonfw.tools.ide.git.GitContext;
20
import com.devonfw.tools.ide.git.GitUrl;
21
import com.devonfw.tools.ide.git.repository.RepositoryCommandlet;
22
import com.devonfw.tools.ide.io.FileAccess;
23
import com.devonfw.tools.ide.property.FlagProperty;
24
import com.devonfw.tools.ide.property.StringProperty;
25
import com.devonfw.tools.ide.step.Step;
26
import com.devonfw.tools.ide.tool.LocalToolCommandlet;
27
import com.devonfw.tools.ide.tool.ToolCommandlet;
28
import com.devonfw.tools.ide.tool.ToolEdition;
29
import com.devonfw.tools.ide.tool.ToolEditionAndVersion;
30
import com.devonfw.tools.ide.tool.ToolInstallRequest;
31
import com.devonfw.tools.ide.tool.custom.CustomToolCommandlet;
32
import com.devonfw.tools.ide.tool.custom.CustomToolMetadata;
33
import com.devonfw.tools.ide.tool.extra.ExtraToolInstallation;
34
import com.devonfw.tools.ide.tool.extra.ExtraTools;
35
import com.devonfw.tools.ide.tool.extra.ExtraToolsMapper;
36
import com.devonfw.tools.ide.variable.IdeVariables;
37
import com.devonfw.tools.ide.version.VersionIdentifier;
38

39
/**
40
 * Abstract {@link Commandlet} base-class for both {@link UpdateCommandlet} and {@link CreateCommandlet}.
41
 */
42
public abstract class AbstractUpdateCommandlet extends Commandlet {
43

44
  private static final Logger LOG = LoggerFactory.getLogger(AbstractUpdateCommandlet.class);
4✔
45

46
  private static final String MESSAGE_CODE_REPO_URL = """
47
      No code repository was given after '--code'.
48
      Further details can be found here: https://github.com/devonfw/IDEasy/blob/main/documentation/settings.adoc
49
      Please enter the code repository below that includes your settings folder.""";
50

51
  private static final String MESSAGE_SETTINGS_REPO_URL = """
52
      No settings found at {} and no SETTINGS_URL is defined.
53
      Further details can be found here: https://github.com/devonfw/IDEasy/blob/main/documentation/settings.adoc
54
      Please contact the technical lead of your project to get the SETTINGS_URL for your project to enter.
55
      In case you just want to test IDEasy you may simply hit return to install the default settings.""";
56

57
  /** {@link StringProperty} for the settings repository URL. */
58
  public final StringProperty settingsRepo;
59

60
  /** {@link FlagProperty} for skipping installation/updating of tools. */
61
  public final FlagProperty skipTools;
62

63
  /** {@link FlagProperty} for skipping the setup of git repositories. */
64
  public final FlagProperty skipRepositories;
65

66
  /** {@link FlagProperty} to force the update of the settings git repository. */
67
  public final FlagProperty forcePull;
68

69
  /** {@link FlagProperty} to force the installation/update of plugins. */
70
  public final FlagProperty forcePlugins;
71

72
  /** {@link FlagProperty} to force the setup of git repositories. */
73
  public final FlagProperty forceRepositories;
74

75
  /**
76
   * The constructor.
77
   *
78
   * @param context the {@link IdeContext}.
79
   */
80
  public AbstractUpdateCommandlet(IdeContext context) {
81

82
    super(context);
3✔
83
    addKeyword(getName());
4✔
84
    this.skipTools = add(new FlagProperty("--skip-tools"));
9✔
85
    this.skipRepositories = add(new FlagProperty("--skip-repositories"));
9✔
86
    this.forcePull = add(new FlagProperty("--force-pull"));
9✔
87
    this.forcePlugins = add(new FlagProperty("--force-plugins"));
9✔
88
    this.forceRepositories = add(new FlagProperty("--force-repositories"));
9✔
89
    this.settingsRepo = new StringProperty("", false, "settingsRepository");
8✔
90
  }
1✔
91

92
  @Override
93
  protected void doRun() {
94

95
    IdeStartContextImpl startContext = ((AbstractIdeContext) this.context).getStartContext();
5✔
96
    startContext.setForcePull(forcePull.isTrue());
5✔
97
    startContext.setForcePlugins(forcePlugins.isTrue());
5✔
98
    startContext.setForceRepositories(forceRepositories.isTrue());
5✔
99

100
    if (!this.context.isSettingsRepositorySymlinkOrJunction() || this.context.isForceMode() || forcePull.isTrue()) {
4!
101
      updateSettings();
2✔
102
    }
103
    updateConf();
2✔
104
    reloadContext();
2✔
105

106
    updateSoftware();
2✔
107
    updateRepositories();
2✔
108
    createStartScripts();
2✔
109
  }
1✔
110

111
  private void reloadContext() {
112

113
    ((AbstractIdeContext) this.context).reload();
4✔
114
  }
1✔
115

116
  private void updateConf() {
117

118
    Path templatesFolder = this.context.getSettingsPath().resolve(IdeContext.FOLDER_TEMPLATES);
6✔
119
    if (!Files.exists(templatesFolder)) {
5✔
120
      Path legacyTemplatesFolder = this.context.getSettingsPath().resolve(IdeContext.FOLDER_LEGACY_TEMPLATES);
6✔
121
      if (Files.exists(legacyTemplatesFolder)) {
5!
122
        templatesFolder = legacyTemplatesFolder;
×
123
      } else {
124
        LOG.warn("Templates folder is missing in settings repository.");
3✔
125
        return;
1✔
126
      }
127
    }
128

129
    Step step = this.context.newStep("Copy configuration templates", templatesFolder);
11✔
130
    final Path finalTemplatesFolder = templatesFolder;
2✔
131
    step.run(() -> setupConf(finalTemplatesFolder, this.context.getIdeHome()));
13✔
132
  }
1✔
133

134
  private void setupConf(Path template, Path conf) {
135

136
    List<Path> children = this.context.getFileAccess().listChildren(template, f -> true);
9✔
137
    for (Path child : children) {
10✔
138

139
      String basename = child.getFileName().toString();
4✔
140
      Path confPath = conf.resolve(basename);
4✔
141

142
      if (Files.isDirectory(child)) {
5✔
143
        if (!Files.isDirectory(confPath)) {
5!
144
          this.context.getFileAccess().mkdirs(confPath);
5✔
145
        }
146
        setupConf(child, confPath);
5✔
147
      } else if (Files.isRegularFile(child)) {
5!
148
        if (Files.isRegularFile(confPath)) {
5!
149
          LOG.debug("Configuration {} already exists - skipping to copy from {}", confPath, child);
×
150
        } else {
151
          if (!basename.equals("settings.xml")) {
4!
152
            LOG.info("Copying template {} to {}.", child, conf);
5✔
153
            this.context.getFileAccess().copy(child, conf);
6✔
154
          }
155
        }
156
      }
157
    }
1✔
158
  }
1✔
159

160
  /**
161
   * Updates the settings repository in IDE_HOME/settings by either cloning if no such repository exists or pulling if the repository exists then saves the
162
   * latest current commit ID in the file ".commit.id".
163
   */
164
  protected void updateSettings() {
165

166
    this.context.newStep(getStepMessage()).run(this::updateSettingsInStep);
9✔
167
  }
1✔
168

169
  protected String getStepMessage() {
170

171
    return "update (pull) settings repository";
2✔
172
  }
173

174
  private void updateSettingsInStep() {
175
    Path settingsPath = this.context.getSettingsPath();
4✔
176
    GitContext gitContext = this.context.getGitContext();
4✔
177
    // here we do not use pullOrClone to prevent asking a pointless question for repository URL...
178
    if (Files.isDirectory(settingsPath) && !this.context.getFileAccess().isEmptyDir(settingsPath)) {
11!
179
      if (this.context.isForcePull() || this.context.isForceMode() || Files.isDirectory(settingsPath.resolve(GitContext.GIT_FOLDER))) {
15!
180
        if (gitContext.hasUntrackedFiles(settingsPath)) {
×
181
          gitContext.pullSafelyWithStash(settingsPath);
×
182
        } else {
183
          gitContext.pull(settingsPath);
×
184
        }
185
        this.context.getGitContext().saveCurrentCommitId(settingsPath, this.context.getSettingsCommitIdPath());
×
186
      } else {
187
        LOG.info("Skipping git pull in settings due to code repository. Use --force-pull to enforce pulling.");
4✔
188
      }
189
    } else {
190
      if (!this.context.getFileAccess().isEmptyDir(settingsPath)) {
6!
191
        String answer =
×
192
          this.context.askForInput(
×
193
            "Your settings repository can be updated, but this will override local changes. The "
194
            + "settings contents will be backed up. Do you want to proceed?",
195
            "Y/n"
196
          );
197

198
        if (answer.toLowerCase().equals("n")) {
×
199
          return;
×
200
        }
201

202
        this.context.getFileAccess().backup(settingsPath);
×
203
      }
204

205
      GitUrl gitUrl = getOrAskSettingsUrl();
3✔
206
      checkProjectNameConvention(gitUrl.getProjectName());
4✔
207
      initializeRepository(gitUrl);
3✔
208
    }
209
  }
1✔
210

211
  private GitUrl getOrAskSettingsUrl() {
212

213
    String repository = this.settingsRepo.getValue();
5✔
214
    repository = handleDefaultRepository(repository);
4✔
215
    String userPromt;
216
    String defaultUrl;
217
    if (isCodeRepository()) {
3✔
218
      userPromt = "Code repository URL:";
2✔
219
      defaultUrl = null;
2✔
220
      LOG.info(MESSAGE_CODE_REPO_URL);
4✔
221
    } else {
222
      userPromt = "Settings URL [" + IdeContext.DEFAULT_SETTINGS_REPO_URL + "]:";
2✔
223
      defaultUrl = IdeContext.DEFAULT_SETTINGS_REPO_URL;
2✔
224
      LOG.info(MESSAGE_SETTINGS_REPO_URL, this.context.getSettingsPath());
6✔
225
    }
226
    GitUrl gitUrl = null;
2✔
227
    if (repository != null) {
2✔
228
      gitUrl = GitUrl.of(repository);
3✔
229
    }
230
    while ((gitUrl == null) || !gitUrl.isValid()) {
5!
231
      repository = this.context.askForInput(userPromt, defaultUrl);
6✔
232
      repository = handleDefaultRepository(repository);
4✔
233
      gitUrl = GitUrl.of(repository);
3✔
234
      if (!gitUrl.isValid()) {
3!
235
        LOG.warn("The input URL is not valid, please try again.");
×
236
      }
237
    }
238
    return gitUrl;
2✔
239
  }
240

241
  private String handleDefaultRepository(String repository) {
242
    if ("-".equals(repository)) {
4✔
243
      if (isCodeRepository()) {
3✔
244
        LOG.warn("'-' is found after '--code'. This is invalid.");
3✔
245
        repository = null;
3✔
246
      } else {
247
        LOG.info("'-' was found for settings repository, the default settings repository '{}' will be used.", IdeContext.DEFAULT_SETTINGS_REPO_URL);
4✔
248
        repository = IdeContext.DEFAULT_SETTINGS_REPO_URL;
2✔
249
      }
250
    }
251
    return repository;
2✔
252
  }
253

254
  private void checkProjectNameConvention(String projectName) {
255
    boolean isSettingsRepo = projectName.contains(IdeContext.SETTINGS_REPOSITORY_KEYWORD);
4✔
256
    boolean codeRepository = isCodeRepository();
3✔
257
    if (isSettingsRepo == codeRepository) {
3✔
258
      String warningTemplate;
259
      if (codeRepository) {
2✔
260
        warningTemplate = """
3✔
261
            Your git URL is pointing to the project name {} that contains the keyword '{}'.
262
            Therefore we assume that you did a mistake by adding the '--code' option to the ide project creation.
263
            Do you really want to create the project?""";
264
      } else {
265
        warningTemplate = """
2✔
266
            Your git URL is pointing to the project name {} that does not contain the keyword ''{}''.
267
            Therefore we assume that you forgot to add the '--code' option to the ide project creation.
268
            Do you really want to create the project?""";
269
      }
270
      this.context.askToContinue(warningTemplate, projectName, IdeContext.SETTINGS_REPOSITORY_KEYWORD);
14✔
271
    }
272
  }
1✔
273

274
  private void initializeRepository(GitUrl gitUrl) {
275

276
    GitContext gitContext = this.context.getGitContext();
4✔
277
    Path settingsPath = this.context.getSettingsPath();
4✔
278
    Path repoPath = settingsPath;
2✔
279
    boolean codeRepository = isCodeRepository();
3✔
280
    if (codeRepository) {
2✔
281
      // clone the given code repository into IDE_HOME/workspaces/main
282
      repoPath = context.getWorkspacePath().resolve(gitUrl.getProjectName());
7✔
283
    }
284
    gitContext.pullOrClone(gitUrl, repoPath);
4✔
285
    if (codeRepository) {
2✔
286
      // check for settings folder and create symlink to IDE_HOME/settings
287
      Path settingsFolder = repoPath.resolve(IdeContext.FOLDER_SETTINGS);
4✔
288
      if (Files.exists(settingsFolder)) {
5!
289
        context.getFileAccess().symlink(settingsFolder, settingsPath);
×
290
      } else {
291
        throw new CliException("Invalid code repository " + gitUrl + ": missing a settings folder at " + settingsFolder);
9✔
292
      }
293
    }
294
    this.context.getGitContext().saveCurrentCommitId(settingsPath, this.context.getSettingsCommitIdPath());
8✔
295
  }
1✔
296

297

298
  private void updateSoftware() {
299

300
    if (this.skipTools.isTrue()) {
4✔
301
      LOG.info("Skipping installation/update of tools as specified by the user.");
3✔
302
      return;
1✔
303
    }
304
    Step step = this.context.newStep("Install or update software");
5✔
305
    step.run(() -> doUpdateSoftwareStep(step));
10✔
306
  }
1✔
307

308
  private void doUpdateSoftwareStep(Step step) {
309

310
    Set<ToolCommandlet> toolCommandlets = new HashSet<>();
4✔
311
    CommandletManager commandletManager = this.context.getCommandletManager();
4✔
312
    // installed tools in IDE_HOME/software
313
    List<Path> softwarePaths = this.context.getFileAccess().listChildren(this.context.getSoftwarePath(), Files::isDirectory);
14✔
314
    for (Path softwarePath : softwarePaths) {
10✔
315
      String toolName = softwarePath.getFileName().toString();
4✔
316
      ToolCommandlet toolCommandlet = commandletManager.getToolCommandlet(toolName);
4✔
317
      if (toolCommandlet != null) {
2!
318
        toolCommandlets.add(toolCommandlet);
4✔
319
      }
320
    }
1✔
321

322
    // regular tools in $IDE_TOOLS
323
    List<String> regularTools = IdeVariables.IDE_TOOLS.get(this.context);
6✔
324
    if (regularTools != null) {
2!
325
      for (String regularTool : regularTools) {
10✔
326
        ToolCommandlet toolCommandlet = commandletManager.getToolCommandlet(regularTool);
4✔
327
        if (toolCommandlet == null) {
2!
328
          String displayName = (regularTool == null || regularTool.isBlank()) ? "<empty>" : "'" + regularTool + "'";
×
329
          LOG.error("Cannot install or update tool '{}''. No matching commandlet found. Please check your IDE_TOOLS configuration.", displayName);
×
330
        } else {
×
331
          toolCommandlets.add(toolCommandlet);
4✔
332
        }
333
      }
1✔
334
    }
335

336
    // custom tools in ide-custom-tools.json
337
    for (CustomToolMetadata customTool : this.context.getCustomToolRepository().getTools()) {
9!
338
      CustomToolCommandlet customToolCommandlet = new CustomToolCommandlet(this.context, customTool);
×
339
      toolCommandlets.add(customToolCommandlet);
×
340
    }
×
341

342
    // update/install the toolCommandlets
343
    for (ToolCommandlet toolCommandlet : toolCommandlets) {
10✔
344
      this.context.newStep("Install " + toolCommandlet.getName()).run(() -> toolCommandlet.install(false));
15✔
345
    }
1✔
346

347
    ExtraTools extraTools = ExtraToolsMapper.get().loadJsonFromFolder(this.context.getSettingsPath());
7✔
348
    if (extraTools != null) {
2✔
349
      List<String> toolNames = extraTools.getSortedToolNames();
3✔
350
      LOG.info("Found extra installation of the following tools: {}", toolNames);
4✔
351
      for (String tool : toolNames) {
10✔
352
        List<ExtraToolInstallation> installations = extraTools.getExtraInstallations(tool);
4✔
353
        this.context.newStep("Install extra version(s) of " + tool).run(() -> installExtraToolInstallations(tool, installations));
16✔
354
      }
1✔
355
    }
356
  }
1✔
357

358
  private void installExtraToolInstallations(String tool, List<ExtraToolInstallation> extraInstallations) {
359

360
    CommandletManager commandletManager = this.context.getCommandletManager();
4✔
361
    FileAccess fileAccess = this.context.getFileAccess();
4✔
362
    Path extraPath = this.context.getSoftwareExtraPath();
4✔
363
    LocalToolCommandlet toolCommandlet = commandletManager.getRequiredLocalToolCommandlet(tool);
4✔
364
    for (ExtraToolInstallation extraInstallation : extraInstallations) {
10✔
365
      ToolInstallRequest request = new ToolInstallRequest(false);
5✔
366
      String edition = extraInstallation.edition();
3✔
367
      if (edition == null) {
2✔
368
        edition = toolCommandlet.getConfiguredEdition();
3✔
369
      }
370
      ToolEdition toolEdition = new ToolEdition(tool, edition);
6✔
371
      VersionIdentifier version = extraInstallation.version();
3✔
372
      request.setRequested(new ToolEditionAndVersion(toolEdition, version));
7✔
373
      Path extraToolPath = extraPath.resolve(tool);
4✔
374
      Path toolPath = extraToolPath.resolve(extraInstallation.name());
5✔
375
      request.setToolPathForExtraInstallation(toolPath);
3✔
376
      toolCommandlet.install(request);
4✔
377
    }
1✔
378
  }
1✔
379

380
  private void updateRepositories() {
381

382
    if (this.skipRepositories.isTrue()) {
4!
383
      if (this.forceRepositories.isTrue()) {
×
384
        LOG.warn("Options to skip and force repositories are incompatible and should not be combined. Ignoring --force-repositories to proceed.");
×
385
      }
386
      LOG.info("Skipping setup of repositories as specified by the user.");
×
387
      return;
×
388
    }
389
    RepositoryCommandlet repositoryCommandlet = this.context.getCommandletManager().getCommandlet(RepositoryCommandlet.class);
7✔
390
    repositoryCommandlet.reset();
2✔
391
    repositoryCommandlet.run();
2✔
392
  }
1✔
393

394
  private void createStartScripts() {
395

396
    List<String> ides = IdeVariables.CREATE_START_SCRIPTS.get(this.context);
6✔
397
    if (ides == null) {
2✔
398
      LOG.info("Variable CREATE_START_SCRIPTS is undefined - skipping start script creation.");
3✔
399
      return;
1✔
400
    }
401
    for (String ide : ides) {
10✔
402
      ToolCommandlet tool = this.context.getCommandletManager().getToolCommandlet(ide);
6✔
403
      if (tool == null) {
2!
404
        LOG.error("Undefined IDE '{}' configured in variable CREATE_START_SCRIPTS.", ide);
×
405
      } else {
406
        createStartScript(ide);
3✔
407
      }
408
    }
1✔
409
  }
1✔
410

411
  private void createStartScript(String ide) {
412

413
    LOG.info("Creating start scripts for {}", ide);
4✔
414
    Path workspaces = this.context.getIdeHome().resolve(IdeContext.FOLDER_WORKSPACES);
6✔
415
    try (Stream<Path> childStream = Files.list(workspaces)) {
3✔
416
      Iterator<Path> iterator = childStream.iterator();
3✔
417
      while (iterator.hasNext()) {
3✔
418
        Path child = iterator.next();
4✔
419
        if (Files.isDirectory(child)) {
5!
420
          createStartScript(ide, child.getFileName().toString());
6✔
421
        }
422
      }
1✔
423
    } catch (IOException e) {
×
424
      throw new RuntimeException("Failed to list children of directory " + workspaces, e);
×
425
    }
1✔
426
  }
1✔
427

428
  private void createStartScript(String ide, String workspace) {
429

430
    Path ideHome = this.context.getIdeHome();
4✔
431
    String scriptName = ide + "-" + workspace;
4✔
432
    boolean windows = this.context.getSystemInfo().isWindows();
5✔
433
    if (windows) {
2!
434
      scriptName = scriptName + ".bat";
×
435
    } else {
436
      scriptName = scriptName + ".sh";
3✔
437
    }
438
    Path scriptPath = ideHome.resolve(scriptName);
4✔
439
    if (Files.exists(scriptPath)) {
5!
440
      return;
×
441
    }
442
    String scriptContent;
443
    if (windows) {
2!
444
      scriptContent = "@echo off\r\n" + "pushd %~dp0\r\n" + "cd workspaces/" + workspace + "\r\n" + "call ide " + ide + "\r\n" + "popd\r\n";
×
445
    } else {
446
      scriptContent = "#!/usr/bin/env bash\n" + "cd \"$(dirname \"$0\")\"\n" + "cd workspaces/" + workspace + "\n" + "ideasy " + ide + "\n";
4✔
447
    }
448
    FileAccess fileAccess = this.context.getFileAccess();
4✔
449
    fileAccess.writeFileContent(scriptContent, scriptPath);
4✔
450
    fileAccess.makeExecutable(scriptPath);
3✔
451
  }
1✔
452

453
  /**
454
   * Judge if the repository is a code repository.
455
   *
456
   * @return true when the repository is a code repository, otherwise false.
457
   */
458
  protected boolean isCodeRepository() {
459
    return false;
2✔
460
  }
461

462
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc