24277709975

Committed 11 Apr 2026 07:31AM UTC coverage: 46.576% (+0.01%) from 46.562%

Build # 24277709975

Build Type

Pull #426

github

Committed by

web-flow

Commit Message

Merge 2bd7e76b0 into 0e96e47b7

Pull Request Pull Request #426: FIXES TODO in callbacks: implement strict validation for all payment callbacks

Coverage Stats

406 of 985 branches covered (41.22%)

Branch coverage included in aggregate %.

21 of 52 new or added lines in 8 files covered. (40.38%)

4 existing lines in 3 files now uncovered.

1240 of 2549 relevant lines covered (48.65%)

9.07 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

18.42

/src/controllers/callbacks/opennode-callback-controller.ts

import { Request, Response } from 'express'

import { Invoice, InvoiceStatus } from '../../@types/invoice'
import { createLogger } from '../../factories/logger-factory'
import { fromOpenNodeInvoice } from '../../utils/transform'
import { IController } from '../../@types/controllers'
import { IPaymentsService } from '../../@types/services'
import { opennodeCallbackBodySchema } from '../../schemas/opennode-callback-schema'
import { validateSchema } from '../../utils/validation'

const debug = createLogger('opennode-callback-controller')

export class OpenNodeCallbackController implements IController {
  public constructor(
    private readonly paymentsService: IPaymentsService,
  ) {}

  public async handleRequest(
    request: Request,
    response: Response,
  ) {
    debug('request headers: %o', request.headers)
    debug('request body: %O', request.body)

    const bodyValidation = validateSchema(opennodeCallbackBodySchema)(request.body)
    if (bodyValidation.error) {
      debug('opennode callback request rejected: invalid body %o', bodyValidation.error)
      response
        .status(400)
        .setHeader('content-type', 'text/plain; charset=utf8')
        .send('Malformed body')
      return
    }

    const invoice = fromOpenNodeInvoice(request.body)

    debug('invoice', invoice)

    let updatedInvoice: Invoice
    try {
      updatedInvoice = await this.paymentsService.updateInvoiceStatus(invoice)
    } catch (error) {
      console.error(`Unable to persist invoice ${invoice.id}`, error)

      throw error
    }

    if (
      updatedInvoice.status !== InvoiceStatus.COMPLETED
      && !updatedInvoice.confirmedAt
    ) {
      response
        .status(200)
        .send()

      return
    }

    invoice.amountPaid = invoice.amountRequested
    updatedInvoice.amountPaid = invoice.amountRequested

    try {
      await this.paymentsService.confirmInvoice({
        id: invoice.id,
        pubkey: invoice.pubkey,
        status: updatedInvoice.status,
        amountPaid: updatedInvoice.amountRequested,
        confirmedAt: updatedInvoice.confirmedAt,
      })
      await this.paymentsService.sendInvoiceUpdateNotification(updatedInvoice)
    } catch (error) {
      console.error(`Unable to confirm invoice ${invoice.id}`, error)

      throw error
    }

    response
      .status(200)
      .setHeader('content-type', 'text/plain; charset=utf8')
      .send('OK')
  }
}

1	import { Request, Response } from 'express'
2
3	import { Invoice, InvoiceStatus } from '../../@types/invoice'	2✔
4	import { createLogger } from '../../factories/logger-factory'	2✔
5	import { fromOpenNodeInvoice } from '../../utils/transform'	2✔
6	import { IController } from '../../@types/controllers'
7	import { IPaymentsService } from '../../@types/services'
8	import { opennodeCallbackBodySchema } from '../../schemas/opennode-callback-schema'	2✔
9	import { validateSchema } from '../../utils/validation'	2✔
10
11	const debug = createLogger('opennode-callback-controller')	2✔
12
13	export class OpenNodeCallbackController implements IController {	2✔
14	public constructor(
15	private readonly paymentsService: IPaymentsService,	×
16	) {}
17
18	public async handleRequest(
19	request: Request,
20	response: Response,
21	) {
22	debug('request headers: %o', request.headers)	×
23	debug('request body: %O', request.body)	×
24
NEW 25	const bodyValidation = validateSchema(opennodeCallbackBodySchema)(request.body)	×
NEW 26	if (bodyValidation.error) {	×
NEW 27	debug('opennode callback request rejected: invalid body %o', bodyValidation.error)	×
NEW 28	response	×
29	.status(400)
30	.setHeader('content-type', 'text/plain; charset=utf8')
31	.send('Malformed body')
NEW 32	return	×
33	}
34
UNCOV 35	const invoice = fromOpenNodeInvoice(request.body)	×
36
37	debug('invoice', invoice)	×
38
39	let updatedInvoice: Invoice
40	try {	×
41	updatedInvoice = await this.paymentsService.updateInvoiceStatus(invoice)	×
42	} catch (error) {
43	console.error(`Unable to persist invoice ${invoice.id}`, error)	×
44
45	throw error	×
46	}
47
48	if (	×
49	updatedInvoice.status !== InvoiceStatus.COMPLETED	×
50	&& !updatedInvoice.confirmedAt
51	) {
52	response	×
53	.status(200)
54	.send()
55
56	return	×
57	}
58
59	invoice.amountPaid = invoice.amountRequested	×
60	updatedInvoice.amountPaid = invoice.amountRequested	×
61
62	try {	×
63	await this.paymentsService.confirmInvoice({	×
64	id: invoice.id,
65	pubkey: invoice.pubkey,
66	status: updatedInvoice.status,
67	amountPaid: updatedInvoice.amountRequested,
68	confirmedAt: updatedInvoice.confirmedAt,
69	})
70	await this.paymentsService.sendInvoiceUpdateNotification(updatedInvoice)	×
71	} catch (error) {
72	console.error(`Unable to confirm invoice ${invoice.id}`, error)	×
73
74	throw error	×
75	}
76
77	response	×
78	.status(200)
79	.setHeader('content-type', 'text/plain; charset=utf8')
80	.send('OK')
81	}
82	}

cameri / nostream / 24277709975

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous