24191725472

Committed 09 Apr 2026 01:04PM UTC coverage: 65.058% (+0.05%) from 65.01%

Build # 24191725472

Build Type

push

github

Committed by

web-flow

Commit Message

Coerce types for non-advertised backend tools in composite workflows (#4671)

When backend tools are excluded from advertising via `excludeAll` or
`filter`, the workflow engine could not find their `InputSchema` for
argument type coercion. This caused string arguments (e.g. "42") to be
forwarded to the backend as-is instead of being coerced to the correct
type (e.g. float64(42)), resulting in backend rejection.

Root cause: `ProcessPreQueriedCapabilities` only returned the advertised
tool list. Sessions stored only those tools, and the workflow engine
used `sess.Tools()` for schema lookup — so hidden tools were invisible
to it.

Fix:
- `ProcessPreQueriedCapabilities` now returns both `advertisedTools`
  (filtered, for MCP clients) and `allResolvedTools` (every resolved
  tool regardless of filter, for internal schema lookup).
- `MultiSession` gains `AllTools() []vmcp.Tool`, backed by the new
  `allTools` field on `defaultMultiSession`.
- The per-session workflow engine is built from `sess.AllTools()` so it
  can coerce arguments for any backend tool, whether advertised or not.

Fixes #4287

Co-authored-by: taskbot <taskbot@users.noreply.github.com>

Coverage Stats

44 of 51 new or added lines in 6 files covered. (86.27%)

11 existing lines in 5 files now uncovered.

55706 of 85625 relevant lines covered (65.06%)

62.63 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

79.38

/pkg/transport/proxy/httpsse/http_proxy.go

Build SHA Not Found

The commit SHA "ccad93aeeb7389c56ad6e2a1058fec72cedb5484" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

stacklok / toolhive / 24191725472

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous