24128148165

Committed 08 Apr 2026 09:25AM UTC coverage: 0.589% (+0.001%) from 0.588%

Build # 24128148165

Build Type

Pull #27

github

Committed by

web-flow

Commit Message

Merge 75d3773fe into 5b588bea0

Pull Request Pull Request #27: [TASK] Revert default passthrough handling on unconfigured renderables

Coverage Stats

7 of 1189 relevant lines covered (0.59%)

0.02 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/Classes/ContentObject/RenderablesContentObject.php

<?php

declare(strict_types=1);

/*
 * This file is part of the TYPO3 CMS extension "handlebars_forms".
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

namespace CPSIT\Typo3HandlebarsForms\ContentObject;

use CPSIT\Typo3HandlebarsForms\Domain;
use Symfony\Component\DependencyInjection;
use TYPO3\CMS\Fluid;
use TYPO3\CMS\Form;

/**
 * RenderablesContentObject
 *
 * @author Elias Häußler <e.haeussler@familie-redlich.de>
 * @license GPL-2.0-or-later
 */
#[DependencyInjection\Attribute\AutoconfigureTag('frontend.contentobject', ['identifier' => 'HBS_RENDERABLES'])]
final class RenderablesContentObject extends AbstractHandlebarsFormsContentObject
{
    private const IDENTIFIER_COUNT = 'HBS_RENDERABLES_COUNT';
    private const IDENTIFIER_CURRENT = 'HBS_RENDERABLES_CURRENT';

    /**
     * @param iterable<Domain\ViewModel\Builder\ViewModelBuilder<Form\Domain\Model\Renderable\RootRenderableInterface>> $viewModelBuilders
     */
    public function __construct(
        #[DependencyInjection\Attribute\AutowireIterator('handlebars_forms.view_model_builder')]
        private readonly iterable $viewModelBuilders,
    ) {}

    /**
     * @return list<mixed>
     */
    protected function resolve(array $configuration, Context\ValueResolutionContext $context): array
    {
        $baseRenderable = $renderable = $context->renderable;
        $processedRenderables = [];

        // Use current page as base renderable if we're on root form context
        if ($baseRenderable instanceof Form\Domain\Runtime\FormRuntime) {
            $renderable = $baseRenderable->getCurrentPage() ?? $baseRenderable;
        }

        // Fetch renderables from base renderable:
        // - On summary pages, the base renderable defines the selection of renderables:
        //   + If the incoming renderable is the summary page, we use ALL ELEMENTS of the configured form.
        //   + If the incoming renderable is the root form, we explicitly render the summary page renderable
        //     to allow further configuration of this specific page type. In TypoScript, the form renderables may
        //     still be rendered for summary pages by using a combination of HBS_RENDERABLES objects for form & page:
        //       formData {
        //         items = HBS_RENDERABLES
        //         items {
        //           # ...
        //           SummaryPage {
        //             elements = HBS_RENDERABLES
        //             elements {
        //               Text { ... }
        //               # ...
        //             }
        //           }
        //         }
        //       }
        // - On default sections (e.g. non-summary pages), this reflects all direct children.
        // - On all other composite renderables, this reflects all renderables recursively (including deeply nested
        //   renderables).
        // - If we have a non-composite base renderable in place, we do nothing since this value resolver only handles
        //   composite renderables.
        if ($baseRenderable instanceof Form\Domain\Model\FormElements\Page && $baseRenderable->getType() === 'SummaryPage') {
            $renderables = array_filter(
                $baseRenderable->getRootForm()->getRenderablesRecursively(),
                $this->isElement(...),
            );
        } elseif ($renderable instanceof Form\Domain\Model\FormElements\Page && $renderable->getType() === 'SummaryPage') {
            $renderables = [$renderable];
        } elseif ($renderable instanceof Form\Domain\Model\FormElements\AbstractSection) {
            $renderables = $renderable->getElements();
        } elseif ($renderable instanceof Form\Domain\Model\Renderable\CompositeRenderableInterface) {
            $renderables = $renderable->getRenderablesRecursively();
        } else {
            $renderables = [];
        }

        // Add renderables count to TSFE register
        // @todo Use $this->request->getAttribute('frontend.register.stack') in TYPO3 v14
        $tsfe = $this->getTypoScriptFrontendController();
        $tsfe->register[self::IDENTIFIER_COUNT] = count($renderables);

        foreach ($renderables as $index => $child) {
            if (!$this->isEnabled($child)) {
                continue;
            }

            if (array_key_exists($child->getType() . '.', $configuration)) {
                // Use configured type-specific configuration (e.g. "Fieldset." for fieldsets)
                $childConfiguration = $configuration[$child->getType() . '.'];
            } elseif (!array_key_exists('default.', $configuration)) {
                // Skip rendering on missing fallback config
                continue;
            } else {
                // Use configured fallback configuration ("default.")
                $childConfiguration = $configuration['default.'];
            }

            if (is_array($childConfiguration)) {
                $childViewModel = $this->buildViewModel($child, $context->renderingContext);
            } else {
                $childConfiguration = [];
                $childViewModel = new Domain\ViewModel\SimpleViewModel($child);
            }

            // Add current renderable index to TSFE register
            $tsfe->register[self::IDENTIFIER_CURRENT] = $index;

            try {
                $processedChild = $context->process($childConfiguration, $child, $childViewModel);
            } finally {
                unset($tsfe->register[self::IDENTIFIER_CURRENT]);
            }

            if ($processedChild !== null) {
                $processedRenderables[] = $processedChild;
            }
        }

        unset($tsfe->register[self::IDENTIFIER_COUNT]);

        return $processedRenderables;
    }

    private function buildViewModel(
        Form\Domain\Model\Renderable\RootRenderableInterface $renderable,
        Fluid\Core\Rendering\RenderingContext $renderingContext,
    ): Domain\ViewModel\ViewModel {
        foreach ($this->viewModelBuilders as $viewModelBuilder) {
            if ($viewModelBuilder->supports($renderable)) {
                return $viewModelBuilder->build($renderable, $renderingContext);
            }
        }

        return new Domain\ViewModel\SimpleViewModel($renderable);
    }

    private function isElement(Form\Domain\Model\Renderable\RenderableInterface $renderable): bool
    {
        return $renderable instanceof Form\Domain\Model\FormElements\FormElementInterface
            && $this->isEnabled($renderable)
        ;
    }

    private function isEnabled(Form\Domain\Model\Renderable\RenderableInterface $renderable): bool
    {
        if (!$renderable->isEnabled()) {
            return false;
        }

        while (($renderable = $renderable->getParentRenderable()) !== null) {
            if (!$renderable->isEnabled()) {
                return false;
            }
        }

        return true;
    }
}

1	<?php
2
3	declare(strict_types=1);
4
5	/*
6	* This file is part of the TYPO3 CMS extension "handlebars_forms".
7	*
8	* It is free software; you can redistribute it and/or modify it under
9	* the terms of the GNU General Public License, either version 2
10	* of the License, or any later version.
11	*
12	* For the full copyright and license information, please read the
13	* LICENSE.txt file that was distributed with this source code.
14	*
15	* The TYPO3 project - inspiring people to share!
16	*/
17
18	namespace CPSIT\Typo3HandlebarsForms\ContentObject;
19
20	use CPSIT\Typo3HandlebarsForms\Domain;
21	use Symfony\Component\DependencyInjection;
22	use TYPO3\CMS\Fluid;
23	use TYPO3\CMS\Form;
24
25	/**
26	* RenderablesContentObject
27	*
28	* @author Elias Häußler <e.haeussler@familie-redlich.de>
29	* @license GPL-2.0-or-later
30	*/
31	#[DependencyInjection\Attribute\AutoconfigureTag('frontend.contentobject', ['identifier' => 'HBS_RENDERABLES'])]
32	final class RenderablesContentObject extends AbstractHandlebarsFormsContentObject
33	{
34	private const IDENTIFIER_COUNT = 'HBS_RENDERABLES_COUNT';
35	private const IDENTIFIER_CURRENT = 'HBS_RENDERABLES_CURRENT';
36
37	/**
38	* @param iterable<Domain\ViewModel\Builder\ViewModelBuilder<Form\Domain\Model\Renderable\RootRenderableInterface>> $viewModelBuilders
39	*/
40	public function __construct(	×
41	#[DependencyInjection\Attribute\AutowireIterator('handlebars_forms.view_model_builder')]
42	private readonly iterable $viewModelBuilders,
43	) {}	×
44
45	/**
46	* @return list<mixed>
47	*/
48	protected function resolve(array $configuration, Context\ValueResolutionContext $context): array	×
49	{
50	$baseRenderable = $renderable = $context->renderable;	×
51	$processedRenderables = [];	×
52
53	// Use current page as base renderable if we're on root form context
54	if ($baseRenderable instanceof Form\Domain\Runtime\FormRuntime) {	×
55	$renderable = $baseRenderable->getCurrentPage() ?? $baseRenderable;	×
56	}
57
58	// Fetch renderables from base renderable:
59	// - On summary pages, the base renderable defines the selection of renderables:
60	// + If the incoming renderable is the summary page, we use ALL ELEMENTS of the configured form.
61	// + If the incoming renderable is the root form, we explicitly render the summary page renderable
62	// to allow further configuration of this specific page type. In TypoScript, the form renderables may
63	// still be rendered for summary pages by using a combination of HBS_RENDERABLES objects for form & page:
64	// formData {
65	// items = HBS_RENDERABLES
66	// items {
67	// # ...
68	// SummaryPage {
69	// elements = HBS_RENDERABLES
70	// elements {
71	// Text { ... }
72	// # ...
73	// }
74	// }
75	// }
76	// }
77	// - On default sections (e.g. non-summary pages), this reflects all direct children.
78	// - On all other composite renderables, this reflects all renderables recursively (including deeply nested
79	// renderables).
80	// - If we have a non-composite base renderable in place, we do nothing since this value resolver only handles
81	// composite renderables.
82	if ($baseRenderable instanceof Form\Domain\Model\FormElements\Page && $baseRenderable->getType() === 'SummaryPage') {	×
83	$renderables = array_filter(	×
84	$baseRenderable->getRootForm()->getRenderablesRecursively(),	×
85	$this->isElement(...),	×
86	);	×
87	} elseif ($renderable instanceof Form\Domain\Model\FormElements\Page && $renderable->getType() === 'SummaryPage') {	×
88	$renderables = [$renderable];	×
89	} elseif ($renderable instanceof Form\Domain\Model\FormElements\AbstractSection) {	×
90	$renderables = $renderable->getElements();	×
91	} elseif ($renderable instanceof Form\Domain\Model\Renderable\CompositeRenderableInterface) {	×
92	$renderables = $renderable->getRenderablesRecursively();	×
93	} else {
94	$renderables = [];	×
95	}
96
97	// Add renderables count to TSFE register
98	// @todo Use $this->request->getAttribute('frontend.register.stack') in TYPO3 v14
99	$tsfe = $this->getTypoScriptFrontendController();	×
100	$tsfe->register[self::IDENTIFIER_COUNT] = count($renderables);	×
101
102	foreach ($renderables as $index => $child) {	×
103	if (!$this->isEnabled($child)) {	×
104	continue;	×
105	}
106
107	if (array_key_exists($child->getType() . '.', $configuration)) {	×
108	// Use configured type-specific configuration (e.g. "Fieldset." for fieldsets)
109	$childConfiguration = $configuration[$child->getType() . '.'];	×
110	} elseif (!array_key_exists('default.', $configuration)) {	×
111	// Skip rendering on missing fallback config
112	continue;	×
113	} else {
114	// Use configured fallback configuration ("default.")
115	$childConfiguration = $configuration['default.'];	×
116	}
117
118	if (is_array($childConfiguration)) {	×
119	$childViewModel = $this->buildViewModel($child, $context->renderingContext);	×
120	} else {
121	$childConfiguration = [];	×
122	$childViewModel = new Domain\ViewModel\SimpleViewModel($child);	×
123	}
124
125	// Add current renderable index to TSFE register
126	$tsfe->register[self::IDENTIFIER_CURRENT] = $index;	×
127
128	try {
129	$processedChild = $context->process($childConfiguration, $child, $childViewModel);	×
130	} finally {
131	unset($tsfe->register[self::IDENTIFIER_CURRENT]);	×
132	}
133
134	if ($processedChild !== null) {	×
135	$processedRenderables[] = $processedChild;	×
136	}
137	}
138
139	unset($tsfe->register[self::IDENTIFIER_COUNT]);	×
140
141	return $processedRenderables;	×
142	}
143
144	private function buildViewModel(	×
145	Form\Domain\Model\Renderable\RootRenderableInterface $renderable,
146	Fluid\Core\Rendering\RenderingContext $renderingContext,
147	): Domain\ViewModel\ViewModel {
148	foreach ($this->viewModelBuilders as $viewModelBuilder) {	×
149	if ($viewModelBuilder->supports($renderable)) {	×
150	return $viewModelBuilder->build($renderable, $renderingContext);	×
151	}
152	}
153
154	return new Domain\ViewModel\SimpleViewModel($renderable);	×
155	}
156
157	private function isElement(Form\Domain\Model\Renderable\RenderableInterface $renderable): bool	×
158	{
159	return $renderable instanceof Form\Domain\Model\FormElements\FormElementInterface	×
160	&& $this->isEnabled($renderable)	×
161	;	×
162	}
163
164	private function isEnabled(Form\Domain\Model\Renderable\RenderableInterface $renderable): bool	×
165	{
166	if (!$renderable->isEnabled()) {	×
167	return false;	×
168	}
169
170	while (($renderable = $renderable->getParentRenderable()) !== null) {	×
171	if (!$renderable->isEnabled()) {	×
172	return false;	×
173	}
174	}
175
176	return true;	×
177	}
178	}

CPS-IT / handlebars-forms / 24128148165

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous