stacklok / toolhive / 24076594373

Build # 24076594373

Build Type

push

github

Committed by web-flow

Commit Message

Add +listType annotations to all CRD slice fields (#4586)

Without +listType/+listMapKey annotations, server-side apply cannot
determine the correct merge strategy for list fields, and strategic
merge patch behavior is ambiguous. This breaks GitOps tools that use
SSA and blocks v1beta1 CRD stabilization.

Add annotations to ~40 slice fields across all 11 CRD types:
- +listType=map with +listMapKey for struct slices with unique keys
  (Env, Volumes, Secrets, UpstreamProviders, etc.)
- +listType=set for unique scalar slices (Servers, ToolsFilter, etc.)
- +listType=atomic for ordered/opaque slices (Args, Scopes, etc.)

All Status.Conditions fields already had correct annotations and
served as the reference pattern.

Regenerated CRD manifests include x-kubernetes-list-type and
x-kubernetes-list-map-keys in the OpenAPI schema.

Fixes #4583

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

54678 of 83885 relevant lines covered (65.18%)

63.35 hits per line

Source File

Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available