• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

randombit / botan / 24001520484

05 Apr 2026 12:28PM UTC coverage: 89.451% (-0.003%) from 89.454%
24001520484

Pull #5521

github

web-flow
Merge 35992c895 into 417709dd7
Pull Request #5521: Rollup of small fixes

105805 of 118283 relevant lines covered (89.45%)

11490476.75 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

92.86
/src/lib/ffi/ffi_cipher.cpp
1
/*
2
* (C) 2015,2017 Jack Lloyd
3
*
4
* Botan is released under the Simplified BSD License (see license.txt)
5
*/
6

7
#include <botan/ffi.h>
8

9
#include <botan/aead.h>
10
#include <botan/mem_ops.h>
11
#include <botan/internal/bit_ops.h>
12
#include <botan/internal/buffer_slicer.h>
13
#include <botan/internal/buffer_stuffer.h>
14
#include <botan/internal/ffi_util.h>
15
#include <botan/internal/scoped_cleanup.h>
16

17
#include <limits>
18

19
extern "C" {
20

21
using namespace Botan_FFI;
22

23
struct botan_cipher_struct final : public botan_struct<Botan::Cipher_Mode, 0xB4A2BF9C> {
24
   public:
25
      explicit botan_cipher_struct(std::unique_ptr<Botan::Cipher_Mode> x,
31✔
26
                                   size_t update_size,
27
                                   size_t ideal_update_size) :
31✔
28
            botan_struct(std::move(x)), m_update_size(update_size), m_ideal_update_size(ideal_update_size) {
31✔
29
         BOTAN_DEBUG_ASSERT(ideal_update_size >= update_size);
31✔
30
         m_buf.reserve(m_ideal_update_size);
31✔
31
      }
31✔
32

33
      Botan::secure_vector<uint8_t>& buf() { return m_buf; }
115✔
34

35
      size_t update_size() const { return m_update_size; }
92✔
36

37
      size_t ideal_update_size() const { return m_ideal_update_size; }
64✔
38

39
   private:
40
      Botan::secure_vector<uint8_t> m_buf;
41
      size_t m_update_size;
42
      size_t m_ideal_update_size;
43
};
44

45
namespace {
46

47
/**
48
 * Select an update size so that the following constraints are satisfies:
49
 *
50
 *   - greater than or equal to the mode's update granularity
51
 *   - greater than the mode's minimum final size
52
 *   - the mode's ideal update granularity is a multiple of this size
53
 *   - (optional) a power of 2
54
 *
55
 * Note that this is necessary mostly for backward-compatibility with previous
56
 * versions of the FFI (prior to Botan 3.5.0). For Botan 4.0.0 we should just
57
 * directly return the update granularity of the cipher mode and instruct users
58
 * to switch to botan_cipher_get_ideal_update_granularity() instead. See also
59
 * the discussion in GitHub Issue #4090.
60
 */
61
size_t ffi_choose_update_size(Botan::Cipher_Mode& mode) {
31✔
62
   const size_t update_granularity = mode.update_granularity();
31✔
63
   const size_t ideal_update_granularity = mode.ideal_granularity();
31✔
64
   const size_t minimum_final_size = mode.minimum_final_size();
31✔
65

66
   // If the minimum final size is zero, or the update_granularity is
67
   // already greater, just use that.
68
   if(minimum_final_size == 0 || update_granularity > minimum_final_size) {
31✔
69
      BOTAN_ASSERT_NOMSG(update_granularity > 0);
15✔
70
      return update_granularity;
71
   }
72

73
   // If the ideal granularity is a multiple of the minimum final size, we
74
   // might be able to use that if it stays within the ideal granularity.
75
   if(ideal_update_granularity % minimum_final_size == 0 && minimum_final_size * 2 <= ideal_update_granularity) {
16✔
76
      return minimum_final_size * 2;
77
   }
78

79
   // Otherwise, try to use the next power of two greater than the minimum
80
   // final size, if the ideal granularity is a multiple of that.
81
   BOTAN_ASSERT_NOMSG(minimum_final_size <= std::numeric_limits<uint16_t>::max());
×
82
   const size_t b1 = size_t(1) << Botan::ceil_log2(static_cast<uint16_t>(minimum_final_size));
×
83
   if(ideal_update_granularity % b1 == 0) {
×
84
      return b1;
85
   }
86

87
   // Last resort: Find the next integer greater than the minimum final size
88
   //              for which the ideal granularity is a multiple of.
89
   //              Most sensible cipher modes should never reach this point.
90
   BOTAN_ASSERT_NOMSG(minimum_final_size < ideal_update_granularity);
×
91
   size_t b2 = minimum_final_size + 1;
×
92
   for(; b2 < ideal_update_granularity && ideal_update_granularity % b2 != 0; ++b2) {}
×
93

94
   return b2;
95
}
96

97
}  // namespace
98

99
int botan_cipher_init(botan_cipher_t* cipher, const char* cipher_name, uint32_t flags) {
31✔
100
   return ffi_guard_thunk(__func__, [=]() -> int {
31✔
101
      if(any_null_pointers(cipher, cipher_name)) {
31✔
102
         return BOTAN_FFI_ERROR_NULL_POINTER;
103
      }
104
      const bool encrypt_p = ((flags & BOTAN_CIPHER_INIT_FLAG_MASK_DIRECTION) == BOTAN_CIPHER_INIT_FLAG_ENCRYPT);
31✔
105
      const Botan::Cipher_Dir dir = encrypt_p ? Botan::Cipher_Dir::Encryption : Botan::Cipher_Dir::Decryption;
31✔
106

107
      std::unique_ptr<Botan::Cipher_Mode> mode(Botan::Cipher_Mode::create(cipher_name, dir));
31✔
108
      if(!mode) {
31✔
109
         return BOTAN_FFI_ERROR_NOT_IMPLEMENTED;
110
      }
111

112
      const size_t update_size = ffi_choose_update_size(*mode);
31✔
113
      const size_t ideal_update_size = std::max(mode->ideal_granularity(), update_size);
31✔
114

115
      return ffi_new_object(cipher, std::move(mode), update_size, ideal_update_size);
31✔
116
   });
31✔
117
}
118

119
int botan_cipher_destroy(botan_cipher_t cipher) {
31✔
120
   return BOTAN_FFI_CHECKED_DELETE(cipher);
31✔
121
}
122

123
int botan_cipher_clear(botan_cipher_t cipher) {
8✔
124
   return BOTAN_FFI_VISIT(cipher, [=](auto& c) {
16✔
125
      cipher->buf().clear();
126
      c.clear();
127
   });
128
}
129

130
int botan_cipher_reset(botan_cipher_t cipher) {
4✔
131
   return BOTAN_FFI_VISIT(cipher, [=](auto& c) {
8✔
132
      cipher->buf().clear();
133
      c.reset();
134
   });
135
}
136

137
int botan_cipher_output_length(botan_cipher_t cipher, size_t in_len, size_t* out_len) {
4✔
138
   if(out_len == nullptr) {
4✔
139
      return BOTAN_FFI_ERROR_NULL_POINTER;
140
   }
141

142
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { *out_len = c.output_length(in_len); });
8✔
143
}
144

145
int botan_cipher_query_keylen(botan_cipher_t cipher, size_t* out_minimum_keylength, size_t* out_maximum_keylength) {
13✔
146
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) {
26✔
147
      if(out_minimum_keylength) {
148
         *out_minimum_keylength = c.key_spec().minimum_keylength();
149
      }
150
      if(out_maximum_keylength) {
151
         *out_maximum_keylength = c.key_spec().maximum_keylength();
152
      }
153
   });
154
}
155

156
int botan_cipher_get_keyspec(botan_cipher_t cipher,
1✔
157
                             size_t* out_minimum_keylength,
158
                             size_t* out_maximum_keylength,
159
                             size_t* out_keylength_modulo) {
160
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) {
2✔
161
      if(out_minimum_keylength) {
162
         *out_minimum_keylength = c.key_spec().minimum_keylength();
163
      }
164
      if(out_maximum_keylength) {
165
         *out_maximum_keylength = c.key_spec().maximum_keylength();
166
      }
167
      if(out_keylength_modulo) {
168
         *out_keylength_modulo = c.key_spec().keylength_multiple();
169
      }
170
   });
171
}
172

173
int botan_cipher_set_key(botan_cipher_t cipher, const uint8_t* key, size_t key_len) {
43✔
174
   if(key == nullptr) {
43✔
175
      return BOTAN_FFI_ERROR_NULL_POINTER;
176
   }
177
   return BOTAN_FFI_VISIT(cipher, [=](auto& c) { c.set_key(key, key_len); });
86✔
178
}
179

180
int botan_cipher_start(botan_cipher_t cipher_obj, const uint8_t* nonce, size_t nonce_len) {
47✔
181
   return ffi_guard_thunk(__func__, [=]() -> int {
47✔
182
      Botan::Cipher_Mode& cipher = safe_get(cipher_obj);
47✔
183
      cipher.start(nonce, nonce_len);
47✔
184
      return BOTAN_FFI_SUCCESS;
47✔
185
   });
47✔
186
}
187

188
int botan_cipher_update(botan_cipher_t cipher_obj,
103✔
189
                        uint32_t flags,
190
                        uint8_t output[],
191
                        size_t output_size,
192
                        size_t* output_written,
193
                        const uint8_t input[],
194
                        size_t input_size,
195
                        size_t* input_consumed) {
196
   if(any_null_pointers(output_written, input_consumed)) {
103✔
197
      return BOTAN_FFI_ERROR_NULL_POINTER;
198
   }
199

200
   return ffi_guard_thunk(__func__, [=]() -> int {
103✔
201
      using namespace Botan;
103✔
202
      Cipher_Mode& cipher = safe_get(cipher_obj);
103✔
203
      secure_vector<uint8_t>& mbuf = cipher_obj->buf();
103✔
204

205
      // If the cipher object's internal buffer contains residual data from
206
      // a previous invocation, we can be sure that botan_cipher_update() was
207
      // called with the final flag set but not enough buffer space was provided
208
      // to accommodate the final output.
209
      const bool was_finished_before = !mbuf.empty();
103✔
210
      const bool final_input = (flags & BOTAN_CIPHER_UPDATE_FLAG_FINAL) != 0;
103✔
211

212
      // Bring the output variables into a defined state.
213
      *output_written = 0;
103✔
214
      *input_consumed = 0;
103✔
215

216
      // Once the final flag was set once, it must always be set for
217
      // consecutive invocations.
218
      if(was_finished_before && !final_input) {
103✔
219
         return BOTAN_FFI_ERROR_INVALID_OBJECT_STATE;
220
      }
221

222
      // If the final flag was set in a previous invocation, no more input
223
      // data can be processed.
224
      if(was_finished_before && input_size > 0) {
103✔
225
         return BOTAN_FFI_ERROR_BAD_PARAMETER;
226
      }
227

228
      // Make sure that we always clear the internal buffer before returning
229
      // or aborting this invocation due to an exception.
230
      auto clean_buffer = scoped_cleanup([&mbuf] { mbuf.clear(); });
301✔
231

232
      if(final_input) {
103✔
233
         // If the final flag is set for the first time, we need to process the
234
         // remaining input data and then finalize the cipher object.
235
         if(!was_finished_before) {
39✔
236
            *input_consumed = input_size;
34✔
237
            mbuf.resize(input_size);
34✔
238
            copy_mem(mbuf, std::span(input, input_size));
34✔
239

240
            try {
34✔
241
               cipher.finish(mbuf);
34✔
242
            } catch(Invalid_Authentication_Tag&) {
×
243
               return BOTAN_FFI_ERROR_BAD_MAC;
×
244
            }
×
245
         }
246

247
         // At this point, the cipher object is finalized (potentially in a
248
         // previous invocation) and we can copy the final output to the caller.
249
         *output_written = mbuf.size();
39✔
250

251
         // Not enough space to copy the final output out to the caller.
252
         // Inform them how much space we need for a successful operation.
253
         if(output_size < mbuf.size()) {
39✔
254
            // This is the only place where mbuf is not cleared before returning.
255
            clean_buffer.disengage();
256
            return BOTAN_FFI_ERROR_INSUFFICIENT_BUFFER_SPACE;
257
         }
258

259
         // Copy the final output to the caller, mbuf is cleared afterwards.
260
         copy_mem(std::span(output, mbuf.size()), mbuf);
34✔
261
      } else {
262
         // Process data in a streamed fashion without finalizing. No data is
263
         // ever retained in the cipher object's internal buffer. If we run out
264
         // of either input data or output capacity, we stop and report that not
265
         // all bytes were processed via *output_written and *input_consumed.
266

267
         BufferSlicer in({input, input_size});
64✔
268
         BufferStuffer out({output, output_size});
64✔
269

270
         // Helper function to do blockwise processing of data.
271
         auto blockwise_update = [&](const size_t granularity) {
192✔
272
            if(granularity == 0) {
128✔
273
               return;
274
            }
275

276
            const size_t expected_output_per_iteration = cipher.requires_entire_message() ? 0 : granularity;
100✔
277
            mbuf.resize(granularity);
100✔
278

279
            while(in.remaining() >= granularity && out.remaining_capacity() >= expected_output_per_iteration) {
262✔
280
               copy_mem(mbuf, in.take(granularity));
62✔
281
               const auto written_bytes = cipher.process(mbuf);
62✔
282
               BOTAN_DEBUG_ASSERT(written_bytes == expected_output_per_iteration);
62✔
283
               if(written_bytes > 0) {
62✔
284
                  BOTAN_ASSERT_NOMSG(written_bytes <= granularity);
42✔
285
                  copy_mem(out.next(written_bytes), std::span(mbuf).first(written_bytes));
42✔
286
               }
287
            }
288
         };
64✔
289

290
         // First, process as much data as possible in chunks of ideal granularity
291
         blockwise_update(cipher_obj->ideal_update_size());
64✔
292

293
         // Then process the remaining bytes in chunks of update_size() or, in one go
294
         // if update_size() is equal to 1 --> i.e. likely a stream cipher.
295
         const bool is_stream_cipher = (cipher_obj->update_size() == 1);
64✔
296
         const size_t tail_granularity =
64✔
297
            is_stream_cipher ? std::min(in.remaining(), out.remaining_capacity()) : cipher_obj->update_size();
64✔
298
         BOTAN_DEBUG_ASSERT(tail_granularity < cipher_obj->ideal_update_size());
64✔
299
         blockwise_update(tail_granularity);
64✔
300

301
         // Inform the caller about the amount of data processed.
302
         *output_written = output_size - out.remaining_capacity();
64✔
303
         *input_consumed = input_size - in.remaining();
64✔
304
      }
305

306
      return BOTAN_FFI_SUCCESS;
307
   });
206✔
308
}
309

310
int botan_cipher_set_associated_data(botan_cipher_t cipher, const uint8_t* ad, size_t ad_len) {
8✔
311
   return BOTAN_FFI_VISIT(cipher, [=](auto& c) {
16✔
312
      if(Botan::AEAD_Mode* aead = dynamic_cast<Botan::AEAD_Mode*>(&c)) {
313
         aead->set_associated_data(ad, ad_len);
314
         return BOTAN_FFI_SUCCESS;
315
      }
316
      return BOTAN_FFI_ERROR_BAD_PARAMETER;
317
   });
318
}
319

320
int botan_cipher_valid_nonce_length(botan_cipher_t cipher, size_t nl) {
6✔
321
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { return c.valid_nonce_length(nl) ? 1 : 0; });
12✔
322
}
323

324
int botan_cipher_get_default_nonce_length(botan_cipher_t cipher, size_t* nl) {
12✔
325
   if(nl == nullptr) {
12✔
326
      return BOTAN_FFI_ERROR_NULL_POINTER;
327
   }
328
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { *nl = c.default_nonce_length(); });
24✔
329
}
330

331
int botan_cipher_get_update_granularity(botan_cipher_t cipher, size_t* ug) {
28✔
332
   if(ug == nullptr) {
28✔
333
      return BOTAN_FFI_ERROR_NULL_POINTER;
334
   }
335
   return BOTAN_FFI_VISIT(cipher, [=](const auto& /*c*/) { *ug = cipher->update_size(); });
56✔
336
}
337

338
int botan_cipher_get_ideal_update_granularity(botan_cipher_t cipher, size_t* ug) {
28✔
339
   if(ug == nullptr) {
28✔
340
      return BOTAN_FFI_ERROR_NULL_POINTER;
341
   }
342
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { *ug = c.ideal_granularity(); });
56✔
343
}
344

345
int botan_cipher_get_tag_length(botan_cipher_t cipher, size_t* tl) {
16✔
346
   if(tl == nullptr) {
16✔
347
      return BOTAN_FFI_ERROR_NULL_POINTER;
348
   }
349
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { *tl = c.tag_size(); });
32✔
350
}
351

352
int botan_cipher_is_authenticated(botan_cipher_t cipher) {
15✔
353
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { return c.authenticated() ? 1 : 0; });
30✔
354
}
355

356
int botan_cipher_requires_entire_message(botan_cipher_t cipher) {
5✔
357
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { return c.requires_entire_message() ? 1 : 0; });
10✔
358
}
359

360
int botan_cipher_name(botan_cipher_t cipher, char* name, size_t* name_len) {
8✔
361
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { return write_str_output(name, name_len, c.name()); });
16✔
362
}
363
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc