• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

randombit / botan / 23989899232

04 Apr 2026 11:31PM UTC coverage: 89.44% (-0.01%) from 89.454%
23989899232

Pull #5521

github

web-flow
Merge fdd9c9e10 into 417709dd7
Pull Request #5521: Rollup of small fixes

105816 of 118310 relevant lines covered (89.44%)

11574334.41 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

92.86
/src/lib/ffi/ffi_cipher.cpp
1
/*
2
* (C) 2015,2017 Jack Lloyd
3
*
4
* Botan is released under the Simplified BSD License (see license.txt)
5
*/
6

7
#include <botan/ffi.h>
8

9
#include <botan/aead.h>
10
#include <botan/mem_ops.h>
11
#include <botan/internal/bit_ops.h>
12
#include <botan/internal/buffer_slicer.h>
13
#include <botan/internal/buffer_stuffer.h>
14
#include <botan/internal/ffi_util.h>
15
#include <botan/internal/scoped_cleanup.h>
16

17
#include <limits>
18

19
extern "C" {
20

21
using namespace Botan_FFI;
22

23
struct botan_cipher_struct final : public botan_struct<Botan::Cipher_Mode, 0xB4A2BF9C> {
24
   public:
25
      explicit botan_cipher_struct(std::unique_ptr<Botan::Cipher_Mode> x,
31✔
26
                                   size_t update_size,
27
                                   size_t ideal_update_size) :
31✔
28
            botan_struct(std::move(x)), m_update_size(update_size), m_ideal_update_size(ideal_update_size) {
31✔
29
         BOTAN_DEBUG_ASSERT(ideal_update_size >= update_size);
31✔
30
         m_buf.reserve(m_ideal_update_size);
31✔
31
      }
31✔
32

33
      Botan::secure_vector<uint8_t>& buf() { return m_buf; }
103✔
34

35
      size_t update_size() const { return m_update_size; }
92✔
36

37
      size_t ideal_update_size() const { return m_ideal_update_size; }
64✔
38

39
   private:
40
      Botan::secure_vector<uint8_t> m_buf;
41
      size_t m_update_size;
42
      size_t m_ideal_update_size;
43
};
44

45
namespace {
46

47
/**
48
 * Select an update size so that the following constraints are satisfies:
49
 *
50
 *   - greater than or equal to the mode's update granularity
51
 *   - greater than the mode's minimum final size
52
 *   - the mode's ideal update granularity is a multiple of this size
53
 *   - (optional) a power of 2
54
 *
55
 * Note that this is necessary mostly for backward-compatibility with previous
56
 * versions of the FFI (prior to Botan 3.5.0). For Botan 4.0.0 we should just
57
 * directly return the update granularity of the cipher mode and instruct users
58
 * to switch to botan_cipher_get_ideal_update_granularity() instead. See also
59
 * the discussion in GitHub Issue #4090.
60
 */
61
size_t ffi_choose_update_size(Botan::Cipher_Mode& mode) {
31✔
62
   const size_t update_granularity = mode.update_granularity();
31✔
63
   const size_t ideal_update_granularity = mode.ideal_granularity();
31✔
64
   const size_t minimum_final_size = mode.minimum_final_size();
31✔
65

66
   // If the minimum final size is zero, or the update_granularity is
67
   // already greater, just use that.
68
   if(minimum_final_size == 0 || update_granularity > minimum_final_size) {
31✔
69
      BOTAN_ASSERT_NOMSG(update_granularity > 0);
15✔
70
      return update_granularity;
71
   }
72

73
   // If the ideal granularity is a multiple of the minimum final size, we
74
   // might be able to use that if it stays within the ideal granularity.
75
   if(ideal_update_granularity % minimum_final_size == 0 && minimum_final_size * 2 <= ideal_update_granularity) {
16✔
76
      return minimum_final_size * 2;
77
   }
78

79
   // Otherwise, try to use the next power of two greater than the minimum
80
   // final size, if the ideal granularity is a multiple of that.
81
   BOTAN_ASSERT_NOMSG(minimum_final_size <= std::numeric_limits<uint16_t>::max());
×
82
   const size_t b1 = size_t(1) << Botan::ceil_log2(static_cast<uint16_t>(minimum_final_size));
×
83
   if(ideal_update_granularity % b1 == 0) {
×
84
      return b1;
85
   }
86

87
   // Last resort: Find the next integer greater than the minimum final size
88
   //              for which the ideal granularity is a multiple of.
89
   //              Most sensible cipher modes should never reach this point.
90
   BOTAN_ASSERT_NOMSG(minimum_final_size < ideal_update_granularity);
×
91
   size_t b2 = minimum_final_size + 1;
×
92
   for(; b2 < ideal_update_granularity && ideal_update_granularity % b2 != 0; ++b2) {}
×
93

94
   return b2;
95
}
96

97
}  // namespace
98

99
int botan_cipher_init(botan_cipher_t* cipher, const char* cipher_name, uint32_t flags) {
31✔
100
   return ffi_guard_thunk(__func__, [=]() -> int {
31✔
101
      if(any_null_pointers(cipher, cipher_name)) {
31✔
102
         return BOTAN_FFI_ERROR_NULL_POINTER;
103
      }
104
      const bool encrypt_p = ((flags & BOTAN_CIPHER_INIT_FLAG_MASK_DIRECTION) == BOTAN_CIPHER_INIT_FLAG_ENCRYPT);
31✔
105
      const Botan::Cipher_Dir dir = encrypt_p ? Botan::Cipher_Dir::Encryption : Botan::Cipher_Dir::Decryption;
31✔
106

107
      std::unique_ptr<Botan::Cipher_Mode> mode(Botan::Cipher_Mode::create(cipher_name, dir));
31✔
108
      if(!mode) {
31✔
109
         return BOTAN_FFI_ERROR_NOT_IMPLEMENTED;
110
      }
111

112
      const size_t update_size = ffi_choose_update_size(*mode);
31✔
113
      const size_t ideal_update_size = std::max(mode->ideal_granularity(), update_size);
31✔
114

115
      return ffi_new_object(cipher, std::move(mode), update_size, ideal_update_size);
31✔
116
   });
31✔
117
}
118

119
int botan_cipher_destroy(botan_cipher_t cipher) {
31✔
120
   return BOTAN_FFI_CHECKED_DELETE(cipher);
31✔
121
}
122

123
int botan_cipher_clear(botan_cipher_t cipher) {
8✔
124
   return BOTAN_FFI_VISIT(cipher, [](auto& c) { c.clear(); });
16✔
125
}
126

127
int botan_cipher_reset(botan_cipher_t cipher) {
4✔
128
   return BOTAN_FFI_VISIT(cipher, [](auto& c) { c.reset(); });
8✔
129
}
130

131
int botan_cipher_output_length(botan_cipher_t cipher, size_t in_len, size_t* out_len) {
4✔
132
   if(out_len == nullptr) {
4✔
133
      return BOTAN_FFI_ERROR_NULL_POINTER;
134
   }
135

136
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { *out_len = c.output_length(in_len); });
8✔
137
}
138

139
int botan_cipher_query_keylen(botan_cipher_t cipher, size_t* out_minimum_keylength, size_t* out_maximum_keylength) {
13✔
140
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) {
26✔
141
      if(out_minimum_keylength) {
142
         *out_minimum_keylength = c.key_spec().minimum_keylength();
143
      }
144
      if(out_maximum_keylength) {
145
         *out_maximum_keylength = c.key_spec().maximum_keylength();
146
      }
147
   });
148
}
149

150
int botan_cipher_get_keyspec(botan_cipher_t cipher,
1✔
151
                             size_t* out_minimum_keylength,
152
                             size_t* out_maximum_keylength,
153
                             size_t* out_keylength_modulo) {
154
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) {
2✔
155
      if(out_minimum_keylength) {
156
         *out_minimum_keylength = c.key_spec().minimum_keylength();
157
      }
158
      if(out_maximum_keylength) {
159
         *out_maximum_keylength = c.key_spec().maximum_keylength();
160
      }
161
      if(out_keylength_modulo) {
162
         *out_keylength_modulo = c.key_spec().keylength_multiple();
163
      }
164
   });
165
}
166

167
int botan_cipher_set_key(botan_cipher_t cipher, const uint8_t* key, size_t key_len) {
43✔
168
   if(key == nullptr) {
43✔
169
      return BOTAN_FFI_ERROR_NULL_POINTER;
170
   }
171
   return BOTAN_FFI_VISIT(cipher, [=](auto& c) { c.set_key(key, key_len); });
86✔
172
}
173

174
int botan_cipher_start(botan_cipher_t cipher_obj, const uint8_t* nonce, size_t nonce_len) {
47✔
175
   return ffi_guard_thunk(__func__, [=]() -> int {
47✔
176
      Botan::Cipher_Mode& cipher = safe_get(cipher_obj);
47✔
177
      cipher.start(nonce, nonce_len);
47✔
178
      return BOTAN_FFI_SUCCESS;
47✔
179
   });
47✔
180
}
181

182
int botan_cipher_update(botan_cipher_t cipher_obj,
103✔
183
                        uint32_t flags,
184
                        uint8_t output[],
185
                        size_t output_size,
186
                        size_t* output_written,
187
                        const uint8_t input[],
188
                        size_t input_size,
189
                        size_t* input_consumed) {
190
   if(any_null_pointers(output_written, input_consumed)) {
103✔
191
      return BOTAN_FFI_ERROR_NULL_POINTER;
192
   }
193

194
   return ffi_guard_thunk(__func__, [=]() -> int {
103✔
195
      using namespace Botan;
103✔
196
      Cipher_Mode& cipher = safe_get(cipher_obj);
103✔
197
      secure_vector<uint8_t>& mbuf = cipher_obj->buf();
103✔
198

199
      // If the cipher object's internal buffer contains residual data from
200
      // a previous invocation, we can be sure that botan_cipher_update() was
201
      // called with the final flag set but not enough buffer space was provided
202
      // to accommodate the final output.
203
      const bool was_finished_before = !mbuf.empty();
103✔
204
      const bool final_input = (flags & BOTAN_CIPHER_UPDATE_FLAG_FINAL) != 0;
103✔
205

206
      // Bring the output variables into a defined state.
207
      *output_written = 0;
103✔
208
      *input_consumed = 0;
103✔
209

210
      // Once the final flag was set once, it must always be set for
211
      // consecutive invocations.
212
      if(was_finished_before && !final_input) {
103✔
213
         return BOTAN_FFI_ERROR_INVALID_OBJECT_STATE;
214
      }
215

216
      // If the final flag was set in a previous invocation, no more input
217
      // data can be processed.
218
      if(was_finished_before && input_size > 0) {
103✔
219
         return BOTAN_FFI_ERROR_BAD_PARAMETER;
220
      }
221

222
      // Make sure that we always clear the internal buffer before returning
223
      // or aborting this invocation due to an exception.
224
      auto clean_buffer = scoped_cleanup([&mbuf] { mbuf.clear(); });
301✔
225

226
      if(final_input) {
103✔
227
         // If the final flag is set for the first time, we need to process the
228
         // remaining input data and then finalize the cipher object.
229
         if(!was_finished_before) {
39✔
230
            *input_consumed = input_size;
34✔
231
            mbuf.resize(input_size);
34✔
232
            copy_mem(mbuf, std::span(input, input_size));
34✔
233

234
            try {
34✔
235
               cipher.finish(mbuf);
34✔
236
            } catch(Invalid_Authentication_Tag&) {
×
237
               return BOTAN_FFI_ERROR_BAD_MAC;
×
238
            }
×
239
         }
240

241
         // At this point, the cipher object is finalized (potentially in a
242
         // previous invocation) and we can copy the final output to the caller.
243
         *output_written = mbuf.size();
39✔
244

245
         // Not enough space to copy the final output out to the caller.
246
         // Inform them how much space we need for a successful operation.
247
         if(output_size < mbuf.size()) {
39✔
248
            // This is the only place where mbuf is not cleared before returning.
249
            clean_buffer.disengage();
250
            return BOTAN_FFI_ERROR_INSUFFICIENT_BUFFER_SPACE;
251
         }
252

253
         // Copy the final output to the caller, mbuf is cleared afterwards.
254
         copy_mem(std::span(output, mbuf.size()), mbuf);
34✔
255
      } else {
256
         // Process data in a streamed fashion without finalizing. No data is
257
         // ever retained in the cipher object's internal buffer. If we run out
258
         // of either input data or output capacity, we stop and report that not
259
         // all bytes were processed via *output_written and *input_consumed.
260

261
         BufferSlicer in({input, input_size});
64✔
262
         BufferStuffer out({output, output_size});
64✔
263

264
         // Helper function to do blockwise processing of data.
265
         auto blockwise_update = [&](const size_t granularity) {
192✔
266
            if(granularity == 0) {
128✔
267
               return;
268
            }
269

270
            const size_t expected_output_per_iteration = cipher.requires_entire_message() ? 0 : granularity;
100✔
271
            mbuf.resize(granularity);
100✔
272

273
            while(in.remaining() >= granularity && out.remaining_capacity() >= expected_output_per_iteration) {
262✔
274
               copy_mem(mbuf, in.take(granularity));
62✔
275
               const auto written_bytes = cipher.process(mbuf);
62✔
276
               BOTAN_DEBUG_ASSERT(written_bytes == expected_output_per_iteration);
62✔
277
               if(written_bytes > 0) {
62✔
278
                  BOTAN_ASSERT_NOMSG(written_bytes <= granularity);
42✔
279
                  copy_mem(out.next(written_bytes), std::span(mbuf).first(written_bytes));
42✔
280
               }
281
            }
282
         };
64✔
283

284
         // First, process as much data as possible in chunks of ideal granularity
285
         blockwise_update(cipher_obj->ideal_update_size());
64✔
286

287
         // Then process the remaining bytes in chunks of update_size() or, in one go
288
         // if update_size() is equal to 1 --> i.e. likely a stream cipher.
289
         const bool is_stream_cipher = (cipher_obj->update_size() == 1);
64✔
290
         const size_t tail_granularity =
64✔
291
            is_stream_cipher ? std::min(in.remaining(), out.remaining_capacity()) : cipher_obj->update_size();
64✔
292
         BOTAN_DEBUG_ASSERT(tail_granularity < cipher_obj->ideal_update_size());
64✔
293
         blockwise_update(tail_granularity);
64✔
294

295
         // Inform the caller about the amount of data processed.
296
         *output_written = output_size - out.remaining_capacity();
64✔
297
         *input_consumed = input_size - in.remaining();
64✔
298
      }
299

300
      return BOTAN_FFI_SUCCESS;
301
   });
206✔
302
}
303

304
int botan_cipher_set_associated_data(botan_cipher_t cipher, const uint8_t* ad, size_t ad_len) {
8✔
305
   return BOTAN_FFI_VISIT(cipher, [=](auto& c) {
16✔
306
      if(Botan::AEAD_Mode* aead = dynamic_cast<Botan::AEAD_Mode*>(&c)) {
307
         aead->set_associated_data(ad, ad_len);
308
         return BOTAN_FFI_SUCCESS;
309
      }
310
      return BOTAN_FFI_ERROR_BAD_PARAMETER;
311
   });
312
}
313

314
int botan_cipher_valid_nonce_length(botan_cipher_t cipher, size_t nl) {
6✔
315
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { return c.valid_nonce_length(nl) ? 1 : 0; });
12✔
316
}
317

318
int botan_cipher_get_default_nonce_length(botan_cipher_t cipher, size_t* nl) {
12✔
319
   if(nl == nullptr) {
12✔
320
      return BOTAN_FFI_ERROR_NULL_POINTER;
321
   }
322
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { *nl = c.default_nonce_length(); });
24✔
323
}
324

325
int botan_cipher_get_update_granularity(botan_cipher_t cipher, size_t* ug) {
28✔
326
   if(ug == nullptr) {
28✔
327
      return BOTAN_FFI_ERROR_NULL_POINTER;
328
   }
329
   return BOTAN_FFI_VISIT(cipher, [=](const auto& /*c*/) { *ug = cipher->update_size(); });
56✔
330
}
331

332
int botan_cipher_get_ideal_update_granularity(botan_cipher_t cipher, size_t* ug) {
28✔
333
   if(ug == nullptr) {
28✔
334
      return BOTAN_FFI_ERROR_NULL_POINTER;
335
   }
336
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { *ug = c.ideal_granularity(); });
56✔
337
}
338

339
int botan_cipher_get_tag_length(botan_cipher_t cipher, size_t* tl) {
16✔
340
   if(tl == nullptr) {
16✔
341
      return BOTAN_FFI_ERROR_NULL_POINTER;
342
   }
343
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { *tl = c.tag_size(); });
32✔
344
}
345

346
int botan_cipher_is_authenticated(botan_cipher_t cipher) {
15✔
347
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { return c.authenticated() ? 1 : 0; });
30✔
348
}
349

350
int botan_cipher_requires_entire_message(botan_cipher_t cipher) {
5✔
351
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { return c.requires_entire_message() ? 1 : 0; });
10✔
352
}
353

354
int botan_cipher_name(botan_cipher_t cipher, char* name, size_t* name_len) {
8✔
355
   return BOTAN_FFI_VISIT(cipher, [=](const auto& c) { return write_str_output(name, name_len, c.name()); });
16✔
356
}
357
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc