• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #5011

03 Apr 2026 03:59PM UTC coverage: 72.3% (+0.008%) from 72.292%
#5011

push

travis-ci

web-flow
merge: from main to 3.0 branch #35067

4053 of 5985 new or added lines in 68 files covered. (67.72%)

732 existing lines in 143 files now uncovered.

257430 of 356056 relevant lines covered (72.3%)

131834103.52 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

82.74
/source/libs/executor/src/filloperator.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "filter.h"
17
#include "os.h"
18
#include "query.h"
19
#include "taosdef.h"
20
#include "taoserror.h"
21
#include "tmsg.h"
22
#include "ttypes.h"
23

24
#include "executorInt.h"
25
#include "tcommon.h"
26
#include "thash.h"
27
#include "ttime.h"
28

29
#include "function.h"
30
#include "operator.h"
31
#include "querynodes.h"
32
#include "querytask.h"
33
#include "tdatablock.h"
34
#include "tfill.h"
35

36
typedef struct STimeRange {
37
  TSKEY    skey;
38
  TSKEY    ekey;
39
  uint64_t groupId;
40
} STimeRange;
41

42
typedef struct SFillOperatorInfo {
43
  struct SFillInfo* pFillInfo;
44
  SSDataBlock*      pRes;
45
  SSDataBlock*      pFinalRes;
46
  int64_t           totalInputRows;
47
  void**            p;
48
  SSDataBlock*      existNewGroupBlock;
49
  STimeWindow       win;
50
  SColMatchInfo     matchInfo;
51
  int32_t           primaryTsCol;
52
  int32_t           primarySrcSlotId;
53
  uint64_t          curGroupId;  // current handled group id
54
  SExprInfo*        pExprInfo;
55
  int32_t           numOfExpr;
56
  SExprSupp         noFillExprSupp;
57
  SExprSupp         fillNullExprSupp;
58
  SList*            pFillSavedBlockList;
59
  SNode*            pTimeRange;  // STimeRangeNode for stream fill
60
} SFillOperatorInfo;
61

62
static void destroyFillOperatorInfo(void* param);
63
static void doApplyScalarCalculation(SOperatorInfo* pOperator, SSDataBlock* pBlock, int32_t order, int32_t scanFlag);
64
static int32_t fillResetPrevForNewGroup(SFillInfo* pFillInfo);
65
static void reviseFillStartAndEndKey(SFillOperatorInfo* pInfo, int32_t order);
66

67
static void doHandleRemainBlockForNewGroupImpl(SOperatorInfo* pOperator, SFillOperatorInfo* pInfo,
430,902✔
68
                                               SResultInfo* pResultInfo, int32_t order) {
69
  pInfo->totalInputRows = pInfo->existNewGroupBlock->info.rows;
430,902✔
70
  SSDataBlock*   pResBlock = pInfo->pFinalRes;
430,902✔
71
  SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
430,902✔
72

73
  //  int32_t order = TSDB_ORDER_ASC;
74
  int32_t scanFlag = MAIN_SCAN;
430,902✔
75
  //  getTableScanInfo(pOperator, &order, &scanFlag, false);
76
  taosResetFillInfo(pInfo->pFillInfo, getFillInfoStart(pInfo->pFillInfo));
430,902✔
77

78
  blockDataCleanup(pInfo->pRes);
430,902✔
79
  doApplyScalarCalculation(pOperator, pInfo->existNewGroupBlock, order, scanFlag);
430,902✔
80

81
  reviseFillStartAndEndKey(pOperator->info, order);
430,902✔
82

83
  int64_t ts = (order == TSDB_ORDER_ASC) ? pInfo->existNewGroupBlock->info.window.ekey
430,902✔
84
                                         : pInfo->existNewGroupBlock->info.window.skey;
861,804✔
85
  taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
430,902✔
86

87
  taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
430,902✔
88
  if (pInfo->pFillInfo->type == TSDB_FILL_PREV || pInfo->pFillInfo->type == TSDB_FILL_LINEAR) {
430,902✔
89
    int32_t code = fillResetPrevForNewGroup(pInfo->pFillInfo);
100,619✔
90
    if (code != TSDB_CODE_SUCCESS) {
100,619✔
91
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
92
      T_LONG_JMP(pTaskInfo->env, code);
×
93
    }
94
  }
95

96
  int32_t numOfResultRows = pResultInfo->capacity - pResBlock->info.rows;
430,902✔
97
  int32_t code = taosFillResultDataBlock(pInfo->pFillInfo, pResBlock, numOfResultRows, NULL);
430,902✔
98
  if (code != TSDB_CODE_SUCCESS) {
430,902✔
99
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
100
    T_LONG_JMP(pTaskInfo->env, code);
×
101
  }
102

103
  pInfo->curGroupId = pInfo->existNewGroupBlock->info.id.groupId;
430,902✔
104
  pInfo->existNewGroupBlock = NULL;
430,902✔
105
}
430,902✔
106

107
static void doHandleRemainBlockFromNewGroup(SOperatorInfo* pOperator, SFillOperatorInfo* pInfo,
2,017,887✔
108
                                            SResultInfo* pResultInfo, int32_t order) {
109
  SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
2,017,887✔
110
  if (taosFillHasMoreResults(pInfo->pFillInfo)) {
2,017,887✔
111
    int32_t numOfResultRows = pResultInfo->capacity - pInfo->pFinalRes->info.rows;
742,075✔
112
    int32_t code = taosFillResultDataBlock(pInfo->pFillInfo, pInfo->pFinalRes, numOfResultRows, NULL);
742,075✔
113
    if (code != TSDB_CODE_SUCCESS) {
742,075✔
114
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
115
      T_LONG_JMP(pTaskInfo->env, code);
×
116
    }
117
    pInfo->pRes->info.id.groupId = pInfo->curGroupId;
742,075✔
118
    return;
742,075✔
119
  }
120

121
  // handle the cached new group data block
122
  if (pInfo->existNewGroupBlock) {
1,275,008✔
123
    doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
430,902✔
124
  }
125
}
126

127
void doApplyScalarCalculation(SOperatorInfo* pOperator, SSDataBlock* pBlock, int32_t order, int32_t scanFlag) {
1,884,748✔
128
  int32_t            code = TSDB_CODE_SUCCESS;
1,884,748✔
129
  int32_t            lino = 0;
1,884,748✔
130
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
1,884,748✔
131
  SFillOperatorInfo* pInfo = pOperator->info;
1,884,748✔
132
  SExprSupp*         pSup = &pOperator->exprSupp;
1,884,748✔
133
  code = setInputDataBlock(pSup, pBlock, order, scanFlag, false);
1,884,748✔
134
  QUERY_CHECK_CODE(code, lino, _end);
1,884,748✔
135
  code = projectApplyFunctions(pSup->pExprInfo, pInfo->pRes, pBlock, pSup->pCtx, pSup->numOfExprs, NULL, GET_STM_RTINFO(pOperator->pTaskInfo));
1,884,748✔
136
  QUERY_CHECK_CODE(code, lino, _end);
1,884,748✔
137

138
  // reset the row value before applying the no-fill functions to the input data block, which is "pBlock" in this case.
139
  pInfo->pRes->info.rows = 0;
1,884,748✔
140
  SExprSupp* pNoFillSupp = &pInfo->noFillExprSupp;
1,884,748✔
141
  code = setInputDataBlock(pNoFillSupp, pBlock, order, scanFlag, false);
1,884,748✔
142
  QUERY_CHECK_CODE(code, lino, _end);
1,884,748✔
143

144
  code = projectApplyFunctions(pNoFillSupp->pExprInfo, pInfo->pRes, pBlock, pNoFillSupp->pCtx, pNoFillSupp->numOfExprs,
1,884,748✔
145
                               NULL, GET_STM_RTINFO(pOperator->pTaskInfo));
1,884,748✔
146
  QUERY_CHECK_CODE(code, lino, _end);
1,884,748✔
147

148
  if (pInfo->fillNullExprSupp.pExprInfo) {
1,884,748✔
149
    pInfo->pRes->info.rows = 0;
95,283✔
150
    code = setInputDataBlock(&pInfo->fillNullExprSupp, pBlock, order, scanFlag, false);
95,283✔
151
    QUERY_CHECK_CODE(code, lino, _end);
95,283✔
152
    code = projectApplyFunctions(pInfo->fillNullExprSupp.pExprInfo, pInfo->pRes, pBlock, pInfo->fillNullExprSupp.pCtx,
95,283✔
153
        pInfo->fillNullExprSupp.numOfExprs, NULL, GET_STM_RTINFO(pOperator->pTaskInfo));
95,283✔
154
  }
155

156
  pInfo->pRes->info.id.groupId = pBlock->info.id.groupId;
1,884,748✔
157

158
_end:
1,884,748✔
159
  if (code != TSDB_CODE_SUCCESS) {
1,884,748✔
160
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
161
    T_LONG_JMP(pTaskInfo->env, code);
×
162
  }
163
}
1,884,748✔
164

165
static int32_t fillResetPrevForNewGroup(SFillInfo* pFillInfo) {
100,619✔
166
  int32_t code = TSDB_CODE_SUCCESS;
100,619✔
167
  int32_t lino = 0;
100,619✔
168
  for (int32_t colIdx = 0; colIdx < pFillInfo->numOfCols; ++colIdx) {
815,386✔
169
    if (!pFillInfo->pFillCol[colIdx].notFillCol) {
714,767✔
170
      SGroupKeys* key = taosArrayGet(pFillInfo->prev.pRowVal, colIdx);
529,720✔
171
      QUERY_CHECK_NULL(key, code, lino, _end, terrno);
529,720✔
172
      key->isNull = true;
529,720✔
173
    }
174
  }
175

176
_end:
100,619✔
177
  if (code != TSDB_CODE_SUCCESS) {
100,619✔
178
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
179
  }
180
  return code;
100,619✔
181
}
182

183
static SSDataBlock* doFillImpl(SOperatorInfo* pOperator) {
2,017,887✔
184
  int32_t            code = TSDB_CODE_SUCCESS;
2,017,887✔
185
  int32_t            lino = 0;
2,017,887✔
186
  SFillOperatorInfo* pInfo = pOperator->info;
2,017,887✔
187
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
2,017,887✔
188
  if (pInfo == NULL || pTaskInfo == NULL) {
2,017,887✔
189
    qError("%s failed at line %d since pInfo or pTaskInfo is NULL.", __func__, __LINE__);
×
190
    return NULL;
×
191
  }
192

193
  SResultInfo* pResultInfo = &pOperator->resultInfo;
2,017,887✔
194
  SSDataBlock* pResBlock = pInfo->pFinalRes;
2,017,887✔
195
  if (pResBlock == NULL) {
2,017,887✔
196
    qError("%s failed at line %d since pResBlock is NULL.", __func__, __LINE__);
×
197
    return NULL;
×
198
  }
199
  blockDataCleanup(pResBlock);
2,017,887✔
200
  int32_t        order = pInfo->pFillInfo->order;
2,017,887✔
201

202
  doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
2,017,887✔
203
  if (pResBlock->info.rows > 0) {
2,017,083✔
204
    pResBlock->info.id.groupId = pInfo->curGroupId;
488,672✔
205
    return pResBlock;
488,672✔
206
  }
207

208
  while (1) {
750,536✔
209
    SSDataBlock* pBlock = getNextBlockFromDownstream(pOperator, 0);
2,278,947✔
210
    if (pBlock == NULL) {
2,279,751✔
211
      if (pInfo->totalInputRows == 0 &&
825,905✔
212
          (pInfo->pFillInfo->type != TSDB_FILL_NULL_F && pInfo->pFillInfo->type != TSDB_FILL_SET_VALUE_F)) {
174,516✔
213
        setOperatorCompleted(pOperator);
132,456✔
214
        return NULL;
132,456✔
215
      } else if (pInfo->totalInputRows == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
693,449✔
216
        reviseFillStartAndEndKey(pInfo, order);
21,030✔
217
      }
218

219
      taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
693,449✔
220
    } else {
221
      pResBlock->info.scanFlag = pBlock->info.scanFlag;
1,453,846✔
222
      pBlock->info.dataLoad = 1;
1,453,846✔
223
      code = blockDataUpdateTsWindow(pBlock, pInfo->primarySrcSlotId);
1,453,846✔
224
      QUERY_CHECK_CODE(code, lino, _end);
1,453,846✔
225

226
      blockDataCleanup(pInfo->pRes);
1,453,846✔
227
      code = blockDataEnsureCapacity(pInfo->pRes, pBlock->info.rows);
1,453,846✔
228
      QUERY_CHECK_CODE(code, lino, _end);
1,453,846✔
229
      code = blockDataEnsureCapacity(pInfo->pFinalRes, pBlock->info.rows);
1,453,846✔
230
      QUERY_CHECK_CODE(code, lino, _end);
1,453,846✔
231
      doApplyScalarCalculation(pOperator, pBlock, order, pBlock->info.scanFlag);
1,453,846✔
232

233
      if (pInfo->curGroupId == 0 || (pInfo->curGroupId == pInfo->pRes->info.id.groupId)) {
2,476,790✔
234
        if (pInfo->curGroupId == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
1,022,944✔
235
          reviseFillStartAndEndKey(pInfo, order);
348,538✔
236
        }
237

238
        pInfo->curGroupId = pInfo->pRes->info.id.groupId;  // the first data block
1,022,944✔
239
        pInfo->totalInputRows += pInfo->pRes->info.rows;
1,022,944✔
240

241
        int64_t ts = (order == TSDB_ORDER_ASC) ? pBlock->info.window.ekey : pBlock->info.window.skey;
1,022,944✔
242
        taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
1,022,944✔
243
        taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
1,022,944✔
244
      } else if (pInfo->curGroupId != pBlock->info.id.groupId) {  // the new group data block
430,902✔
245
        pInfo->existNewGroupBlock = pBlock;
430,902✔
246

247
        // Fill the previous group data block, before handle the data block of new group.
248
        // Close the fill operation for previous group data block
249
        taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
430,902✔
250
      }
251
    }
252

253
    int32_t numOfResultRows = pOperator->resultInfo.capacity - pResBlock->info.rows;
2,147,295✔
254
    bool wantMoreBlock = false;
2,147,295✔
255
    code = taosFillResultDataBlock(pInfo->pFillInfo, pResBlock, numOfResultRows, &wantMoreBlock);
2,147,295✔
256
    QUERY_CHECK_CODE(code, lino, _end);
2,146,838✔
257

258
    // current group has no more result to return
259
    if (pResBlock->info.rows > 0) {
2,146,838✔
260
      // 1. The result in current group not reach the threshold of output result, continue
261
      // 2. If multiple group results existing in one SSDataBlock is not allowed, return immediately
262
      if (pResBlock->info.rows > pResultInfo->threshold || pBlock == NULL || pInfo->existNewGroupBlock != NULL) {
1,053,873✔
263
        pResBlock->info.id.groupId = pInfo->curGroupId;
1,053,873✔
264
        return pResBlock;
1,053,873✔
265
      }
266

267
      doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
×
268
      if (pResBlock->info.rows >= pOperator->resultInfo.threshold || pBlock == NULL) {
×
269
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
270
        return pResBlock;
×
271
      }
272
    } else if (pInfo->existNewGroupBlock) {  // try next group
1,093,422✔
273
      blockDataCleanup(pResBlock);
×
274

275
      doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
×
276
      if (pResBlock->info.rows > pResultInfo->threshold) {
×
277
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
278
        return pResBlock;
×
279
      }
280
    } else {
281
      if (wantMoreBlock) continue;
1,093,422✔
282
      return NULL;
342,886✔
283
    }
284
  }
285

286
_end:
×
287
  if (code != TSDB_CODE_SUCCESS) {
×
288
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
289
    T_LONG_JMP(pTaskInfo->env, code);
×
290
  }
291
  return NULL;
×
292
}
293

294
static int32_t doFillNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) {
2,017,887✔
295
  int32_t            code = TSDB_CODE_SUCCESS;
2,017,887✔
296
  SFillOperatorInfo* pInfo = pOperator->info;
2,017,887✔
297
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
2,017,887✔
298

299
  if (pInfo->pTimeRange != NULL) {
2,017,887✔
300
    STimeWindow pWinRange = {0};
11,370✔
301
    bool        isWinRangeValid = false;
11,370✔
302
    code = streamCalcCurrWinTimeRange((STimeRangeNode*)pInfo->pTimeRange, &pTaskInfo->pStreamRuntimeInfo->funcInfo, &pWinRange,
11,370✔
303
                  &isWinRangeValid, 3);
304
    if (code != TSDB_CODE_SUCCESS || !isWinRangeValid) {
11,370✔
305
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
306
      pTaskInfo->code = code;
×
307
      T_LONG_JMP(pTaskInfo->env, code);
×
308
    }
309

310
    pInfo->win.skey = pWinRange.skey;
11,370✔
311
    /* ekey is inclusive in fill operator, so we need to subtract 1 */
312
    pInfo->win.ekey = pWinRange.ekey - 1;
11,370✔
313
  }
314

315
  if (pOperator->status == OP_EXEC_DONE) {
2,017,887✔
316
    (*ppRes) = NULL;
×
317
    return code;
×
318
  }
319

320
  SSDataBlock* fillResult = NULL;
2,017,887✔
321
  while (true) {
322
    fillResult = doFillImpl(pOperator);
2,017,887✔
323
    if (fillResult == NULL) {
2,017,887✔
324
      setOperatorCompleted(pOperator);
475,342✔
325
      break;
475,342✔
326
    }
327

328
    code = doFilter(fillResult, pOperator->exprSupp.pFilterInfo, &pInfo->matchInfo, NULL);
1,542,545✔
329
    if (code != TSDB_CODE_SUCCESS) {
1,542,545✔
330
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
331
      pTaskInfo->code = code;
×
332
      T_LONG_JMP(pTaskInfo->env, code);
×
333
    }
334
    if (fillResult->info.rows > 0) {
1,542,545✔
335
      break;
1,542,545✔
336
    }
337
  }
338

339
  (*ppRes) = fillResult;
2,017,887✔
340
  return code;
2,017,887✔
341
}
342

343
void destroyFillOperatorInfo(void* param) {
498,613✔
344
  SFillOperatorInfo* pInfo = (SFillOperatorInfo*)param;
498,613✔
345
  pInfo->pFillInfo = taosDestroyFillInfo(pInfo->pFillInfo);
498,613✔
346
  blockDataDestroy(pInfo->pRes);
498,613✔
347
  pInfo->pRes = NULL;
498,613✔
348
  blockDataDestroy(pInfo->pFinalRes);
498,613✔
349
  pInfo->pFinalRes = NULL;
498,613✔
350

351
  cleanupExprSupp(&pInfo->noFillExprSupp);
498,613✔
352
  cleanupExprSupp(&pInfo->fillNullExprSupp);
498,613✔
353

354
  taosMemoryFreeClear(pInfo->p);
498,613✔
355
  taosArrayDestroy(pInfo->matchInfo.pList);
498,613✔
356
  taosMemoryFreeClear(param);
498,613✔
357
}
498,613✔
358

359
static int32_t initFillInfo(SFillOperatorInfo* pInfo, SExprInfo* pExpr,
498,211✔
360
                            int32_t numOfCols, SExprInfo* pNotFillExpr,
361
                            int32_t numOfNotFillCols, SExprInfo* pFillNullExpr,
362
                            int32_t numOfFillNullExprs, SNodeListNode* pValNode,
363
                            STimeWindow win, int32_t capacity, const char* id,
364
                            SInterval* pInterval, int32_t fillType,
365
                            int32_t order, SExecTaskInfo* pTaskInfo,
366
                            int64_t surroundingTime) {
367
  SFillColInfo* pColInfo =
368
      createFillColInfo(pExpr, numOfCols, pNotFillExpr, numOfNotFillCols,
498,211✔
369
                        pFillNullExpr, numOfFillNullExprs, pValNode);
370
  if (!pColInfo) {
498,211✔
371
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(terrno));
×
372
    return terrno;
×
373
  }
374

375
  int64_t startKey = (order == TSDB_ORDER_ASC) ? win.skey : win.ekey;
498,211✔
376

377
  //  STimeWindow w = {0};
378
  //  getInitialStartTimeWindow(pInterval, startKey, &w, order == TSDB_ORDER_ASC);
379
  pInfo->pFillInfo = NULL;
498,211✔
380
  int32_t code = taosCreateFillInfo(startKey, numOfCols, numOfNotFillCols,
498,211✔
381
                                    numOfFillNullExprs, capacity, pInterval,
382
                                    fillType, pColInfo, pInfo->primaryTsCol,
383
                                    order, id, pTaskInfo, surroundingTime,
384
                                    &pInfo->pFillInfo);
498,181✔
385
  if (code != TSDB_CODE_SUCCESS) {
498,181✔
386
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
387
    return code;
×
388
  }
389

390
  if (order == TSDB_ORDER_ASC) {
498,181✔
391
    pInfo->win.skey = win.skey;
413,320✔
392
    pInfo->win.ekey = win.ekey;
413,320✔
393
  } else {
394
    pInfo->win.skey = win.ekey;
84,861✔
395
    pInfo->win.ekey = win.skey;
84,861✔
396
  }
397
  pInfo->p = taosMemoryCalloc(numOfCols, POINTER_BYTES);
498,181✔
398
  if (!pInfo->p) {
498,181✔
399
    return terrno;
×
400
  }
401

402
  if (pInfo->pFillInfo == NULL) {
498,613✔
403
    taosMemoryFree(pInfo->pFillInfo);
×
404
    taosMemoryFree(pInfo->p);
×
405
    return TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR;
×
406
  } else {
407
    return TSDB_CODE_SUCCESS;
498,613✔
408
  }
409
}
410

411
static bool isWstartColumnExist(SFillOperatorInfo* pInfo) {
498,211✔
412
  if (pInfo->noFillExprSupp.numOfExprs == 0) {
498,211✔
413
    return false;
75,370✔
414
  }
415

416
  for (int32_t i = 0; i < pInfo->noFillExprSupp.numOfExprs; ++i) {
664,913✔
417
    SExprInfo* exprInfo = pInfo->noFillExprSupp.pExprInfo + i;
638,882✔
418
    if (exprInfo->pExpr->nodeType == QUERY_NODE_COLUMN && exprInfo->base.numOfParams == 1 &&
638,882✔
419
        exprInfo->base.pParam[0].pCol->colType == COLUMN_TYPE_WINDOW_START) {
638,882✔
420
      return true;
396,810✔
421
    }
422
  }
423
  return false;
26,433✔
424
}
425

426
static int32_t createPrimaryTsExprIfNeeded(SFillOperatorInfo* pInfo, SFillPhysiNode* pPhyFillNode, SExprSupp* pExprSupp,
498,211✔
427
                                           const char* idStr) {
428
  bool wstartExist = isWstartColumnExist(pInfo);
498,211✔
429

430
  if (wstartExist == false) {
498,613✔
431
    if (pPhyFillNode->pWStartTs->type != QUERY_NODE_TARGET) {
101,803✔
432
      qError("pWStartTs of fill physical node is not a target node, %s", idStr);
×
433
      return TSDB_CODE_QRY_SYS_ERROR;
×
434
    }
435

436
    SExprInfo* pExpr = taosMemoryRealloc(pExprSupp->pExprInfo, (pExprSupp->numOfExprs + 1) * sizeof(SExprInfo));
101,803✔
437
    if (pExpr == NULL) {
101,803✔
438
      return terrno;
×
439
    }
440

441
    int32_t code = createExprFromTargetNode(&pExpr[pExprSupp->numOfExprs], (STargetNode*)pPhyFillNode->pWStartTs);
101,803✔
442
    if (code != TSDB_CODE_SUCCESS) {
101,803✔
443
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
444
      pExprSupp->numOfExprs += 1;
×
445
      pExprSupp->pExprInfo = pExpr;
×
446
      return code;
×
447
    }
448

449
    pExprSupp->numOfExprs += 1;
101,803✔
450
    pExprSupp->pExprInfo = pExpr;
101,803✔
451
  }
452

453
  return TSDB_CODE_SUCCESS;
498,211✔
454
}
455

456
static int32_t resetFillOperState(SOperatorInfo* pOper) {
5,685✔
457
  SFillOperatorInfo* pFill = pOper->info;
5,685✔
458
  SExecTaskInfo*           pTaskInfo = pOper->pTaskInfo;
5,685✔
459
  pOper->status = OP_NOT_OPENED;
5,685✔
460
  SFillPhysiNode* pPhyNode = (SFillPhysiNode*)pOper->pPhyNode;
5,685✔
461

462
  pFill->curGroupId = 0;
5,685✔
463
  pFill->totalInputRows = 0;
5,685✔
464
  blockDataCleanup(pFill->pRes);
5,685✔
465
  blockDataCleanup(pFill->pFinalRes);
5,685✔
466

467
  int64_t startKey = (pFill->pFillInfo->order == TSDB_ORDER_ASC) ? pPhyNode->timeRange.skey : pPhyNode->timeRange.ekey;
5,685✔
468
  pFill->pFillInfo->start = startKey;
5,685✔
469
  pFill->pFillInfo->currentKey = startKey;
5,685✔
470
  pFill->pFillInfo->end = startKey;
5,685✔
471

472
  pFill->pFillInfo->numOfRows = 0;
5,685✔
473
  pFill->pFillInfo->index = -1;
5,685✔
474
  pFill->pFillInfo->numOfTotal = 0;
5,685✔
475
  pFill->pFillInfo->numOfCurrent = 0;
5,685✔
476
  pFill->pFillInfo->isFilled = false;
5,685✔
477
  int32_t size = taosArrayGetSize(pFill->pFillInfo->prev.pRowVal);
5,685✔
478
  for (int32_t i = 0; i < size; ++i) {
34,110✔
479
    SGroupKeys* pKey = taosArrayGet(pFill->pFillInfo->prev.pRowVal, i);
28,425✔
480
    pKey->isNull = true;
28,425✔
481
  }
482
  size = taosArrayGetSize(pFill->pFillInfo->next.pRowVal);
5,685✔
483
  for (int32_t i = 0; i < size; ++i) {
34,110✔
484
    SGroupKeys* pKey = taosArrayGet(pFill->pFillInfo->next.pRowVal, i);
28,425✔
485
    pKey->isNull = true;
28,425✔
486
  }
487

488
  taosMemoryFreeClear(pFill->pFillInfo->pTags);
5,685✔
489
  taosArrayDestroy(pFill->pFillInfo->pColFillProgress);
5,685✔
490
  pFill->pFillInfo->pColFillProgress = NULL;
5,685✔
491

492
  tdListFreeP(pFill->pFillInfo->pFillSavedBlockList, destroyFillBlock);
5,685✔
493
  pFill->pFillInfo->pFillSavedBlockList = NULL;
5,685✔
494

495
  int32_t order = (pPhyNode->node.inputTsOrder == ORDER_ASC) ? TSDB_ORDER_ASC : TSDB_ORDER_DESC;
5,685✔
496
  if (order == TSDB_ORDER_ASC) {
5,685✔
497
    pFill->win.skey = pPhyNode->timeRange.skey;
5,685✔
498
    pFill->win.ekey = pPhyNode->timeRange.ekey;
5,685✔
499
  } else {
500
    pFill->win.skey = pPhyNode->timeRange.ekey;
×
501
    pFill->win.ekey = pPhyNode->timeRange.skey;
×
502
  }
503

504
  return TSDB_CODE_SUCCESS;
5,685✔
505
}
506

507
int32_t createFillOperatorInfo(SOperatorInfo* downstream, SFillPhysiNode* pPhyFillNode,
498,211✔
508
                                      SExecTaskInfo* pTaskInfo, SOperatorInfo** pOptrInfo) {
509
  QRY_PARAM_CHECK(pOptrInfo);
498,211✔
510
  int32_t code = 0;
498,613✔
511
  int32_t lino = 0;
498,613✔
512

513
  SFillOperatorInfo* pInfo = taosMemoryCalloc(1, sizeof(SFillOperatorInfo));
498,613✔
514
  SOperatorInfo*     pOperator = taosMemoryCalloc(1, sizeof(SOperatorInfo));
498,613✔
515
  if (pInfo == NULL || pOperator == NULL) {
498,211✔
UNCOV
516
    code = terrno;
×
517
    goto _error;
×
518
  }
519
  initOperatorCostInfo(pOperator);
498,211✔
520

521
  pOperator->pPhyNode = pPhyFillNode;
498,211✔
522
  pInfo->pRes = createDataBlockFromDescNode(pPhyFillNode->node.pOutputDataBlockDesc);
498,613✔
523
  QUERY_CHECK_NULL(pInfo->pRes, code, lino, _error, terrno);
498,211✔
524
  SExprInfo* pExprInfo = NULL;
498,211✔
525

526
  code = createExprInfo(pPhyFillNode->pFillExprs, NULL, &pExprInfo, &pInfo->numOfExpr);
498,211✔
527
  QUERY_CHECK_CODE(code, lino, _error);
498,613✔
528

529
  pOperator->exprSupp.pExprInfo = pExprInfo;
498,613✔
530
  pOperator->exprSupp.numOfExprs = pInfo->numOfExpr;
498,613✔
531

532
  SExprSupp* pNoFillSupp = &pInfo->noFillExprSupp;
498,211✔
533
  code = createExprInfo(pPhyFillNode->pNotFillExprs, NULL, &pNoFillSupp->pExprInfo, &pNoFillSupp->numOfExprs);
498,211✔
534
  QUERY_CHECK_CODE(code, lino, _error);
498,613✔
535

536
  code = createPrimaryTsExprIfNeeded(pInfo, pPhyFillNode, pNoFillSupp, pTaskInfo->id.str);
498,613✔
537
  QUERY_CHECK_CODE(code, lino, _error);
498,211✔
538

539
  code =
540
      initExprSupp(pNoFillSupp, pNoFillSupp->pExprInfo, pNoFillSupp->numOfExprs, &pTaskInfo->storageAPI.functionStore);
498,211✔
541
  QUERY_CHECK_CODE(code, lino, _error);
498,211✔
542

543
  code = createExprInfo(pPhyFillNode->pFillNullExprs, NULL, &pInfo->fillNullExprSupp.pExprInfo,
498,211✔
544
                        &pInfo->fillNullExprSupp.numOfExprs);
545
  QUERY_CHECK_CODE(code, lino, _error);
498,211✔
546
  code = initExprSupp(&pInfo->fillNullExprSupp, pInfo->fillNullExprSupp.pExprInfo, pInfo->fillNullExprSupp.numOfExprs,
498,211✔
547
                      &pTaskInfo->storageAPI.functionStore);
548
  QUERY_CHECK_CODE(code, lino, _error);
498,211✔
549

550
  SInterval* pInterval =
498,613✔
551
      QUERY_NODE_PHYSICAL_PLAN_MERGE_ALIGNED_INTERVAL == downstream->operatorType
498,211✔
552
          ? &((SMergeAlignedIntervalAggOperatorInfo*)downstream->info)->intervalAggOperatorInfo->interval
183,295✔
553
          : &((SIntervalAggOperatorInfo*)downstream->info)->interval;
681,506✔
554

555
  int32_t order = (pPhyFillNode->node.inputTsOrder == ORDER_ASC) ? TSDB_ORDER_ASC : TSDB_ORDER_DESC;
498,613✔
556
  int32_t type = convertFillType(pPhyFillNode->mode);
498,613✔
557

558
  SResultInfo* pResultInfo = &pOperator->resultInfo;
498,613✔
559

560
  initResultSizeInfo(&pOperator->resultInfo, 4096);
498,211✔
561
  code = blockDataEnsureCapacity(pInfo->pRes, pOperator->resultInfo.capacity);
498,211✔
562
  if (code != TSDB_CODE_SUCCESS) {
498,613✔
563
    goto _error;
×
564
  }
565
  code = initExprSupp(&pOperator->exprSupp, pExprInfo, pInfo->numOfExpr, &pTaskInfo->storageAPI.functionStore);
498,613✔
566
  if (code != TSDB_CODE_SUCCESS) {
498,613✔
567
    goto _error;
×
568
  }
569

570
  pInfo->primaryTsCol = ((STargetNode*)pPhyFillNode->pWStartTs)->slotId;
498,613✔
571
  pInfo->primarySrcSlotId = ((SColumnNode*)((STargetNode*)pPhyFillNode->pWStartTs)->pExpr)->slotId;
498,613✔
572

573
  int32_t numOfOutputCols = 0;
498,211✔
574
  code = extractColMatchInfo(pPhyFillNode->pFillExprs, pPhyFillNode->node.pOutputDataBlockDesc, &numOfOutputCols,
498,211✔
575
                             COL_MATCH_FROM_SLOT_ID, &pInfo->matchInfo);
576

577
  QUERY_CHECK_CODE(code, lino, _error);
498,613✔
578

579
  // Extract surroundingTime from pSurroundingTime node
580
  int64_t surroundingTime = 0;
498,613✔
581
  if (pPhyFillNode->pSurroundingTime != NULL &&
498,613✔
582
      nodeType(pPhyFillNode->pSurroundingTime) == QUERY_NODE_VALUE) {
7,959✔
583
    surroundingTime = ((SValueNode*)pPhyFillNode->pSurroundingTime)->datum.i;
7,959✔
584
  }
585

586
  code = initFillInfo(pInfo, pExprInfo, pInfo->numOfExpr,
996,824✔
587
                      pNoFillSupp->pExprInfo, pNoFillSupp->numOfExprs,
588
                      pInfo->fillNullExprSupp.pExprInfo,
589
                      pInfo->fillNullExprSupp.numOfExprs,
590
                      (SNodeListNode*)pPhyFillNode->pValues,
498,211✔
591
                      pPhyFillNode->timeRange, pResultInfo->capacity,
592
                      pTaskInfo->id.str, pInterval, type, order, pTaskInfo,
498,613✔
593
                      surroundingTime);
594
  if (code != TSDB_CODE_SUCCESS) {
498,181✔
595
    goto _error;
×
596
  }
597
  TSWAP(pInfo->pTimeRange, pPhyFillNode->pTimeRange);
498,181✔
598
  pInfo->pFinalRes = NULL;
498,181✔
599

600
  code = createOneDataBlock(pInfo->pRes, false, &pInfo->pFinalRes);
498,613✔
601
  if (code) {
498,613✔
602
    goto _error;
×
603
  }
604

605
  code = blockDataEnsureCapacity(pInfo->pFinalRes, pOperator->resultInfo.capacity);
498,613✔
606
  if (code != TSDB_CODE_SUCCESS) {
498,613✔
607
    goto _error;
×
608
  }
609

610
  code = filterInitFromNode((SNode*)pPhyFillNode->node.pConditions, &pOperator->exprSupp.pFilterInfo, 0,
498,613✔
611
                            pTaskInfo->pStreamRuntimeInfo);
498,613✔
612
  if (code != TSDB_CODE_SUCCESS) {
498,613✔
613
    goto _error;
×
614
  }
615

616
  setOperatorInfo(pOperator, "FillOperator", QUERY_NODE_PHYSICAL_PLAN_FILL, false, OP_NOT_OPENED, pInfo, pTaskInfo);
498,613✔
617
  pOperator->fpSet = createOperatorFpSet(optrDummyOpenFn, doFillNext, NULL, destroyFillOperatorInfo, optrDefaultBufFn, NULL,
498,613✔
618
                                         optrDefaultGetNextExtFn, NULL);
619
  setOperatorResetStateFn(pOperator, resetFillOperState);
498,613✔
620

621
  code = appendDownstream(pOperator, &downstream, 1);
498,613✔
622
  if (code != TSDB_CODE_SUCCESS) {
498,613✔
623
    goto _error;
×
624
  }
625

626
  *pOptrInfo = pOperator;
498,613✔
627
  return TSDB_CODE_SUCCESS;
498,613✔
628

629
_error:
×
630
  qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
631

632
  if (pInfo != NULL) {
×
633
    destroyFillOperatorInfo(pInfo);
×
634
  }
635
  destroyOperatorAndDownstreams(pOperator, &downstream, 1);
×
636
  pTaskInfo->code = code;
×
637
  return code;
×
638
}
639

640
static void reviseFillStartAndEndKey(SFillOperatorInfo* pInfo, int32_t order) {
800,470✔
641
  int64_t skey, ekey, next;
642
  if (order == TSDB_ORDER_ASC) {
800,470✔
643
    skey = taosTimeTruncate(pInfo->win.skey, &pInfo->pFillInfo->interval);
745,835✔
644
    taosFillUpdateStartTimestampInfo(pInfo->pFillInfo, skey);
745,835✔
645

646
    ekey = taosTimeTruncate(pInfo->win.ekey, &pInfo->pFillInfo->interval);
745,835✔
647
    next = ekey;
745,835✔
648
    while (next < pInfo->win.ekey) {
934,174✔
649
      next = taosTimeAdd(ekey, pInfo->pFillInfo->interval.sliding, pInfo->pFillInfo->interval.slidingUnit,
188,339✔
650
                         pInfo->pFillInfo->interval.precision, NULL);
188,339✔
651
      if (next == ekey) break;
188,339✔
652
      ekey = next > pInfo->win.ekey ? ekey : next;
188,339✔
653
    }
654
    pInfo->win.ekey = ekey;
745,835✔
655
  } else {
656
    skey = taosTimeTruncate(pInfo->win.skey, &pInfo->pFillInfo->interval);
54,635✔
657
    next = skey;
54,635✔
658
    while (next < pInfo->win.skey) {
102,295✔
659
      next = taosTimeAdd(skey, pInfo->pFillInfo->interval.sliding, pInfo->pFillInfo->interval.slidingUnit,
47,660✔
660
                         pInfo->pFillInfo->interval.precision, NULL);
47,660✔
661
      if (next == skey) break;
47,660✔
662
      skey = next > pInfo->win.skey ? skey : next;
47,660✔
663
    }
664
    taosFillUpdateStartTimestampInfo(pInfo->pFillInfo, skey);
54,635✔
665
    pInfo->win.ekey = taosTimeTruncate(pInfo->win.ekey, &pInfo->pFillInfo->interval);
54,635✔
666
  }
667
}
800,470✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc