• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

opendefensecloud / solution-arsenal / 23768564093

30 Mar 2026 09:26PM UTC coverage: 71.823% (-0.3%) from 72.141%
23768564093

Pull #338

github

web-flow
Merge 97bdd6d3b into 0fe88d665
Pull Request #338: feat: reworked rendertask to be a clusterwide ressource, modified tes…

83 of 98 new or added lines in 5 files covered. (84.69%)

19 existing lines in 5 files now uncovered.

2210 of 3077 relevant lines covered (71.82%)

23.57 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

89.41
/pkg/controller/rendertask_controller.go
1
// Copyright 2026 BWI GmbH and Solution Arsenal contributors
2
// SPDX-License-Identifier: Apache-2.0
3

4
package controller
5

6
import (
7
        "context"
8
        "encoding/json"
9
        "fmt"
10
        "slices"
11
        "strings"
12
        "time"
13

14
        batchv1 "k8s.io/api/batch/v1"
15
        corev1 "k8s.io/api/core/v1"
16
        apierrors "k8s.io/apimachinery/pkg/api/errors"
17
        apimeta "k8s.io/apimachinery/pkg/api/meta"
18
        metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
19
        "k8s.io/apimachinery/pkg/runtime"
20
        "k8s.io/client-go/tools/events"
21
        ctrl "sigs.k8s.io/controller-runtime"
22
        "sigs.k8s.io/controller-runtime/pkg/client"
23
        "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
24

25
        solarv1alpha1 "go.opendefense.cloud/solar/api/solar/v1alpha1"
26
)
27

28
const (
29
        renderTaskFinalizer = "solar.opendefense.cloud/rendertask-finalizer"
30

31
        annotationJobName    = "solar.opendefense.cloud/job-name"
32
        annotationSecretName = "solar.opendefense.cloud/secret-name"
33

34
        // Condition types
35
        ConditionTypeJobScheduled = "JobScheduled"
36
        ConditionTypeJobSucceeded = "JobSucceeded"
37
        ConditionTypeJobFailed    = "JobFailed"
38

39
        ConditionTypeTaskCompleted = "TaskCompleted"
40
        ConditionTypeTaskFailed    = "TaskFailed"
41
)
42

43
// RenderTaskReconciler reconciles a RenderTask object
44
type RenderTaskReconciler struct {
45
        client.Client
46
        Scheme              *runtime.Scheme
47
        Recorder            events.EventRecorder
48
        RendererImage       string
49
        RendererCommand     string
50
        RendererArgs        []string
51
        PushSecretRef       *corev1.SecretReference
52
        BaseURL             string
53
        RendererCAConfigMap string
54
        // Namespace is the namespace where Jobs and Secrets are created.
55
        // Passed via --namespace flag from the controller-manager.
56
        Namespace string
57
}
58

59
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=rendertasks,verbs=get;list;watch;create;update;patch;delete
60
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=rendertasks/status,verbs=get;update;patch
61
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=rendertasks/finalizers,verbs=update
62
//+kubebuilder:rbac:groups=batch,resources=jobs,verbs=get;list;watch;create;update;patch;delete
63
//+kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch;create;update;patch;delete
64
//+kubebuilder:rbac:groups=core,resources=events,verbs=create;patch
65
//+kubebuilder:rbac:groups=events.k8s.io,resources=events,verbs=create;patch
66

67
// Reconcile moves the current state of the cluster closer to the desired state
68
func (r *RenderTaskReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
321✔
69
        log := ctrl.LoggerFrom(ctx)
321✔
70
        ctrlResult := ctrl.Result{}
321✔
71

321✔
72
        log.V(1).Info("RenderTask is being reconciled", "req", req)
321✔
73

321✔
74
        // Fetch the RenderTask instance
321✔
75
        res := &solarv1alpha1.RenderTask{}
321✔
76
        if err := r.Get(ctx, req.NamespacedName, res); err != nil {
372✔
77
                if apierrors.IsNotFound(err) {
102✔
78
                        // Object not found, return. Created objects are automatically garbage collected.
51✔
79
                        return ctrlResult, nil
51✔
80
                }
51✔
81

82
                return ctrlResult, errLogAndWrap(log, err, "failed to get object")
×
83
        }
84

85
        // Handle deletion: cleanup job and secret, then remove finalizer
86
        if !res.DeletionTimestamp.IsZero() {
319✔
87
                log.V(1).Info("RenderTask is being deleted")
49✔
88
                r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "Deleting", "Delete", "RenderTask is being deleted, cleaning up secret and job")
49✔
89

49✔
90
                // Cleanup render resources, if exists
49✔
91
                if err := r.deleteRenderJob(ctx, res); err != nil && !apierrors.IsNotFound(err) {
49✔
92
                        return ctrlResult, errLogAndWrap(log, err, "failed to clean up render job")
×
93
                }
×
94

95
                if err := r.deleteConfigSecret(ctx, res); err != nil && !apierrors.IsNotFound(err) {
49✔
96
                        return ctrlResult, errLogAndWrap(log, err, "failed to clean up render secret")
×
97
                }
×
98

99
                // Remove finalizer
100
                if slices.Contains(res.Finalizers, renderTaskFinalizer) {
98✔
101
                        log.V(1).Info("Removing finalizer from resource")
49✔
102
                        res.Finalizers = slices.DeleteFunc(res.Finalizers, func(f string) bool {
98✔
103
                                return f == renderTaskFinalizer
49✔
104
                        })
49✔
105
                        if err := r.Update(ctx, res); err != nil {
85✔
106
                                if apierrors.IsNotFound(err) {
72✔
107
                                        return ctrlResult, nil
36✔
108
                                }
36✔
109

UNCOV
110
                                return ctrlResult, errLogAndWrap(log, err, "failed to remove finalizer")
×
111
                        }
112
                }
113

114
                return ctrlResult, nil
13✔
115
        }
116

117
        // Add finalizer if not present and not deleting
118
        if res.DeletionTimestamp.IsZero() {
442✔
119
                if !slices.Contains(res.Finalizers, renderTaskFinalizer) {
270✔
120
                        log.V(1).Info("Adding finalizer to resource")
49✔
121
                        res.Finalizers = append(res.Finalizers, renderTaskFinalizer)
49✔
122
                        if err := r.Update(ctx, res); err != nil {
49✔
123
                                return ctrlResult, errLogAndWrap(log, err, "failed to add finalizer")
×
124
                        }
×
125
                        // Return without requeue; the Update event will trigger reconciliation again
126
                        return ctrlResult, nil
49✔
127
                }
128
        }
129

130
        // Check if renderjob has already completed successfully
131
        sc := apimeta.FindStatusCondition(res.Status.Conditions, ConditionTypeJobSucceeded)
172✔
132
        if sc != nil && sc.ObservedGeneration >= res.Generation && sc.Status == metav1.ConditionTrue {
178✔
133
                log.V(1).Info("RenderTask has already completed successfully, no further action needed")
6✔
134
                return ctrlResult, nil
6✔
135
        }
6✔
136

137
        // Reconcile Config Secret
138
        configSecret := &corev1.Secret{}
166✔
139
        err := r.Get(ctx, r.configSecretKey(res), configSecret)
166✔
140
        if err != nil && apierrors.IsNotFound(err) {
263✔
141
                createdSecret, err := r.createConfigSecret(ctx, res)
97✔
142
                if err != nil {
102✔
143
                        r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "CreateSecretFailed", "CreateConfigSecret", fmt.Sprintf("Failed to create config secret: %s", err))
5✔
144
                        return ctrlResult, errLogAndWrap(log, err, "failed to create secret")
5✔
145
                }
5✔
146
                configSecret = createdSecret
92✔
147
        } else if err != nil {
69✔
148
                return ctrlResult, errLogAndWrap(log, err, "could not get secret")
×
149
        }
×
150

151
        // Resolve push secret (lives in controller namespace, referenced directly by Jobs)
152
        var pushSecret *corev1.Secret
161✔
153
        if r.PushSecretRef != nil {
322✔
154
                pushSecret = &corev1.Secret{}
161✔
155
                if err := r.Get(ctx, client.ObjectKey{Name: r.PushSecretRef.Name, Namespace: r.PushSecretRef.Namespace}, pushSecret); err != nil {
161✔
NEW
156
                        return ctrlResult, errLogAndWrap(log, err, "failed to get push secret")
×
UNCOV
157
                }
×
158
        }
159

160
        // Reconcile Job
161
        job := &batchv1.Job{}
161✔
162
        err = r.Get(ctx, r.renderJobKey(res), job)
161✔
163
        if err != nil && apierrors.IsNotFound(err) {
205✔
164
                err := r.createRenderJob(ctx, res, configSecret, pushSecret)
44✔
165
                if err != nil {
44✔
166
                        r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "CreateJobFailed", "CreateJob", fmt.Sprintf("Failed to create job: %s", err))
×
167
                        return ctrlResult, errLogAndWrap(log, err, "failed to create job")
×
168
                }
×
169
        } else if err != nil {
117✔
170
                return ctrlResult, errLogAndWrap(log, err, "could not get job")
×
171
        }
×
172

173
        // Update Status
174
        if changed := r.updateResourceStatusFromJob(ctx, res, job); changed {
216✔
175
                if err := r.Status().Update(ctx, res); err != nil {
61✔
176
                        return ctrlResult, errLogAndWrap(log, err, "failed to update status")
6✔
177
                }
6✔
178
        }
179

180
        if !isJobComplete(job) {
253✔
181
                log.V(1).Info("Job is still running, requeue after 5 seconds")
98✔
182
                return ctrl.Result{RequeueAfter: 5 * time.Second}, nil
98✔
183
        }
98✔
184

185
        ttlDuration := time.Duration(ttlSeconds(res.Spec.FailedJobTTL)) * time.Second
57✔
186

57✔
187
        switch {
57✔
188
        case job.Status.Succeeded > 0:
3✔
189
                cleanupRenderResources(ctx, r, res, job)
3✔
190
                log.V(1).Info("Cleaned up after successful job")
3✔
191

3✔
192
                return ctrlResult, nil
3✔
193

194
        case job.Status.Failed > 0:
54✔
195
                if shouldCleanupSecrets(res, ttlDuration) {
104✔
196
                        cleanupSecrets(ctx, r, res)
50✔
197
                        log.V(1).Info("Cleaned up secrets after failed job TTL")
50✔
198

50✔
199
                        return ctrlResult, nil
50✔
200
                }
50✔
201
                remaining := remainingTTL(res, ttlDuration)
4✔
202
                log.V(1).Info("Waiting for TTL to expire before cleaning up secrets", "remainingSeconds", remaining.Seconds())
4✔
203

4✔
204
                return ctrl.Result{RequeueAfter: remaining + time.Second}, nil
4✔
205
        }
206

207
        return ctrlResult, nil
×
208
}
209

210
// updateResourceStatusFromJob updates the resource status based on job status
211
func (r *RenderTaskReconciler) updateResourceStatusFromJob(ctx context.Context, res *solarv1alpha1.RenderTask, job *batchv1.Job) (changed bool) {
161✔
212
        log := ctrl.LoggerFrom(ctx)
161✔
213

161✔
214
        if job == nil {
161✔
215
                changed = apimeta.SetStatusCondition(&res.Status.Conditions, metav1.Condition{
×
216
                        Type:               ConditionTypeJobScheduled,
×
217
                        Status:             metav1.ConditionFalse,
×
218
                        ObservedGeneration: res.Generation,
×
219
                        Reason:             "DoesNotExist",
×
220
                        Message:            "Renderer job does not exist",
×
221
                })
×
222

×
223
                return changed
×
224
        }
×
225

226
        if job.Status.Succeeded > 0 {
164✔
227
                changed = apimeta.SetStatusCondition(&res.Status.Conditions, metav1.Condition{
3✔
228
                        Type:               ConditionTypeJobSucceeded,
3✔
229
                        Status:             metav1.ConditionTrue,
3✔
230
                        ObservedGeneration: res.Generation,
3✔
231
                        Reason:             "JobSucceeded",
3✔
232
                        Message:            fmt.Sprintf("Renderer job completed successfully at %v", job.Status.CompletionTime),
3✔
233
                })
3✔
234

3✔
235
                if res.Status.ChartURL != r.referenceURL(res.Spec.Repository, res.Spec.Tag) {
6✔
236
                        res.Status.ChartURL = r.referenceURL(res.Spec.Repository, res.Spec.Tag)
3✔
237
                        changed = true
3✔
238
                }
3✔
239

240
                r.Recorder.Eventf(res, job, corev1.EventTypeNormal, "JobSucceeded", "RunJob", "Renderer job completed successfully")
3✔
241
                log.V(1).Info("Job succeeded", "name", job.Name)
3✔
242

3✔
243
                return changed
3✔
244
        }
245

246
        if job.Status.Failed > 0 {
212✔
247
                changed = apimeta.SetStatusCondition(&res.Status.Conditions, metav1.Condition{
54✔
248
                        Type:               ConditionTypeJobFailed,
54✔
249
                        Status:             metav1.ConditionTrue,
54✔
250
                        ObservedGeneration: res.Generation,
54✔
251
                        Reason:             "JobFailed",
54✔
252
                        Message:            "Renderer job failed",
54✔
253
                })
54✔
254
                r.Recorder.Eventf(res, job, corev1.EventTypeWarning, "JobFailed", "RunJob", "Renderer job failed")
54✔
255
                log.V(1).Info("Job failed", "name", job.Name)
54✔
256

54✔
257
                return changed
54✔
258
        }
54✔
259

260
        return apimeta.SetStatusCondition(&res.Status.Conditions, metav1.Condition{
104✔
261
                Type:               ConditionTypeJobScheduled,
104✔
262
                Status:             metav1.ConditionTrue,
104✔
263
                ObservedGeneration: res.Generation,
104✔
264
                Reason:             "JobScheduled",
104✔
265
                Message:            fmt.Sprintf("Renderer job is running (active: %d, succeeded: %d, failed: %d)", job.Status.Active, job.Status.Succeeded, job.Status.Failed),
104✔
266
        })
104✔
267
}
268

269
func (r *RenderTaskReconciler) deleteRenderJob(ctx context.Context, res *solarv1alpha1.RenderTask) error {
52✔
270
        job := &batchv1.Job{}
52✔
271
        if err := r.Get(ctx, r.renderJobKey(res), job); err != nil {
60✔
272
                return err
8✔
273
        }
8✔
274

275
        return r.Delete(ctx, job, client.PropagationPolicy(metav1.DeletePropagationBackground))
44✔
276
}
277

278
func (r *RenderTaskReconciler) deleteConfigSecret(ctx context.Context, res *solarv1alpha1.RenderTask) error {
102✔
279
        secret := &corev1.Secret{}
102✔
280
        if err := r.Get(ctx, r.configSecretKey(res), secret); err != nil {
107✔
281
                return err
5✔
282
        }
5✔
283

284
        return r.Delete(ctx, secret, client.PropagationPolicy(metav1.DeletePropagationBackground))
97✔
285
}
286

287
func (r *RenderTaskReconciler) createRenderJob(ctx context.Context, res *solarv1alpha1.RenderTask, configSecret, pushSecret *corev1.Secret) error {
44✔
288
        log := ctrl.LoggerFrom(ctx)
44✔
289

44✔
290
        jobName := r.renderJobKey(res).Name
44✔
291
        backoffLimit := int32(3)
44✔
292
        ttlSecondsAfterFinished := int32(3600)
44✔
293
        if res.Spec.FailedJobTTL != nil {
47✔
294
                ttlSecondsAfterFinished = *res.Spec.FailedJobTTL
3✔
295
        }
3✔
296

297
        volumes := []corev1.Volume{
44✔
298
                {
44✔
299
                        Name: "config",
44✔
300
                        VolumeSource: corev1.VolumeSource{
44✔
301
                                Secret: &corev1.SecretVolumeSource{
44✔
302
                                        SecretName: configSecret.Name,
44✔
303
                                        Items: []corev1.KeyToPath{
44✔
304
                                                {
44✔
305
                                                        Key:  "config.json",
44✔
306
                                                        Path: "config.json",
44✔
307
                                                },
44✔
308
                                        },
44✔
309
                                },
44✔
310
                        },
44✔
311
                },
44✔
312
        }
44✔
313
        volumeMounts := []corev1.VolumeMount{
44✔
314
                {
44✔
315
                        Name:      "config",
44✔
316
                        MountPath: "/etc/renderer/config.json",
44✔
317
                        SubPath:   "config.json",
44✔
318
                        ReadOnly:  true,
44✔
319
                },
44✔
320
        }
44✔
321
        envVars := []corev1.EnvVar{
44✔
322
                {
44✔
323
                        Name: "POD_NAMESPACE",
44✔
324
                        ValueFrom: &corev1.EnvVarSource{
44✔
325
                                FieldRef: &corev1.ObjectFieldSelector{
44✔
326
                                        FieldPath: "metadata.namespace",
44✔
327
                                },
44✔
328
                        },
44✔
329
                },
44✔
330
                {
44✔
331
                        Name: "POD_NAME",
44✔
332
                        ValueFrom: &corev1.EnvVarSource{
44✔
333
                                FieldRef: &corev1.ObjectFieldSelector{
44✔
334
                                        FieldPath: "metadata.name",
44✔
335
                                },
44✔
336
                        },
44✔
337
                },
44✔
338
        }
44✔
339

44✔
340
        if r.RendererCAConfigMap != "" {
88✔
341
                volumes = append(volumes, corev1.Volume{
44✔
342
                        Name: "ca-bundle",
44✔
343
                        VolumeSource: corev1.VolumeSource{
44✔
344
                                ConfigMap: &corev1.ConfigMapVolumeSource{
44✔
345
                                        LocalObjectReference: corev1.LocalObjectReference{
44✔
346
                                                Name: r.RendererCAConfigMap,
44✔
347
                                        },
44✔
348
                                        Items: []corev1.KeyToPath{
44✔
349
                                                {
44✔
350
                                                        Key:  "trust-bundle.pem",
44✔
351
                                                        Path: "ca-bundle.pem",
44✔
352
                                                },
44✔
353
                                        },
44✔
354
                                },
44✔
355
                        },
44✔
356
                })
44✔
357
                volumeMounts = append(volumeMounts, corev1.VolumeMount{
44✔
358
                        Name:      "ca-bundle",
44✔
359
                        MountPath: "/etc/ssl/certs",
44✔
360
                        ReadOnly:  true,
44✔
361
                })
44✔
362
                envVars = append(envVars, corev1.EnvVar{
44✔
363
                        Name:  "SSL_CERT_FILE",
44✔
364
                        Value: "/etc/ssl/certs/ca-bundle.pem",
44✔
365
                })
44✔
366
        }
44✔
367

368
        job := &batchv1.Job{
44✔
369
                ObjectMeta: metav1.ObjectMeta{
44✔
370
                        Name:      jobName,
44✔
371
                        Namespace: r.renderJobKey(res).Namespace,
44✔
372
                        OwnerReferences: []metav1.OwnerReference{
44✔
373
                                {
44✔
374
                                        APIVersion:         solarv1alpha1.SchemeGroupVersion.String(),
44✔
375
                                        Kind:               res.Kind,
44✔
376
                                        Name:               res.Name,
44✔
377
                                        UID:                res.GetUID(),
44✔
378
                                        Controller:         new(true),
44✔
379
                                        BlockOwnerDeletion: new(true),
44✔
380
                                },
44✔
381
                        },
44✔
382
                        Annotations: map[string]string{
44✔
383
                                annotationJobName: jobName,
44✔
384
                        },
44✔
385
                },
44✔
386
                Spec: batchv1.JobSpec{
44✔
387
                        BackoffLimit:            &backoffLimit,
44✔
388
                        TTLSecondsAfterFinished: &ttlSecondsAfterFinished,
44✔
389
                        Template: corev1.PodTemplateSpec{
44✔
390
                                Spec: corev1.PodSpec{
44✔
391
                                        RestartPolicy: corev1.RestartPolicyNever,
44✔
392
                                        Containers: []corev1.Container{
44✔
393
                                                {
44✔
394
                                                        Name:    "renderer",
44✔
395
                                                        Image:   r.RendererImage,
44✔
396
                                                        Command: []string{r.RendererCommand},
44✔
397
                                                        Args: append(r.RendererArgs,
44✔
398
                                                                "/etc/renderer/config.json",
44✔
399
                                                                fmt.Sprintf("--url=%s", r.referenceURL(res.Spec.Repository, res.Spec.Tag)),
44✔
400
                                                        ),
44✔
401
                                                        Env:          envVars,
44✔
402
                                                        VolumeMounts: volumeMounts,
44✔
403
                                                },
44✔
404
                                        },
44✔
405
                                        Volumes: volumes,
44✔
406
                                },
44✔
407
                        },
44✔
408
                },
44✔
409
        }
44✔
410

44✔
411
        if pushSecret != nil {
88✔
412
                switch pushSecret.Type {
44✔
413
                case corev1.SecretTypeBasicAuth:
1✔
414
                        job.Spec.Template.Spec.Containers[0].Env = append(job.Spec.Template.Spec.Containers[0].Env,
1✔
415
                                corev1.EnvVar{
1✔
416
                                        Name: "REGISTRY_USERNAME",
1✔
417
                                        ValueFrom: &corev1.EnvVarSource{
1✔
418
                                                SecretKeyRef: &corev1.SecretKeySelector{
1✔
419
                                                        LocalObjectReference: corev1.LocalObjectReference{
1✔
420
                                                                Name: pushSecret.Name,
1✔
421
                                                        },
1✔
422
                                                        Key: "username",
1✔
423
                                                },
1✔
424
                                        },
1✔
425
                                },
1✔
426
                                corev1.EnvVar{
1✔
427
                                        Name: "REGISTRY_PASSWORD",
1✔
428
                                        ValueFrom: &corev1.EnvVarSource{
1✔
429
                                                SecretKeyRef: &corev1.SecretKeySelector{
1✔
430
                                                        LocalObjectReference: corev1.LocalObjectReference{
1✔
431
                                                                Name: pushSecret.Name,
1✔
432
                                                        },
1✔
433
                                                        Key: "password",
1✔
434
                                                },
1✔
435
                                        },
1✔
436
                                },
1✔
437
                        )
1✔
438

439
                case corev1.SecretTypeDockerConfigJson:
1✔
440
                        job.Spec.Template.Spec.Volumes = append(job.Spec.Template.Spec.Volumes, corev1.Volume{
1✔
441
                                Name: "dockerconfig",
1✔
442
                                VolumeSource: corev1.VolumeSource{
1✔
443
                                        Secret: &corev1.SecretVolumeSource{
1✔
444
                                                SecretName: pushSecret.Name,
1✔
445
                                                Items: []corev1.KeyToPath{
1✔
446
                                                        {
1✔
447
                                                                Key:  ".dockerconfigjson",
1✔
448
                                                                Path: "dockerconfig.json",
1✔
449
                                                        },
1✔
450
                                                },
1✔
451
                                        },
1✔
452
                                },
1✔
453
                        })
1✔
454

1✔
455
                        job.Spec.Template.Spec.Containers[0].VolumeMounts = append(job.Spec.Template.Spec.Containers[0].VolumeMounts, corev1.VolumeMount{
1✔
456
                                Name:      "dockerconfig",
1✔
457
                                MountPath: "/etc/renderer/dockerconfig.json",
1✔
458
                                SubPath:   "dockerconfig.json",
1✔
459
                                ReadOnly:  true,
1✔
460
                        })
1✔
461

1✔
462
                        job.Spec.Template.Spec.Containers[0].Env = append(job.Spec.Template.Spec.Containers[0].Env, corev1.EnvVar{
1✔
463
                                Name:  "DOCKER_CONFIG",
1✔
464
                                Value: "/etc/renderer/dockerconfig.json",
1✔
465
                        })
1✔
466
                default:
42✔
467
                }
468
        }
469

470
        if err := r.Create(ctx, job); err != nil {
44✔
UNCOV
471
                r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "CreationFailed", "Create", "Failed to create job: %s", err)
×
UNCOV
472
                return errLogAndWrap(log, err, "job creation failed")
×
UNCOV
473
        }
×
474

475
        // Set owner references
476
        if err := controllerutil.SetControllerReference(res, job, r.Scheme); err != nil {
44✔
477
                return errLogAndWrap(log, err, "failed to set controller reference")
×
478
        }
×
479

480
        res.Status.JobRef = &corev1.ObjectReference{
44✔
481
                APIVersion: batchv1.SchemeGroupVersion.String(),
44✔
482
                Kind:       "Job",
44✔
483
                Namespace:  job.Namespace,
44✔
484
                Name:       job.Name,
44✔
485
        }
44✔
486

44✔
487
        if err := r.Status().Update(ctx, res); err != nil {
44✔
488
                return errLogAndWrap(log, err, "failed to update status")
×
489
        }
×
490

491
        return nil
44✔
492
}
493

494
func (r *RenderTaskReconciler) createConfigSecret(ctx context.Context, res *solarv1alpha1.RenderTask) (*corev1.Secret, error) {
97✔
495
        log := ctrl.LoggerFrom(ctx)
97✔
496

97✔
497
        cfgJson, err := json.Marshal(res.Spec.RendererConfig)
97✔
498
        if err != nil {
97✔
499
                return nil, err
×
500
        }
×
501

502
        secret := &corev1.Secret{
97✔
503
                ObjectMeta: metav1.ObjectMeta{
97✔
504
                        Name:      r.configSecretKey(res).Name,
97✔
505
                        Namespace: r.configSecretKey(res).Namespace,
97✔
506
                        OwnerReferences: []metav1.OwnerReference{
97✔
507
                                {
97✔
508
                                        APIVersion:         solarv1alpha1.SchemeGroupVersion.String(),
97✔
509
                                        Kind:               res.Kind,
97✔
510
                                        Name:               res.Name,
97✔
511
                                        UID:                res.UID,
97✔
512
                                        Controller:         new(true),
97✔
513
                                        BlockOwnerDeletion: new(true),
97✔
514
                                },
97✔
515
                        },
97✔
516
                        Annotations: map[string]string{
97✔
517
                                annotationSecretName: r.configSecretKey(res).Name,
97✔
518
                        },
97✔
519
                },
97✔
520
                Type: corev1.SecretTypeOpaque,
97✔
521
                Data: map[string][]byte{
97✔
522
                        "config.json": cfgJson,
97✔
523
                },
97✔
524
        }
97✔
525

97✔
526
        if err := r.Create(ctx, secret); err != nil {
97✔
UNCOV
527
                r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "CreationFailed", "Create", "Failed to create secret: %s", err)
×
UNCOV
528
                return nil, errLogAndWrap(log, err, "secret creation failed")
×
UNCOV
529
        }
×
530

531
        // Set owner references
532
        if err := controllerutil.SetControllerReference(res, secret, r.Scheme); err != nil {
97✔
533
                return nil, errLogAndWrap(log, err, "failed to set controller reference")
×
534
        }
×
535

536
        res.Status.ConfigSecretRef = &corev1.ObjectReference{
97✔
537
                APIVersion: corev1.SchemeGroupVersion.String(),
97✔
538
                Kind:       "Secret",
97✔
539
                Namespace:  secret.Namespace,
97✔
540
                Name:       secret.Name,
97✔
541
        }
97✔
542

97✔
543
        if err := r.Status().Update(ctx, res); err != nil {
102✔
544
                return nil, errLogAndWrap(log, err, "failed to update status")
5✔
545
        }
5✔
546

547
        return secret, nil
92✔
548
}
549

550
func (r *RenderTaskReconciler) configSecretKey(res *solarv1alpha1.RenderTask) client.ObjectKey {
559✔
551
        return client.ObjectKey{
559✔
552
                Name:      truncateName(fmt.Sprintf("render-%s", res.Name), maxK8sLabelValueLen),
559✔
553
                Namespace: r.Namespace,
559✔
554
        }
559✔
555
}
559✔
556

557
func (r *RenderTaskReconciler) renderJobKey(res *solarv1alpha1.RenderTask) client.ObjectKey {
301✔
558
        return client.ObjectKey{
301✔
559
                Name:      truncateName(fmt.Sprintf("render-%s", res.Name), maxK8sLabelValueLen),
301✔
560
                Namespace: r.Namespace,
301✔
561
        }
301✔
562
}
301✔
563

564
// isJobComplete returns true if the Job is complete (succeeded or failed)
565
func isJobComplete(job *batchv1.Job) bool {
155✔
566
        return job.Status.CompletionTime != nil || job.Status.Failed > 0
155✔
567
}
155✔
568

569
func (r *RenderTaskReconciler) referenceURL(repo string, tag string) string {
50✔
570
        base := r.BaseURL
50✔
571
        if !strings.HasPrefix(base, "oci://") {
100✔
572
                base = fmt.Sprintf("oci://%s", base)
50✔
573
        }
50✔
574
        base = strings.TrimSuffix(base, "/")
50✔
575
        url := fmt.Sprintf("%s/%s:%s", base, repo, tag)
50✔
576

50✔
577
        return url
50✔
578
}
579

580
func ttlSeconds(ttl *int32) int32 {
57✔
581
        if ttl != nil {
109✔
582
                return *ttl
52✔
583
        }
52✔
584

585
        return 3600
5✔
586
}
587

588
func shouldCleanupSecrets(res *solarv1alpha1.RenderTask, ttl time.Duration) bool {
54✔
589
        cond := apimeta.FindStatusCondition(res.Status.Conditions, ConditionTypeJobFailed)
54✔
590
        return cond != nil && time.Since(cond.LastTransitionTime.Time) >= ttl
54✔
591
}
54✔
592

593
func remainingTTL(res *solarv1alpha1.RenderTask, ttl time.Duration) time.Duration {
4✔
594
        cond := apimeta.FindStatusCondition(res.Status.Conditions, ConditionTypeJobFailed)
4✔
595
        if cond == nil {
4✔
596
                return ttl
×
597
        }
×
598
        remaining := ttl - time.Since(cond.LastTransitionTime.Time)
4✔
599
        if remaining < 0 {
4✔
600
                return 0
×
601
        }
×
602

603
        return remaining
4✔
604
}
605

606
func cleanupSecrets(ctx context.Context, r *RenderTaskReconciler, res *solarv1alpha1.RenderTask) {
53✔
607
        if err := r.deleteConfigSecret(ctx, res); err != nil && !apierrors.IsNotFound(err) {
53✔
608
                r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "DeletionFailed", "Delete", "Failed to delete config secret", err)
×
609
        }
×
610
}
611

612
func cleanupRenderResources(ctx context.Context, r *RenderTaskReconciler, res *solarv1alpha1.RenderTask, job *batchv1.Job) {
3✔
613
        cleanupSecrets(ctx, r, res)
3✔
614
        if err := r.deleteRenderJob(ctx, res); err != nil && !apierrors.IsNotFound(err) {
3✔
615
                r.Recorder.Eventf(res, job, corev1.EventTypeWarning, "DeletionFailed", "Delete", "Failed to delete job", err)
×
616
        }
×
617
}
618

619
// SetupWithManager sets up the controller with the Manager.
620
func (r *RenderTaskReconciler) SetupWithManager(mgr ctrl.Manager) error {
1✔
621
        return ctrl.NewControllerManagedBy(mgr).
1✔
622
                For(&solarv1alpha1.RenderTask{}).
1✔
623
                Owns(&batchv1.Job{}).
1✔
624
                Owns(&corev1.Secret{}).
1✔
625
                Complete(r)
1✔
626
}
1✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc