#5002

Committed 24 Mar 2026 01:11AM UTC coverage: 72.671% (+0.4%) from 72.254%

Build # #5002

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

fix: possible memory leak in tdb; (#34872)

Coverage Stats

1 of 20 new or added lines in 2 files covered. (5.0%)

539 existing lines in 124 files now uncovered.

227507 of 313065 relevant lines covered (72.67%)

147556935.28 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.0

/source/dnode/vnode/src/vnd/vnodeHash.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include "vnodeHash.h"

#define VNODE_HASH_DEFAULT_NUM_BUCKETS 1024

typedef struct SVHashEntry SVHashEntry;

struct SVHashEntry {
  SVHashEntry* next;
  void*        obj;
};

static void vHashRehash(SVHashTable* ht, uint32_t newNumBuckets) {
  SVHashEntry** newBuckets = (SVHashEntry**)taosMemoryCalloc(newNumBuckets, sizeof(SVHashEntry*));
  if (newBuckets == NULL) {
    return;
  }

  for (int32_t i = 0; i < ht->numBuckets; i++) {
    SVHashEntry* entry = ht->buckets[i];
    while (entry != NULL) {
      SVHashEntry* next = entry->next;
      uint32_t     bucketIndex = ht->hash(entry->obj) % newNumBuckets;
      entry->next = newBuckets[bucketIndex];
      newBuckets[bucketIndex] = entry;
      entry = next;
    }
  }

  taosMemoryFree(ht->buckets);
  ht->buckets = newBuckets;
  ht->numBuckets = newNumBuckets;

  return;
}

int32_t vHashInit(SVHashTable** ht, uint32_t (*hash)(const void*), int32_t (*compare)(const void*, const void*)) {
  if (ht == NULL || hash == NULL || compare == NULL) {
    return TSDB_CODE_INVALID_PARA;
  }

  (*ht) = (SVHashTable*)taosMemoryMalloc(sizeof(SVHashTable));
  if (*ht == NULL) {
    return terrno;
  }

  (*ht)->hash = hash;
  (*ht)->compare = compare;
  (*ht)->numEntries = 0;
  (*ht)->numBuckets = VNODE_HASH_DEFAULT_NUM_BUCKETS;
  (*ht)->buckets = (SVHashEntry**)taosMemoryCalloc((*ht)->numBuckets, sizeof(SVHashEntry*));
  if ((*ht)->buckets == NULL) {
    taosMemoryFree(*ht);
    return terrno;
  }

  return 0;
}

void vHashDestroy(SVHashTable** ht) {
  if (ht == NULL) {
    return;
  }

  if (*ht) {
    taosMemoryFree((*ht)->buckets);
    taosMemoryFree(*ht);
    (*ht) = NULL;
  }
}

int32_t vHashPut(SVHashTable* ht, void* obj) {
  if (ht == NULL || obj == NULL) {
    return TSDB_CODE_INVALID_PARA;
  }

  uint32_t bucketIndex = ht->hash(obj) % ht->numBuckets;
  for (SVHashEntry* entry = ht->buckets[bucketIndex]; entry != NULL; entry = entry->next) {
    if (ht->compare(entry->obj, obj) == 0) {
      return TSDB_CODE_DUP_KEY;
    }
  }

  if (ht->numEntries >= ht->numBuckets) {
    vHashRehash(ht, ht->numBuckets * 2);
    bucketIndex = ht->hash(obj) % ht->numBuckets;
  }

  SVHashEntry* entry = (SVHashEntry*)taosMemoryMalloc(sizeof(SVHashEntry));
  if (entry == NULL) {
    return terrno;
  }
  entry->obj = obj;
  entry->next = ht->buckets[bucketIndex];
  ht->buckets[bucketIndex] = entry;
  ht->numEntries++;

  return 0;
}

int32_t vHashGet(SVHashTable* ht, const void* obj, void** retObj) {
  if (ht == NULL || obj == NULL || retObj == NULL) {
    return TSDB_CODE_INVALID_PARA;
  }

  uint32_t bucketIndex = ht->hash(obj) % ht->numBuckets;
  for (SVHashEntry* entry = ht->buckets[bucketIndex]; entry != NULL; entry = entry->next) {
    if (ht->compare(entry->obj, obj) == 0) {
      *retObj = entry->obj;
      return 0;
    }
  }

  *retObj = NULL;
  return TSDB_CODE_NOT_FOUND;
}

int32_t vHashDrop(SVHashTable* ht, const void* obj) {
  if (ht == NULL || obj == NULL) {
    return TSDB_CODE_INVALID_PARA;
  }

  uint32_t bucketIndex = ht->hash(obj) % ht->numBuckets;
  for (SVHashEntry** entry = &ht->buckets[bucketIndex]; *entry != NULL; entry = &(*entry)->next) {
    if (ht->compare((*entry)->obj, obj) == 0) {
      SVHashEntry* tmp = *entry;
      *entry = (*entry)->next;
      taosMemoryFree(tmp);
      ht->numEntries--;
      if (ht->numBuckets > VNODE_HASH_DEFAULT_NUM_BUCKETS && ht->numEntries < ht->numBuckets / 4) {
        vHashRehash(ht, ht->numBuckets / 2);
      }
      return 0;
    }
  }

  return TSDB_CODE_NOT_FOUND;
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#include "vnodeHash.h"
17
18	#define VNODE_HASH_DEFAULT_NUM_BUCKETS 1024
19
20	typedef struct SVHashEntry SVHashEntry;
21
22	struct SVHashEntry {
23	SVHashEntry* next;
24	void* obj;
25	};
26
27	static void vHashRehash(SVHashTable* ht, uint32_t newNumBuckets) {	15,368✔
28	SVHashEntry newBuckets = (SVHashEntry)taosMemoryCalloc(newNumBuckets, sizeof(SVHashEntry*));	15,368✔
29	if (newBuckets == NULL) {	15,368✔
30	return;	×
31	}
32
33	for (int32_t i = 0; i < ht->numBuckets; i++) {	23,620,616✔
34	SVHashEntry* entry = ht->buckets[i];	23,605,248✔
35	while (entry != NULL) {	35,400,188✔
36	SVHashEntry* next = entry->next;	11,794,940✔
37	uint32_t bucketIndex = ht->hash(entry->obj) % newNumBuckets;	11,794,940✔
38	entry->next = newBuckets[bucketIndex];	11,794,940✔
39	newBuckets[bucketIndex] = entry;	11,794,940✔
40	entry = next;	11,794,940✔
41	}
42	}
43
44	taosMemoryFree(ht->buckets);	15,368✔
45	ht->buckets = newBuckets;	15,368✔
46	ht->numBuckets = newNumBuckets;	15,368✔
47
48	return;	15,368✔
49	}
50
51	int32_t vHashInit(SVHashTable** ht, uint32_t (hash)(const void), int32_t (compare)(const void, const void*)) {	9,168,701✔
52	if (ht == NULL \|\| hash == NULL \|\| compare == NULL) {	9,168,701✔
53	return TSDB_CODE_INVALID_PARA;	×
54	}
55
56	(ht) = (SVHashTable)taosMemoryMalloc(sizeof(SVHashTable));	9,168,701✔
57	if (*ht == NULL) {	9,168,701✔
58	return terrno;	×
59	}
60
61	(*ht)->hash = hash;	9,168,701✔
62	(*ht)->compare = compare;	9,168,701✔
63	(*ht)->numEntries = 0;	9,168,701✔
64	(*ht)->numBuckets = VNODE_HASH_DEFAULT_NUM_BUCKETS;	9,168,009✔
65	(ht)->buckets = (SVHashEntry)taosMemoryCalloc((ht)->numBuckets, sizeof(SVHashEntry*));	9,168,701✔
66	if ((*ht)->buckets == NULL) {	9,168,701✔
67	taosMemoryFree(*ht);	×
68	return terrno;	×
69	}
70
71	return 0;	9,168,701✔
72	}
73
74	void vHashDestroy(SVHashTable** ht) {	9,168,701✔
75	if (ht == NULL) {	9,168,701✔
76	return;	×
77	}
78
79	if (*ht) {	9,168,701✔
80	taosMemoryFree((*ht)->buckets);	9,168,701✔
81	taosMemoryFree(*ht);	9,168,701✔
82	(*ht) = NULL;	9,168,701✔
83	}
84	}
85
86	int32_t vHashPut(SVHashTable* ht, void* obj) {	24,455,452✔
87	if (ht == NULL \|\| obj == NULL) {	24,455,452✔
88	return TSDB_CODE_INVALID_PARA;	×
89	}
90
91	uint32_t bucketIndex = ht->hash(obj) % ht->numBuckets;	24,458,320✔
92	for (SVHashEntry* entry = ht->buckets[bucketIndex]; entry != NULL; entry = entry->next) {	31,783,737✔
93	if (ht->compare(entry->obj, obj) == 0) {	7,324,656✔
94	return TSDB_CODE_DUP_KEY;	×
95	}
96	}
97
98	if (ht->numEntries >= ht->numBuckets) {	24,455,655✔
99	vHashRehash(ht, ht->numBuckets * 2);	7,684✔
100	bucketIndex = ht->hash(obj) % ht->numBuckets;	7,684✔
101	}
102
103	SVHashEntry* entry = (SVHashEntry*)taosMemoryMalloc(sizeof(SVHashEntry));	24,457,984✔
104	if (entry == NULL) {	24,458,898✔
105	return terrno;	×
106	}
107	entry->obj = obj;	24,458,898✔
108	entry->next = ht->buckets[bucketIndex];	24,458,832✔
109	ht->buckets[bucketIndex] = entry;	24,459,570✔
110	ht->numEntries++;	24,458,218✔
111
112	return 0;	24,459,493✔
113	}
114
115	int32_t vHashGet(SVHashTable* ht, const void* obj, void** retObj) {	106,413,922✔
116	if (ht == NULL \|\| obj == NULL \|\| retObj == NULL) {	106,413,922✔
UNCOV 117	return TSDB_CODE_INVALID_PARA;	×
118	}
119
120	uint32_t bucketIndex = ht->hash(obj) % ht->numBuckets;	106,431,676✔
121	for (SVHashEntry* entry = ht->buckets[bucketIndex]; entry != NULL; entry = entry->next) {	121,685,880✔
122	if (ht->compare(entry->obj, obj) == 0) {	97,740,868✔
123	*retObj = entry->obj;	82,452,307✔
124	return 0;	82,463,349✔
125	}
126	}
127
128	*retObj = NULL;	23,953,043✔
129	return TSDB_CODE_NOT_FOUND;	23,953,043✔
130	}
131
132	int32_t vHashDrop(SVHashTable* ht, const void* obj) {	24,459,508✔
133	if (ht == NULL \|\| obj == NULL) {	24,459,508✔
134	return TSDB_CODE_INVALID_PARA;	×
135	}
136
137	uint32_t bucketIndex = ht->hash(obj) % ht->numBuckets;	24,460,976✔
138	for (SVHashEntry** entry = &ht->buckets[bucketIndex]; entry != NULL; entry = &(entry)->next) {	27,564,876✔
139	if (ht->compare((*entry)->obj, obj) == 0) {	27,564,319✔
140	SVHashEntry* tmp = *entry;	24,460,976✔
141	entry = (entry)->next;	24,460,976✔
142	taosMemoryFree(tmp);	24,460,976✔
143	ht->numEntries--;	24,460,403✔
144	if (ht->numBuckets > VNODE_HASH_DEFAULT_NUM_BUCKETS && ht->numEntries < ht->numBuckets / 4) {	24,460,976✔
145	vHashRehash(ht, ht->numBuckets / 2);	7,684✔
146	}
147	return 0;	24,460,976✔
148	}
149	}
150
151	return TSDB_CODE_NOT_FOUND;	×
152	}

taosdata / TDengine / #5002

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous