23528008920

Committed 25 Mar 2026 06:26AM UTC coverage: 16.386% (+0.004%) from 16.382%

Build # 23528008920

Build Type

push

github

Committed by

tkuhn

Commit Message

fix: read 'label' URL parameter on ResourcePartPage

The label param was ignored — the page always derived the label from
the resource ID. Now it uses the URL parameter when provided, falling
back to the ID-derived label otherwise.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

751 of 5639 branches covered (13.32%)

Branch coverage included in aggregate %.

1900 of 10539 relevant lines covered (18.03%)

2.47 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

src/main/java/com/knowledgepixels/nanodash/component/RdfResultComponent.java

package com.knowledgepixels.nanodash.component;

import com.knowledgepixels.nanodash.ApiCache;
import org.apache.wicket.Component;
import org.apache.wicket.markup.html.basic.Label;
import org.eclipse.rdf4j.model.Model;
import org.nanopub.extra.services.QueryRef;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
 * A component that asynchronously loads and displays the RDF result of a CONSTRUCT query.
 */
public abstract class RdfResultComponent extends ResultComponent {

    private final QueryRef queryRef;
    private Model model = null;
    private static final Logger logger = LoggerFactory.getLogger(RdfResultComponent.class);

    /**
     * Constructor.
     *
     * @param id       the component id
     * @param queryRef the QueryRef for the CONSTRUCT query
     */
    public RdfResultComponent(String id, QueryRef queryRef) {
        super(id);
        this.queryRef = queryRef;
    }

    private static final long LAZY_LOAD_TIMEOUT_MS = 60_000;

    @Override
    public Component getLazyLoadComponent(String markupId) {
        long deadline = System.currentTimeMillis() + LAZY_LOAD_TIMEOUT_MS;
        while (System.currentTimeMillis() < deadline) {
            if (!ApiCache.isRunning(queryRef)) {
                try {
                    model = ApiCache.retrieveRdfModelAsync(queryRef);
                    if (model != null) break;
                } catch (Exception ex) {
                    return new Label(markupId, "<span class=\"negative\">API call failed.</span>").setEscapeModelStrings(false);
                }
            }
            try {
                Thread.sleep(100);
            } catch (InterruptedException ex) {
                Thread.currentThread().interrupt();
                logger.error("Interrupted while waiting for RDF response", ex);
                break;
            }
        }
        if (model == null) {
            logger.error("Timed out waiting for RDF response for {}", queryRef);
            return new Label(markupId, "<span class=\"negative\">Loading timed out. Please reload the page.</span>").setEscapeModelStrings(false);
        }
        return getRdfResultComponent(markupId, model);
    }

    @Override
    protected boolean isContentReady() {
        return model != null || !ApiCache.isRunning(queryRef);
    }

    /**
     * Implement to return the component that displays the RDF result.
     *
     * @param markupId the markup ID for the component
     * @param model    the RDF model from the CONSTRUCT query
     * @return a Component that displays the RDF model
     */
    public abstract Component getRdfResultComponent(String markupId, Model model);

}

1	package com.knowledgepixels.nanodash.component;
2
3	import com.knowledgepixels.nanodash.ApiCache;
4	import org.apache.wicket.Component;
5	import org.apache.wicket.markup.html.basic.Label;
6	import org.eclipse.rdf4j.model.Model;
7	import org.nanopub.extra.services.QueryRef;
8	import org.slf4j.Logger;
9	import org.slf4j.LoggerFactory;
10
11	/**
12	* A component that asynchronously loads and displays the RDF result of a CONSTRUCT query.
13	*/
14	public abstract class RdfResultComponent extends ResultComponent {
15
16	private final QueryRef queryRef;
17	private Model model = null;	×
18	private static final Logger logger = LoggerFactory.getLogger(RdfResultComponent.class);	×
19
20	/**
21	* Constructor.
22	*
23	* @param id the component id
24	* @param queryRef the QueryRef for the CONSTRUCT query
25	*/
26	public RdfResultComponent(String id, QueryRef queryRef) {
27	super(id);	×
28	this.queryRef = queryRef;	×
29	}	×
30
31	private static final long LAZY_LOAD_TIMEOUT_MS = 60_000;
32
33	@Override
34	public Component getLazyLoadComponent(String markupId) {
35	long deadline = System.currentTimeMillis() + LAZY_LOAD_TIMEOUT_MS;	×
36	while (System.currentTimeMillis() < deadline) {	×
37	if (!ApiCache.isRunning(queryRef)) {	×
38	try {
39	model = ApiCache.retrieveRdfModelAsync(queryRef);	×
40	if (model != null) break;	×
41	} catch (Exception ex) {	×
42	return new Label(markupId, "<span class=\"negative\">API call failed.</span>").setEscapeModelStrings(false);	×
43	}	×
44	}
45	try {
46	Thread.sleep(100);	×
47	} catch (InterruptedException ex) {	×
48	Thread.currentThread().interrupt();	×
49	logger.error("Interrupted while waiting for RDF response", ex);	×
50	break;	×
51	}	×
52	}
53	if (model == null) {	×
54	logger.error("Timed out waiting for RDF response for {}", queryRef);	×
55	return new Label(markupId, "<span class=\"negative\">Loading timed out. Please reload the page.</span>").setEscapeModelStrings(false);	×
56	}
57	return getRdfResultComponent(markupId, model);	×
58	}
59
60	@Override
61	protected boolean isContentReady() {
62	return model != null \|\| !ApiCache.isRunning(queryRef);	×
63	}
64
65	/**
66	* Implement to return the component that displays the RDF result.
67	*
68	* @param markupId the markup ID for the component
69	* @param model the RDF model from the CONSTRUCT query
70	* @return a Component that displays the RDF model
71	*/
72	public abstract Component getRdfResultComponent(String markupId, Model model);
73
74	}

knowledgepixels / nanodash / 23528008920

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous