23374838686

Committed 21 Mar 2026 07:29AM UTC coverage: 59.341% (-20.0%) from 79.315%

Build # 23374838686

Build Type

Pull #15075

github

Committed by

web-flow

Commit Message

Merge 90b4e834f into 6587e363a

Pull Request Pull Request #15075: Stack 8001 v16.4

Coverage Stats

38 of 70 new or added lines in 10 files covered. (54.29%)

34165 existing lines in 563 files now uncovered.

119621 of 201584 relevant lines covered (59.34%)

650666.92 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/util-systemd.c

/* SPDX-License-Identifier: MIT-0 */

/* Implement the systemd notify protocol without external dependencies.
 * Supports both readiness notification on startup and on reloading,
 * according to the protocol defined at:
 * https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html
 * This protocol is guaranteed to be stable as per:
 * https://systemd.io/PORTABILITY_AND_STABILITY/ */

/* this file is copied from:
 * https://github.com/systemd/systemd/blob/main/man/notify-selfcontained-example.c
 * written by Luca Boccassi */

#include "suricata-common.h"

#if (defined SYSTEMD_NOTIFY) && (defined HAVE_SYS_UN_H) && (defined HAVE_SYS_STAT_H) &&            \
        (defined HAVE_SYS_TYPES_H)
#include <sys/un.h>
#include <sys/stat.h>
#include <sys/types.h>

#include "util-systemd.h"

#define _cleanup_(f) __attribute__((cleanup(f)))

static void closep(int *fd)
{
    if (!fd || *fd < 0)
        return;

    close(*fd);
    *fd = -1;
}

static int Notify(const char *message)
{
    union sockaddr_union {
        struct sockaddr sa;
        struct sockaddr_un sun;
    } socket_addr = {
        .sun.sun_family = AF_UNIX,
    };
    size_t path_length, message_length;
    _cleanup_(closep) int fd = -1;
    const char *socket_path;

    socket_path = getenv("NOTIFY_SOCKET");
    if (!socket_path)
        return 0; /* Not running under systemd? Nothing to do */

    if (!message)
        return -EINVAL;

    message_length = strlen(message);
    if (message_length == 0)
        return -EINVAL;

    /* Only AF_UNIX is supported, with path or abstract sockets */
    if (socket_path[0] != '/' && socket_path[0] != '@')
        return -EAFNOSUPPORT;

    path_length = strlen(socket_path);
    /* Ensure there is room for NUL byte */
    if (path_length >= sizeof(socket_addr.sun.sun_path))
        return -E2BIG;

    memcpy(socket_addr.sun.sun_path, socket_path, path_length);

    /* Support for abstract socket */
    if (socket_addr.sun.sun_path[0] == '@')
        socket_addr.sun.sun_path[0] = 0;

    fd = socket(AF_UNIX, SOCK_DGRAM | SOCK_CLOEXEC, 0);
    if (fd < 0)
        return -errno;

    if (connect(fd, &socket_addr.sa,
                offsetof(struct sockaddr_un, sun_path) + (uint32_t)path_length) != 0)
        return -errno;

    ssize_t written = write(fd, message, message_length);
    if (written != (ssize_t)message_length)
        return written < 0 ? -errno : -EPROTO;

    return 1; /* Notified! */
}

int SystemDNotifyReady(void)
{
    return Notify("READY=1");
}
#endif

1	/* SPDX-License-Identifier: MIT-0 */
2
3	/* Implement the systemd notify protocol without external dependencies.
4	* Supports both readiness notification on startup and on reloading,
5	* according to the protocol defined at:
6	* https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html
7	* This protocol is guaranteed to be stable as per:
8	* https://systemd.io/PORTABILITY_AND_STABILITY/ */
9
10	/* this file is copied from:
11	* https://github.com/systemd/systemd/blob/main/man/notify-selfcontained-example.c
12	* written by Luca Boccassi */
13
14	#include "suricata-common.h"
15
16	#if (defined SYSTEMD_NOTIFY) && (defined HAVE_SYS_UN_H) && (defined HAVE_SYS_STAT_H) && \
17	(defined HAVE_SYS_TYPES_H)
18	#include <sys/un.h>
19	#include <sys/stat.h>
20	#include <sys/types.h>
21
22	#include "util-systemd.h"
23
UNCOV 24	#define _cleanup_(f) __attribute__((cleanup(f)))	×
25
26	static void closep(int *fd)
UNCOV 27	{	×
UNCOV 28	if (!fd \|\| *fd < 0)	×
UNCOV 29	return;	×
30
31	close(*fd);	×
32	*fd = -1;	×
33	}	×
34
35	static int Notify(const char *message)
UNCOV 36	{	×
UNCOV 37	union sockaddr_union {	×
UNCOV 38	struct sockaddr sa;	×
UNCOV 39	struct sockaddr_un sun;	×
UNCOV 40	} socket_addr = {	×
UNCOV 41	.sun.sun_family = AF_UNIX,	×
UNCOV 42	};	×
UNCOV 43	size_t path_length, message_length;	×
UNCOV 44	_cleanup_(closep) int fd = -1;	×
UNCOV 45	const char *socket_path;	×
46
UNCOV 47	socket_path = getenv("NOTIFY_SOCKET");	×
UNCOV 48	if (!socket_path)	×
UNCOV 49	return 0; /* Not running under systemd? Nothing to do */	×
50
51	if (!message)	×
52	return -EINVAL;	×
53
54	message_length = strlen(message);	×
55	if (message_length == 0)	×
56	return -EINVAL;	×
57
58	/* Only AF_UNIX is supported, with path or abstract sockets */
59	if (socket_path[0] != '/' && socket_path[0] != '@')	×
60	return -EAFNOSUPPORT;	×
61
62	path_length = strlen(socket_path);	×
63	/* Ensure there is room for NUL byte */
64	if (path_length >= sizeof(socket_addr.sun.sun_path))	×
65	return -E2BIG;	×
66
67	memcpy(socket_addr.sun.sun_path, socket_path, path_length);	×
68
69	/* Support for abstract socket */
70	if (socket_addr.sun.sun_path[0] == '@')	×
71	socket_addr.sun.sun_path[0] = 0;	×
72
73	fd = socket(AF_UNIX, SOCK_DGRAM \| SOCK_CLOEXEC, 0);	×
74	if (fd < 0)	×
75	return -errno;	×
76
77	if (connect(fd, &socket_addr.sa,	×
78	offsetof(struct sockaddr_un, sun_path) + (uint32_t)path_length) != 0)	×
79	return -errno;	×
80
81	ssize_t written = write(fd, message, message_length);	×
82	if (written != (ssize_t)message_length)	×
83	return written < 0 ? -errno : -EPROTO;	×
84
85	return 1; /* Notified! */	×
86	}	×
87
88	int SystemDNotifyReady(void)
UNCOV 89	{	×
UNCOV 90	return Notify("READY=1");	×
UNCOV 91	}	×
92	#endif

OISF / suricata / 23374838686

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous