23374838686

Committed 21 Mar 2026 07:29AM UTC coverage: 59.341% (-20.0%) from 79.315%

Build # 23374838686

Build Type

Pull #15075

github

Committed by

web-flow

Commit Message

Merge 90b4e834f into 6587e363a

Pull Request Pull Request #15075: Stack 8001 v16.4

Coverage Stats

38 of 70 new or added lines in 10 files covered. (54.29%)

34165 existing lines in 563 files now uncovered.

119621 of 201584 relevant lines covered (59.34%)

650666.92 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/util-pidfile.c

/* Copyright (C) 2007-2010 Open Information Security Foundation
 *
 * You can copy, redistribute or modify this Program under the terms of
 * the GNU General Public License version 2 as published by the Free
 * Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * version 2 along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
 * 02110-1301, USA.
 */

/**
 * \file
 *
 * \author Pablo Rincon Crespo <pablo.rincon.crespo@gmail.com>
 * \author Victor Julien <victor@inliniac.net>
 *
 * Utility code for dealing with a pidfile.
 * Adaptation of Steve Grubbs patch to our coding guidelines
 * (thanks for the patch Steve ;)
 */

#include "suricata-common.h"
#include "util-pidfile.h"
#include "util-debug.h"

/**
 * \brief Write a pid file (used at the startup)
 *        This commonly needed by the init scripts
 *
 * \param pointer to the name of the pid file to write (optarg)
 *
 * \retval 0 if succes
 * \retval -1 on failure
 */
int SCPidfileCreate(const char *pidfile)
{
    SCEnter();

    int pidfd = 0;
    char val[32];

    size_t len = snprintf(val, sizeof(val), "%"PRIuMAX"\n", (uintmax_t)getpid());
    if (len <= 0) {
        SCLogError("Pid error (%s)", strerror(errno));
        SCReturnInt(-1);
    }

    pidfd = open(pidfile, O_CREAT | O_TRUNC | O_NOFOLLOW | O_WRONLY, 0644);
    if (pidfd < 0) {
        SCLogError("unable to set pidfile '%s': %s", pidfile, strerror(errno));
        SCReturnInt(-1);
    }

    ssize_t r = write(pidfd, val, (unsigned int)len);
    if (r == -1) {
        SCLogError("unable to write pidfile: %s", strerror(errno));
        close(pidfd);
        SCReturnInt(-1);
    } else if ((size_t)r != len) {
        SCLogError("unable to write pidfile: wrote"
                   " %" PRIdMAX " of %" PRIuMAX " bytes.",
                (intmax_t)r, (uintmax_t)len);
        close(pidfd);
        SCReturnInt(-1);
    }

    close(pidfd);
    SCReturnInt(0);
}

/**
 * \brief Remove the pid file (used at the startup)
 *
 * \param pointer to the name of the pid file to write (optarg)
 */
void SCPidfileRemove(const char *pid_filename)
{
    if (pid_filename != NULL) {
        /* we ignore the result, the user may have removed the file already. */
        (void)unlink(pid_filename);
    }
}

/**
 * \brief Check the Suricata pid file (used at the startup)
 *
 * This commonly needed by the init scripts.
 *
 * This function will fail if the PID file exists, but tries to log a
 * meaningful message if appears Suricata is running, or if the PID
 * file appears to be stale.
 *
 * \param pointer to the name of the pid file to write (optarg)
 *
 * \retval 0 if succes
 * \retval -1 on failure
 */
int SCPidfileTestRunning(const char *pid_filename)
{
    /* Check if the existing process is still alive. */
    FILE *pf;

    pf = fopen(pid_filename, "r");
    if (pf == NULL) {
        if (access(pid_filename, F_OK) == 0) {
            SCLogError("pid file '%s' exists and can not be read. Aborting!", pid_filename);
            return -1;
        } else {
            return 0;
        }
    }

#ifndef OS_WIN32
    pid_t pidv;
    if (fscanf(pf, "%d", &pidv) == 1 && kill(pidv, 0) == 0) {
        SCLogError("pid file '%s' exists and Suricata appears to be running. "
                   "Aborting!",
                pid_filename);
    } else
#endif
    {
        SCLogError("pid file '%s' exists but appears stale. "
                   "Make sure Suricata is not running and then remove %s. "
                   "Aborting!",
                pid_filename, pid_filename);
    }

    fclose(pf);
    return -1;
}

1	/* Copyright (C) 2007-2010 Open Information Security Foundation
2	*
3	* You can copy, redistribute or modify this Program under the terms of
4	* the GNU General Public License version 2 as published by the Free
5	* Software Foundation.
6	*
7	* This program is distributed in the hope that it will be useful,
8	* but WITHOUT ANY WARRANTY; without even the implied warranty of
9	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10	* GNU General Public License for more details.
11	*
12	* You should have received a copy of the GNU General Public License
13	* version 2 along with this program; if not, write to the Free Software
14	* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
15	* 02110-1301, USA.
16	*/
17
18	/**
19	* \file
20	*
21	* \author Pablo Rincon Crespo <pablo.rincon.crespo@gmail.com>
22	* \author Victor Julien <victor@inliniac.net>
23	*
24	* Utility code for dealing with a pidfile.
25	* Adaptation of Steve Grubbs patch to our coding guidelines
26	* (thanks for the patch Steve ;)
27	*/
28
29	#include "suricata-common.h"
30	#include "util-pidfile.h"
31	#include "util-debug.h"
32
33	/**
34	* \brief Write a pid file (used at the startup)
35	* This commonly needed by the init scripts
36	*
37	* \param pointer to the name of the pid file to write (optarg)
38	*
39	* \retval 0 if succes
40	* \retval -1 on failure
41	*/
42	int SCPidfileCreate(const char *pidfile)
43	{	×
44	SCEnter();	×
45
46	int pidfd = 0;	×
47	char val[32];	×
48
49	size_t len = snprintf(val, sizeof(val), "%"PRIuMAX"\n", (uintmax_t)getpid());	×
50	if (len <= 0) {	×
51	SCLogError("Pid error (%s)", strerror(errno));	×
52	SCReturnInt(-1);	×
53	}	×
54
55	pidfd = open(pidfile, O_CREAT \| O_TRUNC \| O_NOFOLLOW \| O_WRONLY, 0644);	×
56	if (pidfd < 0) {	×
57	SCLogError("unable to set pidfile '%s': %s", pidfile, strerror(errno));	×
58	SCReturnInt(-1);	×
59	}	×
60
61	ssize_t r = write(pidfd, val, (unsigned int)len);	×
62	if (r == -1) {	×
63	SCLogError("unable to write pidfile: %s", strerror(errno));	×
64	close(pidfd);	×
65	SCReturnInt(-1);	×
66	} else if ((size_t)r != len) {	×
67	SCLogError("unable to write pidfile: wrote"	×
68	" %" PRIdMAX " of %" PRIuMAX " bytes.",	×
69	(intmax_t)r, (uintmax_t)len);	×
70	close(pidfd);	×
71	SCReturnInt(-1);	×
72	}	×
73
74	close(pidfd);	×
75	SCReturnInt(0);	×
76	}	×
77
78	/**
79	* \brief Remove the pid file (used at the startup)
80	*
81	* \param pointer to the name of the pid file to write (optarg)
82	*/
83	void SCPidfileRemove(const char *pid_filename)
UNCOV 84	{	×
UNCOV 85	if (pid_filename != NULL) {	×
86	/* we ignore the result, the user may have removed the file already. */
87	(void)unlink(pid_filename);	×
88	}	×
UNCOV 89	}	×
90
91	/**
92	* \brief Check the Suricata pid file (used at the startup)
93	*
94	* This commonly needed by the init scripts.
95	*
96	* This function will fail if the PID file exists, but tries to log a
97	* meaningful message if appears Suricata is running, or if the PID
98	* file appears to be stale.
99	*
100	* \param pointer to the name of the pid file to write (optarg)
101	*
102	* \retval 0 if succes
103	* \retval -1 on failure
104	*/
105	int SCPidfileTestRunning(const char *pid_filename)
106	{	×
107	/* Check if the existing process is still alive. */
108	FILE *pf;	×
109
110	pf = fopen(pid_filename, "r");	×
111	if (pf == NULL) {	×
112	if (access(pid_filename, F_OK) == 0) {	×
113	SCLogError("pid file '%s' exists and can not be read. Aborting!", pid_filename);	×
114	return -1;	×
115	} else {	×
116	return 0;	×
117	}	×
118	}	×
119
120	#ifndef OS_WIN32	×
121	pid_t pidv;	×
122	if (fscanf(pf, "%d", &pidv) == 1 && kill(pidv, 0) == 0) {	×
123	SCLogError("pid file '%s' exists and Suricata appears to be running. "	×
124	"Aborting!",	×
125	pid_filename);	×
126	} else	×
127	#endif	×
128	{	×
129	SCLogError("pid file '%s' exists but appears stale. "	×
130	"Make sure Suricata is not running and then remove %s. "	×
131	"Aborting!",	×
132	pid_filename, pid_filename);	×
133	}	×
134
135	fclose(pf);	×
136	return -1;	×
137	}	×

OISF / suricata / 23374838686

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous