23225340130

Committed 18 Mar 2026 01:53AM UTC coverage: 89.677% (-0.001%) from 89.678%

Build # 23225340130

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #5456 from randombit/jack/clang-tidy-22

Fix various warnings from clang-tidy 22

Run Details

104438 of 116460 relevant lines covered (89.68%)

11819947.55 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.46

/src/cli/zfec.cpp

/*
* (C) 2021 Jack Lloyd
*
* Botan is released under the Simplified BSD License (see license.txt)
*/

#include "cli.h"

#if defined(BOTAN_HAS_ZFEC) && defined(BOTAN_HAS_SHA2_64)
   #include <botan/hash.h>
   #include <botan/mem_ops.h>
   #include <botan/zfec.h>
   #include <botan/internal/loadstor.h>
   #include <fstream>
   #include <sstream>
#endif

namespace Botan_CLI {

namespace {

#if defined(BOTAN_HAS_ZFEC) && defined(BOTAN_HAS_SHA2_64)

constexpr uint32_t FEC_MAGIC = 0xFECC0DEC;
const char* const FEC_SHARE_HASH = "SHA-512-256";

class FEC_Share final {
   public:
      FEC_Share() : m_share(0), m_k(0), m_n(0), m_padding(0) {}

      FEC_Share(size_t share, size_t k, size_t n, size_t padding, const uint8_t bits[], size_t len) :
            m_share(share), m_k(k), m_n(n), m_padding(padding), m_bits(bits, bits + len) {}

      size_t share_id() const { return m_share; }

      size_t k() const { return m_k; }

      size_t n() const { return m_n; }

      size_t padding() const { return m_padding; }

      size_t share_size() const { return m_bits.size(); }

      const uint8_t* share_data() const { return m_bits.data(); }

      static FEC_Share deserialize(const uint8_t bits[], size_t len, Botan::HashFunction& hash) {
         const size_t hash_len = hash.output_length();

         if(len < FEC_SHARE_HEADER_LEN + hash_len) {
            throw CLI_Error("FEC share is too short to be valid");
         }

         if(Botan::load_be<uint32_t>(bits, 0) != FEC_MAGIC) {
            throw CLI_Error("FEC share does not have expected magic bytes");
         }

         // verify that reserved bytes are zero
         for(size_t i = 8; i != 12; ++i) {
            if(bits[i] != 0) {
               throw CLI_Error("FEC share has reserved header bytes set");
            }
         }

         const size_t share_id = bits[4];
         const size_t k = bits[5];
         const size_t n = bits[6];
         const size_t padding = bits[7];

         if(share_id >= n || k >= n || padding >= k) {
            throw CLI_Error("FEC share has invalid k/n/padding fields");
         }

         hash.update(bits, len - hash_len);
         auto share_hash = hash.final();

         const bool digest_ok = Botan::constant_time_compare(share_hash.data(), &bits[len - hash_len], hash_len);

         if(!digest_ok) {
            throw CLI_Error("FEC share has invalid hash");
         }

         return FEC_Share(
            share_id, k, n, padding, bits + FEC_SHARE_HEADER_LEN, len - (FEC_SHARE_HEADER_LEN + hash_len));
      }

      void serialize_to(Botan::HashFunction& hash, std::ostream& out) const {
         uint8_t header[FEC_SHARE_HEADER_LEN] = {0};

         Botan::store_be(FEC_MAGIC, header);
         header[4] = static_cast<uint8_t>(m_share);
         header[5] = static_cast<uint8_t>(m_k);
         header[6] = static_cast<uint8_t>(m_n);
         header[7] = static_cast<uint8_t>(m_padding);
         // bytes 8..12 left as zero/reserved

         out.write(reinterpret_cast<const char*>(header), sizeof(header));
         out.write(reinterpret_cast<const char*>(m_bits.data()), m_bits.size());

         hash.update(header, sizeof(header));
         hash.update(m_bits);
         auto digest = hash.final();

         out.write(reinterpret_cast<const char*>(digest.data()), digest.size());
      }

   private:
      static const size_t FEC_SHARE_HEADER_LEN = 12;

      size_t m_share;
      size_t m_k;
      size_t m_n;
      size_t m_padding;
      std::vector<uint8_t> m_bits;
};

class FEC_Encode final : public Command {
   public:
      FEC_Encode() : Command("fec_encode --suffix=fec --prefix= --output-dir= k n input") {}

      std::string group() const override { return "fec"; }

      std::string description() const override { return "Forward error encode a file"; }

      void go() override {
         const size_t k = get_arg_sz("k");
         const size_t n = get_arg_sz("n");

         const std::string suffix = get_arg("suffix");
         const std::string prefix = get_arg("prefix");
         const std::string input = get_arg("input");
         const std::string output_dir = get_arg("output-dir");

         const Botan::ZFEC fec(k, n);  // checks k/n for validity

         auto hash = Botan::HashFunction::create_or_throw(FEC_SHARE_HASH);

         auto input_data = slurp_file(get_arg("input"));

         // append a hash of the input
         hash->update(input_data);
         const auto hash_of_input = hash->final();
         input_data.insert(input_data.end(), hash_of_input.begin(), hash_of_input.end());

         // add padding 0x00 bytes as needed to round up to k multiple
         size_t padding = 0;
         while(input_data.size() % k != 0) {
            padding += 1;
            input_data.push_back(0x00);
         }

         auto encoder_fn = [&](size_t share, const uint8_t bits[], size_t len) {
            std::ostringstream output_fsname;

            if(!output_dir.empty()) {
               output_fsname << output_dir << "/";
            }

            if(!prefix.empty()) {
               output_fsname << prefix;
            } else {
               output_fsname << input;
            }

            output_fsname << "." << (share + 1) << "_" << n;

            if(!suffix.empty()) {
               output_fsname << "." << suffix;
            }

            std::ofstream output(output_fsname.str(), std::ios::binary);

            const FEC_Share fec_share(share, k, n, padding, bits, len);
            fec_share.serialize_to(*hash, output);
         };

         fec.encode(input_data.data(), input_data.size(), encoder_fn);
      }
};

BOTAN_REGISTER_COMMAND("fec_encode", FEC_Encode);

class FEC_Decode final : public Command {
   public:
      FEC_Decode() : Command("fec_decode *shares") {}

      std::string group() const override { return "fec"; }

      std::string description() const override { return "Recover data from FEC shares"; }

      void go() override {
         auto hash = Botan::HashFunction::create_or_throw(FEC_SHARE_HASH);
         const size_t hash_len = hash->output_length();

         std::vector<FEC_Share> shares;

         for(const auto& share_fsname : get_arg_list("shares")) {
            const auto share_bits = slurp_file(share_fsname);

            try {
               auto share = FEC_Share::deserialize(share_bits.data(), share_bits.size(), *hash);
               shares.push_back(share);
            } catch(std::exception& e) {
               error_output() << "Ignoring invalid share '" << share_fsname << "': " << e.what() << "\n";
            }
         }

         if(shares.empty()) {
            error_output() << "Must provide a list of at least k shares\n";
            this->set_return_code(1);
            return;
         }

         size_t k = 0;
         size_t n = 0;
         size_t padding = 0;
         size_t share_size = 0;

         for(const auto& share : shares) {
            if(k == 0 && n == 0 && padding == 0) {
               k = share.k();
               n = share.n();
               padding = share.padding();
               share_size = share.share_size();
            } else {
               if(share.k() != k || share.n() != n || share.padding() != padding || share.share_size() != share_size) {
                  error_output() << "Shares have mismatched k/n/padding/size values\n";
                  this->set_return_code(2);
                  return;
               }
            }
         }

         if(shares.size() < k) {
            error_output() << "At least " << k << " shares are required for recovery\n";
            this->set_return_code(2);
            return;
         }

         const Botan::ZFEC fec(k, n);

         std::vector<uint8_t> decoded(share_size * k);

         auto decoder_fn = [&](size_t share, const uint8_t bits[], size_t len) {
            std::memcpy(&decoded[share * share_size], bits, len);
         };

         std::map<size_t, const uint8_t*> share_ptrs;

         for(auto& share : shares) {
            share_ptrs[share.share_id()] = share.share_data();
         }

         fec.decode_shares(share_ptrs, share_size, decoder_fn);

         auto decoded_digest = hash->process(decoded.data(), decoded.size() - (hash_len + padding));

         if(!Botan::constant_time_compare(
               decoded_digest.data(), &decoded[decoded.size() - (hash_len + padding)], hash_len)) {
            throw CLI_Error("Recovered data failed digest check");
         }

         for(size_t i = 0; i != padding; ++i) {
            if(decoded[decoded.size() - padding + i] != 0) {
               throw CLI_Error("Recovered data had non-zero padding bytes");
            }
         }

         output_binary().write(reinterpret_cast<const char*>(decoded.data()), decoded.size() - (hash_len + padding));
      }
};

BOTAN_REGISTER_COMMAND("fec_decode", FEC_Decode);

class FEC_Info final : public Command {
   public:
      FEC_Info() : Command("fec_info share") {}

      std::string group() const override { return "fec"; }

      std::string description() const override { return "Display information about a FEC share"; }

      void go() override {
         auto hash = Botan::HashFunction::create_or_throw(FEC_SHARE_HASH);

         const std::string share_fsname = get_arg("share");
         const auto share_bits = slurp_file(share_fsname);

         try {
            auto share = FEC_Share::deserialize(share_bits.data(), share_bits.size(), *hash);
            output() << "FEC share " << share.share_id() + 1 << "/" << share.n() << " with " << share.k()
                     << " needed for recovery\n";
         } catch(std::exception& e) {
            error_output() << "Invalid share '" << share_fsname << "': " << e.what() << "\n";
         }
      }
};

BOTAN_REGISTER_COMMAND("fec_info", FEC_Info);

#endif

}  // namespace

}  // namespace Botan_CLI

1	/*
2	* (C) 2021 Jack Lloyd
3	*
4	* Botan is released under the Simplified BSD License (see license.txt)
5	*/
6
7	#include "cli.h"
8
9	#if defined(BOTAN_HAS_ZFEC) && defined(BOTAN_HAS_SHA2_64)
10	#include <botan/hash.h>
11	#include <botan/mem_ops.h>
12	#include <botan/zfec.h>
13	#include <botan/internal/loadstor.h>
14	#include <fstream>
15	#include <sstream>
16	#endif
17
18	namespace Botan_CLI {
19
20	namespace {
21
22	#if defined(BOTAN_HAS_ZFEC) && defined(BOTAN_HAS_SHA2_64)
23
24	constexpr uint32_t FEC_MAGIC = 0xFECC0DEC;
25	const char* const FEC_SHARE_HASH = "SHA-512-256";
26
27	class FEC_Share final {	34✔
28	public:
29	FEC_Share() : m_share(0), m_k(0), m_n(0), m_padding(0) {}
30
31	FEC_Share(size_t share, size_t k, size_t n, size_t padding, const uint8_t bits[], size_t len) :	15✔
32	m_share(share), m_k(k), m_n(n), m_padding(padding), m_bits(bits, bits + len) {}	30✔
33
34	size_t share_id() const { return m_share; }	3✔
35
36	size_t k() const { return m_k; }	10✔
37
38	size_t n() const { return m_n; }	10✔
39
40	size_t padding() const { return m_padding; }	5✔
41
42	size_t share_size() const { return m_bits.size(); }	3✔
43
44	const uint8_t* share_data() const { return m_bits.data(); }	3✔
45
46	static FEC_Share deserialize(const uint8_t bits[], size_t len, Botan::HashFunction& hash) {	10✔
47	const size_t hash_len = hash.output_length();	10✔
48
49	if(len < FEC_SHARE_HEADER_LEN + hash_len) {	10✔
50	throw CLI_Error("FEC share is too short to be valid");	×
51	}
52
53	if(Botan::load_be<uint32_t>(bits, 0) != FEC_MAGIC) {	10✔
54	throw CLI_Error("FEC share does not have expected magic bytes");	×
55	}
56
57	// verify that reserved bytes are zero
58	for(size_t i = 8; i != 12; ++i) {	50✔
59	if(bits[i] != 0) {	40✔
60	throw CLI_Error("FEC share has reserved header bytes set");	×
61	}
62	}
63
64	const size_t share_id = bits[4];	10✔
65	const size_t k = bits[5];	10✔
66	const size_t n = bits[6];	10✔
67	const size_t padding = bits[7];	10✔
68
69	if(share_id >= n \|\| k >= n \|\| padding >= k) {	10✔
70	throw CLI_Error("FEC share has invalid k/n/padding fields");	×
71	}
72
73	hash.update(bits, len - hash_len);	10✔
74	auto share_hash = hash.final();	10✔
75
76	const bool digest_ok = Botan::constant_time_compare(share_hash.data(), &bits[len - hash_len], hash_len);	10✔
77
78	if(!digest_ok) {	10✔
79	throw CLI_Error("FEC share has invalid hash");	×
80	}
81
82	return FEC_Share(	10✔
83	share_id, k, n, padding, bits + FEC_SHARE_HEADER_LEN, len - (FEC_SHARE_HEADER_LEN + hash_len));	10✔
84	}	10✔
85
86	void serialize_to(Botan::HashFunction& hash, std::ostream& out) const {	5✔
87	uint8_t header[FEC_SHARE_HEADER_LEN] = {0};	5✔
88
89	Botan::store_be(FEC_MAGIC, header);	5✔
90	header[4] = static_cast<uint8_t>(m_share);	5✔
91	header[5] = static_cast<uint8_t>(m_k);	5✔
92	header[6] = static_cast<uint8_t>(m_n);	5✔
93	header[7] = static_cast<uint8_t>(m_padding);	5✔
94	// bytes 8..12 left as zero/reserved
95
96	out.write(reinterpret_cast<const char*>(header), sizeof(header));	5✔
97	out.write(reinterpret_cast<const char*>(m_bits.data()), m_bits.size());	5✔
98
99	hash.update(header, sizeof(header));	5✔
100	hash.update(m_bits);	5✔
101	auto digest = hash.final();	5✔
102
103	out.write(reinterpret_cast<const char*>(digest.data()), digest.size());	5✔
104	}	5✔
105
106	private:
107	static const size_t FEC_SHARE_HEADER_LEN = 12;
108
109	size_t m_share;
110	size_t m_k;
111	size_t m_n;
112	size_t m_padding;
113	std::vector<uint8_t> m_bits;
114	};
115
116	class FEC_Encode final : public Command {
117	public:
118	FEC_Encode() : Command("fec_encode --suffix=fec --prefix= --output-dir= k n input") {}	4✔
119
120	std::string group() const override { return "fec"; }	1✔
121
122	std::string description() const override { return "Forward error encode a file"; }	1✔
123
124	void go() override {	1✔
125	const size_t k = get_arg_sz("k");	1✔
126	const size_t n = get_arg_sz("n");	1✔
127
128	const std::string suffix = get_arg("suffix");	1✔
129	const std::string prefix = get_arg("prefix");	1✔
130	const std::string input = get_arg("input");	1✔
131	const std::string output_dir = get_arg("output-dir");	1✔
132
133	const Botan::ZFEC fec(k, n); // checks k/n for validity	1✔
134
135	auto hash = Botan::HashFunction::create_or_throw(FEC_SHARE_HASH);	1✔
136
137	auto input_data = slurp_file(get_arg("input"));	2✔
138
139	// append a hash of the input
140	hash->update(input_data);	1✔
141	const auto hash_of_input = hash->final();	1✔
142	input_data.insert(input_data.end(), hash_of_input.begin(), hash_of_input.end());	1✔
143
144	// add padding 0x00 bytes as needed to round up to k multiple
145	size_t padding = 0;	1✔
146	while(input_data.size() % k != 0) {	2✔
147	padding += 1;	1✔
148	input_data.push_back(0x00);	1✔
149	}
150
151	auto encoder_fn = [&](size_t share, const uint8_t bits[], size_t len) {	6✔
152	std::ostringstream output_fsname;	5✔
153
154	if(!output_dir.empty()) {	5✔
155	output_fsname << output_dir << "/";	5✔
156	}
157
158	if(!prefix.empty()) {	5✔
159	output_fsname << prefix;	5✔
160	} else {
161	output_fsname << input;	×
162	}
163
164	output_fsname << "." << (share + 1) << "_" << n;	5✔
165
166	if(!suffix.empty()) {	5✔
167	output_fsname << "." << suffix;	5✔
168	}
169
170	std::ofstream output(output_fsname.str(), std::ios::binary);	5✔
171
172	const FEC_Share fec_share(share, k, n, padding, bits, len);	5✔
173	fec_share.serialize_to(*hash, output);	5✔
174	};	5✔
175
176	fec.encode(input_data.data(), input_data.size(), encoder_fn);	2✔
177	}	4✔
178	};
179
180	BOTAN_REGISTER_COMMAND("fec_encode", FEC_Encode);	2✔
181
182	class FEC_Decode final : public Command {
183	public:
184	FEC_Decode() : Command("fec_decode *shares") {}	3✔
185
186	std::string group() const override { return "fec"; }	1✔
187
188	std::string description() const override { return "Recover data from FEC shares"; }	1✔
189
190	void go() override {	2✔
191	auto hash = Botan::HashFunction::create_or_throw(FEC_SHARE_HASH);	2✔
192	const size_t hash_len = hash->output_length();	2✔
193
194	std::vector<FEC_Share> shares;	2✔
195
196	for(const auto& share_fsname : get_arg_list("shares")) {	7✔
197	const auto share_bits = slurp_file(share_fsname);	5✔
198
199	try {	5✔
200	auto share = FEC_Share::deserialize(share_bits.data(), share_bits.size(), *hash);	5✔
201	shares.push_back(share);	5✔
202	} catch(std::exception& e) {	5✔
203	error_output() << "Ignoring invalid share '" << share_fsname << "': " << e.what() << "\n";	×
204	}	×
205	}	7✔
206
207	if(shares.empty()) {	2✔
208	error_output() << "Must provide a list of at least k shares\n";	×
209	this->set_return_code(1);	×
210	return;	×
211	}
212
213	size_t k = 0;	2✔
214	size_t n = 0;	2✔
215	size_t padding = 0;	2✔
216	size_t share_size = 0;	2✔
217
218	for(const auto& share : shares) {	7✔
219	if(k == 0 && n == 0 && padding == 0) {	5✔
220	k = share.k();	2✔
221	n = share.n();	2✔
222	padding = share.padding();	2✔
223	share_size = share.share_size();	2✔
224	} else {
225	if(share.k() != k \|\| share.n() != n \|\| share.padding() != padding \|\| share.share_size() != share_size) {	3✔
226	error_output() << "Shares have mismatched k/n/padding/size values\n";	×
227	this->set_return_code(2);	×
228	return;	×
229	}
230	}
231	}
232
233	if(shares.size() < k) {	2✔
234	error_output() << "At least " << k << " shares are required for recovery\n";	1✔
235	this->set_return_code(2);	1✔
236	return;	1✔
237	}
238
239	const Botan::ZFEC fec(k, n);	1✔
240
241	std::vector<uint8_t> decoded(share_size * k);	1✔
242
243	auto decoder_fn = [&](size_t share, const uint8_t bits[], size_t len) {	4✔
244	std::memcpy(&decoded[share * share_size], bits, len);	3✔
245	};	4✔
246
247	std::map<size_t, const uint8_t*> share_ptrs;	1✔
248
249	for(auto& share : shares) {	4✔
250	share_ptrs[share.share_id()] = share.share_data();	3✔
251	}
252
253	fec.decode_shares(share_ptrs, share_size, decoder_fn);	1✔
254
255	auto decoded_digest = hash->process(decoded.data(), decoded.size() - (hash_len + padding));	1✔
256
257	if(!Botan::constant_time_compare(	1✔
258	decoded_digest.data(), &decoded[decoded.size() - (hash_len + padding)], hash_len)) {	1✔
259	throw CLI_Error("Recovered data failed digest check");	×
260	}
261
262	for(size_t i = 0; i != padding; ++i) {	2✔
263	if(decoded[decoded.size() - padding + i] != 0) {	1✔
264	throw CLI_Error("Recovered data had non-zero padding bytes");	×
265	}
266	}
267
268	output_binary().write(reinterpret_cast<const char*>(decoded.data()), decoded.size() - (hash_len + padding));	1✔
269	}	6✔
270	};
271
272	BOTAN_REGISTER_COMMAND("fec_decode", FEC_Decode);	3✔
273
274	class FEC_Info final : public Command {
275	public:
276	FEC_Info() : Command("fec_info share") {}	12✔
277
278	std::string group() const override { return "fec"; }	1✔
279
280	std::string description() const override { return "Display information about a FEC share"; }	1✔
281
282	void go() override {	5✔
283	auto hash = Botan::HashFunction::create_or_throw(FEC_SHARE_HASH);	5✔
284
285	const std::string share_fsname = get_arg("share");	5✔
286	const auto share_bits = slurp_file(share_fsname);	5✔
287
288	try {	5✔
289	auto share = FEC_Share::deserialize(share_bits.data(), share_bits.size(), *hash);	5✔
290	output() << "FEC share " << share.share_id() + 1 << "/" << share.n() << " with " << share.k()	5✔
291	<< " needed for recovery\n";	5✔
292	} catch(std::exception& e) {	5✔
293	error_output() << "Invalid share '" << share_fsname << "': " << e.what() << "\n";	×
294	}	×
295	}	10✔
296	};
297
298	BOTAN_REGISTER_COMMAND("fec_info", FEC_Info);	6✔
299
300	#endif
301
302	} // namespace
303
304	} // namespace Botan_CLI

randombit / botan / 23225340130

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous