23225340130

Committed 18 Mar 2026 01:53AM UTC coverage: 89.677% (-0.001%) from 89.678%

Build # 23225340130

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #5456 from randombit/jack/clang-tidy-22

Fix various warnings from clang-tidy 22

Run Details

104438 of 116460 relevant lines covered (89.68%)

11819947.55 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

98.18

/src/cli/perf_pk_ka.cpp

/*
* (C) 2024 Jack Lloyd
*
* Botan is released under the Simplified BSD License (see license.txt)
*/

#include "perf.h"

#if defined(BOTAN_HAS_PUBLIC_KEY_CRYPTO)
   #include <botan/pk_algs.h>
   #include <botan/pubkey.h>
   #include <botan/internal/fmt.h>
#endif

namespace Botan_CLI {

namespace {

#if defined(BOTAN_HAS_PUBLIC_KEY_CRYPTO)

class PerfTest_PKKa : public PerfTest {
   public:
      virtual std::string algo() const = 0;

      virtual std::vector<std::string> keygen_params(const PerfConfig& /*config*/) const { return {""}; }

      void go(const PerfConfig& config) override {
         const std::string alg = this->algo();

         const auto params = this->keygen_params(config);

         for(const auto& param : params) {
            const std::string nm = this->format_name(alg, param);
            bench_pk_ka(config, nm, alg, param);
         }
      }

      static void bench_pk_ka(const PerfConfig& config,
                              const std::string& nm,
                              const std::string& algo,
                              const std::string& params,
                              const std::string& provider = "") {
         const auto msec = config.runtime();

         const std::string kdf = "KDF2(SHA-256)";  // arbitrary choice

         auto keygen_timer = config.make_timer(nm, 1, "keygen");

         auto& rng = config.rng();

         auto key1 = keygen_timer->run([&] { return Botan::create_private_key(algo, rng, params); });
         auto key2 = keygen_timer->run([&] { return Botan::create_private_key(algo, rng, params); });

         if(key1 && key2) {
            while(keygen_timer->under(msec)) {
               key2 = keygen_timer->run([&] { return Botan::create_private_key(algo, rng, params); });
            }

            config.record_result(*keygen_timer);

            const Botan::PK_Key_Agreement_Key& ka_key1 = dynamic_cast<const Botan::PK_Key_Agreement_Key&>(*key1);
            const Botan::PK_Key_Agreement_Key& ka_key2 = dynamic_cast<const Botan::PK_Key_Agreement_Key&>(*key2);

            Botan::PK_Key_Agreement ka1(ka_key1, rng, kdf, provider);
            Botan::PK_Key_Agreement ka2(ka_key2, rng, kdf, provider);

            const std::vector<uint8_t> ka1_pub = ka_key1.public_value();
            const std::vector<uint8_t> ka2_pub = ka_key2.public_value();

            auto ka_timer = config.make_timer(nm, 1, "key agreements");

            while(ka_timer->under(msec)) {
               auto k1 = ka_timer->run([&]() { return ka1.derive_key(32, ka2_pub); });
               auto k2 = ka_timer->run([&]() { return ka2.derive_key(32, ka1_pub); });

               if(k1 != k2) {
                  config.error_output() << "Key agreement mismatch in PK bench\n";
               }
            }

            config.record_result(*ka_timer);
         }
      }
};

#endif

#if defined(BOTAN_HAS_DIFFIE_HELLMAN)

class PerfTest_DH final : public PerfTest_PKKa {
   public:
      std::string algo() const override { return "DH"; }

      std::vector<std::string> keygen_params(const PerfConfig& /*config*/) const override {
         return {
            "ffdhe/ietf/2048",
            "ffdhe/ietf/3072",
            "ffdhe/ietf/4096",
            "ffdhe/ietf/6144",
            "ffdhe/ietf/8192",
         };
      }

      std::string format_name(const std::string& alg, const std::string& param) const override {
         return Botan::fmt("{}-{}", alg, param.substr(param.find_last_of('/') + 1));
      }
};

BOTAN_REGISTER_PERF_TEST("DH", PerfTest_DH);

#endif

#if defined(BOTAN_HAS_ECDH)

class PerfTest_ECDH final : public PerfTest_PKKa {
   public:
      std::string algo() const override { return "ECDH"; }

      std::vector<std::string> keygen_params(const PerfConfig& config) const override { return config.ecc_groups(); }
};

BOTAN_REGISTER_PERF_TEST("ECDH", PerfTest_ECDH);

#endif

#if defined(BOTAN_HAS_X25519)

class PerfTest_X25519 final : public PerfTest_PKKa {
   public:
      std::string algo() const override { return "X25519"; }
};

BOTAN_REGISTER_PERF_TEST("X25519", PerfTest_X25519);

#endif

#if defined(BOTAN_HAS_X448)

class PerfTest_X448 final : public PerfTest_PKKa {
   public:
      std::string algo() const override { return "X448"; }
};

BOTAN_REGISTER_PERF_TEST("X448", PerfTest_X448);

#endif

}  // namespace

}  // namespace Botan_CLI

1	/*
2	* (C) 2024 Jack Lloyd
3	*
4	* Botan is released under the Simplified BSD License (see license.txt)
5	*/
6
7	#include "perf.h"
8
9	#if defined(BOTAN_HAS_PUBLIC_KEY_CRYPTO)
10	#include <botan/pk_algs.h>
11	#include <botan/pubkey.h>
12	#include <botan/internal/fmt.h>
13	#endif
14
15	namespace Botan_CLI {
16
17	namespace {
18
19	#if defined(BOTAN_HAS_PUBLIC_KEY_CRYPTO)
20
21	class PerfTest_PKKa : public PerfTest {	4✔
22	public:
23	virtual std::string algo() const = 0;
24
25	virtual std::vector<std::string> keygen_params(const PerfConfig& /config/) const { return {""}; }	2✔
26
27	void go(const PerfConfig& config) override {	4✔
28	const std::string alg = this->algo();	4✔
29
30	const auto params = this->keygen_params(config);	4✔
31
32	for(const auto& param : params) {	17✔
33	const std::string nm = this->format_name(alg, param);	13✔
34	bench_pk_ka(config, nm, alg, param);	26✔
35	}	13✔
36	}	4✔
37
38	static void bench_pk_ka(const PerfConfig& config,	13✔
39	const std::string& nm,
40	const std::string& algo,
41	const std::string& params,
42	const std::string& provider = "") {
43	const auto msec = config.runtime();	13✔
44
45	const std::string kdf = "KDF2(SHA-256)"; // arbitrary choice	13✔
46
47	auto keygen_timer = config.make_timer(nm, 1, "keygen");	26✔
48
49	auto& rng = config.rng();	13✔
50
51	auto key1 = keygen_timer->run([&] { return Botan::create_private_key(algo, rng, params); });	26✔
52	auto key2 = keygen_timer->run([&] { return Botan::create_private_key(algo, rng, params); });	26✔
53
54	if(key1 && key2) {	13✔
55	while(keygen_timer->under(msec)) {	34✔
56	key2 = keygen_timer->run([&] { return Botan::create_private_key(algo, rng, params); });	63✔
57	}
58
59	config.record_result(*keygen_timer);	13✔
60
61	const Botan::PK_Key_Agreement_Key& ka_key1 = dynamic_cast<const Botan::PK_Key_Agreement_Key&>(*key1);	13✔
62	const Botan::PK_Key_Agreement_Key& ka_key2 = dynamic_cast<const Botan::PK_Key_Agreement_Key&>(*key2);	13✔
63
64	Botan::PK_Key_Agreement ka1(ka_key1, rng, kdf, provider);	13✔
65	Botan::PK_Key_Agreement ka2(ka_key2, rng, kdf, provider);	13✔
66
67	const std::vector<uint8_t> ka1_pub = ka_key1.public_value();	13✔
68	const std::vector<uint8_t> ka2_pub = ka_key2.public_value();	13✔
69
70	auto ka_timer = config.make_timer(nm, 1, "key agreements");	26✔
71
72	while(ka_timer->under(msec)) {	34✔
73	auto k1 = ka_timer->run([&]() { return ka1.derive_key(32, ka2_pub); });	42✔
74	auto k2 = ka_timer->run([&]() { return ka2.derive_key(32, ka1_pub); });	42✔
75
76	if(k1 != k2) {	21✔
77	config.error_output() << "Key agreement mismatch in PK bench\n";	×
78	}
79	}	42✔
80
81	config.record_result(*ka_timer);	26✔
82	}	39✔
83	}	26✔
84	};
85
86	#endif
87
88	#if defined(BOTAN_HAS_DIFFIE_HELLMAN)
89
90	class PerfTest_DH final : public PerfTest_PKKa {	1✔
91	public:
92	std::string algo() const override { return "DH"; }	1✔
93
94	std::vector<std::string> keygen_params(const PerfConfig& /config/) const override {	1✔
95	return {	1✔
96	"ffdhe/ietf/2048",
97	"ffdhe/ietf/3072",
98	"ffdhe/ietf/4096",
99	"ffdhe/ietf/6144",
100	"ffdhe/ietf/8192",
101	};	1✔
102	}
103
104	std::string format_name(const std::string& alg, const std::string& param) const override {	5✔
105	return Botan::fmt("{}-{}", alg, param.substr(param.find_last_of('/') + 1));	10✔
106	}
107	};
108
109	BOTAN_REGISTER_PERF_TEST("DH", PerfTest_DH);	1✔
110
111	#endif
112
113	#if defined(BOTAN_HAS_ECDH)
114
115	class PerfTest_ECDH final : public PerfTest_PKKa {	1✔
116	public:
117	std::string algo() const override { return "ECDH"; }	1✔
118
119	std::vector<std::string> keygen_params(const PerfConfig& config) const override { return config.ecc_groups(); }	1✔
120	};
121
122	BOTAN_REGISTER_PERF_TEST("ECDH", PerfTest_ECDH);	1✔
123
124	#endif
125
126	#if defined(BOTAN_HAS_X25519)
127
128	class PerfTest_X25519 final : public PerfTest_PKKa {	1✔
129	public:
130	std::string algo() const override { return "X25519"; }	1✔
131	};
132
133	BOTAN_REGISTER_PERF_TEST("X25519", PerfTest_X25519);	1✔
134
135	#endif
136
137	#if defined(BOTAN_HAS_X448)
138
139	class PerfTest_X448 final : public PerfTest_PKKa {	1✔
140	public:
141	std::string algo() const override { return "X448"; }	1✔
142	};
143
144	BOTAN_REGISTER_PERF_TEST("X448", PerfTest_X448);	1✔
145
146	#endif
147
148	} // namespace
149
150	} // namespace Botan_CLI

randombit / botan / 23225340130

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous