#525521795

Committed 17 Mar 2026 06:05PM UTC coverage: 75.963% (+0.05%) from 75.914%

Build # #525521795

Build Type

push

github

Committed by

hurricup

Commit Message

IJPL-237202 Refactored PerlNamesCache to improve reliability

- updating method is now asynchronous with a callback. Tests using semaphore
- NBRA now has a `coalesceBy` project, no manual control over duplications. We did have cases, when several actions run from different sources: queue and forceUpdate
- service stopping in tests is now implemented using test disposable, instead of manual code and atomic getter

Run Details

14772 of 22636 branches covered (65.26%)

Branch coverage included in aggregate %.

18 of 23 new or added lines in 4 files covered. (78.26%)

7 existing lines in 4 files now uncovered.

31089 of 37737 relevant lines covered (82.38%)

0.82 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.74

/plugin/common/src/main/java/com/perl5/lang/pod/parser/PodParserUtil.java

/*
 * Copyright 2015-2025 Alexandr Evstigneev
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package com.perl5.lang.pod.parser;

import com.intellij.lang.PsiBuilder;
import com.intellij.lang.parser.GeneratedParserUtilBase;
import com.intellij.openapi.util.NlsContexts.ParsingError;
import com.intellij.psi.tree.IElementType;
import com.perl5.lang.pod.lexer.PodTokenSetsEx;
import org.jetbrains.annotations.NotNull;

import static com.perl5.lang.pod.parser.PodElementTypesGenerated.*;


public class PodParserUtil extends GeneratedParserUtilBase {
  @SuppressWarnings({"StaticMethodOnlyUsedInOneClass", "SameReturnValue"})
  public static boolean completeOrReport(@NotNull PsiBuilder b,
                                         int ignoredL,
                                         @NotNull IElementType targetElement,
                                         @NotNull @ParsingError String message) {
    if (b.getTokenType() == targetElement) {
      b.advanceLexer();
      return true;
    }
    PsiBuilder.Marker marker = b.mark();
    while (!b.eof() && b.getTokenType() != targetElement && b.getTokenType() != POD_NEWLINE) {
      b.advanceLexer();
    }
    marker.error(message);
    b.advanceLexer();
    return true;
  }

  @SuppressWarnings({"UnusedReturnValue", "StaticMethodOnlyUsedInOneClass"})
  public static boolean checkAndConvert(@NotNull PsiBuilder b,
                                        int ignoredL,
                                        @NotNull IElementType sourceType,
                                        @NotNull IElementType ignoredTargetType) {
    if (b.getTokenType() == sourceType) {
      PsiBuilder.Marker m = b.mark();
      b.advanceLexer();
      m.collapse(POD_INDENT_LEVEL);
      return true;
    }
    return false;
  }


  @SuppressWarnings("StaticMethodOnlyUsedInOneClass")
  public static boolean collapseNonSpaceTo(@NotNull PsiBuilder b, int ignoredL, @NotNull IElementType targetElement) {
    IElementType tokenType = b.getTokenType();

    if (tokenType == POD_IDENTIFIER) {
      PsiBuilder.Marker m = b.mark();
      while (!b.eof() && !PodTokenSetsEx.ALL_WHITE_SPACES.contains(b.rawLookup(1))) {
        b.advanceLexer();
      }
      b.advanceLexer();
      m.collapse(targetElement);
      return true;
    }
    return false;
  }

  @SuppressWarnings({"StaticMethodOnlyUsedInOneClass", "SameReturnValue"})
  public static boolean parsePodSectionContent(@NotNull PsiBuilder b,
                                               int ignoredL,
                                               @NotNull IElementType stopToken,
                                               @NotNull IElementType targetToken,
                                               @ParsingError String errorMessage) {
    PsiBuilder.Marker m = b.mark();
    while (!b.eof() && b.getTokenType() != stopToken) {
      b.advanceLexer();
    }

    m.done(targetToken);

    if (b.eof()) {
      b.mark().error(errorMessage);
    }

    return true;
  }
}

1	/*
2	* Copyright 2015-2025 Alexandr Evstigneev
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* http://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16
17	package com.perl5.lang.pod.parser;
18
19	import com.intellij.lang.PsiBuilder;
20	import com.intellij.lang.parser.GeneratedParserUtilBase;
21	import com.intellij.openapi.util.NlsContexts.ParsingError;
22	import com.intellij.psi.tree.IElementType;
23	import com.perl5.lang.pod.lexer.PodTokenSetsEx;
24	import org.jetbrains.annotations.NotNull;
25
26	import static com.perl5.lang.pod.parser.PodElementTypesGenerated.*;
27
28
29	public class PodParserUtil extends GeneratedParserUtilBase {	×
30	@SuppressWarnings({"StaticMethodOnlyUsedInOneClass", "SameReturnValue"})
31	public static boolean completeOrReport(@NotNull PsiBuilder b,
32	int ignoredL,
33	@NotNull IElementType targetElement,
34	@NotNull @ParsingError String message) {
35	if (b.getTokenType() == targetElement) {	1✔
36	b.advanceLexer();	1✔
37	return true;	1✔
38	}
39	PsiBuilder.Marker marker = b.mark();	1✔
40	while (!b.eof() && b.getTokenType() != targetElement && b.getTokenType() != POD_NEWLINE) {	1!
UNCOV 41	b.advanceLexer();	×
42	}
43	marker.error(message);	1✔
44	b.advanceLexer();	1✔
45	return true;	1✔
46	}
47
48	@SuppressWarnings({"UnusedReturnValue", "StaticMethodOnlyUsedInOneClass"})
49	public static boolean checkAndConvert(@NotNull PsiBuilder b,
50	int ignoredL,
51	@NotNull IElementType sourceType,
52	@NotNull IElementType ignoredTargetType) {
53	if (b.getTokenType() == sourceType) {	1✔
54	PsiBuilder.Marker m = b.mark();	1✔
55	b.advanceLexer();	1✔
56	m.collapse(POD_INDENT_LEVEL);	1✔
57	return true;	1✔
58	}
59	return false;	1✔
60	}
61
62
63	@SuppressWarnings("StaticMethodOnlyUsedInOneClass")
64	public static boolean collapseNonSpaceTo(@NotNull PsiBuilder b, int ignoredL, @NotNull IElementType targetElement) {
65	IElementType tokenType = b.getTokenType();	1✔
66
67	if (tokenType == POD_IDENTIFIER) {	1✔
68	PsiBuilder.Marker m = b.mark();	1✔
69	while (!b.eof() && !PodTokenSetsEx.ALL_WHITE_SPACES.contains(b.rawLookup(1))) {	1✔
70	b.advanceLexer();	1✔
71	}
72	b.advanceLexer();	1✔
73	m.collapse(targetElement);	1✔
74	return true;	1✔
75	}
76	return false;	1✔
77	}
78
79	@SuppressWarnings({"StaticMethodOnlyUsedInOneClass", "SameReturnValue"})
80	public static boolean parsePodSectionContent(@NotNull PsiBuilder b,
81	int ignoredL,
82	@NotNull IElementType stopToken,
83	@NotNull IElementType targetToken,
84	@ParsingError String errorMessage) {
85	PsiBuilder.Marker m = b.mark();	1✔
86	while (!b.eof() && b.getTokenType() != stopToken) {	1✔
87	b.advanceLexer();	1✔
88	}
89
90	m.done(targetToken);	1✔
91
92	if (b.eof()) {	1✔
93	b.mark().error(errorMessage);	1✔
94	}
95
96	return true;	1✔
97	}
98	}

Camelcade / Perl5-IDEA / #525521795

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous