Stellarium / stellarium / 23203922253

Pull #4819

github

Make object searches return StelObjectP

The Search dialog is currently implemented in a very suboptimal way,
especially since #4635, when it started triggering searches by name in
its CompletionListModel::data method. The search is supposed to get
object type for each item found, which is only a name of the object.

What the dialog would really want is to have object pointers in the
search results, not simply names. This requires a huge refactoring of
the search API in StelObjectModule, so that the object listing methods
return the object pointers. This is exactly what this change does. In
addition to the pointers the API still returns the names, because it
looks like the right names for search results are not always trivial
to find out from the object itself.

Fixes #4655.

0 of 500 new or added lines in 21 files covered. (0.0%)

14713 of 130618 relevant lines covered (11.26%)

15121.59 hits per line