• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4988

16 Mar 2026 12:26PM UTC coverage: 75.821% (+1.9%) from 73.883%
#4988

push

travis-ci

web-flow
feat: support secure delete option. (#34591)

274 of 464 new or added lines in 29 files covered. (59.05%)

4404 existing lines in 23 files now uncovered.

337108 of 444611 relevant lines covered (75.82%)

146708292.94 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

78.35
/source/dnode/mnode/impl/src/mndStb.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "audit.h"
18
#include "mndDb.h"
19
#include "mndDnode.h"
20
#include "mndIndex.h"
21
#include "mndIndexComm.h"
22
#include "mndInfoSchema.h"
23
#include "mndMnode.h"
24
#include "mndPerfSchema.h"
25
#include "mndPrivilege.h"
26
#include "mndRsma.h"
27
#include "mndShow.h"
28
#include "mndSma.h"
29
#include "mndStb.h"
30
#include "mndTopic.h"
31
#include "mndTrans.h"
32
#include "mndUser.h"
33
#include "mndVgroup.h"
34
#include "mndStream.h"
35
#include "tname.h"
36

37
#define STB_VER_SUPPORT_COMP    2
38
#define STB_VER_SUPPORT_VIRTUAL 3
39
#define STB_VER_SUPPORT_OWNER   4
40
#define STB_VER_NUMBER          STB_VER_SUPPORT_OWNER
41
#define STB_RESERVE_SIZE        55
42

43
static int32_t  mndStbActionInsert(SSdb *pSdb, SStbObj *pStb);
44
static int32_t  mndStbActionDelete(SSdb *pSdb, SStbObj *pStb);
45
static int32_t  mndStbActionUpdate(SSdb *pSdb, SStbObj *pOld, SStbObj *pNew);
46
static int32_t  mndProcessTtlTimer(SRpcMsg *pReq);
47
// static int32_t  mndProcessTrimDbTimer(SRpcMsg *pReq);
48
static int32_t  mndProcessCreateStbReq(SRpcMsg *pReq);
49
static int32_t  mndProcessAlterStbReq(SRpcMsg *pReq);
50
static int32_t  mndProcessDropStbReq(SRpcMsg *pReq);
51
static int32_t  mndProcessDropTtltbRsp(SRpcMsg *pReq);
52
static int32_t  mndProcessTrimDbRsp(SRpcMsg *pReq);
53
static int32_t  mndProcessTrimDbWalRsp(SRpcMsg *pReq);
54
static int32_t  mndProcessTableMetaReq(SRpcMsg *pReq);
55
static int32_t  mndRetrieveStb(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
56
static int32_t  mndRetrieveStbCol(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
57
static void     mndCancelGetNextStb(SMnode *pMnode, void *pIter);
58
static int32_t  mndProcessTableCfgReq(SRpcMsg *pReq);
59
static int32_t  mndAlterStbImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
60
                               void *alterOriData, int32_t alterOriDataLen);
61
static int32_t  mndAlterStbAndUpdateTagIdxImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
62
                                              void *alterOriData, int32_t alterOriDataLen, const SMAlterStbReq *pAlter);
63

64
static int32_t mndProcessCreateIndexReq(SRpcMsg *pReq);
65
static int32_t mndProcessDropIndexReq(SRpcMsg *pReq);
66

67
static int32_t mndProcessDropStbReqFromMNode(SRpcMsg *pReq);
68
static int32_t mndProcessDropTbWithTsma(SRpcMsg *pReq);
69
static int32_t mndProcessFetchTtlExpiredTbs(SRpcMsg *pReq);
70
static int32_t mndProcessAuditRecordRsp(SRpcMsg *pRsp);
71

72
int32_t mndInitStb(SMnode *pMnode) {
916,128✔
73
  SSdbTable table = {
916,128✔
74
      .sdbType = SDB_STB,
75
      .keyType = SDB_KEY_BINARY,
76
      .encodeFp = (SdbEncodeFp)mndStbActionEncode,
77
      .decodeFp = (SdbDecodeFp)mndStbActionDecode,
78
      .insertFp = (SdbInsertFp)mndStbActionInsert,
79
      .updateFp = (SdbUpdateFp)mndStbActionUpdate,
80
      .deleteFp = (SdbDeleteFp)mndStbActionDelete,
81
  };
82

83
  mndSetMsgHandle(pMnode, TDMT_MND_CREATE_STB, mndProcessCreateStbReq);
916,128✔
84
  mndSetMsgHandle(pMnode, TDMT_MND_ALTER_STB, mndProcessAlterStbReq);
916,128✔
85
  mndSetMsgHandle(pMnode, TDMT_MND_DROP_STB, mndProcessDropStbReq);
916,128✔
86
  mndSetMsgHandle(pMnode, TDMT_VND_CREATE_STB_RSP, mndTransProcessRsp);
916,128✔
87
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_TTL_TABLE_RSP, mndProcessDropTtltbRsp);
916,128✔
88
  mndSetMsgHandle(pMnode, TDMT_VND_TRIM_RSP, mndTransProcessRsp);
916,128✔
89
  mndSetMsgHandle(pMnode, TDMT_VND_TRIM_WAL_RSP, mndProcessTrimDbWalRsp);
916,128✔
90
  mndSetMsgHandle(pMnode, TDMT_VND_ALTER_STB_RSP, mndTransProcessRsp);
916,128✔
91
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_STB_RSP, mndTransProcessRsp);
916,128✔
92
  mndSetMsgHandle(pMnode, TDMT_MND_TABLE_META, mndProcessTableMetaReq);
916,128✔
93
  mndSetMsgHandle(pMnode, TDMT_MND_TTL_TIMER, mndProcessTtlTimer);
916,128✔
94
  // mndSetMsgHandle(pMnode, TDMT_MND_TRIM_DB_TIMER, mndProcessTrimDbTimer);
95
  mndSetMsgHandle(pMnode, TDMT_MND_TABLE_CFG, mndProcessTableCfgReq);
916,128✔
96
  mndSetMsgHandle(pMnode, TDMT_MND_STB_DROP, mndProcessDropStbReqFromMNode);
916,128✔
97
  mndSetMsgHandle(pMnode, TDMT_MND_STB_DROP_RSP, mndTransProcessRsp);
916,128✔
98
  mndSetMsgHandle(pMnode, TDMT_MND_DROP_TB_WITH_TSMA, mndProcessDropTbWithTsma);
916,128✔
99
  mndSetMsgHandle(pMnode, TDMT_VND_FETCH_TTL_EXPIRED_TBS_RSP, mndProcessFetchTtlExpiredTbs);
916,128✔
100
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_TABLE_RSP, mndTransProcessRsp);
916,128✔
101
  //  mndSetMsgHandle(pMnode, TDMT_MND_SYSTABLE_RETRIEVE, mndProcessRetrieveStbReq);
102

103
  // mndSetMsgHandle(pMnode, TDMT_MND_CREATE_INDEX, mndProcessCreateIndexReq);
104
  // mndSetMsgHandle(pMnode, TDMT_MND_DROP_INDEX, mndProcessDropIndexReq);
105
  // mndSetMsgHandle(pMnode, TDMT_VND_CREATE_INDEX_RSP, mndTransProcessRsp);
106
  // mndSetMsgHandle(pMnode, TDMT_VND_DROP_INDEX_RSP, mndTransProcessRsp);
107
  mndSetMsgHandle(pMnode, TDMT_VND_AUDIT_RECORD_RSP, mndProcessAuditRecordRsp);
916,128✔
108

109
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_STB, mndRetrieveStb);
916,128✔
110
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_STB, mndCancelGetNextStb);
916,128✔
111

112
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_COL, mndRetrieveStbCol);
916,128✔
113
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_COL, mndCancelGetNextStb);
916,128✔
114

115
  return sdbSetTable(pMnode->pSdb, table);
916,128✔
116
}
117

118
void mndCleanupStb(SMnode *pMnode) {}
915,990✔
119

120
SSdbRaw *mndStbActionEncode(SStbObj *pStb) {
31,646,734✔
121
  int32_t code = 0;
31,646,734✔
122
  int32_t lino = 0;
31,646,734✔
123
  bool    hasTypeMod = false;
31,646,734✔
124
  terrno = TSDB_CODE_OUT_OF_MEMORY;
31,646,734✔
125

126
  int32_t size = sizeof(SStbObj) + (pStb->numOfColumns + pStb->numOfTags) * sizeof(SSchema) + pStb->commentLen +
31,663,330✔
127
                 pStb->ast1Len + pStb->ast2Len + pStb->numOfColumns * sizeof(SColCmpr) + STB_RESERVE_SIZE +
31,663,330✔
128
                 taosArrayGetSize(pStb->pFuncs) * TSDB_FUNC_NAME_LEN + sizeof(int32_t) * pStb->numOfColumns;
31,646,734✔
129
  SSdbRaw *pRaw = sdbAllocRaw(SDB_STB, STB_VER_NUMBER, size);
31,646,734✔
130
  if (pRaw == NULL) goto _OVER;
31,646,734✔
131

132
  int32_t dataPos = 0;
31,646,734✔
133
  SDB_SET_BINARY(pRaw, dataPos, pStb->name, TSDB_TABLE_FNAME_LEN, _OVER)
31,646,734✔
134
  SDB_SET_BINARY(pRaw, dataPos, pStb->db, TSDB_DB_FNAME_LEN, _OVER)
31,646,734✔
135
  SDB_SET_INT64(pRaw, dataPos, pStb->createdTime, _OVER)
31,646,734✔
136
  SDB_SET_INT64(pRaw, dataPos, pStb->updateTime, _OVER)
31,646,734✔
137
  SDB_SET_INT64(pRaw, dataPos, pStb->uid, _OVER)
31,646,734✔
138
  SDB_SET_INT64(pRaw, dataPos, pStb->dbUid, _OVER)
31,646,734✔
139
  SDB_SET_INT32(pRaw, dataPos, pStb->tagVer, _OVER)
31,646,734✔
140
  SDB_SET_INT32(pRaw, dataPos, pStb->colVer, _OVER)
31,646,734✔
141
  SDB_SET_INT32(pRaw, dataPos, pStb->smaVer, _OVER)
31,646,734✔
142
  SDB_SET_INT32(pRaw, dataPos, pStb->nextColId, _OVER)
31,646,734✔
143
  SDB_SET_INT64(pRaw, dataPos, pStb->maxdelay[0], _OVER)
31,646,734✔
144
  SDB_SET_INT64(pRaw, dataPos, pStb->maxdelay[1], _OVER)
31,646,734✔
145
  SDB_SET_INT64(pRaw, dataPos, pStb->watermark[0], _OVER)
31,646,734✔
146
  SDB_SET_INT64(pRaw, dataPos, pStb->watermark[1], _OVER)
31,646,734✔
147
  SDB_SET_INT32(pRaw, dataPos, pStb->ttl, _OVER)
31,646,734✔
148
  SDB_SET_INT32(pRaw, dataPos, pStb->numOfColumns, _OVER)
31,646,734✔
149
  SDB_SET_INT32(pRaw, dataPos, pStb->numOfTags, _OVER)
31,646,734✔
150
  SDB_SET_INT32(pRaw, dataPos, pStb->numOfFuncs, _OVER)
31,646,734✔
151
  SDB_SET_INT32(pRaw, dataPos, pStb->commentLen, _OVER)
31,646,734✔
152
  SDB_SET_INT32(pRaw, dataPos, pStb->ast1Len, _OVER)
31,646,734✔
153
  SDB_SET_INT32(pRaw, dataPos, pStb->ast2Len, _OVER)
31,646,734✔
154

155
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
1,933,508,432✔
156
    SSchema *pSchema = &pStb->pColumns[i];
1,901,861,698✔
157
    SDB_SET_INT8(pRaw, dataPos, pSchema->type, _OVER)
1,901,861,698✔
158
    SDB_SET_INT8(pRaw, dataPos, pSchema->flags, _OVER)
1,901,861,698✔
159
    SDB_SET_INT16(pRaw, dataPos, pSchema->colId, _OVER)
1,901,861,698✔
160
    SDB_SET_INT32(pRaw, dataPos, pSchema->bytes, _OVER)
1,901,861,698✔
161
    SDB_SET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
1,901,861,698✔
162
    hasTypeMod = hasTypeMod || HAS_TYPE_MOD(pSchema);
1,901,861,698✔
163
  }
164

165
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
206,266,958✔
166
    SSchema *pSchema = &pStb->pTags[i];
174,620,224✔
167
    SDB_SET_INT8(pRaw, dataPos, pSchema->type, _OVER)
174,620,224✔
168
    SDB_SET_INT8(pRaw, dataPos, pSchema->flags, _OVER)
174,620,224✔
169
    SDB_SET_INT16(pRaw, dataPos, pSchema->colId, _OVER)
174,620,224✔
170
    SDB_SET_INT32(pRaw, dataPos, pSchema->bytes, _OVER)
174,620,224✔
171
    SDB_SET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
174,620,224✔
172
  }
173

174
  for (int32_t i = 0; i < pStb->numOfFuncs; ++i) {
31,646,734✔
175
    char *func = taosArrayGet(pStb->pFuncs, i);
×
176
    SDB_SET_BINARY(pRaw, dataPos, func, TSDB_FUNC_NAME_LEN, _OVER)
×
177
  }
178

179
  if (pStb->commentLen > 0) {
31,646,734✔
180
    SDB_SET_BINARY(pRaw, dataPos, pStb->comment, pStb->commentLen + 1, _OVER)
129,886✔
181
  }
182

183
  if (pStb->ast1Len > 0) {
31,646,734✔
184
    SDB_SET_BINARY(pRaw, dataPos, pStb->pAst1, pStb->ast1Len, _OVER)
×
185
  }
186

187
  if (pStb->ast2Len > 0) {
31,646,734✔
188
    SDB_SET_BINARY(pRaw, dataPos, pStb->pAst2, pStb->ast2Len, _OVER)
×
189
  }
190

191
  if (pStb->pCmpr != NULL) {
31,646,734✔
192
    for (int i = 0; i < pStb->numOfColumns; i++) {
1,933,508,432✔
193
      SColCmpr *p = &pStb->pCmpr[i];
1,901,861,698✔
194
      SDB_SET_INT16(pRaw, dataPos, p->id, _OVER)
1,901,861,698✔
195
      SDB_SET_INT32(pRaw, dataPos, p->alg, _OVER)
1,901,861,698✔
196
    }
197
  }
198
  SDB_SET_INT64(pRaw, dataPos, pStb->keep, _OVER)
31,646,734✔
199

200
  if (hasTypeMod) {
31,646,734✔
201
    for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
1,209,200,000✔
202
      SDB_SET_INT32(pRaw, dataPos, pStb->pExtSchemas[i].typeMod, _OVER);
1,198,812,944✔
203
    }
204
  }
205

206
  SDB_SET_INT8(pRaw, dataPos, pStb->virtualStb, _OVER)
31,646,734✔
207
  // since 3.4.0.0 - STB_VER_SUPPORT_OWNER
208
  SDB_SET_BINARY(pRaw, dataPos, pStb->createUser, TSDB_USER_LEN, _OVER)
31,646,734✔
209
  SDB_SET_INT64(pRaw, dataPos, pStb->ownerId, _OVER)
31,646,734✔
210
  SDB_SET_INT8(pRaw, dataPos, pStb->secureDelete, _OVER)
31,646,734✔
211
  SDB_SET_RESERVE(pRaw, dataPos, STB_RESERVE_SIZE, _OVER)
31,646,734✔
212
  SDB_SET_DATALEN(pRaw, dataPos, _OVER)
31,646,734✔
213

214
  terrno = 0;
31,646,734✔
215

216
_OVER:
31,646,734✔
217
  if (terrno != 0) {
31,646,734✔
UNCOV
218
    mError("stb:%s, failed to encode to raw:%p since %s", pStb->name, pRaw, terrstr());
×
219
    sdbFreeRaw(pRaw);
×
220
    return NULL;
×
221
  }
222

223
  mTrace("stb:%s, encode to raw:%p, row:%p", pStb->name, pRaw, pStb);
31,646,734✔
224
  return pRaw;
31,646,734✔
225
}
226

227
SSdbRow *mndStbActionDecode(SSdbRaw *pRaw) {
29,761,258✔
228
  int32_t code = 0;
29,761,258✔
229
  int32_t lino = 0;
29,761,258✔
230
  terrno = TSDB_CODE_OUT_OF_MEMORY;
29,761,258✔
231
  SSdbRow *pRow = NULL;
29,761,258✔
232
  SStbObj *pStb = NULL;
29,761,258✔
233
  bool     hasExtSchemas = false;
29,761,258✔
234

235
  int8_t sver = 0;
29,761,258✔
236
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) goto _OVER;
29,761,258✔
237

238
  if (sver > STB_VER_NUMBER) {
29,761,258✔
UNCOV
239
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
240
    goto _OVER;
×
241
  }
242

243
  pRow = sdbAllocRow(sizeof(SStbObj));
29,761,258✔
244
  if (pRow == NULL) goto _OVER;
29,761,258✔
245

246
  pStb = sdbGetRowObj(pRow);
29,761,258✔
247
  if (pStb == NULL) goto _OVER;
29,761,258✔
248

249
  int32_t dataPos = 0;
29,761,258✔
250
  SDB_GET_BINARY(pRaw, dataPos, pStb->name, TSDB_TABLE_FNAME_LEN, _OVER)
29,761,258✔
251
  SDB_GET_BINARY(pRaw, dataPos, pStb->db, TSDB_DB_FNAME_LEN, _OVER)
29,761,258✔
252
  SDB_GET_INT64(pRaw, dataPos, &pStb->createdTime, _OVER)
29,761,258✔
253
  SDB_GET_INT64(pRaw, dataPos, &pStb->updateTime, _OVER)
29,761,258✔
254
  SDB_GET_INT64(pRaw, dataPos, &pStb->uid, _OVER)
29,761,258✔
255
  SDB_GET_INT64(pRaw, dataPos, &pStb->dbUid, _OVER)
29,761,258✔
256
  SDB_GET_INT32(pRaw, dataPos, &pStb->tagVer, _OVER)
29,761,258✔
257
  SDB_GET_INT32(pRaw, dataPos, &pStb->colVer, _OVER)
29,761,258✔
258
  SDB_GET_INT32(pRaw, dataPos, &pStb->smaVer, _OVER)
29,761,258✔
259
  SDB_GET_INT32(pRaw, dataPos, &pStb->nextColId, _OVER)
29,761,258✔
260
  SDB_GET_INT64(pRaw, dataPos, &pStb->maxdelay[0], _OVER)
29,761,258✔
261
  SDB_GET_INT64(pRaw, dataPos, &pStb->maxdelay[1], _OVER)
29,761,258✔
262
  SDB_GET_INT64(pRaw, dataPos, &pStb->watermark[0], _OVER)
29,761,258✔
263
  SDB_GET_INT64(pRaw, dataPos, &pStb->watermark[1], _OVER)
29,761,258✔
264
  SDB_GET_INT32(pRaw, dataPos, &pStb->ttl, _OVER)
29,761,258✔
265
  SDB_GET_INT32(pRaw, dataPos, &pStb->numOfColumns, _OVER)
29,761,258✔
266
  SDB_GET_INT32(pRaw, dataPos, &pStb->numOfTags, _OVER)
29,761,258✔
267
  SDB_GET_INT32(pRaw, dataPos, &pStb->numOfFuncs, _OVER)
29,761,258✔
268
  SDB_GET_INT32(pRaw, dataPos, &pStb->commentLen, _OVER)
29,761,258✔
269
  SDB_GET_INT32(pRaw, dataPos, &pStb->ast1Len, _OVER)
29,761,258✔
270
  SDB_GET_INT32(pRaw, dataPos, &pStb->ast2Len, _OVER)
29,761,258✔
271

272
  pStb->pColumns = taosMemoryCalloc(pStb->numOfColumns, sizeof(SSchema));
29,761,258✔
273
  pStb->pTags = taosMemoryCalloc(pStb->numOfTags, sizeof(SSchema));
29,761,258✔
274
  pStb->pFuncs = taosArrayInit(pStb->numOfFuncs, TSDB_FUNC_NAME_LEN);
29,761,258✔
275
  if (pStb->pColumns == NULL || pStb->pTags == NULL || pStb->pFuncs == NULL) {
29,761,258✔
UNCOV
276
    goto _OVER;
×
277
  }
278

279
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
2,147,483,647✔
280
    SSchema *pSchema = &pStb->pColumns[i];
2,147,483,647✔
281
    SDB_GET_INT8(pRaw, dataPos, &pSchema->type, _OVER)
2,147,483,647✔
282
    SDB_GET_INT8(pRaw, dataPos, &pSchema->flags, _OVER)
2,147,483,647✔
283
    SDB_GET_INT16(pRaw, dataPos, &pSchema->colId, _OVER)
2,147,483,647✔
284
    SDB_GET_INT32(pRaw, dataPos, &pSchema->bytes, _OVER)
2,147,483,647✔
285
    SDB_GET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
2,147,483,647✔
286
    hasExtSchemas = hasExtSchemas || HAS_TYPE_MOD(pSchema);
2,147,483,647✔
287
  }
288

289
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
297,427,660✔
290
    SSchema *pSchema = &pStb->pTags[i];
267,666,402✔
291
    SDB_GET_INT8(pRaw, dataPos, &pSchema->type, _OVER)
267,666,402✔
292
    SDB_GET_INT8(pRaw, dataPos, &pSchema->flags, _OVER)
267,666,402✔
293
    SDB_GET_INT16(pRaw, dataPos, &pSchema->colId, _OVER)
267,666,402✔
294
    SDB_GET_INT32(pRaw, dataPos, &pSchema->bytes, _OVER)
267,666,402✔
295
    SDB_GET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
267,666,402✔
296
  }
297

298
  for (int32_t i = 0; i < pStb->numOfFuncs; ++i) {
29,761,258✔
UNCOV
299
    char funcName[TSDB_FUNC_NAME_LEN] = {0};
×
300
    SDB_GET_BINARY(pRaw, dataPos, funcName, TSDB_FUNC_NAME_LEN, _OVER)
×
301
    if (taosArrayPush(pStb->pFuncs, funcName) == NULL) goto _OVER;
×
302
  }
303

304
  if (pStb->commentLen > 0) {
29,761,258✔
305
    pStb->comment = taosMemoryCalloc(pStb->commentLen + 1, 1);
125,260✔
306
    if (pStb->comment == NULL) goto _OVER;
125,260✔
307
    SDB_GET_BINARY(pRaw, dataPos, pStb->comment, pStb->commentLen + 1, _OVER)
125,260✔
308
  }
309

310
  if (pStb->ast1Len > 0) {
29,761,258✔
UNCOV
311
    pStb->pAst1 = taosMemoryCalloc(pStb->ast1Len, 1);
×
312
    if (pStb->pAst1 == NULL) goto _OVER;
×
313
    SDB_GET_BINARY(pRaw, dataPos, pStb->pAst1, pStb->ast1Len, _OVER)
×
314
  }
315

316
  if (pStb->ast2Len > 0) {
29,761,258✔
UNCOV
317
    pStb->pAst2 = taosMemoryCalloc(pStb->ast2Len, 1);
×
318
    if (pStb->pAst2 == NULL) goto _OVER;
×
319
    SDB_GET_BINARY(pRaw, dataPos, pStb->pAst2, pStb->ast2Len, _OVER)
×
320
  }
321

322
  pStb->pCmpr = taosMemoryCalloc(pStb->numOfColumns, sizeof(SColCmpr));
29,761,258✔
323
  if (sver < STB_VER_SUPPORT_COMP) {
29,761,258✔
324
    // compatible with old data, setup default compress value
325
    // impl later
UNCOV
326
    for (int i = 0; i < pStb->numOfColumns; i++) {
×
327
      SSchema  *pSchema = &pStb->pColumns[i];
×
328
      SColCmpr *pCmpr = &pStb->pCmpr[i];
×
329
      pCmpr->id = pSchema->colId;
×
330
      pCmpr->alg = createDefaultColCmprByType(pSchema->type);
×
331
    }
332
  } else {
333
    for (int i = 0; i < pStb->numOfColumns; i++) {
2,147,483,647✔
334
      SColCmpr *pCmpr = &pStb->pCmpr[i];
2,147,483,647✔
335
      SDB_GET_INT16(pRaw, dataPos, &pCmpr->id, _OVER)
2,147,483,647✔
336
      SDB_GET_INT32(pRaw, dataPos, (int32_t *)&pCmpr->alg, _OVER)  // compatiable
2,147,483,647✔
337
    }
338
  }
339
  SDB_GET_INT64(pRaw, dataPos, &pStb->keep, _OVER)
29,761,258✔
340

341
  // type mod
342
  if (hasExtSchemas) {
29,761,258✔
343
    pStb->pExtSchemas = taosMemoryCalloc(pStb->numOfColumns, sizeof(SExtSchema));
13,003,438✔
344
    if (!pStb->pExtSchemas) goto _OVER;
13,003,438✔
345
    for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
2,147,483,647✔
346
      SSchema *pSchema = &pStb->pColumns[i];
2,147,483,647✔
347
      SDB_GET_INT32(pRaw, dataPos, &pStb->pExtSchemas[i].typeMod, _OVER)
2,147,483,647✔
348
    }
349
  }
350

351
  if (sver < STB_VER_SUPPORT_VIRTUAL) {
29,761,258✔
UNCOV
352
    pStb->virtualStb = 0;
×
353
  } else {
354
    SDB_GET_INT8(pRaw, dataPos, &pStb->virtualStb, _OVER)
29,761,258✔
355
  }
356

357
  if (sver < STB_VER_SUPPORT_OWNER) {
29,761,258✔
UNCOV
358
    pStb->createUser[0] = 0;
×
359
  } else {
360
    SDB_GET_BINARY(pRaw, dataPos, pStb->createUser, TSDB_USER_LEN, _OVER)
29,761,258✔
361
    SDB_GET_INT64(pRaw, dataPos, &pStb->ownerId, _OVER)
29,761,258✔
362
  }
363

364
  if (dataPos + sizeof(int8_t) <= pRaw->dataLen) {
29,761,258✔
365
    SDB_GET_INT8(pRaw, dataPos, &pStb->secureDelete, _OVER)
29,761,258✔
366
  } else {
NEW
367
    pStb->secureDelete = 0;
×
368
  }
369

370
  SDB_GET_RESERVE(pRaw, dataPos, STB_RESERVE_SIZE, _OVER)
29,761,258✔
371

372
  terrno = 0;
29,761,258✔
373

374
_OVER:
29,761,258✔
375
  if (terrno != 0) {
29,761,258✔
UNCOV
376
    mError("stb:%s, failed to decode from raw:%p since %s", pStb == NULL ? "null" : pStb->name, pRaw, terrstr());
×
UNCOV
377
    if (pStb != NULL) {
×
UNCOV
378
      taosMemoryFreeClear(pStb->pColumns);
×
UNCOV
379
      taosMemoryFreeClear(pStb->pTags);
×
UNCOV
380
      taosMemoryFreeClear(pStb->comment);
×
UNCOV
381
      taosMemoryFree(pStb->pCmpr);
×
UNCOV
382
      taosMemoryFreeClear(pStb->pExtSchemas);
×
383
    }
384
    taosMemoryFreeClear(pRow);
×
385
    return NULL;
×
386
  }
387

388
  mTrace("stb:%s, decode from raw:%p, row:%p", pStb->name, pRaw, pStb);
29,761,258✔
389
  return pRow;
29,761,258✔
390
}
391

392
void mndFreeStb(SStbObj *pStb) {
33,691,688✔
393
  taosArrayDestroy(pStb->pFuncs);
33,691,688✔
394
  taosMemoryFreeClear(pStb->pColumns);
33,691,688✔
395
  taosMemoryFreeClear(pStb->pTags);
33,691,688✔
396
  taosMemoryFreeClear(pStb->comment);
33,691,688✔
397
  taosMemoryFreeClear(pStb->pAst1);
33,691,688✔
398
  taosMemoryFreeClear(pStb->pAst2);
33,691,688✔
399
  taosMemoryFreeClear(pStb->pCmpr);
33,691,688✔
400
  taosMemoryFreeClear(pStb->pExtSchemas);
33,691,688✔
401
}
33,691,688✔
402

403
static int32_t mndStbActionInsert(SSdb *pSdb, SStbObj *pStb) {
5,005,446✔
404
  mTrace("stb:%s, perform insert action, row:%p", pStb->name, pStb);
5,005,446✔
405
  return 0;
5,005,446✔
406
}
407

408
static int32_t mndStbActionDelete(SSdb *pSdb, SStbObj *pStb) {
33,548,272✔
409
  mTrace("stb:%s, perform delete action, row:%p", pStb->name, pStb);
33,548,272✔
410
  mndFreeStb(pStb);
33,548,272✔
411
  return 0;
33,548,272✔
412
}
413

414
static int32_t mndStbActionUpdate(SSdb *pSdb, SStbObj *pOld, SStbObj *pNew) {
22,612,106✔
415
  terrno = 0;
22,612,106✔
416
  mTrace("stb:%s, perform update action, old row:%p new row:%p", pOld->name, pOld, pNew);
22,612,106✔
417

418
  taosWLockLatch(&pOld->lock);
22,612,106✔
419
  int32_t numOfColumns = pOld->numOfColumns;
22,612,106✔
420
  if (pOld->numOfColumns < pNew->numOfColumns) {
22,612,106✔
421
    void *pColumns = taosMemoryMalloc(pNew->numOfColumns * sizeof(SSchema));
5,322,732✔
422
    if (pColumns == NULL) {
5,322,732✔
UNCOV
423
      goto END;
×
424
    }
425
    taosMemoryFree(pOld->pColumns);
5,322,732✔
426
    pOld->pColumns = pColumns;
5,322,732✔
427
  }
428

429
  if (pOld->numOfTags < pNew->numOfTags) {
22,612,106✔
430
    void *pTags = taosMemoryMalloc(pNew->numOfTags * sizeof(SSchema));
564,830✔
431
    if (pTags == NULL) {
564,830✔
UNCOV
432
      goto END;
×
433
    }
434
    taosMemoryFree(pOld->pTags);
564,830✔
435
    pOld->pTags = pTags;
564,830✔
436
  }
437

438
  if (pOld->commentLen < pNew->commentLen && pNew->commentLen > 0) {
22,612,106✔
439
    void *comment = taosMemoryMalloc(pNew->commentLen + 1);
12,278✔
440
    if (comment == NULL) {
12,278✔
UNCOV
441
      goto END;
×
442
    }
443
    taosMemoryFree(pOld->comment);
12,278✔
444
    pOld->comment = comment;
12,278✔
445
  }
446
  pOld->commentLen = pNew->commentLen;
22,612,106✔
447

448
  if (pOld->ast1Len < pNew->ast1Len) {
22,612,106✔
UNCOV
449
    void *pAst1 = taosMemoryMalloc(pNew->ast1Len + 1);
×
UNCOV
450
    if (pAst1 == NULL) {
×
UNCOV
451
      goto END;
×
452
    }
UNCOV
453
    taosMemoryFree(pOld->pAst1);
×
UNCOV
454
    pOld->pAst1 = pAst1;
×
455
  }
456

457
  if (pOld->ast2Len < pNew->ast2Len) {
22,612,106✔
458
    void *pAst2 = taosMemoryMalloc(pNew->ast2Len + 1);
×
UNCOV
459
    if (pAst2 == NULL) {
×
460
      goto END;
×
461
    }
UNCOV
462
    taosMemoryFree(pOld->pAst2);
×
UNCOV
463
    pOld->pAst2 = pAst2;
×
464
  }
465

466
  pOld->updateTime = pNew->updateTime;
22,612,106✔
467
  pOld->tagVer = pNew->tagVer;
22,612,106✔
468
  pOld->colVer = pNew->colVer;
22,612,106✔
469
  pOld->smaVer = pNew->smaVer;
22,612,106✔
470
  pOld->nextColId = pNew->nextColId;
22,612,106✔
471
  pOld->ttl = pNew->ttl;
22,612,106✔
472
  pOld->keep = pNew->keep;
22,612,106✔
473
  pOld->ownerId = pNew->ownerId;
22,612,106✔
474
  pOld->secureDelete = pNew->secureDelete;
22,612,106✔
475

476
  if (pNew->numOfColumns > 0) {
22,612,106✔
477
    pOld->numOfColumns = pNew->numOfColumns;
22,612,106✔
478
    memcpy(pOld->pColumns, pNew->pColumns, pOld->numOfColumns * sizeof(SSchema));
22,612,106✔
479
  }
480
  if (pNew->numOfTags > 0) {
22,612,106✔
481
    pOld->numOfTags = pNew->numOfTags;
22,612,106✔
482
    memcpy(pOld->pTags, pNew->pTags, pOld->numOfTags * sizeof(SSchema));
22,612,106✔
483
  }
484
  if (pNew->commentLen > 0) {
22,612,106✔
485
    memcpy(pOld->comment, pNew->comment, pNew->commentLen + 1);
82,950✔
486
    pOld->commentLen = pNew->commentLen;
82,950✔
487
  }
488
  if (pNew->ast1Len != 0) {
22,612,106✔
UNCOV
489
    memcpy(pOld->pAst1, pNew->pAst1, pNew->ast1Len);
×
UNCOV
490
    pOld->ast1Len = pNew->ast1Len;
×
491
  }
492
  if (pNew->ast2Len != 0) {
22,612,106✔
UNCOV
493
    memcpy(pOld->pAst2, pNew->pAst2, pNew->ast2Len);
×
UNCOV
494
    pOld->ast2Len = pNew->ast2Len;
×
495
  }
496
  if (numOfColumns < pNew->numOfColumns) {
22,612,106✔
497
    taosMemoryFree(pOld->pCmpr);
5,322,732✔
498
    pOld->pCmpr = taosMemoryCalloc(pNew->numOfColumns, sizeof(SColCmpr));
5,322,732✔
499
    if (pOld->pCmpr == NULL){
5,322,732✔
UNCOV
500
      goto END;
×
501
    }
502
    memcpy(pOld->pCmpr, pNew->pCmpr, pNew->numOfColumns * sizeof(SColCmpr));
5,322,732✔
503
  } else {
504
    memcpy(pOld->pCmpr, pNew->pCmpr, pNew->numOfColumns * sizeof(SColCmpr));
17,289,374✔
505
  }
506

507
  if (pNew->pExtSchemas) {
22,612,106✔
508
    taosMemoryFreeClear(pOld->pExtSchemas);
12,897,730✔
509
    pOld->pExtSchemas = taosMemoryCalloc(pNew->numOfColumns, sizeof(SExtSchema));
12,897,730✔
510
    if (pOld->pExtSchemas == NULL){
12,897,730✔
UNCOV
511
      goto END;
×
512
    }
513
    memcpy(pOld->pExtSchemas, pNew->pExtSchemas, pNew->numOfColumns * sizeof(SExtSchema));
12,897,730✔
514
  }
515

516
END:
9,714,376✔
517
  taosWUnLockLatch(&pOld->lock);
22,612,106✔
518
  return terrno;
22,612,106✔
519
}
520

521
SStbObj *mndAcquireStb(SMnode *pMnode, char *stbName) {
69,959,628✔
522
  SSdb    *pSdb = pMnode->pSdb;
69,959,628✔
523
  SStbObj *pStb = sdbAcquire(pSdb, SDB_STB, stbName);
69,959,628✔
524
  if (pStb == NULL && terrno == TSDB_CODE_SDB_OBJ_NOT_THERE) {
69,959,628✔
525
    terrno = TSDB_CODE_MND_STB_NOT_EXIST;
6,239,904✔
526
  }
527
  return pStb;
69,959,532✔
528
}
529

530
void mndReleaseStb(SMnode *pMnode, SStbObj *pStb) {
68,442,404✔
531
  SSdb *pSdb = pMnode->pSdb;
68,442,404✔
532
  sdbRelease(pSdb, pStb);
68,442,404✔
533
}
68,442,404✔
534

535
SDbObj *mndAcquireDbByStb(SMnode *pMnode, const char *stbName) {
16,338,894✔
536
  SName name = {0};
16,338,894✔
537
  if ((terrno = tNameFromString(&name, stbName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) return NULL;
16,338,894✔
538

539
  char db[TSDB_TABLE_FNAME_LEN] = {0};
16,338,894✔
540
  if ((terrno = tNameGetFullDbName(&name, db)) != 0) return NULL;
16,338,894✔
541

542
  return mndAcquireDb(pMnode, db);
16,338,894✔
543
}
544

545
static FORCE_INLINE int32_t schemaExColIdCompare(const void *colId, const void *pSchema) {
546
  if (*(col_id_t *)colId < ((SSchema *)pSchema)->colId) {
547
    return -1;
548
  } else if (*(col_id_t *)colId > ((SSchema *)pSchema)->colId) {
549
    return 1;
550
  }
551
  return 0;
552
}
553

554
void *mndBuildVCreateStbReq(SMnode *pMnode, SVgObj *pVgroup, SStbObj *pStb, int32_t *pContLen, void *alterOriData,
21,778,564✔
555
                            int32_t alterOriDataLen) {
556
  SEncoder       encoder = {0};
21,778,564✔
557
  int32_t        contLen;
558
  SName          name = {0};
21,778,564✔
559
  SVCreateStbReq req = {0};
21,778,564✔
560

561
  if ((terrno = tNameFromString(&name, pStb->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
21,778,564✔
UNCOV
562
    goto _err;
×
563
  }
564
  char dbFName[TSDB_DB_FNAME_LEN] = {0};
21,778,564✔
565
  if ((terrno = tNameGetFullDbName(&name, dbFName)) != 0) {
21,778,564✔
UNCOV
566
    goto _err;
×
567
  };
568

569
  req.name = (char *)tNameGetTableName(&name);
21,778,564✔
570
  req.suid = pStb->uid;
21,778,564✔
571
  req.rollup = pStb->ast1Len > 0 ? 1 : 0;
21,778,564✔
572
  req.alterOriData = alterOriData;
21,778,564✔
573
  req.alterOriDataLen = alterOriDataLen;
21,778,564✔
574
  req.source = pStb->source;
21,778,564✔
575
  req.virtualStb = pStb->virtualStb;
21,778,564✔
576
  req.secureDelete = pStb->secureDelete;
21,778,564✔
577
  // todo
578
  req.schemaRow.nCols = pStb->numOfColumns;
21,778,564✔
579
  req.schemaRow.version = pStb->colVer;
21,778,564✔
580
  req.schemaRow.pSchema = pStb->pColumns;
21,778,564✔
581
  req.schemaTag.nCols = pStb->numOfTags;
21,778,564✔
582
  req.schemaTag.version = pStb->tagVer;
21,778,564✔
583
  req.schemaTag.pSchema = pStb->pTags;
21,778,564✔
584

585
  req.colCmpred = 1;
21,778,564✔
586
  SColCmprWrapper *pCmpr = &req.colCmpr;
21,778,564✔
587
  req.keep = pStb->keep;
21,778,564✔
588
  pCmpr->version = pStb->colVer;
21,778,564✔
589
  pCmpr->nCols = pStb->numOfColumns;
21,778,564✔
590

591
  req.colCmpr.pColCmpr = taosMemoryCalloc(pCmpr->nCols, sizeof(SColCmpr));
21,778,564✔
592
  for (int32_t i = 0; i < pStb->numOfColumns; i++) {
1,856,550,634✔
593
    SColCmpr *p = &pCmpr->pColCmpr[i];
1,834,772,070✔
594
    p->alg = pStb->pCmpr[i].alg;
1,834,772,070✔
595
    p->id = pStb->pCmpr[i].id;
1,834,772,070✔
596
  }
597

598
  req.pExtSchemas = pStb->pExtSchemas; // only reference to it.
21,778,564✔
599
  // get length
600
  int32_t ret = 0;
21,778,564✔
601
  tEncodeSize(tEncodeSVCreateStbReq, &req, contLen, ret);
21,778,564✔
602
  if (ret < 0) {
21,778,564✔
UNCOV
603
    goto _err;
×
604
  }
605

606
  contLen += sizeof(SMsgHead);
21,778,564✔
607

608
  SMsgHead *pHead = taosMemoryCalloc(1, contLen);
21,778,564✔
609
  if (pHead == NULL) {
21,778,564✔
UNCOV
610
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
611
    goto _err;
×
612
  }
613

614
  pHead->contLen = htonl(contLen);
21,778,564✔
615
  pHead->vgId = htonl(pVgroup->vgId);
21,778,564✔
616

617
  void *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
21,778,564✔
618
  tEncoderInit(&encoder, pBuf, contLen - sizeof(SMsgHead));
21,778,564✔
619
  if (tEncodeSVCreateStbReq(&encoder, &req) < 0) {
21,778,564✔
620
    taosMemoryFreeClear(pHead);
×
UNCOV
621
    tEncoderClear(&encoder);
×
UNCOV
622
    goto _err;
×
623
  }
624
  tEncoderClear(&encoder);
21,778,564✔
625

626
  *pContLen = contLen;
21,778,564✔
627
  taosMemoryFreeClear(req.rsmaParam.name);
21,778,564✔
628
  taosMemoryFreeClear(req.rsmaParam.funcColIds);
21,778,564✔
629
  taosMemoryFreeClear(req.rsmaParam.funcIds);
21,778,564✔
630
  taosMemoryFreeClear(req.colCmpr.pColCmpr);
21,778,564✔
631
  return pHead;
21,778,564✔
UNCOV
632
_err:
×
UNCOV
633
  taosMemoryFreeClear(req.rsmaParam.name);
×
UNCOV
634
  taosMemoryFreeClear(req.rsmaParam.funcColIds);
×
UNCOV
635
  taosMemoryFreeClear(req.rsmaParam.funcIds);
×
UNCOV
636
  taosMemoryFreeClear(req.colCmpr.pColCmpr);
×
UNCOV
637
  return NULL;
×
638
}
639

640
static void *mndBuildVDropStbReq(SMnode *pMnode, SVgObj *pVgroup, SStbObj *pStb, int32_t *pContLen) {
10,572,940✔
641
  SName        name = {0};
10,572,940✔
642
  SVDropStbReq req = {0};
10,572,940✔
643
  int32_t      contLen = 0;
10,572,940✔
644
  int32_t      ret = 0;
10,572,940✔
645
  SMsgHead    *pHead = NULL;
10,572,940✔
646
  SEncoder     encoder = {0};
10,572,940✔
647

648
  if ((terrno = tNameFromString(&name, pStb->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
10,572,940✔
UNCOV
649
    return NULL;
×
650
  }
651

652
  req.name = (char *)tNameGetTableName(&name);
10,572,940✔
653
  req.suid = pStb->uid;
10,572,940✔
654

655
  tEncodeSize(tEncodeSVDropStbReq, &req, contLen, ret);
10,572,940✔
656
  if (ret < 0) return NULL;
10,572,940✔
657

658
  contLen += sizeof(SMsgHead);
10,572,940✔
659
  pHead = taosMemoryMalloc(contLen);
10,572,940✔
660
  if (pHead == NULL) {
10,572,940✔
UNCOV
661
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
662
    return NULL;
×
663
  }
664

665
  pHead->contLen = htonl(contLen);
10,572,940✔
666
  pHead->vgId = htonl(pVgroup->vgId);
10,572,940✔
667

668
  void *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
10,572,940✔
669

670
  tEncoderInit(&encoder, pBuf, contLen - sizeof(SMsgHead));
10,572,940✔
671
  int32_t code = tEncodeSVDropStbReq(&encoder, &req);
10,572,940✔
672
  tEncoderClear(&encoder);
10,572,940✔
673
  if (code != 0) {
10,572,940✔
UNCOV
674
    terrno = code;
×
UNCOV
675
    return NULL;
×
676
  }
677

678
  *pContLen = contLen;
10,572,940✔
679
  return pHead;
10,572,940✔
680
}
681

682
int32_t mndCheckCreateStbReq(SMCreateStbReq *pCreate) {
4,040,506✔
683
  int32_t code = 0;
4,040,506✔
684
  if (pCreate->igExists < 0 || pCreate->igExists > 1) {
4,040,506✔
UNCOV
685
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
686
    TAOS_RETURN(code);
×
687
  }
688

689
  if (pCreate->virtualStb != 0 && pCreate->virtualStb != 1) {
4,040,506✔
UNCOV
690
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
691
    TAOS_RETURN(code);
×
692
  }
693

694
  int32_t maxColumns = pCreate->virtualStb ? TSDB_MAX_COLUMNS : TSDB_MAX_COLUMNS_NON_VIRTUAL;
4,040,506✔
695
  if (pCreate->numOfColumns < TSDB_MIN_COLUMNS || pCreate->numOfTags + pCreate->numOfColumns > maxColumns) {
4,040,506✔
UNCOV
696
    code = TSDB_CODE_PAR_INVALID_COLUMNS_NUM;
×
UNCOV
697
    TAOS_RETURN(code);
×
698
  }
699

700
  if (pCreate->numOfTags <= 0 || pCreate->numOfTags > TSDB_MAX_TAGS) {
4,040,506✔
UNCOV
701
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
702
    TAOS_RETURN(code);
×
703
  }
704

705
  SField *pField = taosArrayGet(pCreate->pColumns, 0);
4,040,506✔
706
  if (pField->type != TSDB_DATA_TYPE_TIMESTAMP) {
4,040,506✔
UNCOV
707
    code = TSDB_CODE_PAR_INVALID_FIRST_COLUMN;
×
UNCOV
708
    TAOS_RETURN(code);
×
709
  }
710

711
  for (int32_t i = 0; i < pCreate->numOfColumns; ++i) {
314,985,300✔
712
    SFieldWithOptions *pField1 = taosArrayGet(pCreate->pColumns, i);
310,944,794✔
713
    if (pField1->type >= TSDB_DATA_TYPE_MAX) {
310,944,794✔
UNCOV
714
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
715
      TAOS_RETURN(code);
×
716
    }
717
    if (pField1->bytes <= 0) {
310,944,794✔
UNCOV
718
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
719
      TAOS_RETURN(code);
×
720
    }
721
    if (pField1->name[0] == 0) {
310,944,794✔
UNCOV
722
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
723
      TAOS_RETURN(code);
×
724
    }
725
  }
726

727
  for (int32_t i = 0; i < pCreate->numOfTags; ++i) {
20,835,474✔
728
    SField *pField1 = taosArrayGet(pCreate->pTags, i);
16,794,968✔
729
    if (pField1->type >= TSDB_DATA_TYPE_MAX) {
16,794,968✔
UNCOV
730
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
731
      TAOS_RETURN(code);
×
732
    }
733
    if (pField1->bytes <= 0) {
16,794,968✔
UNCOV
734
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
735
      TAOS_RETURN(code);
×
736
    }
737
    if (pField1->name[0] == 0) {
16,794,968✔
UNCOV
738
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
739
      TAOS_RETURN(code);
×
740
    }
741
  }
742

743
  TAOS_RETURN(code);
4,040,506✔
744
}
745

UNCOV
746
static int32_t mndSetCreateStbPrepareLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
×
747
  int32_t  code = 0;
×
748
  SSdbRaw *pRedoRaw = mndStbActionEncode(pStb);
×
UNCOV
749
  if (pRedoRaw == NULL) {
×
UNCOV
750
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
751
    if (terrno != 0) code = terrno;
×
UNCOV
752
    TAOS_RETURN(code);
×
753
  }
UNCOV
754
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
×
755
    sdbFreeRaw(pRedoRaw);
×
756
    TAOS_RETURN(code);
×
757
  }
758
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_CREATING));
×
759

760
  TAOS_RETURN(code);
×
761
}
762

763
int32_t mndSetCreateStbCommitLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
3,917,014✔
764
  int32_t  code = 0;
3,917,014✔
765
  SSdbRaw *pCommitRaw = mndStbActionEncode(pStb);
3,917,014✔
766
  if (pCommitRaw == NULL) {
3,917,014✔
767
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
768
    if (terrno != 0) code = terrno;
×
769
    TAOS_RETURN(code);
×
770
  }
771
  mInfo("trans:%d, add stb to commit log", pTrans->id);
3,917,014✔
772
  if ((code = mndTransAppendCommitlog(pTrans, pCommitRaw)) != 0) {
3,917,014✔
UNCOV
773
    sdbFreeRaw(pCommitRaw);
×
UNCOV
774
    TAOS_RETURN(code);
×
775
  }
776
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
3,917,014✔
777

778
  TAOS_RETURN(code);
3,917,014✔
779
}
780

781
static int32_t mndSetCreateStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
3,913,140✔
782
  int32_t code = 0;
3,913,140✔
783
  SSdb   *pSdb = pMnode->pSdb;
3,913,140✔
784
  SVgObj *pVgroup = NULL;
3,913,140✔
785
  void   *pIter = NULL;
3,913,140✔
786
  int32_t contLen;
3,908,298✔
787

788
  while (1) {
17,441,594✔
789
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
21,354,734✔
790
    if (pIter == NULL) break;
21,354,734✔
791
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
17,441,594✔
792
      sdbRelease(pSdb, pVgroup);
8,753,756✔
793
      continue;
8,753,756✔
794
    }
795

796
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, NULL, 0);
8,687,838✔
797
    if (pReq == NULL) {
8,687,838✔
UNCOV
798
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
799
      sdbRelease(pSdb, pVgroup);
×
UNCOV
800
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
801
      if (terrno != 0) code = terrno;
×
UNCOV
802
      TAOS_RETURN(code);
×
803
    }
804

805
    STransAction action = {0};
8,687,838✔
806
    action.mTraceId = pTrans->mTraceId;
8,687,838✔
807
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
8,687,838✔
808
    action.pCont = pReq;
8,687,838✔
809
    action.contLen = contLen;
8,687,838✔
810
    action.msgType = TDMT_VND_CREATE_STB;
8,687,838✔
811
    action.acceptableCode = TSDB_CODE_TDB_STB_ALREADY_EXIST;
8,687,838✔
812
    action.retryCode = TSDB_CODE_TDB_STB_NOT_EXIST;
8,687,838✔
813
    mInfo("trans:%d, add create stb to redo action", pTrans->id);
8,687,838✔
814
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
8,687,838✔
UNCOV
815
      taosMemoryFree(pReq);
×
UNCOV
816
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
817
      sdbRelease(pSdb, pVgroup);
×
UNCOV
818
      TAOS_RETURN(code);
×
819
    }
820
    sdbRelease(pSdb, pVgroup);
8,687,838✔
821
  }
822

823
  TAOS_RETURN(code);
3,913,140✔
824
}
825

826
int32_t mndSetForceDropCreateStbRedoActions(SMnode *pMnode, STrans *pTrans, SVgObj *pVgroup, SStbObj *pStb) {
×
827
  int32_t code = 0;
×
UNCOV
828
  SSdb   *pSdb = pMnode->pSdb;
×
UNCOV
829
  int32_t contLen;
×
830

UNCOV
831
  void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, NULL, 0);
×
UNCOV
832
  if (pReq == NULL) {
×
UNCOV
833
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
834
    if (terrno != 0) code = terrno;
×
835
    TAOS_RETURN(code);
×
836
  }
837

838
  STransAction action = {0};
×
UNCOV
839
  action.mTraceId = pTrans->mTraceId;
×
840
  action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
×
841
  action.pCont = pReq;
×
842
  action.contLen = contLen;
×
843
  action.msgType = TDMT_VND_CREATE_STB;
×
844
  action.acceptableCode = TSDB_CODE_TDB_STB_ALREADY_EXIST;
×
UNCOV
845
  action.retryCode = TSDB_CODE_TDB_STB_NOT_EXIST;
×
UNCOV
846
  action.groupId = pVgroup->vgId;
×
847
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
×
848
    taosMemoryFree(pReq);
×
849
    TAOS_RETURN(code);
×
850
  }
851

852
  TAOS_RETURN(code);
×
853
}
854

855
static int32_t mndSetCreateStbUndoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
3,913,140✔
856
  int32_t code = 0;
3,913,140✔
857
  SSdb   *pSdb = pMnode->pSdb;
3,913,140✔
858
  SVgObj *pVgroup = NULL;
3,913,140✔
859
  void   *pIter = NULL;
3,913,140✔
860

861
  while (1) {
17,441,594✔
862
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
21,354,734✔
863
    if (pIter == NULL) break;
21,354,734✔
864
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
17,441,594✔
865
      sdbRelease(pSdb, pVgroup);
8,753,756✔
866
      continue;
8,753,756✔
867
    }
868

869
    int32_t contLen = 0;
8,687,838✔
870
    void   *pReq = mndBuildVDropStbReq(pMnode, pVgroup, pStb, &contLen);
8,687,838✔
871
    if (pReq == NULL) {
8,687,838✔
UNCOV
872
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
873
      sdbRelease(pSdb, pVgroup);
×
UNCOV
874
      code = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
875
      TAOS_RETURN(code);
×
876
    }
877

878
    STransAction action = {0};
8,687,838✔
879
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
8,687,838✔
880
    action.pCont = pReq;
8,687,838✔
881
    action.contLen = contLen;
8,687,838✔
882
    action.msgType = TDMT_VND_DROP_STB;
8,687,838✔
883
    action.acceptableCode = TSDB_CODE_TDB_STB_NOT_EXIST;
8,687,838✔
884
    mInfo("trans:%d, add drop stb to undo action", pTrans->id);
8,687,838✔
885
    if ((code = mndTransAppendUndoAction(pTrans, &action)) != 0) {
8,687,838✔
UNCOV
886
      taosMemoryFree(pReq);
×
UNCOV
887
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
888
      sdbRelease(pSdb, pVgroup);
×
UNCOV
889
      TAOS_RETURN(code);
×
890
    }
891
    sdbRelease(pSdb, pVgroup);
8,687,838✔
892
  }
893

894
  TAOS_RETURN(code);
3,913,140✔
895
}
896

897
static SSchema *mndFindStbColumns(const SStbObj *pStb, const char *colName) {
×
898
  for (int32_t col = 0; col < pStb->numOfColumns; ++col) {
×
UNCOV
899
    SSchema *pSchema = &pStb->pColumns[col];
×
UNCOV
900
    if (taosStrncasecmp(pSchema->name, colName, TSDB_COL_NAME_LEN) == 0) {
×
UNCOV
901
      return pSchema;
×
902
    }
903
  }
UNCOV
904
  return NULL;
×
905
}
906

907
int32_t mndBuildStbFromReq(SMnode *pMnode, SStbObj *pDst, SMCreateStbReq *pCreate, SDbObj *pDb) {
3,926,556✔
908
  int32_t code = 0;
3,926,556✔
909
  bool    hasTypeMods = false;
3,926,556✔
910
  memcpy(pDst->name, pCreate->name, TSDB_TABLE_FNAME_LEN);
3,926,556✔
911
  memcpy(pDst->db, pDb->name, TSDB_DB_FNAME_LEN);
3,926,556✔
912
  pDst->createdTime = taosGetTimestampMs();
3,926,556✔
913
  pDst->updateTime = pDst->createdTime;
3,926,556✔
914
  pDst->uid = (pCreate->source == TD_REQ_FROM_TAOX_OLD || pCreate->source == TD_REQ_FROM_TAOX || pCreate->source == TD_REQ_FROM_SML)
11,769,984✔
915
                  ? pCreate->suid
916
                  : mndGenerateUid(pCreate->name, TSDB_TABLE_FNAME_LEN);
7,853,112✔
917
  pDst->dbUid = pDb->uid;
3,926,556✔
918
  pDst->tagVer = 1;
3,926,556✔
919
  pDst->colVer = 1;
3,926,556✔
920
  pDst->smaVer = 1;
3,926,556✔
921
  pDst->nextColId = 1;
3,926,556✔
922
  pDst->maxdelay[0] = pCreate->delay1;
3,926,556✔
923
  pDst->maxdelay[1] = pCreate->delay2;
3,926,556✔
924
  pDst->watermark[0] = pCreate->watermark1;
3,926,556✔
925
  pDst->watermark[1] = pCreate->watermark2;
3,926,556✔
926
  pDst->ttl = pCreate->ttl;
3,926,556✔
927
  pDst->numOfColumns = pCreate->numOfColumns;
3,926,556✔
928
  pDst->numOfTags = pCreate->numOfTags;
3,926,556✔
929
  pDst->numOfFuncs = pCreate->numOfFuncs;
3,926,556✔
930
  pDst->commentLen = pCreate->commentLen;
3,926,556✔
931
  pDst->pFuncs = pCreate->pFuncs;
3,926,556✔
932
  pDst->source = pCreate->source;
3,926,556✔
933
  pDst->keep = pCreate->keep;
3,926,556✔
934
  pDst->virtualStb = pCreate->virtualStb;
3,926,556✔
935
  pDst->secureDelete = pCreate->secureDelete;
3,926,556✔
936
  pCreate->pFuncs = NULL;
3,926,556✔
937

938
  if (pDst->commentLen > 0) {
3,926,556✔
939
    pDst->comment = taosMemoryCalloc(pDst->commentLen + 1, 1);
18,094✔
940
    if (pDst->comment == NULL) {
18,094✔
UNCOV
941
      code = terrno;
×
UNCOV
942
      TAOS_RETURN(code);
×
943
    }
944
    memcpy(pDst->comment, pCreate->pComment, pDst->commentLen + 1);
18,094✔
945
  }
946

947
  pDst->ast1Len = pCreate->ast1Len;
3,926,556✔
948
  if (pDst->ast1Len > 0) {
3,926,556✔
UNCOV
949
    pDst->pAst1 = taosMemoryCalloc(pDst->ast1Len, 1);
×
UNCOV
950
    if (pDst->pAst1 == NULL) {
×
951
      code = terrno;
×
952
      TAOS_RETURN(code);
×
953
    }
UNCOV
954
    memcpy(pDst->pAst1, pCreate->pAst1, pDst->ast1Len);
×
955
  }
956

957
  pDst->ast2Len = pCreate->ast2Len;
3,926,556✔
958
  if (pDst->ast2Len > 0) {
3,926,556✔
959
    pDst->pAst2 = taosMemoryCalloc(pDst->ast2Len, 1);
×
960
    if (pDst->pAst2 == NULL) {
×
961
      code = terrno;
×
962
      TAOS_RETURN(code);
×
963
    }
964
    memcpy(pDst->pAst2, pCreate->pAst2, pDst->ast2Len);
×
965
  }
966

967
  pDst->pColumns = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SSchema));
3,926,556✔
968
  pDst->pTags = taosMemoryCalloc(1, pDst->numOfTags * sizeof(SSchema));
3,926,556✔
969
  if (pDst->pColumns == NULL || pDst->pTags == NULL) {
3,926,556✔
970
    code = terrno;
×
971
    TAOS_RETURN(code);
×
972
  }
973

974
  if (pDst->nextColId < 0 || pDst->nextColId >= 0x7fff - pDst->numOfColumns - pDst->numOfTags) {
3,926,556✔
975
    code = TSDB_CODE_OUT_OF_RANGE;
2,240✔
976
    TAOS_RETURN(code);
2,240✔
977
  }
978

979
  for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
240,824,052✔
980
    SFieldWithOptions *pField = taosArrayGet(pCreate->pColumns, i);
236,899,736✔
981
    SSchema           *pSchema = &pDst->pColumns[i];
236,899,736✔
982
    pSchema->type = pField->type;
236,899,736✔
983
    pSchema->bytes = pField->bytes;
236,899,736✔
984
    pSchema->flags = pField->flags;
236,899,736✔
985
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
236,899,736✔
986
    pSchema->colId = pDst->nextColId;
236,899,736✔
987
    pDst->nextColId++;
236,899,736✔
988
    hasTypeMods = hasTypeMods || HAS_TYPE_MOD(pSchema);
236,899,736✔
989
  }
990

991
  for (int32_t i = 0; i < pDst->numOfTags; ++i) {
20,167,448✔
992
    SField  *pField = taosArrayGet(pCreate->pTags, i);
16,243,132✔
993
    SSchema *pSchema = &pDst->pTags[i];
16,243,132✔
994
    pSchema->type = pField->type;
16,243,132✔
995
    pSchema->bytes = pField->bytes;
16,243,132✔
996
    if (i == 0) {
16,243,132✔
997
      SSCHMEA_SET_IDX_ON(pSchema);
3,924,316✔
998
    }
999
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
16,243,132✔
1000
    pSchema->colId = pDst->nextColId;
16,243,132✔
1001
    pDst->nextColId++;
16,243,132✔
1002
  }
1003
  // set col compress
1004
  pDst->pCmpr = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SCmprObj));
3,924,316✔
1005
  for (int32_t i = 0; i < pDst->numOfColumns; i++) {
240,824,052✔
1006
    SFieldWithOptions *pField = taosArrayGet(pCreate->pColumns, i);
236,899,736✔
1007
    SSchema           *pSchema = &pDst->pColumns[i];
236,899,736✔
1008

1009
    SColCmpr *pColCmpr = &pDst->pCmpr[i];
236,899,736✔
1010
    pColCmpr->id = pSchema->colId;
236,899,736✔
1011
    pColCmpr->alg = pField->compress;
236,899,736✔
1012
  }
1013

1014
  if (hasTypeMods) {
3,924,316✔
1015
    pDst->pExtSchemas = taosMemoryCalloc(pDst->numOfColumns, sizeof(SExtSchema));
41,588✔
1016
    if (!pDst->pExtSchemas) {
41,588✔
UNCOV
1017
      code = terrno;
×
UNCOV
1018
      TAOS_RETURN(code);
×
1019
    }
1020
    for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
667,336✔
1021
      SFieldWithOptions * pField = taosArrayGet(pCreate->pColumns, i);
625,748✔
1022
      pDst->pExtSchemas[i].typeMod = pField->typeMod;
625,748✔
1023
    }
1024
  }
1025
  TAOS_RETURN(code);
3,924,316✔
1026
}
1027
int32_t mndGenIdxNameForFirstTag(char *fullname, char *dbname, char *stbname, char *tagname) {
3,788,494✔
1028
  SName name = {0};
3,788,494✔
1029
  if ((terrno = tNameFromString(&name, stbname, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
3,788,494✔
UNCOV
1030
    return -1;
×
1031
  }
1032
  return snprintf(fullname, TSDB_INDEX_FNAME_LEN, "%s.%s_%s", dbname, tagname, tNameGetTableName(&name));
3,788,494✔
1033
}
1034

1035
static int32_t mndCreateStb(SMnode *pMnode, SRpcMsg *pReq, SMCreateStbReq *pCreate, SDbObj *pDb, SUserObj *pOperUser) {
3,786,860✔
1036
  SStbObj stbObj = {0};
3,786,860✔
1037
  int32_t code = -1;
3,786,860✔
1038

1039
  char fullIdxName[TSDB_INDEX_FNAME_LEN * 2] = {0};
3,786,860✔
1040

1041
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_ROLLBACK, TRN_CONFLICT_DB_INSIDE, pReq, "create-stb");
3,786,860✔
1042
  if (pTrans == NULL) {
3,786,860✔
UNCOV
1043
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
1044
    if (terrno != 0) code = terrno;
×
UNCOV
1045
    goto _OVER;
×
1046
  }
1047

1048
  mInfo("trans:%d, used to create stb:%s", pTrans->id, pCreate->name);
3,786,860✔
1049
  TAOS_CHECK_GOTO(mndBuildStbFromReq(pMnode, &stbObj, pCreate, pDb), NULL, _OVER);
3,786,860✔
1050
  memcpy(stbObj.createUser, pOperUser->name, TSDB_USER_LEN);
3,784,620✔
1051
  stbObj.ownerId = pOperUser->uid;
3,784,620✔
1052

1053

1054
  SSchema *pSchema = &(stbObj.pTags[0]);
3,784,620✔
1055
  if (mndGenIdxNameForFirstTag(fullIdxName, pDb->name, stbObj.name, pSchema->name) < 0) {
3,784,620✔
UNCOV
1056
    code = terrno;
×
UNCOV
1057
    goto _OVER;
×
1058
  }
1059
  SSIdx idx = {0};
3,784,620✔
1060
  if (mndAcquireGlobalIdx(pMnode, fullIdxName, SDB_IDX, &idx) == 0 && idx.pIdx != NULL) {
3,784,620✔
UNCOV
1061
    code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
×
UNCOV
1062
    mndReleaseIdx(pMnode, idx.pIdx);
×
UNCOV
1063
    goto _OVER;
×
1064
  }
1065

1066
  SIdxObj idxObj = {0};
3,784,620✔
1067
  memcpy(idxObj.name, fullIdxName, TSDB_INDEX_FNAME_LEN);
3,784,620✔
1068
  memcpy(idxObj.stb, stbObj.name, TSDB_TABLE_FNAME_LEN);
3,784,620✔
1069
  memcpy(idxObj.db, stbObj.db, TSDB_DB_FNAME_LEN);
3,784,620✔
1070
  memcpy(idxObj.colName, pSchema->name, TSDB_COL_NAME_LEN);
3,784,620✔
1071
  memcpy(idxObj.createUser, pOperUser->name, TSDB_USER_LEN);
3,784,620✔
1072
  idxObj.ownerId = pOperUser->uid;
3,784,620✔
1073
  idxObj.createdTime = taosGetTimestampMs();
3,784,620✔
1074
  idxObj.uid = mndGenerateUid(fullIdxName, strlen(fullIdxName));
3,784,620✔
1075
  idxObj.stbUid = stbObj.uid;
3,784,620✔
1076
  idxObj.dbUid = stbObj.dbUid;
3,784,620✔
1077

1078
  TAOS_CHECK_GOTO(mndSetCreateIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
3,784,620✔
1079

1080
  TAOS_CHECK_GOTO(mndAddStbToTrans(pMnode, pTrans, pDb, &stbObj), NULL, _OVER);
3,784,620✔
1081
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
3,773,444✔
1082
  code = 0;
3,773,444✔
1083

1084
_OVER:
3,786,860✔
1085
  mndTransDrop(pTrans);
3,786,860✔
1086
  if (mndStbActionDelete(pMnode->pSdb, &stbObj) != 0) mError("failed to mndStbActionDelete");
3,786,860✔
1087
  TAOS_RETURN(code);
3,786,860✔
1088
}
1089

1090
typedef struct {
1091
  const char *name;
1092
  uint8_t     type;
1093
  int32_t     bytes;
1094
  uint32_t    alg;
1095
} AuditColumnDef;
1096

1097
// column is consistent with vnodePrepareRow process in vnodeSvr.c
1098
static const AuditColumnDef audit_columns[] = {
1099
    {"ts", TSDB_DATA_TYPE_TIMESTAMP, 8, 0x2000102},
1100
    {"details", TSDB_DATA_TYPE_VARCHAR, 50000 + VARSTR_HEADER_SIZE, 0xFF000302},
1101
    {"user_name", TSDB_DATA_TYPE_VARCHAR, 25 + VARSTR_HEADER_SIZE, 0xFF000302},
1102
    {"operation", TSDB_DATA_TYPE_VARCHAR, 20 + VARSTR_HEADER_SIZE, 0xFF000302},
1103
    {"db", TSDB_DATA_TYPE_VARCHAR, TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE, 0xFF000302},
1104
    {"resource", TSDB_DATA_TYPE_VARCHAR, TSDB_STREAM_NAME_LEN + VARSTR_HEADER_SIZE, 0xFF000302},
1105
    {"client_address", TSDB_DATA_TYPE_VARCHAR, AUDIT_CLIENT_ADD_LEN + VARSTR_HEADER_SIZE, 0xFF000302},
1106
    {"duration", TSDB_DATA_TYPE_DOUBLE, 8, 0x5000102},
1107
    {"affected_rows", TSDB_DATA_TYPE_UBIGINT, 8, 0x1000102}};
1108

1109
static int32_t mndBuildAuditStb(SMnode *pMnode, SStbObj *pDst, SDbObj *pDb) {
154✔
1110
  int32_t code = 0;
154✔
1111
  char   *name = AUDIT_STABLE_NAME;
154✔
1112
  (void)tsnprintf(pDst->name, TSDB_TABLE_FNAME_LEN, "%s.%s", pDb->name, name);
154✔
1113
  memcpy(pDst->db, pDb->name, TSDB_DB_FNAME_LEN);
154✔
1114
  pDst->createdTime = taosGetTimestampMs();
154✔
1115
  pDst->updateTime = pDst->createdTime;
154✔
1116
  pDst->uid = mndGenerateUid(pDst->name, strlen(pDst->name));
154✔
1117
  pDst->dbUid = pDb->uid;
154✔
1118
  pDst->tagVer = 1;
154✔
1119
  pDst->colVer = 1;
154✔
1120
  pDst->smaVer = 1;
154✔
1121
  pDst->nextColId = 1;
154✔
1122
  pDst->maxdelay[0] = -1;
154✔
1123
  pDst->maxdelay[1] = -1;
154✔
1124
  pDst->watermark[0] = 5000;
154✔
1125
  pDst->watermark[1] = 5000;
154✔
1126
  pDst->ttl = 0;
154✔
1127
  pDst->keep = -1;
154✔
1128
  pDst->source = 0;
154✔
1129
  pDst->virtualStb = 0;
154✔
1130
  pDst->numOfColumns = sizeof(audit_columns) / sizeof(AuditColumnDef);
154✔
1131
  pDst->numOfTags = 1;
154✔
1132
  pDst->numOfFuncs = 0;
154✔
1133
  pDst->commentLen = -1;
154✔
1134
  pDst->pFuncs = NULL;
154✔
1135

1136
  pDst->ast1Len = 0;
154✔
1137
  pDst->ast2Len = 0;
154✔
1138

1139
  pDst->pColumns = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SSchema));
154✔
1140
  pDst->pTags = taosMemoryCalloc(1, pDst->numOfTags * sizeof(SSchema));
154✔
1141
  pDst->pCmpr = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SCmprObj));
154✔
1142
  if (pDst->pColumns == NULL || pDst->pTags == NULL || pDst->pCmpr == NULL) {
154✔
UNCOV
1143
    code = terrno;
×
UNCOV
1144
    TAOS_RETURN(code);
×
1145
  }
1146

1147
  if (pDst->nextColId < 0 || pDst->nextColId >= 0x7fff - pDst->numOfColumns - pDst->numOfTags) {
154✔
UNCOV
1148
    code = TSDB_CODE_OUT_OF_RANGE;
×
UNCOV
1149
    TAOS_RETURN(code);
×
1150
  }
1151

1152
  SSchema *pSchema = NULL;
154✔
1153
  for (int32_t i = 0; i < sizeof(audit_columns) / sizeof(AuditColumnDef); ++i) {
1,540✔
1154
    pSchema = &pDst->pColumns[pDst->nextColId - 1];
1,386✔
1155
    pSchema->type = audit_columns[i].type;
1,386✔
1156
    pSchema->bytes = audit_columns[i].bytes;
1,386✔
1157
    pSchema->flags = 1;
1,386✔
1158
    tstrncpy(pSchema->name, audit_columns[i].name, TSDB_COL_NAME_LEN);
1,386✔
1159
    pSchema->colId = pDst->nextColId;
1,386✔
1160
    // hasTypeMods = hasTypeMods || HAS_TYPE_MOD(pSchema);
1161
    SColCmpr *pColCmpr = &pDst->pCmpr[pDst->nextColId - 1];
1,386✔
1162
    pColCmpr->id = pSchema->colId;
1,386✔
1163
    pColCmpr->alg = audit_columns[i].alg;
1,386✔
1164
    pDst->nextColId++;
1,386✔
1165
  }
1166

1167
  // tag
1168
  pSchema = &pDst->pTags[0];
154✔
1169
  pSchema->type = TSDB_DATA_TYPE_VARCHAR;
154✔
1170
  pSchema->bytes = 64 + VARSTR_HEADER_SIZE;
154✔
1171
  SSCHMEA_SET_IDX_ON(pSchema);
154✔
1172
  tstrncpy(pSchema->name, "cluster_id", TSDB_COL_NAME_LEN);
154✔
1173
  pSchema->colId = pDst->nextColId;
154✔
1174
  pDst->nextColId++;
154✔
1175

1176
  /*
1177
    if (hasTypeMods) {
1178
      pDst->pExtSchemas = taosMemoryCalloc(pDst->numOfColumns, sizeof(SExtSchema));
1179
      if (!pDst->pExtSchemas) {
1180
        code = terrno;
1181
        TAOS_RETURN(code);
1182
      }
1183
      for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
1184
        SFieldWithOptions *pField = taosArrayGet(pCreate->pColumns, i);
1185
        pDst->pExtSchemas[i].typeMod = pField->typeMod;
1186
      }
1187
    }
1188
  */
1189
  TAOS_RETURN(code);
154✔
1190
}
1191

1192
static int32_t mndSetCreateAuditStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb,
154✔
1193
                                               SVgObj *pVgroup) {
1194
  int32_t code = 0;
154✔
1195
  SSdb   *pSdb = pMnode->pSdb;
154✔
1196

1197
  int32_t contLen;
154✔
1198

1199
  if (pVgroup == NULL) {
154✔
UNCOV
1200
    code = TSDB_CODE_INVALID_PARA;
×
UNCOV
1201
    TAOS_RETURN(code);
×
1202
  }
1203

1204
  void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, NULL, 0);
154✔
1205
  if (pReq == NULL) {
154✔
UNCOV
1206
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
1207
    if (terrno != 0) code = terrno;
×
UNCOV
1208
    TAOS_RETURN(code);
×
1209
  }
1210

1211
  STransAction action = {0};
154✔
1212
  action.mTraceId = pTrans->mTraceId;
154✔
1213
  action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
154✔
1214
  action.pCont = pReq;
154✔
1215
  action.contLen = contLen;
154✔
1216
  action.msgType = TDMT_VND_CREATE_STB;
154✔
1217
  action.acceptableCode = TSDB_CODE_TDB_STB_ALREADY_EXIST;
154✔
1218
  action.retryCode = TSDB_CODE_TDB_STB_NOT_EXIST;
154✔
1219
  mInfo("trans:%d, add create stb to redo action", pTrans->id);
154✔
1220
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
154✔
UNCOV
1221
    taosMemoryFree(pReq);
×
UNCOV
1222
    TAOS_RETURN(code);
×
1223
  }
1224

1225
  TAOS_RETURN(code);
154✔
1226
}
1227

1228
// Note: pVgroup is expected to point to the first element of a vgroup array (e.g. pVgroups at the call site).
1229
// Only the first element is used for creating the audit super table.
1230
int32_t mndCreateAuditStb(SMnode *pMnode, SDbObj *pDb, SUserObj *pOperUser, STrans *pTrans, SVgObj *pVgroup) {
154✔
1231
  SStbObj stbObj = {0};
154✔
1232
  int32_t code = -1;
154✔
1233

1234
  char fullIdxName[TSDB_INDEX_FNAME_LEN * 2] = {0};
154✔
1235

1236
  TAOS_CHECK_GOTO(mndBuildAuditStb(pMnode, &stbObj, pDb), NULL, _OVER);
154✔
1237
  memcpy(stbObj.createUser, pOperUser->name, TSDB_USER_LEN);
154✔
1238
  stbObj.ownerId = pOperUser->uid;
154✔
1239

1240
  SSchema *pSchema = &(stbObj.pTags[0]);
154✔
1241
  if (mndGenIdxNameForFirstTag(fullIdxName, pDb->name, stbObj.name, pSchema->name) < 0) {
154✔
UNCOV
1242
    code = terrno;
×
UNCOV
1243
    goto _OVER;
×
1244
  }
1245

1246
  SSIdx idx = {0};
154✔
1247
  if (mndAcquireGlobalIdx(pMnode, fullIdxName, SDB_IDX, &idx) == 0 && idx.pIdx != NULL) {
154✔
UNCOV
1248
    code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
×
UNCOV
1249
    mndReleaseIdx(pMnode, idx.pIdx);
×
UNCOV
1250
    goto _OVER;
×
1251
  }
1252

1253
  SIdxObj idxObj = {0};
154✔
1254
  memcpy(idxObj.name, fullIdxName, TSDB_INDEX_FNAME_LEN);
154✔
1255
  memcpy(idxObj.stb, stbObj.name, TSDB_TABLE_FNAME_LEN);
154✔
1256
  memcpy(idxObj.db, stbObj.db, TSDB_DB_FNAME_LEN);
154✔
1257
  memcpy(idxObj.colName, pSchema->name, TSDB_COL_NAME_LEN);
154✔
1258
  memcpy(idxObj.createUser, pOperUser->name, TSDB_USER_LEN);
154✔
1259
  idxObj.ownerId = pOperUser->uid;
154✔
1260
  idxObj.createdTime = taosGetTimestampMs();
154✔
1261
  idxObj.uid = mndGenerateUid(fullIdxName, strlen(fullIdxName));
154✔
1262
  idxObj.stbUid = stbObj.uid;
154✔
1263
  idxObj.dbUid = stbObj.dbUid;
154✔
1264

1265
  mndTransSetDbName(pTrans, pDb->name, stbObj.name);
154✔
1266
  TAOS_CHECK_RETURN(mndTransCheckConflict(pMnode, pTrans));
154✔
1267
  TAOS_CHECK_GOTO(mndSetCreateIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
154✔
1268
  TAOS_CHECK_GOTO(mndSetCreateStbCommitLogs(pMnode, pTrans, pDb, &stbObj), NULL, _OVER);
154✔
1269
  TAOS_CHECK_GOTO(mndSetCreateAuditStbRedoActions(pMnode, pTrans, pDb, &stbObj, pVgroup), NULL, _OVER);
154✔
1270

1271
  code = 0;
154✔
1272

1273
_OVER:
154✔
1274
  if (mndStbActionDelete(pMnode->pSdb, &stbObj) != 0) mError("failed to mndStbActionDelete");
154✔
1275
  TAOS_RETURN(code);
154✔
1276
}
1277

1278
static int32_t mndProcessAuditRecordRsp(SRpcMsg *pRsp) {
616✔
1279
  int32_t code = 0;
616✔
1280

1281
  if (pRsp == NULL) {
616✔
UNCOV
1282
    mError("audit record rsp, null response message");
×
UNCOV
1283
    return -1;
×
1284
  }
1285

1286
  if (pRsp->code != 0) {
616✔
UNCOV
1287
    mError("audit record rsp failed, code:%d", pRsp->code);
×
UNCOV
1288
    return pRsp->code;
×
1289
  }
1290

1291
  SMnode *pMnode = pRsp->info.node;
616✔
1292
  SSdb   *pSdb = pMnode->pSdb;
616✔
1293
  (void)pMnode;  // currently unused, kept for potential future use
1294
  (void)pSdb;    // currently unused, kept for potential future use
1295

1296
  mDebug("audit record rsp succeeded, code:%d", pRsp->code);
616✔
1297

1298
  // no need to implement this rsp, since we do not care about the result of audit record insertion
1299

1300
  return code;
616✔
1301
}
1302

1303
int32_t mndAddStbToTrans(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
3,924,316✔
1304
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
3,924,316✔
1305
  TAOS_CHECK_RETURN(mndTransCheckConflict(pMnode, pTrans));
3,924,316✔
1306
  TAOS_CHECK_RETURN(mndSetCreateStbCommitLogs(pMnode, pTrans, pDb, pStb));
3,913,140✔
1307
  TAOS_CHECK_RETURN(mndSetCreateStbRedoActions(pMnode, pTrans, pDb, pStb));
3,913,140✔
1308
  TAOS_CHECK_RETURN(mndSetCreateStbUndoActions(pMnode, pTrans, pDb, pStb));
3,913,140✔
1309
  return 0;
3,913,140✔
1310
}
1311

1312
static int32_t mndProcessTtlTimer(SRpcMsg *pReq) {
6,391,232✔
1313
  SMnode           *pMnode = pReq->info.node;
6,391,232✔
1314
  SSdb             *pSdb = pMnode->pSdb;
6,391,232✔
1315
  SVgObj           *pVgroup = NULL;
6,391,232✔
1316
  void             *pIter = NULL;
6,391,232✔
1317
  SVDropTtlTableReq ttlReq = {
6,391,232✔
1318
      .timestampSec = taosGetTimestampSec(), .ttlDropMaxCount = tsTtlBatchDropNum, .nUids = 0, .pTbUids = NULL};
6,391,232✔
1319
  int32_t reqLen = tSerializeSVDropTtlTableReq(NULL, 0, &ttlReq);
6,391,232✔
1320
  int32_t contLen = reqLen + sizeof(SMsgHead);
6,391,232✔
1321

1322
  mDebug("start to process ttl timer");
6,391,232✔
1323

1324
  while (1) {
23,711,494✔
1325
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
30,102,726✔
1326
    if (pIter == NULL) break;
30,102,726✔
1327

1328
    if (pVgroup->mountVgId) {
23,711,494✔
1329
      sdbRelease(pSdb, pVgroup);
1,232✔
1330
      continue;
1,232✔
1331
    }
1332

1333
    int32_t   code = 0;
23,710,262✔
1334
    SMsgHead *pHead = rpcMallocCont(contLen);
23,710,262✔
1335
    if (pHead == NULL) {
23,710,262✔
UNCOV
1336
      sdbRelease(pSdb, pVgroup);
×
UNCOV
1337
      continue;
×
1338
    }
1339
    pHead->contLen = htonl(contLen);
23,710,262✔
1340
    pHead->vgId = htonl(pVgroup->vgId);
23,710,262✔
1341
    if ((code = tSerializeSVDropTtlTableReq((char *)pHead + sizeof(SMsgHead), reqLen, &ttlReq)) < 0) {
23,710,262✔
UNCOV
1342
      mError("vgId:%d, failed to serialize drop ttl table request since %s", pVgroup->vgId, tstrerror(code));
×
UNCOV
1343
      sdbRelease(pSdb, pVgroup);
×
UNCOV
1344
      continue;
×
1345
    }
1346

1347
    SRpcMsg rpcMsg = {
23,710,262✔
1348
        .msgType = TDMT_VND_FETCH_TTL_EXPIRED_TBS, .pCont = pHead, .contLen = contLen, .info = pReq->info};
1349
    SEpSet epSet = mndGetVgroupEpset(pMnode, pVgroup);
23,710,262✔
1350
    code = tmsgSendReq(&epSet, &rpcMsg);
23,710,262✔
1351
    if (code != 0) {
23,710,262✔
1352
      mError("vgId:%d, failed to send drop ttl table request to vnode since 0x%x", pVgroup->vgId, code);
98,402✔
1353
    } else {
1354
      mDebug("vgId:%d, send drop ttl table request to vnode, time:%" PRId32, pVgroup->vgId, ttlReq.timestampSec);
23,611,860✔
1355
    }
1356
    sdbRelease(pSdb, pVgroup);
23,710,262✔
1357
  }
1358

1359
  return 0;
6,391,232✔
1360
}
1361

1362
#if 0
1363
static int32_t mndProcessTrimDbTimer(SRpcMsg *pReq) {
1364
  SMnode     *pMnode = pReq->info.node;
1365
  SSdb       *pSdb = pMnode->pSdb;
1366
  SVgObj     *pVgroup = NULL;
1367
  void       *pIter = NULL;
1368
  SVTrimDbReq trimReq = {0};
1369
  trimReq.compactStartTime = taosGetTimestampMs();
1370
  trimReq.tw.skey = INT64_MIN;
1371
  trimReq.tw.ekey = trimReq.compactStartTime;
1372
  trimReq.compactId = 0;  // TODO: use the real value
1373
  trimReq.metaOnly = 0;
1374
  trimReq.triggerType = TSDB_TRIGGER_AUTO;
1375
  int32_t reqLen = tSerializeSVTrimDbReq(NULL, 0, &trimReq);
1376
  int32_t contLen = reqLen + sizeof(SMsgHead);
1377

1378
  while (1) {
1379
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
1380
    if (pIter == NULL) break;
1381
    if (pVgroup->mountVgId) {
1382
      sdbRelease(pSdb, pVgroup);
1383
      continue;
1384
    }
1385

1386
    int32_t code = 0;
1387

1388
    SMsgHead *pHead = rpcMallocCont(contLen);
1389
    if (pHead == NULL) {
1390
      sdbCancelFetch(pSdb, pVgroup);
1391
      sdbRelease(pSdb, pVgroup);
1392
      continue;
1393
    }
1394
    pHead->contLen = htonl(contLen);
1395
    pHead->vgId = htonl(pVgroup->vgId);
1396
    trimReq.dbUid = pVgroup->dbUid;
1397
    (void)snprintf(trimReq.db, sizeof(trimReq.db), "%s", pVgroup->dbName);
1398
    if ((code = tSerializeSVTrimDbReq((char *)pHead + sizeof(SMsgHead), reqLen, &trimReq)) < 0) {
1399
      mError("vgId:%d, failed to serialize trim db request since %s", pVgroup->vgId, tstrerror(code));
1400
    }
1401

1402
    SRpcMsg rpcMsg = {.msgType = TDMT_VND_TRIM, .pCont = pHead, .contLen = contLen};
1403
    SEpSet  epSet = mndGetVgroupEpset(pMnode, pVgroup);
1404
    code = tmsgSendReq(&epSet, &rpcMsg);
1405
    if (code != 0) {
1406
      mError("vgId:%d, timer failed to send vnode-trim request to vnode since 0x%x", pVgroup->vgId, code);
1407
    } else {
1408
      mInfo("vgId:%d, timer send vnode-trim request to vnode, time:%" PRIi64 " ms", pVgroup->vgId, trimReq.tw.ekey);
1409
    }
1410
    sdbRelease(pSdb, pVgroup);
1411
  }
1412

1413
  return 0;
1414
}
1415
#endif
1416

1417
static int32_t mndFindSuperTableTagIndex(const SStbObj *pStb, const char *tagName) {
7,238,732✔
1418
  for (int32_t tag = 0; tag < pStb->numOfTags; tag++) {
56,831,212✔
1419
    if (strcmp(pStb->pTags[tag].name, tagName) == 0) {
51,438,978✔
1420
      return tag;
1,846,498✔
1421
    }
1422
  }
1423

1424
  return -1;
5,392,234✔
1425
}
1426

1427
static int32_t mndFindSuperTableColumnIndex(const SStbObj *pStb, const char *colName) {
11,196,206✔
1428
  for (int32_t col = 0; col < pStb->numOfColumns; col++) {
654,570,448✔
1429
    if (strcmp(pStb->pColumns[col].name, colName) == 0) {
649,035,202✔
1430
      return col;
5,660,960✔
1431
    }
1432
  }
1433

1434
  return -1;
5,535,246✔
1435
}
1436

1437
static bool mndValidateSchema(SSchema *pSchemas, int32_t nSchema, SArray *pFields, int32_t maxLen) {
5,885,864✔
1438
  int32_t rowLen = 0;
5,885,864✔
1439
  for (int32_t i = 0; i < nSchema; ++i) {
417,644,982✔
1440
    rowLen += (pSchemas + i)->bytes;
411,759,118✔
1441
  }
1442

1443
  int32_t nField = taosArrayGetSize(pFields);
5,885,864✔
1444
  for (int32_t i = 0; i < nField; ++i) {
11,771,728✔
1445
    rowLen += ((SField *)TARRAY_GET_ELEM(pFields, i))->bytes;
5,885,864✔
1446
  }
1447

1448
  return rowLen <= maxLen;
5,885,864✔
1449
}
1450

1451
static int32_t mndBuildStbFromAlter(SStbObj *pStb, SStbObj *pDst, SMCreateStbReq *createReq) {
71,186✔
1452
  int32_t code = 0;
71,186✔
1453
  taosRLockLatch(&pStb->lock);
71,186✔
1454
  memcpy(pDst, pStb, sizeof(SStbObj));
71,186✔
1455
  taosRUnLockLatch(&pStb->lock);
71,186✔
1456

1457
  pDst->source = createReq->source;
71,186✔
1458
  pDst->updateTime = taosGetTimestampMs();
71,186✔
1459
  pDst->numOfColumns = createReq->numOfColumns;
71,186✔
1460
  pDst->numOfTags = createReq->numOfTags;
71,186✔
1461
  pDst->pColumns = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SSchema));
71,186✔
1462
  pDst->pTags = taosMemoryCalloc(1, pDst->numOfTags * sizeof(SSchema));
71,186✔
1463
  pDst->pCmpr = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SColCmpr));
71,186✔
1464
  pDst->pExtSchemas = taosMemoryCalloc(pDst->numOfColumns, sizeof(SExtSchema));
71,186✔
1465

1466
  if (pDst->pColumns == NULL || pDst->pTags == NULL || pDst->pCmpr == NULL || pDst->pExtSchemas == NULL) {
71,186✔
UNCOV
1467
    code = terrno;
×
UNCOV
1468
    TAOS_RETURN(code);
×
1469
  }
1470

1471
  if (pDst->nextColId < 0 || pDst->nextColId >= 0x7fff - pDst->numOfColumns - pDst->numOfTags) {
71,186✔
UNCOV
1472
    code = TSDB_CODE_OUT_OF_RANGE;
×
UNCOV
1473
    TAOS_RETURN(code);
×
1474
  }
1475

1476
  for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
508,712✔
1477
    SFieldWithOptions *pField = taosArrayGet(createReq->pColumns, i);
437,526✔
1478
    SSchema           *pSchema = &pDst->pColumns[i];
437,526✔
1479
    pSchema->type = pField->type;
437,526✔
1480
    pSchema->bytes = pField->bytes;
437,526✔
1481
    pSchema->flags = pField->flags;
437,526✔
1482
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
437,526✔
1483
    int32_t cIndex = mndFindSuperTableColumnIndex(pStb, pField->name);
437,526✔
1484
    if (cIndex >= 0) {
437,526✔
1485
      pSchema->colId = pStb->pColumns[cIndex].colId;
404,974✔
1486
    } else {
1487
      pSchema->colId = pDst->nextColId++;
32,552✔
1488
    }
1489
  }
1490

1491
  for (int32_t i = 0; i < pDst->numOfTags; ++i) {
483,870✔
1492
    SField  *pField = taosArrayGet(createReq->pTags, i);
412,684✔
1493
    SSchema *pSchema = &pDst->pTags[i];
412,684✔
1494
    pSchema->type = pField->type;
412,684✔
1495
    pSchema->bytes = pField->bytes;
412,684✔
1496
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
412,684✔
1497
    int32_t cIndex = mndFindSuperTableTagIndex(pStb, pField->name);
412,684✔
1498
    if (cIndex >= 0) {
412,684✔
1499
      pSchema->colId = pStb->pTags[cIndex].colId;
390,402✔
1500
    } else {
1501
      pSchema->colId = pDst->nextColId++;
22,282✔
1502
    }
1503
  }
1504
  for (int32_t i = 0; i < pDst->numOfColumns; i++) {
508,712✔
1505
    SColCmpr          *p = pDst->pCmpr + i;
437,526✔
1506
    SFieldWithOptions *pField = taosArrayGet(createReq->pColumns, i);
437,526✔
1507
    SSchema           *pSchema = &pDst->pColumns[i];
437,526✔
1508
    p->id = pSchema->colId;
437,526✔
1509
    if (pField->compress == 0) {
437,526✔
UNCOV
1510
      p->alg = createDefaultColCmprByType(pSchema->type);
×
1511
    } else {
1512
      p->alg = pField->compress;
437,526✔
1513
    }
1514
    if (pField->flags & COL_HAS_TYPE_MOD) {
437,526✔
1515
      pDst->pExtSchemas[i].typeMod = pField->typeMod;
9,472✔
1516
    }
1517
  }
1518
  pDst->tagVer = createReq->tagVer;
71,186✔
1519
  pDst->colVer = createReq->colVer;
71,186✔
1520
  return TSDB_CODE_SUCCESS;
71,186✔
1521
}
1522

1523
// used for tmq_get_json_meta to build alter msg
1524
static void buildAlterMsg(SStbObj *pStb, SStbObj *pDst, void** pAlterBuf, int32_t* len){
71,186✔
1525
  SMAlterStbReq alterReq = {0};
71,186✔
1526
  alterReq.pFields = taosArrayInit(2, sizeof(SField));
71,186✔
1527
  if (NULL == alterReq.pFields) {
71,186✔
UNCOV
1528
    mError("failed to init alter fields array");
×
UNCOV
1529
    goto END;
×
1530
  }
1531
  tstrncpy(alterReq.name, pStb->name, TSDB_TABLE_FNAME_LEN);
71,186✔
1532
  for (int32_t i = 0; i < pDst->numOfColumns && taosArrayGetSize(alterReq.pFields) == 0; ++i) {
490,576✔
1533
    SSchema           *pSchema = &pDst->pColumns[i];
419,390✔
1534
    int32_t cIndex = mndFindSuperTableColumnIndex(pStb, pSchema->name);
419,390✔
1535
    if (cIndex >= 0 && pSchema->bytes == pStb->pColumns[cIndex].bytes) {
419,390✔
1536
      continue;
379,526✔
1537
    }
1538
    if (cIndex < 0) {
39,864✔
1539
      alterReq.alterType = TSDB_ALTER_TABLE_ADD_COLUMN;
32,552✔
1540
    } else if (pSchema->bytes > pStb->pColumns[cIndex].bytes){
7,312✔
1541
      alterReq.alterType = TSDB_ALTER_TABLE_UPDATE_COLUMN_BYTES;
7,312✔
1542
    }
1543
    SField *pAlterField = taosArrayReserve(alterReq.pFields, 1);
39,864✔
1544
    pAlterField->type = pSchema->type;
39,864✔
1545
    pAlterField->bytes = pSchema->bytes;
39,864✔
1546
    tstrncpy(pAlterField->name, pSchema->name, TSDB_COL_NAME_LEN);
39,864✔
1547
    mDebug("alter column name:%s, type:%d, bytes:%d", pAlterField->name, pAlterField->type, pAlterField->bytes);
39,864✔
1548
  }
1549

1550
  for (int32_t i = 0; i < pDst->numOfTags && taosArrayGetSize(alterReq.pFields) == 0; ++i) {
295,398✔
1551
    SSchema *pSchema = &pDst->pTags[i];
224,212✔
1552
    int32_t cIndex = mndFindSuperTableTagIndex(pStb, pSchema->name);
224,212✔
1553
    if (cIndex >= 0 && pSchema->bytes == pStb->pTags[cIndex].bytes) {
224,212✔
1554
      continue;
195,258✔
1555
    }
1556
    if (cIndex < 0) {
28,954✔
1557
      alterReq.alterType = TSDB_ALTER_TABLE_ADD_TAG;
22,282✔
1558
    } else if (pSchema->bytes > pStb->pTags[cIndex].bytes){
6,672✔
1559
      alterReq.alterType = TSDB_ALTER_TABLE_UPDATE_TAG_BYTES;
6,672✔
1560
    }
1561
    SField *pAlterField = taosArrayReserve(alterReq.pFields, 1);
28,954✔
1562
    pAlterField->type = pSchema->type;
28,954✔
1563
    pAlterField->bytes = pSchema->bytes;
28,954✔
1564
    tstrncpy(pAlterField->name, pSchema->name, TSDB_COL_NAME_LEN);
28,954✔
1565
    mDebug("alter tag name:%s, type:%d, bytes:%d", pAlterField->name, pAlterField->type, pAlterField->bytes);
28,954✔
1566
  }
1567
  alterReq.numOfFields = taosArrayGetSize(alterReq.pFields);
71,186✔
1568
  if (alterReq.numOfFields == 0) {
71,186✔
1569
    mError("no valid alter field found");
2,368✔
1570
    goto END;
2,368✔
1571
  }
1572

1573
  int32_t contLen = tSerializeSMAlterStbReq(NULL, 0, &alterReq);
68,818✔
1574
  if (contLen <= 0) {
68,818✔
UNCOV
1575
    mError("failed to get alter stb req len");
×
UNCOV
1576
    goto END;
×
1577
  }
1578
  void*   buf = taosMemoryMalloc(contLen);
68,818✔
1579
  if (buf == NULL) {
68,818✔
UNCOV
1580
    mError("failed to malloc alter stb req buf");
×
UNCOV
1581
    goto END;
×
1582
  }
1583
  int32_t code = tSerializeSMAlterStbReq(buf, contLen, &alterReq);
68,818✔
1584
  if (code <= TSDB_CODE_SUCCESS) {
68,818✔
1585
    mError("failed to serialize alter stb req %d", code);
×
1586
    taosMemoryFreeClear(buf);
×
UNCOV
1587
    goto END;
×
1588
  }
1589
  *pAlterBuf = buf;
68,818✔
1590
  *len = contLen;
68,818✔
1591
END:
71,186✔
1592
  taosArrayDestroy(alterReq.pFields);
71,186✔
1593
}
71,186✔
1594

1595
static int32_t mndProcessCreateStbReq(SRpcMsg *pReq) {
3,900,810✔
1596
  SMnode        *pMnode = pReq->info.node;
3,900,810✔
1597
  int32_t        code = -1;
3,900,810✔
1598
  SStbObj       *pStb = NULL;
3,900,810✔
1599
  SDbObj        *pDb = NULL;
3,900,810✔
1600
  SUserObj      *pOperUser = NULL;
3,900,810✔
1601
  SMCreateStbReq createReq = {0};
3,900,810✔
1602
  bool           isAlter = false;
3,900,810✔
1603
  SHashObj      *pHash = NULL;
3,900,810✔
1604
  int64_t        tss = taosGetTimestampMs();
3,900,810✔
1605

1606
  if (tDeserializeSMCreateStbReq(pReq->pCont, pReq->contLen, &createReq) != 0) {
3,900,810✔
UNCOV
1607
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
1608
    goto _OVER;
×
1609
  }
1610

1611
  mInfo("stb:%s, start to create", createReq.name);
3,900,810✔
1612
  if (mndCheckCreateStbReq(&createReq) != 0) {
3,900,810✔
UNCOV
1613
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
1614
    goto _OVER;
×
1615
  }
1616

1617
  pStb = mndAcquireStb(pMnode, createReq.name);
3,900,810✔
1618
  if (pStb != NULL) {
3,900,810✔
1619
    if (createReq.igExists) {
112,574✔
1620
      if (createReq.source == TD_REQ_FROM_APP) {
109,906✔
1621
        mInfo("stb:%s, already exist, ignore exist is set", createReq.name);
7,222✔
1622
        code = 0;
7,222✔
1623
        goto _OVER;
7,222✔
1624
      } else if (pStb->uid != createReq.suid) {
102,684✔
UNCOV
1625
        mInfo("stb:%s, alter table does not need to be done, because table is deleted", createReq.name);
×
UNCOV
1626
        code = 0;
×
UNCOV
1627
        goto _OVER;
×
1628
      } else if (createReq.tagVer > 0 || createReq.colVer > 0) {
173,870✔
1629
        int32_t tagDelta = createReq.tagVer - pStb->tagVer;
102,684✔
1630
        int32_t colDelta = createReq.colVer - pStb->colVer;
102,684✔
1631
        mInfo("stb:%s, already exist while create, input tagVer:%d colVer:%d, exist tagVer:%d colVer:%d",
102,684✔
1632
              createReq.name, createReq.tagVer, createReq.colVer, pStb->tagVer, pStb->colVer);
1633
        if (tagDelta <= 0 && colDelta <= 0) {
102,684✔
1634
          mInfo("stb:%s, schema version is not incremented and nothing needs to be done", createReq.name);
31,498✔
1635
          code = 0;
31,498✔
1636
          goto _OVER;
31,498✔
1637
        } else if ((tagDelta == 1 && colDelta == 0) || (tagDelta == 0 && colDelta == 1) ||
71,186✔
UNCOV
1638
                   (pStb->colVer == 1 && createReq.colVer > 1) || (pStb->tagVer == 1 && createReq.tagVer > 1)) {
×
1639
          isAlter = true;
71,186✔
1640
          mInfo("stb:%s, schema version is only increased by 1 number, do alter operation", createReq.name);
71,186✔
1641
        } else {
UNCOV
1642
          mError("stb:%s, schema version increase more than 1 number, error is returned", createReq.name);
×
UNCOV
1643
          code = TSDB_CODE_MND_INVALID_SCHEMA_VER;
×
UNCOV
1644
          goto _OVER;
×
1645
        }
1646
      } else {
UNCOV
1647
        mError("stb:%s, already exist while create, input tagVer:%d colVer:%d is invalid, origin tagVer:%d colVer:%d",
×
1648
               createReq.name, createReq.tagVer, createReq.colVer, pStb->tagVer, pStb->colVer);
UNCOV
1649
        code = TSDB_CODE_MND_INVALID_SCHEMA_VER;
×
UNCOV
1650
        goto _OVER;
×
1651
      }
1652
    } else {
1653
      code = TSDB_CODE_MND_STB_ALREADY_EXIST;
2,668✔
1654
      goto _OVER;
2,668✔
1655
    }
1656
  } else if (terrno != TSDB_CODE_MND_STB_NOT_EXIST) {
3,788,236✔
1657
    goto _OVER;
×
1658
  } else if ((createReq.source == TD_REQ_FROM_TAOX_OLD || createReq.source == TD_REQ_FROM_TAOX || createReq.source == TD_REQ_FROM_SML) &&
3,788,236✔
1659
             (createReq.tagVer != 1 || createReq.colVer != 1)) {
32,666✔
1660
    mInfo("stb:%s, alter table does not need to be done, because table is deleted", createReq.name);
1,184✔
1661
    code = 0;
1,184✔
1662
    goto _OVER;
1,184✔
1663
  }
1664

1665
  pHash = taosHashInit(createReq.numOfColumns + createReq.numOfTags, taosGetDefaultHashFunction(TSDB_DATA_TYPE_BINARY),
3,858,238✔
1666
                       false, HASH_NO_LOCK);
1667
  if (pHash == NULL) {
3,858,238✔
UNCOV
1668
    code = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
1669
    goto _OVER;
×
1670
  }
1671

1672
  for (int32_t i = 0; i < createReq.numOfColumns; ++i) {
313,989,158✔
1673
    SFieldWithOptions *pField = taosArrayGet(createReq.pColumns, i);
310,130,920✔
1674
    if ((code = taosHashPut(pHash, pField->name, strlen(pField->name), NULL, 0)) != 0) {
310,130,920✔
UNCOV
1675
      if (code == TSDB_CODE_DUP_KEY) {
×
UNCOV
1676
        code = TSDB_CODE_TSC_DUP_COL_NAMES;
×
1677
      }
1678
      goto _OVER;
×
1679
    }
1680
  }
1681

1682
  for (int32_t i = 0; i < createReq.numOfTags; ++i) {
20,277,046✔
1683
    SField *pField = taosArrayGet(createReq.pTags, i);
16,419,000✔
1684
    if ((code = taosHashPut(pHash, pField->name, strlen(pField->name), NULL, 0)) != 0) {
16,419,000✔
1685
      if (code == TSDB_CODE_DUP_KEY) {
192✔
1686
        code = TSDB_CODE_TSC_DUP_COL_NAMES;
192✔
1687
      }
1688
      goto _OVER;
192✔
1689
    }
1690
  }
1691

1692
  pDb = mndAcquireDbByStb(pMnode, createReq.name);
3,858,046✔
1693
  if (pDb == NULL) {
3,858,046✔
UNCOV
1694
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
UNCOV
1695
    goto _OVER;
×
1696
  }
1697

1698
  if ((code = mndAcquireUser(pMnode, (RPC_MSG_USER(pReq)), &pOperUser))) {
3,858,046✔
UNCOV
1699
    goto _OVER;
×
1700
  }
1701

1702
  if ((code = mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB, pDb))) {
3,858,046✔
UNCOV
1703
    goto _OVER;
×
1704
  }
1705

1706
  if ((code =
3,858,046✔
1707
           mndCheckDbPrivilegeByNameRecF(pMnode, pOperUser, pDb->cfg.isAudit ? PRIV_AUDIT_TBL_CREATE : PRIV_TBL_CREATE,
3,858,046✔
1708
                                         pDb->cfg.isAudit ? PRIV_OBJ_CLUSTER : PRIV_OBJ_DB, pDb->name, NULL))) {
3,858,046✔
1709
    goto _OVER;
×
1710
  }
1711

1712
  if (pDb->cfg.isMount) {
3,858,046✔
1713
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
×
UNCOV
1714
    goto _OVER;
×
1715
  }
1716

1717
  int32_t numOfStbs = -1;
3,858,046✔
1718
  if ((code = mndGetNumOfStbs(pMnode, pDb->name, &numOfStbs)) != 0) {
3,858,046✔
1719
    goto _OVER;
×
1720
  }
1721

1722
  if (pDb->cfg.numOfStables == 1 && numOfStbs != 0) {
3,858,046✔
1723
    code = TSDB_CODE_MND_SINGLE_STB_MODE_DB;
×
1724
    goto _OVER;
×
1725
  }
1726

1727
  if ((code = grantCheck(TSDB_GRANT_STABLE)) < 0) {
3,858,046✔
UNCOV
1728
    goto _OVER;
×
1729
  }
1730

1731
  if (isAlter) {
3,858,046✔
1732
    bool    needRsp = false;
71,186✔
1733
    SStbObj pDst = {0};
71,186✔
1734
    if ((code = mndBuildStbFromAlter(pStb, &pDst, &createReq)) != 0) {
71,186✔
UNCOV
1735
      taosMemoryFreeClear(pDst.pTags);
×
UNCOV
1736
      taosMemoryFreeClear(pDst.pColumns);
×
UNCOV
1737
      taosMemoryFreeClear(pDst.pCmpr);
×
1738
      taosMemoryFreeClear(pDst.pExtSchemas);
×
UNCOV
1739
      goto _OVER;
×
1740
    }
1741
    void* buf = NULL;
71,186✔
1742
    int32_t contLen = 0;
71,186✔
1743
    buildAlterMsg(pStb, &pDst, &buf, &contLen);
71,186✔
1744
    code = mndAlterStbImp(pMnode, pReq, pDb, &pDst, needRsp, buf, contLen);
71,186✔
1745
    taosMemoryFree(buf);
71,186✔
1746
    taosMemoryFreeClear(pDst.pTags);
71,186✔
1747
    taosMemoryFreeClear(pDst.pColumns);
71,186✔
1748
    taosMemoryFreeClear(pDst.pCmpr);
71,186✔
1749
    taosMemoryFreeClear(pDst.pExtSchemas);
71,186✔
1750
  } else {
1751
    code = mndCreateStb(pMnode, pReq, &createReq, pDb, pOperUser);
3,786,860✔
1752
  }
1753
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
3,858,046✔
1754

1755
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
3,858,046✔
1756
    SName name = {0};
3,858,046✔
1757
    TAOS_CHECK_RETURN(tNameFromString(&name, createReq.name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
3,858,046✔
1758

1759
    int64_t tse = taosGetTimestampMs();
3,858,046✔
1760
    double  duration = (double)(tse - tss);
3,858,046✔
1761
    duration = duration / 1000;
3,858,046✔
1762
    if (createReq.sql == NULL && createReq.sqlLen == 0) {
3,859,774✔
1763
      char detail[1000] = {0};
800,802✔
1764

1765
      (void)tsnprintf(detail, sizeof(detail), "dbname:%s, stable name:%s", name.dbname, name.tname);
800,802✔
1766

1767
      auditRecord(pReq, pMnode->clusterId, "createStb", name.dbname, name.tname, detail, strlen(detail), duration, 0);
800,802✔
1768
    } else {
1769
      auditRecord(pReq, pMnode->clusterId, "createStb", name.dbname, name.tname, createReq.sql, createReq.sqlLen,
3,057,244✔
1770
                  duration, 0);
1771
    }
1772
  }
1773
_OVER:
3,895,620✔
1774
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
3,900,810✔
1775
    mError("stb:%s, failed to create since %s", createReq.name, tstrerror(code));
16,276✔
1776
  }
1777

1778
  mndReleaseStb(pMnode, pStb);
3,900,810✔
1779
  mndReleaseDb(pMnode, pDb);
3,900,810✔
1780
  mndReleaseUser(pMnode, pOperUser);
3,900,810✔
1781
  tFreeSMCreateStbReq(&createReq);
3,900,810✔
1782

1783
  if (pHash != NULL) {
3,900,810✔
1784
    taosHashCleanup(pHash);
3,858,238✔
1785
  }
1786

1787
  TAOS_RETURN(code);
3,900,810✔
1788
}
1789

1790
static int32_t mndCheckAlterStbReq(SMAlterStbReq *pAlter) {
11,363,702✔
1791
  int32_t code = 0;
11,363,702✔
1792
  if (pAlter->commentLen >= 0) return 0;
11,363,702✔
1793
  if (pAlter->ttl != 0) return 0;
28,368✔
1794
  if (pAlter->keep != -1) return 0;
28,368✔
NEW
1795
  if (pAlter->secureDelete >= 0) return 0;
×
1796

UNCOV
1797
  if (pAlter->numOfFields < 1 || pAlter->numOfFields != (int32_t)taosArrayGetSize(pAlter->pFields)) {
×
UNCOV
1798
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
1799
    TAOS_RETURN(code);
×
1800
  }
1801

UNCOV
1802
  for (int32_t i = 0; i < pAlter->numOfFields; ++i) {
×
UNCOV
1803
    SField *pField = taosArrayGet(pAlter->pFields, i);
×
UNCOV
1804
    if (pField->name[0] == 0) {
×
UNCOV
1805
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
1806
      TAOS_RETURN(code);
×
1807
    }
1808
  }
1809

1810
  TAOS_RETURN(code);
×
1811
}
1812

1813
int32_t mndAllocStbSchemas(const SStbObj *pOld, SStbObj *pNew) {
10,868,376✔
1814
  pNew->pTags = taosMemoryCalloc(pNew->numOfTags, sizeof(SSchema));
10,868,376✔
1815
  pNew->pColumns = taosMemoryCalloc(pNew->numOfColumns, sizeof(SSchema));
10,868,376✔
1816
  pNew->pCmpr = taosMemoryCalloc(pNew->numOfColumns, sizeof(SColCmpr));
10,868,376✔
1817
  if (pNew->pTags == NULL || pNew->pColumns == NULL || pNew->pCmpr == NULL) {
10,868,376✔
UNCOV
1818
    TAOS_RETURN(terrno);
×
1819
  }
1820

1821
  memcpy(pNew->pColumns, pOld->pColumns, sizeof(SSchema) * pOld->numOfColumns);
10,868,376✔
1822
  memcpy(pNew->pTags, pOld->pTags, sizeof(SSchema) * pOld->numOfTags);
10,868,376✔
1823
  memcpy(pNew->pCmpr, pOld->pCmpr, sizeof(SColCmpr) * pOld->numOfColumns);
10,868,376✔
1824
  if (pOld->pExtSchemas) {
10,868,376✔
1825
    pNew->pExtSchemas = taosMemoryCalloc(pNew->numOfColumns, sizeof(SExtSchema));
8,679,758✔
1826
    if (pNew->pExtSchemas == NULL) {
8,679,758✔
UNCOV
1827
      TAOS_RETURN(terrno);
×
1828
    }
1829
    memcpy(pNew->pExtSchemas, pOld->pExtSchemas, sizeof(SExtSchema) * pOld->numOfColumns);
8,679,758✔
1830
  }
1831

1832
  TAOS_RETURN(0);
10,868,376✔
1833
}
1834

1835
static int32_t mndUpdateTableOptions(const SStbObj *pOld, SStbObj *pNew, char *pComment, int32_t commentLen,
50,094✔
1836
                                     int32_t ttl, int64_t keep, int8_t secureDelete) {
1837
  int32_t code = 0;
50,094✔
1838
  if (commentLen > 0) {
50,094✔
1839
    pNew->commentLen = commentLen;
12,278✔
1840
    pNew->comment = taosMemoryCalloc(1, commentLen + 1);
12,278✔
1841
    if (pNew->comment == NULL) {
12,278✔
UNCOV
1842
      terrno = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
1843
      return -1;
×
1844
    }
1845
    memcpy(pNew->comment, pComment, commentLen + 1);
12,278✔
1846
  } else if (commentLen == 0) {
37,816✔
1847
    pNew->commentLen = 0;
9,448✔
1848
  } else {
1849
  }
1850

1851
  if (ttl >= 0) {
50,094✔
1852
    pNew->ttl = ttl;
50,094✔
1853
  }
1854

1855
  if (keep > 0) {
50,094✔
1856
    pNew->keep = keep;
27,188✔
1857
  }
1858

1859
  if (secureDelete >= 0) {
50,094✔
1860
    pNew->secureDelete = secureDelete;
1,180✔
1861
  }
1862

1863
  if ((code = mndAllocStbSchemas(pOld, pNew)) != 0) {
50,094✔
UNCOV
1864
    TAOS_RETURN(code);
×
1865
  }
1866
  TAOS_RETURN(code);
50,094✔
1867
}
1868

1869
static int32_t mndAddSuperTableTag(const SStbObj *pOld, SStbObj *pNew, SArray *pFields, int32_t ntags) {
572,186✔
1870
  int32_t code = 0;
572,186✔
1871
  if (pOld->numOfTags + ntags > TSDB_MAX_TAGS) {
572,186✔
UNCOV
1872
    code = TSDB_CODE_MND_TOO_MANY_TAGS;
×
UNCOV
1873
    TAOS_RETURN(code);
×
1874
  }
1875

1876
  int32_t maxColumns = pOld->virtualStb ? TSDB_MAX_COLUMNS : TSDB_MAX_COLUMNS_NON_VIRTUAL;
572,186✔
1877
  if (pOld->numOfColumns + ntags + pOld->numOfTags > maxColumns) {
572,186✔
UNCOV
1878
    code = TSDB_CODE_MND_TOO_MANY_COLUMNS;
×
1879
    TAOS_RETURN(code);
×
1880
  }
1881

1882
  if (!mndValidateSchema(pOld->pTags, pOld->numOfTags, pFields, TSDB_MAX_TAGS_LEN)) {
572,186✔
1883
    code = TSDB_CODE_PAR_INVALID_TAGS_LENGTH;
57,018✔
1884
    TAOS_RETURN(code);
57,018✔
1885
  }
1886

1887
  pNew->numOfTags = pNew->numOfTags + ntags;
515,168✔
1888
  if ((code = mndAllocStbSchemas(pOld, pNew)) != 0) {
515,168✔
UNCOV
1889
    TAOS_RETURN(code);
×
1890
  }
1891

1892
  if (pNew->nextColId < 0 || pNew->nextColId >= 0x7fff - ntags) {
515,168✔
1893
    code = TSDB_CODE_OUT_OF_RANGE;
2,240✔
1894
    TAOS_RETURN(code);
2,240✔
1895
  }
1896

1897
  for (int32_t i = 0; i < ntags; i++) {
900,350✔
1898
    SField *pField = taosArrayGet(pFields, i);
512,928✔
1899
    if (mndFindSuperTableColumnIndex(pOld, pField->name) >= 0) {
512,928✔
1900
      code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
4,206✔
1901
      TAOS_RETURN(code);
4,206✔
1902
    }
1903

1904
    if (mndFindSuperTableTagIndex(pOld, pField->name) >= 0) {
508,722✔
1905
      code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
121,300✔
1906
      TAOS_RETURN(code);
121,300✔
1907
    }
1908

1909
    SSchema *pSchema = &pNew->pTags[pOld->numOfTags + i];
387,422✔
1910
    pSchema->bytes = pField->bytes;
387,422✔
1911
    pSchema->type = pField->type;
387,422✔
1912
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
387,422✔
1913
    if (pNew->nextColId > INT16_MAX) {
387,422✔
UNCOV
1914
      code = TSDB_CODE_MND_EXCEED_MAX_COL_ID;
×
UNCOV
1915
      TAOS_RETURN(code);
×
1916
    }
1917
    pSchema->colId = pNew->nextColId;
387,422✔
1918
    pNew->nextColId++;
387,422✔
1919

1920
    mInfo("stb:%s, start to add tag %s", pNew->name, pSchema->name);
387,422✔
1921
  }
1922

1923
  pNew->tagVer++;
387,422✔
1924
  TAOS_RETURN(code);
387,422✔
1925
}
1926

1927
static int32_t mndCheckAlterColForTSma(SMnode *pMnode, const char *stbFullName, int64_t suid, col_id_t colId, bool isTag) {
5,147,914✔
1928
  int32_t code = 0;
5,147,914✔
1929
  SSdb   *pSdb = pMnode->pSdb;
5,147,914✔
1930
  void   *pIter = NULL;
5,147,914✔
UNCOV
1931
  while (1) {
×
1932
    SSmaObj *pSma = NULL;
5,147,914✔
1933
    pIter = sdbFetch(pSdb, SDB_SMA, pIter, (void **)&pSma);
5,147,914✔
1934
    if (pIter == NULL) break;
5,147,914✔
1935

1936
    mInfo("tsma:%s, check tag and column modifiable, stb:%s suid:%" PRId64 " colId:%d, sql:%s", pSma->name, stbFullName,
504✔
1937
          suid, colId, pSma->sql);
1938

1939
    if (isTag) {
504✔
1940
      code = TSDB_CODE_MND_FIELD_CONFLICT_WITH_TSMA;
504✔
1941
      mError("tsma:%s, check tag:%d conflicted", pSma->name, colId);
504✔
1942
      sdbRelease(pSdb, pSma);
504✔
1943
      sdbCancelFetch(pSdb, pIter);
504✔
1944
      TAOS_RETURN(code);
504✔
1945
    }
1946

UNCOV
1947
    SNode *pAst = NULL;
×
UNCOV
1948
    if (nodesStringToNode(pSma->ast, &pAst) != 0) {
×
UNCOV
1949
      code = TSDB_CODE_SDB_INVALID_DATA_CONTENT;
×
UNCOV
1950
      mError("tsma:%s, check tag and column modifiable, stb:%s suid:%" PRId64 " colId:%d failed since parse AST err",
×
1951
             pSma->name, stbFullName, suid, colId);
UNCOV
1952
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
1953
      TAOS_RETURN(code);
×
1954
    }
1955

UNCOV
1956
    SNodeList *pNodeList = NULL;
×
UNCOV
1957
    if ((code = nodesCollectColumns((SSelectStmt *)pAst, SQL_CLAUSE_FROM, NULL, COLLECT_COL_TYPE_ALL, &pNodeList)) !=
×
1958
        0) {
UNCOV
1959
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
1960
      TAOS_RETURN(code);
×
1961
    }
1962
    SNode *pNode = NULL;
×
1963
    FOREACH(pNode, pNodeList) {
×
1964
      SColumnNode *pCol = (SColumnNode *)pNode;
×
1965
      mInfo("tsma:%s, check colId:%d tableId:%" PRId64, pSma->name, pCol->colId, pCol->tableId);
×
1966

1967
      if ((pCol->tableId != suid) && (pSma->stbUid != suid)) {
×
1968
        mInfo("tsma:%s, check colId:%d passed", pSma->name, pCol->colId);
×
UNCOV
1969
        goto NEXT;
×
1970
      }
1971
      if ((pCol->colId) > 0 && (pCol->colId == colId)) {
×
1972
        code = TSDB_CODE_MND_FIELD_CONFLICT_WITH_TSMA;
×
UNCOV
1973
        mError("tsma:%s, check colId:%d conflicted", pSma->name, pCol->colId);
×
1974
        nodesDestroyNode(pAst);
×
1975
        nodesDestroyList(pNodeList);
×
UNCOV
1976
        sdbRelease(pSdb, pSma);
×
1977
        sdbCancelFetch(pSdb, pIter);
×
1978
        TAOS_RETURN(code);
×
1979
      }
1980
      mInfo("tsma:%s, check colId:%d passed", pSma->name, pCol->colId);
×
1981
    }
1982

1983
  NEXT:
×
1984
    sdbRelease(pSdb, pSma);
×
UNCOV
1985
    nodesDestroyNode(pAst);
×
1986
    nodesDestroyList(pNodeList);
×
1987
  }
1988
  TAOS_RETURN(code);
5,147,410✔
1989
}
1990

1991
static int32_t mndDropSuperTableTag(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const char *tagName) {
212,642✔
1992
  int32_t code = 0;
212,642✔
1993
  int32_t tag = mndFindSuperTableTagIndex(pOld, tagName);
212,642✔
1994
  if (tag < 0) {
212,642✔
1995
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
192✔
1996
    TAOS_RETURN(code);
192✔
1997
  }
1998

1999
  col_id_t colId = pOld->pTags[tag].colId;
212,450✔
2000
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, pOld->name, pOld->uid, colId, true));
212,450✔
2001

2002
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
212,198✔
2003

2004
  memmove(pNew->pTags + tag, pNew->pTags + tag + 1, sizeof(SSchema) * (pNew->numOfTags - tag - 1));
212,198✔
2005
  pNew->numOfTags--;
212,198✔
2006

2007
  pNew->tagVer++;
212,198✔
2008

2009
  // if (mndDropIndexByTag(pMnode, pOld, tagName) != 0) {
2010
  //   return -1;
2011
  // }
2012
  mInfo("stb:%s, start to drop tag %s", pNew->name, tagName);
212,198✔
2013
  TAOS_RETURN(code);
212,198✔
2014
}
2015

2016
static int32_t mndAlterStbTagName(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, SArray *pFields) {
262,456✔
2017
  int32_t code = 0;
262,456✔
2018
  if ((int32_t)taosArrayGetSize(pFields) != 2) {
262,456✔
UNCOV
2019
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
2020
    TAOS_RETURN(code);
×
2021
  }
2022

2023
  SField *pField0 = taosArrayGet(pFields, 0);
262,456✔
2024
  SField *pField1 = taosArrayGet(pFields, 1);
262,456✔
2025

2026
  const char *oldTagName = pField0->name;
262,456✔
2027
  const char *newTagName = pField1->name;
262,456✔
2028

2029
  int32_t tag = mndFindSuperTableTagIndex(pOld, oldTagName);
262,456✔
2030
  if (tag < 0) {
262,456✔
2031
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
7,048✔
2032
    TAOS_RETURN(code);
7,048✔
2033
  }
2034

2035
  col_id_t colId = pOld->pTags[tag].colId;
255,408✔
2036
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, pOld->name, pOld->uid, colId, true));
255,408✔
2037

2038
  if (mndFindSuperTableTagIndex(pOld, newTagName) >= 0) {
255,156✔
2039
    code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
12,354✔
2040
    TAOS_RETURN(code);
12,354✔
2041
  }
2042

2043
  if (mndFindSuperTableColumnIndex(pOld, newTagName) >= 0) {
242,802✔
2044
    code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
192✔
2045
    TAOS_RETURN(code);
192✔
2046
  }
2047

2048
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
242,610✔
2049

2050
  SSchema *pSchema = (SSchema *)(pNew->pTags + tag);
242,610✔
2051
  memcpy(pSchema->name, newTagName, TSDB_COL_NAME_LEN);
242,610✔
2052

2053
  pNew->tagVer++;
242,610✔
2054
  mInfo("stb:%s, start to modify tag %s to %s", pNew->name, oldTagName, newTagName);
242,610✔
2055
  TAOS_RETURN(code);
242,610✔
2056
}
2057

2058
static int32_t mndAlterStbTagBytes(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const SField *pField) {
648,640✔
2059
  int32_t code = 0;
648,640✔
2060
  int32_t tag = mndFindSuperTableTagIndex(pOld, pField->name);
648,640✔
2061
  if (tag < 0) {
648,640✔
2062
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
192✔
2063
    TAOS_RETURN(code);
192✔
2064
  }
2065

2066
  col_id_t colId = pOld->pTags[tag].colId;
648,448✔
2067
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, pOld->name, pOld->uid, colId, true));
648,448✔
2068

2069
  uint32_t nLen = 0;
648,448✔
2070
  for (int32_t i = 0; i < pOld->numOfTags; ++i) {
25,905,202✔
2071
    nLen += (pOld->pTags[i].colId == colId) ? pField->bytes : pOld->pTags[i].bytes;
25,256,754✔
2072
  }
2073

2074
  if (nLen > TSDB_MAX_TAGS_LEN) {
648,448✔
2075
    code = TSDB_CODE_PAR_INVALID_TAGS_LENGTH;
364,650✔
2076
    TAOS_RETURN(code);
364,650✔
2077
  }
2078

2079
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
283,798✔
2080

2081
  SSchema *pTag = pNew->pTags + tag;
283,798✔
2082

2083
  if (!(pTag->type == TSDB_DATA_TYPE_BINARY || pTag->type == TSDB_DATA_TYPE_VARBINARY ||
283,798✔
2084
        pTag->type == TSDB_DATA_TYPE_NCHAR || pTag->type == TSDB_DATA_TYPE_GEOMETRY)) {
272,352✔
2085
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
192✔
2086
    TAOS_RETURN(code);
192✔
2087
  }
2088

2089
  if (pField->bytes <= pTag->bytes) {
283,606✔
2090
    code = TSDB_CODE_MND_INVALID_ROW_BYTES;
89,034✔
2091
    TAOS_RETURN(code);
89,034✔
2092
  }
2093

2094
  pTag->bytes = pField->bytes;
194,572✔
2095
  pNew->tagVer++;
194,572✔
2096

2097
  mInfo("stb:%s, start to modify tag len %s to %d", pNew->name, pField->name, pField->bytes);
194,572✔
2098
  TAOS_RETURN(code);
194,572✔
2099
}
2100

2101
static int32_t mndUpdateSuperTableColumnCompress(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, SArray *pField,
186,096✔
2102
                                                 int32_t nCols) {
2103
  // if (pColCmpr == NULL || colName == NULL) return -1;
2104

2105
  if (taosArrayGetSize(pField) != nCols) return TSDB_CODE_FAILED;
186,096✔
2106
  TAOS_FIELD *p = taosArrayGet(pField, 0);
186,096✔
2107

2108
  int32_t code = 0;
186,096✔
2109
  int32_t idx = mndFindSuperTableColumnIndex(pOld, p->name);
186,096✔
2110
  if (idx == -1) {
186,096✔
UNCOV
2111
    code = TSDB_CODE_MND_COLUMN_NOT_EXIST;
×
UNCOV
2112
    TAOS_RETURN(code);
×
2113
  }
2114
  SSchema *pTarget = &pOld->pColumns[idx];
186,096✔
2115
  col_id_t colId = pTarget->colId;
186,096✔
2116

2117
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
186,096✔
2118
  code = validColCmprByType(pTarget->type, p->bytes);
186,096✔
2119
  if (code != TSDB_CODE_SUCCESS) {
186,096✔
2120
    TAOS_RETURN(code);
4,464✔
2121
  }
2122

2123
  int8_t updated = 0;
181,632✔
2124
  for (int i = 0; i < pNew->numOfColumns; i++) {
1,539,110✔
2125
    SColCmpr *pCmpr = &pNew->pCmpr[i];
1,539,110✔
2126
    if (pCmpr->id == colId) {
1,539,110✔
2127
      uint32_t dst = 0;
181,632✔
2128
      updated = tUpdateCompress(pCmpr->alg, p->bytes, TSDB_COLVAL_COMPRESS_DISABLED, TSDB_COLVAL_LEVEL_DISABLED,
181,632✔
2129
                                TSDB_COLVAL_LEVEL_MEDIUM, &dst);
2130
      if (updated > 0) pCmpr->alg = dst;
181,632✔
2131
      break;
181,632✔
2132
    }
2133
  }
2134

2135
  if (updated == 0) {
181,632✔
2136
    code = TSDB_CODE_MND_COLUMN_COMPRESS_ALREADY_EXIST;
15,848✔
2137
    TAOS_RETURN(code);
15,848✔
2138
  } else if (updated == -1) {
165,784✔
UNCOV
2139
    code = TSDB_CODE_TSC_COMPRESS_LEVEL_ERROR;
×
UNCOV
2140
    TAOS_RETURN(code);
×
2141
  }
2142

2143
  pNew->colVer++;
165,784✔
2144

2145
  TAOS_RETURN(code);
165,784✔
2146
}
2147
static int32_t mndAddSuperTableColumn(const SStbObj *pOld, SStbObj *pNew, const SMAlterStbReq* pReq, int32_t ncols,
5,313,678✔
2148
                                      int8_t withCompress) {
2149
  int32_t code = 0;
5,313,678✔
2150
  int32_t maxColumns = pOld->virtualStb ? TSDB_MAX_COLUMNS : TSDB_MAX_COLUMNS_NON_VIRTUAL;
5,313,678✔
2151
  int32_t maxBytesPerRow = pOld->virtualStb ? TSDB_MAX_BYTES_PER_ROW_VIRTUAL : TSDB_MAX_BYTES_PER_ROW;
5,313,678✔
2152
  if (pOld->numOfColumns + ncols + pOld->numOfTags > maxColumns) {
5,313,678✔
UNCOV
2153
    code = TSDB_CODE_MND_TOO_MANY_COLUMNS;
×
2154
    TAOS_RETURN(code);
×
2155
  }
2156

2157
  if ((code = grantCheck(TSDB_GRANT_TIMESERIES)) != 0) {
5,313,678✔
UNCOV
2158
    TAOS_RETURN(code);
×
2159
  }
2160

2161
  if (!mndValidateSchema(pOld->pColumns, pOld->numOfColumns, pReq->pFields, maxBytesPerRow)) {
5,313,678✔
2162
    code = TSDB_CODE_PAR_INVALID_ROW_LENGTH;
1,326✔
2163
    TAOS_RETURN(code);
1,326✔
2164
  }
2165

2166
  pNew->numOfColumns = pNew->numOfColumns + ncols;
5,312,352✔
2167

2168
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
5,312,352✔
2169

2170
  if (pNew->nextColId < 0 || pNew->nextColId >= 0x7fff - ncols) {
5,312,352✔
2171
    code = TSDB_CODE_OUT_OF_RANGE;
2,240✔
2172
    TAOS_RETURN(code);
2,240✔
2173
  }
2174

2175
  for (int32_t i = 0; i < ncols; i++) {
10,020,126✔
2176
    if (withCompress) {
5,310,112✔
2177
      SFieldWithOptions *pField = taosArrayGet(pReq->pFields, i);
508,640✔
2178
      if (mndFindSuperTableColumnIndex(pOld, pField->name) >= 0) {
508,640✔
UNCOV
2179
        code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
×
UNCOV
2180
        TAOS_RETURN(code);
×
2181
      }
2182

2183
      if (mndFindSuperTableTagIndex(pOld, pField->name) >= 0) {
508,640✔
UNCOV
2184
        code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
×
UNCOV
2185
        TAOS_RETURN(code);
×
2186
      }
2187

2188
      SSchema *pSchema = &pNew->pColumns[pOld->numOfColumns + i];
508,640✔
2189
      pSchema->bytes = pField->bytes;
508,640✔
2190
      pSchema->type = pField->type;
508,640✔
2191
      memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
508,640✔
2192
      if (pNew->nextColId > INT16_MAX) {
508,640✔
UNCOV
2193
        code = TSDB_CODE_MND_EXCEED_MAX_COL_ID;
×
2194
        TAOS_RETURN(code);
×
2195
      }
2196
      pSchema->colId = pNew->nextColId;
508,640✔
2197
      pNew->nextColId++;
508,640✔
2198

2199
      SColCmpr *pCmpr = &pNew->pCmpr[pOld->numOfColumns + i];
508,640✔
2200
      pCmpr->id = pSchema->colId;
508,640✔
2201
      pCmpr->alg = pField->compress;
508,640✔
2202
      mInfo("stb:%s, start to add column %s", pNew->name, pSchema->name);
508,640✔
2203
    } else {
2204
      SField *pField = taosArrayGet(pReq->pFields, i);
4,801,472✔
2205
      if (mndFindSuperTableColumnIndex(pOld, pField->name) >= 0) {
4,801,472✔
2206
        code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
595,892✔
2207
        TAOS_RETURN(code);
595,892✔
2208
      }
2209

2210
      if (mndFindSuperTableTagIndex(pOld, pField->name) >= 0) {
4,205,580✔
2211
        code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
4,206✔
2212
        TAOS_RETURN(code);
4,206✔
2213
      }
2214

2215
      SSchema *pSchema = &pNew->pColumns[pOld->numOfColumns + i];
4,201,374✔
2216
      pSchema->bytes = pField->bytes;
4,201,374✔
2217
      pSchema->type = pField->type;
4,201,374✔
2218
      memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
4,201,374✔
2219
      if (pNew->nextColId > INT16_MAX) {
4,201,374✔
UNCOV
2220
        code = TSDB_CODE_MND_EXCEED_MAX_COL_ID;
×
UNCOV
2221
        TAOS_RETURN(code);
×
2222
      }
2223
      pSchema->colId = pNew->nextColId;
4,201,374✔
2224
      pNew->nextColId++;
4,201,374✔
2225

2226
      SColCmpr *pCmpr = &pNew->pCmpr[pOld->numOfColumns + i];
4,201,374✔
2227
      pCmpr->id = pSchema->colId;
4,201,374✔
2228
      pCmpr->alg = createDefaultColCmprByType(pSchema->type);
4,201,374✔
2229
      mInfo("stb:%s, start to add column %s", pNew->name, pSchema->name);
4,201,374✔
2230
    }
2231
  }
2232
  // 1. old schema already has extschemas
2233
  // 2. new schema has extschemas
2234
  if (pReq->pTypeMods || pOld->pExtSchemas) {
4,710,014✔
2235
    if (!pNew->pExtSchemas) {
4,709,630✔
2236
      // all ext schemas reset to zero
2237
      pNew->pExtSchemas = taosMemoryCalloc(pNew->numOfColumns, sizeof(SExtSchema));
66,470✔
2238
      if (!pNew->pExtSchemas) TAOS_RETURN(terrno);
66,470✔
2239
    }
2240
    if (pOld->pExtSchemas) {
4,709,630✔
2241
      memcpy(pNew->pExtSchemas, pOld->pExtSchemas, pOld->numOfColumns * sizeof(SExtSchema));
4,643,160✔
2242
    }
2243
    if (taosArrayGetSize(pReq->pTypeMods) > 0) {
4,709,630✔
2244
      // copy added column ext schema
2245
      for (int32_t i = 0; i < ncols; ++i) {
9,419,260✔
2246
        pNew->pColumns[pOld->numOfColumns + i].flags |= COL_HAS_TYPE_MOD;
4,709,630✔
2247
        pNew->pExtSchemas[pOld->numOfColumns + i].typeMod = *(STypeMod *)taosArrayGet(pReq->pTypeMods, i);
4,709,630✔
2248
      }
2249
    }
2250
  }
2251

2252
  pNew->colVer++;
4,710,014✔
2253
  TAOS_RETURN(code);
4,710,014✔
2254
}
2255

2256
static int32_t mndDropSuperTableColumn(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const char *colName) {
3,079,538✔
2257
  int32_t code = 0;
3,079,538✔
2258
  int32_t col = mndFindSuperTableColumnIndex(pOld, colName);
3,079,538✔
2259
  if (col < 0) {
3,079,538✔
2260
    code = TSDB_CODE_MND_COLUMN_NOT_EXIST;
4,206✔
2261
    TAOS_RETURN(code);
4,206✔
2262
  }
2263

2264
  if (col == 0) {
3,075,332✔
2265
    code = TSDB_CODE_MND_INVALID_STB_ALTER_OPTION;
3,034✔
2266
    TAOS_RETURN(code);
3,034✔
2267
  }
2268

2269
  if (pOld->numOfColumns == 2) {
3,072,298✔
2270
    code = TSDB_CODE_PAR_INVALID_DROP_COL;
192✔
2271
    TAOS_RETURN(code);
192✔
2272
  }
2273

2274
  col_id_t colId = pOld->pColumns[col].colId;
3,072,106✔
2275
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, pOld->name, pOld->uid, colId, false));
3,072,106✔
2276

2277
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
3,072,106✔
2278

2279
  int32_t sz = pNew->numOfColumns - col - 1;
3,072,106✔
2280
  memmove(pNew->pColumns + col, pNew->pColumns + col + 1, sizeof(SSchema) * sz);
3,072,106✔
2281
  memmove(pNew->pCmpr + col, pNew->pCmpr + col + 1, sizeof(SColCmpr) * sz);
3,072,106✔
2282
  if (pOld->pExtSchemas) {
3,072,106✔
2283
    memmove(pNew->pExtSchemas + col, pNew->pExtSchemas + col + 1, sizeof(SExtSchema) * sz);
3,013,788✔
2284
  }
2285
  pNew->numOfColumns--;
3,072,106✔
2286

2287
  pNew->colVer++;
3,072,106✔
2288
  mInfo("stb:%s, start to drop col %s", pNew->name, colName);
3,072,106✔
2289
  TAOS_RETURN(code);
3,072,106✔
2290
}
2291

2292
static int32_t mndAlterStbColumnBytes(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const SField *pField) {
1,007,814✔
2293
  int32_t code = 0;
1,007,814✔
2294
  int32_t col = mndFindSuperTableColumnIndex(pOld, pField->name);
1,007,814✔
2295
  if (col < 0) {
1,007,814✔
2296
    code = TSDB_CODE_MND_COLUMN_NOT_EXIST;
384✔
2297
    TAOS_RETURN(code);
384✔
2298
  }
2299

2300
  col_id_t colId = pOld->pColumns[col].colId;
1,007,430✔
2301

2302
  uint32_t nLen = 0;
1,007,430✔
2303
  int32_t  maxBytesPerRow = pOld->virtualStb ? TSDB_MAX_BYTES_PER_ROW_VIRTUAL : TSDB_MAX_BYTES_PER_ROW;
1,007,430✔
2304
  for (int32_t i = 0; i < pOld->numOfColumns; ++i) {
77,749,100✔
2305
    nLen += (pOld->pColumns[i].colId == colId) ? pField->bytes : pOld->pColumns[i].bytes;
76,741,670✔
2306
  }
2307

2308
  if (nLen > maxBytesPerRow) {
1,007,430✔
2309
    code = TSDB_CODE_MND_INVALID_ROW_BYTES;
47,928✔
2310
    TAOS_RETURN(code);
47,928✔
2311
  }
2312

2313
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, pOld->name, pOld->uid, colId, false));
959,502✔
2314

2315
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
959,502✔
2316

2317
  SSchema *pCol = pNew->pColumns + col;
959,502✔
2318
  if (!(pCol->type == TSDB_DATA_TYPE_BINARY || pCol->type == TSDB_DATA_TYPE_VARBINARY ||
959,502✔
2319
        pCol->type == TSDB_DATA_TYPE_NCHAR || pCol->type == TSDB_DATA_TYPE_GEOMETRY)) {
935,160✔
2320
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
192✔
2321
    TAOS_RETURN(code);
192✔
2322
  }
2323

2324
  if (pField->bytes <= pCol->bytes) {
959,310✔
2325
    code = TSDB_CODE_MND_INVALID_ROW_BYTES;
360,864✔
2326
    TAOS_RETURN(code);
360,864✔
2327
  }
2328

2329
  pCol->bytes = pField->bytes;
598,446✔
2330
  pNew->colVer++;
598,446✔
2331

2332
  mInfo("stb:%s, start to modify col len %s to %d", pNew->name, pField->name, pField->bytes);
598,446✔
2333
  TAOS_RETURN(code);
598,446✔
2334
}
2335

2336
static int32_t mndSetAlterStbPrepareLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
9,412,712✔
2337
  int32_t  code = 0;
9,412,712✔
2338
  SSdbRaw *pRedoRaw = mndStbActionEncode(pStb);
9,412,712✔
2339
  if (pRedoRaw == NULL) {
9,412,712✔
UNCOV
2340
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2341
    if (terrno != 0) code = terrno;
×
UNCOV
2342
    TAOS_RETURN(code);
×
2343
  }
2344
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
9,412,712✔
UNCOV
2345
    sdbFreeRaw(pRedoRaw);
×
UNCOV
2346
    TAOS_RETURN(code);
×
2347
  }
2348
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_READY));
9,412,712✔
2349

2350
  TAOS_RETURN(code);
9,412,712✔
2351
}
2352

2353
static int32_t mndSetAlterStbCommitLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
9,412,712✔
2354
  int32_t  code = 0;
9,412,712✔
2355
  SSdbRaw *pCommitRaw = mndStbActionEncode(pStb);
9,412,712✔
2356
  if (pCommitRaw == NULL) {
9,412,712✔
2357
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2358
    if (terrno != 0) code = terrno;
×
UNCOV
2359
    TAOS_RETURN(code);
×
2360
  }
2361
  if ((code = mndTransAppendCommitlog(pTrans, pCommitRaw)) != 0) {
9,412,712✔
UNCOV
2362
    sdbFreeRaw(pCommitRaw);
×
UNCOV
2363
    TAOS_RETURN(code);
×
2364
  }
2365
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
9,412,712✔
2366

2367
  TAOS_RETURN(code);
9,412,712✔
2368
}
2369

2370
static int32_t mndSetAlterStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb, void *alterOriData,
9,412,712✔
2371
                                         int32_t alterOriDataLen) {
2372
  int32_t code = 0;
9,412,712✔
2373
  SSdb   *pSdb = pMnode->pSdb;
9,412,712✔
2374
  SVgObj *pVgroup = NULL;
9,412,712✔
2375
  void   *pIter = NULL;
9,412,712✔
2376
  int32_t contLen;
9,410,312✔
2377

2378
  while (1) {
24,588,098✔
2379
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
34,000,810✔
2380
    if (pIter == NULL) break;
34,000,810✔
2381
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
24,588,098✔
2382
      sdbRelease(pSdb, pVgroup);
11,534,898✔
2383
      continue;
11,534,898✔
2384
    }
2385

2386
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, alterOriData, alterOriDataLen);
13,053,200✔
2387
    if (pReq == NULL) {
13,053,200✔
UNCOV
2388
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
2389
      sdbRelease(pSdb, pVgroup);
×
UNCOV
2390
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2391
      if (terrno != 0) code = terrno;
×
UNCOV
2392
      TAOS_RETURN(code);
×
2393
    }
2394
    STransAction action = {0};
13,053,200✔
2395
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
13,053,200✔
2396
    action.pCont = pReq;
13,053,200✔
2397
    action.contLen = contLen;
13,053,200✔
2398
    action.msgType = TDMT_VND_ALTER_STB;
13,053,200✔
2399
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
13,053,200✔
UNCOV
2400
      taosMemoryFree(pReq);
×
UNCOV
2401
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
2402
      sdbRelease(pSdb, pVgroup);
×
2403
      TAOS_RETURN(code);
×
2404
    }
2405
    sdbRelease(pSdb, pVgroup);
13,053,200✔
2406
  }
2407

2408
  TAOS_RETURN(code);
9,412,712✔
2409
}
2410

UNCOV
2411
static int32_t mndSetAlterStbRedoActions2(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb,
×
2412
                                          void *alterOriData, int32_t alterOriDataLen) {
UNCOV
2413
  int32_t code = 0;
×
UNCOV
2414
  SSdb   *pSdb = pMnode->pSdb;
×
2415
  SVgObj *pVgroup = NULL;
×
2416
  void   *pIter = NULL;
×
2417
  int32_t contLen;
×
2418

UNCOV
2419
  while (1) {
×
UNCOV
2420
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
×
UNCOV
2421
    if (pIter == NULL) break;
×
UNCOV
2422
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
×
UNCOV
2423
      sdbRelease(pSdb, pVgroup);
×
UNCOV
2424
      continue;
×
2425
    }
2426

UNCOV
2427
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, alterOriData, alterOriDataLen);
×
2428
    if (pReq == NULL) {
×
2429
      sdbCancelFetch(pSdb, pIter);
×
2430
      sdbRelease(pSdb, pVgroup);
×
2431
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2432
      if (terrno != 0) code = terrno;
×
UNCOV
2433
      TAOS_RETURN(code);
×
2434
    }
2435
    STransAction action = {0};
×
2436
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
×
2437
    action.pCont = pReq;
×
2438
    action.contLen = contLen;
×
2439
    action.msgType = TDMT_VND_CREATE_INDEX;
×
UNCOV
2440
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
×
UNCOV
2441
      taosMemoryFree(pReq);
×
2442
      sdbCancelFetch(pSdb, pIter);
×
2443
      sdbRelease(pSdb, pVgroup);
×
2444
      TAOS_RETURN(code);
×
2445
    }
2446
    sdbRelease(pSdb, pVgroup);
×
2447
  }
2448

UNCOV
2449
  TAOS_RETURN(code);
×
2450
}
2451

2452
static int32_t mndBuildStbSchemaImp(SMnode *pMnode, SDbObj *pDb, SStbObj *pStb, const char *tbName, STableMetaRsp *pRsp, bool refByStm) {
44,203,040✔
2453
  int32_t code = 0;
44,203,040✔
2454
  taosRLockLatch(&pStb->lock);
44,203,040✔
2455

2456
  int32_t totalCols = pStb->numOfColumns + pStb->numOfTags;
44,203,040✔
2457
  pRsp->pSchemas = taosMemoryCalloc(totalCols, sizeof(SSchema));
44,203,040✔
2458
  if (pRsp->pSchemas == NULL) {
44,203,040✔
2459
    taosRUnLockLatch(&pStb->lock);
×
UNCOV
2460
    code = terrno;
×
2461
    TAOS_RETURN(code);
×
2462
  }
2463
  pRsp->pSchemaExt = taosMemoryCalloc(pStb->numOfColumns, sizeof(SSchemaExt));
44,203,040✔
2464
  if (pRsp->pSchemaExt == NULL) {
44,203,040✔
UNCOV
2465
    taosRUnLockLatch(&pStb->lock);
×
UNCOV
2466
    code = terrno;
×
UNCOV
2467
    TAOS_RETURN(code);
×
2468
  }
2469
  pRsp->numOfColRefs = 0;
44,203,040✔
2470
  pRsp->pColRefs = NULL;
44,203,040✔
2471
  tstrncpy(pRsp->dbFName, pStb->db, sizeof(pRsp->dbFName));
44,203,040✔
2472
  tstrncpy(pRsp->tbName, tbName, sizeof(pRsp->tbName));
44,203,040✔
2473
  tstrncpy(pRsp->stbName, tbName, sizeof(pRsp->stbName));
44,201,978✔
2474
  pRsp->dbId = pDb->uid;
44,200,778✔
2475
  pRsp->numOfTags = pStb->numOfTags;
44,201,240✔
2476
  pRsp->numOfColumns = pStb->numOfColumns;
44,201,240✔
2477
  pRsp->precision = pDb->cfg.precision;
44,201,240✔
2478
  pRsp->tableType = TSDB_SUPER_TABLE;
44,203,040✔
2479
  pRsp->sversion = pStb->colVer;
44,202,440✔
2480
  pRsp->tversion = pStb->tagVer;
44,202,440✔
2481
  pRsp->suid = pStb->uid;
44,202,440✔
2482
  pRsp->tuid = pStb->uid;
44,201,378✔
2483
  pRsp->virtualStb = pStb->virtualStb;
44,202,440✔
2484
  pRsp->ownerId = pStb->ownerId;
44,201,978✔
2485
  pRsp->isAudit = pDb->cfg.isAudit ? 1 : 0;
44,202,440✔
2486
  pRsp->secureDelete = pStb->secureDelete;
44,201,378✔
2487

2488
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
1,301,801,880✔
2489
    SSchema *pSchema = &pRsp->pSchemas[i];
1,257,600,502✔
2490
    SSchema *pSrcSchema = &pStb->pColumns[i];
1,257,601,102✔
2491
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
1,257,600,040✔
2492
    pSchema->type = pSrcSchema->type;
1,257,599,440✔
2493
    pSchema->flags = pSrcSchema->flags;
1,257,599,902✔
2494
    pSchema->colId = pSrcSchema->colId;
1,257,601,102✔
2495
    pSchema->bytes = pSrcSchema->bytes;
1,257,599,902✔
2496
  }
2497
  
2498
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
204,583,826✔
2499
    SSchema *pSchema = &pRsp->pSchemas[i + pStb->numOfColumns];
160,380,186✔
2500
    SSchema *pSrcSchema = &pStb->pTags[i];
160,380,786✔
2501
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
160,379,124✔
2502
    pSchema->type = pSrcSchema->type;
160,380,786✔
2503
    pSchema->flags = pSrcSchema->flags;
160,379,586✔
2504
    pSchema->colId = pSrcSchema->colId;
160,380,786✔
2505
    pSchema->bytes = pSrcSchema->bytes;
160,380,186✔
2506
  }
2507

2508
  if (refByStm) {
44,203,040✔
2509
    mndStreamUpdateTagsRefFlag(pMnode, pStb->uid, &pRsp->pSchemas[pStb->numOfColumns], pStb->numOfTags);
31,000,950✔
2510
  }
2511

2512
  for (int32_t i = 0; i < pStb->numOfColumns; i++) {
1,301,803,542✔
2513
    SColCmpr   *pCmpr = &pStb->pCmpr[i];
1,257,600,502✔
2514
    SSchemaExt *pSchEx = &pRsp->pSchemaExt[i];
1,257,600,040✔
2515
    pSchEx->colId = pCmpr->id;
1,257,601,102✔
2516
    pSchEx->compress = pCmpr->alg;
1,257,599,902✔
2517
    if (pStb->pExtSchemas) {
1,257,600,502✔
2518
      pSchEx->typeMod = pStb->pExtSchemas[i].typeMod;
616,364,942✔
2519
    }
2520
  }
2521

2522
  taosRUnLockLatch(&pStb->lock);
44,203,040✔
2523
  TAOS_RETURN(code);
44,203,040✔
2524
}
2525

2526
static int32_t mndBuildStbCfgImp(SDbObj *pDb, SStbObj *pStb, const char *tbName, STableCfgRsp *pRsp) {
56,094✔
2527
  int32_t code = 0;
56,094✔
2528
  taosRLockLatch(&pStb->lock);
56,094✔
2529

2530
  int32_t totalCols = pStb->numOfColumns + pStb->numOfTags;
56,094✔
2531
  pRsp->pSchemas = taosMemoryCalloc(totalCols, sizeof(SSchema));
56,094✔
2532
  if (pRsp->pSchemas == NULL) {
56,094✔
UNCOV
2533
    taosRUnLockLatch(&pStb->lock);
×
UNCOV
2534
    code = terrno;
×
UNCOV
2535
    TAOS_RETURN(code);
×
2536
  }
2537

2538
  tstrncpy(pRsp->dbFName, pStb->db, sizeof(pRsp->dbFName));
56,094✔
2539
  tstrncpy(pRsp->tbName, tbName, sizeof(pRsp->tbName));
56,094✔
2540
  tstrncpy(pRsp->stbName, tbName, sizeof(pRsp->stbName));
56,094✔
2541
  pRsp->numOfTags = pStb->numOfTags;
56,094✔
2542
  pRsp->numOfColumns = pStb->numOfColumns;
56,094✔
2543
  pRsp->tableType = TSDB_SUPER_TABLE;
56,094✔
2544
  pRsp->delay1 = pStb->maxdelay[0];
56,094✔
2545
  pRsp->delay2 = pStb->maxdelay[1];
56,094✔
2546
  pRsp->watermark1 = pStb->watermark[0];
56,094✔
2547
  pRsp->watermark2 = pStb->watermark[1];
56,094✔
2548
  pRsp->ttl = pStb->ttl;
56,094✔
2549
  pRsp->keep = pStb->keep;
56,094✔
2550
  pRsp->commentLen = pStb->commentLen;
56,094✔
2551
  if (pStb->commentLen > 0) {
56,094✔
UNCOV
2552
    pRsp->pComment = taosStrdup(pStb->comment);
×
2553
  }
2554

2555
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
322,204✔
2556
    SSchema *pSchema = &pRsp->pSchemas[i];
266,110✔
2557
    SSchema *pSrcSchema = &pStb->pColumns[i];
266,110✔
2558
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
266,110✔
2559
    pSchema->type = pSrcSchema->type;
266,110✔
2560
    pSchema->flags = pSrcSchema->flags;
266,110✔
2561
    pSchema->colId = pSrcSchema->colId;
266,110✔
2562
    pSchema->bytes = pSrcSchema->bytes;
266,110✔
2563
  }
2564

2565
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
167,048✔
2566
    SSchema *pSchema = &pRsp->pSchemas[i + pStb->numOfColumns];
110,954✔
2567
    SSchema *pSrcSchema = &pStb->pTags[i];
110,954✔
2568
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
110,954✔
2569
    pSchema->type = pSrcSchema->type;
110,954✔
2570
    pSchema->flags = pSrcSchema->flags;
110,954✔
2571
    pSchema->colId = pSrcSchema->colId;
110,954✔
2572
    pSchema->bytes = pSrcSchema->bytes;
110,954✔
2573
  }
2574

2575
  if (pStb->numOfFuncs > 0) {
56,094✔
UNCOV
2576
    pRsp->pFuncs = taosArrayDup(pStb->pFuncs, NULL);
×
2577
  }
2578

2579
  pRsp->pSchemaExt = taosMemoryCalloc(pStb->numOfColumns, sizeof(SSchemaExt));
56,094✔
2580
  for (int32_t i = 0; i < pStb->numOfColumns; i++) {
322,204✔
2581
    SColCmpr *pCmpr = &pStb->pCmpr[i];
266,110✔
2582

2583
    SSchemaExt *pSchExt = &pRsp->pSchemaExt[i];
266,110✔
2584
    pSchExt->colId = pCmpr->id;
266,110✔
2585
    pSchExt->compress = pCmpr->alg;
266,110✔
2586
    if (pStb->pExtSchemas) {
266,110✔
2587
      pSchExt->typeMod = pStb->pExtSchemas[i].typeMod;
51,574✔
2588
    }
2589
  }
2590
  pRsp->virtualStb = pStb->virtualStb;
56,094✔
2591
  pRsp->pColRefs = NULL;
56,094✔
2592
  pRsp->secureDelete = pStb->secureDelete;
56,094✔
2593

2594
  taosRUnLockLatch(&pStb->lock);
56,094✔
2595
  TAOS_RETURN(code);
56,094✔
2596
}
2597

2598
static int32_t mndValidateStbVersion(SMnode *pMnode, SSTableVersion *pStbVer, bool *schema, bool *sma) {
15,978,982✔
2599
  int32_t code = 0;
15,978,982✔
2600
  char    tbFName[TSDB_TABLE_FNAME_LEN] = {0};
15,978,982✔
2601
  snprintf(tbFName, sizeof(tbFName), "%s.%s", pStbVer->dbFName, pStbVer->stbName);
15,978,982✔
2602

2603
  SDbObj *pDb = mndAcquireDb(pMnode, pStbVer->dbFName);
15,978,982✔
2604
  if (pDb == NULL) {
15,978,982✔
2605
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
53,048✔
2606
    TAOS_RETURN(code);
53,048✔
2607
  }
2608

2609
  if (pDb->uid != pStbVer->dbId) {
15,925,934✔
2610
    mndReleaseDb(pMnode, pDb);
15,212✔
2611
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
15,212✔
2612
    TAOS_RETURN(code);
15,212✔
2613
  }
2614

2615
  SStbObj *pStb = mndAcquireStb(pMnode, tbFName);
15,910,722✔
2616
  if (pStb == NULL) {
15,910,722✔
2617
    mndReleaseDb(pMnode, pDb);
3,528✔
2618
    code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
3,528✔
2619
    TAOS_RETURN(code);
3,528✔
2620
  }
2621

2622
  taosRLockLatch(&pStb->lock);
15,907,194✔
2623

2624
  if (pStbVer->sversion != pStb->colVer || pStbVer->tversion != pStb->tagVer) {
15,907,194✔
2625
    *schema = true;
49,892✔
2626
  } else {
2627
    *schema = false;
15,856,084✔
2628
  }
2629

2630
  if (pStbVer->smaVer && pStbVer->smaVer != pStb->smaVer) {
15,904,912✔
UNCOV
2631
    *sma = true;
×
2632
  } else {
2633
    *sma = false;
15,906,130✔
2634
  }
2635

2636
  taosRUnLockLatch(&pStb->lock);
15,904,912✔
2637

2638
  mndReleaseDb(pMnode, pDb);
15,907,194✔
2639
  mndReleaseStb(pMnode, pStb);
15,907,194✔
2640
  return TSDB_CODE_SUCCESS;
15,907,194✔
2641
}
2642

2643
static int32_t mndBuildStbSchema(SMnode *pMnode, const char *dbFName, const char *tbName, STableMetaRsp *pRsp, bool refByStm) {
32,545,894✔
2644
  int32_t code = 0;
32,545,894✔
2645
  char    tbFName[TSDB_TABLE_FNAME_LEN] = {0};
32,545,894✔
2646
  snprintf(tbFName, sizeof(tbFName), "%s.%s", dbFName, tbName);
32,545,894✔
2647

2648
  SDbObj *pDb = mndAcquireDb(pMnode, dbFName);
32,545,894✔
2649
  if (pDb == NULL) {
32,545,894✔
UNCOV
2650
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
UNCOV
2651
    TAOS_RETURN(code);
×
2652
  }
2653

2654
  SStbObj *pStb = mndAcquireStb(pMnode, tbFName);
32,545,894✔
2655
  if (pStb == NULL) {
32,545,798✔
2656
    mndReleaseDb(pMnode, pDb);
1,494,956✔
2657
    code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
1,495,052✔
2658
    TAOS_RETURN(code);
1,495,052✔
2659
  }
2660

2661
  code = mndBuildStbSchemaImp(pMnode, pDb, pStb, tbName, pRsp, refByStm);
31,050,842✔
2662
  mndReleaseDb(pMnode, pDb);
31,050,842✔
2663
  mndReleaseStb(pMnode, pStb);
31,050,842✔
2664
  TAOS_RETURN(code);
31,050,842✔
2665
}
2666

2667
static int32_t mndBuildStbCfg(SMnode *pMnode, const char *dbFName, const char *tbName, STableCfgRsp *pRsp) {
56,094✔
2668
  int32_t code = 0;
56,094✔
2669
  char    tbFName[TSDB_TABLE_FNAME_LEN] = {0};
56,094✔
2670
  snprintf(tbFName, sizeof(tbFName), "%s.%s", dbFName, tbName);
56,094✔
2671

2672
  SDbObj *pDb = mndAcquireDb(pMnode, dbFName);
56,094✔
2673
  if (pDb == NULL) {
56,094✔
UNCOV
2674
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
UNCOV
2675
    TAOS_RETURN(code);
×
2676
  }
2677

2678
  SStbObj *pStb = mndAcquireStb(pMnode, tbFName);
56,094✔
2679
  if (pStb == NULL) {
56,094✔
UNCOV
2680
    mndReleaseDb(pMnode, pDb);
×
UNCOV
2681
    code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
×
UNCOV
2682
    TAOS_RETURN(code);
×
2683
  }
2684

2685
  code = mndBuildStbCfgImp(pDb, pStb, tbName, pRsp);
56,094✔
2686

2687
  mndReleaseDb(pMnode, pDb);
56,094✔
2688
  mndReleaseStb(pMnode, pStb);
56,094✔
2689
  TAOS_RETURN(code);
56,094✔
2690
}
2691

2692
static int32_t mndBuildSMAlterStbRsp(SDbObj *pDb, SStbObj *pObj, void **pCont, int32_t *pLen) {
9,291,432✔
2693
  int32_t       code = 0;
9,291,432✔
2694
  SEncoder      ec = {0};
9,291,432✔
2695
  uint32_t      contLen = 0;
9,291,432✔
2696
  SMAlterStbRsp alterRsp = {0};
9,291,432✔
2697
  SName         name = {0};
9,291,432✔
2698
  TAOS_CHECK_RETURN(tNameFromString(&name, pObj->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
9,291,432✔
2699

2700
  alterRsp.pMeta = taosMemoryCalloc(1, sizeof(STableMetaRsp));
9,291,432✔
2701
  if (NULL == alterRsp.pMeta) {
9,291,432✔
UNCOV
2702
    code = terrno;
×
UNCOV
2703
    TAOS_RETURN(code);
×
2704
  }
2705

2706
  code = mndBuildStbSchemaImp(NULL, pDb, pObj, name.tname, alterRsp.pMeta, false);
9,291,432✔
2707
  if (code) {
9,291,432✔
UNCOV
2708
    tFreeSMAlterStbRsp(&alterRsp);
×
UNCOV
2709
    return code;
×
2710
  }
2711

2712
  tEncodeSize(tEncodeSMAlterStbRsp, &alterRsp, contLen, code);
9,291,432✔
2713
  if (code) {
9,291,432✔
UNCOV
2714
    tFreeSMAlterStbRsp(&alterRsp);
×
UNCOV
2715
    return code;
×
2716
  }
2717

2718
  void *cont = taosMemoryMalloc(contLen);
9,291,432✔
2719
  if (NULL == cont) {
9,291,432✔
2720
    code = terrno;
×
UNCOV
2721
    tFreeSMAlterStbRsp(&alterRsp);
×
UNCOV
2722
    TAOS_RETURN(code);
×
2723
  }
2724
  tEncoderInit(&ec, cont, contLen);
9,291,432✔
2725
  code = tEncodeSMAlterStbRsp(&ec, &alterRsp);
9,291,432✔
2726
  tEncoderClear(&ec);
9,291,432✔
2727

2728
  tFreeSMAlterStbRsp(&alterRsp);
9,291,432✔
2729

2730
  if (code < 0) TAOS_RETURN(code);
9,291,432✔
2731

2732
  *pCont = cont;
9,291,432✔
2733
  *pLen = contLen;
9,291,432✔
2734

2735
  TAOS_RETURN(code);
9,291,432✔
2736
}
2737

2738
int32_t mndBuildSMCreateStbRsp(SMnode *pMnode, char *dbFName, char *stbFName, void **pCont, int32_t *pLen) {
3,863,878✔
2739
  int32_t code = -1;
3,863,878✔
2740
  SDbObj *pDb = mndAcquireDb(pMnode, dbFName);
3,863,878✔
2741
  if (NULL == pDb) {
3,863,878✔
UNCOV
2742
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2743
    if (terrno != 0) code = terrno;
×
UNCOV
2744
    TAOS_RETURN(code);
×
2745
  }
2746

2747
  SStbObj *pObj = mndAcquireStb(pMnode, stbFName);
3,863,878✔
2748
  if (NULL == pObj) {
3,863,878✔
2749
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
3,112✔
2750
    if (terrno != 0) code = terrno;
3,112✔
2751
    goto _OVER;
3,112✔
2752
  }
2753

2754
  SEncoder       ec = {0};
3,860,766✔
2755
  uint32_t       contLen = 0;
3,860,766✔
2756
  SMCreateStbRsp stbRsp = {0};
3,860,766✔
2757
  SName          name = {0};
3,860,766✔
2758
  TAOS_CHECK_GOTO(tNameFromString(&name, pObj->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE), NULL, _OVER);
3,860,766✔
2759

2760
  stbRsp.pMeta = taosMemoryCalloc(1, sizeof(STableMetaRsp));
3,860,766✔
2761
  if (NULL == stbRsp.pMeta) {
3,860,766✔
UNCOV
2762
    code = terrno;
×
UNCOV
2763
    goto _OVER;
×
2764
  }
2765

2766
  code = mndBuildStbSchemaImp(NULL, pDb, pObj, name.tname, stbRsp.pMeta, false);
3,860,766✔
2767
  if (code) {
3,860,766✔
UNCOV
2768
    tFreeSMCreateStbRsp(&stbRsp);
×
UNCOV
2769
    goto _OVER;
×
2770
  }
2771

2772
  tEncodeSize(tEncodeSMCreateStbRsp, &stbRsp, contLen, code);
3,860,766✔
2773
  if (code) {
3,860,766✔
UNCOV
2774
    tFreeSMCreateStbRsp(&stbRsp);
×
UNCOV
2775
    goto _OVER;
×
2776
  }
2777

2778
  void *cont = taosMemoryMalloc(contLen);
3,860,766✔
2779
  if (NULL == cont) {
3,860,766✔
2780
    code = terrno;
×
UNCOV
2781
    tFreeSMCreateStbRsp(&stbRsp);
×
UNCOV
2782
    goto _OVER;
×
2783
  }
2784
  tEncoderInit(&ec, cont, contLen);
3,860,766✔
2785
  TAOS_CHECK_GOTO(tEncodeSMCreateStbRsp(&ec, &stbRsp), NULL, _OVER);
3,860,766✔
2786
  tEncoderClear(&ec);
3,860,766✔
2787

2788
  tFreeSMCreateStbRsp(&stbRsp);
3,860,766✔
2789

2790
  *pCont = cont;
3,860,766✔
2791
  *pLen = contLen;
3,860,766✔
2792

2793
  code = 0;
3,860,766✔
2794

2795
_OVER:
3,863,878✔
2796
  if (pObj) {
3,863,878✔
2797
    mndReleaseStb(pMnode, pObj);
3,860,766✔
2798
  }
2799

2800
  if (pDb) {
3,863,878✔
2801
    mndReleaseDb(pMnode, pDb);
3,863,878✔
2802
  }
2803

2804
  TAOS_RETURN(code);
3,863,878✔
2805
}
2806

2807
static int32_t mndAlterStbImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
9,249,624✔
2808
                              void *alterOriData, int32_t alterOriDataLen) {
2809
  int32_t code = -1;
9,249,624✔
2810
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "alter-stb");
9,249,624✔
2811
  if (pTrans == NULL) {
9,249,624✔
UNCOV
2812
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2813
    if (terrno != 0) code = terrno;
×
UNCOV
2814
    goto _OVER;
×
2815
  }
2816

2817
  mInfo("trans:%d, used to alter stb:%s, alterOriDataLen:%d", pTrans->id, pStb->name, alterOriDataLen);
9,249,624✔
2818
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
9,249,624✔
2819
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
9,249,624✔
2820

2821
  if (needRsp) {
8,957,904✔
2822
    void   *pCont = NULL;
8,836,624✔
2823
    int32_t contLen = 0;
8,836,624✔
2824
    TAOS_CHECK_GOTO(mndBuildSMAlterStbRsp(pDb, pStb, &pCont, &contLen), NULL, _OVER);
8,836,624✔
2825
    mndTransSetRpcRsp(pTrans, pCont, contLen);
8,836,624✔
2826
  }
2827

2828
  TAOS_CHECK_GOTO(mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
8,957,904✔
2829
  TAOS_CHECK_GOTO(mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
8,957,904✔
2830
  TAOS_CHECK_GOTO(mndSetAlterStbRedoActions(pMnode, pTrans, pDb, pStb, alterOriData, alterOriDataLen), NULL, _OVER);
8,957,904✔
2831
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
8,957,904✔
2832

2833
  code = 0;
8,957,904✔
2834

2835
_OVER:
9,249,624✔
2836
  mndTransDrop(pTrans);
9,249,624✔
2837
  TAOS_RETURN(code);
9,249,624✔
2838
}
2839

2840
static int32_t mndAlterStbAndUpdateTagIdxImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
454,808✔
2841
                                             void *alterOriData, int32_t alterOriDataLen, const SMAlterStbReq *pAlter) {
2842
  int32_t code = -1;
454,808✔
2843
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "alter-stb");
454,808✔
2844
  if (pTrans == NULL) {
454,808✔
UNCOV
2845
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2846
    if (terrno != 0) code = terrno;
×
UNCOV
2847
    goto _OVER;
×
2848
  }
2849

2850
  mInfo("trans:%d, used to alter stb:%s", pTrans->id, pStb->name);
454,808✔
2851
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
454,808✔
2852

2853
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
454,808✔
2854

2855
  if (needRsp) {
454,808✔
2856
    void   *pCont = NULL;
454,808✔
2857
    int32_t contLen = 0;
454,808✔
2858
    TAOS_CHECK_GOTO(mndBuildSMAlterStbRsp(pDb, pStb, &pCont, &contLen), NULL, _OVER);
454,808✔
2859
    mndTransSetRpcRsp(pTrans, pCont, contLen);
454,808✔
2860
  }
2861

2862
  if (pAlter->alterType == TSDB_ALTER_TABLE_DROP_TAG) {
454,808✔
2863
    SIdxObj idxObj = {0};
212,198✔
2864
    SField *pField0 = taosArrayGet(pAlter->pFields, 0);
212,198✔
2865
    bool    exist = false;
212,198✔
2866
    if (mndGetIdxsByTagName(pMnode, pStb, pField0->name, &idxObj) == 0) {
212,198✔
2867
      exist = true;
9,156✔
2868
    }
2869
    TAOS_CHECK_GOTO(mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
212,198✔
2870
    TAOS_CHECK_GOTO(mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
212,198✔
2871

2872
    if (exist == true) {
212,198✔
2873
      TAOS_CHECK_GOTO(mndSetDropIdxPrepareLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
9,156✔
2874
      TAOS_CHECK_GOTO(mndSetDropIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
9,156✔
2875
    }
2876

2877
    TAOS_CHECK_GOTO(mndSetAlterStbRedoActions(pMnode, pTrans, pDb, pStb, alterOriData, alterOriDataLen), NULL, _OVER);
212,198✔
2878
    TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
212,198✔
2879

2880
  } else if (pAlter->alterType == TSDB_ALTER_TABLE_UPDATE_TAG_NAME) {
242,610✔
2881
    SIdxObj     idxObj = {0};
242,610✔
2882
    SField     *pField0 = taosArrayGet(pAlter->pFields, 0);
242,610✔
2883
    SField     *pField1 = taosArrayGet(pAlter->pFields, 1);
242,610✔
2884
    const char *oTagName = pField0->name;
242,610✔
2885
    const char *nTagName = pField1->name;
242,610✔
2886
    bool        exist = false;
242,610✔
2887

2888
    if (mndGetIdxsByTagName(pMnode, pStb, pField0->name, &idxObj) == 0) {
242,610✔
2889
      exist = true;
28,390✔
2890
    }
2891

2892
    TAOS_CHECK_GOTO(mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
242,610✔
2893
    TAOS_CHECK_GOTO(mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
242,610✔
2894

2895
    if (exist == true) {
242,610✔
2896
      memcpy(idxObj.colName, nTagName, strlen(nTagName));
28,390✔
2897
      idxObj.colName[strlen(nTagName)] = 0;
28,390✔
2898
      TAOS_CHECK_GOTO(mndSetAlterIdxPrepareLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
28,390✔
2899
      TAOS_CHECK_GOTO(mndSetAlterIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
28,390✔
2900
    }
2901

2902
    TAOS_CHECK_GOTO(mndSetAlterStbRedoActions(pMnode, pTrans, pDb, pStb, alterOriData, alterOriDataLen), NULL, _OVER);
242,610✔
2903
    TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
242,610✔
2904
  }
2905
  code = 0;
454,808✔
2906

2907
_OVER:
454,808✔
2908
  mndTransDrop(pTrans);
454,808✔
2909
  TAOS_RETURN(code);
454,808✔
2910
}
2911

2912
static int32_t mndAlterStb(SMnode *pMnode, SRpcMsg *pReq, const SMAlterStbReq *pAlter, SDbObj *pDb, SStbObj *pOld) {
11,333,144✔
2913
  bool    needRsp = true;
11,333,144✔
2914
  int32_t code = -1;
11,333,144✔
2915
  SField *pField0 = NULL;
11,333,144✔
2916

2917
  SStbObj stbObj = {0};
11,333,144✔
2918
  taosRLockLatch(&pOld->lock);
11,333,144✔
2919
  memcpy(&stbObj, pOld, sizeof(SStbObj));
11,333,144✔
2920
  taosRUnLockLatch(&pOld->lock);
11,333,144✔
2921
  stbObj.pColumns = NULL;
11,333,144✔
2922
  stbObj.pTags = NULL;
11,333,144✔
2923
  stbObj.pFuncs = NULL;
11,333,144✔
2924
  stbObj.pCmpr = NULL;
11,333,144✔
2925
  stbObj.pExtSchemas = NULL;
11,333,144✔
2926
  stbObj.updateTime = taosGetTimestampMs();
11,333,144✔
2927
  stbObj.lock = 0;
11,333,144✔
2928
  stbObj.virtualStb = pOld->virtualStb;
11,333,144✔
2929
  bool updateTagIndex = false;
11,333,144✔
2930
  switch (pAlter->alterType) {
11,333,144✔
2931
    case TSDB_ALTER_TABLE_ADD_TAG:
572,186✔
2932
      code = mndAddSuperTableTag(pOld, &stbObj, pAlter->pFields, pAlter->numOfFields);
572,186✔
2933
      break;
572,186✔
2934
    case TSDB_ALTER_TABLE_DROP_TAG:
212,642✔
2935
      pField0 = taosArrayGet(pAlter->pFields, 0);
212,642✔
2936
      code = mndDropSuperTableTag(pMnode, pOld, &stbObj, pField0->name);
212,642✔
2937
      updateTagIndex = true;
212,642✔
2938
      break;
212,642✔
2939
    case TSDB_ALTER_TABLE_UPDATE_TAG_NAME:
262,456✔
2940
      code = mndAlterStbTagName(pMnode, pOld, &stbObj, pAlter->pFields);
262,456✔
2941
      updateTagIndex = true;
262,456✔
2942
      break;
262,456✔
2943
    case TSDB_ALTER_TABLE_UPDATE_TAG_BYTES:
648,640✔
2944
      pField0 = taosArrayGet(pAlter->pFields, 0);
648,640✔
2945
      code = mndAlterStbTagBytes(pMnode, pOld, &stbObj, pField0);
648,640✔
2946
      break;
648,640✔
2947
    case TSDB_ALTER_TABLE_ADD_COLUMN:
4,805,038✔
2948
      code = mndAddSuperTableColumn(pOld, &stbObj, pAlter, pAlter->numOfFields, 0);
4,805,038✔
2949
      break;
4,805,038✔
2950
    case TSDB_ALTER_TABLE_DROP_COLUMN:
3,079,538✔
2951
      pField0 = taosArrayGet(pAlter->pFields, 0);
3,079,538✔
2952
      code = mndDropSuperTableColumn(pMnode, pOld, &stbObj, pField0->name);
3,079,538✔
2953
      break;
3,079,538✔
2954
    case TSDB_ALTER_TABLE_UPDATE_COLUMN_BYTES:
1,007,814✔
2955
      pField0 = taosArrayGet(pAlter->pFields, 0);
1,007,814✔
2956
      code = mndAlterStbColumnBytes(pMnode, pOld, &stbObj, pField0);
1,007,814✔
2957
      break;
1,007,814✔
2958
    case TSDB_ALTER_TABLE_UPDATE_OPTIONS:
50,094✔
2959
      needRsp = false;
50,094✔
2960
      code = mndUpdateTableOptions(pOld, &stbObj, pAlter->comment, pAlter->commentLen, pAlter->ttl, pAlter->keep,
50,094✔
2961
                                   pAlter->secureDelete);
50,094✔
2962
      break;
50,094✔
2963
    case TSDB_ALTER_TABLE_UPDATE_COLUMN_COMPRESS:
186,096✔
2964
      code = mndUpdateSuperTableColumnCompress(pMnode, pOld, &stbObj, pAlter->pFields, pAlter->numOfFields);
186,096✔
2965
      break;
186,096✔
2966
    case TSDB_ALTER_TABLE_ADD_COLUMN_WITH_COMPRESS_OPTION:
508,640✔
2967
      code = mndAddSuperTableColumn(pOld, &stbObj, pAlter, pAlter->numOfFields, 1);
508,640✔
2968
      break;
508,640✔
UNCOV
2969
    default:
×
UNCOV
2970
      needRsp = false;
×
UNCOV
2971
      terrno = TSDB_CODE_OPS_NOT_SUPPORT;
×
UNCOV
2972
      break;
×
2973
  }
2974

2975
  if (code != 0) goto _OVER;
11,333,144✔
2976
  if (updateTagIndex == false) {
9,633,246✔
2977
    code = mndAlterStbImp(pMnode, pReq, pDb, &stbObj, needRsp, pReq->pCont, pReq->contLen);
9,178,438✔
2978
  } else {
2979
    code = mndAlterStbAndUpdateTagIdxImp(pMnode, pReq, pDb, &stbObj, needRsp, pReq->pCont, pReq->contLen, pAlter);
454,808✔
2980
  }
2981

2982
_OVER:
11,333,144✔
2983
  taosMemoryFreeClear(stbObj.pTags);
11,333,144✔
2984
  taosMemoryFreeClear(stbObj.pColumns);
11,333,144✔
2985
  taosMemoryFreeClear(stbObj.pCmpr);
11,333,144✔
2986
  if (pAlter->commentLen > 0) {
11,333,144✔
2987
    taosMemoryFreeClear(stbObj.comment);
12,278✔
2988
  }
2989
  taosMemoryFreeClear(stbObj.pExtSchemas);
11,333,144✔
2990
  TAOS_RETURN(code);
11,333,144✔
2991
}
2992

2993
static int32_t mndProcessAlterStbReq(SRpcMsg *pReq) {
11,363,702✔
2994
  SMnode       *pMnode = pReq->info.node;
11,363,702✔
2995
  int32_t       code = -1;
11,363,702✔
2996
  SDbObj       *pDb = NULL;
11,363,702✔
2997
  SStbObj      *pStb = NULL;
11,363,702✔
2998
  SUserObj     *pOperUser = NULL;
11,363,702✔
2999
  SMAlterStbReq alterReq = {0};
11,363,702✔
3000
  int64_t       tss = taosGetTimestampMs();
11,363,702✔
3001

3002
  if (tDeserializeSMAlterStbReq(pReq->pCont, pReq->contLen, &alterReq) != 0) {
11,363,702✔
UNCOV
3003
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
3004
    goto _OVER;
×
3005
  }
3006

3007
  mInfo("stb:%s, start to alter", alterReq.name);
11,363,702✔
3008
  if (mndCheckAlterStbReq(&alterReq) != 0) goto _OVER;
11,363,702✔
3009

3010
  pDb = mndAcquireDbByStb(pMnode, alterReq.name);
11,363,702✔
3011
  if (pDb == NULL) {
11,363,702✔
3012
    code = TSDB_CODE_MND_DB_NOT_EXIST;
384✔
3013
    goto _OVER;
384✔
3014
  }
3015
  if (pDb->cfg.isMount) {
11,363,318✔
3016
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
618✔
3017
    goto _OVER;
618✔
3018
  }
3019

3020
  pStb = mndAcquireStb(pMnode, alterReq.name);
11,362,700✔
3021
  if (pStb == NULL) {
11,362,700✔
3022
    code = TSDB_CODE_MND_STB_NOT_EXIST;
29,556✔
3023
    goto _OVER;
29,556✔
3024
  }
3025

3026
  SName   name = {0};
11,333,144✔
3027
  int32_t ret = 0;
11,333,144✔
3028
  if ((ret = tNameFromString(&name, alterReq.name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0)
11,333,144✔
UNCOV
3029
    mError("stb:%s, failed to tNameFromString since %s", alterReq.name, tstrerror(ret));
×
3030

3031
  // if ((code = mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), MND_OPER_WRITE_DB, pDb)) != 0) {
3032
  //   goto _OVER;
3033
  // }
3034
  TAOS_CHECK_GOTO(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser), NULL, _OVER);
11,333,144✔
3035
  TAOS_CHECK_GOTO(mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB, pDb), NULL,
11,333,144✔
3036
                  _OVER);
3037
  TAOS_CHECK_GOTO(mndCheckDbPrivilegeByNameRecF(pMnode, pOperUser, PRIV_CM_ALTER, PRIV_OBJ_TBL, pDb->name, name.tname),
11,333,144✔
3038
                  NULL, _OVER);
3039

3040
  code = mndAlterStb(pMnode, pReq, &alterReq, pDb, pStb);
11,333,144✔
3041
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
11,333,144✔
3042

3043
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
11,333,144✔
3044
    int64_t tse = taosGetTimestampMs();
11,333,144✔
3045
    double  duration = (double)(tse - tss);
11,333,144✔
3046
    duration = duration / 1000;
11,333,144✔
3047
    auditRecord(pReq, pMnode->clusterId, "alterStb", name.dbname, name.tname, alterReq.sql, alterReq.sqlLen, duration,
11,333,144✔
3048
                0);
3049
  }
3050
_OVER:
11,356,502✔
3051
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
11,363,702✔
3052
    mError("stb:%s, failed to alter since %s", alterReq.name, tstrerror(code));
2,022,176✔
3053
  }
3054

3055
  mndReleaseStb(pMnode, pStb);
11,363,702✔
3056
  mndReleaseDb(pMnode, pDb);
11,363,702✔
3057
  mndReleaseUser(pMnode, pOperUser);
11,363,702✔
3058
  tFreeSMAltertbReq(&alterReq);
11,363,702✔
3059

3060
  TAOS_RETURN(code);
11,363,702✔
3061
}
3062

3063
static int32_t mndSetDropStbPrepareLogs(SMnode *pMnode, STrans *pTrans, SStbObj *pStb) {
945,238✔
3064
  int32_t  code = 0;
945,238✔
3065
  SSdbRaw *pRedoRaw = mndStbActionEncode(pStb);
945,238✔
3066
  if (pRedoRaw == NULL) {
945,238✔
UNCOV
3067
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
3068
    if (terrno != 0) code = terrno;
×
UNCOV
3069
    TAOS_RETURN(code);
×
3070
  }
3071
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
945,238✔
UNCOV
3072
    sdbFreeRaw(pRedoRaw);
×
UNCOV
3073
    TAOS_RETURN(code);
×
3074
  }
3075
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_DROPPING));
945,238✔
3076

3077
  TAOS_RETURN(code);
945,238✔
3078
}
3079

3080
static int32_t mndSetDropStbCommitLogs(SMnode *pMnode, STrans *pTrans, SStbObj *pStb) {
945,238✔
3081
  int32_t  code = 0;
945,238✔
3082
  SSdbRaw *pCommitRaw = mndStbActionEncode(pStb);
945,238✔
3083
  if (pCommitRaw == NULL) {
945,238✔
UNCOV
3084
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
3085
    if (terrno != 0) code = terrno;
×
3086
    TAOS_RETURN(code);
×
3087
  }
3088
  if (mndTransAppendCommitlog(pTrans, pCommitRaw) != 0) {
945,238✔
UNCOV
3089
    sdbFreeRaw(pCommitRaw);
×
3090
    TAOS_RETURN(code);
×
3091
  }
3092
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_DROPPED));
945,238✔
3093

3094
  TAOS_RETURN(code);
945,238✔
3095
}
3096

3097
static int32_t mndSetDropStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
945,238✔
3098
  int32_t code = 0;
945,238✔
3099
  SSdb   *pSdb = pMnode->pSdb;
945,238✔
3100
  SVgObj *pVgroup = NULL;
945,238✔
3101
  void   *pIter = NULL;
945,238✔
3102

3103
  while (1) {
2,578,574✔
3104
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
3,523,812✔
3105
    if (pIter == NULL) break;
3,523,812✔
3106
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
2,578,574✔
3107
      sdbRelease(pSdb, pVgroup);
693,472✔
3108
      continue;
693,472✔
3109
    }
3110

3111
    int32_t contLen = 0;
1,885,102✔
3112
    void   *pReq = mndBuildVDropStbReq(pMnode, pVgroup, pStb, &contLen);
1,885,102✔
3113
    if (pReq == NULL) {
1,885,102✔
UNCOV
3114
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
3115
      sdbRelease(pSdb, pVgroup);
×
UNCOV
3116
      code = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
3117
      TAOS_RETURN(code);
×
3118
    }
3119

3120
    STransAction action = {0};
1,885,102✔
3121
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
1,885,102✔
3122
    action.pCont = pReq;
1,885,102✔
3123
    action.contLen = contLen;
1,885,102✔
3124
    action.msgType = TDMT_VND_DROP_STB;
1,885,102✔
3125
    action.acceptableCode = TSDB_CODE_TDB_STB_NOT_EXIST;
1,885,102✔
3126
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
1,885,102✔
UNCOV
3127
      taosMemoryFree(pReq);
×
UNCOV
3128
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
3129
      sdbRelease(pSdb, pVgroup);
×
UNCOV
3130
      TAOS_RETURN(code);
×
3131
    }
3132
    sdbRelease(pSdb, pVgroup);
1,885,102✔
3133
  }
3134

3135
  TAOS_RETURN(code);
945,238✔
3136
}
3137

3138
static int32_t mndDropStb(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb) {
945,238✔
3139
  int32_t code = -1;
945,238✔
3140
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "drop-stb");
945,238✔
3141
  if (pTrans == NULL) {
945,238✔
UNCOV
3142
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
3143
    if (terrno != 0) code = terrno;
×
UNCOV
3144
    goto _OVER;
×
3145
  }
3146

3147
  mInfo("trans:%d, used to drop stb:%s", pTrans->id, pStb->name);
945,238✔
3148
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
945,238✔
3149
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
945,238✔
3150

3151
  TAOS_CHECK_GOTO(mndSetDropStbPrepareLogs(pMnode, pTrans, pStb), NULL, _OVER);
945,238✔
3152
  TAOS_CHECK_GOTO(mndSetDropStbCommitLogs(pMnode, pTrans, pStb), NULL, _OVER);
945,238✔
3153
  TAOS_CHECK_GOTO(mndSetDropStbRedoActions(pMnode, pTrans, pDb, pStb), NULL, _OVER);
945,238✔
3154
  TAOS_CHECK_GOTO(mndDropIdxsByStb(pMnode, pTrans, pDb, pStb), NULL, _OVER);
945,238✔
3155
  TAOS_CHECK_GOTO(mndDropRsmaByStb(pMnode, pTrans, pDb, pStb), NULL, _OVER);
945,238✔
3156
  TAOS_CHECK_GOTO(mndUserRemoveStb(pMnode, pTrans, pStb->name), NULL, _OVER);
945,238✔
3157
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
945,238✔
3158
  code = 0;
945,238✔
3159

3160
_OVER:
945,238✔
3161
  mndTransDrop(pTrans);
945,238✔
3162
  TAOS_RETURN(code);
945,238✔
3163
}
3164

3165
static int32_t mndCheckDropStbForTopic(SMnode *pMnode, const char *stbFullName, int64_t suid) {
945,856✔
3166
  int32_t code = 0;
945,856✔
3167
  SSdb   *pSdb = pMnode->pSdb;
945,856✔
3168
  void   *pIter = NULL;
945,856✔
3169
  while (1) {
48,390✔
3170
    SMqTopicObj *pTopic = NULL;
994,246✔
3171
    pIter = sdbFetch(pSdb, SDB_TOPIC, pIter, (void **)&pTopic);
994,246✔
3172
    if (pIter == NULL) break;
994,246✔
3173

3174
    if (pTopic->stbUid == suid) {
48,390✔
UNCOV
3175
      sdbRelease(pSdb, pTopic);
×
UNCOV
3176
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
3177
      TAOS_RETURN(TSDB_CODE_MND_TOPIC_MUST_BE_DELETED);
×
3178
    }
3179
    sdbRelease(pSdb, pTopic);
48,390✔
3180
  }
3181
  TAOS_RETURN(code);
945,856✔
3182
}
3183

UNCOV
3184
static int32_t mndCheckDropStbForStream(SMnode *pMnode, const char *stbFullName, int64_t suid) {
×
UNCOV
3185
  int32_t code = 0;
×
UNCOV
3186
  SSdb   *pSdb = pMnode->pSdb;
×
UNCOV
3187
  void   *pIter = NULL;
×
UNCOV
3188
  while (1) {
×
UNCOV
3189
    SStreamObj *pStream = NULL;
×
UNCOV
3190
    pIter = sdbFetch(pSdb, SDB_STREAM, pIter, (void **)&pStream);
×
UNCOV
3191
    if (pIter == NULL) break;
×
3192

3193
    if (pStream->pCreate->outStbUid == suid) {
×
3194
      sdbCancelFetch(pSdb, pIter);
×
3195
      sdbRelease(pSdb, pStream);
×
UNCOV
3196
      TAOS_RETURN(-1);
×
3197
    }
3198

UNCOV
3199
    sdbRelease(pSdb, pStream);
×
3200
  }
UNCOV
3201
  TAOS_RETURN(code);
×
3202
}
3203

3204
static int32_t mndProcessDropTtltbRsp(SRpcMsg *pRsp) { return 0; }
×
3205
static int32_t mndProcessTrimDbRsp(SRpcMsg *pRsp) { return 0; }
×
3206
static int32_t mndProcessTrimDbWalRsp(SRpcMsg *pRsp) { return 0; }
4,560✔
3207
static int32_t mndProcessS3MigrateDbRsp(SRpcMsg *pRsp) { return 0; }
×
3208

3209
static int32_t mndProcessDropStbReq(SRpcMsg *pReq) {
1,717,362✔
3210
  SMnode      *pMnode = pReq->info.node;
1,717,362✔
3211
  int32_t      code = -1;
1,717,362✔
3212
  SDbObj      *pDb = NULL;
1,717,362✔
3213
  SStbObj     *pStb = NULL;
1,717,362✔
3214
  SUserObj    *pOperUser = NULL;
1,717,362✔
3215
  SMDropStbReq dropReq = {0};
1,717,362✔
3216
  int64_t      tss = taosGetTimestampMs();
1,717,362✔
3217

3218
  TAOS_CHECK_GOTO(tDeserializeSMDropStbReq(pReq->pCont, pReq->contLen, &dropReq), NULL, _OVER);
1,717,362✔
3219

3220
  mInfo("stb:%s, start to drop", dropReq.name);
1,717,362✔
3221

3222
  pStb = mndAcquireStb(pMnode, dropReq.name);
1,717,362✔
3223
  if (pStb == NULL) {
1,717,362✔
3224
    if (dropReq.igNotExists) {
771,506✔
3225
      mInfo("stb:%s, not exist, ignore not exist is set", dropReq.name);
769,444✔
3226
      code = 0;
769,444✔
3227
      goto _OVER;
769,444✔
3228
    } else {
3229
      code = TSDB_CODE_MND_STB_NOT_EXIST;
2,062✔
3230
      goto _OVER;
2,062✔
3231
    }
3232
  }
3233

3234
  if ((dropReq.source == TD_REQ_FROM_TAOX_OLD || dropReq.source == TD_REQ_FROM_TAOX) && pStb->uid != dropReq.suid) {
945,856✔
UNCOV
3235
    code = 0;
×
UNCOV
3236
    goto _OVER;
×
3237
  }
3238

3239
  pDb = mndAcquireDbByStb(pMnode, dropReq.name);
945,856✔
3240
  if (pDb == NULL) {
945,856✔
UNCOV
3241
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
UNCOV
3242
    goto _OVER;
×
3243
  }
3244

3245
  SName   name = {0};
945,856✔
3246
  int32_t ret = 0;
945,856✔
3247
  if ((ret = tNameFromString(&name, dropReq.name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0)
945,856✔
UNCOV
3248
    mError("stb:%s, failed to tNameFromString since %s", dropReq.name, tstrerror(ret));
×
3249

3250
  // if ((code = mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), MND_OPER_WRITE_DB, pDb)) != 0) {
3251
  //   goto _OVER;
3252
  // }
3253
  TAOS_CHECK_GOTO(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser), NULL, _OVER);
945,856✔
3254
  TAOS_CHECK_GOTO(mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB, pDb), NULL,
945,856✔
3255
                  _OVER);
3256
  TAOS_CHECK_GOTO(
945,856✔
3257
      mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_DROP, PRIV_OBJ_TBL, pStb->ownerId, pDb->name, name.tname),
3258
      NULL, _OVER);
3259
  if ((code = mndCheckDropStbForTopic(pMnode, dropReq.name, pStb->uid)) != 0) {
945,856✔
3260
    goto _OVER;
×
3261
  }
3262

3263
  if (pDb->cfg.isMount) {
945,856✔
3264
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
618✔
3265
    goto _OVER;
618✔
3266
  }
3267

3268
  code = mndDropStb(pMnode, pReq, pDb, pStb);
945,238✔
3269
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
945,238✔
3270

3271
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
945,238✔
3272
    int64_t tse = taosGetTimestampMs();
945,238✔
3273
    double  duration = (double)(tse - tss);
945,238✔
3274
    duration = duration / 1000;
945,238✔
3275
    auditRecord(pReq, pMnode->clusterId, "dropStb", name.dbname, name.tname, dropReq.sql, dropReq.sqlLen, duration, 0);
945,238✔
3276
  }
3277
_OVER:
1,716,570✔
3278
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
1,717,362✔
3279
    mError("stb:%s, failed to drop since %s", dropReq.name, tstrerror(code));
2,680✔
3280
  }
3281

3282
  mndReleaseDb(pMnode, pDb);
1,717,362✔
3283
  mndReleaseStb(pMnode, pStb);
1,717,362✔
3284
  mndReleaseUser(pMnode, pOperUser);
1,717,362✔
3285
  tFreeSMDropStbReq(&dropReq);
1,717,362✔
3286
  TAOS_RETURN(code);
1,717,362✔
3287
}
3288

3289
static int32_t mndProcessTableMetaReq(SRpcMsg *pReq) {
36,612,420✔
3290
  SMnode       *pMnode = pReq->info.node;
36,612,420✔
3291
  int32_t       code = -1;
36,612,420✔
3292
  STableInfoReq infoReq = {0};
36,612,420✔
3293
  STableMetaRsp metaRsp = {0};
36,612,420✔
3294
  SUserObj     *pUser = NULL;
36,612,420✔
3295

3296
  code = mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pUser);
36,612,420✔
3297
  if (pUser == NULL) return 0;
36,612,420✔
3298
  bool sysinfo = pUser->sysInfo;
36,612,420✔
3299

3300
  TAOS_CHECK_GOTO(tDeserializeSTableInfoReq(pReq->pCont, pReq->contLen, &infoReq), NULL, _OVER);
36,612,420✔
3301

3302
  if (0 == strcmp(infoReq.dbFName, TSDB_INFORMATION_SCHEMA_DB)) {
36,612,420✔
3303
    mInfo("information_schema table:%s.%s, start to retrieve meta", infoReq.dbFName, infoReq.tbName);
3,827,726✔
3304
    TAOS_CHECK_GOTO(mndBuildInsTableSchema(pMnode, infoReq.dbFName, infoReq.tbName, sysinfo, &metaRsp), NULL, _OVER);
3,827,726✔
3305
  } else if (0 == strcmp(infoReq.dbFName, TSDB_PERFORMANCE_SCHEMA_DB)) {
32,784,694✔
3306
    mInfo("performance_schema table:%s.%s, start to retrieve meta", infoReq.dbFName, infoReq.tbName);
288,692✔
3307
    TAOS_CHECK_GOTO(mndBuildPerfsTableSchema(pMnode, infoReq.dbFName, infoReq.tbName, &metaRsp), NULL, _OVER);
288,692✔
3308
  } else {
3309
    mInfo("stb:%s.%s, start to retrieve meta", infoReq.dbFName, infoReq.tbName);
32,496,002✔
3310
    TAOS_CHECK_GOTO(mndBuildStbSchema(pMnode, infoReq.dbFName, infoReq.tbName, &metaRsp, true), NULL, _OVER);
32,496,002✔
3311
  }
3312

3313
  int32_t rspLen = tSerializeSTableMetaRsp(NULL, 0, &metaRsp);
34,763,560✔
3314
  if (rspLen < 0) {
34,762,960✔
UNCOV
3315
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
3316
    goto _OVER;
×
3317
  }
3318

3319
  void *pRsp = rpcMallocCont(rspLen);
34,762,960✔
3320
  if (pRsp == NULL) {
34,762,960✔
UNCOV
3321
    code = terrno;
×
UNCOV
3322
    goto _OVER;
×
3323
  }
3324

3325
  if ((rspLen = tSerializeSTableMetaRsp(pRsp, rspLen, &metaRsp)) < 0) {
34,762,960✔
UNCOV
3326
    code = rspLen;
×
UNCOV
3327
    goto _OVER;
×
3328
  }
3329
  pReq->info.rsp = pRsp;
34,762,960✔
3330
  pReq->info.rspLen = rspLen;
34,762,960✔
3331
  code = 0;
34,762,960✔
3332

3333
  mTrace("%s.%s, meta is retrieved", infoReq.dbFName, infoReq.tbName);
34,762,960✔
3334

3335
_OVER:
36,611,628✔
3336
  if (code != 0) {
36,612,420✔
3337
    mError("stb:%s.%s, failed to retrieve meta since %s", infoReq.dbFName, infoReq.tbName, tstrerror(code));
1,848,860✔
3338
  }
3339

3340
  mndReleaseUser(pMnode, pUser);
36,612,420✔
3341
  tFreeSTableMetaRsp(&metaRsp);
36,612,420✔
3342
  // TODO change to TAOS_RETURN
3343
  return code;
36,611,820✔
3344
}
3345

3346
static int32_t mndProcessTableCfgReq(SRpcMsg *pReq) {
67,134✔
3347
  SMnode      *pMnode = pReq->info.node;
67,134✔
3348
  int32_t      code = -1;
67,134✔
3349
  STableCfgReq cfgReq = {0};
67,134✔
3350
  STableCfgRsp cfgRsp = {0};
67,134✔
3351

3352
  TAOS_CHECK_GOTO(tDeserializeSTableCfgReq(pReq->pCont, pReq->contLen, &cfgReq), NULL, _OVER);
67,134✔
3353

3354
  char dbName[TSDB_DB_NAME_LEN] = {0};
67,134✔
3355
  TAOS_CHECK_GOTO(mndExtractShortDbNameFromDbFullName(cfgReq.dbFName, dbName), NULL, _OVER);
67,134✔
3356
  if (0 == strcmp(dbName, TSDB_INFORMATION_SCHEMA_DB)) {
67,134✔
3357
    mInfo("information_schema table:%s.%s, start to retrieve cfg", cfgReq.dbFName, cfgReq.tbName);
7,360✔
3358
    TAOS_CHECK_GOTO(mndBuildInsTableCfg(pMnode, cfgReq.dbFName, cfgReq.tbName, &cfgRsp), NULL, _OVER);
7,360✔
3359
  } else if (0 == strcmp(dbName, TSDB_PERFORMANCE_SCHEMA_DB)) {
59,774✔
3360
    mInfo("performance_schema table:%s.%s, start to retrieve cfg", cfgReq.dbFName, cfgReq.tbName);
3,680✔
3361
    TAOS_CHECK_GOTO(mndBuildPerfsTableCfg(pMnode, cfgReq.dbFName, cfgReq.tbName, &cfgRsp), NULL, _OVER);
3,680✔
3362
  } else {
3363
    mInfo("stb:%s.%s, start to retrieve cfg", cfgReq.dbFName, cfgReq.tbName);
56,094✔
3364
    TAOS_CHECK_GOTO(mndBuildStbCfg(pMnode, cfgReq.dbFName, cfgReq.tbName, &cfgRsp), NULL, _OVER);
56,094✔
3365
  }
3366

3367
  int32_t rspLen = tSerializeSTableCfgRsp(NULL, 0, &cfgRsp);
67,134✔
3368
  if (rspLen < 0) {
67,134✔
UNCOV
3369
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
3370
    goto _OVER;
×
3371
  }
3372

3373
  void *pRsp = rpcMallocCont(rspLen);
67,134✔
3374
  if (pRsp == NULL) {
67,134✔
UNCOV
3375
    code = terrno;
×
UNCOV
3376
    goto _OVER;
×
3377
  }
3378

3379
  if ((rspLen = tSerializeSTableCfgRsp(pRsp, rspLen, &cfgRsp)) < 0) {
67,134✔
UNCOV
3380
    code = rspLen;
×
UNCOV
3381
    goto _OVER;
×
3382
  }
3383
  pReq->info.rsp = pRsp;
67,134✔
3384
  pReq->info.rspLen = rspLen;
67,134✔
3385
  code = 0;
67,134✔
3386

3387
  mTrace("%s.%s, cfg is retrieved", cfgReq.dbFName, cfgReq.tbName);
67,134✔
3388

3389
_OVER:
67,134✔
3390
  if (code != 0) {
67,134✔
UNCOV
3391
    mError("stb:%s.%s, failed to retrieve cfg since %s", cfgReq.dbFName, cfgReq.tbName, tstrerror(code));
×
3392
  }
3393

3394
  tFreeSTableCfgRsp(&cfgRsp);
67,134✔
3395
  TAOS_RETURN(code);
67,134✔
3396
}
3397

3398
int32_t mndValidateStbInfo(SMnode *pMnode, SSTableVersion *pStbVersions, int32_t numOfStbs, void **ppRsp,
11,529,010✔
3399
                           int32_t *pRspLen) {
3400
  int32_t   code = 0;
11,529,010✔
3401
  SSTbHbRsp hbRsp = {0};
11,529,010✔
3402
  hbRsp.pMetaRsp = taosArrayInit(numOfStbs, sizeof(STableMetaRsp));
11,529,010✔
3403
  if (hbRsp.pMetaRsp == NULL) {
11,529,010✔
UNCOV
3404
    code = terrno;
×
UNCOV
3405
    TAOS_RETURN(code);
×
3406
  }
3407

3408
  hbRsp.pIndexRsp = taosArrayInit(numOfStbs, sizeof(STableIndexRsp));
11,529,010✔
3409
  if (NULL == hbRsp.pIndexRsp) {
11,529,010✔
UNCOV
3410
    taosArrayDestroy(hbRsp.pMetaRsp);
×
UNCOV
3411
    code = terrno;
×
UNCOV
3412
    TAOS_RETURN(code);
×
3413
  }
3414

3415
  for (int32_t i = 0; i < numOfStbs; ++i) {
27,507,992✔
3416
    SSTableVersion *pStbVersion = &pStbVersions[i];
15,978,982✔
3417
    pStbVersion->suid = be64toh(pStbVersion->suid);
15,978,982✔
3418
    pStbVersion->sversion = ntohl(pStbVersion->sversion);
15,978,982✔
3419
    pStbVersion->tversion = ntohl(pStbVersion->tversion);
15,978,982✔
3420
    pStbVersion->smaVer = ntohl(pStbVersion->smaVer);
15,978,982✔
3421

3422
    bool    schema = false;
15,978,982✔
3423
    bool    sma = false;
15,978,982✔
3424
    int32_t code = mndValidateStbVersion(pMnode, pStbVersion, &schema, &sma);
15,978,982✔
3425
    if (TSDB_CODE_SUCCESS != code) {
15,978,982✔
3426
      STableMetaRsp metaRsp = {0};
71,788✔
3427
      metaRsp.numOfColumns = -1;
71,788✔
3428
      metaRsp.suid = pStbVersion->suid;
71,788✔
3429
      tstrncpy(metaRsp.dbFName, pStbVersion->dbFName, sizeof(metaRsp.dbFName));
71,788✔
3430
      tstrncpy(metaRsp.tbName, pStbVersion->stbName, sizeof(metaRsp.tbName));
71,788✔
3431
      tstrncpy(metaRsp.stbName, pStbVersion->stbName, sizeof(metaRsp.stbName));
71,788✔
3432
      if (taosArrayPush(hbRsp.pMetaRsp, &metaRsp) == NULL) {
143,576✔
UNCOV
3433
        code = terrno;
×
UNCOV
3434
        return code;
×
3435
      }
3436
      continue;
71,788✔
3437
    }
3438

3439
    if (schema) {
15,907,194✔
3440
      STableMetaRsp metaRsp = {0};
49,892✔
3441
      mInfo("stb:%s.%s, start to retrieve meta", pStbVersion->dbFName, pStbVersion->stbName);
49,892✔
3442
      if (mndBuildStbSchema(pMnode, pStbVersion->dbFName, pStbVersion->stbName, &metaRsp, false) != 0) {
49,892✔
UNCOV
3443
        metaRsp.numOfColumns = -1;
×
UNCOV
3444
        metaRsp.suid = pStbVersion->suid;
×
UNCOV
3445
        tstrncpy(metaRsp.dbFName, pStbVersion->dbFName, sizeof(metaRsp.dbFName));
×
UNCOV
3446
        tstrncpy(metaRsp.tbName, pStbVersion->stbName, sizeof(metaRsp.tbName));
×
UNCOV
3447
        tstrncpy(metaRsp.stbName, pStbVersion->stbName, sizeof(metaRsp.stbName));
×
UNCOV
3448
        if (taosArrayPush(hbRsp.pMetaRsp, &metaRsp) == NULL) {
×
UNCOV
3449
          code = terrno;
×
UNCOV
3450
          return code;
×
3451
        }
3452
        continue;
×
3453
      }
3454

3455
      if (taosArrayPush(hbRsp.pMetaRsp, &metaRsp) == NULL) {
99,784✔
UNCOV
3456
        code = terrno;
×
UNCOV
3457
        return code;
×
3458
      }
3459
    }
3460

3461
    if (sma) {
15,907,194✔
3462
      bool           exist = false;
×
3463
      char           tbFName[TSDB_TABLE_FNAME_LEN];
×
3464
      STableIndexRsp indexRsp = {0};
×
3465
      indexRsp.pIndex = taosArrayInit(10, sizeof(STableIndexInfo));
×
3466
      if (NULL == indexRsp.pIndex) {
×
3467
        code = terrno;
×
3468
        TAOS_RETURN(code);
×
3469
      }
3470

UNCOV
3471
      (void)tsnprintf(tbFName, sizeof(tbFName), "%s.%s", pStbVersion->dbFName, pStbVersion->stbName);
×
UNCOV
3472
      tstrncpy(indexRsp.dbFName, pStbVersion->dbFName, sizeof(indexRsp.dbFName));
×
UNCOV
3473
      tstrncpy(indexRsp.tbName, pStbVersion->stbName, sizeof(indexRsp.tbName));
×
3474

3475
      if (taosArrayPush(hbRsp.pIndexRsp, &indexRsp) == NULL) {
×
UNCOV
3476
        code = terrno;
×
UNCOV
3477
        return code;
×
3478
      }
3479
    }
3480
  }
3481

3482
  int32_t rspLen = tSerializeSSTbHbRsp(NULL, 0, &hbRsp);
11,529,010✔
3483
  if (rspLen < 0) {
11,527,946✔
3484
    tFreeSSTbHbRsp(&hbRsp);
×
3485
    code = TSDB_CODE_INVALID_MSG;
×
3486
    TAOS_RETURN(code);
×
3487
  }
3488

3489
  void *pRsp = taosMemoryMalloc(rspLen);
11,527,946✔
3490
  if (pRsp == NULL) {
11,527,792✔
3491
    tFreeSSTbHbRsp(&hbRsp);
×
UNCOV
3492
    code = terrno;
×
3493
    TAOS_RETURN(code);
×
3494
  }
3495

3496
  rspLen = tSerializeSSTbHbRsp(pRsp, rspLen, &hbRsp);
11,527,792✔
3497
  tFreeSSTbHbRsp(&hbRsp);
11,529,010✔
3498
  if (rspLen < 0) return rspLen;
11,526,728✔
3499
  *ppRsp = pRsp;
11,526,728✔
3500
  *pRspLen = rspLen;
11,526,728✔
3501
  TAOS_RETURN(code);
11,527,792✔
3502
}
3503

3504
int32_t mndGetNumOfStbs(SMnode *pMnode, char *dbName, int32_t *pNumOfStbs) {
3,997,742✔
3505
  int32_t code = 0;
3,997,742✔
3506
  SSdb   *pSdb = pMnode->pSdb;
3,997,742✔
3507
  SDbObj *pDb = mndAcquireDb(pMnode, dbName);
3,997,742✔
3508
  if (pDb == NULL) {
3,997,742✔
3509
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
3510
    TAOS_RETURN(code);
×
3511
  }
3512

3513
  int32_t numOfStbs = 0;
3,997,742✔
3514
  void   *pIter = NULL;
3,997,742✔
3515
  while (1) {
66,787,750✔
3516
    SStbObj *pStb = NULL;
70,785,492✔
3517
    pIter = sdbFetch(pSdb, SDB_STB, pIter, (void **)&pStb);
70,785,492✔
3518
    if (pIter == NULL) break;
70,785,492✔
3519

3520
    if (pStb->dbUid == pDb->uid) {
66,787,750✔
3521
      numOfStbs++;
44,673,084✔
3522
    }
3523

3524
    sdbRelease(pSdb, pStb);
66,787,750✔
3525
  }
3526

3527
  *pNumOfStbs = numOfStbs;
3,997,742✔
3528
  mndReleaseDb(pMnode, pDb);
3,997,742✔
3529
  TAOS_RETURN(code);
3,997,742✔
3530
}
3531

UNCOV
3532
int32_t mndExtractDbNameFromStbFullName(const char *stbFullName, char *dst) {
×
UNCOV
3533
  SName name = {0};
×
UNCOV
3534
  TAOS_CHECK_RETURN(tNameFromString(&name, stbFullName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
×
3535

UNCOV
3536
  TAOS_CHECK_RETURN(tNameGetFullDbName(&name, dst));
×
3537

UNCOV
3538
  return 0;
×
3539
}
3540

UNCOV
3541
int32_t mndExtractShortDbNameFromStbFullName(const char *stbFullName, char *dst) {
×
UNCOV
3542
  SName name = {0};
×
UNCOV
3543
  TAOS_CHECK_RETURN(tNameFromString(&name, stbFullName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
×
3544

UNCOV
3545
  TAOS_CHECK_RETURN(tNameGetDbName(&name, dst));
×
3546

UNCOV
3547
  return 0;
×
3548
}
3549

3550
int32_t mndExtractShortDbNameFromDbFullName(const char *stbFullName, char *dst) {
67,134✔
3551
  SName name = {0};
67,134✔
3552
  TAOS_CHECK_RETURN(tNameFromString(&name, stbFullName, T_NAME_ACCT | T_NAME_DB));
67,134✔
3553

3554
  TAOS_CHECK_RETURN(tNameGetDbName(&name, dst));
67,134✔
3555

3556
  return 0;
67,134✔
3557
}
3558

3559
void mndExtractTbNameFromStbFullName(const char *stbFullName, char *dst, int32_t dstSize) {
5,808,292✔
3560
  int32_t pos = -1;
5,808,292✔
3561
  int32_t num = 0;
5,808,292✔
3562
  for (pos = 0; stbFullName[pos] != 0; ++pos) {
50,338,776✔
3563
    if (stbFullName[pos] == TS_PATH_DELIMITER[0]) num++;
50,338,776✔
3564
    if (num == 2) break;
50,338,776✔
3565
  }
3566

3567
  if (num == 2) {
5,808,292✔
3568
    tstrncpy(dst, stbFullName + pos + 1, dstSize);
5,808,292✔
3569
  }
3570
}
5,808,292✔
3571

3572
static int32_t mndRetrieveStb(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
561,568✔
3573
  SMnode    *pMnode = pReq->info.node;
561,568✔
3574
  SSdb      *pSdb = pMnode->pSdb;
561,568✔
3575
  int32_t    numOfRows = 0;
561,568✔
3576
  SStbObj   *pStb = NULL;
561,568✔
3577
  SUserObj  *pOperUser = NULL;
561,568✔
3578
  SSHashObj *pUidNames = NULL;
561,568✔
3579
  int32_t    cols = 0;
561,568✔
3580
  int32_t    lino = 0;
561,568✔
3581
  int32_t    code = 0;
561,568✔
3582
  char       objFName[TSDB_OBJ_FNAME_LEN + 1] = {0};
561,568✔
3583
  bool       showAll = false;
561,568✔
3584

3585
  SDbObj *pDb = NULL;
561,568✔
3586
  if (strlen(pShow->db) > 0) {
561,568✔
3587
    pDb = mndAcquireDb(pMnode, pShow->db);
454,164✔
3588
    if (pDb == NULL) return terrno;
454,164✔
3589
  }
3590

3591
  if ((code = mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser)) != 0) {
559,358✔
UNCOV
3592
    goto _ERROR;
×
3593
  }
3594

3595
  (void)snprintf(objFName, sizeof(objFName), "%d.*", pOperUser->acctId);
559,358✔
3596
  showAll = (0 == mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_SHOW, PRIV_OBJ_TBL, pDb ? pDb->ownerId : 0,
559,358✔
3597
                                           pDb ? pDb->name : objFName, "*"));
3598
  showAll = showAll && (0 == mndCheckDbPrivilegeByName(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB,
559,358✔
3599
                                                       pDb ? pDb->name : objFName, false));
3600

3601
  while (numOfRows < rows) {
4,383,088✔
3602
    pShow->pIter = sdbFetch(pSdb, SDB_STB, pShow->pIter, (void **)&pStb);
4,380,844✔
3603
    if (pShow->pIter == NULL) break;
4,380,844✔
3604

3605
    if (pDb != NULL && pStb->dbUid != pDb->uid) {
3,823,730✔
3606
      sdbRelease(pSdb, pStb);
1,891,772✔
3607
      continue;
1,891,772✔
3608
    }
3609

3610
    if (isTsmaResSTb(pStb->name)) {
1,931,958✔
UNCOV
3611
      sdbRelease(pSdb, pStb);
×
UNCOV
3612
      continue;
×
3613
    }
3614

3615
#if 0
3616
    if ((0 == pUser->superUser) && mndCheckStbPrivilege(pMnode, pUser, RPC_MSG_TOKEN(pReq), MND_OPER_SHOW_STB, pStb) != 0) {
3617
      sdbRelease(pSdb, pStb);
3618
      terrno = 0;
3619
      continue;
3620
    }
3621
#endif
3622
    cols = 0;
1,931,958✔
3623

3624
    SName name = {0};
1,931,958✔
3625

3626
    char stbName[TSDB_TABLE_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
1,931,958✔
3627
    mndExtractTbNameFromStbFullName(pStb->name, &stbName[VARSTR_HEADER_SIZE], TSDB_TABLE_NAME_LEN);
1,931,958✔
3628

3629
    if (!showAll && (mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_SHOW, PRIV_OBJ_TBL, pStb->ownerId, pStb->db,
1,931,958✔
3630
                                              &stbName[VARSTR_HEADER_SIZE]) ||
6,916✔
3631
                     mndCheckDbPrivilegeByName(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB,
6,916✔
3632
                                               pStb->db, false))) {
6,916✔
3633
      sdbRelease(pSdb, pStb);
4,368✔
3634
      terrno = 0;
4,368✔
3635
      continue;
4,368✔
3636
    }
3637

3638
    varDataSetLen(stbName, strlen(&stbName[VARSTR_HEADER_SIZE]));
1,927,590✔
3639
    SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,927,590✔
3640
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)stbName, false), pStb, &lino, _ERROR);
1,927,590✔
3641

3642
    char db[TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
1,927,590✔
3643
    RETRIEVE_CHECK_GOTO(tNameFromString(&name, pStb->db, T_NAME_ACCT | T_NAME_DB), pStb, &lino, _ERROR);
1,927,590✔
3644
    RETRIEVE_CHECK_GOTO(tNameGetDbName(&name, varDataVal(db)), pStb, &lino, _ERROR);
1,927,590✔
3645
    varDataSetLen(db, strlen(varDataVal(db)));
1,927,590✔
3646
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,927,590✔
3647
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)db, false), pStb, &lino, _ERROR);
1,927,590✔
3648

3649
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,927,590✔
3650
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->createdTime, false), pStb, &lino,
1,927,590✔
3651
                        _ERROR);
3652

3653
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,927,590✔
3654
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->numOfColumns, false), pStb, &lino,
1,927,590✔
3655
                        _ERROR);
3656

3657
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,927,590✔
3658
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->numOfTags, false), pStb, &lino, _ERROR);
1,927,590✔
3659

3660
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,927,590✔
3661
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->updateTime, false), pStb, &lino,
1,927,590✔
3662
                        _ERROR);  // number of tables
3663

3664
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,927,590✔
3665
    if (pStb->commentLen > 0) {
1,927,590✔
3666
      char comment[TSDB_TB_COMMENT_LEN + VARSTR_HEADER_SIZE] = {0};
38,034✔
3667
      STR_TO_VARSTR(comment, pStb->comment);
38,034✔
3668
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, comment, false), pStb, &lino, _ERROR);
38,034✔
3669
    } else if (pStb->commentLen == 0) {
1,889,556✔
3670
      char comment[VARSTR_HEADER_SIZE + VARSTR_HEADER_SIZE] = {0};
258,840✔
3671
      STR_TO_VARSTR(comment, "");
258,840✔
3672
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, comment, false), pStb, &lino, _ERROR);
258,840✔
3673
    } else {
3674
      colDataSetNULL(pColInfo, numOfRows);
1,630,716✔
3675
    }
3676

3677
    char watermark[64 + VARSTR_HEADER_SIZE] = {0};
1,927,590✔
3678
    (void)tsnprintf(varDataVal(watermark), sizeof(watermark) - VARSTR_HEADER_SIZE, "%" PRId64 "a,%" PRId64 "a",
3,853,068✔
3679
              pStb->watermark[0], pStb->watermark[1]);
3,853,068✔
3680
    varDataSetLen(watermark, strlen(varDataVal(watermark)));
1,927,590✔
3681

3682
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,927,590✔
3683
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)watermark, false), pStb, &lino, _ERROR);
1,927,590✔
3684

3685
    char maxDelay[64 + VARSTR_HEADER_SIZE] = {0};
1,927,590✔
3686
    (void)tsnprintf(varDataVal(maxDelay), sizeof(maxDelay) - VARSTR_HEADER_SIZE, "%" PRId64 "a,%" PRId64 "a",
3,853,068✔
3687
              pStb->maxdelay[0], pStb->maxdelay[1]);
3,853,068✔
3688
    varDataSetLen(maxDelay, strlen(varDataVal(maxDelay)));
1,927,590✔
3689

3690
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,927,590✔
3691
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)maxDelay, false), pStb, &lino, _ERROR);
1,927,590✔
3692

3693
    char    rollup[160 + VARSTR_HEADER_SIZE] = {0};
1,927,590✔
3694
    int32_t rollupNum = (int32_t)taosArrayGetSize(pStb->pFuncs);
1,927,590✔
3695
    char   *sep = ", ";
1,927,590✔
3696
    int32_t sepLen = strlen(sep);
1,927,590✔
3697
    int32_t rollupLen = sizeof(rollup) - VARSTR_HEADER_SIZE - 2;
1,927,590✔
3698
    for (int32_t i = 0; i < rollupNum; ++i) {
1,927,590✔
UNCOV
3699
      char *funcName = taosArrayGet(pStb->pFuncs, i);
×
UNCOV
3700
      if (i) {
×
UNCOV
3701
        (void)strncat(varDataVal(rollup), sep, rollupLen);
×
UNCOV
3702
        rollupLen -= sepLen;
×
3703
      }
UNCOV
3704
      (void)strncat(varDataVal(rollup), funcName, rollupLen);
×
UNCOV
3705
      rollupLen -= strlen(funcName);
×
3706
    }
3707
    varDataSetLen(rollup, strlen(varDataVal(rollup)));
1,927,590✔
3708

3709
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,927,590✔
3710
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)rollup, false), pStb, &lino, _ERROR);
1,927,590✔
3711

3712
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,927,590✔
3713
    if (pColInfo) {
1,927,590✔
3714
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)(&pStb->uid), false), pStb, &lino, _ERROR);
1,927,590✔
3715
    }
3716

3717
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,927,590✔
3718
    if (pColInfo) {
1,927,590✔
3719
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)(&pStb->virtualStb), false), pStb, &lino, _ERROR);
1,927,590✔
3720
    }
3721

3722
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,927,590✔
3723
    if (pColInfo) {
1,927,590✔
3724
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)(&pStb->keep), false), pStb, &lino, _ERROR);
1,927,590✔
3725
    }
3726

3727
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,927,590✔
3728
    if (pColInfo) {
1,927,590✔
3729
      if (!pUidNames) {
1,927,590✔
3730
        TAOS_CHECK_GOTO(mndBuildUidNamesHash(pMnode, &pUidNames), &lino, _OVER);
433,644✔
3731
      }
3732
      const char *ownerName = tSimpleHashGet(pUidNames, (const char *)&pStb->ownerId, sizeof(pStb->ownerId));
1,927,590✔
3733
      char        owner[TSDB_USER_LEN + VARSTR_HEADER_SIZE] = {0};
1,927,590✔
3734
      STR_WITH_MAXSIZE_TO_VARSTR(owner, ownerName ? ownerName : "[unknown]", sizeof(owner));
1,927,590✔
3735
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)owner, false), pStb, &lino, _ERROR);
1,927,590✔
3736
    }
3737

3738
    numOfRows++;
1,927,590✔
3739
    sdbRelease(pSdb, pStb);
1,927,590✔
3740
  }
3741

3742
  if (pDb != NULL) {
559,358✔
3743
    mndReleaseDb(pMnode, pDb);
451,954✔
3744
  }
3745
  if (pOperUser != NULL) {
559,358✔
3746
    mndReleaseUser(pMnode, pOperUser);
559,358✔
3747
  }
3748

3749
  goto _OVER;
559,358✔
3750

UNCOV
3751
_ERROR:
×
UNCOV
3752
  if (pDb != NULL) {
×
UNCOV
3753
    mndReleaseDb(pMnode, pDb);
×
3754
  }
UNCOV
3755
  if (pOperUser != NULL) {
×
UNCOV
3756
    mndReleaseUser(pMnode, pOperUser);
×
3757
  }
UNCOV
3758
  mError("show:0x%" PRIx64 ", failed to retrieve data at %s:%d since %s", pShow->id, __FUNCTION__, lino,
×
3759
         tstrerror(code));
3760

3761
_OVER:
556,862✔
3762
  pShow->numOfRows += numOfRows;
559,358✔
3763
  tSimpleHashCleanup(pUidNames);
559,358✔
3764
  return numOfRows;
559,358✔
3765
}
3766

3767
static int32_t buildDbColsInfoBlock(const SSDataBlock *p, const SSysTableMeta *pSysDbTableMeta, size_t size,
3,653,272✔
3768
                                    const char *dbName, const char *tbName) {
3769
  char    tName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
3,653,272✔
3770
  char    dName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
3,653,272✔
3771
  char    typeName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
3,653,272✔
3772
  int32_t numOfRows = p->info.rows;
3,653,272✔
3773
  int32_t lino = 0;
3,653,272✔
3774
  int32_t code = 0;
3,653,272✔
3775

3776
  STR_TO_VARSTR(dName, dbName);
3,653,272✔
3777
  STR_TO_VARSTR(typeName, "SYSTEM_TABLE");
3,653,272✔
3778

3779
  for (int32_t i = 0; i < size; ++i) {
120,553,816✔
3780
    const SSysTableMeta *pm = &pSysDbTableMeta[i];
116,900,544✔
3781
    //    if (pm->sysInfo) {
3782
    //      continue;
3783
    //    }
3784
    if (tbName[0] && strncmp(tbName, pm->name, TSDB_TABLE_NAME_LEN) != 0) {
116,899,504✔
UNCOV
3785
      continue;
×
3786
    }
3787

3788
    STR_TO_VARSTR(tName, pm->name);
116,899,504✔
3789

3790
    for (int32_t j = 0; j < pm->colNum; j++) {
1,132,373,920✔
3791
      // table name
3792
      SColumnInfoData *pColInfoData = taosArrayGet(p->pDataBlock, 0);
1,015,475,456✔
3793
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, tName, false), &lino, _OVER);
1,015,362,096✔
3794

3795
      // database name
3796
      pColInfoData = taosArrayGet(p->pDataBlock, 1);
1,015,293,456✔
3797
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, dName, false), &lino, _OVER);
1,015,170,736✔
3798

3799
      pColInfoData = taosArrayGet(p->pDataBlock, 2);
1,015,230,016✔
3800
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, typeName, false), &lino, _OVER);
1,015,219,616✔
3801

3802
      // col name
3803
      char colName[TSDB_COL_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
1,015,245,616✔
3804
      STR_TO_VARSTR(colName, pm->schema[j].name);
1,015,250,816✔
3805
      pColInfoData = taosArrayGet(p->pDataBlock, 3);
1,015,476,496✔
3806
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, colName, false), &lino, _OVER);
1,015,311,136✔
3807

3808
      // col type
3809
      int8_t colType = pm->schema[j].type;
1,015,312,176✔
3810
      pColInfoData = taosArrayGet(p->pDataBlock, 4);
1,015,326,736✔
3811
      char colTypeStr[VARSTR_HEADER_SIZE + 32];
1,015,324,656✔
3812
      int  colTypeLen =
1,015,486,896✔
3813
          tsnprintf(varDataVal(colTypeStr), sizeof(colTypeStr) - VARSTR_HEADER_SIZE, "%s", tDataTypes[colType].name);
1,015,327,776✔
3814
      if (colType == TSDB_DATA_TYPE_VARCHAR) {
1,015,486,896✔
3815
        colTypeLen +=
527,838,524✔
3816
            tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE, "(%d)",
527,840,604✔
3817
                      (int32_t)(pm->schema[j].bytes - VARSTR_HEADER_SIZE));
527,837,484✔
3818
      } else if (colType == TSDB_DATA_TYPE_NCHAR) {
487,649,412✔
UNCOV
3819
        colTypeLen +=
×
UNCOV
3820
            tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE, "(%d)",
×
UNCOV
3821
                      (int32_t)((pm->schema[j].bytes - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE));
×
3822
      }
3823
      varDataSetLen(colTypeStr, colTypeLen);
1,015,487,936✔
3824
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, (char *)colTypeStr, false), &lino, _OVER);
1,015,314,256✔
3825

3826
      // col length
3827
      pColInfoData = taosArrayGet(p->pDataBlock, 5);
1,015,361,056✔
3828
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, (const char *)&pm->schema[j].bytes, false), &lino, _OVER);
1,015,356,896✔
3829

3830
      // col precision, col scale, col nullable, col source
3831
      for (int32_t k = 6; k <= 10; ++k) {
2,147,483,647✔
3832
        pColInfoData = taosArrayGet(p->pDataBlock, k);
2,147,483,647✔
3833
        colDataSetNULL(pColInfoData, numOfRows);
2,147,483,647✔
3834
      }
3835

3836
      numOfRows += 1;
1,017,162,336✔
3837
    }
3838
  }
3839
  return numOfRows;
3,653,272✔
UNCOV
3840
_OVER:
×
UNCOV
3841
  mError("failed at %s:%d since %s", __FUNCTION__, lino, tstrerror(code));
×
UNCOV
3842
  return numOfRows;
×
3843
}
3844
#define BUILD_COL_FOR_INFO_DB 1
3845
#define BUILD_COL_FOR_PERF_DB 1 << 1
3846
#define BUILD_COL_FOR_USER_DB 1 << 2
3847
#define BUILD_COL_FOR_ALL_DB  (BUILD_COL_FOR_INFO_DB | BUILD_COL_FOR_PERF_DB | BUILD_COL_FOR_USER_DB)
3848

3849
static int32_t buildSysDbColsInfo(SSDataBlock *p, int8_t buildWhichDBs, char *tb) {
1,894,004✔
3850
  size_t               size = 0;
1,894,004✔
3851
  const SSysTableMeta *pSysDbTableMeta = NULL;
1,894,004✔
3852

3853
  if (buildWhichDBs & BUILD_COL_FOR_INFO_DB) {
1,894,004✔
3854
    getInfosDbMeta(&pSysDbTableMeta, &size);
1,826,636✔
3855
    p->info.rows = buildDbColsInfoBlock(p, pSysDbTableMeta, size, TSDB_INFORMATION_SCHEMA_DB, tb);
1,826,636✔
3856
  }
3857

3858
  if (buildWhichDBs & BUILD_COL_FOR_PERF_DB) {
1,894,004✔
3859
    getPerfDbMeta(&pSysDbTableMeta, &size);
1,826,636✔
3860
    p->info.rows = buildDbColsInfoBlock(p, pSysDbTableMeta, size, TSDB_PERFORMANCE_SCHEMA_DB, tb);
1,826,636✔
3861
  }
3862

3863
  return p->info.rows;
1,894,004✔
3864
}
3865

3866
static int8_t determineBuildColForWhichDBs(const char *db) {
1,901,780✔
3867
  int8_t buildWhichDBs;
3868
  if (!db[0])
1,901,780✔
3869
    buildWhichDBs = BUILD_COL_FOR_ALL_DB;
1,826,312✔
3870
  else {
3871
    char *p = strchr(db, '.');
75,468✔
3872
    if (p && strcmp(p + 1, TSDB_INFORMATION_SCHEMA_DB) == 0) {
75,468✔
3873
      buildWhichDBs = BUILD_COL_FOR_INFO_DB;
324✔
3874
    } else if (p && strcmp(p + 1, TSDB_PERFORMANCE_SCHEMA_DB) == 0) {
75,144✔
3875
      buildWhichDBs = BUILD_COL_FOR_PERF_DB;
324✔
3876
    } else {
3877
      buildWhichDBs = BUILD_COL_FOR_USER_DB;
74,820✔
3878
    }
3879
  }
3880
  return buildWhichDBs;
1,901,780✔
3881
}
3882

3883
static int32_t mndRetrieveStbCol(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
1,901,780✔
3884
  uint8_t  buildWhichDBs;
3885
  SMnode  *pMnode = pReq->info.node;
1,901,780✔
3886
  SSdb    *pSdb = pMnode->pSdb;
1,901,780✔
3887
  SStbObj *pStb = NULL;
1,901,780✔
3888
  int32_t  numOfRows = 0;
1,901,780✔
3889
  int32_t  lino = 0;
1,901,780✔
3890
  int32_t  code = 0;
1,901,780✔
3891

3892
  buildWhichDBs = determineBuildColForWhichDBs(pShow->db);
1,901,780✔
3893

3894
  if (!pShow->sysDbRsp) {
1,901,780✔
3895
    numOfRows = buildSysDbColsInfo(pBlock, buildWhichDBs, pShow->filterTb);
1,894,004✔
3896
    mDebug("mndRetrieveStbCol get system table cols, rows:%d, db:%s", numOfRows, pShow->db);
1,894,004✔
3897
    pShow->sysDbRsp = true;
1,894,004✔
3898
  }
3899

3900
  if (buildWhichDBs & BUILD_COL_FOR_USER_DB) {
1,901,780✔
3901
    SDbObj *pDb = NULL;
1,901,132✔
3902
    if (strlen(pShow->db) > 0) {
1,901,132✔
3903
      pDb = mndAcquireDb(pMnode, pShow->db);
74,820✔
3904
      if (pDb == NULL && TSDB_CODE_MND_DB_NOT_EXIST != terrno && pBlock->info.rows == 0) return terrno;
74,820✔
3905
    }
3906

3907
    char typeName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
1,901,132✔
3908
    STR_TO_VARSTR(typeName, "SUPER_TABLE");
1,901,132✔
3909
    bool fetch = pShow->restore ? false : true;
1,901,132✔
3910
    pShow->restore = false;
1,901,132✔
3911
    while (numOfRows < rows) {
5,574,094✔
3912
      if (fetch) {
5,574,094✔
3913
        pShow->pIter = sdbFetch(pSdb, SDB_STB, pShow->pIter, (void **)&pStb);
5,566,318✔
3914
        if (pShow->pIter == NULL) break;
5,566,318✔
3915
      } else {
3916
        fetch = true;
7,776✔
3917
        void *pKey = taosHashGetKey(pShow->pIter, NULL);
7,776✔
3918
        pStb = sdbAcquire(pSdb, SDB_STB, pKey);
7,776✔
3919
        if (!pStb) continue;
7,776✔
3920
      }
3921

3922
      if (pDb != NULL && pStb->dbUid != pDb->uid) {
3,680,738✔
3923
        sdbRelease(pSdb, pStb);
5,368✔
3924
        continue;
5,368✔
3925
      }
3926

3927
      SName name = {0};
3,675,370✔
3928
      char  stbName[TSDB_TABLE_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
3,675,370✔
3929
      mndExtractTbNameFromStbFullName(pStb->name, &stbName[VARSTR_HEADER_SIZE], TSDB_TABLE_NAME_LEN);
3,675,370✔
3930
      if (pShow->filterTb[0] && strncmp(pShow->filterTb, &stbName[VARSTR_HEADER_SIZE], TSDB_TABLE_NAME_LEN) != 0) {
3,675,370✔
UNCOV
3931
        sdbRelease(pSdb, pStb);
×
UNCOV
3932
        continue;
×
3933
      }
3934

3935
      if ((numOfRows + pStb->numOfColumns) > rows) {
3,675,370✔
3936
        pShow->restore = true;
7,776✔
3937
        if (numOfRows == 0) {
7,776✔
UNCOV
3938
          mError("mndRetrieveStbCol failed to get stable cols since buf:%d less than result:%d, stable name:%s, db:%s",
×
3939
                 rows, pStb->numOfColumns, pStb->name, pStb->db);
3940
        }
3941
        sdbRelease(pSdb, pStb);
7,776✔
3942
        break;
7,776✔
3943
      }
3944

3945
      varDataSetLen(stbName, strlen(&stbName[VARSTR_HEADER_SIZE]));
3,667,594✔
3946

3947
      mDebug("mndRetrieveStbCol get stable cols, stable name:%s, db:%s", pStb->name, pStb->db);
3,667,594✔
3948

3949
      char db[TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
3,667,594✔
3950
      RETRIEVE_CHECK_GOTO(tNameFromString(&name, pStb->db, T_NAME_ACCT | T_NAME_DB), pStb, &lino, _OVER);
3,667,594✔
3951
      RETRIEVE_CHECK_GOTO(tNameGetDbName(&name, varDataVal(db)), pStb, &lino, _OVER);
3,667,594✔
3952
      varDataSetLen(db, strlen(varDataVal(db)));
3,667,594✔
3953

3954
      for (int i = 0; i < pStb->numOfColumns; i++) {
68,966,380✔
3955
        int32_t          cols = 0;
65,298,786✔
3956
        SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
65,298,786✔
3957
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)stbName, false), pStb, &lino, _OVER);
65,298,786✔
3958

3959
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
65,298,786✔
3960
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)db, false), pStb, &lino, _OVER);
65,298,786✔
3961

3962
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
65,298,786✔
3963
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, typeName, false), pStb, &lino, _OVER);
65,298,786✔
3964

3965
        // col name
3966
        char colName[TSDB_COL_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
65,298,786✔
3967
        STR_TO_VARSTR(colName, pStb->pColumns[i].name);
65,298,786✔
3968
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
65,298,786✔
3969
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, colName, false), pStb, &lino, _OVER);
65,298,786✔
3970

3971
        // col type
3972
        int8_t colType = pStb->pColumns[i].type;
65,298,786✔
3973
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
65,298,786✔
3974
        char colTypeStr[VARSTR_HEADER_SIZE + 32];
65,298,786✔
3975
        int  colTypeLen =
65,298,786✔
3976
            tsnprintf(varDataVal(colTypeStr), sizeof(colTypeStr) - VARSTR_HEADER_SIZE, "%s", tDataTypes[colType].name);
65,298,786✔
3977
        if (colType == TSDB_DATA_TYPE_VARCHAR) {
65,298,786✔
3978
          colTypeLen +=
2,022,484✔
3979
              tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE,
2,022,484✔
3980
                        "(%d)", (int32_t)(pStb->pColumns[i].bytes - VARSTR_HEADER_SIZE));
2,022,484✔
3981
        } else if (colType == TSDB_DATA_TYPE_NCHAR) {
63,276,302✔
3982
          colTypeLen +=
2,021,756✔
3983
              tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE,
2,021,756✔
3984
                        "(%d)", (int32_t)((pStb->pColumns[i].bytes - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE));
2,021,756✔
3985
        } else if (IS_DECIMAL_TYPE(colType)) {
61,254,546✔
UNCOV
3986
          STypeMod typeMod = pStb->pExtSchemas[i].typeMod;
×
UNCOV
3987
          uint8_t prec = 0, scale = 0;
×
UNCOV
3988
          decimalFromTypeMod(typeMod, &prec, &scale);
×
UNCOV
3989
          colTypeLen += sprintf(varDataVal(colTypeStr) + colTypeLen, "(%d,%d)", prec, scale);
×
3990
        }
3991
        varDataSetLen(colTypeStr, colTypeLen);
65,298,786✔
3992
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (char *)colTypeStr, false), pStb, &lino, _OVER);
65,298,786✔
3993

3994
        // col length
3995
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
65,298,786✔
3996
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->pColumns[i].bytes, false), pStb,
65,298,786✔
3997
                            &lino, _OVER);
3998
        
3999
        // col precision, col scale, col nullable, col source
4000
        for (int32_t j = 6; j <= 9; ++j) {
326,492,890✔
4001
          pColInfo = taosArrayGet(pBlock->pDataBlock, j);
261,195,144✔
4002
          colDataSetNULL(pColInfo, numOfRows);
261,195,144✔
4003
        }
4004

4005
        // col id
4006
        pColInfo = taosArrayGet(pBlock->pDataBlock, 10);
65,297,746✔
4007
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->pColumns[i].colId, false), pStb,
65,298,786✔
4008
                            &lino, _OVER);
4009
        numOfRows++;
65,298,786✔
4010
      }
4011

4012
      sdbRelease(pSdb, pStb);
3,667,594✔
4013
    }
4014

4015
    if (pDb != NULL) {
1,901,132✔
4016
      mndReleaseDb(pMnode, pDb);
74,452✔
4017
    }
4018
  }
4019

4020
  mDebug("mndRetrieveStbCol success, rows:%d, pShow->numOfRows:%d", numOfRows, pShow->numOfRows);
1,901,780✔
4021
  goto _OVER;
1,901,780✔
4022

4023
_ERROR:
4024
  mError("failed to mndRetrieveStbCol, rows:%d, pShow->numOfRows:%d, at %s:%d since %s", numOfRows, pShow->numOfRows,
4025
         __FUNCTION__, lino, tstrerror(code));
4026

4027
_OVER:
1,901,780✔
4028
  pShow->numOfRows += numOfRows;
1,901,780✔
4029
  return numOfRows;
1,901,780✔
4030
}
4031

4032
static void mndCancelGetNextStb(SMnode *pMnode, void *pIter) {
324✔
4033
  SSdb *pSdb = pMnode->pSdb;
324✔
4034
  sdbCancelFetchByType(pSdb, pIter, SDB_STB);
324✔
4035
}
324✔
4036

UNCOV
4037
const char *mndGetStbStr(const char *src) {
×
UNCOV
4038
  char *posDb = strstr(src, TS_PATH_DELIMITER);
×
UNCOV
4039
  if (posDb != NULL) ++posDb;
×
UNCOV
4040
  if (posDb == NULL) return src;
×
4041

UNCOV
4042
  char *posStb = strstr(posDb, TS_PATH_DELIMITER);
×
UNCOV
4043
  if (posStb != NULL) ++posStb;
×
UNCOV
4044
  if (posStb == NULL) return posDb;
×
UNCOV
4045
  return posStb;
×
4046
}
4047

UNCOV
4048
static int32_t mndCheckIndexReq(SCreateTagIndexReq *pReq) {
×
4049
  // impl
UNCOV
4050
  return TSDB_CODE_SUCCESS;
×
4051
}
4052

4053
/*int32_t mndAddIndexImpl(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp, void *sql,
4054
                        int32_t len) {
4055
  // impl later
4056
  int32_t code = 0;
4057
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "create-stb-index");
4058
  if (pTrans == NULL) goto _OVER;
4059

4060
  mInfo("trans:%d, used to add index to stb:%s", pTrans->id, pStb->name);
4061
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
4062
  if (mndTransCheckConflict(pMnode, pTrans) != 0) goto _OVER;
4063

4064
  if (mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb) != 0) goto _OVER;
4065
  if (mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb) != 0) goto _OVER;
4066
  if (mndSetAlterStbRedoActions2(pMnode, pTrans, pDb, pStb, sql, len) != 0) goto _OVER;
4067
  if (mndTransPrepare(pMnode, pTrans) != 0) goto _OVER;
4068

4069
  return code;
4070

4071
_OVER:
4072
  mndTransDrop(pTrans);
4073
  return code;
4074
}
4075
static int32_t mndAddIndex(SMnode *pMnode, SRpcMsg *pReq, SCreateTagIndexReq *tagIdxReq, SDbObj *pDb, SStbObj *pOld) {
4076
  bool    needRsp = true;
4077
  int32_t code = -1;
4078
  SField *pField0 = NULL;
4079

4080
  SStbObj  stbObj = {0};
4081
  SStbObj *pNew = &stbObj;
4082

4083
  taosRLockLatch(&pOld->lock);
4084
  memcpy(&stbObj, pOld, sizeof(SStbObj));
4085
  taosRUnLockLatch(&pOld->lock);
4086

4087
  stbObj.pColumns = NULL;
4088
  stbObj.pTags = NULL;
4089
  stbObj.updateTime = taosGetTimestampMs();
4090
  stbObj.lock = 0;
4091

4092
  int32_t tag = mndFindSuperTableTagIndex(pOld, tagIdxReq->colName);
4093
  if (tag < 0) {
4094
    terrno = TSDB_CODE_MND_TAG_NOT_EXIST;
4095
    return -1;
4096
  }
4097
  if (mndAllocStbSchemas(pOld, pNew) != 0) {
4098
    return -1;
4099
  }
4100

4101
  SSchema *pTag = pNew->pTags + tag;
4102
  if (IS_IDX_ON(pTag)) {
4103
    terrno = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
4104
    return -1;
4105
  } else {
4106
    pTag->flags |= COL_IDX_ON;
4107
  }
4108
  pNew->tagVer++;
4109

4110
  code = mndAddIndexImpl(pMnode, pReq, pDb, pNew, needRsp, pReq->pCont, pReq->contLen);
4111

4112
  return code;
4113
}
4114
static int32_t mndProcessCreateIndexReq(SRpcMsg *pReq) {
4115
  SMnode            *pMnode = pReq->info.node;
4116
  int32_t            code = -1;
4117
  SDbObj            *pDb = NULL;
4118
  SStbObj           *pStb = NULL;
4119
  SCreateTagIndexReq tagIdxReq = {0};
4120

4121
  if (tDeserializeSCreateTagIdxReq(pReq->pCont, pReq->contLen, &tagIdxReq) != 0) {
4122
    terrno = TSDB_CODE_INVALID_MSG;
4123
    goto _OVER;
4124
  }
4125

4126
  mInfo("stb:%s, start to alter", tagIdxReq.stbName);
4127

4128
  if (mndCheckIndexReq(&tagIdxReq) != TSDB_CODE_SUCCESS) {
4129
    goto _OVER;
4130
  }
4131

4132
  pDb = mndAcquireDbByStb(pMnode, tagIdxReq.dbFName);
4133
  if (pDb == NULL) {
4134
    terrno = TSDB_CODE_MND_DB_NOT_EXIST;
4135
    goto _OVER;
4136
  }
4137

4138
  pStb = mndAcquireStb(pMnode, tagIdxReq.stbName);
4139
  if (pStb == NULL) {
4140
    terrno = TSDB_CODE_MND_STB_NOT_EXIST;
4141
    goto _OVER;
4142
  }
4143
  if (mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_WRITE_DB, pDb) != 0) {
4144
    goto _OVER;
4145
  }
4146

4147
  code = mndAddIndex(pMnode, pReq, &tagIdxReq, pDb, pStb);
4148
  if (terrno == TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST || terrno == TSDB_CODE_MND_TAG_NOT_EXIST) {
4149
    return terrno;
4150
  } else {
4151
    if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
4152
  }
4153
_OVER:
4154
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
4155
    mError("stb:%s, failed to create index since %s", tagIdxReq.stbName, terrstr());
4156
  }
4157
  mndReleaseStb(pMnode, pStb);
4158
  mndReleaseDb(pMnode, pDb);
4159
  return code;
4160
}
4161
static int32_t mndProcessDropIndexReq(SRpcMsg *pReq) {
4162
  SMnode          *pMnode = pReq->info.node;
4163
  int32_t          code = -1;
4164
  SDbObj          *pDb = NULL;
4165
  SStbObj         *pStb = NULL;
4166
  SDropTagIndexReq dropReq = {0};
4167
  if (tDeserializeSDropTagIdxReq(pReq->pCont, pReq->contLen, &dropReq) != 0) {
4168
    terrno = TSDB_CODE_INVALID_MSG;
4169
    goto _OVER;
4170
  }
4171
  //
4172
  return TSDB_CODE_SUCCESS;
4173
_OVER:
4174
  return code;
4175
}*/
4176

4177
static int32_t mndProcessDropStbReqFromMNode(SRpcMsg *pReq) {
4,830✔
4178
  int32_t code = mndProcessDropStbReq(pReq);
4,830✔
4179
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
4,830✔
UNCOV
4180
    pReq->info.rsp = rpcMallocCont(1);
×
UNCOV
4181
    pReq->info.rspLen = 1;
×
UNCOV
4182
    pReq->info.noResp = false;
×
UNCOV
4183
    pReq->code = code;
×
4184
  }
4185
  return code;
4,830✔
4186
}
4187

4188
typedef struct SVDropTbVgReqs {
4189
  SArray     *pBatchReqs;
4190
  SVgroupInfo info;
4191
} SVDropTbVgReqs;
4192

4193
typedef struct SMDropTbDbInfo {
4194
  SArray *dbVgInfos;
4195
  int32_t hashPrefix;
4196
  int32_t hashSuffix;
4197
  int32_t hashMethod;
4198
} SMDropTbDbInfo;
4199

4200
typedef struct SMDropTbTsmaInfo {
4201
  char           tsmaResTbDbFName[TSDB_DB_FNAME_LEN];
4202
  char           tsmaResTbNamePrefix[TSDB_TABLE_FNAME_LEN];
4203
  int32_t        suid;
4204
  SMDropTbDbInfo dbInfo;  // reference to DbInfo in pDbMap
4205
} SMDropTbTsmaInfo;
4206

4207
typedef struct SMDropTbTsmaInfos {
4208
  SArray *pTsmaInfos;  // SMDropTbTsmaInfo
4209
} SMDropTbTsmaInfos;
4210

4211
typedef struct SMndDropTbsWithTsmaCtx {
4212
  SHashObj *pVgMap;  // <vgId, SVDropTbVgReqs>
4213
} SMndDropTbsWithTsmaCtx;
4214

4215
static int32_t mndDropTbForSingleVg(SMnode *pMnode, SMndDropTbsWithTsmaCtx *pCtx, SArray *pTbs, int32_t vgId);
4216

4217
static void destroySVDropTbBatchReqs(void *p);
4218
static void mndDestroyDropTbsWithTsmaCtx(SMndDropTbsWithTsmaCtx *p) {
24,102✔
4219
  if (!p) return;
24,102✔
4220

4221
  if (p->pVgMap) {
24,102✔
4222
    void *pIter = taosHashIterate(p->pVgMap, NULL);
24,102✔
4223
    while (pIter) {
48,204✔
4224
      SVDropTbVgReqs *pReqs = pIter;
24,102✔
4225
      taosArrayDestroyEx(pReqs->pBatchReqs, destroySVDropTbBatchReqs);
24,102✔
4226
      pIter = taosHashIterate(p->pVgMap, pIter);
24,102✔
4227
    }
4228
    taosHashCleanup(p->pVgMap);
24,102✔
4229
  }
4230
  taosMemoryFree(p);
24,102✔
4231
}
4232

4233
static int32_t mndInitDropTbsWithTsmaCtx(SMndDropTbsWithTsmaCtx **ppCtx) {
24,102✔
4234
  int32_t                 code = 0;
24,102✔
4235
  SMndDropTbsWithTsmaCtx *pCtx = taosMemoryCalloc(1, sizeof(SMndDropTbsWithTsmaCtx));
24,102✔
4236
  if (!pCtx) return terrno;
24,102✔
4237

4238
  pCtx->pVgMap = taosHashInit(4, taosGetDefaultHashFunction(TSDB_DATA_TYPE_INT), false, HASH_NO_LOCK);
24,102✔
4239
  if (!pCtx->pVgMap) {
24,102✔
UNCOV
4240
    code = terrno;
×
UNCOV
4241
    goto _end;
×
4242
  }
4243

4244
  *ppCtx = pCtx;
24,102✔
4245
_end:
24,102✔
4246
  if (code) mndDestroyDropTbsWithTsmaCtx(pCtx);
24,102✔
4247
  return code;
24,102✔
4248
}
4249

4250
static void *mndBuildVDropTbsReq(SMnode *pMnode, const SVgroupInfo *pVgInfo, const SVDropTbBatchReq *pReq,
69,808✔
4251
                                 int32_t *len) {
4252
  int32_t   contLen = 0;
69,808✔
4253
  int32_t   ret = 0;
69,808✔
4254
  SMsgHead *pHead = NULL;
69,808✔
4255
  SEncoder  encoder = {0};
69,808✔
4256

4257
  tEncodeSize(tEncodeSVDropTbBatchReq, pReq, contLen, ret);
69,808✔
4258
  if (ret < 0) return NULL;
69,808✔
4259

4260
  contLen += sizeof(SMsgHead);
69,808✔
4261
  pHead = taosMemoryMalloc(contLen);
69,808✔
4262
  if (pHead == NULL) {
69,808✔
UNCOV
4263
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
4264
    return NULL;
×
4265
  }
4266

4267
  pHead->contLen = htonl(contLen);
69,808✔
4268
  pHead->vgId = htonl(pVgInfo->vgId);
69,808✔
4269

4270
  void *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
69,808✔
4271

4272
  tEncoderInit(&encoder, pBuf, contLen - sizeof(SMsgHead));
69,808✔
4273
  int32_t code = tEncodeSVDropTbBatchReq(&encoder, pReq);
69,808✔
4274
  tEncoderClear(&encoder);
69,808✔
4275
  if (code != 0) return NULL;
69,808✔
4276

4277
  *len = contLen;
69,808✔
4278
  return pHead;
69,808✔
4279
}
4280

4281
static int32_t mndSetDropTbsRedoActions(SMnode *pMnode, STrans *pTrans, const SVDropTbVgReqs *pVgReqs, void *pCont,
69,808✔
4282
                                        int32_t contLen, tmsg_t msgType) {
4283
  STransAction action = {0};
69,808✔
4284
  action.epSet = pVgReqs->info.epSet;
69,808✔
4285
  action.pCont = pCont;
69,808✔
4286
  action.contLen = contLen;
69,808✔
4287
  action.msgType = msgType;
69,808✔
4288
  action.acceptableCode = TSDB_CODE_TDB_TABLE_NOT_EXIST;
69,808✔
4289
  return mndTransAppendRedoAction(pTrans, &action);
69,808✔
4290
}
4291

4292
static int32_t mndBuildDropTbRedoActions(SMnode *pMnode, STrans *pTrans, SHashObj *pVgMap, tmsg_t msgType) {
17,452✔
4293
  int32_t code = 0;
17,452✔
4294
  void   *pIter = taosHashIterate(pVgMap, NULL);
17,452✔
4295
  while (pIter) {
34,904✔
4296
    const SVDropTbVgReqs *pVgReqs = pIter;
17,452✔
4297
    int32_t               len = 0;
17,452✔
4298
    for (int32_t i = 0; i < taosArrayGetSize(pVgReqs->pBatchReqs) && code == TSDB_CODE_SUCCESS; ++i) {
87,260✔
4299
      SVDropTbBatchReq *pBatchReq = taosArrayGet(pVgReqs->pBatchReqs, i);
69,808✔
4300
      void             *p = mndBuildVDropTbsReq(pMnode, &pVgReqs->info, pBatchReq, &len);
69,808✔
4301
      if (!p) {
69,808✔
UNCOV
4302
        code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
4303
        if (terrno != 0) code = terrno;
×
UNCOV
4304
        break;
×
4305
      }
4306
      if ((code = mndSetDropTbsRedoActions(pMnode, pTrans, pVgReqs, p, len, msgType)) != 0) {
69,808✔
UNCOV
4307
        break;
×
4308
      }
4309
    }
4310
    if (TSDB_CODE_SUCCESS != code) {
17,452✔
UNCOV
4311
      taosHashCancelIterate(pVgMap, pIter);
×
UNCOV
4312
      break;
×
4313
    }
4314
    pIter = taosHashIterate(pVgMap, pIter);
17,452✔
4315
  }
4316
  return code;
17,452✔
4317
}
4318

4319
static int32_t mndCreateDropTbsTxnPrepare(SRpcMsg *pRsp, SMndDropTbsWithTsmaCtx *pCtx) {
24,102✔
4320
  int32_t code = 0;
24,102✔
4321
  SMnode *pMnode = pRsp->info.node;
24,102✔
4322
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_GLOBAL, pRsp, "drop-tbs");
24,102✔
4323
  mndTransSetChangeless(pTrans);
24,102✔
4324
  mndTransSetSerial(pTrans);
24,102✔
4325
  if (pTrans == NULL) {
24,102✔
UNCOV
4326
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
4327
    if (terrno != 0) code = terrno;
×
UNCOV
4328
    goto _OVER;
×
4329
  }
4330

4331
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
24,102✔
4332

4333
  if ((code = mndBuildDropTbRedoActions(pMnode, pTrans, pCtx->pVgMap, TDMT_VND_DROP_TABLE)) != 0) goto _OVER;
17,452✔
4334
  if ((code = mndTransPrepare(pMnode, pTrans)) != 0) goto _OVER;
17,452✔
4335

4336
_OVER:
17,452✔
4337
  mndTransDrop(pTrans);
24,102✔
4338
  TAOS_RETURN(code);
24,102✔
4339
}
4340

UNCOV
4341
static int32_t mndProcessDropTbWithTsma(SRpcMsg *pReq) {
×
UNCOV
4342
  int32_t      code = -1;
×
UNCOV
4343
  SMnode      *pMnode = pReq->info.node;
×
4344
  SDbObj      *pDb = NULL;
×
4345
  SStbObj     *pStb = NULL;
×
4346
  SMDropTbsReq dropReq = {0};
×
UNCOV
4347
  bool         locked = false;
×
UNCOV
4348
  if (tDeserializeSMDropTbsReq(pReq->pCont, pReq->contLen, &dropReq) != 0) {
×
UNCOV
4349
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
4350
    goto _OVER;
×
4351
  }
4352

UNCOV
4353
  SMndDropTbsWithTsmaCtx *pCtx = NULL;
×
UNCOV
4354
  code = mndInitDropTbsWithTsmaCtx(&pCtx);
×
UNCOV
4355
  if (code) goto _OVER;
×
UNCOV
4356
  for (int32_t i = 0; i < dropReq.pVgReqs->size; ++i) {
×
UNCOV
4357
    SMDropTbReqsOnSingleVg *pReq = taosArrayGet(dropReq.pVgReqs, i);
×
UNCOV
4358
    code = mndDropTbForSingleVg(pMnode, pCtx, pReq->pTbs, pReq->vgInfo.vgId);
×
4359
    if (code) goto _OVER;
×
4360
  }
4361
  code = mndCreateDropTbsTxnPrepare(pReq, pCtx);
×
4362
  if (code == 0) {
×
4363
    code = TSDB_CODE_ACTION_IN_PROGRESS;
×
4364
  }
4365
_OVER:
×
4366
  tFreeSMDropTbsReq(&dropReq);
×
4367
  if (pCtx) mndDestroyDropTbsWithTsmaCtx(pCtx);
×
4368
  TAOS_RETURN(code);
×
4369
}
4370

4371
static int32_t createDropTbBatchReq(const SVDropTbReq *pReq, SVDropTbBatchReq *pBatchReq) {
99,068✔
4372
  pBatchReq->nReqs = 1;
99,068✔
4373
  pBatchReq->pArray = taosArrayInit(TARRAY_MIN_SIZE, sizeof(SVDropTbReq));
99,068✔
4374
  if (!pBatchReq->pArray) return terrno;
99,068✔
4375
  if (taosArrayPush(pBatchReq->pArray, pReq) == NULL) {
198,136✔
4376
    taosArrayDestroy(pBatchReq->pArray);
×
4377
    pBatchReq->pArray = NULL;
×
UNCOV
4378
    return terrno;
×
4379
  }
4380
  return TSDB_CODE_SUCCESS;
99,068✔
4381
}
4382

4383
static void destroySVDropTbBatchReqs(void *p) {
99,068✔
4384
  SVDropTbBatchReq *pReq = p;
99,068✔
4385
  taosArrayDestroy(pReq->pArray);
99,068✔
4386
  pReq->pArray = NULL;
99,068✔
4387
}
99,068✔
4388

4389
static int32_t mndDropTbAdd(SMnode *pMnode, SHashObj *pVgHashMap, const SVgroupInfo *pVgInfo, char *name, tb_uid_t suid,
99,068✔
4390
                            bool ignoreNotExists) {
4391
  SVDropTbReq req = {.name = name, .suid = suid, .igNotExists = ignoreNotExists, .uid = 0};
99,068✔
4392

4393
  SVDropTbVgReqs *pVgReqs = taosHashGet(pVgHashMap, &pVgInfo->vgId, sizeof(pVgInfo->vgId));
99,068✔
4394
  SVDropTbVgReqs  vgReqs = {0};
99,068✔
4395
  if (pVgReqs == NULL) {
99,068✔
4396
    vgReqs.info = *pVgInfo;
24,102✔
4397
    vgReqs.pBatchReqs = taosArrayInit(TARRAY_MIN_SIZE, sizeof(SVDropTbBatchReq));
24,102✔
4398
    if (!vgReqs.pBatchReqs) return terrno;
24,102✔
4399
    SVDropTbBatchReq batchReq = {0};
24,102✔
4400
    int32_t          code = createDropTbBatchReq(&req, &batchReq);
24,102✔
4401
    if (TSDB_CODE_SUCCESS != code) return code;
24,102✔
4402
    if (taosArrayPush(vgReqs.pBatchReqs, &batchReq) == NULL) {
48,204✔
UNCOV
4403
      taosArrayDestroy(batchReq.pArray);
×
UNCOV
4404
      return terrno;
×
4405
    }
4406
    if (taosHashPut(pVgHashMap, &pVgInfo->vgId, sizeof(pVgInfo->vgId), &vgReqs, sizeof(vgReqs)) != 0) {
24,102✔
UNCOV
4407
      taosArrayDestroyEx(vgReqs.pBatchReqs, destroySVDropTbBatchReqs);
×
UNCOV
4408
      return terrno;
×
4409
    }
4410
  } else {
4411
    SVDropTbBatchReq batchReq = {0};
74,966✔
4412
    int32_t          code = createDropTbBatchReq(&req, &batchReq);
74,966✔
4413
    if (TSDB_CODE_SUCCESS != code) return code;
74,966✔
4414
    if (taosArrayPush(pVgReqs->pBatchReqs, &batchReq) == NULL) {
149,932✔
UNCOV
4415
      taosArrayDestroy(batchReq.pArray);
×
UNCOV
4416
      return terrno;
×
4417
    }
4418
  }
4419
  return 0;
99,068✔
4420
}
4421

4422
static int32_t mndDropTbForSingleVg(SMnode *pMnode, SMndDropTbsWithTsmaCtx *pCtx, SArray *pTbs, int32_t vgId) {
24,102✔
4423
  int32_t code = 0;
24,102✔
4424

4425
  SVgObj *pVgObj = mndAcquireVgroup(pMnode, vgId);
24,102✔
4426
  if (!pVgObj) {
24,102✔
UNCOV
4427
    code = 0;
×
UNCOV
4428
    goto _end;
×
4429
  }
4430
  SVgroupInfo vgInfo = {.hashBegin = pVgObj->hashBegin,
48,204✔
4431
                        .hashEnd = pVgObj->hashEnd,
24,102✔
4432
                        .numOfTable = pVgObj->numOfTables,
24,102✔
4433
                        .vgId = pVgObj->vgId};
24,102✔
4434
  vgInfo.epSet = mndGetVgroupEpset(pMnode, pVgObj);
24,102✔
4435
  mndReleaseVgroup(pMnode, pVgObj);
24,102✔
4436

4437
  for (int32_t i = 0; i < pTbs->size; ++i) {
123,170✔
4438
    SVDropTbReq *pTb = taosArrayGet(pTbs, i);
99,068✔
4439
    TAOS_CHECK_GOTO(mndDropTbAdd(pMnode, pCtx->pVgMap, &vgInfo, pTb->name, pTb->suid, pTb->igNotExists), NULL, _end);
99,068✔
4440
  }
4441
_end:
24,102✔
4442
  return code;
24,102✔
4443
}
4444

4445
static int32_t mndProcessFetchTtlExpiredTbs(SRpcMsg *pRsp) {
23,605,448✔
4446
  int32_t                 code = -1;
23,605,448✔
4447
  SDecoder                decoder = {0};
23,605,448✔
4448
  SMnode                 *pMnode = pRsp->info.node;
23,605,448✔
4449
  SVFetchTtlExpiredTbsRsp rsp = {0};
23,605,448✔
4450
  SMndDropTbsWithTsmaCtx *pCtx = NULL;
23,605,448✔
4451
  if (pRsp->code != TSDB_CODE_SUCCESS) {
23,605,448✔
4452
    code = pRsp->code;
180,838✔
4453
    goto _end;
180,838✔
4454
  }
4455
  if (pRsp->contLen == 0) {
23,424,610✔
4456
    code = 0;
23,400,508✔
4457
    goto _end;
23,400,508✔
4458
  }
4459

4460
  tDecoderInit(&decoder, pRsp->pCont, pRsp->contLen);
24,102✔
4461
  code = tDecodeVFetchTtlExpiredTbsRsp(&decoder, &rsp);
24,102✔
4462
  if (code) goto _end;
24,102✔
4463

4464
  code = mndInitDropTbsWithTsmaCtx(&pCtx);
24,102✔
4465
  if (code) goto _end;
24,102✔
4466

4467
  code = mndDropTbForSingleVg(pMnode, pCtx, rsp.pExpiredTbs, rsp.vgId);
24,102✔
4468
  if (code) goto _end;
24,102✔
4469
  code = mndCreateDropTbsTxnPrepare(pRsp, pCtx);
24,102✔
4470
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
24,102✔
4471
_end:
23,603,242✔
4472
  if (pCtx) mndDestroyDropTbsWithTsmaCtx(pCtx);
23,605,448✔
4473
  tDecoderClear(&decoder);
23,605,448✔
4474
  tFreeFetchTtlExpiredTbsRsp(&rsp);
23,605,448✔
4475
  TAOS_RETURN(code);
23,605,448✔
4476
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc