23138432878

Committed 16 Mar 2026 10:09AM UTC coverage: 15.99% (+0.2%) from 15.811%

Build # 23138432878

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #402 from knowledgepixels/fix/401-bounded-api-cache

Fix unbounded memory growth and resource exhaustion

Coverage Stats

717 of 5509 branches covered (13.02%)

Branch coverage included in aggregate %.

1810 of 10295 relevant lines covered (17.58%)

2.39 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

46.77

src/main/java/com/knowledgepixels/nanodash/page/NanodashPage.java

package com.knowledgepixels.nanodash.page;

import com.knowledgepixels.nanodash.NanodashPreferences;
import com.knowledgepixels.nanodash.NanodashThreadPool;
import com.knowledgepixels.nanodash.Utils;
import com.knowledgepixels.nanodash.WicketApplication;
import com.knowledgepixels.nanodash.domain.*;
import com.knowledgepixels.nanodash.template.TemplateData;
import org.apache.wicket.markup.head.CssHeaderItem;
import org.apache.wicket.markup.head.IHeaderResponse;
import org.apache.wicket.markup.head.JavaScriptHeaderItem;
import org.apache.wicket.markup.head.JavaScriptReferenceHeaderItem;
import org.apache.wicket.markup.html.WebPage;
import org.apache.wicket.request.flow.RedirectToUrlException;
import org.apache.wicket.request.mapper.parameter.PageParameters;
import org.apache.wicket.request.resource.JavaScriptResourceReference;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.util.ResourceBundle;

/**
 * Abstract base class for Nanodash pages.
 * Provides functionality for auto-refreshing data and rendering JavaScript resources.
 */
public abstract class NanodashPage extends WebPage {

    private static final Logger logger = LoggerFactory.getLogger(NanodashPage.class);

    private static long lastRefresh = 0L;
    private static final long REFRESH_INTERVAL = 60 * 1000; // 1 minute
    private static boolean refreshRunning = false;

    private long state = 0L;

    private static JavaScriptResourceReference nanodashJs = new JavaScriptResourceReference(WicketApplication.class, "script/nanodash.js");

    /**
     * Returns the mount path for this page.
     *
     * @return the mount path as a String
     */
    public abstract String getMountPath();

    /**
     * Constructor for NanodashPage.
     *
     * @param parameters the page parameters
     */
    protected NanodashPage(PageParameters parameters) {
        super(parameters);
        ensureRefreshed();
    }

    private void ensureRefreshed() {
        synchronized (getClass()) {
            state = lastRefresh;
            if (!refreshRunning && System.currentTimeMillis() - lastRefresh > REFRESH_INTERVAL) {
                lastRefresh = System.currentTimeMillis();
                refreshRunning = true;
                NanodashThreadPool.submit(() -> {
                    try {
                        logger.info("Refreshing data...");
                        User.refreshUsers();
                        TemplateData.refreshTemplates();
                        Space.refresh();
                        MaintainedResource.refresh();
                        AbstractResourceWithProfile.refresh();
                        Project.refresh();
                        logger.info("Refreshing data... done");
                        lastRefresh = System.currentTimeMillis();
                    } catch (Exception ex) {
                        logger.error("Error during refresh", ex);
                    } finally {
                        refreshRunning = false;
                    }
                });
            }
        }
    }

    /**
     * Checks if auto-refresh is enabled for this page.
     * Override this method in subclasses to enable auto-refresh.
     *
     * @return true if auto-refresh is enabled, false otherwise
     */
    protected boolean hasAutoRefreshEnabled() {
        return false;
    }

    /**
     * {@inheritDoc}
     */
    @Override
    protected void onRender() {
        if (hasAutoRefreshEnabled() && state < lastRefresh) {
            throw new RedirectToUrlException(getMountPath() + "?" + Utils.getPageParametersAsString(getPageParameters()));
        }
        super.onRender();
    }

    /**
     * {@inheritDoc}
     * <p>
     * Renders the head section of the page, including JavaScript references.
     */
    @Override
    public void renderHead(IHeaderResponse response) {
        super.renderHead(response);
        String version = ResourceBundle.getBundle("nanodash").getString("nanodash.version");
        response.render(CssHeaderItem.forUrl("style.css?v=" + version));
        response.render(JavaScriptHeaderItem.forReference(getApplication().getJavaScriptLibrarySettings().getJQueryReference()));
        response.render(JavaScriptReferenceHeaderItem.forReference(nanodashJs));
        String umamiScriptUrl = NanodashPreferences.get().getUmamiScriptUrl();
        String umamiWebsiteId = NanodashPreferences.get().getUmamiWebsiteId();
        if (umamiScriptUrl != null && !umamiScriptUrl.isBlank()
            && umamiWebsiteId != null && !umamiWebsiteId.isBlank()) {
            String umamiJs = "(function(){" +
                             "var s=document.createElement('script');" +
                             "s.src='" + umamiScriptUrl + "';" +
                             "s.defer=true;" +
                             "s.setAttribute('data-website-id','" + umamiWebsiteId + "');" +
                             "document.head.appendChild(s);" +
                             "})();";
            response.render(JavaScriptHeaderItem.forScript(umamiJs, "umami-loader"));
        }
    }

}

1	package com.knowledgepixels.nanodash.page;
2
3	import com.knowledgepixels.nanodash.NanodashPreferences;
4	import com.knowledgepixels.nanodash.NanodashThreadPool;
5	import com.knowledgepixels.nanodash.Utils;
6	import com.knowledgepixels.nanodash.WicketApplication;
7	import com.knowledgepixels.nanodash.domain.*;
8	import com.knowledgepixels.nanodash.template.TemplateData;
9	import org.apache.wicket.markup.head.CssHeaderItem;
10	import org.apache.wicket.markup.head.IHeaderResponse;
11	import org.apache.wicket.markup.head.JavaScriptHeaderItem;
12	import org.apache.wicket.markup.head.JavaScriptReferenceHeaderItem;
13	import org.apache.wicket.markup.html.WebPage;
14	import org.apache.wicket.request.flow.RedirectToUrlException;
15	import org.apache.wicket.request.mapper.parameter.PageParameters;
16	import org.apache.wicket.request.resource.JavaScriptResourceReference;
17	import org.slf4j.Logger;
18	import org.slf4j.LoggerFactory;
19
20	import java.util.ResourceBundle;
21
22	/**
23	* Abstract base class for Nanodash pages.
24	* Provides functionality for auto-refreshing data and rendering JavaScript resources.
25	*/
26	public abstract class NanodashPage extends WebPage {
27
28	private static final Logger logger = LoggerFactory.getLogger(NanodashPage.class);	9✔
29
30	private static long lastRefresh = 0L;	6✔
31	private static final long REFRESH_INTERVAL = 60 * 1000; // 1 minute
32	private static boolean refreshRunning = false;	6✔
33
34	private long state = 0L;	9✔
35
36	private static JavaScriptResourceReference nanodashJs = new JavaScriptResourceReference(WicketApplication.class, "script/nanodash.js");	21✔
37
38	/**
39	* Returns the mount path for this page.
40	*
41	* @return the mount path as a String
42	*/
43	public abstract String getMountPath();
44
45	/**
46	* Constructor for NanodashPage.
47	*
48	* @param parameters the page parameters
49	*/
50	protected NanodashPage(PageParameters parameters) {
51	super(parameters);	9✔
52	ensureRefreshed();	6✔
53	}	3✔
54
55	private void ensureRefreshed() {
56	synchronized (getClass()) {	15✔
57	state = lastRefresh;	9✔
58	if (!refreshRunning && System.currentTimeMillis() - lastRefresh > REFRESH_INTERVAL) {	24!
59	lastRefresh = System.currentTimeMillis();	6✔
60	refreshRunning = true;	6✔
61	NanodashThreadPool.submit(() -> {	9✔
62	try {
63	logger.info("Refreshing data...");	9✔
64	User.refreshUsers();	3✔
65	TemplateData.refreshTemplates();	3✔
66	Space.refresh();	3✔
67	MaintainedResource.refresh();	3✔
68	AbstractResourceWithProfile.refresh();	3✔
69	Project.refresh();	3✔
70	logger.info("Refreshing data... done");	9✔
71	lastRefresh = System.currentTimeMillis();	6✔
72	} catch (Exception ex) {	×
73	logger.error("Error during refresh", ex);	×
74	} finally {
75	refreshRunning = false;	6✔
76	}
77	});	3✔
78	}
79	}	9✔
80	}	3✔
81
82	/**
83	* Checks if auto-refresh is enabled for this page.
84	* Override this method in subclasses to enable auto-refresh.
85	*
86	* @return true if auto-refresh is enabled, false otherwise
87	*/
88	protected boolean hasAutoRefreshEnabled() {
89	return false;	×
90	}
91
92	/**
93	* {@inheritDoc}
94	*/
95	@Override
96	protected void onRender() {
97	if (hasAutoRefreshEnabled() && state < lastRefresh) {	×
98	throw new RedirectToUrlException(getMountPath() + "?" + Utils.getPageParametersAsString(getPageParameters()));	×
99	}
100	super.onRender();	×
101	}	×
102
103	/**
104	* {@inheritDoc}
105	* <p>
106	* Renders the head section of the page, including JavaScript references.
107	*/
108	@Override
109	public void renderHead(IHeaderResponse response) {
110	super.renderHead(response);	×
111	String version = ResourceBundle.getBundle("nanodash").getString("nanodash.version");	×
112	response.render(CssHeaderItem.forUrl("style.css?v=" + version));	×
113	response.render(JavaScriptHeaderItem.forReference(getApplication().getJavaScriptLibrarySettings().getJQueryReference()));	×
114	response.render(JavaScriptReferenceHeaderItem.forReference(nanodashJs));	×
115	String umamiScriptUrl = NanodashPreferences.get().getUmamiScriptUrl();	×
116	String umamiWebsiteId = NanodashPreferences.get().getUmamiWebsiteId();	×
117	if (umamiScriptUrl != null && !umamiScriptUrl.isBlank()	×
118	&& umamiWebsiteId != null && !umamiWebsiteId.isBlank()) {	×
119	String umamiJs = "(function(){" +	×
120	"var s=document.createElement('script');" +
121	"s.src='" + umamiScriptUrl + "';" +
122	"s.defer=true;" +
123	"s.setAttribute('data-website-id','" + umamiWebsiteId + "');" +
124	"document.head.appendChild(s);" +
125	"})();";
126	response.render(JavaScriptHeaderItem.forScript(umamiJs, "umami-loader"));	×
127	}
128	}	×
129
130	}

knowledgepixels / nanodash / 23138432878

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous