• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4985

15 Mar 2026 07:43AM UTC coverage: 68.601% (-0.04%) from 68.643%
#4985

push

travis-ci

web-flow
feat(stream): add natural time units support for PERIOD trigger (#34766)

Implement week/month/year units for stream PERIOD trigger with natural
boundary alignment and offset support.

Key changes:
- Parser: Add validation for natural time units (w/n/y) and offset parameter
- Time utilities: Add getDuration() support for week/month/year units
- TriggerTask: Implement window calculation with natural boundary alignment
  - Week: align to Monday 00:00:00
  - Month: align to 1st of month 00:00:00
  - Year: align to Jan 1st 00:00:00
- Add offset support: PERIOD(1w, 1d) shifts window by 1 day
- Unit tests: Parser validation, time utilities, TriggerTask window calculation
- System tests: End-to-end tests for week/month/year units with offset
- Documentation: Update user manual with natural time unit examples

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

2 of 60 new or added lines in 2 files covered. (3.33%)

448 existing lines in 114 files now uncovered.

212624 of 309941 relevant lines covered (68.6%)

136450774.73 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.17
/source/client/src/clientSmlLine.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include <ctype.h>
17
#include <stdio.h>
18
#include <stdlib.h>
19
#include <string.h>
20

21
#include "clientSml.h"
22

23
#define IS_COMMA(sql,escapeChar) (*(sql) == COMMA && (*((sql)-1) != SLASH || ((sql)-1 == escapeChar)))
24
#define IS_SPACE(sql,escapeChar) (*(sql) == SPACE && (*((sql)-1) != SLASH || ((sql)-1 == escapeChar)))
25
#define IS_EQUAL(sql,escapeChar) (*(sql) == EQUAL && (*((sql)-1) != SLASH || ((sql)-1 == escapeChar)))
26

27
#define IS_SLASH_LETTER_IN_FIELD_VALUE(sql) (*((sql)-1) == SLASH && (*(sql) == QUOTE || *(sql) == SLASH))
28

29
#define IS_SLASH_LETTER_IN_TAG_FIELD_KEY(sql) \
30
  (*((sql)-1) == SLASH && (*(sql) == COMMA || *(sql) == SPACE || *(sql) == EQUAL || *(sql) == SLASH))
31

32
#define PROCESS_SLASH_IN_FIELD_VALUE(key, keyLen)  \
33
  for (int i = 1; i < keyLen; ++i) {               \
34
    if (IS_SLASH_LETTER_IN_FIELD_VALUE(key + i)) { \
35
      MOVE_FORWARD_ONE(key + i, keyLen - i);       \
36
      keyLen--;                                    \
37
    }                                              \
38
  }
39

40
#define PROCESS_SLASH_IN_TAG_FIELD_KEY(key, keyLen)  \
41
  for (int i = 1; i < keyLen; ++i) {                 \
42
    if (IS_SLASH_LETTER_IN_TAG_FIELD_KEY(key + i)) { \
43
      MOVE_FORWARD_ONE(key + i, keyLen - i);         \
44
      keyLen--;                                      \
45
    }                                                \
46
  }
47

48
#define BINARY_ADD_LEN (sizeof("\"\"")-1)    // "binary"   2 means length of ("")
49
#define NCHAR_ADD_LEN  (sizeof("L\"\"")-1)   // L"nchar"   3 means length of (L"")
50

51
uint8_t smlPrecisionConvert[] = {TSDB_TIME_PRECISION_NANO,    TSDB_TIME_PRECISION_HOURS, TSDB_TIME_PRECISION_MINUTES,
52
                                  TSDB_TIME_PRECISION_SECONDS, TSDB_TIME_PRECISION_MILLI, TSDB_TIME_PRECISION_MICRO,
53
                                  TSDB_TIME_PRECISION_NANO};
54

55
static int64_t smlParseInfluxTime(SSmlHandle *info, const char *data, int32_t len) {
4,258,341✔
56
  uint8_t toPrecision = info->currSTableMeta ? info->currSTableMeta->tableInfo.precision : TSDB_TIME_PRECISION_NANO;
4,258,341✔
57

58
  if (unlikely(len == 0 || (len == 1 && data[0] == '0'))) {
4,260,203✔
59
    return taosGetTimestampNs() / smlFactorNS[toPrecision];
18,528✔
60
  }
61

62
  uint8_t fromPrecision = smlPrecisionConvert[info->precision];
4,250,939✔
63

64
  int64_t ts = smlGetTimeValue(data, len, fromPrecision, toPrecision);
4,284,265✔
65
  if (unlikely(ts == -1)) {
4,254,435✔
66
    smlBuildInvalidDataMsg(&info->msgBuf, "SML line invalid timestamp", data);
2,320✔
67
    return TSDB_CODE_SML_INVALID_DATA;
2,320✔
68
  }
69
  return ts;
4,252,115✔
70
}
71

72
int32_t smlParseValue(SSmlKv *pVal, SSmlMsgBuf *msg) {
25,010,239✔
73
  if (pVal->value[0] == '"') {  // binary
25,010,239✔
74
    if (pVal->length >= 2 && pVal->value[pVal->length - 1] == '"') {
3,368,327✔
75
      pVal->type = TSDB_DATA_TYPE_BINARY;
3,368,365✔
76
      pVal->length -= BINARY_ADD_LEN;
3,368,289✔
77
      if (pVal->length > TSDB_MAX_BINARY_LEN - VARSTR_HEADER_SIZE) {
3,347,161✔
78
        return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
1,160✔
79
      }
80
      pVal->value += (BINARY_ADD_LEN - 1);
3,367,243✔
81
      return TSDB_CODE_SUCCESS;
3,367,243✔
82
    }
83
    return TSDB_CODE_TSC_INVALID_VALUE;
×
84
  }
85

86
  if (pVal->value[0] == 'l' || pVal->value[0] == 'L') {  // nchar
21,917,640✔
87
    if (pVal->length >= NCHAR_ADD_LEN && pVal->value[1] == '"' && pVal->value[pVal->length - 1] == '"') {
226,943✔
88
      pVal->type = TSDB_DATA_TYPE_NCHAR;
242,270✔
89
      pVal->length -= NCHAR_ADD_LEN;
242,270✔
90
      if (pVal->length > (TSDB_MAX_NCHAR_LEN - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE) {
242,270✔
91
        return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
580✔
92
      }
93
      pVal->value += (NCHAR_ADD_LEN - 1);
241,690✔
94
      return TSDB_CODE_SUCCESS;
241,690✔
95
    }
96
    return TSDB_CODE_TSC_INVALID_VALUE;
×
97
  }
98

99
  if (pVal->value[0] == 'g' || pVal->value[0] == 'G') {  // geometry
21,622,563✔
100
#ifdef USE_GEOS
101
    if (pVal->length >= NCHAR_ADD_LEN && pVal->value[1] == '"' && pVal->value[pVal->length - 1] == '"') {
6,492✔
102
      int32_t code = initCtxGeomFromText();
6,948✔
103
      if (code != TSDB_CODE_SUCCESS) {
6,948✔
104
        return code;
×
105
      }
106
      char *tmp = taosMemoryCalloc(pVal->length, 1);
6,948✔
107
      if (tmp == NULL) {
6,948✔
108
        return terrno;
×
109
      }
110
      (void)memcpy(tmp, pVal->value + NCHAR_ADD_LEN - 1, pVal->length - NCHAR_ADD_LEN);
6,948✔
111
      code = doGeomFromText(tmp, (unsigned char **)&pVal->value, &pVal->length);
6,948✔
112
      taosMemoryFree(tmp);
6,948✔
113
      if (code != TSDB_CODE_SUCCESS) {
6,948✔
114
        return code;
1,158✔
115
      }
116

117
      pVal->type = TSDB_DATA_TYPE_GEOMETRY;
5,790✔
118
      if (pVal->length > TSDB_MAX_BINARY_LEN - VARSTR_HEADER_SIZE) {
5,790✔
119
        geosFreeBuffer((void *)(pVal->value));
×
120
        return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
121
      }
122
      return TSDB_CODE_SUCCESS;
5,790✔
123
    }
124
    return TSDB_CODE_TSC_INVALID_VALUE;
×
125
#else
126
    return TSDB_CODE_OPS_NOT_SUPPORT;
127
#endif
128
  }
129

130
  if (pVal->value[0] == 'b' || pVal->value[0] == 'B') {  // varbinary
21,720,584✔
131
    if (pVal->length >= NCHAR_ADD_LEN && pVal->value[1] == '"' && pVal->value[pVal->length - 1] == '"') {
78,650✔
132
      pVal->type = TSDB_DATA_TYPE_VARBINARY;
11,580✔
133
      if(isHex(pVal->value + NCHAR_ADD_LEN - 1, pVal->length - NCHAR_ADD_LEN)){
11,580✔
134
        if(!isValidateHex(pVal->value + NCHAR_ADD_LEN - 1, pVal->length - NCHAR_ADD_LEN)){
1,158✔
135
          return TSDB_CODE_PAR_INVALID_VARBINARY;
×
136
        }
137

138
        void* data = NULL;
1,158✔
139
        uint32_t size = 0;
1,158✔
140
        if(taosHex2Ascii(pVal->value + NCHAR_ADD_LEN - 1, pVal->length - NCHAR_ADD_LEN, &data, &size) < 0){
1,158✔
141
          return terrno;
×
142
        }
143

144
        if (size + VARSTR_HEADER_SIZE > TSDB_MAX_VARBINARY_LEN) {
1,158✔
145
          taosMemoryFree(data);
×
146
          return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
147
        }
148
        pVal->value  = data;
1,158✔
149
        pVal->length = size;
1,158✔
150
      }else{
151
        pVal->length -= NCHAR_ADD_LEN;
10,422✔
152
        if (pVal->length > TSDB_MAX_VARBINARY_LEN - VARSTR_HEADER_SIZE) {
10,422✔
153
          return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
154
        }
155
        void *data = taosMemoryMalloc(pVal->length);
10,422✔
156
        if(data == NULL){
10,422✔
157
          return terrno;
×
158
        }
159
        (void)memcpy(data, pVal->value + (NCHAR_ADD_LEN - 1), pVal->length);
10,422✔
160
        pVal->value = data;
10,422✔
161
      }
162

163
      return TSDB_CODE_SUCCESS;
11,580✔
164
    }
165
    return TSDB_CODE_TSC_INVALID_VALUE;
×
166
  }
167

168
  if (pVal->value[0] == 't' || pVal->value[0] == 'T') {
21,687,382✔
169
    if (pVal->length == 1 ||
5,016,098✔
170
        (pVal->length == 4 && (pVal->value[1] == 'r' || pVal->value[1] == 'R') &&
98,579✔
171
         (pVal->value[2] == 'u' || pVal->value[2] == 'U') && (pVal->value[3] == 'e' || pVal->value[3] == 'E'))) {
98,579✔
172
      pVal->i = TSDB_TRUE;
4,923,543✔
173
      pVal->type = TSDB_DATA_TYPE_BOOL;
4,923,543✔
174
      pVal->length = (int16_t)tDataTypes[pVal->type].bytes;
4,923,543✔
175
      return TSDB_CODE_SUCCESS;
4,923,543✔
176
    }
177
    return TSDB_CODE_TSC_INVALID_VALUE;
×
178
  }
179

180
  if (pVal->value[0] == 'f' || pVal->value[0] == 'F') {
16,700,164✔
181
    if (pVal->length == 1 ||
372,278✔
182
        (pVal->length == 5 && (pVal->value[1] == 'a' || pVal->value[1] == 'A') &&
230,547✔
183
         (pVal->value[2] == 'l' || pVal->value[2] == 'L') && (pVal->value[3] == 's' || pVal->value[3] == 'S') &&
230,573✔
184
         (pVal->value[4] == 'e' || pVal->value[4] == 'E'))) {
230,573✔
185
      pVal->i = TSDB_FALSE;
354,026✔
186
      pVal->type = TSDB_DATA_TYPE_BOOL;
354,026✔
187
      pVal->length = (int16_t)tDataTypes[pVal->type].bytes;
354,026✔
188
      return TSDB_CODE_SUCCESS;
354,026✔
189
    }
UNCOV
190
    return TSDB_CODE_TSC_INVALID_VALUE;
×
191
  }
192

193
  // number
194
  if (smlParseNumber(pVal, msg)) {
16,431,588✔
195
    pVal->length = (int16_t)tDataTypes[pVal->type].bytes;
16,303,085✔
196
    return TSDB_CODE_SUCCESS;
16,375,551✔
197
  }
198

199
  return TSDB_CODE_TSC_INVALID_VALUE;
19,720✔
200
}
201

202
static int32_t smlProcessTagLine(SSmlHandle *info, char **sql, char *sqlEnd){
487,834✔
203
  SArray *preLineKV = info->preLineTagKV;
487,834✔
204
  taosArrayClearEx(preLineKV, freeSSmlKv);
487,834✔
205
  int     cnt = 0;
487,834✔
206

207
  while (*sql < sqlEnd) {
2,886,803✔
208
    if (unlikely(IS_SPACE(*sql,NULL))) {
2,886,803✔
209
      break;
99,189✔
210
    }
211

212
    // parse key
213
    const char *key = *sql;
2,789,039✔
214
    size_t      keyLen = 0;
2,789,077✔
215
    bool        keyEscaped = false;
2,789,077✔
216
    size_t      keyLenEscaped = 0;
2,789,077✔
217
    const char *escapeChar = NULL;
2,789,077✔
218

219
    while (*sql < sqlEnd) {
10,908,328✔
220
      if (unlikely(IS_SPACE(*sql,escapeChar) || IS_COMMA(*sql,escapeChar))) {
10,907,606✔
221
        smlBuildInvalidDataMsg(&info->msgBuf, "invalid data", *sql);
1,158✔
222
        return TSDB_CODE_SML_INVALID_DATA;
1,158✔
223
      }
224
      if (unlikely(IS_EQUAL(*sql,escapeChar))) {
10,906,296✔
225
        keyLen = *sql - key;
2,787,881✔
226
        (*sql)++;
2,787,881✔
227
        break;
2,787,919✔
228
      }
229
      if (IS_SLASH_LETTER_IN_TAG_FIELD_KEY(*sql)) {
8,119,213✔
230
        escapeChar = *sql;
5,790✔
231
        keyLenEscaped++;
5,790✔
232
        keyEscaped = true;
5,790✔
233
      }
234
      (*sql)++;
8,119,213✔
235
    }
236

237
    if (unlikely(IS_INVALID_COL_LEN(keyLen - keyLenEscaped))) {
2,787,957✔
238
      smlBuildInvalidDataMsg(&info->msgBuf, "invalid key or key is too long than 64", key);
×
239
      return TSDB_CODE_TSC_INVALID_COLUMN_LENGTH;
×
240
    }
241

242
    // parse value
243
    const char *value = *sql;
2,787,957✔
244
    size_t      valueLen = 0;
2,787,957✔
245
    bool        valueEscaped = false;
2,787,957✔
246
    size_t      valueLenEscaped = 0;
2,787,957✔
247
    while (*sql < sqlEnd) {
56,560,893✔
248
      // parse value
249
      if (unlikely(IS_SPACE(*sql,escapeChar) || IS_COMMA(*sql,escapeChar))) {
56,560,627✔
250
        break;
2,786,799✔
251
      } else if (unlikely(IS_EQUAL(*sql,escapeChar))) {
53,774,018✔
252
        smlBuildInvalidDataMsg(&info->msgBuf, "invalid data", *sql);
1,158✔
253
        return TSDB_CODE_SML_INVALID_DATA;
1,158✔
254
      }
255

256
      if (IS_SLASH_LETTER_IN_TAG_FIELD_KEY(*sql)) {
53,772,936✔
257
        escapeChar = *sql;
8,106✔
258
        valueLenEscaped++;
8,106✔
259
        valueEscaped = true;
8,106✔
260
      }
261

262
      (*sql)++;
53,772,822✔
263
    }
264
    valueLen = *sql - value;
2,786,723✔
265

266
    if (unlikely(valueLen == 0)) {
2,786,761✔
267
      smlBuildInvalidDataMsg(&info->msgBuf, "invalid value", value);
×
268
      return TSDB_CODE_SML_INVALID_DATA;
×
269
    }
270

271
    if (unlikely(valueLen - valueLenEscaped > (TSDB_MAX_NCHAR_LEN - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE)) {
2,786,799✔
272
      return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
273
    }
274

275
    if (keyEscaped) {
2,786,799✔
276
      char *tmp = (char *)taosMemoryMalloc(keyLen);
2,316✔
277
      if (tmp == NULL){
2,316✔
278
        return terrno;
×
279
      }
280
      (void)memcpy(tmp, key, keyLen);
2,316✔
281
      PROCESS_SLASH_IN_TAG_FIELD_KEY(tmp, keyLen);
16,212✔
282
      key = tmp;
2,316✔
283
    }
284
    if (valueEscaped) {
2,786,799✔
285
      char *tmp = (char *)taosMemoryMalloc(valueLen);
4,632✔
286
      if (tmp == NULL){
4,632✔
287
        return terrno;
×
288
      }
289
      (void)memcpy(tmp, value, valueLen);
4,632✔
290
      PROCESS_SLASH_IN_TAG_FIELD_KEY(tmp, valueLen);
22,002✔
291
      value = tmp;
4,632✔
292
    }
293
    SSmlKv kv = {.key = key,
2,786,799✔
294
        .keyLen = keyLen,
295
        .type = TSDB_DATA_TYPE_NCHAR,
296
        .value = value,
297
        .length = valueLen,
298
        .keyEscaped = keyEscaped,
299
        .valueEscaped = valueEscaped};
300
    if(taosArrayPush(preLineKV, &kv) == NULL){
2,786,824✔
301
      return terrno;
×
302
    }
303

304
    if (info->dataFormat && !isSmlTagAligned(info, cnt, &kv)) {
2,786,824✔
305
      return TSDB_CODE_SML_INVALID_DATA;
12,373✔
306
    }
307

308
    cnt++;
2,774,451✔
309
    if (IS_SPACE(*sql,escapeChar)) {
2,774,451✔
310
      break;
311
    }
312
    (*sql)++;
2,398,969✔
313
  }
314
  return TSDB_CODE_SUCCESS;
473,132✔
315
}
316

317
static int32_t smlParseTagLine(SSmlHandle *info, char **sql, char *sqlEnd, SSmlLineInfo *elements) {
4,513,649✔
318
  int32_t code = 0;
4,513,649✔
319
  int32_t lino = 0;
4,513,649✔
320
  bool isSameCTable = IS_SAME_CHILD_TABLE;
4,513,649✔
321
  if(isSameCTable){
4,506,809✔
322
    return TSDB_CODE_SUCCESS;
3,897,304✔
323
  }
324

325
  if(info->dataFormat){
609,505✔
326
    SML_CHECK_CODE(smlProcessSuperTable(info, elements));
196,192✔
327
  }
328
  SML_CHECK_CODE(smlProcessTagLine(info, sql, sqlEnd));
487,834✔
329
  return smlProcessChildTable(info, elements);
473,145✔
330

331
END:
147,988✔
332
  if(info->reRun){
147,988✔
333
    return TSDB_CODE_SUCCESS;
142,706✔
334
  }
335
  RETURN
5,282✔
336
}
337

338
static int32_t smlParseColLine(SSmlHandle *info, char **sql, char *sqlEnd, SSmlLineInfo *currElement) {
4,353,311✔
339
  int cnt = 0;
4,353,311✔
340
  while (*sql < sqlEnd) {
24,931,893✔
341
    if (unlikely(IS_SPACE(*sql,NULL))) {
24,994,916✔
342
      break;
6,805✔
343
    }
344

345
    // parse key
346
    const char *key = *sql;
25,000,958✔
347
    size_t      keyLen = 0;
24,997,082✔
348
    bool        keyEscaped = false;
24,997,082✔
349
    size_t      keyLenEscaped = 0;
24,997,082✔
350
    const char *escapeChar = NULL;
24,997,082✔
351
    while (*sql < sqlEnd) {
185,601,686✔
352
      if (unlikely(IS_SPACE(*sql,escapeChar) || IS_COMMA(*sql,escapeChar))) {
184,512,416✔
353
        smlBuildInvalidDataMsg(&info->msgBuf, "SML line invalid data", *sql);
2,318✔
354
        return TSDB_CODE_SML_INVALID_DATA;
2,849✔
355
      }
356
      if (unlikely(IS_EQUAL(*sql,escapeChar))) {
184,401,190✔
357
        keyLen = *sql - key;
24,963,300✔
358
        (*sql)++;
24,969,152✔
359
        break;
24,970,900✔
360
      }
361
      if (IS_SLASH_LETTER_IN_TAG_FIELD_KEY(*sql)) {
160,536,204✔
362
        escapeChar = *sql;
10,422✔
363
        keyLenEscaped++;
10,422✔
364
        keyEscaped = true;
10,422✔
365
      }
366
      (*sql)++;
160,299,616✔
367
    }
368

369
    if (unlikely(IS_INVALID_COL_LEN(keyLen - keyLenEscaped))) {
24,975,422✔
370
      smlBuildInvalidDataMsg(&info->msgBuf, "SML line invalid key or key is too long than 64", key);
×
371
      return TSDB_CODE_TSC_INVALID_COLUMN_LENGTH;
×
372
    }
373

374
    // parse value
375
    const char *value = *sql;
24,975,422✔
376
    size_t      valueLen = 0;
24,853,404✔
377
    bool        valueEscaped = false;
24,853,404✔
378
    size_t      valueLenEscaped = 0;
24,853,404✔
379
    int         quoteNum = 0;
24,853,404✔
380
    while (*sql < sqlEnd) {
724,798,457✔
381
      // parse value
382
      if (unlikely(*(*sql) == QUOTE && (*(*sql - 1) != SLASH || (*sql - 1) == escapeChar))) {
717,595,338✔
383
        quoteNum++;
7,165,550✔
384
        (*sql)++;
7,165,550✔
385
        if(quoteNum > 2){
7,173,606✔
386
          break;
×
387
        }
388
        continue;
7,173,606✔
389
      }
390
      if (quoteNum % 2 == 0 && (unlikely(IS_SPACE(*sql,escapeChar) || IS_COMMA(*sql,escapeChar)))) {
713,265,196✔
391
        break;
24,965,969✔
392
      }
393
      if (IS_SLASH_LETTER_IN_FIELD_VALUE(*sql) && (*sql - 1) != escapeChar) {
685,111,635✔
394
        escapeChar = *sql;
148,224✔
395
        valueEscaped = true;
148,224✔
396
        valueLenEscaped++;
148,224✔
397
      }
398

399
      (*sql)++;
691,532,495✔
400
    }
401
    valueLen = *sql - value;
30,197,344✔
402

403
    if (unlikely(quoteNum != 0 && quoteNum != 2)) {
24,910,936✔
404
      smlBuildInvalidDataMsg(&info->msgBuf, "SML line unbalanced quotes", value);
×
405
      return TSDB_CODE_SML_INVALID_DATA;
×
406
    }
407
    if (unlikely(valueLen == 0)) {
24,910,936✔
408
      smlBuildInvalidDataMsg(&info->msgBuf, "SML line invalid value", value);
×
409
      return TSDB_CODE_SML_INVALID_DATA;
×
410
    }
411

412
    SSmlKv  kv = {.key = key, .keyLen = keyLen, .value = value, .length = valueLen};
24,910,936✔
413
    int32_t ret = smlParseValue(&kv, &info->msgBuf);
24,739,936✔
414
    if (ret != TSDB_CODE_SUCCESS) {
24,993,856✔
415
      uError("SML:0x%" PRIx64 " %s parse value error:%d.", info->id, __FUNCTION__, ret);
12,771✔
416
      return ret;
12,758✔
417
    }
418

419
    if (keyEscaped) {
24,981,085✔
420
      char *tmp = (char *)taosMemoryMalloc(kv.keyLen);
3,474✔
421
      if (tmp == NULL){
3,474✔
422
        return terrno;
×
423
      }
424
      (void)memcpy(tmp, key, kv.keyLen);
3,474✔
425
      PROCESS_SLASH_IN_TAG_FIELD_KEY(tmp, kv.keyLen);
42,846✔
426
      kv.key = tmp;
3,474✔
427
      kv.keyEscaped = keyEscaped;
3,474✔
428
    }
429

430
    if (valueEscaped) {
24,981,085✔
431
      char *tmp = (char *)taosMemoryMalloc(kv.length);
4,632✔
432
      if (tmp == NULL){
4,632✔
433
        return terrno;
×
434
      }
435
      (void)memcpy(tmp, kv.value, kv.length);
4,632✔
436
      PROCESS_SLASH_IN_FIELD_VALUE(tmp, kv.length);
1,388,442✔
437
      if(kv.type == TSDB_DATA_TYPE_VARBINARY){
4,632✔
438
        taosMemoryFree((void*)kv.value);
×
439
      }
440
      kv.value = tmp;
4,632✔
441
      kv.valueEscaped = valueEscaped;
4,632✔
442
    }
443

444
    if (info->dataFormat) {
24,981,085✔
445
      bool isAligned = isSmlColAligned(info, cnt, &kv);
50,558✔
446
      if (kv.type == TSDB_DATA_TYPE_BINARY && valueEscaped) {
50,545✔
447
        if (taosArrayPush(info->escapedStringList, &kv.value) == NULL){
2,316✔
448
          freeSSmlKv(&kv);
×
449
          return terrno;
×
450
        }
451
        kv.value = NULL;
1,158✔
452
      }
453
      freeSSmlKv(&kv);
50,545✔
454
      if(!isAligned){
50,558✔
455
        return TSDB_CODE_SUCCESS;
50,558✔
456
      }
457
    } else {
458
      if (currElement->colArray == NULL) {
24,879,873✔
459
        currElement->colArray = taosArrayInit_s(sizeof(SSmlKv), 1);
4,307,883✔
460
        if (currElement->colArray == NULL) {
4,311,721✔
461
          freeSSmlKv(&kv);
×
462
          return terrno;
×
463
        }
464
      }
465
      if (taosArrayPush(currElement->colArray, &kv) == NULL){  // reserve for timestamp
49,861,608✔
466
        freeSSmlKv(&kv);
×
467
        return terrno;
×
468
      }
469
    }
470

471
    cnt++;
24,911,321✔
472
    if (IS_SPACE(*sql,escapeChar)) {
24,911,321✔
473
      break;
474
    }
475
    (*sql)++;
20,647,476✔
476
  }
477

478
  return TSDB_CODE_SUCCESS;
4,284,992✔
479
}
480

481
int32_t smlParseInfluxString(SSmlHandle *info, char *sql, char *sqlEnd, SSmlLineInfo *elements) {
4,482,033✔
482
  if (!sql) return TSDB_CODE_SML_INVALID_DATA;
4,482,033✔
483
  JUMP_SPACE(sql, sqlEnd)
4,482,033✔
484
  if (unlikely(*sql == COMMA)) return TSDB_CODE_SML_INVALID_DATA;
4,491,799✔
485
  elements->measure = sql;
4,511,141✔
486
  // parse measure
487
  size_t measureLenEscaped = 0;
4,516,993✔
488
  const char *escapeChar = NULL;
4,516,993✔
489
  while (sql < sqlEnd) {
32,481,843✔
490
    if (unlikely(IS_COMMA(sql,escapeChar) || IS_SPACE(sql,escapeChar))) {
32,355,822✔
491
      break;
4,506,606✔
492
    }
493

494
    if (unlikely((sql != elements->measure) && IS_SLASH_LETTER_IN_MEASUREMENT(sql))) {
27,903,100✔
495
      elements->measureEscaped = true;
10,422✔
496
      escapeChar = sql;
10,422✔
497
      measureLenEscaped++;
10,422✔
498
      sql++;
10,422✔
499
      continue;
10,422✔
500
    }
501
    sql++;
27,971,870✔
502
  }
503
  elements->measureLen = sql - elements->measure;
4,632,627✔
504
  if (unlikely(IS_INVALID_TABLE_LEN(elements->measureLen - measureLenEscaped))) {
4,509,127✔
505
    smlBuildInvalidDataMsg(&info->msgBuf, "SML line measure is empty or too large than 192", NULL);
×
506
    return TSDB_CODE_TSC_INVALID_TABLE_ID_LENGTH;
×
507
  }
508

509
  // to get measureTagsLen before
510
  const char *tmp = sql;
4,498,753✔
511
  while (tmp < sqlEnd) {
278,524,498✔
512
    if (unlikely(IS_SPACE(tmp,escapeChar))) {
276,637,456✔
513
      break;
4,515,055✔
514
    }
515
    if(unlikely(IS_SLASH_LETTER_IN_TAG_FIELD_KEY(tmp))){
272,909,039✔
516
      escapeChar = tmp;
32,424✔
517
    }
518
    tmp++;
273,873,175✔
519
  }
520
  elements->measureTagsLen = tmp - elements->measure;
6,402,097✔
521
  elements->measureTag = elements->measure;
4,512,585✔
522
  // parse tag
523
  if (*sql == COMMA) sql++;
4,519,045✔
524
  elements->tags = sql;
4,502,325✔
525

526
  int ret = smlParseTagLine(info, &sql, sqlEnd, elements);
4,519,045✔
527
  if (unlikely(ret != TSDB_CODE_SUCCESS)) {
4,519,273✔
528
    return ret;
5,282✔
529
  }
530
  if (unlikely(info->reRun)) {
4,513,991✔
531
    return TSDB_CODE_SUCCESS;
142,706✔
532
  }
533

534
  sql = elements->measure + elements->measureTagsLen;
4,371,779✔
535
  elements->tagsLen = sql - elements->tags;
4,376,529✔
536

537
  // parse cols
538
  JUMP_SPACE(sql, sqlEnd)
8,748,536✔
539
  elements->cols = sql;
4,395,605✔
540

541
  ret = smlParseColLine(info, &sql, sqlEnd, elements);
4,379,607✔
542
  if (unlikely(ret != TSDB_CODE_SUCCESS)) {
4,340,961✔
543
    return ret;
15,076✔
544
  }
545

546
  if (unlikely(info->reRun)) {
4,325,885✔
547
    return TSDB_CODE_SUCCESS;
50,558✔
548
  }
549

550
  elements->colsLen = sql - elements->cols;
4,276,809✔
551
  if (unlikely(elements->colsLen == 0)) {
4,296,303✔
552
    smlBuildInvalidDataMsg(&info->msgBuf, "SML line cols is empty", NULL);
×
553
    return TSDB_CODE_SML_INVALID_DATA;
×
554
  }
555

556
  // parse timestamp
557
  JUMP_SPACE(sql, sqlEnd)
8,475,384✔
558
  elements->timestamp = sql;
4,236,035✔
559
  while (sql < sqlEnd) {
60,856,713✔
560
    if (unlikely(isspace(*sql))) {
55,690,600✔
561
      break;
580✔
562
    }
563
    sql++;
56,555,698✔
564
  }
565
  elements->timestampLen = sql - elements->timestamp;
5,166,693✔
566

567
  int64_t ts = smlParseInfluxTime(info, elements->timestamp, elements->timestampLen);
4,300,065✔
568
  if (unlikely(ts <= 0)) {
4,262,217✔
569
    uError("SML:0x%" PRIx64 " %s error:%" PRId64, info->id, __FUNCTION__, ts);
2,320✔
570
    return TSDB_CODE_INVALID_TIMESTAMP;
2,320✔
571
  }
572

573
  SSmlKv kvTs = {0};
4,259,897✔
574
  smlBuildTsKv(&kvTs, ts);
4,259,213✔
575

576
  return smlParseEndLine(info, elements, &kvTs);
4,300,481✔
577
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc