• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4984

13 Mar 2026 03:38AM UTC coverage: 68.643% (-0.01%) from 68.653%
#4984

push

travis-ci

web-flow
feat/6641435300-save-audit-in-self (#34738)

434 of 584 new or added lines in 10 files covered. (74.32%)

3048 existing lines in 150 files now uncovered.

212713 of 309883 relevant lines covered (68.64%)

135561814.23 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

79.5
/source/dnode/vnode/src/tsdb/tsdbCacheRead.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "functionResInfo.h"
17
#include "taoserror.h"
18
#include "tarray.h"
19
#include "tcommon.h"
20
#include "tsdb.h"
21
#include "tsdbDataFileRW.h"
22
#include "tsdbReadUtil.h"
23

24
#define HASTYPE(_type, _t) (((_type) & (_t)) == (_t))
25

26
// empty blob string, used to rebuild blob column with empty value
27
static const char kEmptyBlobStr[1] = {0};
28

29
static int32_t setFirstLastResColToNull(SColumnInfoData* pCol, int32_t row) {
×
30
  int32_t        code = TSDB_CODE_SUCCESS;
×
31
  int32_t        lino = 0;
×
32
  char*          buf = NULL;
×
33
  SFirstLastRes* pRes = NULL;
×
34

35
  TSDB_CHECK_NULL(pCol, code, lino, _end, TSDB_CODE_INVALID_PARA);
×
36

37
  buf = taosMemoryCalloc(1, pCol->info.bytes);
×
38
  TSDB_CHECK_NULL(buf, code, lino, _end, terrno);
×
39

40
  pRes = (SFirstLastRes*)((char*)buf + VARSTR_HEADER_SIZE);
×
41
  pRes->bytes = 0;
×
42
  pRes->hasResult = true;
×
43
  pRes->isNull = true;
×
44
  varDataSetLen(buf, pCol->info.bytes - VARSTR_HEADER_SIZE);
×
45
  code = colDataSetVal(pCol, row, buf, false);
×
46
  TSDB_CHECK_CODE(code, lino, _end);
×
47

48
_end:
×
49
  if (code != TSDB_CODE_SUCCESS) {
×
50
    tsdbError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
51
  }
52
  if (buf != NULL) {
×
53
    taosMemoryFreeClear(buf);
×
54
  }
55
  return code;
×
56
}
57

58
typedef struct SLastColWithDstSlotId {
59
  SLastCol *col;
60
  int32_t  dstSlotId;
61
} SLastColWithDstSlotId;
62

63
int32_t tCompareLastColWithDstSlotId(const void* a, const void* b) {
2,656,606✔
64
  const SLastColWithDstSlotId* colA = (const SLastColWithDstSlotId*)a;
2,656,606✔
65
  const SLastColWithDstSlotId* colB = (const SLastColWithDstSlotId*)b;
2,656,606✔
66
  return -1 * tRowKeyCompare(&colA->col->rowKey, &colB->col->rowKey);
2,656,606✔
67
}
68

69
static int32_t saveMultiRows(SArray* pRow, SSDataBlock* pResBlock, 
956,300✔
70
  const int32_t* dstSlotIds, SCacheRowsReader* pr) {
71
  int32_t code = TSDB_CODE_SUCCESS;
956,300✔
72
  int32_t lino = 0;
956,300✔
73
  int32_t* nextRowIndex = NULL;
956,300✔
74
  SArray* pRowWithDstSlotId = NULL;
956,300✔
75

76
  TSDB_CHECK_NULL(pResBlock, code, lino, _end, TSDB_CODE_INVALID_PARA);
956,300✔
77
  if (pRow->size > 0) {
956,300✔
78
    TSDB_CHECK_NULL(dstSlotIds, code, lino, _end, TSDB_CODE_INVALID_PARA);
956,300✔
79
  }
80

81
  pRowWithDstSlotId = taosArrayInit(pRow->size, sizeof(SLastColWithDstSlotId));
956,300✔
82
  TSDB_CHECK_NULL(pRowWithDstSlotId, code, lino, _end, terrno);
956,300✔
83

84
  // sort pRow by ts and pk in descending order
85
  for (int32_t i = 0; i < pRow->size; ++i) {
3,121,565✔
86
    SLastColWithDstSlotId colWithDstSlotId = {0};
2,165,879✔
87
    colWithDstSlotId.col = taosArrayGet(pRow, i);
2,165,265✔
88
    colWithDstSlotId.dstSlotId = dstSlotIds[i];
2,165,265✔
89
    if (taosArrayPush(pRowWithDstSlotId, &colWithDstSlotId) == NULL) {
2,166,279✔
90
      code = terrno;
×
91
      TSDB_CHECK_CODE(code, lino, _end);
×
92
    }
93
  }
94
  taosArraySort(pRowWithDstSlotId, tCompareLastColWithDstSlotId);
955,686✔
95

96
  int32_t blockSize = taosArrayGetSize(pResBlock->pDataBlock);
956,300✔
97
  // row index of next row to fill value
98
  nextRowIndex = taosMemCalloc(blockSize, sizeof(int32_t));
956,300✔
99
  if (NULL == nextRowIndex) {
955,686✔
100
    code = terrno;
×
UNCOV
101
    TSDB_CHECK_CODE(code, lino, _end);
×
102
  }
103
  for (int32_t i = 0; i < blockSize; ++i) {
3,372,809✔
104
    nextRowIndex[i] = pResBlock->info.rows;
2,417,123✔
105
  }
106

107
  // assign sorted result to res datablock
108
  int64_t minTs = TSKEY_MAX;
955,686✔
109
  for (int32_t i = 0; i < pRowWithDstSlotId->size; ++i) {
3,121,351✔
110
    SLastColWithDstSlotId* pColWithDstSlotId = (SLastColWithDstSlotId*)taosArrayGet(pRowWithDstSlotId, i);
2,165,051✔
111
    SLastCol* pCol = pColWithDstSlotId->col;
2,165,879✔
112
    int32_t   dstSlotId = pColWithDstSlotId->dstSlotId;
2,165,879✔
113
    int64_t   colTs = pCol->rowKey.ts;
2,165,265✔
114
    if (TSKEY_MIN == colTs || COL_VAL_IS_NONE(&pCol->colVal)) {
2,164,651✔
115
      // if colTs equals to TSKEY_MIN, col value is null
116
      // mainly because this col has no cache or cache is invalid
117
      continue;
87,378✔
118
    }
119

120
    // update row index(row number) and minimal ts
121
    if (colTs < minTs) {
2,078,501✔
122
      // find smaller timestamp, which means a new row appears
123
      minTs = colTs;
986,121✔
124
      code = blockDataEnsureCapacity(pResBlock, pResBlock->info.rows+1);
986,121✔
125
      TSDB_CHECK_CODE(code, lino, _end);
985,293✔
126
      pResBlock->info.rows += 1;
985,293✔
127
    }
128
    int32_t rowIndex = pResBlock->info.rows - 1; // row index of this new row
2,078,287✔
129
    for (int32_t j = 0; j < blockSize; ++j) {
9,460,438✔
130
      SColumnInfoData* pDstCol = (SColumnInfoData*)taosArrayGet(pResBlock->pDataBlock, j);
7,382,551✔
131
      TSDB_CHECK_NULL(pDstCol, code, lino, _end, TSDB_CODE_INVALID_PARA);
7,382,151✔
132

133
      if (pDstCol->info.colId == PRIMARYKEY_TIMESTAMP_COL_ID && 
7,382,151✔
134
        pDstCol->info.type == TSDB_DATA_TYPE_TIMESTAMP) {
2,079,701✔
135
        // update timestamp column
136
        code = colDataSetVal(pDstCol, rowIndex, (const char*)&colTs, false);
2,078,901✔
137
        TSDB_CHECK_CODE(code, lino, _end);
2,078,501✔
138
        nextRowIndex[j] = rowIndex + 1;
2,078,501✔
139
      } else if (j == dstSlotId) {
5,303,864✔
140
        // update destinate column
141
        // 1. set previous rows to null
142
        for (int32_t prevRowIndex = nextRowIndex[j]; prevRowIndex < rowIndex; ++prevRowIndex) {
1,309,342✔
143
          colDataSetNULL(pDstCol, prevRowIndex);
145,015✔
144
          pDstCol->hasNull = true;
145,015✔
145
        }
146
        // 2. set current row to this value
147
        SColVal* pColVal = &pCol->colVal;
1,163,713✔
148
        if (IS_VAR_DATA_TYPE(pColVal->value.type)) {
1,164,327✔
149
          if (COL_VAL_IS_NULL(pColVal)) {
249,977✔
150
            colDataSetNULL(pDstCol, rowIndex);
17,604✔
151
          } else {
152
            if (IS_STR_DATA_BLOB(pColVal->value.type)) {
233,534✔
153
              int32_t dataLen = 0;
1,740✔
154
              uint8_t* pValue = NULL;
2,175✔
155
              code = doGetValueFromBseBySeq(pr->pVnode->pBse, pColVal->value.pData,
2,175✔
156
                                            pColVal->value.nData, &pValue, &dataLen);
2,175✔
157
              if (code == TSDB_CODE_SUCCESS) {
2,175✔
158
                if ((pValue == NULL && dataLen > 0) ||
2,175✔
159
                    (pValue != NULL && dataLen == 0)) {
2,175✔
160
                  /* invalid output from bse */
161
                  code = TSDB_CODE_INTERNAL_ERROR;
×
162
                } else if (dataLen == 0) {
2,175✔
163
                  /* empty blob */
164
                  code = varColSetVarData(pDstCol, rowIndex, kEmptyBlobStr, 0, false);
870✔
165
                } else {
166
                  /* normal blob */
167
                  code = varColSetVarData(pDstCol, rowIndex, (const char*)pValue, dataLen, false);
1,305✔
168
                }
169
              }
170
              taosMemFreeClear(pValue);
2,175✔
171
              TSDB_CHECK_CODE(code, lino, _end);
2,175✔
172
            } else {
173
              code = varColSetVarData(pDstCol, rowIndex, (const char*)pColVal->value.pData,
229,184✔
174
                                      pColVal->value.nData, false);
229,184✔
175
              TSDB_CHECK_CODE(code, lino, _end);
229,184✔
176
            }
177
          }
178
        } else {
179
          code = colDataSetVal(pDstCol, rowIndex,
913,550✔
180
            VALUE_GET_DATUM(&pColVal->value, pColVal->value.type), COL_VAL_IS_NULL(pColVal));
914,350✔
181
          TSDB_CHECK_CODE(code, lino, _end);
914,750✔
182
        }
183
        // 3. update nextRowIndex
184
        nextRowIndex[j] = rowIndex + 1;
1,163,713✔
185
      } else {
186
        // do nothing for other columns
187
      }
188
    }
189
  }
190

191
  // filling res datablock with NULL
192
  for (int32_t j = 0; j < blockSize; ++j) {
3,373,637✔
193
    SColumnInfoData* pDstCol = (SColumnInfoData*)taosArrayGet(pResBlock->pDataBlock, j);
2,417,123✔
194
    for (int32_t prevRowIndex = nextRowIndex[j]; prevRowIndex < pResBlock->info.rows; ++prevRowIndex) {
2,805,187✔
195
      colDataSetNULL(pDstCol, prevRowIndex);
388,464✔
196
      pDstCol->hasNull = true;
388,464✔
197
    }
198
  }
199

200
_end:
956,514✔
201
  if (code != TSDB_CODE_SUCCESS) {
956,514✔
202
    tsdbError("%s failed at line %d since %s, %s", __func__, lino, tstrerror(code), pr->idstr);
×
203
  }
204

205
  if (nextRowIndex != NULL) {
955,686✔
206
    taosMemFreeClear(nextRowIndex);
955,686✔
207
  }
208
  if (NULL != pRowWithDstSlotId) {
955,072✔
209
    taosArrayDestroy(pRowWithDstSlotId);
955,686✔
210
  }
211
  return code;
955,686✔
212
}
213

214
static int32_t setTableSchema(SCacheRowsReader* p, uint64_t suid, const char* idstr) {
852,420✔
215
  int32_t code = TSDB_CODE_SUCCESS;
852,420✔
216
  int32_t lino = 0;
852,420✔
217
  int32_t numOfTables = 0;
852,420✔
218

219
  TSDB_CHECK_NULL(p, code, lino, _end, TSDB_CODE_INVALID_PARA);
852,420✔
220

221
  numOfTables = p->numOfTables;
852,420✔
222

223
  if (suid != 0) {
851,806✔
224
    code = metaGetTbTSchemaNotNull(p->pVnode->pMeta, suid, -1, 1, &p->pSchema);
731,496✔
225
    if (TSDB_CODE_SUCCESS != code) {
732,110✔
226
      tsdbWarn("stable:%" PRIu64 " has been dropped, failed to retrieve cached rows, %s", suid, idstr);
×
227
      if (code == TSDB_CODE_NOT_FOUND) {
×
228
        code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
×
229
      }
230
      TSDB_CHECK_CODE(code, lino, _end);
×
231
    }
232
  } else {
233
    for (int32_t i = 0; i < numOfTables; ++i) {
120,310✔
234
      uint64_t uid = p->pTableList[i].uid;
120,310✔
235
      code = metaGetTbTSchemaMaybeNull(p->pVnode->pMeta, uid, -1, 1, &p->pSchema);
120,310✔
236
      TSDB_CHECK_CODE(code, lino, _end);
120,310✔
237
      if (p->pSchema != NULL) {
120,310✔
238
        break;
120,310✔
239
      }
240

241
      tsdbWarn("table:%" PRIu64 " has been dropped, failed to retrieve cached rows, %s", uid, idstr);
×
242
    }
243

244
    // all queried tables have been dropped already, return immediately.
245
    if (p->pSchema == NULL) {
120,310✔
246
      tsdbWarn("all queried tables has been dropped, try next group, %s", idstr);
×
247
      code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
×
248
      TSDB_CHECK_CODE(code, lino, _end);
×
249
    }
250
  }
251

252
_end:
120,310✔
253
  if (code != TSDB_CODE_SUCCESS) {
852,420✔
254
    tsdbError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
255
  }
256
  return code;
851,806✔
257
}
258

259
int32_t tsdbReuseCacherowsReader(void* reader, void* pTableIdList, int32_t numOfTables) {
11,518✔
260
  int32_t           code = TSDB_CODE_SUCCESS;
11,518✔
261
  int32_t           lino = 0;
11,518✔
262
  SCacheRowsReader* pReader = (SCacheRowsReader*)reader;
11,518✔
263

264
  TSDB_CHECK_NULL(pReader, code, lino, _end, TSDB_CODE_INVALID_PARA);
11,518✔
265

266
  pReader->pTableList = pTableIdList;
11,518✔
267
  pReader->numOfTables = numOfTables;
11,518✔
268
  pReader->lastTs = INT64_MIN;
11,518✔
269
  destroySttBlockReader(pReader->pLDataIterArray, NULL);
11,518✔
270
  pReader->pLDataIterArray = taosArrayInit(4, POINTER_BYTES);
11,518✔
271
  TSDB_CHECK_NULL(pReader->pLDataIterArray, code, lino, _end, terrno);
11,518✔
272

273
_end:
11,518✔
274
  if (code != TSDB_CODE_SUCCESS) {
11,518✔
275
    tsdbError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
276
  }
277
  return code;
11,518✔
278
}
279

280
int32_t tsdbCacherowsReaderOpen(void* pVnode, int32_t type, void* pTableIdList, int32_t numOfTables, int32_t numOfCols,
852,420✔
281
                                SArray* pCidList, int32_t* pSlotIds, uint64_t suid, void** pReader, const char* idstr,
282
                                SArray* pFuncTypeList, SColumnInfo* pPkCol, int32_t numOfPks) {
283
  int32_t           code = TSDB_CODE_SUCCESS;
852,420✔
284
  int32_t           lino = 0;
852,420✔
285
  SCacheRowsReader* p = NULL;
852,420✔
286

287
  TSDB_CHECK_NULL(pVnode, code, lino, _end, TSDB_CODE_INVALID_PARA);
852,420✔
288
  TSDB_CHECK_NULL(pReader, code, lino, _end, TSDB_CODE_INVALID_PARA);
852,420✔
289

290
  *pReader = NULL;
852,420✔
291
  p = taosMemoryCalloc(1, sizeof(SCacheRowsReader));
852,420✔
292
  TSDB_CHECK_NULL(p, code, lino, _end, terrno);
852,420✔
293

294
  p->type = type;
852,420✔
295
  p->pVnode = pVnode;
852,420✔
296
  p->pTsdb = p->pVnode->pTsdb;
851,806✔
297
  p->info.verRange = (SVersionRange){.minVer = 0, .maxVer = INT64_MAX};
852,420✔
298
  p->info.suid = suid;
852,420✔
299
  p->numOfCols = numOfCols;
852,420✔
300
  p->pCidList = pCidList;
852,420✔
301
  p->pSlotIds = pSlotIds;
851,806✔
302
  p->pFuncTypeList = pFuncTypeList;
852,420✔
303

304
  p->rowKey.numOfPKs = numOfPks;
852,420✔
305
  if (numOfPks > 0) {
851,806✔
306
    TSDB_CHECK_NULL(pPkCol, code, lino, _end, TSDB_CODE_INVALID_PARA);
475,950✔
307
    p->rowKey.pks[0].type = pPkCol->type;
475,950✔
308
    if (IS_VAR_DATA_TYPE(pPkCol->type)) {
475,950✔
309
      p->rowKey.pks[0].pData = taosMemoryCalloc(1, pPkCol->bytes);
149,348✔
310
      if (p->rowKey.pks[0].pData == NULL) {
149,348✔
311
        taosMemoryFreeClear(p);
×
312
        code = terrno;
×
313
        TSDB_CHECK_CODE(code, lino, _end);
×
314
      }
315
    }
316

317
    p->pkColumn = *pPkCol;
475,336✔
318
  }
319

320
  if (numOfTables == 0) {
851,806✔
321
    *pReader = p;
×
322
    p = NULL;
×
323
    goto _end;
×
324
  }
325

326
  p->pTableList = pTableIdList;
851,806✔
327
  p->numOfTables = numOfTables;
851,806✔
328

329
  code = setTableSchema(p, suid, idstr);
852,420✔
330
  TSDB_CHECK_CODE(code, lino, _end);
852,420✔
331

332
  p->transferBuf = taosMemoryCalloc(p->pSchema->numOfCols, POINTER_BYTES);
852,420✔
333
  TSDB_CHECK_NULL(p->transferBuf, code, lino, _end, terrno);
852,420✔
334

335
  for (int32_t i = 0; i < p->pSchema->numOfCols; ++i) {
18,611,124✔
336
    if (IS_VAR_DATA_TYPE(p->pSchema->columns[i].type)) {
17,758,090✔
337
      p->transferBuf[i] = taosMemoryMalloc(p->pSchema->columns[i].bytes);
2,512,405✔
338
      TSDB_CHECK_NULL(p->transferBuf[i], code, lino, _end, terrno);
2,512,032✔
339
    }
340
  }
341

342
  if (idstr != NULL) {
852,420✔
343
    p->idstr = taosStrdup(idstr);
852,420✔
344
    TSDB_CHECK_NULL(p->idstr, code, lino, _end, terrno);
851,806✔
345
  }
346
  code = taosThreadMutexInit(&p->readerMutex, NULL);
852,420✔
347
  TSDB_CHECK_CODE(code, lino, _end);
852,420✔
348

349
  p->lastTs = INT64_MIN;
852,420✔
350

351
  *pReader = p;
852,420✔
352
  p = NULL;
851,806✔
353

354
_end:
851,806✔
355
  if (code != TSDB_CODE_SUCCESS) {
851,806✔
356
    tsdbError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
357
    *pReader = NULL;
×
358
  }
359
  if (p != NULL) {
851,806✔
360
    tsdbCacherowsReaderClose(p);
×
361
  }
362
  return code;
852,420✔
363
}
364

365
void tsdbCacherowsReaderClose(void* pReader) {
851,806✔
366
  SCacheRowsReader* p = pReader;
851,806✔
367
  if (p == NULL) {
851,806✔
368
    return;
×
369
  }
370

371
  if (p->pSchema != NULL && p->transferBuf != NULL) {
851,806✔
372
    for (int32_t i = 0; i < p->pSchema->numOfCols; ++i) {
18,601,541✔
373
      taosMemoryFreeClear(p->transferBuf[i]);
17,754,165✔
374
    }
375

376
    taosMemoryFree(p->transferBuf);
852,047✔
377
    taosMemoryFree(p->pSchema);
851,806✔
378
  }
379

380
  taosMemoryFree(p->pCurrSchema);
852,047✔
381

382
  if (p->rowKey.numOfPKs > 0) {
851,806✔
383
    for (int32_t i = 0; i < p->rowKey.numOfPKs; i++) {
950,058✔
384
      if (IS_VAR_DATA_TYPE(p->rowKey.pks[i].type)) {
475,336✔
385
        taosMemoryFree(p->rowKey.pks[i].pData);
148,734✔
386
      }
387
    }
388
  }
389

390
  if (p->pLDataIterArray) {
852,420✔
391
    destroySttBlockReader(p->pLDataIterArray, NULL);
49,799✔
392
    p->pLDataIterArray = NULL;
49,799✔
393
  }
394

395
  if (p->pFileReader) {
851,806✔
396
    tsdbDataFileReaderClose(&p->pFileReader);
×
397
    p->pFileReader = NULL;
×
398
  }
399

400
  taosMemoryFree((void*)p->idstr);
852,420✔
401
  (void)taosThreadMutexDestroy(&p->readerMutex);
851,192✔
402

403
  if (p->pTableMap) {
850,819✔
404
    void*   pe = NULL;
376,663✔
405
    int32_t iter = 0;
376,663✔
406
    while ((pe = tSimpleHashIterate(p->pTableMap, pe, &iter)) != NULL) {
938,034✔
407
      STableLoadInfo* pInfo = *(STableLoadInfo**)pe;
561,744✔
408
      taosArrayDestroy(pInfo->pTombData);
561,744✔
409
      pInfo->pTombData = NULL;
561,371✔
410
    }
411

412
    tSimpleHashCleanup(p->pTableMap);
376,290✔
413
  }
414
  if (p->uidList) {
850,819✔
415
    taosMemoryFree(p->uidList);
44,067✔
416
  }
417

418
  taosMemoryFree(pReader);
851,806✔
419
}
420

421
static int32_t tsdbCacheQueryReseek(void* pQHandle) {
×
422
  int32_t           code = 0;
×
423
  SCacheRowsReader* pReader = pQHandle;
×
424

425
  code = taosThreadMutexTryLock(&pReader->readerMutex);
×
426
  if (code == 0) {
×
427
    // pause current reader's state if not paused, save ts & version for resuming
428
    // just wait for the big all tables' snapshot untaking for now
429

430
    code = TSDB_CODE_VND_QUERY_BUSY;
×
431
    (void)taosThreadMutexUnlock(&pReader->readerMutex);
×
432

433
    return code;
×
434
  } else if (code == EBUSY) {
×
435
    return TSDB_CODE_VND_QUERY_BUSY;
×
436
  } else {
437
    return -1;
×
438
  }
439
}
440

441
int32_t tsdbRetrieveCacheRows(void* pReader, SSDataBlock* pResBlock, const int32_t* slotIds, const int32_t* dstSlotIds,
1,383,570✔
442
                              SArray* pTableUidList, bool* pGotAll) {
443
  int32_t           code = TSDB_CODE_SUCCESS;
1,383,570✔
444
  int32_t           lino = 0;
1,383,570✔
445
  bool              hasRes = false;
1,383,570✔
446
  SArray*           pRow = NULL;
1,383,570✔
447
  SCacheRowsReader* pr = NULL;
1,383,570✔
448
  int32_t           pkBufLen = 0;
1,383,570✔
449

450
  TSDB_CHECK_NULL(pReader, code, lino, _end, TSDB_CODE_INVALID_PARA);
1,383,570✔
451
  TSDB_CHECK_NULL(pResBlock, code, lino, _end, TSDB_CODE_INVALID_PARA);
1,383,570✔
452

453
  pr = pReader;
1,383,570✔
454

455
  pr->pReadSnap = NULL;
1,383,570✔
456
  pRow = taosArrayInit(TARRAY_SIZE(pr->pCidList), sizeof(SLastCol));
1,383,811✔
457
  TSDB_CHECK_NULL(pRow, code, lino, _end, terrno);
1,384,184✔
458

459
  (void)taosThreadMutexLock(&pr->readerMutex);
1,384,184✔
460
  code = tsdbTakeReadSnap2((STsdbReader*)pr, tsdbCacheQueryReseek, &pr->pReadSnap, pr->idstr);
1,383,811✔
461
  TSDB_CHECK_CODE(code, lino, _end);
1,384,184✔
462

463
  int8_t ltype = (pr->type & CACHESCAN_RETRIEVE_LAST) >> 3;
1,384,184✔
464

465
  STableKeyInfo* pTableList = pr->pTableList;
1,384,184✔
466

467
  // retrieve combined last/last_row data of all tables in the uid list.
468
  if (HASTYPE(pr->type, CACHESCAN_RETRIEVE_TYPE_SINGLE)) {
1,384,184✔
469
    SArray* pLastCols = taosArrayInit(pr->numOfCols, sizeof(SLastCol));
395,928✔
470
    TSDB_CHECK_NULL(pLastCols, code, lino, _end, terrno);
395,928✔
471

472
    for (int32_t i = 0; i < pr->numOfCols; ++i) {
1,285,825✔
473
      int32_t slotId = slotIds[i];
890,270✔
474
      if (slotId == -1) {
890,270✔
475
        SLastCol p = {.rowKey.ts = INT64_MIN, .colVal.value.type = TSDB_DATA_TYPE_BOOL, .colVal.flag = CV_FLAG_NULL};
×
476
        void*    px = taosArrayPush(pLastCols, &p);
×
477
        TSDB_CHECK_NULL(px, code, lino, _end, terrno);
×
478
        continue;
×
479
      }
480
      struct STColumn* pCol = &pr->pSchema->columns[slotId];
890,270✔
481
      SLastCol         p = {.rowKey.ts = INT64_MIN, .colVal.value.type = pCol->type, .colVal.flag = CV_FLAG_NULL};
890,270✔
482

483
      if (pr->rowKey.numOfPKs > 0) {
890,270✔
484
        p.rowKey.numOfPKs = pr->rowKey.numOfPKs;
588,608✔
485
        for (int32_t j = 0; j < pr->rowKey.numOfPKs; j++) {
1,177,216✔
486
          p.rowKey.pks[j].type = pr->pkColumn.type;
588,608✔
487
          if (IS_VAR_DATA_TYPE(pr->pkColumn.type)) {
588,608✔
488
            p.rowKey.pks[j].pData = taosMemoryCalloc(1, pr->pkColumn.bytes);
220,952✔
489
            TSDB_CHECK_NULL(p.rowKey.pks[j].pData, code, lino, _end, terrno);
220,952✔
490
          }
491
        }
492
      }
493

494
      if (IS_VAR_DATA_TYPE(pCol->type) || pCol->type == TSDB_DATA_TYPE_DECIMAL) {
889,897✔
495
        int32_t allocBytes = IS_STR_DATA_BLOB(pCol->type) ?
151,390✔
496
                             BSE_SEQUECE_SIZE : pCol->bytes;
497
        p.colVal.value.pData = taosMemoryCalloc(allocBytes, sizeof(char));
151,390✔
498
        TSDB_CHECK_NULL(p.colVal.value.pData, code, lino, _end, terrno);
151,390✔
499
      }
500

501
      void* px = taosArrayPush(pLastCols, &p);
890,270✔
502
      TSDB_CHECK_NULL(px, code, lino, _end, terrno);
890,270✔
503
    }
504

505
    int64_t totalLastTs = INT64_MAX;
395,928✔
506
    for (int32_t i = 0; i < pr->numOfTables; ++i) {
1,464,952✔
507
      tb_uid_t uid = pTableList[i].uid;
1,069,024✔
508

509
      code = tsdbCacheGetBatch(pr->pTsdb, uid, pRow, pr, ltype);
1,069,024✔
510
      if (code == -1) {  // fix the invalid return code
1,069,024✔
511
        code = 0;
×
512
      }
513
      TSDB_CHECK_CODE(code, lino, _end);
1,069,024✔
514

515
      if (TARRAY_SIZE(pRow) <= 0) {
1,069,024✔
UNCOV
516
        taosArrayClearEx(pRow, tsdbCacheFreeSLastColItem);
×
517
        continue;
×
518
      }
519

520
      {
521
        bool    hasNotNullRow = true;
1,069,024✔
522
        int64_t singleTableLastTs = INT64_MAX;
1,069,024✔
523
        for (int32_t k = 0; k < pr->numOfCols; ++k) {
3,545,386✔
524
          if (slotIds[k] == -1) continue;
2,477,590✔
525
          SLastCol* p = taosArrayGet(pLastCols, k);
2,477,590✔
526
          if (p == NULL) {
2,477,590✔
527
            return TSDB_CODE_INVALID_PARA;
×
528
          }
529

530
          SLastCol* pColVal = (SLastCol*)taosArrayGet(pRow, k);
2,477,590✔
531
          if (pColVal == NULL) {
2,477,590✔
532
            return TSDB_CODE_INVALID_PARA;
×
533
          }
534

535
          if (tRowKeyCompare(&pColVal->rowKey, &p->rowKey) > 0) {
2,477,590✔
536
            if (!COL_VAL_IS_VALUE(&pColVal->colVal) && HASTYPE(pr->type, CACHESCAN_RETRIEVE_LAST)) {
1,054,386✔
537
              if (!COL_VAL_IS_VALUE(&p->colVal)) {
17,888✔
538
                hasNotNullRow = false;
416✔
539
              }
540
              // For all of cols is null, the last null col of last table will be save
541
              if (i != pr->numOfTables - 1 || k != pr->numOfCols - 1 || hasRes) {
17,888✔
542
                continue;
17,888✔
543
              }
544
            }
545

546
            hasRes = true;
1,036,498✔
547
            p->rowKey.ts = pColVal->rowKey.ts;
1,036,498✔
548
            for (int32_t j = 0; j < p->rowKey.numOfPKs; j++) {
1,635,940✔
549
              if (IS_VAR_DATA_TYPE(p->rowKey.pks[j].type)) {
600,056✔
550
                memcpy(p->rowKey.pks[j].pData, pColVal->rowKey.pks[j].pData, pColVal->rowKey.pks[j].nData);
225,162✔
551
                p->rowKey.pks[j].nData = pColVal->rowKey.pks[j].nData;
225,776✔
552
              } else {
553
                valueCloneDatum(p->rowKey.pks + j, pColVal->rowKey.pks + j, p->rowKey.pks[j].type);
374,280✔
554
              }
555
            }
556

557
            if (k == 0) {
1,035,270✔
558
              if (TARRAY_SIZE(pTableUidList) == 0) {
444,244✔
559
                void* px = taosArrayPush(pTableUidList, &uid);
394,328✔
560
                TSDB_CHECK_NULL(px, code, lino, _end, terrno);
394,328✔
561
              } else {
562
                taosArraySet(pTableUidList, 0, &uid);
50,631✔
563
              }
564
            }
565

566
            if (pColVal->rowKey.ts < singleTableLastTs && HASTYPE(pr->type, CACHESCAN_RETRIEVE_LAST)) {
1,036,498✔
567
              singleTableLastTs = pColVal->rowKey.ts;
253,480✔
568
            }
569

570
            if (p->colVal.value.type != pColVal->colVal.value.type) {
1,035,884✔
571
              // check for type/cid mismatch
572
              tsdbError("last cache type mismatch, uid:%" PRIu64
×
573
                        ", schema-type:%d, slotId:%d, cache-type:%d, cache-col:%d",
574
                        uid, p->colVal.value.type, slotIds[k], pColVal->colVal.value.type, pColVal->colVal.cid);
575
              taosArrayClearEx(pRow, tsdbCacheFreeSLastColItem);
×
576
              code = TSDB_CODE_INVALID_PARA;
×
577
              goto _end;
×
578
            }
579

580
            if (!IS_VAR_DATA_TYPE(pColVal->colVal.value.type) && pColVal->colVal.value.type != TSDB_DATA_TYPE_DECIMAL) {
1,035,270✔
581
              p->colVal = pColVal->colVal;
866,762✔
582
            } else {
583
              if (COL_VAL_IS_VALUE(&pColVal->colVal) &&
170,350✔
584
                  pColVal->colVal.value.nData > 0 &&
159,524✔
585
                  pColVal->colVal.value.pData != NULL) {
158,910✔
586
                int32_t copyBytes = IS_STR_DATA_BLOB(pColVal->colVal.value.type) ?
159,524✔
587
                                    BSE_SEQUECE_SIZE : pColVal->colVal.value.nData;
158,040✔
588
                TAOS_UNUSED(memcpy(p->colVal.value.pData, pColVal->colVal.value.pData, copyBytes));
159,524✔
589
              }
590

591
              p->colVal.value.nData = pColVal->colVal.value.nData;
169,122✔
592
              p->colVal.value.type = pColVal->colVal.value.type;
169,736✔
593
              p->colVal.flag = pColVal->colVal.flag;
169,736✔
594
              p->colVal.cid = pColVal->colVal.cid;
169,736✔
595
            }
596
          }
597
        }
598

599
        if (hasNotNullRow) {
1,069,638✔
600
          if (INT64_MAX == totalLastTs || (INT64_MAX != singleTableLastTs && totalLastTs < singleTableLastTs)) {
1,069,222✔
601
            totalLastTs = singleTableLastTs;
805,806✔
602
          }
603
        }
604
      }
605

606
      taosArrayClearEx(pRow, tsdbCacheFreeSLastColItem);
1,069,638✔
607
    }
608

609
    if (hasRes) {
395,928✔
610
      code = saveMultiRows(pLastCols, pResBlock, dstSlotIds, pr);
394,328✔
611
      TSDB_CHECK_CODE(code, lino, _end);
393,714✔
612
    }
613

614
    taosArrayDestroyEx(pLastCols, tsdbCacheFreeSLastColItem);
395,314✔
615
  } else if (HASTYPE(pr->type, CACHESCAN_RETRIEVE_TYPE_ALL)) {
988,256✔
616
    // retrieve data for each table
617
    int32_t i = pr->tableIndex;
988,256✔
618
    for (; i < pr->numOfTables; ++i) {
1,029,982✔
619
      tb_uid_t uid = pTableList[i].uid;
561,972✔
620

621
      if ((code = tsdbCacheGetBatch(pr->pTsdb, uid, pRow, pr, ltype)) != 0) {
561,972✔
622
        if (code == -1) {  // fix the invalid return code
×
623
          code = 0;
×
624
        }
625
        TSDB_CHECK_CODE(code, lino, _end);
×
626
      }
627

628
      if (TARRAY_SIZE(pRow) <= 0) {
561,972✔
629
        taosArrayClearEx(pRow, tsdbCacheFreeSLastColItem);
×
630
        continue;
×
631
      }
632

633
      code = saveMultiRows(pRow, pResBlock, dstSlotIds, pr);
561,972✔
634
      TSDB_CHECK_CODE(code, lino, _end);
561,972✔
635

636
      taosArrayClearEx(pRow, tsdbCacheFreeSLastColItem);
561,972✔
637
      ++pr->tableIndex;
561,972✔
638
      if (pResBlock->info.rows > 0) {
561,972✔
639
        void* px = taosArrayPush(pTableUidList, &uid);
520,246✔
640
        TSDB_CHECK_NULL(px, code, lino, _end, terrno);
520,246✔
641
        break;
520,246✔
642
      }
643
    }
644

645
    if (pGotAll && i == pr->numOfTables) {
988,256✔
646
      *pGotAll = true;
468,010✔
647
    }
648
  } else {
649
    code = TSDB_CODE_INVALID_PARA;
×
650
    TSDB_CHECK_CODE(code, lino, _end);
×
651
  }
652

653
_end:
×
654
  tsdbUntakeReadSnap2((STsdbReader*)pr, pr->pReadSnap, true);
1,383,570✔
655
  pr->pReadSnap = NULL;
1,383,570✔
656

657
  if (pr->pCurFileSet) {
1,383,570✔
658
    pr->pCurFileSet = NULL;
43,235✔
659
  }
660

661
  (void)taosThreadMutexUnlock(&pr->readerMutex);
1,383,570✔
662

663
  taosArrayDestroy(pRow);
1,383,570✔
664

665
  if (code != TSDB_CODE_SUCCESS) {
1,384,184✔
666
    tsdbError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
667
  }
668
  return code;
1,384,184✔
669
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc