• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4984

13 Mar 2026 03:38AM UTC coverage: 68.643% (-0.01%) from 68.653%
#4984

push

travis-ci

web-flow
feat/6641435300-save-audit-in-self (#34738)

434 of 584 new or added lines in 10 files covered. (74.32%)

3048 existing lines in 150 files now uncovered.

212713 of 309883 relevant lines covered (68.64%)

135561814.23 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

77.66
/source/dnode/mnode/impl/src/mndStb.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "audit.h"
18
#include "mndDb.h"
19
#include "mndDnode.h"
20
#include "mndIndex.h"
21
#include "mndIndexComm.h"
22
#include "mndInfoSchema.h"
23
#include "mndMnode.h"
24
#include "mndPerfSchema.h"
25
#include "mndPrivilege.h"
26
#include "mndRsma.h"
27
#include "mndShow.h"
28
#include "mndSma.h"
29
#include "mndStb.h"
30
#include "mndTopic.h"
31
#include "mndTrans.h"
32
#include "mndUser.h"
33
#include "mndVgroup.h"
34
#include "mndStream.h"
35
#include "tname.h"
36

37
#define STB_VER_SUPPORT_COMP    2
38
#define STB_VER_SUPPORT_VIRTUAL 3
39
#define STB_VER_SUPPORT_OWNER   4
40
#define STB_VER_NUMBER          STB_VER_SUPPORT_OWNER
41
#define STB_RESERVE_SIZE        56
42

43
static int32_t  mndStbActionInsert(SSdb *pSdb, SStbObj *pStb);
44
static int32_t  mndStbActionDelete(SSdb *pSdb, SStbObj *pStb);
45
static int32_t  mndStbActionUpdate(SSdb *pSdb, SStbObj *pOld, SStbObj *pNew);
46
static int32_t  mndProcessTtlTimer(SRpcMsg *pReq);
47
// static int32_t  mndProcessTrimDbTimer(SRpcMsg *pReq);
48
static int32_t  mndProcessCreateStbReq(SRpcMsg *pReq);
49
static int32_t  mndProcessAlterStbReq(SRpcMsg *pReq);
50
static int32_t  mndProcessDropStbReq(SRpcMsg *pReq);
51
static int32_t  mndProcessDropTtltbRsp(SRpcMsg *pReq);
52
static int32_t  mndProcessTrimDbRsp(SRpcMsg *pReq);
53
static int32_t  mndProcessTrimDbWalRsp(SRpcMsg *pReq);
54
static int32_t  mndProcessTableMetaReq(SRpcMsg *pReq);
55
static int32_t  mndRetrieveStb(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
56
static int32_t  mndRetrieveStbCol(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
57
static void     mndCancelGetNextStb(SMnode *pMnode, void *pIter);
58
static int32_t  mndProcessTableCfgReq(SRpcMsg *pReq);
59
static int32_t  mndAlterStbImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
60
                               void *alterOriData, int32_t alterOriDataLen);
61
static int32_t  mndAlterStbAndUpdateTagIdxImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
62
                                              void *alterOriData, int32_t alterOriDataLen, const SMAlterStbReq *pAlter);
63

64
static int32_t mndProcessCreateIndexReq(SRpcMsg *pReq);
65
static int32_t mndProcessDropIndexReq(SRpcMsg *pReq);
66

67
static int32_t mndProcessDropStbReqFromMNode(SRpcMsg *pReq);
68
static int32_t mndProcessDropTbWithTsma(SRpcMsg *pReq);
69
static int32_t mndProcessFetchTtlExpiredTbs(SRpcMsg *pReq);
70
static int32_t mndProcessAuditRecordRsp(SRpcMsg *pRsp);
71

72
int32_t mndInitStb(SMnode *pMnode) {
427,841✔
73
  SSdbTable table = {
427,841✔
74
      .sdbType = SDB_STB,
75
      .keyType = SDB_KEY_BINARY,
76
      .encodeFp = (SdbEncodeFp)mndStbActionEncode,
77
      .decodeFp = (SdbDecodeFp)mndStbActionDecode,
78
      .insertFp = (SdbInsertFp)mndStbActionInsert,
79
      .updateFp = (SdbUpdateFp)mndStbActionUpdate,
80
      .deleteFp = (SdbDeleteFp)mndStbActionDelete,
81
  };
82

83
  mndSetMsgHandle(pMnode, TDMT_MND_CREATE_STB, mndProcessCreateStbReq);
427,841✔
84
  mndSetMsgHandle(pMnode, TDMT_MND_ALTER_STB, mndProcessAlterStbReq);
427,841✔
85
  mndSetMsgHandle(pMnode, TDMT_MND_DROP_STB, mndProcessDropStbReq);
427,841✔
86
  mndSetMsgHandle(pMnode, TDMT_VND_CREATE_STB_RSP, mndTransProcessRsp);
427,841✔
87
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_TTL_TABLE_RSP, mndProcessDropTtltbRsp);
427,841✔
88
  mndSetMsgHandle(pMnode, TDMT_VND_TRIM_RSP, mndTransProcessRsp);
427,841✔
89
  mndSetMsgHandle(pMnode, TDMT_VND_TRIM_WAL_RSP, mndProcessTrimDbWalRsp);
427,841✔
90
  mndSetMsgHandle(pMnode, TDMT_VND_ALTER_STB_RSP, mndTransProcessRsp);
427,841✔
91
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_STB_RSP, mndTransProcessRsp);
427,841✔
92
  mndSetMsgHandle(pMnode, TDMT_MND_TABLE_META, mndProcessTableMetaReq);
427,841✔
93
  mndSetMsgHandle(pMnode, TDMT_MND_TTL_TIMER, mndProcessTtlTimer);
427,841✔
94
  // mndSetMsgHandle(pMnode, TDMT_MND_TRIM_DB_TIMER, mndProcessTrimDbTimer);
95
  mndSetMsgHandle(pMnode, TDMT_MND_TABLE_CFG, mndProcessTableCfgReq);
427,841✔
96
  mndSetMsgHandle(pMnode, TDMT_MND_STB_DROP, mndProcessDropStbReqFromMNode);
427,841✔
97
  mndSetMsgHandle(pMnode, TDMT_MND_STB_DROP_RSP, mndTransProcessRsp);
427,841✔
98
  mndSetMsgHandle(pMnode, TDMT_MND_DROP_TB_WITH_TSMA, mndProcessDropTbWithTsma);
427,841✔
99
  mndSetMsgHandle(pMnode, TDMT_VND_FETCH_TTL_EXPIRED_TBS_RSP, mndProcessFetchTtlExpiredTbs);
427,841✔
100
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_TABLE_RSP, mndTransProcessRsp);
427,841✔
101
  //  mndSetMsgHandle(pMnode, TDMT_MND_SYSTABLE_RETRIEVE, mndProcessRetrieveStbReq);
102

103
  // mndSetMsgHandle(pMnode, TDMT_MND_CREATE_INDEX, mndProcessCreateIndexReq);
104
  // mndSetMsgHandle(pMnode, TDMT_MND_DROP_INDEX, mndProcessDropIndexReq);
105
  // mndSetMsgHandle(pMnode, TDMT_VND_CREATE_INDEX_RSP, mndTransProcessRsp);
106
  // mndSetMsgHandle(pMnode, TDMT_VND_DROP_INDEX_RSP, mndTransProcessRsp);
107
  mndSetMsgHandle(pMnode, TDMT_VND_AUDIT_RECORD_RSP, mndProcessAuditRecordRsp);
427,841✔
108

109
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_STB, mndRetrieveStb);
427,841✔
110
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_STB, mndCancelGetNextStb);
427,841✔
111

112
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_COL, mndRetrieveStbCol);
427,841✔
113
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_COL, mndCancelGetNextStb);
427,841✔
114

115
  return sdbSetTable(pMnode->pSdb, table);
427,841✔
116
}
117

118
void mndCleanupStb(SMnode *pMnode) {}
427,780✔
119

120
SSdbRaw *mndStbActionEncode(SStbObj *pStb) {
14,936,317✔
121
  int32_t code = 0;
14,936,317✔
122
  int32_t lino = 0;
14,936,317✔
123
  bool    hasTypeMod = false;
14,936,317✔
124
  terrno = TSDB_CODE_OUT_OF_MEMORY;
14,936,317✔
125

126
  int32_t size = sizeof(SStbObj) + (pStb->numOfColumns + pStb->numOfTags) * sizeof(SSchema) + pStb->commentLen +
14,936,767✔
127
                 pStb->ast1Len + pStb->ast2Len + pStb->numOfColumns * sizeof(SColCmpr) + STB_RESERVE_SIZE +
14,936,767✔
128
                 taosArrayGetSize(pStb->pFuncs) * TSDB_FUNC_NAME_LEN + sizeof(int32_t) * pStb->numOfColumns;
14,936,317✔
129
  SSdbRaw *pRaw = sdbAllocRaw(SDB_STB, STB_VER_NUMBER, size);
14,936,317✔
130
  if (pRaw == NULL) goto _OVER;
14,936,317✔
131

132
  int32_t dataPos = 0;
14,936,317✔
133
  SDB_SET_BINARY(pRaw, dataPos, pStb->name, TSDB_TABLE_FNAME_LEN, _OVER)
14,936,317✔
134
  SDB_SET_BINARY(pRaw, dataPos, pStb->db, TSDB_DB_FNAME_LEN, _OVER)
14,936,317✔
135
  SDB_SET_INT64(pRaw, dataPos, pStb->createdTime, _OVER)
14,936,317✔
136
  SDB_SET_INT64(pRaw, dataPos, pStb->updateTime, _OVER)
14,936,317✔
137
  SDB_SET_INT64(pRaw, dataPos, pStb->uid, _OVER)
14,936,317✔
138
  SDB_SET_INT64(pRaw, dataPos, pStb->dbUid, _OVER)
14,936,317✔
139
  SDB_SET_INT32(pRaw, dataPos, pStb->tagVer, _OVER)
14,936,317✔
140
  SDB_SET_INT32(pRaw, dataPos, pStb->colVer, _OVER)
14,936,317✔
141
  SDB_SET_INT32(pRaw, dataPos, pStb->smaVer, _OVER)
14,936,317✔
142
  SDB_SET_INT32(pRaw, dataPos, pStb->nextColId, _OVER)
14,936,317✔
143
  SDB_SET_INT64(pRaw, dataPos, pStb->maxdelay[0], _OVER)
14,936,317✔
144
  SDB_SET_INT64(pRaw, dataPos, pStb->maxdelay[1], _OVER)
14,936,317✔
145
  SDB_SET_INT64(pRaw, dataPos, pStb->watermark[0], _OVER)
14,936,317✔
146
  SDB_SET_INT64(pRaw, dataPos, pStb->watermark[1], _OVER)
14,936,317✔
147
  SDB_SET_INT32(pRaw, dataPos, pStb->ttl, _OVER)
14,936,317✔
148
  SDB_SET_INT32(pRaw, dataPos, pStb->numOfColumns, _OVER)
14,936,317✔
149
  SDB_SET_INT32(pRaw, dataPos, pStb->numOfTags, _OVER)
14,936,317✔
150
  SDB_SET_INT32(pRaw, dataPos, pStb->numOfFuncs, _OVER)
14,936,317✔
151
  SDB_SET_INT32(pRaw, dataPos, pStb->commentLen, _OVER)
14,936,317✔
152
  SDB_SET_INT32(pRaw, dataPos, pStb->ast1Len, _OVER)
14,936,317✔
153
  SDB_SET_INT32(pRaw, dataPos, pStb->ast2Len, _OVER)
14,936,317✔
154

155
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
886,999,212✔
156
    SSchema *pSchema = &pStb->pColumns[i];
872,062,895✔
157
    SDB_SET_INT8(pRaw, dataPos, pSchema->type, _OVER)
872,062,895✔
158
    SDB_SET_INT8(pRaw, dataPos, pSchema->flags, _OVER)
872,062,895✔
159
    SDB_SET_INT16(pRaw, dataPos, pSchema->colId, _OVER)
872,062,895✔
160
    SDB_SET_INT32(pRaw, dataPos, pSchema->bytes, _OVER)
872,062,895✔
161
    SDB_SET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
872,062,895✔
162
    hasTypeMod = hasTypeMod || HAS_TYPE_MOD(pSchema);
872,062,895✔
163
  }
164

165
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
97,120,365✔
166
    SSchema *pSchema = &pStb->pTags[i];
82,184,048✔
167
    SDB_SET_INT8(pRaw, dataPos, pSchema->type, _OVER)
82,184,048✔
168
    SDB_SET_INT8(pRaw, dataPos, pSchema->flags, _OVER)
82,184,048✔
169
    SDB_SET_INT16(pRaw, dataPos, pSchema->colId, _OVER)
82,184,048✔
170
    SDB_SET_INT32(pRaw, dataPos, pSchema->bytes, _OVER)
82,184,048✔
171
    SDB_SET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
82,184,048✔
172
  }
173

174
  for (int32_t i = 0; i < pStb->numOfFuncs; ++i) {
14,936,317✔
UNCOV
175
    char *func = taosArrayGet(pStb->pFuncs, i);
×
UNCOV
176
    SDB_SET_BINARY(pRaw, dataPos, func, TSDB_FUNC_NAME_LEN, _OVER)
×
177
  }
178

179
  if (pStb->commentLen > 0) {
14,936,317✔
180
    SDB_SET_BINARY(pRaw, dataPos, pStb->comment, pStb->commentLen + 1, _OVER)
62,066✔
181
  }
182

183
  if (pStb->ast1Len > 0) {
14,936,317✔
UNCOV
184
    SDB_SET_BINARY(pRaw, dataPos, pStb->pAst1, pStb->ast1Len, _OVER)
×
185
  }
186

187
  if (pStb->ast2Len > 0) {
14,936,317✔
UNCOV
188
    SDB_SET_BINARY(pRaw, dataPos, pStb->pAst2, pStb->ast2Len, _OVER)
×
189
  }
190

191
  if (pStb->pCmpr != NULL) {
14,936,317✔
192
    for (int i = 0; i < pStb->numOfColumns; i++) {
886,999,212✔
193
      SColCmpr *p = &pStb->pCmpr[i];
872,062,895✔
194
      SDB_SET_INT16(pRaw, dataPos, p->id, _OVER)
872,062,895✔
195
      SDB_SET_INT32(pRaw, dataPos, p->alg, _OVER)
872,062,895✔
196
    }
197
  }
198
  SDB_SET_INT64(pRaw, dataPos, pStb->keep, _OVER)
14,936,317✔
199

200
  if (hasTypeMod) {
14,936,317✔
201
    for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
543,181,590✔
202
      SDB_SET_INT32(pRaw, dataPos, pStb->pExtSchemas[i].typeMod, _OVER);
538,245,509✔
203
    }
204
  }
205

206
  SDB_SET_INT8(pRaw, dataPos, pStb->virtualStb, _OVER)
14,936,317✔
207
  // since 3.4.0.0 - STB_VER_SUPPORT_OWNER
208
  SDB_SET_BINARY(pRaw, dataPos, pStb->createUser, TSDB_USER_LEN, _OVER)
14,936,317✔
209
  SDB_SET_INT64(pRaw, dataPos, pStb->ownerId, _OVER)
14,936,317✔
210
  SDB_SET_RESERVE(pRaw, dataPos, STB_RESERVE_SIZE, _OVER)
14,936,317✔
211
  SDB_SET_DATALEN(pRaw, dataPos, _OVER)
14,936,317✔
212

213
  terrno = 0;
14,936,317✔
214

215
_OVER:
14,936,317✔
216
  if (terrno != 0) {
14,936,317✔
UNCOV
217
    mError("stb:%s, failed to encode to raw:%p since %s", pStb->name, pRaw, terrstr());
×
UNCOV
218
    sdbFreeRaw(pRaw);
×
219
    return NULL;
×
220
  }
221

222
  mTrace("stb:%s, encode to raw:%p, row:%p", pStb->name, pRaw, pStb);
14,936,317✔
223
  return pRaw;
14,936,317✔
224
}
225

226
SSdbRow *mndStbActionDecode(SSdbRaw *pRaw) {
14,025,593✔
227
  int32_t code = 0;
14,025,593✔
228
  int32_t lino = 0;
14,025,593✔
229
  terrno = TSDB_CODE_OUT_OF_MEMORY;
14,025,593✔
230
  SSdbRow *pRow = NULL;
14,025,593✔
231
  SStbObj *pStb = NULL;
14,025,593✔
232
  bool     hasExtSchemas = false;
14,025,593✔
233

234
  int8_t sver = 0;
14,025,593✔
235
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) goto _OVER;
14,025,593✔
236

237
  if (sver > STB_VER_NUMBER) {
14,025,593✔
UNCOV
238
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
UNCOV
239
    goto _OVER;
×
240
  }
241

242
  pRow = sdbAllocRow(sizeof(SStbObj));
14,025,593✔
243
  if (pRow == NULL) goto _OVER;
14,025,593✔
244

245
  pStb = sdbGetRowObj(pRow);
14,025,593✔
246
  if (pStb == NULL) goto _OVER;
14,025,593✔
247

248
  int32_t dataPos = 0;
14,025,593✔
249
  SDB_GET_BINARY(pRaw, dataPos, pStb->name, TSDB_TABLE_FNAME_LEN, _OVER)
14,025,593✔
250
  SDB_GET_BINARY(pRaw, dataPos, pStb->db, TSDB_DB_FNAME_LEN, _OVER)
14,025,593✔
251
  SDB_GET_INT64(pRaw, dataPos, &pStb->createdTime, _OVER)
14,025,593✔
252
  SDB_GET_INT64(pRaw, dataPos, &pStb->updateTime, _OVER)
14,025,593✔
253
  SDB_GET_INT64(pRaw, dataPos, &pStb->uid, _OVER)
14,025,593✔
254
  SDB_GET_INT64(pRaw, dataPos, &pStb->dbUid, _OVER)
14,025,593✔
255
  SDB_GET_INT32(pRaw, dataPos, &pStb->tagVer, _OVER)
14,025,593✔
256
  SDB_GET_INT32(pRaw, dataPos, &pStb->colVer, _OVER)
14,025,593✔
257
  SDB_GET_INT32(pRaw, dataPos, &pStb->smaVer, _OVER)
14,025,593✔
258
  SDB_GET_INT32(pRaw, dataPos, &pStb->nextColId, _OVER)
14,025,593✔
259
  SDB_GET_INT64(pRaw, dataPos, &pStb->maxdelay[0], _OVER)
14,025,593✔
260
  SDB_GET_INT64(pRaw, dataPos, &pStb->maxdelay[1], _OVER)
14,025,593✔
261
  SDB_GET_INT64(pRaw, dataPos, &pStb->watermark[0], _OVER)
14,025,593✔
262
  SDB_GET_INT64(pRaw, dataPos, &pStb->watermark[1], _OVER)
14,025,593✔
263
  SDB_GET_INT32(pRaw, dataPos, &pStb->ttl, _OVER)
14,025,593✔
264
  SDB_GET_INT32(pRaw, dataPos, &pStb->numOfColumns, _OVER)
14,025,593✔
265
  SDB_GET_INT32(pRaw, dataPos, &pStb->numOfTags, _OVER)
14,025,593✔
266
  SDB_GET_INT32(pRaw, dataPos, &pStb->numOfFuncs, _OVER)
14,025,593✔
267
  SDB_GET_INT32(pRaw, dataPos, &pStb->commentLen, _OVER)
14,025,593✔
268
  SDB_GET_INT32(pRaw, dataPos, &pStb->ast1Len, _OVER)
14,025,593✔
269
  SDB_GET_INT32(pRaw, dataPos, &pStb->ast2Len, _OVER)
14,025,593✔
270

271
  pStb->pColumns = taosMemoryCalloc(pStb->numOfColumns, sizeof(SSchema));
14,025,593✔
272
  pStb->pTags = taosMemoryCalloc(pStb->numOfTags, sizeof(SSchema));
14,025,593✔
273
  pStb->pFuncs = taosArrayInit(pStb->numOfFuncs, TSDB_FUNC_NAME_LEN);
14,025,593✔
274
  if (pStb->pColumns == NULL || pStb->pTags == NULL || pStb->pFuncs == NULL) {
14,025,593✔
UNCOV
275
    goto _OVER;
×
276
  }
277

278
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
1,403,424,271✔
279
    SSchema *pSchema = &pStb->pColumns[i];
1,389,398,678✔
280
    SDB_GET_INT8(pRaw, dataPos, &pSchema->type, _OVER)
1,389,398,678✔
281
    SDB_GET_INT8(pRaw, dataPos, &pSchema->flags, _OVER)
1,389,398,678✔
282
    SDB_GET_INT16(pRaw, dataPos, &pSchema->colId, _OVER)
1,389,398,678✔
283
    SDB_GET_INT32(pRaw, dataPos, &pSchema->bytes, _OVER)
1,389,398,678✔
284
    SDB_GET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
1,389,398,678✔
285
    hasExtSchemas = hasExtSchemas || HAS_TYPE_MOD(pSchema);
1,389,398,678✔
286
  }
287

288
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
139,125,094✔
289
    SSchema *pSchema = &pStb->pTags[i];
125,099,501✔
290
    SDB_GET_INT8(pRaw, dataPos, &pSchema->type, _OVER)
125,099,501✔
291
    SDB_GET_INT8(pRaw, dataPos, &pSchema->flags, _OVER)
125,099,501✔
292
    SDB_GET_INT16(pRaw, dataPos, &pSchema->colId, _OVER)
125,099,501✔
293
    SDB_GET_INT32(pRaw, dataPos, &pSchema->bytes, _OVER)
125,099,501✔
294
    SDB_GET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
125,099,501✔
295
  }
296

297
  for (int32_t i = 0; i < pStb->numOfFuncs; ++i) {
14,025,593✔
UNCOV
298
    char funcName[TSDB_FUNC_NAME_LEN] = {0};
×
UNCOV
299
    SDB_GET_BINARY(pRaw, dataPos, funcName, TSDB_FUNC_NAME_LEN, _OVER)
×
300
    if (taosArrayPush(pStb->pFuncs, funcName) == NULL) goto _OVER;
×
301
  }
302

303
  if (pStb->commentLen > 0) {
14,025,593✔
304
    pStb->comment = taosMemoryCalloc(pStb->commentLen + 1, 1);
59,877✔
305
    if (pStb->comment == NULL) goto _OVER;
59,877✔
306
    SDB_GET_BINARY(pRaw, dataPos, pStb->comment, pStb->commentLen + 1, _OVER)
59,877✔
307
  }
308

309
  if (pStb->ast1Len > 0) {
14,025,593✔
UNCOV
310
    pStb->pAst1 = taosMemoryCalloc(pStb->ast1Len, 1);
×
UNCOV
311
    if (pStb->pAst1 == NULL) goto _OVER;
×
312
    SDB_GET_BINARY(pRaw, dataPos, pStb->pAst1, pStb->ast1Len, _OVER)
×
313
  }
314

315
  if (pStb->ast2Len > 0) {
14,025,593✔
UNCOV
316
    pStb->pAst2 = taosMemoryCalloc(pStb->ast2Len, 1);
×
UNCOV
317
    if (pStb->pAst2 == NULL) goto _OVER;
×
318
    SDB_GET_BINARY(pRaw, dataPos, pStb->pAst2, pStb->ast2Len, _OVER)
×
319
  }
320

321
  pStb->pCmpr = taosMemoryCalloc(pStb->numOfColumns, sizeof(SColCmpr));
14,025,593✔
322
  if (sver < STB_VER_SUPPORT_COMP) {
14,025,593✔
323
    // compatible with old data, setup default compress value
324
    // impl later
UNCOV
325
    for (int i = 0; i < pStb->numOfColumns; i++) {
×
UNCOV
326
      SSchema  *pSchema = &pStb->pColumns[i];
×
327
      SColCmpr *pCmpr = &pStb->pCmpr[i];
×
328
      pCmpr->id = pSchema->colId;
×
329
      pCmpr->alg = createDefaultColCmprByType(pSchema->type);
×
330
    }
331
  } else {
332
    for (int i = 0; i < pStb->numOfColumns; i++) {
1,403,424,271✔
333
      SColCmpr *pCmpr = &pStb->pCmpr[i];
1,389,398,678✔
334
      SDB_GET_INT16(pRaw, dataPos, &pCmpr->id, _OVER)
1,389,398,678✔
335
      SDB_GET_INT32(pRaw, dataPos, (int32_t *)&pCmpr->alg, _OVER)  // compatiable
1,389,398,678✔
336
    }
337
  }
338
  SDB_GET_INT64(pRaw, dataPos, &pStb->keep, _OVER)
14,025,593✔
339

340
  // type mod
341
  if (hasExtSchemas) {
14,025,593✔
342
    pStb->pExtSchemas = taosMemoryCalloc(pStb->numOfColumns, sizeof(SExtSchema));
6,089,953✔
343
    if (!pStb->pExtSchemas) goto _OVER;
6,089,953✔
344
    for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
1,141,258,363✔
345
      SSchema *pSchema = &pStb->pColumns[i];
1,135,168,410✔
346
      SDB_GET_INT32(pRaw, dataPos, &pStb->pExtSchemas[i].typeMod, _OVER)
1,135,168,410✔
347
    }
348
  }
349

350
  if (sver < STB_VER_SUPPORT_VIRTUAL) {
14,025,593✔
UNCOV
351
    pStb->virtualStb = 0;
×
352
  } else {
353
    SDB_GET_INT8(pRaw, dataPos, &pStb->virtualStb, _OVER)
14,025,593✔
354
  }
355

356
  if (sver < STB_VER_SUPPORT_OWNER) {
14,025,593✔
UNCOV
357
    pStb->createUser[0] = 0;
×
358
  } else {
359
    SDB_GET_BINARY(pRaw, dataPos, pStb->createUser, TSDB_USER_LEN, _OVER)
14,025,593✔
360
    SDB_GET_INT64(pRaw, dataPos, &pStb->ownerId, _OVER)
14,025,593✔
361
  }
362

363
  SDB_GET_RESERVE(pRaw, dataPos, STB_RESERVE_SIZE, _OVER)
14,025,593✔
364

365
  terrno = 0;
14,025,593✔
366

367
_OVER:
14,025,593✔
368
  if (terrno != 0) {
14,025,593✔
UNCOV
369
    mError("stb:%s, failed to decode from raw:%p since %s", pStb == NULL ? "null" : pStb->name, pRaw, terrstr());
×
UNCOV
370
    if (pStb != NULL) {
×
371
      taosMemoryFreeClear(pStb->pColumns);
×
372
      taosMemoryFreeClear(pStb->pTags);
×
373
      taosMemoryFreeClear(pStb->comment);
×
374
      taosMemoryFree(pStb->pCmpr);
×
375
      taosMemoryFreeClear(pStb->pExtSchemas);
×
376
    }
377
    taosMemoryFreeClear(pRow);
×
UNCOV
378
    return NULL;
×
379
  }
380

381
  mTrace("stb:%s, decode from raw:%p, row:%p", pStb->name, pRaw, pStb);
14,025,593✔
382
  return pRow;
14,025,593✔
383
}
384

385
void mndFreeStb(SStbObj *pStb) {
15,871,042✔
386
  taosArrayDestroy(pStb->pFuncs);
15,871,042✔
387
  taosMemoryFreeClear(pStb->pColumns);
15,871,042✔
388
  taosMemoryFreeClear(pStb->pTags);
15,871,042✔
389
  taosMemoryFreeClear(pStb->comment);
15,871,042✔
390
  taosMemoryFreeClear(pStb->pAst1);
15,871,042✔
391
  taosMemoryFreeClear(pStb->pAst2);
15,871,042✔
392
  taosMemoryFreeClear(pStb->pCmpr);
15,871,042✔
393
  taosMemoryFreeClear(pStb->pExtSchemas);
15,871,042✔
394
}
15,871,042✔
395

396
static int32_t mndStbActionInsert(SSdb *pSdb, SStbObj *pStb) {
2,283,807✔
397
  mTrace("stb:%s, perform insert action, row:%p", pStb->name, pStb);
2,283,807✔
398
  return 0;
2,283,807✔
399
}
400

401
static int32_t mndStbActionDelete(SSdb *pSdb, SStbObj *pStb) {
15,806,417✔
402
  mTrace("stb:%s, perform delete action, row:%p", pStb->name, pStb);
15,806,417✔
403
  mndFreeStb(pStb);
15,806,417✔
404
  return 0;
15,806,417✔
405
}
406

407
static int32_t mndStbActionUpdate(SSdb *pSdb, SStbObj *pOld, SStbObj *pNew) {
10,727,311✔
408
  terrno = 0;
10,727,311✔
409
  mTrace("stb:%s, perform update action, old row:%p new row:%p", pOld->name, pOld, pNew);
10,727,311✔
410

411
  taosWLockLatch(&pOld->lock);
10,727,311✔
412
  int32_t numOfColumns = pOld->numOfColumns;
10,727,311✔
413
  if (pOld->numOfColumns < pNew->numOfColumns) {
10,727,311✔
414
    void *pColumns = taosMemoryMalloc(pNew->numOfColumns * sizeof(SSchema));
2,519,942✔
415
    if (pColumns == NULL) {
2,519,942✔
UNCOV
416
      goto END;
×
417
    }
418
    taosMemoryFree(pOld->pColumns);
2,519,942✔
419
    pOld->pColumns = pColumns;
2,519,942✔
420
  }
421

422
  if (pOld->numOfTags < pNew->numOfTags) {
10,727,311✔
423
    void *pTags = taosMemoryMalloc(pNew->numOfTags * sizeof(SSchema));
261,282✔
424
    if (pTags == NULL) {
261,282✔
UNCOV
425
      goto END;
×
426
    }
427
    taosMemoryFree(pOld->pTags);
261,282✔
428
    pOld->pTags = pTags;
261,282✔
429
  }
430

431
  if (pOld->commentLen < pNew->commentLen && pNew->commentLen > 0) {
10,727,311✔
432
    void *comment = taosMemoryMalloc(pNew->commentLen + 1);
5,900✔
433
    if (comment == NULL) {
5,900✔
UNCOV
434
      goto END;
×
435
    }
436
    taosMemoryFree(pOld->comment);
5,900✔
437
    pOld->comment = comment;
5,900✔
438
  }
439
  pOld->commentLen = pNew->commentLen;
10,727,311✔
440

441
  if (pOld->ast1Len < pNew->ast1Len) {
10,727,311✔
UNCOV
442
    void *pAst1 = taosMemoryMalloc(pNew->ast1Len + 1);
×
UNCOV
443
    if (pAst1 == NULL) {
×
444
      goto END;
×
445
    }
446
    taosMemoryFree(pOld->pAst1);
×
UNCOV
447
    pOld->pAst1 = pAst1;
×
448
  }
449

450
  if (pOld->ast2Len < pNew->ast2Len) {
10,727,311✔
UNCOV
451
    void *pAst2 = taosMemoryMalloc(pNew->ast2Len + 1);
×
UNCOV
452
    if (pAst2 == NULL) {
×
453
      goto END;
×
454
    }
455
    taosMemoryFree(pOld->pAst2);
×
UNCOV
456
    pOld->pAst2 = pAst2;
×
457
  }
458

459
  pOld->updateTime = pNew->updateTime;
10,727,311✔
460
  pOld->tagVer = pNew->tagVer;
10,727,311✔
461
  pOld->colVer = pNew->colVer;
10,727,311✔
462
  pOld->smaVer = pNew->smaVer;
10,727,311✔
463
  pOld->nextColId = pNew->nextColId;
10,727,311✔
464
  pOld->ttl = pNew->ttl;
10,727,311✔
465
  pOld->keep = pNew->keep;
10,727,311✔
466
  pOld->ownerId = pNew->ownerId;
10,727,311✔
467
  
468
  if (pNew->numOfColumns > 0) {
10,727,311✔
469
    pOld->numOfColumns = pNew->numOfColumns;
10,727,311✔
470
    memcpy(pOld->pColumns, pNew->pColumns, pOld->numOfColumns * sizeof(SSchema));
10,727,311✔
471
  }
472
  if (pNew->numOfTags > 0) {
10,727,311✔
473
    pOld->numOfTags = pNew->numOfTags;
10,727,311✔
474
    memcpy(pOld->pTags, pNew->pTags, pOld->numOfTags * sizeof(SSchema));
10,727,311✔
475
  }
476
  if (pNew->commentLen > 0) {
10,727,311✔
477
    memcpy(pOld->comment, pNew->comment, pNew->commentLen + 1);
39,486✔
478
    pOld->commentLen = pNew->commentLen;
39,486✔
479
  }
480
  if (pNew->ast1Len != 0) {
10,727,311✔
UNCOV
481
    memcpy(pOld->pAst1, pNew->pAst1, pNew->ast1Len);
×
UNCOV
482
    pOld->ast1Len = pNew->ast1Len;
×
483
  }
484
  if (pNew->ast2Len != 0) {
10,727,311✔
UNCOV
485
    memcpy(pOld->pAst2, pNew->pAst2, pNew->ast2Len);
×
UNCOV
486
    pOld->ast2Len = pNew->ast2Len;
×
487
  }
488
  if (numOfColumns < pNew->numOfColumns) {
10,727,311✔
489
    taosMemoryFree(pOld->pCmpr);
2,519,942✔
490
    pOld->pCmpr = taosMemoryCalloc(pNew->numOfColumns, sizeof(SColCmpr));
2,519,942✔
491
    if (pOld->pCmpr == NULL){
2,519,942✔
UNCOV
492
      goto END;
×
493
    }
494
    memcpy(pOld->pCmpr, pNew->pCmpr, pNew->numOfColumns * sizeof(SColCmpr));
2,519,942✔
495
  } else {
496
    memcpy(pOld->pCmpr, pNew->pCmpr, pNew->numOfColumns * sizeof(SColCmpr));
8,207,369✔
497
  }
498

499
  if (pNew->pExtSchemas) {
10,727,311✔
500
    taosMemoryFreeClear(pOld->pExtSchemas);
6,035,826✔
501
    pOld->pExtSchemas = taosMemoryCalloc(pNew->numOfColumns, sizeof(SExtSchema));
6,035,826✔
502
    if (pOld->pExtSchemas == NULL){
6,035,826✔
UNCOV
503
      goto END;
×
504
    }
505
    memcpy(pOld->pExtSchemas, pNew->pExtSchemas, pNew->numOfColumns * sizeof(SExtSchema));
6,035,826✔
506
  }
507

508
END:
4,691,485✔
509
  taosWUnLockLatch(&pOld->lock);
10,727,311✔
510
  return terrno;
10,727,311✔
511
}
512

513
SStbObj *mndAcquireStb(SMnode *pMnode, char *stbName) {
33,463,485✔
514
  SSdb    *pSdb = pMnode->pSdb;
33,463,485✔
515
  SStbObj *pStb = sdbAcquire(pSdb, SDB_STB, stbName);
33,463,555✔
516
  if (pStb == NULL && terrno == TSDB_CODE_SDB_OBJ_NOT_THERE) {
33,463,555✔
517
    terrno = TSDB_CODE_MND_STB_NOT_EXIST;
2,954,266✔
518
  }
519
  return pStb;
33,463,555✔
520
}
521

522
void mndReleaseStb(SMnode *pMnode, SStbObj *pStb) {
32,732,300✔
523
  SSdb *pSdb = pMnode->pSdb;
32,732,300✔
524
  sdbRelease(pSdb, pStb);
32,732,300✔
525
}
32,732,300✔
526

527
SDbObj *mndAcquireDbByStb(SMnode *pMnode, const char *stbName) {
7,821,618✔
528
  SName name = {0};
7,821,618✔
529
  if ((terrno = tNameFromString(&name, stbName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) return NULL;
7,821,618✔
530

531
  char db[TSDB_TABLE_FNAME_LEN] = {0};
7,821,618✔
532
  if ((terrno = tNameGetFullDbName(&name, db)) != 0) return NULL;
7,821,618✔
533

534
  return mndAcquireDb(pMnode, db);
7,821,618✔
535
}
536

537
static FORCE_INLINE int32_t schemaExColIdCompare(const void *colId, const void *pSchema) {
538
  if (*(col_id_t *)colId < ((SSchema *)pSchema)->colId) {
539
    return -1;
540
  } else if (*(col_id_t *)colId > ((SSchema *)pSchema)->colId) {
541
    return 1;
542
  }
543
  return 0;
544
}
545

546
void *mndBuildVCreateStbReq(SMnode *pMnode, SVgObj *pVgroup, SStbObj *pStb, int32_t *pContLen, void *alterOriData,
10,287,338✔
547
                            int32_t alterOriDataLen) {
548
  SEncoder       encoder = {0};
10,287,338✔
549
  int32_t        contLen;
550
  SName          name = {0};
10,287,338✔
551
  SVCreateStbReq req = {0};
10,287,338✔
552

553
  if ((terrno = tNameFromString(&name, pStb->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
10,287,338✔
UNCOV
554
    goto _err;
×
555
  }
556
  char dbFName[TSDB_DB_FNAME_LEN] = {0};
10,287,338✔
557
  if ((terrno = tNameGetFullDbName(&name, dbFName)) != 0) {
10,287,338✔
UNCOV
558
    goto _err;
×
559
  };
560

561
  req.name = (char *)tNameGetTableName(&name);
10,287,338✔
562
  req.suid = pStb->uid;
10,287,338✔
563
  req.rollup = pStb->ast1Len > 0 ? 1 : 0;
10,287,338✔
564
  req.alterOriData = alterOriData;
10,287,338✔
565
  req.alterOriDataLen = alterOriDataLen;
10,287,338✔
566
  req.source = pStb->source;
10,287,338✔
567
  req.virtualStb = pStb->virtualStb;
10,287,338✔
568
  // todo
569
  req.schemaRow.nCols = pStb->numOfColumns;
10,287,338✔
570
  req.schemaRow.version = pStb->colVer;
10,287,338✔
571
  req.schemaRow.pSchema = pStb->pColumns;
10,287,338✔
572
  req.schemaTag.nCols = pStb->numOfTags;
10,287,338✔
573
  req.schemaTag.version = pStb->tagVer;
10,287,338✔
574
  req.schemaTag.pSchema = pStb->pTags;
10,287,338✔
575

576
  req.colCmpred = 1;
10,287,338✔
577
  SColCmprWrapper *pCmpr = &req.colCmpr;
10,287,338✔
578
  req.keep = pStb->keep;
10,287,338✔
579
  pCmpr->version = pStb->colVer;
10,287,338✔
580
  pCmpr->nCols = pStb->numOfColumns;
10,287,338✔
581

582
  req.colCmpr.pColCmpr = taosMemoryCalloc(pCmpr->nCols, sizeof(SColCmpr));
10,287,338✔
583
  for (int32_t i = 0; i < pStb->numOfColumns; i++) {
850,770,787✔
584
    SColCmpr *p = &pCmpr->pColCmpr[i];
840,483,449✔
585
    p->alg = pStb->pCmpr[i].alg;
840,483,449✔
586
    p->id = pStb->pCmpr[i].id;
840,483,449✔
587
  }
588

589
  req.pExtSchemas = pStb->pExtSchemas; // only reference to it.
10,287,338✔
590
  // get length
591
  int32_t ret = 0;
10,287,338✔
592
  tEncodeSize(tEncodeSVCreateStbReq, &req, contLen, ret);
10,287,338✔
593
  if (ret < 0) {
10,287,338✔
UNCOV
594
    goto _err;
×
595
  }
596

597
  contLen += sizeof(SMsgHead);
10,287,338✔
598

599
  SMsgHead *pHead = taosMemoryCalloc(1, contLen);
10,287,338✔
600
  if (pHead == NULL) {
10,287,338✔
UNCOV
601
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
602
    goto _err;
×
603
  }
604

605
  pHead->contLen = htonl(contLen);
10,287,338✔
606
  pHead->vgId = htonl(pVgroup->vgId);
10,287,338✔
607

608
  void *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
10,287,338✔
609
  tEncoderInit(&encoder, pBuf, contLen - sizeof(SMsgHead));
10,287,338✔
610
  if (tEncodeSVCreateStbReq(&encoder, &req) < 0) {
10,287,338✔
UNCOV
611
    taosMemoryFreeClear(pHead);
×
UNCOV
612
    tEncoderClear(&encoder);
×
613
    goto _err;
×
614
  }
615
  tEncoderClear(&encoder);
10,287,338✔
616

617
  *pContLen = contLen;
10,287,338✔
618
  taosMemoryFreeClear(req.rsmaParam.name);
10,287,338✔
619
  taosMemoryFreeClear(req.rsmaParam.funcColIds);
10,287,338✔
620
  taosMemoryFreeClear(req.rsmaParam.funcIds);
10,287,338✔
621
  taosMemoryFreeClear(req.colCmpr.pColCmpr);
10,287,338✔
622
  return pHead;
10,287,338✔
UNCOV
623
_err:
×
UNCOV
624
  taosMemoryFreeClear(req.rsmaParam.name);
×
625
  taosMemoryFreeClear(req.rsmaParam.funcColIds);
×
626
  taosMemoryFreeClear(req.rsmaParam.funcIds);
×
627
  taosMemoryFreeClear(req.colCmpr.pColCmpr);
×
628
  return NULL;
×
629
}
630

631
static void *mndBuildVDropStbReq(SMnode *pMnode, SVgObj *pVgroup, SStbObj *pStb, int32_t *pContLen) {
4,928,835✔
632
  SName        name = {0};
4,928,835✔
633
  SVDropStbReq req = {0};
4,928,835✔
634
  int32_t      contLen = 0;
4,928,835✔
635
  int32_t      ret = 0;
4,928,835✔
636
  SMsgHead    *pHead = NULL;
4,928,835✔
637
  SEncoder     encoder = {0};
4,928,835✔
638

639
  if ((terrno = tNameFromString(&name, pStb->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
4,928,835✔
UNCOV
640
    return NULL;
×
641
  }
642

643
  req.name = (char *)tNameGetTableName(&name);
4,928,835✔
644
  req.suid = pStb->uid;
4,928,835✔
645

646
  tEncodeSize(tEncodeSVDropStbReq, &req, contLen, ret);
4,928,835✔
647
  if (ret < 0) return NULL;
4,928,835✔
648

649
  contLen += sizeof(SMsgHead);
4,928,835✔
650
  pHead = taosMemoryMalloc(contLen);
4,928,835✔
651
  if (pHead == NULL) {
4,928,835✔
UNCOV
652
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
653
    return NULL;
×
654
  }
655

656
  pHead->contLen = htonl(contLen);
4,928,835✔
657
  pHead->vgId = htonl(pVgroup->vgId);
4,928,835✔
658

659
  void *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
4,928,835✔
660

661
  tEncoderInit(&encoder, pBuf, contLen - sizeof(SMsgHead));
4,928,835✔
662
  int32_t code = tEncodeSVDropStbReq(&encoder, &req);
4,928,835✔
663
  tEncoderClear(&encoder);
4,928,835✔
664
  if (code != 0) {
4,928,835✔
UNCOV
665
    terrno = code;
×
UNCOV
666
    return NULL;
×
667
  }
668

669
  *pContLen = contLen;
4,928,835✔
670
  return pHead;
4,928,835✔
671
}
672

673
int32_t mndCheckCreateStbReq(SMCreateStbReq *pCreate) {
1,896,559✔
674
  int32_t code = 0;
1,896,559✔
675
  if (pCreate->igExists < 0 || pCreate->igExists > 1) {
1,896,559✔
UNCOV
676
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
677
    TAOS_RETURN(code);
×
678
  }
679

680
  if (pCreate->virtualStb != 0 && pCreate->virtualStb != 1) {
1,896,559✔
UNCOV
681
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
682
    TAOS_RETURN(code);
×
683
  }
684

685
  int32_t maxColumns = pCreate->virtualStb ? TSDB_MAX_COLUMNS : TSDB_MAX_COLUMNS_NON_VIRTUAL;
1,896,559✔
686
  if (pCreate->numOfColumns < TSDB_MIN_COLUMNS || pCreate->numOfTags + pCreate->numOfColumns > maxColumns) {
1,896,559✔
UNCOV
687
    code = TSDB_CODE_PAR_INVALID_COLUMNS_NUM;
×
UNCOV
688
    TAOS_RETURN(code);
×
689
  }
690

691
  if (pCreate->numOfTags <= 0 || pCreate->numOfTags > TSDB_MAX_TAGS) {
1,896,559✔
UNCOV
692
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
693
    TAOS_RETURN(code);
×
694
  }
695

696
  SField *pField = taosArrayGet(pCreate->pColumns, 0);
1,896,559✔
697
  if (pField->type != TSDB_DATA_TYPE_TIMESTAMP) {
1,896,559✔
UNCOV
698
    code = TSDB_CODE_PAR_INVALID_FIRST_COLUMN;
×
UNCOV
699
    TAOS_RETURN(code);
×
700
  }
701

702
  for (int32_t i = 0; i < pCreate->numOfColumns; ++i) {
149,652,914✔
703
    SFieldWithOptions *pField1 = taosArrayGet(pCreate->pColumns, i);
147,756,355✔
704
    if (pField1->type >= TSDB_DATA_TYPE_MAX) {
147,756,355✔
UNCOV
705
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
706
      TAOS_RETURN(code);
×
707
    }
708
    if (pField1->bytes <= 0) {
147,756,355✔
UNCOV
709
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
710
      TAOS_RETURN(code);
×
711
    }
712
    if (pField1->name[0] == 0) {
147,756,355✔
UNCOV
713
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
714
      TAOS_RETURN(code);
×
715
    }
716
  }
717

718
  for (int32_t i = 0; i < pCreate->numOfTags; ++i) {
9,863,051✔
719
    SField *pField1 = taosArrayGet(pCreate->pTags, i);
7,966,492✔
720
    if (pField1->type >= TSDB_DATA_TYPE_MAX) {
7,966,492✔
UNCOV
721
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
722
      TAOS_RETURN(code);
×
723
    }
724
    if (pField1->bytes <= 0) {
7,966,492✔
UNCOV
725
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
726
      TAOS_RETURN(code);
×
727
    }
728
    if (pField1->name[0] == 0) {
7,966,492✔
UNCOV
729
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
730
      TAOS_RETURN(code);
×
731
    }
732
  }
733

734
  TAOS_RETURN(code);
1,896,559✔
735
}
736

UNCOV
737
static int32_t mndSetCreateStbPrepareLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
×
UNCOV
738
  int32_t  code = 0;
×
739
  SSdbRaw *pRedoRaw = mndStbActionEncode(pStb);
×
740
  if (pRedoRaw == NULL) {
×
741
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
742
    if (terrno != 0) code = terrno;
×
743
    TAOS_RETURN(code);
×
744
  }
745
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
×
UNCOV
746
    sdbFreeRaw(pRedoRaw);
×
747
    TAOS_RETURN(code);
×
748
  }
749
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_CREATING));
×
750

751
  TAOS_RETURN(code);
×
752
}
753

754
int32_t mndSetCreateStbCommitLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
1,837,507✔
755
  int32_t  code = 0;
1,837,507✔
756
  SSdbRaw *pCommitRaw = mndStbActionEncode(pStb);
1,837,507✔
757
  if (pCommitRaw == NULL) {
1,837,507✔
UNCOV
758
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
759
    if (terrno != 0) code = terrno;
×
760
    TAOS_RETURN(code);
×
761
  }
762
  mInfo("trans:%d, add stb to commit log", pTrans->id);
1,837,507✔
763
  if ((code = mndTransAppendCommitlog(pTrans, pCommitRaw)) != 0) {
1,837,507✔
UNCOV
764
    sdbFreeRaw(pCommitRaw);
×
UNCOV
765
    TAOS_RETURN(code);
×
766
  }
767
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
1,837,507✔
768

769
  TAOS_RETURN(code);
1,837,507✔
770
}
771

772
static int32_t mndSetCreateStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
1,835,914✔
773
  int32_t code = 0;
1,835,914✔
774
  SSdb   *pSdb = pMnode->pSdb;
1,835,914✔
775
  SVgObj *pVgroup = NULL;
1,835,914✔
776
  void   *pIter = NULL;
1,835,914✔
777
  int32_t contLen;
1,835,712✔
778

779
  while (1) {
8,121,466✔
780
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
9,957,380✔
781
    if (pIter == NULL) break;
9,957,380✔
782
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
8,121,466✔
783
      sdbRelease(pSdb, pVgroup);
4,088,676✔
784
      continue;
4,088,676✔
785
    }
786

787
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, NULL, 0);
4,032,790✔
788
    if (pReq == NULL) {
4,032,790✔
UNCOV
789
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
790
      sdbRelease(pSdb, pVgroup);
×
UNCOV
791
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
792
      if (terrno != 0) code = terrno;
×
793
      TAOS_RETURN(code);
×
794
    }
795

796
    STransAction action = {0};
4,032,790✔
797
    action.mTraceId = pTrans->mTraceId;
4,032,790✔
798
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
4,032,790✔
799
    action.pCont = pReq;
4,032,790✔
800
    action.contLen = contLen;
4,032,790✔
801
    action.msgType = TDMT_VND_CREATE_STB;
4,032,790✔
802
    action.acceptableCode = TSDB_CODE_TDB_STB_ALREADY_EXIST;
4,032,790✔
803
    action.retryCode = TSDB_CODE_TDB_STB_NOT_EXIST;
4,032,790✔
804
    mInfo("trans:%d, add create stb to redo action", pTrans->id);
4,032,790✔
805
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
4,032,790✔
UNCOV
806
      taosMemoryFree(pReq);
×
UNCOV
807
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
808
      sdbRelease(pSdb, pVgroup);
×
UNCOV
809
      TAOS_RETURN(code);
×
810
    }
811
    sdbRelease(pSdb, pVgroup);
4,032,790✔
812
  }
813

814
  TAOS_RETURN(code);
1,835,914✔
815
}
816

UNCOV
817
int32_t mndSetForceDropCreateStbRedoActions(SMnode *pMnode, STrans *pTrans, SVgObj *pVgroup, SStbObj *pStb) {
×
UNCOV
818
  int32_t code = 0;
×
UNCOV
819
  SSdb   *pSdb = pMnode->pSdb;
×
UNCOV
820
  int32_t contLen;
×
821

822
  void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, NULL, 0);
×
823
  if (pReq == NULL) {
×
824
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
825
    if (terrno != 0) code = terrno;
×
826
    TAOS_RETURN(code);
×
827
  }
828

829
  STransAction action = {0};
×
830
  action.mTraceId = pTrans->mTraceId;
×
UNCOV
831
  action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
×
UNCOV
832
  action.pCont = pReq;
×
833
  action.contLen = contLen;
×
834
  action.msgType = TDMT_VND_CREATE_STB;
×
835
  action.acceptableCode = TSDB_CODE_TDB_STB_ALREADY_EXIST;
×
836
  action.retryCode = TSDB_CODE_TDB_STB_NOT_EXIST;
×
837
  action.groupId = pVgroup->vgId;
×
838
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
×
839
    taosMemoryFree(pReq);
×
840
    TAOS_RETURN(code);
×
841
  }
842

843
  TAOS_RETURN(code);
×
844
}
845

846
static int32_t mndSetCreateStbUndoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
1,835,914✔
847
  int32_t code = 0;
1,835,914✔
848
  SSdb   *pSdb = pMnode->pSdb;
1,835,914✔
849
  SVgObj *pVgroup = NULL;
1,835,914✔
850
  void   *pIter = NULL;
1,835,914✔
851

852
  while (1) {
8,121,466✔
853
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
9,957,380✔
854
    if (pIter == NULL) break;
9,957,380✔
855
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
8,121,466✔
856
      sdbRelease(pSdb, pVgroup);
4,088,676✔
857
      continue;
4,088,676✔
858
    }
859

860
    int32_t contLen = 0;
4,032,790✔
861
    void   *pReq = mndBuildVDropStbReq(pMnode, pVgroup, pStb, &contLen);
4,032,790✔
862
    if (pReq == NULL) {
4,032,790✔
UNCOV
863
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
864
      sdbRelease(pSdb, pVgroup);
×
UNCOV
865
      code = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
866
      TAOS_RETURN(code);
×
867
    }
868

869
    STransAction action = {0};
4,032,790✔
870
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
4,032,790✔
871
    action.pCont = pReq;
4,032,790✔
872
    action.contLen = contLen;
4,032,790✔
873
    action.msgType = TDMT_VND_DROP_STB;
4,032,790✔
874
    action.acceptableCode = TSDB_CODE_TDB_STB_NOT_EXIST;
4,032,790✔
875
    mInfo("trans:%d, add drop stb to undo action", pTrans->id);
4,032,790✔
876
    if ((code = mndTransAppendUndoAction(pTrans, &action)) != 0) {
4,032,790✔
UNCOV
877
      taosMemoryFree(pReq);
×
UNCOV
878
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
879
      sdbRelease(pSdb, pVgroup);
×
UNCOV
880
      TAOS_RETURN(code);
×
881
    }
882
    sdbRelease(pSdb, pVgroup);
4,032,790✔
883
  }
884

885
  TAOS_RETURN(code);
1,835,914✔
886
}
887

UNCOV
888
static SSchema *mndFindStbColumns(const SStbObj *pStb, const char *colName) {
×
UNCOV
889
  for (int32_t col = 0; col < pStb->numOfColumns; ++col) {
×
UNCOV
890
    SSchema *pSchema = &pStb->pColumns[col];
×
UNCOV
891
    if (taosStrncasecmp(pSchema->name, colName, TSDB_COL_NAME_LEN) == 0) {
×
UNCOV
892
      return pSchema;
×
893
    }
894
  }
895
  return NULL;
×
896
}
897

898
int32_t mndBuildStbFromReq(SMnode *pMnode, SStbObj *pDst, SMCreateStbReq *pCreate, SDbObj *pDb) {
1,843,856✔
899
  int32_t code = 0;
1,843,856✔
900
  bool    hasTypeMods = false;
1,843,856✔
901
  memcpy(pDst->name, pCreate->name, TSDB_TABLE_FNAME_LEN);
1,843,856✔
902
  memcpy(pDst->db, pDb->name, TSDB_DB_FNAME_LEN);
1,843,856✔
903
  pDst->createdTime = taosGetTimestampMs();
1,843,856✔
904
  pDst->updateTime = pDst->createdTime;
1,843,856✔
905
  pDst->uid = (pCreate->source == TD_REQ_FROM_TAOX_OLD || pCreate->source == TD_REQ_FROM_TAOX || pCreate->source == TD_REQ_FROM_SML)
5,531,164✔
906
                  ? pCreate->suid
907
                  : mndGenerateUid(pCreate->name, TSDB_TABLE_FNAME_LEN);
3,687,712✔
908
  pDst->dbUid = pDb->uid;
1,843,856✔
909
  pDst->tagVer = 1;
1,843,856✔
910
  pDst->colVer = 1;
1,843,856✔
911
  pDst->smaVer = 1;
1,843,856✔
912
  pDst->nextColId = 1;
1,843,856✔
913
  pDst->maxdelay[0] = pCreate->delay1;
1,843,856✔
914
  pDst->maxdelay[1] = pCreate->delay2;
1,843,856✔
915
  pDst->watermark[0] = pCreate->watermark1;
1,843,856✔
916
  pDst->watermark[1] = pCreate->watermark2;
1,843,856✔
917
  pDst->ttl = pCreate->ttl;
1,843,856✔
918
  pDst->numOfColumns = pCreate->numOfColumns;
1,843,856✔
919
  pDst->numOfTags = pCreate->numOfTags;
1,843,856✔
920
  pDst->numOfFuncs = pCreate->numOfFuncs;
1,843,856✔
921
  pDst->commentLen = pCreate->commentLen;
1,843,856✔
922
  pDst->pFuncs = pCreate->pFuncs;
1,843,856✔
923
  pDst->source = pCreate->source;
1,843,856✔
924
  pDst->keep = pCreate->keep;
1,843,856✔
925
  pDst->virtualStb = pCreate->virtualStb;
1,843,856✔
926
  pCreate->pFuncs = NULL;
1,843,856✔
927

928
  if (pDst->commentLen > 0) {
1,843,856✔
929
    pDst->comment = taosMemoryCalloc(pDst->commentLen + 1, 1);
8,692✔
930
    if (pDst->comment == NULL) {
8,692✔
UNCOV
931
      code = terrno;
×
UNCOV
932
      TAOS_RETURN(code);
×
933
    }
934
    memcpy(pDst->comment, pCreate->pComment, pDst->commentLen + 1);
8,692✔
935
  }
936

937
  pDst->ast1Len = pCreate->ast1Len;
1,843,856✔
938
  if (pDst->ast1Len > 0) {
1,843,856✔
UNCOV
939
    pDst->pAst1 = taosMemoryCalloc(pDst->ast1Len, 1);
×
UNCOV
940
    if (pDst->pAst1 == NULL) {
×
UNCOV
941
      code = terrno;
×
UNCOV
942
      TAOS_RETURN(code);
×
943
    }
944
    memcpy(pDst->pAst1, pCreate->pAst1, pDst->ast1Len);
×
945
  }
946

947
  pDst->ast2Len = pCreate->ast2Len;
1,843,856✔
948
  if (pDst->ast2Len > 0) {
1,843,856✔
949
    pDst->pAst2 = taosMemoryCalloc(pDst->ast2Len, 1);
×
UNCOV
950
    if (pDst->pAst2 == NULL) {
×
UNCOV
951
      code = terrno;
×
UNCOV
952
      TAOS_RETURN(code);
×
953
    }
954
    memcpy(pDst->pAst2, pCreate->pAst2, pDst->ast2Len);
×
955
  }
956

957
  pDst->pColumns = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SSchema));
1,843,856✔
958
  pDst->pTags = taosMemoryCalloc(1, pDst->numOfTags * sizeof(SSchema));
1,843,856✔
959
  if (pDst->pColumns == NULL || pDst->pTags == NULL) {
1,843,856✔
UNCOV
960
    code = terrno;
×
UNCOV
961
    TAOS_RETURN(code);
×
962
  }
963

964
  if (pDst->nextColId < 0 || pDst->nextColId >= 0x7fff - pDst->numOfColumns - pDst->numOfTags) {
1,843,856✔
965
    code = TSDB_CODE_OUT_OF_RANGE;
1,064✔
966
    TAOS_RETURN(code);
1,064✔
967
  }
968

969
  for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
114,433,508✔
970
    SFieldWithOptions *pField = taosArrayGet(pCreate->pColumns, i);
112,590,716✔
971
    SSchema           *pSchema = &pDst->pColumns[i];
112,590,716✔
972
    pSchema->type = pField->type;
112,590,716✔
973
    pSchema->bytes = pField->bytes;
112,590,716✔
974
    pSchema->flags = pField->flags;
112,590,716✔
975
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
112,590,716✔
976
    pSchema->colId = pDst->nextColId;
112,590,716✔
977
    pDst->nextColId++;
112,590,716✔
978
    hasTypeMods = hasTypeMods || HAS_TYPE_MOD(pSchema);
112,590,716✔
979
  }
980

981
  for (int32_t i = 0; i < pDst->numOfTags; ++i) {
9,556,359✔
982
    SField  *pField = taosArrayGet(pCreate->pTags, i);
7,713,567✔
983
    SSchema *pSchema = &pDst->pTags[i];
7,713,567✔
984
    pSchema->type = pField->type;
7,713,567✔
985
    pSchema->bytes = pField->bytes;
7,713,567✔
986
    if (i == 0) {
7,713,567✔
987
      SSCHMEA_SET_IDX_ON(pSchema);
1,842,792✔
988
    }
989
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
7,713,567✔
990
    pSchema->colId = pDst->nextColId;
7,713,567✔
991
    pDst->nextColId++;
7,713,567✔
992
  }
993
  // set col compress
994
  pDst->pCmpr = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SCmprObj));
1,842,792✔
995
  for (int32_t i = 0; i < pDst->numOfColumns; i++) {
114,433,508✔
996
    SFieldWithOptions *pField = taosArrayGet(pCreate->pColumns, i);
112,590,716✔
997
    SSchema           *pSchema = &pDst->pColumns[i];
112,590,716✔
998

999
    SColCmpr *pColCmpr = &pDst->pCmpr[i];
112,590,716✔
1000
    pColCmpr->id = pSchema->colId;
112,590,716✔
1001
    pColCmpr->alg = pField->compress;
112,590,716✔
1002
  }
1003

1004
  if (hasTypeMods) {
1,842,792✔
1005
    pDst->pExtSchemas = taosMemoryCalloc(pDst->numOfColumns, sizeof(SExtSchema));
22,543✔
1006
    if (!pDst->pExtSchemas) {
22,543✔
UNCOV
1007
      code = terrno;
×
UNCOV
1008
      TAOS_RETURN(code);
×
1009
    }
1010
    for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
360,505✔
1011
      SFieldWithOptions * pField = taosArrayGet(pCreate->pColumns, i);
337,962✔
1012
      pDst->pExtSchemas[i].typeMod = pField->typeMod;
337,962✔
1013
    }
1014
  }
1015
  TAOS_RETURN(code);
1,842,792✔
1016
}
1017
int32_t mndGenIdxNameForFirstTag(char *fullname, char *dbname, char *stbname, char *tagname) {
1,781,290✔
1018
  SName name = {0};
1,781,290✔
1019
  if ((terrno = tNameFromString(&name, stbname, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
1,781,290✔
UNCOV
1020
    return -1;
×
1021
  }
1022
  return snprintf(fullname, TSDB_INDEX_FNAME_LEN, "%s.%s_%s", dbname, tagname, tNameGetTableName(&name));
1,781,290✔
1023
}
1024

1025
static int32_t mndCreateStb(SMnode *pMnode, SRpcMsg *pReq, SMCreateStbReq *pCreate, SDbObj *pDb, SUserObj *pOperUser) {
1,780,761✔
1026
  SStbObj stbObj = {0};
1,780,761✔
1027
  int32_t code = -1;
1,780,761✔
1028

1029
  char fullIdxName[TSDB_INDEX_FNAME_LEN * 2] = {0};
1,780,761✔
1030

1031
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_ROLLBACK, TRN_CONFLICT_DB_INSIDE, pReq, "create-stb");
1,780,761✔
1032
  if (pTrans == NULL) {
1,780,761✔
UNCOV
1033
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
1034
    if (terrno != 0) code = terrno;
×
UNCOV
1035
    goto _OVER;
×
1036
  }
1037

1038
  mInfo("trans:%d, used to create stb:%s", pTrans->id, pCreate->name);
1,780,761✔
1039
  TAOS_CHECK_GOTO(mndBuildStbFromReq(pMnode, &stbObj, pCreate, pDb), NULL, _OVER);
1,780,761✔
1040
  memcpy(stbObj.createUser, pOperUser->name, TSDB_USER_LEN);
1,779,697✔
1041
  stbObj.ownerId = pOperUser->uid;
1,779,697✔
1042

1043

1044
  SSchema *pSchema = &(stbObj.pTags[0]);
1,779,697✔
1045
  if (mndGenIdxNameForFirstTag(fullIdxName, pDb->name, stbObj.name, pSchema->name) < 0) {
1,779,697✔
NEW
1046
    code = terrno;
×
UNCOV
1047
    goto _OVER;
×
1048
  }
1049
  SSIdx idx = {0};
1,779,697✔
1050
  if (mndAcquireGlobalIdx(pMnode, fullIdxName, SDB_IDX, &idx) == 0 && idx.pIdx != NULL) {
1,779,697✔
UNCOV
1051
    code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
×
1052
    mndReleaseIdx(pMnode, idx.pIdx);
×
1053
    goto _OVER;
×
1054
  }
1055

1056
  SIdxObj idxObj = {0};
1,779,697✔
1057
  memcpy(idxObj.name, fullIdxName, TSDB_INDEX_FNAME_LEN);
1,779,697✔
1058
  memcpy(idxObj.stb, stbObj.name, TSDB_TABLE_FNAME_LEN);
1,779,697✔
1059
  memcpy(idxObj.db, stbObj.db, TSDB_DB_FNAME_LEN);
1,779,697✔
1060
  memcpy(idxObj.colName, pSchema->name, TSDB_COL_NAME_LEN);
1,779,697✔
1061
  memcpy(idxObj.createUser, pOperUser->name, TSDB_USER_LEN);
1,779,697✔
1062
  idxObj.ownerId = pOperUser->uid;
1,779,697✔
1063
  idxObj.createdTime = taosGetTimestampMs();
1,779,697✔
1064
  idxObj.uid = mndGenerateUid(fullIdxName, strlen(fullIdxName));
1,779,697✔
1065
  idxObj.stbUid = stbObj.uid;
1,779,697✔
1066
  idxObj.dbUid = stbObj.dbUid;
1,779,697✔
1067

1068
  TAOS_CHECK_GOTO(mndSetCreateIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
1,779,697✔
1069

1070
  TAOS_CHECK_GOTO(mndAddStbToTrans(pMnode, pTrans, pDb, &stbObj), NULL, _OVER);
1,779,697✔
1071
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
1,772,819✔
1072
  code = 0;
1,772,653✔
1073

1074
_OVER:
1,780,761✔
1075
  mndTransDrop(pTrans);
1,780,761✔
1076
  if (mndStbActionDelete(pMnode->pSdb, &stbObj) != 0) mError("failed to mndStbActionDelete");
1,780,761✔
1077
  TAOS_RETURN(code);
1,780,761✔
1078
}
1079

1080
typedef struct {
1081
  const char *name;
1082
  uint8_t     type;
1083
  int32_t     bytes;
1084
  uint32_t    alg;
1085
} AuditColumnDef;
1086

1087
// column is consistent with vnodePrepareRow process in vnodeSvr.c
1088
static const AuditColumnDef audit_columns[] = {
1089
    {"ts", TSDB_DATA_TYPE_TIMESTAMP, 8, 0x2000102},
1090
    {"details", TSDB_DATA_TYPE_VARCHAR, 50000 + VARSTR_HEADER_SIZE, 0xFF000302},
1091
    {"user_name", TSDB_DATA_TYPE_VARCHAR, 25 + VARSTR_HEADER_SIZE, 0xFF000302},
1092
    {"operation", TSDB_DATA_TYPE_VARCHAR, 20 + VARSTR_HEADER_SIZE, 0xFF000302},
1093
    {"db", TSDB_DATA_TYPE_VARCHAR, TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE, 0xFF000302},
1094
    {"resource", TSDB_DATA_TYPE_VARCHAR, TSDB_STREAM_NAME_LEN + VARSTR_HEADER_SIZE, 0xFF000302},
1095
    {"client_address", TSDB_DATA_TYPE_VARCHAR, AUDIT_CLIENT_ADD_LEN + VARSTR_HEADER_SIZE, 0xFF000302},
1096
    {"duration", TSDB_DATA_TYPE_DOUBLE, 8, 0x5000102},
1097
    {"affected_rows", TSDB_DATA_TYPE_UBIGINT, 8, 0x1000102}};
1098

1099
static int32_t mndBuildAuditStb(SMnode *pMnode, SStbObj *pDst, SDbObj *pDb) {
63✔
1100
  int32_t code = 0;
63✔
1101
  char   *name = AUDIT_STABLE_NAME;
63✔
1102
  (void)tsnprintf(pDst->name, TSDB_TABLE_FNAME_LEN, "%s.%s", pDb->name, name);
63✔
1103
  memcpy(pDst->db, pDb->name, TSDB_DB_FNAME_LEN);
63✔
1104
  pDst->createdTime = taosGetTimestampMs();
63✔
1105
  pDst->updateTime = pDst->createdTime;
63✔
1106
  pDst->uid = mndGenerateUid(pDst->name, strlen(pDst->name));
63✔
1107
  pDst->dbUid = pDb->uid;
63✔
1108
  pDst->tagVer = 1;
63✔
1109
  pDst->colVer = 1;
63✔
1110
  pDst->smaVer = 1;
63✔
1111
  pDst->nextColId = 1;
63✔
1112
  pDst->maxdelay[0] = -1;
63✔
1113
  pDst->maxdelay[1] = -1;
63✔
1114
  pDst->watermark[0] = 5000;
63✔
1115
  pDst->watermark[1] = 5000;
63✔
1116
  pDst->ttl = 0;
63✔
1117
  pDst->keep = -1;
63✔
1118
  pDst->source = 0;
63✔
1119
  pDst->virtualStb = 0;
63✔
1120
  pDst->numOfColumns = sizeof(audit_columns) / sizeof(AuditColumnDef);
63✔
1121
  pDst->numOfTags = 1;
63✔
1122
  pDst->numOfFuncs = 0;
63✔
1123
  pDst->commentLen = -1;
63✔
1124
  pDst->pFuncs = NULL;
63✔
1125

1126
  pDst->ast1Len = 0;
63✔
1127
  pDst->ast2Len = 0;
63✔
1128

1129
  pDst->pColumns = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SSchema));
63✔
1130
  pDst->pTags = taosMemoryCalloc(1, pDst->numOfTags * sizeof(SSchema));
63✔
1131
  pDst->pCmpr = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SCmprObj));
63✔
1132
  if (pDst->pColumns == NULL || pDst->pTags == NULL || pDst->pCmpr == NULL) {
63✔
NEW
1133
    code = terrno;
×
NEW
1134
    TAOS_RETURN(code);
×
1135
  }
1136

1137
  if (pDst->nextColId < 0 || pDst->nextColId >= 0x7fff - pDst->numOfColumns - pDst->numOfTags) {
63✔
NEW
1138
    code = TSDB_CODE_OUT_OF_RANGE;
×
NEW
1139
    TAOS_RETURN(code);
×
1140
  }
1141

1142
  SSchema *pSchema = NULL;
63✔
1143
  for (int32_t i = 0; i < sizeof(audit_columns) / sizeof(AuditColumnDef); ++i) {
630✔
1144
    pSchema = &pDst->pColumns[pDst->nextColId - 1];
567✔
1145
    pSchema->type = audit_columns[i].type;
567✔
1146
    pSchema->bytes = audit_columns[i].bytes;
567✔
1147
    pSchema->flags = 1;
567✔
1148
    tstrncpy(pSchema->name, audit_columns[i].name, TSDB_COL_NAME_LEN);
567✔
1149
    pSchema->colId = pDst->nextColId;
567✔
1150
    // hasTypeMods = hasTypeMods || HAS_TYPE_MOD(pSchema);
1151
    SColCmpr *pColCmpr = &pDst->pCmpr[pDst->nextColId - 1];
567✔
1152
    pColCmpr->id = pSchema->colId;
567✔
1153
    pColCmpr->alg = audit_columns[i].alg;
567✔
1154
    pDst->nextColId++;
567✔
1155
  }
1156

1157
  // tag
1158
  pSchema = &pDst->pTags[0];
63✔
1159
  pSchema->type = TSDB_DATA_TYPE_VARCHAR;
63✔
1160
  pSchema->bytes = 64 + VARSTR_HEADER_SIZE;
63✔
1161
  SSCHMEA_SET_IDX_ON(pSchema);
63✔
1162
  tstrncpy(pSchema->name, "cluster_id", TSDB_COL_NAME_LEN);
63✔
1163
  pSchema->colId = pDst->nextColId;
63✔
1164
  pDst->nextColId++;
63✔
1165

1166
  /*
1167
    if (hasTypeMods) {
1168
      pDst->pExtSchemas = taosMemoryCalloc(pDst->numOfColumns, sizeof(SExtSchema));
1169
      if (!pDst->pExtSchemas) {
1170
        code = terrno;
1171
        TAOS_RETURN(code);
1172
      }
1173
      for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
1174
        SFieldWithOptions *pField = taosArrayGet(pCreate->pColumns, i);
1175
        pDst->pExtSchemas[i].typeMod = pField->typeMod;
1176
      }
1177
    }
1178
  */
1179
  TAOS_RETURN(code);
63✔
1180
}
1181

1182
static int32_t mndSetCreateAuditStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb,
63✔
1183
                                               SVgObj *pVgroup) {
1184
  int32_t code = 0;
63✔
1185
  SSdb   *pSdb = pMnode->pSdb;
63✔
1186

1187
  int32_t contLen;
63✔
1188

1189
  if (pVgroup == NULL) {
63✔
NEW
1190
    code = TSDB_CODE_INVALID_PARA;
×
NEW
1191
    TAOS_RETURN(code);
×
1192
  }
1193

1194
  void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, NULL, 0);
63✔
1195
  if (pReq == NULL) {
63✔
NEW
1196
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
NEW
1197
    if (terrno != 0) code = terrno;
×
NEW
1198
    TAOS_RETURN(code);
×
1199
  }
1200

1201
  STransAction action = {0};
63✔
1202
  action.mTraceId = pTrans->mTraceId;
63✔
1203
  action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
63✔
1204
  action.pCont = pReq;
63✔
1205
  action.contLen = contLen;
63✔
1206
  action.msgType = TDMT_VND_CREATE_STB;
63✔
1207
  action.acceptableCode = TSDB_CODE_TDB_STB_ALREADY_EXIST;
63✔
1208
  action.retryCode = TSDB_CODE_TDB_STB_NOT_EXIST;
63✔
1209
  mInfo("trans:%d, add create stb to redo action", pTrans->id);
63✔
1210
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
63✔
NEW
1211
    taosMemoryFree(pReq);
×
NEW
1212
    TAOS_RETURN(code);
×
1213
  }
1214

1215
  TAOS_RETURN(code);
63✔
1216
}
1217

1218
// Note: pVgroup is expected to point to the first element of a vgroup array (e.g. pVgroups at the call site).
1219
// Only the first element is used for creating the audit super table.
1220
int32_t mndCreateAuditStb(SMnode *pMnode, SDbObj *pDb, SUserObj *pOperUser, STrans *pTrans, SVgObj *pVgroup) {
63✔
1221
  SStbObj stbObj = {0};
63✔
1222
  int32_t code = -1;
63✔
1223

1224
  char fullIdxName[TSDB_INDEX_FNAME_LEN * 2] = {0};
63✔
1225

1226
  TAOS_CHECK_GOTO(mndBuildAuditStb(pMnode, &stbObj, pDb), NULL, _OVER);
63✔
1227
  memcpy(stbObj.createUser, pOperUser->name, TSDB_USER_LEN);
63✔
1228
  stbObj.ownerId = pOperUser->uid;
63✔
1229

1230
  SSchema *pSchema = &(stbObj.pTags[0]);
63✔
1231
  if (mndGenIdxNameForFirstTag(fullIdxName, pDb->name, stbObj.name, pSchema->name) < 0) {
63✔
NEW
1232
    code = terrno;
×
NEW
1233
    goto _OVER;
×
1234
  }
1235

1236
  SSIdx idx = {0};
63✔
1237
  if (mndAcquireGlobalIdx(pMnode, fullIdxName, SDB_IDX, &idx) == 0 && idx.pIdx != NULL) {
63✔
NEW
1238
    code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
×
NEW
1239
    mndReleaseIdx(pMnode, idx.pIdx);
×
NEW
1240
    goto _OVER;
×
1241
  }
1242

1243
  SIdxObj idxObj = {0};
63✔
1244
  memcpy(idxObj.name, fullIdxName, TSDB_INDEX_FNAME_LEN);
63✔
1245
  memcpy(idxObj.stb, stbObj.name, TSDB_TABLE_FNAME_LEN);
63✔
1246
  memcpy(idxObj.db, stbObj.db, TSDB_DB_FNAME_LEN);
63✔
1247
  memcpy(idxObj.colName, pSchema->name, TSDB_COL_NAME_LEN);
63✔
1248
  memcpy(idxObj.createUser, pOperUser->name, TSDB_USER_LEN);
63✔
1249
  idxObj.ownerId = pOperUser->uid;
63✔
1250
  idxObj.createdTime = taosGetTimestampMs();
63✔
1251
  idxObj.uid = mndGenerateUid(fullIdxName, strlen(fullIdxName));
63✔
1252
  idxObj.stbUid = stbObj.uid;
63✔
1253
  idxObj.dbUid = stbObj.dbUid;
63✔
1254

1255
  mndTransSetDbName(pTrans, pDb->name, stbObj.name);
63✔
1256
  TAOS_CHECK_RETURN(mndTransCheckConflict(pMnode, pTrans));
63✔
1257
  TAOS_CHECK_GOTO(mndSetCreateIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
63✔
1258
  TAOS_CHECK_GOTO(mndSetCreateStbCommitLogs(pMnode, pTrans, pDb, &stbObj), NULL, _OVER);
63✔
1259
  TAOS_CHECK_GOTO(mndSetCreateAuditStbRedoActions(pMnode, pTrans, pDb, &stbObj, pVgroup), NULL, _OVER);
63✔
1260

1261
  code = 0;
63✔
1262

1263
_OVER:
63✔
1264
  if (mndStbActionDelete(pMnode->pSdb, &stbObj) != 0) mError("failed to mndStbActionDelete");
63✔
1265
  TAOS_RETURN(code);
63✔
1266
}
1267

1268
static int32_t mndProcessAuditRecordRsp(SRpcMsg *pRsp) {
252✔
1269
  int32_t code = 0;
252✔
1270

1271
  if (pRsp == NULL) {
252✔
NEW
1272
    mError("audit record rsp, null response message");
×
NEW
1273
    return -1;
×
1274
  }
1275

1276
  if (pRsp->code != 0) {
252✔
NEW
1277
    mError("audit record rsp failed, code:%d", pRsp->code);
×
NEW
1278
    return pRsp->code;
×
1279
  }
1280

1281
  SMnode *pMnode = pRsp->info.node;
252✔
1282
  SSdb   *pSdb = pMnode->pSdb;
252✔
1283
  (void)pMnode;  // currently unused, kept for potential future use
1284
  (void)pSdb;    // currently unused, kept for potential future use
1285

1286
  mDebug("audit record rsp succeeded, code:%d", pRsp->code);
252✔
1287

1288
  // no need to implement this rsp, since we do not care about the result of audit record insertion
1289

1290
  return code;
252✔
1291
}
1292

1293
int32_t mndAddStbToTrans(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
1,842,792✔
1294
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
1,842,792✔
1295
  TAOS_CHECK_RETURN(mndTransCheckConflict(pMnode, pTrans));
1,842,792✔
1296
  TAOS_CHECK_RETURN(mndSetCreateStbCommitLogs(pMnode, pTrans, pDb, pStb));
1,835,914✔
1297
  TAOS_CHECK_RETURN(mndSetCreateStbRedoActions(pMnode, pTrans, pDb, pStb));
1,835,914✔
1298
  TAOS_CHECK_RETURN(mndSetCreateStbUndoActions(pMnode, pTrans, pDb, pStb));
1,835,914✔
1299
  return 0;
1,835,914✔
1300
}
1301

1302
static int32_t mndProcessTtlTimer(SRpcMsg *pReq) {
3,094,256✔
1303
  SMnode           *pMnode = pReq->info.node;
3,094,256✔
1304
  SSdb             *pSdb = pMnode->pSdb;
3,094,256✔
1305
  SVgObj           *pVgroup = NULL;
3,094,256✔
1306
  void             *pIter = NULL;
3,094,256✔
1307
  SVDropTtlTableReq ttlReq = {
3,094,256✔
1308
      .timestampSec = taosGetTimestampSec(), .ttlDropMaxCount = tsTtlBatchDropNum, .nUids = 0, .pTbUids = NULL};
3,094,256✔
1309
  int32_t reqLen = tSerializeSVDropTtlTableReq(NULL, 0, &ttlReq);
3,094,256✔
1310
  int32_t contLen = reqLen + sizeof(SMsgHead);
3,094,256✔
1311

1312
  mDebug("start to process ttl timer");
3,094,256✔
1313

1314
  while (1) {
11,138,805✔
1315
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
14,233,061✔
1316
    if (pIter == NULL) break;
14,233,061✔
1317

1318
    if (pVgroup->mountVgId) {
11,138,805✔
1319
      sdbRelease(pSdb, pVgroup);
1,552✔
1320
      continue;
1,552✔
1321
    }
1322

1323
    int32_t   code = 0;
11,137,253✔
1324
    SMsgHead *pHead = rpcMallocCont(contLen);
11,137,253✔
1325
    if (pHead == NULL) {
11,137,253✔
UNCOV
1326
      sdbRelease(pSdb, pVgroup);
×
UNCOV
1327
      continue;
×
1328
    }
1329
    pHead->contLen = htonl(contLen);
11,137,253✔
1330
    pHead->vgId = htonl(pVgroup->vgId);
11,137,253✔
1331
    if ((code = tSerializeSVDropTtlTableReq((char *)pHead + sizeof(SMsgHead), reqLen, &ttlReq)) < 0) {
11,137,253✔
UNCOV
1332
      mError("vgId:%d, failed to serialize drop ttl table request since %s", pVgroup->vgId, tstrerror(code));
×
UNCOV
1333
      sdbRelease(pSdb, pVgroup);
×
UNCOV
1334
      continue;
×
1335
    }
1336

1337
    SRpcMsg rpcMsg = {
11,137,253✔
1338
        .msgType = TDMT_VND_FETCH_TTL_EXPIRED_TBS, .pCont = pHead, .contLen = contLen, .info = pReq->info};
1339
    SEpSet epSet = mndGetVgroupEpset(pMnode, pVgroup);
11,137,253✔
1340
    code = tmsgSendReq(&epSet, &rpcMsg);
11,137,253✔
1341
    if (code != 0) {
11,137,253✔
1342
      mError("vgId:%d, failed to send drop ttl table request to vnode since 0x%x", pVgroup->vgId, code);
57,810✔
1343
    } else {
1344
      mDebug("vgId:%d, send drop ttl table request to vnode, time:%" PRId32, pVgroup->vgId, ttlReq.timestampSec);
11,079,443✔
1345
    }
1346
    sdbRelease(pSdb, pVgroup);
11,137,253✔
1347
  }
1348

1349
  return 0;
3,094,256✔
1350
}
1351

1352
#if 0
1353
static int32_t mndProcessTrimDbTimer(SRpcMsg *pReq) {
1354
  SMnode     *pMnode = pReq->info.node;
1355
  SSdb       *pSdb = pMnode->pSdb;
1356
  SVgObj     *pVgroup = NULL;
1357
  void       *pIter = NULL;
1358
  SVTrimDbReq trimReq = {0};
1359
  trimReq.compactStartTime = taosGetTimestampMs();
1360
  trimReq.tw.skey = INT64_MIN;
1361
  trimReq.tw.ekey = trimReq.compactStartTime;
1362
  trimReq.compactId = 0;  // TODO: use the real value
1363
  trimReq.metaOnly = 0;
1364
  trimReq.triggerType = TSDB_TRIGGER_AUTO;
1365
  int32_t reqLen = tSerializeSVTrimDbReq(NULL, 0, &trimReq);
1366
  int32_t contLen = reqLen + sizeof(SMsgHead);
1367

1368
  while (1) {
1369
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
1370
    if (pIter == NULL) break;
1371
    if (pVgroup->mountVgId) {
1372
      sdbRelease(pSdb, pVgroup);
1373
      continue;
1374
    }
1375

1376
    int32_t code = 0;
1377

1378
    SMsgHead *pHead = rpcMallocCont(contLen);
1379
    if (pHead == NULL) {
1380
      sdbCancelFetch(pSdb, pVgroup);
1381
      sdbRelease(pSdb, pVgroup);
1382
      continue;
1383
    }
1384
    pHead->contLen = htonl(contLen);
1385
    pHead->vgId = htonl(pVgroup->vgId);
1386
    trimReq.dbUid = pVgroup->dbUid;
1387
    (void)snprintf(trimReq.db, sizeof(trimReq.db), "%s", pVgroup->dbName);
1388
    if ((code = tSerializeSVTrimDbReq((char *)pHead + sizeof(SMsgHead), reqLen, &trimReq)) < 0) {
1389
      mError("vgId:%d, failed to serialize trim db request since %s", pVgroup->vgId, tstrerror(code));
1390
    }
1391

1392
    SRpcMsg rpcMsg = {.msgType = TDMT_VND_TRIM, .pCont = pHead, .contLen = contLen};
1393
    SEpSet  epSet = mndGetVgroupEpset(pMnode, pVgroup);
1394
    code = tmsgSendReq(&epSet, &rpcMsg);
1395
    if (code != 0) {
1396
      mError("vgId:%d, timer failed to send vnode-trim request to vnode since 0x%x", pVgroup->vgId, code);
1397
    } else {
1398
      mInfo("vgId:%d, timer send vnode-trim request to vnode, time:%" PRIi64 " ms", pVgroup->vgId, trimReq.tw.ekey);
1399
    }
1400
    sdbRelease(pSdb, pVgroup);
1401
  }
1402

1403
  return 0;
1404
}
1405
#endif
1406

1407
static int32_t mndFindSuperTableTagIndex(const SStbObj *pStb, const char *tagName) {
3,473,627✔
1408
  for (int32_t tag = 0; tag < pStb->numOfTags; tag++) {
27,094,046✔
1409
    if (strcmp(pStb->pTags[tag].name, tagName) == 0) {
24,500,702✔
1410
      return tag;
880,283✔
1411
    }
1412
  }
1413

1414
  return -1;
2,593,344✔
1415
}
1416

1417
static int32_t mndFindSuperTableColumnIndex(const SStbObj *pStb, const char *colName) {
5,396,353✔
1418
  for (int32_t col = 0; col < pStb->numOfColumns; col++) {
296,462,578✔
1419
    if (strcmp(pStb->pColumns[col].name, colName) == 0) {
293,794,478✔
1420
      return col;
2,728,253✔
1421
    }
1422
  }
1423

1424
  return -1;
2,668,100✔
1425
}
1426

1427
static bool mndValidateSchema(SSchema *pSchemas, int32_t nSchema, SArray *pFields, int32_t maxLen) {
2,833,943✔
1428
  int32_t rowLen = 0;
2,833,943✔
1429
  for (int32_t i = 0; i < nSchema; ++i) {
190,774,443✔
1430
    rowLen += (pSchemas + i)->bytes;
187,940,500✔
1431
  }
1432

1433
  int32_t nField = taosArrayGetSize(pFields);
2,833,943✔
1434
  for (int32_t i = 0; i < nField; ++i) {
5,667,886✔
1435
    rowLen += ((SField *)TARRAY_GET_ELEM(pFields, i))->bytes;
2,833,943✔
1436
  }
1437

1438
  return rowLen <= maxLen;
2,833,943✔
1439
}
1440

1441
static int32_t mndBuildStbFromAlter(SStbObj *pStb, SStbObj *pDst, SMCreateStbReq *createReq) {
33,662✔
1442
  int32_t code = 0;
33,662✔
1443
  taosRLockLatch(&pStb->lock);
33,662✔
1444
  memcpy(pDst, pStb, sizeof(SStbObj));
33,662✔
1445
  taosRUnLockLatch(&pStb->lock);
33,662✔
1446

1447
  pDst->source = createReq->source;
33,662✔
1448
  pDst->updateTime = taosGetTimestampMs();
33,662✔
1449
  pDst->numOfColumns = createReq->numOfColumns;
33,662✔
1450
  pDst->numOfTags = createReq->numOfTags;
33,662✔
1451
  pDst->pColumns = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SSchema));
33,662✔
1452
  pDst->pTags = taosMemoryCalloc(1, pDst->numOfTags * sizeof(SSchema));
33,662✔
1453
  pDst->pCmpr = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SColCmpr));
33,662✔
1454
  pDst->pExtSchemas = taosMemoryCalloc(pDst->numOfColumns, sizeof(SExtSchema));
33,662✔
1455

1456
  if (pDst->pColumns == NULL || pDst->pTags == NULL || pDst->pCmpr == NULL || pDst->pExtSchemas == NULL) {
33,662✔
1457
    code = terrno;
×
1458
    TAOS_RETURN(code);
×
1459
  }
1460

1461
  if (pDst->nextColId < 0 || pDst->nextColId >= 0x7fff - pDst->numOfColumns - pDst->numOfTags) {
33,662✔
UNCOV
1462
    code = TSDB_CODE_OUT_OF_RANGE;
×
UNCOV
1463
    TAOS_RETURN(code);
×
1464
  }
1465

1466
  for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
241,040✔
1467
    SFieldWithOptions *pField = taosArrayGet(createReq->pColumns, i);
207,378✔
1468
    SSchema           *pSchema = &pDst->pColumns[i];
207,378✔
1469
    pSchema->type = pField->type;
207,378✔
1470
    pSchema->bytes = pField->bytes;
207,378✔
1471
    pSchema->flags = pField->flags;
207,378✔
1472
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
207,378✔
1473
    int32_t cIndex = mndFindSuperTableColumnIndex(pStb, pField->name);
207,378✔
1474
    if (cIndex >= 0) {
207,378✔
1475
      pSchema->colId = pStb->pColumns[cIndex].colId;
191,972✔
1476
    } else {
1477
      pSchema->colId = pDst->nextColId++;
15,406✔
1478
    }
1479
  }
1480

1481
  for (int32_t i = 0; i < pDst->numOfTags; ++i) {
229,655✔
1482
    SField  *pField = taosArrayGet(createReq->pTags, i);
195,993✔
1483
    SSchema *pSchema = &pDst->pTags[i];
195,993✔
1484
    pSchema->type = pField->type;
195,993✔
1485
    pSchema->bytes = pField->bytes;
195,993✔
1486
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
195,993✔
1487
    int32_t cIndex = mndFindSuperTableTagIndex(pStb, pField->name);
195,993✔
1488
    if (cIndex >= 0) {
195,993✔
1489
      pSchema->colId = pStb->pTags[cIndex].colId;
185,401✔
1490
    } else {
1491
      pSchema->colId = pDst->nextColId++;
10,592✔
1492
    }
1493
  }
1494
  for (int32_t i = 0; i < pDst->numOfColumns; i++) {
241,040✔
1495
    SColCmpr          *p = pDst->pCmpr + i;
207,378✔
1496
    SFieldWithOptions *pField = taosArrayGet(createReq->pColumns, i);
207,378✔
1497
    SSchema           *pSchema = &pDst->pColumns[i];
207,378✔
1498
    p->id = pSchema->colId;
207,378✔
1499
    if (pField->compress == 0) {
207,378✔
UNCOV
1500
      p->alg = createDefaultColCmprByType(pSchema->type);
×
1501
    } else {
1502
      p->alg = pField->compress;
207,378✔
1503
    }
1504
    if (pField->flags & COL_HAS_TYPE_MOD) {
207,378✔
1505
      pDst->pExtSchemas[i].typeMod = pField->typeMod;
4,288✔
1506
    }
1507
  }
1508
  pDst->tagVer = createReq->tagVer;
33,662✔
1509
  pDst->colVer = createReq->colVer;
33,662✔
1510
  return TSDB_CODE_SUCCESS;
33,662✔
1511
}
1512

1513
// used for tmq_get_json_meta to build alter msg
1514
static void buildAlterMsg(SStbObj *pStb, SStbObj *pDst, void** pAlterBuf, int32_t* len){
33,662✔
1515
  SMAlterStbReq alterReq = {0};
33,662✔
1516
  alterReq.pFields = taosArrayInit(2, sizeof(SField));
33,662✔
1517
  if (NULL == alterReq.pFields) {
33,662✔
UNCOV
1518
    mError("failed to init alter fields array");
×
UNCOV
1519
    goto END;
×
1520
  }
1521
  tstrncpy(alterReq.name, pStb->name, TSDB_TABLE_FNAME_LEN);
33,662✔
1522
  for (int32_t i = 0; i < pDst->numOfColumns && taosArrayGetSize(alterReq.pFields) == 0; ++i) {
232,490✔
1523
    SSchema           *pSchema = &pDst->pColumns[i];
198,828✔
1524
    int32_t cIndex = mndFindSuperTableColumnIndex(pStb, pSchema->name);
198,828✔
1525
    if (cIndex >= 0 && pSchema->bytes == pStb->pColumns[cIndex].bytes) {
198,828✔
1526
      continue;
180,020✔
1527
    }
1528
    if (cIndex < 0) {
18,808✔
1529
      alterReq.alterType = TSDB_ALTER_TABLE_ADD_COLUMN;
15,406✔
1530
    } else if (pSchema->bytes > pStb->pColumns[cIndex].bytes){
3,402✔
1531
      alterReq.alterType = TSDB_ALTER_TABLE_UPDATE_COLUMN_BYTES;
3,402✔
1532
    }
1533
    SField *pAlterField = taosArrayReserve(alterReq.pFields, 1);
18,808✔
1534
    pAlterField->type = pSchema->type;
18,808✔
1535
    pAlterField->bytes = pSchema->bytes;
18,808✔
1536
    tstrncpy(pAlterField->name, pSchema->name, TSDB_COL_NAME_LEN);
18,808✔
1537
    mDebug("alter column name:%s, type:%d, bytes:%d", pAlterField->name, pAlterField->type, pAlterField->bytes);
18,808✔
1538
  }
1539

1540
  for (int32_t i = 0; i < pDst->numOfTags && taosArrayGetSize(alterReq.pFields) == 0; ++i) {
139,070✔
1541
    SSchema *pSchema = &pDst->pTags[i];
105,408✔
1542
    int32_t cIndex = mndFindSuperTableTagIndex(pStb, pSchema->name);
105,408✔
1543
    if (cIndex >= 0 && pSchema->bytes == pStb->pTags[cIndex].bytes) {
105,408✔
1544
      continue;
91,626✔
1545
    }
1546
    if (cIndex < 0) {
13,782✔
1547
      alterReq.alterType = TSDB_ALTER_TABLE_ADD_TAG;
10,592✔
1548
    } else if (pSchema->bytes > pStb->pTags[cIndex].bytes){
3,190✔
1549
      alterReq.alterType = TSDB_ALTER_TABLE_UPDATE_TAG_BYTES;
3,190✔
1550
    }
1551
    SField *pAlterField = taosArrayReserve(alterReq.pFields, 1);
13,782✔
1552
    pAlterField->type = pSchema->type;
13,782✔
1553
    pAlterField->bytes = pSchema->bytes;
13,782✔
1554
    tstrncpy(pAlterField->name, pSchema->name, TSDB_COL_NAME_LEN);
13,782✔
1555
    mDebug("alter tag name:%s, type:%d, bytes:%d", pAlterField->name, pAlterField->type, pAlterField->bytes);
13,782✔
1556
  }
1557
  alterReq.numOfFields = taosArrayGetSize(alterReq.pFields);
33,662✔
1558
  if (alterReq.numOfFields == 0) {
33,662✔
1559
    mError("no valid alter field found");
1,072✔
1560
    goto END;
1,072✔
1561
  }
1562

1563
  int32_t contLen = tSerializeSMAlterStbReq(NULL, 0, &alterReq);
32,590✔
1564
  if (contLen <= 0) {
32,590✔
UNCOV
1565
    mError("failed to get alter stb req len");
×
UNCOV
1566
    goto END;
×
1567
  }
1568
  void*   buf = taosMemoryMalloc(contLen);
32,590✔
1569
  if (buf == NULL) {
32,590✔
UNCOV
1570
    mError("failed to malloc alter stb req buf");
×
UNCOV
1571
    goto END;
×
1572
  }
1573
  int32_t code = tSerializeSMAlterStbReq(buf, contLen, &alterReq);
32,590✔
1574
  if (code <= TSDB_CODE_SUCCESS) {
32,590✔
UNCOV
1575
    mError("failed to serialize alter stb req %d", code);
×
UNCOV
1576
    taosMemoryFreeClear(buf);
×
UNCOV
1577
    goto END;
×
1578
  }
1579
  *pAlterBuf = buf;
32,590✔
1580
  *len = contLen;
32,590✔
1581
END:
33,662✔
1582
  taosArrayDestroy(alterReq.pFields);
33,662✔
1583
}
33,662✔
1584

1585
static int32_t mndProcessCreateStbReq(SRpcMsg *pReq) {
1,833,464✔
1586
  SMnode        *pMnode = pReq->info.node;
1,833,464✔
1587
  int32_t        code = -1;
1,833,464✔
1588
  SStbObj       *pStb = NULL;
1,833,464✔
1589
  SDbObj        *pDb = NULL;
1,833,464✔
1590
  SUserObj      *pOperUser = NULL;
1,833,464✔
1591
  SMCreateStbReq createReq = {0};
1,833,464✔
1592
  bool           isAlter = false;
1,833,464✔
1593
  SHashObj      *pHash = NULL;
1,833,464✔
1594
  int64_t        tss = taosGetTimestampMs();
1,833,464✔
1595

1596
  if (tDeserializeSMCreateStbReq(pReq->pCont, pReq->contLen, &createReq) != 0) {
1,833,464✔
UNCOV
1597
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
1598
    goto _OVER;
×
1599
  }
1600

1601
  mInfo("stb:%s, start to create", createReq.name);
1,833,464✔
1602
  if (mndCheckCreateStbReq(&createReq) != 0) {
1,833,464✔
UNCOV
1603
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
1604
    goto _OVER;
×
1605
  }
1606

1607
  pStb = mndAcquireStb(pMnode, createReq.name);
1,833,464✔
1608
  if (pStb != NULL) {
1,833,464✔
1609
    if (createReq.igExists) {
51,899✔
1610
      if (createReq.source == TD_REQ_FROM_APP) {
50,707✔
1611
        mInfo("stb:%s, already exist, ignore exist is set", createReq.name);
3,539✔
1612
        code = 0;
3,539✔
1613
        goto _OVER;
3,539✔
1614
      } else if (pStb->uid != createReq.suid) {
47,168✔
UNCOV
1615
        mInfo("stb:%s, alter table does not need to be done, because table is deleted", createReq.name);
×
UNCOV
1616
        code = 0;
×
UNCOV
1617
        goto _OVER;
×
1618
      } else if (createReq.tagVer > 0 || createReq.colVer > 0) {
80,830✔
1619
        int32_t tagDelta = createReq.tagVer - pStb->tagVer;
47,168✔
1620
        int32_t colDelta = createReq.colVer - pStb->colVer;
47,168✔
1621
        mInfo("stb:%s, already exist while create, input tagVer:%d colVer:%d, exist tagVer:%d colVer:%d",
47,168✔
1622
              createReq.name, createReq.tagVer, createReq.colVer, pStb->tagVer, pStb->colVer);
1623
        if (tagDelta <= 0 && colDelta <= 0) {
47,168✔
1624
          mInfo("stb:%s, schema version is not incremented and nothing needs to be done", createReq.name);
13,506✔
1625
          code = 0;
13,506✔
1626
          goto _OVER;
13,506✔
1627
        } else if ((tagDelta == 1 && colDelta == 0) || (tagDelta == 0 && colDelta == 1) ||
33,662✔
UNCOV
1628
                   (pStb->colVer == 1 && createReq.colVer > 1) || (pStb->tagVer == 1 && createReq.tagVer > 1)) {
×
1629
          isAlter = true;
33,662✔
1630
          mInfo("stb:%s, schema version is only increased by 1 number, do alter operation", createReq.name);
33,662✔
1631
        } else {
UNCOV
1632
          mError("stb:%s, schema version increase more than 1 number, error is returned", createReq.name);
×
UNCOV
1633
          code = TSDB_CODE_MND_INVALID_SCHEMA_VER;
×
UNCOV
1634
          goto _OVER;
×
1635
        }
1636
      } else {
UNCOV
1637
        mError("stb:%s, already exist while create, input tagVer:%d colVer:%d is invalid, origin tagVer:%d colVer:%d",
×
1638
               createReq.name, createReq.tagVer, createReq.colVer, pStb->tagVer, pStb->colVer);
UNCOV
1639
        code = TSDB_CODE_MND_INVALID_SCHEMA_VER;
×
UNCOV
1640
        goto _OVER;
×
1641
      }
1642
    } else {
1643
      code = TSDB_CODE_MND_STB_ALREADY_EXIST;
1,192✔
1644
      goto _OVER;
1,192✔
1645
    }
1646
  } else if (terrno != TSDB_CODE_MND_STB_NOT_EXIST) {
1,781,565✔
UNCOV
1647
    goto _OVER;
×
1648
  } else if ((createReq.source == TD_REQ_FROM_TAOX_OLD || createReq.source == TD_REQ_FROM_TAOX || createReq.source == TD_REQ_FROM_SML) &&
1,781,565✔
1649
             (createReq.tagVer != 1 || createReq.colVer != 1)) {
15,189✔
1650
    mInfo("stb:%s, alter table does not need to be done, because table is deleted", createReq.name);
804✔
1651
    code = 0;
804✔
1652
    goto _OVER;
804✔
1653
  }
1654

1655
  pHash = taosHashInit(createReq.numOfColumns + createReq.numOfTags, taosGetDefaultHashFunction(TSDB_DATA_TYPE_BINARY),
1,814,423✔
1656
                       false, HASH_NO_LOCK);
1657
  if (pHash == NULL) {
1,814,423✔
UNCOV
1658
    code = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
1659
    goto _OVER;
×
1660
  }
1661

1662
  for (int32_t i = 0; i < createReq.numOfColumns; ++i) {
149,200,634✔
1663
    SFieldWithOptions *pField = taosArrayGet(createReq.pColumns, i);
147,386,211✔
1664
    if ((code = taosHashPut(pHash, pField->name, strlen(pField->name), NULL, 0)) != 0) {
147,386,211✔
UNCOV
1665
      if (code == TSDB_CODE_DUP_KEY) {
×
UNCOV
1666
        code = TSDB_CODE_TSC_DUP_COL_NAMES;
×
1667
      }
UNCOV
1668
      goto _OVER;
×
1669
    }
1670
  }
1671

1672
  for (int32_t i = 0; i < createReq.numOfTags; ++i) {
9,616,163✔
1673
    SField *pField = taosArrayGet(createReq.pTags, i);
7,801,740✔
1674
    if ((code = taosHashPut(pHash, pField->name, strlen(pField->name), NULL, 0)) != 0) {
7,801,740✔
UNCOV
1675
      if (code == TSDB_CODE_DUP_KEY) {
×
1676
        code = TSDB_CODE_TSC_DUP_COL_NAMES;
×
1677
      }
UNCOV
1678
      goto _OVER;
×
1679
    }
1680
  }
1681

1682
  pDb = mndAcquireDbByStb(pMnode, createReq.name);
1,814,423✔
1683
  if (pDb == NULL) {
1,814,423✔
UNCOV
1684
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
UNCOV
1685
    goto _OVER;
×
1686
  }
1687

1688
  if ((code = mndAcquireUser(pMnode, (RPC_MSG_USER(pReq)), &pOperUser))) {
1,814,423✔
UNCOV
1689
    goto _OVER;
×
1690
  }
1691

1692
  if ((code = mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB, pDb))) {
1,814,423✔
UNCOV
1693
    goto _OVER;
×
1694
  }
1695

1696
  if ((code =
1,814,423✔
1697
           mndCheckDbPrivilegeByNameRecF(pMnode, pOperUser, pDb->cfg.isAudit ? PRIV_AUDIT_TBL_CREATE : PRIV_TBL_CREATE,
1,814,423✔
1698
                                         pDb->cfg.isAudit ? PRIV_OBJ_CLUSTER : PRIV_OBJ_DB, pDb->name, NULL))) {
1,814,423✔
UNCOV
1699
    goto _OVER;
×
1700
  }
1701

1702
  if (pDb->cfg.isMount) {
1,814,423✔
UNCOV
1703
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
×
UNCOV
1704
    goto _OVER;
×
1705
  }
1706

1707
  int32_t numOfStbs = -1;
1,814,423✔
1708
  if ((code = mndGetNumOfStbs(pMnode, pDb->name, &numOfStbs)) != 0) {
1,814,423✔
UNCOV
1709
    goto _OVER;
×
1710
  }
1711

1712
  if (pDb->cfg.numOfStables == 1 && numOfStbs != 0) {
1,814,423✔
UNCOV
1713
    code = TSDB_CODE_MND_SINGLE_STB_MODE_DB;
×
UNCOV
1714
    goto _OVER;
×
1715
  }
1716

1717
  if ((code = grantCheck(TSDB_GRANT_STABLE)) < 0) {
1,814,423✔
UNCOV
1718
    goto _OVER;
×
1719
  }
1720

1721
  if (isAlter) {
1,814,423✔
1722
    bool    needRsp = false;
33,662✔
1723
    SStbObj pDst = {0};
33,662✔
1724
    if ((code = mndBuildStbFromAlter(pStb, &pDst, &createReq)) != 0) {
33,662✔
UNCOV
1725
      taosMemoryFreeClear(pDst.pTags);
×
UNCOV
1726
      taosMemoryFreeClear(pDst.pColumns);
×
UNCOV
1727
      taosMemoryFreeClear(pDst.pCmpr);
×
UNCOV
1728
      taosMemoryFreeClear(pDst.pExtSchemas);
×
UNCOV
1729
      goto _OVER;
×
1730
    }
1731
    void* buf = NULL;
33,662✔
1732
    int32_t contLen = 0;
33,662✔
1733
    buildAlterMsg(pStb, &pDst, &buf, &contLen);
33,662✔
1734
    code = mndAlterStbImp(pMnode, pReq, pDb, &pDst, needRsp, buf, contLen);
33,662✔
1735
    taosMemoryFree(buf);
33,662✔
1736
    taosMemoryFreeClear(pDst.pTags);
33,662✔
1737
    taosMemoryFreeClear(pDst.pColumns);
33,662✔
1738
    taosMemoryFreeClear(pDst.pCmpr);
33,662✔
1739
    taosMemoryFreeClear(pDst.pExtSchemas);
33,662✔
1740
  } else {
1741
    code = mndCreateStb(pMnode, pReq, &createReq, pDb, pOperUser);
1,780,761✔
1742
  }
1743
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
1,814,423✔
1744

1745
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
1,814,423✔
1746
    SName name = {0};
1,814,423✔
1747
    TAOS_CHECK_RETURN(tNameFromString(&name, createReq.name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
1,814,423✔
1748

1749
    int64_t tse = taosGetTimestampMs();
1,814,423✔
1750
    double  duration = (double)(tse - tss);
1,814,423✔
1751
    duration = duration / 1000;
1,814,423✔
1752
    if (createReq.sql == NULL && createReq.sqlLen == 0) {
1,814,423✔
1753
      char detail[1000] = {0};
384,050✔
1754

1755
      (void)tsnprintf(detail, sizeof(detail), "dbname:%s, stable name:%s", name.dbname, name.tname);
384,050✔
1756

1757
      auditRecord(pReq, pMnode->clusterId, "createStb", name.dbname, name.tname, detail, strlen(detail), duration, 0);
384,050✔
1758
    } else {
1759
      auditRecord(pReq, pMnode->clusterId, "createStb", name.dbname, name.tname, createReq.sql, createReq.sqlLen,
1,430,373✔
1760
                  duration, 0);
1761
    }
1762
  }
1763
_OVER:
1,833,262✔
1764
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
1,833,464✔
1765
    mError("stb:%s, failed to create since %s", createReq.name, tstrerror(code));
9,300✔
1766
  }
1767

1768
  mndReleaseStb(pMnode, pStb);
1,833,464✔
1769
  mndReleaseDb(pMnode, pDb);
1,833,464✔
1770
  mndReleaseUser(pMnode, pOperUser);
1,833,464✔
1771
  tFreeSMCreateStbReq(&createReq);
1,833,464✔
1772

1773
  if (pHash != NULL) {
1,833,464✔
1774
    taosHashCleanup(pHash);
1,814,423✔
1775
  }
1776

1777
  TAOS_RETURN(code);
1,833,464✔
1778
}
1779

1780
static int32_t mndCheckAlterStbReq(SMAlterStbReq *pAlter) {
5,479,721✔
1781
  int32_t code = 0;
5,479,721✔
1782
  if (pAlter->commentLen >= 0) return 0;
5,479,721✔
1783
  if (pAlter->ttl != 0) return 0;
12,948✔
1784
  if (pAlter->keep != -1) return 0;
12,948✔
1785

UNCOV
1786
  if (pAlter->numOfFields < 1 || pAlter->numOfFields != (int32_t)taosArrayGetSize(pAlter->pFields)) {
×
UNCOV
1787
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
1788
    TAOS_RETURN(code);
×
1789
  }
1790

UNCOV
1791
  for (int32_t i = 0; i < pAlter->numOfFields; ++i) {
×
UNCOV
1792
    SField *pField = taosArrayGet(pAlter->pFields, i);
×
UNCOV
1793
    if (pField->name[0] == 0) {
×
1794
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
1795
      TAOS_RETURN(code);
×
1796
    }
1797
  }
1798

UNCOV
1799
  TAOS_RETURN(code);
×
1800
}
1801

1802
int32_t mndAllocStbSchemas(const SStbObj *pOld, SStbObj *pNew) {
5,240,122✔
1803
  pNew->pTags = taosMemoryCalloc(pNew->numOfTags, sizeof(SSchema));
5,240,122✔
1804
  pNew->pColumns = taosMemoryCalloc(pNew->numOfColumns, sizeof(SSchema));
5,240,122✔
1805
  pNew->pCmpr = taosMemoryCalloc(pNew->numOfColumns, sizeof(SColCmpr));
5,240,122✔
1806
  if (pNew->pTags == NULL || pNew->pColumns == NULL || pNew->pCmpr == NULL) {
5,240,122✔
UNCOV
1807
    TAOS_RETURN(terrno);
×
1808
  }
1809

1810
  memcpy(pNew->pColumns, pOld->pColumns, sizeof(SSchema) * pOld->numOfColumns);
5,240,122✔
1811
  memcpy(pNew->pTags, pOld->pTags, sizeof(SSchema) * pOld->numOfTags);
5,240,122✔
1812
  memcpy(pNew->pCmpr, pOld->pCmpr, sizeof(SColCmpr) * pOld->numOfColumns);
5,240,122✔
1813
  if (pOld->pExtSchemas) {
5,240,122✔
1814
    pNew->pExtSchemas = taosMemoryCalloc(pNew->numOfColumns, sizeof(SExtSchema));
4,179,280✔
1815
    if (pNew->pExtSchemas == NULL) {
4,179,280✔
1816
      TAOS_RETURN(terrno);
×
1817
    }
1818
    memcpy(pNew->pExtSchemas, pOld->pExtSchemas, sizeof(SExtSchema) * pOld->numOfColumns);
4,179,280✔
1819
  }
1820

1821
  TAOS_RETURN(0);
5,240,122✔
1822
}
1823

1824
static int32_t mndUpdateTableOptions(const SStbObj *pOld, SStbObj *pNew, char *pComment, int32_t commentLen,
23,414✔
1825
                                     int32_t ttl, int64_t keep) {
1826
  int32_t code = 0;
23,414✔
1827
  if (commentLen > 0) {
23,414✔
1828
    pNew->commentLen = commentLen;
5,900✔
1829
    pNew->comment = taosMemoryCalloc(1, commentLen + 1);
5,900✔
1830
    if (pNew->comment == NULL) {
5,900✔
UNCOV
1831
      terrno = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
1832
      return -1;
×
1833
    }
1834
    memcpy(pNew->comment, pComment, commentLen + 1);
5,900✔
1835
  } else if (commentLen == 0) {
17,514✔
1836
    pNew->commentLen = 0;
4,566✔
1837
  } else {
1838
  }
1839

1840
  if (ttl >= 0) {
23,414✔
1841
    pNew->ttl = ttl;
23,414✔
1842
  }
1843

1844
  if (keep > 0) {
23,414✔
1845
    pNew->keep = keep;
12,948✔
1846
  }
1847

1848
  if ((code = mndAllocStbSchemas(pOld, pNew)) != 0) {
23,414✔
UNCOV
1849
    TAOS_RETURN(code);
×
1850
  }
1851
  TAOS_RETURN(code);
23,414✔
1852
}
1853

1854
static int32_t mndAddSuperTableTag(const SStbObj *pOld, SStbObj *pNew, SArray *pFields, int32_t ntags) {
273,665✔
1855
  int32_t code = 0;
273,665✔
1856
  if (pOld->numOfTags + ntags > TSDB_MAX_TAGS) {
273,665✔
UNCOV
1857
    code = TSDB_CODE_MND_TOO_MANY_TAGS;
×
1858
    TAOS_RETURN(code);
×
1859
  }
1860

1861
  int32_t maxColumns = pOld->virtualStb ? TSDB_MAX_COLUMNS : TSDB_MAX_COLUMNS_NON_VIRTUAL;
273,665✔
1862
  if (pOld->numOfColumns + ntags + pOld->numOfTags > maxColumns) {
273,665✔
UNCOV
1863
    code = TSDB_CODE_MND_TOO_MANY_COLUMNS;
×
UNCOV
1864
    TAOS_RETURN(code);
×
1865
  }
1866

1867
  if (!mndValidateSchema(pOld->pTags, pOld->numOfTags, pFields, TSDB_MAX_TAGS_LEN)) {
273,665✔
1868
    code = TSDB_CODE_PAR_INVALID_TAGS_LENGTH;
24,434✔
1869
    TAOS_RETURN(code);
24,434✔
1870
  }
1871

1872
  pNew->numOfTags = pNew->numOfTags + ntags;
249,231✔
1873
  if ((code = mndAllocStbSchemas(pOld, pNew)) != 0) {
249,231✔
UNCOV
1874
    TAOS_RETURN(code);
×
1875
  }
1876

1877
  if (pNew->nextColId < 0 || pNew->nextColId >= 0x7fff - ntags) {
249,231✔
1878
    code = TSDB_CODE_OUT_OF_RANGE;
1,064✔
1879
    TAOS_RETURN(code);
1,064✔
1880
  }
1881

1882
  for (int32_t i = 0; i < ntags; i++) {
429,920✔
1883
    SField *pField = taosArrayGet(pFields, i);
248,167✔
1884
    if (mndFindSuperTableColumnIndex(pOld, pField->name) >= 0) {
248,167✔
1885
      code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
1,941✔
1886
      TAOS_RETURN(code);
1,941✔
1887
    }
1888

1889
    if (mndFindSuperTableTagIndex(pOld, pField->name) >= 0) {
246,226✔
1890
      code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
64,473✔
1891
      TAOS_RETURN(code);
64,473✔
1892
    }
1893

1894
    SSchema *pSchema = &pNew->pTags[pOld->numOfTags + i];
181,753✔
1895
    pSchema->bytes = pField->bytes;
181,753✔
1896
    pSchema->type = pField->type;
181,753✔
1897
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
181,753✔
1898
    if (pNew->nextColId > INT16_MAX) {
181,753✔
UNCOV
1899
      code = TSDB_CODE_MND_EXCEED_MAX_COL_ID;
×
UNCOV
1900
      TAOS_RETURN(code);
×
1901
    }
1902
    pSchema->colId = pNew->nextColId;
181,753✔
1903
    pNew->nextColId++;
181,753✔
1904

1905
    mInfo("stb:%s, start to add tag %s", pNew->name, pSchema->name);
181,753✔
1906
  }
1907

1908
  pNew->tagVer++;
181,753✔
1909
  TAOS_RETURN(code);
181,753✔
1910
}
1911

1912
static int32_t mndCheckAlterColForTSma(SMnode *pMnode, const char *stbFullName, int64_t suid, col_id_t colId, bool isTag) {
2,489,318✔
1913
  int32_t code = 0;
2,489,318✔
1914
  SSdb   *pSdb = pMnode->pSdb;
2,489,318✔
1915
  void   *pIter = NULL;
2,489,318✔
UNCOV
1916
  while (1) {
×
1917
    SSmaObj *pSma = NULL;
2,489,318✔
1918
    pIter = sdbFetch(pSdb, SDB_SMA, pIter, (void **)&pSma);
2,489,318✔
1919
    if (pIter == NULL) break;
2,489,318✔
1920

1921
    mInfo("tsma:%s, check tag and column modifiable, stb:%s suid:%" PRId64 " colId:%d, sql:%s", pSma->name, stbFullName,
220✔
1922
          suid, colId, pSma->sql);
1923

1924
    if (isTag) {
220✔
1925
      code = TSDB_CODE_MND_FIELD_CONFLICT_WITH_TSMA;
220✔
1926
      mError("tsma:%s, check tag:%d conflicted", pSma->name, colId);
220✔
1927
      sdbRelease(pSdb, pSma);
220✔
1928
      sdbCancelFetch(pSdb, pIter);
220✔
1929
      TAOS_RETURN(code);
220✔
1930
    }
1931

1932
    SNode *pAst = NULL;
×
1933
    if (nodesStringToNode(pSma->ast, &pAst) != 0) {
×
UNCOV
1934
      code = TSDB_CODE_SDB_INVALID_DATA_CONTENT;
×
UNCOV
1935
      mError("tsma:%s, check tag and column modifiable, stb:%s suid:%" PRId64 " colId:%d failed since parse AST err",
×
1936
             pSma->name, stbFullName, suid, colId);
1937
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
1938
      TAOS_RETURN(code);
×
1939
    }
1940

UNCOV
1941
    SNodeList *pNodeList = NULL;
×
UNCOV
1942
    if ((code = nodesCollectColumns((SSelectStmt *)pAst, SQL_CLAUSE_FROM, NULL, COLLECT_COL_TYPE_ALL, &pNodeList)) !=
×
1943
        0) {
1944
      sdbCancelFetch(pSdb, pIter);
×
1945
      TAOS_RETURN(code);
×
1946
    }
1947
    SNode *pNode = NULL;
×
1948
    FOREACH(pNode, pNodeList) {
×
UNCOV
1949
      SColumnNode *pCol = (SColumnNode *)pNode;
×
UNCOV
1950
      mInfo("tsma:%s, check colId:%d tableId:%" PRId64, pSma->name, pCol->colId, pCol->tableId);
×
1951

UNCOV
1952
      if ((pCol->tableId != suid) && (pSma->stbUid != suid)) {
×
UNCOV
1953
        mInfo("tsma:%s, check colId:%d passed", pSma->name, pCol->colId);
×
UNCOV
1954
        goto NEXT;
×
1955
      }
UNCOV
1956
      if ((pCol->colId) > 0 && (pCol->colId == colId)) {
×
UNCOV
1957
        code = TSDB_CODE_MND_FIELD_CONFLICT_WITH_TSMA;
×
UNCOV
1958
        mError("tsma:%s, check colId:%d conflicted", pSma->name, pCol->colId);
×
UNCOV
1959
        nodesDestroyNode(pAst);
×
UNCOV
1960
        nodesDestroyList(pNodeList);
×
UNCOV
1961
        sdbRelease(pSdb, pSma);
×
UNCOV
1962
        sdbCancelFetch(pSdb, pIter);
×
UNCOV
1963
        TAOS_RETURN(code);
×
1964
      }
UNCOV
1965
      mInfo("tsma:%s, check colId:%d passed", pSma->name, pCol->colId);
×
1966
    }
1967

UNCOV
1968
  NEXT:
×
UNCOV
1969
    sdbRelease(pSdb, pSma);
×
UNCOV
1970
    nodesDestroyNode(pAst);
×
UNCOV
1971
    nodesDestroyList(pNodeList);
×
1972
  }
1973
  TAOS_RETURN(code);
2,489,098✔
1974
}
1975

1976
static int32_t mndDropSuperTableTag(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const char *tagName) {
100,873✔
1977
  int32_t code = 0;
100,873✔
1978
  int32_t tag = mndFindSuperTableTagIndex(pOld, tagName);
100,873✔
1979
  if (tag < 0) {
100,873✔
UNCOV
1980
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
×
UNCOV
1981
    TAOS_RETURN(code);
×
1982
  }
1983

1984
  col_id_t colId = pOld->pTags[tag].colId;
100,873✔
1985
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, pOld->name, pOld->uid, colId, true));
100,873✔
1986

1987
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
100,763✔
1988

1989
  memmove(pNew->pTags + tag, pNew->pTags + tag + 1, sizeof(SSchema) * (pNew->numOfTags - tag - 1));
100,763✔
1990
  pNew->numOfTags--;
100,763✔
1991

1992
  pNew->tagVer++;
100,763✔
1993

1994
  // if (mndDropIndexByTag(pMnode, pOld, tagName) != 0) {
1995
  //   return -1;
1996
  // }
1997
  mInfo("stb:%s, start to drop tag %s", pNew->name, tagName);
100,763✔
1998
  TAOS_RETURN(code);
100,763✔
1999
}
2000

2001
static int32_t mndAlterStbTagName(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, SArray *pFields) {
115,659✔
2002
  int32_t code = 0;
115,659✔
2003
  if ((int32_t)taosArrayGetSize(pFields) != 2) {
115,659✔
UNCOV
2004
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
2005
    TAOS_RETURN(code);
×
2006
  }
2007

2008
  SField *pField0 = taosArrayGet(pFields, 0);
115,659✔
2009
  SField *pField1 = taosArrayGet(pFields, 1);
115,659✔
2010

2011
  const char *oldTagName = pField0->name;
115,659✔
2012
  const char *newTagName = pField1->name;
115,659✔
2013

2014
  int32_t tag = mndFindSuperTableTagIndex(pOld, oldTagName);
115,659✔
2015
  if (tag < 0) {
115,659✔
2016
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
3,227✔
2017
    TAOS_RETURN(code);
3,227✔
2018
  }
2019

2020
  col_id_t colId = pOld->pTags[tag].colId;
112,432✔
2021
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, pOld->name, pOld->uid, colId, true));
112,432✔
2022

2023
  if (mndFindSuperTableTagIndex(pOld, newTagName) >= 0) {
112,322✔
2024
    code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
5,796✔
2025
    TAOS_RETURN(code);
5,796✔
2026
  }
2027

2028
  if (mndFindSuperTableColumnIndex(pOld, newTagName) >= 0) {
106,526✔
UNCOV
2029
    code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
×
UNCOV
2030
    TAOS_RETURN(code);
×
2031
  }
2032

2033
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
106,526✔
2034

2035
  SSchema *pSchema = (SSchema *)(pNew->pTags + tag);
106,526✔
2036
  memcpy(pSchema->name, newTagName, TSDB_COL_NAME_LEN);
106,526✔
2037

2038
  pNew->tagVer++;
106,526✔
2039
  mInfo("stb:%s, start to modify tag %s to %s", pNew->name, oldTagName, newTagName);
106,526✔
2040
  TAOS_RETURN(code);
106,526✔
2041
}
2042

2043
static int32_t mndAlterStbTagBytes(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const SField *pField) {
314,551✔
2044
  int32_t code = 0;
314,551✔
2045
  int32_t tag = mndFindSuperTableTagIndex(pOld, pField->name);
314,551✔
2046
  if (tag < 0) {
314,551✔
UNCOV
2047
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
×
UNCOV
2048
    TAOS_RETURN(code);
×
2049
  }
2050

2051
  col_id_t colId = pOld->pTags[tag].colId;
314,551✔
2052
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, pOld->name, pOld->uid, colId, true));
314,551✔
2053

2054
  uint32_t nLen = 0;
314,551✔
2055
  for (int32_t i = 0; i < pOld->numOfTags; ++i) {
12,585,695✔
2056
    nLen += (pOld->pTags[i].colId == colId) ? pField->bytes : pOld->pTags[i].bytes;
12,271,144✔
2057
  }
2058

2059
  if (nLen > TSDB_MAX_TAGS_LEN) {
314,551✔
2060
    code = TSDB_CODE_PAR_INVALID_TAGS_LENGTH;
181,326✔
2061
    TAOS_RETURN(code);
181,326✔
2062
  }
2063

2064
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
133,225✔
2065

2066
  SSchema *pTag = pNew->pTags + tag;
133,225✔
2067

2068
  if (!(pTag->type == TSDB_DATA_TYPE_BINARY || pTag->type == TSDB_DATA_TYPE_VARBINARY ||
133,225✔
2069
        pTag->type == TSDB_DATA_TYPE_NCHAR || pTag->type == TSDB_DATA_TYPE_GEOMETRY)) {
128,064✔
UNCOV
2070
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
2071
    TAOS_RETURN(code);
×
2072
  }
2073

2074
  if (pField->bytes <= pTag->bytes) {
133,225✔
2075
    code = TSDB_CODE_MND_INVALID_ROW_BYTES;
39,866✔
2076
    TAOS_RETURN(code);
39,866✔
2077
  }
2078

2079
  pTag->bytes = pField->bytes;
93,359✔
2080
  pNew->tagVer++;
93,359✔
2081

2082
  mInfo("stb:%s, start to modify tag len %s to %d", pNew->name, pField->name, pField->bytes);
93,359✔
2083
  TAOS_RETURN(code);
93,359✔
2084
}
2085

2086
static int32_t mndUpdateSuperTableColumnCompress(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, SArray *pField,
89,592✔
2087
                                                 int32_t nCols) {
2088
  // if (pColCmpr == NULL || colName == NULL) return -1;
2089

2090
  if (taosArrayGetSize(pField) != nCols) return TSDB_CODE_FAILED;
89,592✔
2091
  TAOS_FIELD *p = taosArrayGet(pField, 0);
89,592✔
2092

2093
  int32_t code = 0;
89,592✔
2094
  int32_t idx = mndFindSuperTableColumnIndex(pOld, p->name);
89,592✔
2095
  if (idx == -1) {
89,592✔
UNCOV
2096
    code = TSDB_CODE_MND_COLUMN_NOT_EXIST;
×
UNCOV
2097
    TAOS_RETURN(code);
×
2098
  }
2099
  SSchema *pTarget = &pOld->pColumns[idx];
89,592✔
2100
  col_id_t colId = pTarget->colId;
89,592✔
2101

2102
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
89,592✔
2103
  code = validColCmprByType(pTarget->type, p->bytes);
89,592✔
2104
  if (code != TSDB_CODE_SUCCESS) {
89,592✔
2105
    TAOS_RETURN(code);
2,144✔
2106
  }
2107

2108
  int8_t updated = 0;
87,448✔
2109
  for (int i = 0; i < pNew->numOfColumns; i++) {
741,623✔
2110
    SColCmpr *pCmpr = &pNew->pCmpr[i];
741,623✔
2111
    if (pCmpr->id == colId) {
741,623✔
2112
      uint32_t dst = 0;
87,448✔
2113
      updated = tUpdateCompress(pCmpr->alg, p->bytes, TSDB_COLVAL_COMPRESS_DISABLED, TSDB_COLVAL_LEVEL_DISABLED,
87,448✔
2114
                                TSDB_COLVAL_LEVEL_MEDIUM, &dst);
2115
      if (updated > 0) pCmpr->alg = dst;
87,448✔
2116
      break;
87,448✔
2117
    }
2118
  }
2119

2120
  if (updated == 0) {
87,448✔
2121
    code = TSDB_CODE_MND_COLUMN_COMPRESS_ALREADY_EXIST;
7,567✔
2122
    TAOS_RETURN(code);
7,567✔
2123
  } else if (updated == -1) {
79,881✔
UNCOV
2124
    code = TSDB_CODE_TSC_COMPRESS_LEVEL_ERROR;
×
UNCOV
2125
    TAOS_RETURN(code);
×
2126
  }
2127

2128
  pNew->colVer++;
79,881✔
2129

2130
  TAOS_RETURN(code);
79,881✔
2131
}
2132
static int32_t mndAddSuperTableColumn(const SStbObj *pOld, SStbObj *pNew, const SMAlterStbReq* pReq, int32_t ncols,
2,560,278✔
2133
                                      int8_t withCompress) {
2134
  int32_t code = 0;
2,560,278✔
2135
  int32_t maxColumns = pOld->virtualStb ? TSDB_MAX_COLUMNS : TSDB_MAX_COLUMNS_NON_VIRTUAL;
2,560,278✔
2136
  int32_t maxBytesPerRow = pOld->virtualStb ? TSDB_MAX_BYTES_PER_ROW_VIRTUAL : TSDB_MAX_BYTES_PER_ROW;
2,560,278✔
2137
  if (pOld->numOfColumns + ncols + pOld->numOfTags > maxColumns) {
2,560,278✔
UNCOV
2138
    code = TSDB_CODE_MND_TOO_MANY_COLUMNS;
×
UNCOV
2139
    TAOS_RETURN(code);
×
2140
  }
2141

2142
  if ((code = grantCheck(TSDB_GRANT_TIMESERIES)) != 0) {
2,560,278✔
UNCOV
2143
    TAOS_RETURN(code);
×
2144
  }
2145

2146
  if (!mndValidateSchema(pOld->pColumns, pOld->numOfColumns, pReq->pFields, maxBytesPerRow)) {
2,560,278✔
2147
    code = TSDB_CODE_PAR_INVALID_ROW_LENGTH;
643✔
2148
    TAOS_RETURN(code);
643✔
2149
  }
2150

2151
  pNew->numOfColumns = pNew->numOfColumns + ncols;
2,559,635✔
2152

2153
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
2,559,635✔
2154

2155
  if (pNew->nextColId < 0 || pNew->nextColId >= 0x7fff - ncols) {
2,559,635✔
2156
    code = TSDB_CODE_OUT_OF_RANGE;
1,064✔
2157
    TAOS_RETURN(code);
1,064✔
2158
  }
2159

2160
  for (int32_t i = 0; i < ncols; i++) {
4,839,225✔
2161
    if (withCompress) {
2,558,571✔
2162
      SFieldWithOptions *pField = taosArrayGet(pReq->pFields, i);
247,094✔
2163
      if (mndFindSuperTableColumnIndex(pOld, pField->name) >= 0) {
247,094✔
2164
        code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
×
UNCOV
2165
        TAOS_RETURN(code);
×
2166
      }
2167

2168
      if (mndFindSuperTableTagIndex(pOld, pField->name) >= 0) {
247,094✔
2169
        code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
×
UNCOV
2170
        TAOS_RETURN(code);
×
2171
      }
2172

2173
      SSchema *pSchema = &pNew->pColumns[pOld->numOfColumns + i];
247,094✔
2174
      pSchema->bytes = pField->bytes;
247,094✔
2175
      pSchema->type = pField->type;
247,094✔
2176
      memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
247,094✔
2177
      if (pNew->nextColId > INT16_MAX) {
247,094✔
2178
        code = TSDB_CODE_MND_EXCEED_MAX_COL_ID;
×
2179
        TAOS_RETURN(code);
×
2180
      }
2181
      pSchema->colId = pNew->nextColId;
247,094✔
2182
      pNew->nextColId++;
247,094✔
2183

2184
      SColCmpr *pCmpr = &pNew->pCmpr[pOld->numOfColumns + i];
247,094✔
2185
      pCmpr->id = pSchema->colId;
247,094✔
2186
      pCmpr->alg = pField->compress;
247,094✔
2187
      mInfo("stb:%s, start to add column %s", pNew->name, pSchema->name);
247,094✔
2188
    } else {
2189
      SField *pField = taosArrayGet(pReq->pFields, i);
2,311,477✔
2190
      if (mndFindSuperTableColumnIndex(pOld, pField->name) >= 0) {
2,311,477✔
2191
        code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
275,976✔
2192
        TAOS_RETURN(code);
275,976✔
2193
      }
2194

2195
      if (mndFindSuperTableTagIndex(pOld, pField->name) >= 0) {
2,035,501✔
2196
        code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
1,941✔
2197
        TAOS_RETURN(code);
1,941✔
2198
      }
2199

2200
      SSchema *pSchema = &pNew->pColumns[pOld->numOfColumns + i];
2,033,560✔
2201
      pSchema->bytes = pField->bytes;
2,033,560✔
2202
      pSchema->type = pField->type;
2,033,560✔
2203
      memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
2,033,560✔
2204
      if (pNew->nextColId > INT16_MAX) {
2,033,560✔
UNCOV
2205
        code = TSDB_CODE_MND_EXCEED_MAX_COL_ID;
×
UNCOV
2206
        TAOS_RETURN(code);
×
2207
      }
2208
      pSchema->colId = pNew->nextColId;
2,033,560✔
2209
      pNew->nextColId++;
2,033,560✔
2210

2211
      SColCmpr *pCmpr = &pNew->pCmpr[pOld->numOfColumns + i];
2,033,560✔
2212
      pCmpr->id = pSchema->colId;
2,033,560✔
2213
      pCmpr->alg = createDefaultColCmprByType(pSchema->type);
2,033,560✔
2214
      mInfo("stb:%s, start to add column %s", pNew->name, pSchema->name);
2,033,560✔
2215
    }
2216
  }
2217
  // 1. old schema already has extschemas
2218
  // 2. new schema has extschemas
2219
  if (pReq->pTypeMods || pOld->pExtSchemas) {
2,280,654✔
2220
    if (!pNew->pExtSchemas) {
2,280,654✔
2221
      // all ext schemas reset to zero
2222
      pNew->pExtSchemas = taosMemoryCalloc(pNew->numOfColumns, sizeof(SExtSchema));
31,617✔
2223
      if (!pNew->pExtSchemas) TAOS_RETURN(terrno);
31,617✔
2224
    }
2225
    if (pOld->pExtSchemas) {
2,280,654✔
2226
      memcpy(pNew->pExtSchemas, pOld->pExtSchemas, pOld->numOfColumns * sizeof(SExtSchema));
2,249,037✔
2227
    }
2228
    if (taosArrayGetSize(pReq->pTypeMods) > 0) {
2,280,654✔
2229
      // copy added column ext schema
2230
      for (int32_t i = 0; i < ncols; ++i) {
4,561,308✔
2231
        pNew->pColumns[pOld->numOfColumns + i].flags |= COL_HAS_TYPE_MOD;
2,280,654✔
2232
        pNew->pExtSchemas[pOld->numOfColumns + i].typeMod = *(STypeMod *)taosArrayGet(pReq->pTypeMods, i);
2,280,654✔
2233
      }
2234
    }
2235
  }
2236

2237
  pNew->colVer++;
2,280,654✔
2238
  TAOS_RETURN(code);
2,280,654✔
2239
}
2240

2241
static int32_t mndDropSuperTableColumn(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const char *colName) {
1,495,784✔
2242
  int32_t code = 0;
1,495,784✔
2243
  int32_t col = mndFindSuperTableColumnIndex(pOld, colName);
1,495,784✔
2244
  if (col < 0) {
1,495,784✔
2245
    code = TSDB_CODE_MND_COLUMN_NOT_EXIST;
1,941✔
2246
    TAOS_RETURN(code);
1,941✔
2247
  }
2248

2249
  if (col == 0) {
1,493,843✔
2250
    code = TSDB_CODE_MND_INVALID_STB_ALTER_OPTION;
1,383✔
2251
    TAOS_RETURN(code);
1,383✔
2252
  }
2253

2254
  if (pOld->numOfColumns == 2) {
1,492,460✔
UNCOV
2255
    code = TSDB_CODE_PAR_INVALID_DROP_COL;
×
UNCOV
2256
    TAOS_RETURN(code);
×
2257
  }
2258

2259
  col_id_t colId = pOld->pColumns[col].colId;
1,492,460✔
2260
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, pOld->name, pOld->uid, colId, false));
1,492,460✔
2261

2262
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
1,492,460✔
2263

2264
  int32_t sz = pNew->numOfColumns - col - 1;
1,492,460✔
2265
  memmove(pNew->pColumns + col, pNew->pColumns + col + 1, sizeof(SSchema) * sz);
1,492,460✔
2266
  memmove(pNew->pCmpr + col, pNew->pCmpr + col + 1, sizeof(SColCmpr) * sz);
1,492,460✔
2267
  if (pOld->pExtSchemas) {
1,492,460✔
2268
    memmove(pNew->pExtSchemas + col, pNew->pExtSchemas + col + 1, sizeof(SExtSchema) * sz);
1,464,737✔
2269
  }
2270
  pNew->numOfColumns--;
1,492,460✔
2271

2272
  pNew->colVer++;
1,492,460✔
2273
  mInfo("stb:%s, start to drop col %s", pNew->name, colName);
1,492,460✔
2274
  TAOS_RETURN(code);
1,492,460✔
2275
}
2276

2277
static int32_t mndAlterStbColumnBytes(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const SField *pField) {
491,507✔
2278
  int32_t code = 0;
491,507✔
2279
  int32_t col = mndFindSuperTableColumnIndex(pOld, pField->name);
491,507✔
2280
  if (col < 0) {
491,507✔
UNCOV
2281
    code = TSDB_CODE_MND_COLUMN_NOT_EXIST;
×
UNCOV
2282
    TAOS_RETURN(code);
×
2283
  }
2284

2285
  col_id_t colId = pOld->pColumns[col].colId;
491,507✔
2286

2287
  uint32_t nLen = 0;
491,507✔
2288
  int32_t  maxBytesPerRow = pOld->virtualStb ? TSDB_MAX_BYTES_PER_ROW_VIRTUAL : TSDB_MAX_BYTES_PER_ROW;
491,507✔
2289
  for (int32_t i = 0; i < pOld->numOfColumns; ++i) {
37,495,796✔
2290
    nLen += (pOld->pColumns[i].colId == colId) ? pField->bytes : pOld->pColumns[i].bytes;
37,004,289✔
2291
  }
2292

2293
  if (nLen > maxBytesPerRow) {
491,507✔
2294
    code = TSDB_CODE_MND_INVALID_ROW_BYTES;
22,505✔
2295
    TAOS_RETURN(code);
22,505✔
2296
  }
2297

2298
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, pOld->name, pOld->uid, colId, false));
469,002✔
2299

2300
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
469,002✔
2301

2302
  SSchema *pCol = pNew->pColumns + col;
469,002✔
2303
  if (!(pCol->type == TSDB_DATA_TYPE_BINARY || pCol->type == TSDB_DATA_TYPE_VARBINARY ||
469,002✔
2304
        pCol->type == TSDB_DATA_TYPE_NCHAR || pCol->type == TSDB_DATA_TYPE_GEOMETRY)) {
457,820✔
UNCOV
2305
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
UNCOV
2306
    TAOS_RETURN(code);
×
2307
  }
2308

2309
  if (pField->bytes <= pCol->bytes) {
469,002✔
2310
    code = TSDB_CODE_MND_INVALID_ROW_BYTES;
181,326✔
2311
    TAOS_RETURN(code);
181,326✔
2312
  }
2313

2314
  pCol->bytes = pField->bytes;
287,676✔
2315
  pNew->colVer++;
287,676✔
2316

2317
  mInfo("stb:%s, start to modify col len %s to %d", pNew->name, pField->name, pField->bytes);
287,676✔
2318
  TAOS_RETURN(code);
287,676✔
2319
}
2320

2321
static int32_t mndSetAlterStbPrepareLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
4,521,970✔
2322
  int32_t  code = 0;
4,521,970✔
2323
  SSdbRaw *pRedoRaw = mndStbActionEncode(pStb);
4,521,970✔
2324
  if (pRedoRaw == NULL) {
4,521,970✔
UNCOV
2325
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2326
    if (terrno != 0) code = terrno;
×
UNCOV
2327
    TAOS_RETURN(code);
×
2328
  }
2329
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
4,521,970✔
UNCOV
2330
    sdbFreeRaw(pRedoRaw);
×
UNCOV
2331
    TAOS_RETURN(code);
×
2332
  }
2333
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_READY));
4,521,970✔
2334

2335
  TAOS_RETURN(code);
4,521,970✔
2336
}
2337

2338
static int32_t mndSetAlterStbCommitLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
4,521,970✔
2339
  int32_t  code = 0;
4,521,970✔
2340
  SSdbRaw *pCommitRaw = mndStbActionEncode(pStb);
4,521,970✔
2341
  if (pCommitRaw == NULL) {
4,521,970✔
UNCOV
2342
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2343
    if (terrno != 0) code = terrno;
×
2344
    TAOS_RETURN(code);
×
2345
  }
2346
  if ((code = mndTransAppendCommitlog(pTrans, pCommitRaw)) != 0) {
4,521,970✔
UNCOV
2347
    sdbFreeRaw(pCommitRaw);
×
UNCOV
2348
    TAOS_RETURN(code);
×
2349
  }
2350
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
4,521,970✔
2351

2352
  TAOS_RETURN(code);
4,521,970✔
2353
}
2354

2355
static int32_t mndSetAlterStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb, void *alterOriData,
4,521,970✔
2356
                                         int32_t alterOriDataLen) {
2357
  int32_t code = 0;
4,521,970✔
2358
  SSdb   *pSdb = pMnode->pSdb;
4,521,970✔
2359
  SVgObj *pVgroup = NULL;
4,521,970✔
2360
  void   *pIter = NULL;
4,521,970✔
2361
  int32_t contLen;
4,521,970✔
2362

2363
  while (1) {
11,781,454✔
2364
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
16,303,424✔
2365
    if (pIter == NULL) break;
16,303,424✔
2366
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
11,781,454✔
2367
      sdbRelease(pSdb, pVgroup);
5,544,610✔
2368
      continue;
5,544,610✔
2369
    }
2370

2371
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, alterOriData, alterOriDataLen);
6,236,844✔
2372
    if (pReq == NULL) {
6,236,844✔
UNCOV
2373
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
2374
      sdbRelease(pSdb, pVgroup);
×
UNCOV
2375
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2376
      if (terrno != 0) code = terrno;
×
UNCOV
2377
      TAOS_RETURN(code);
×
2378
    }
2379
    STransAction action = {0};
6,236,844✔
2380
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
6,236,844✔
2381
    action.pCont = pReq;
6,236,844✔
2382
    action.contLen = contLen;
6,236,844✔
2383
    action.msgType = TDMT_VND_ALTER_STB;
6,236,844✔
2384
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
6,236,844✔
UNCOV
2385
      taosMemoryFree(pReq);
×
UNCOV
2386
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
2387
      sdbRelease(pSdb, pVgroup);
×
2388
      TAOS_RETURN(code);
×
2389
    }
2390
    sdbRelease(pSdb, pVgroup);
6,236,844✔
2391
  }
2392

2393
  TAOS_RETURN(code);
4,521,970✔
2394
}
2395

UNCOV
2396
static int32_t mndSetAlterStbRedoActions2(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb,
×
2397
                                          void *alterOriData, int32_t alterOriDataLen) {
2398
  int32_t code = 0;
×
UNCOV
2399
  SSdb   *pSdb = pMnode->pSdb;
×
UNCOV
2400
  SVgObj *pVgroup = NULL;
×
UNCOV
2401
  void   *pIter = NULL;
×
UNCOV
2402
  int32_t contLen;
×
2403

UNCOV
2404
  while (1) {
×
UNCOV
2405
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
×
UNCOV
2406
    if (pIter == NULL) break;
×
UNCOV
2407
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
×
UNCOV
2408
      sdbRelease(pSdb, pVgroup);
×
UNCOV
2409
      continue;
×
2410
    }
2411

UNCOV
2412
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, alterOriData, alterOriDataLen);
×
UNCOV
2413
    if (pReq == NULL) {
×
UNCOV
2414
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
2415
      sdbRelease(pSdb, pVgroup);
×
UNCOV
2416
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2417
      if (terrno != 0) code = terrno;
×
UNCOV
2418
      TAOS_RETURN(code);
×
2419
    }
UNCOV
2420
    STransAction action = {0};
×
UNCOV
2421
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
×
UNCOV
2422
    action.pCont = pReq;
×
UNCOV
2423
    action.contLen = contLen;
×
2424
    action.msgType = TDMT_VND_CREATE_INDEX;
×
2425
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
×
UNCOV
2426
      taosMemoryFree(pReq);
×
UNCOV
2427
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
2428
      sdbRelease(pSdb, pVgroup);
×
UNCOV
2429
      TAOS_RETURN(code);
×
2430
    }
UNCOV
2431
    sdbRelease(pSdb, pVgroup);
×
2432
  }
2433

UNCOV
2434
  TAOS_RETURN(code);
×
2435
}
2436

2437
static int32_t mndBuildStbSchemaImp(SMnode *pMnode, SDbObj *pDb, SStbObj *pStb, const char *tbName, STableMetaRsp *pRsp, bool refByStm) {
21,242,603✔
2438
  int32_t code = 0;
21,242,603✔
2439
  taosRLockLatch(&pStb->lock);
21,242,603✔
2440

2441
  int32_t totalCols = pStb->numOfColumns + pStb->numOfTags;
21,242,603✔
2442
  pRsp->pSchemas = taosMemoryCalloc(totalCols, sizeof(SSchema));
21,242,603✔
2443
  if (pRsp->pSchemas == NULL) {
21,242,603✔
UNCOV
2444
    taosRUnLockLatch(&pStb->lock);
×
UNCOV
2445
    code = terrno;
×
UNCOV
2446
    TAOS_RETURN(code);
×
2447
  }
2448
  pRsp->pSchemaExt = taosMemoryCalloc(pStb->numOfColumns, sizeof(SSchemaExt));
21,242,603✔
2449
  if (pRsp->pSchemaExt == NULL) {
21,242,223✔
UNCOV
2450
    taosRUnLockLatch(&pStb->lock);
×
UNCOV
2451
    code = terrno;
×
UNCOV
2452
    TAOS_RETURN(code);
×
2453
  }
2454
  pRsp->numOfColRefs = 0;
21,242,223✔
2455
  pRsp->pColRefs = NULL;
21,242,603✔
2456
  tstrncpy(pRsp->dbFName, pStb->db, sizeof(pRsp->dbFName));
21,242,223✔
2457
  tstrncpy(pRsp->tbName, tbName, sizeof(pRsp->tbName));
21,242,223✔
2458
  tstrncpy(pRsp->stbName, tbName, sizeof(pRsp->stbName));
21,242,603✔
2459
  pRsp->dbId = pDb->uid;
21,242,603✔
2460
  pRsp->numOfTags = pStb->numOfTags;
21,242,603✔
2461
  pRsp->numOfColumns = pStb->numOfColumns;
21,242,603✔
2462
  pRsp->precision = pDb->cfg.precision;
21,242,603✔
2463
  pRsp->tableType = TSDB_SUPER_TABLE;
21,242,603✔
2464
  pRsp->sversion = pStb->colVer;
21,241,960✔
2465
  pRsp->tversion = pStb->tagVer;
21,242,603✔
2466
  pRsp->suid = pStb->uid;
21,242,603✔
2467
  pRsp->tuid = pStb->uid;
21,242,603✔
2468
  pRsp->virtualStb = pStb->virtualStb;
21,242,603✔
2469
  pRsp->ownerId = pStb->ownerId;
21,242,223✔
2470
  pRsp->isAudit = pDb->cfg.isAudit ? 1 : 0;
21,242,223✔
2471

2472
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
586,073,314✔
2473
    SSchema *pSchema = &pRsp->pSchemas[i];
564,830,711✔
2474
    SSchema *pSrcSchema = &pStb->pColumns[i];
564,830,711✔
2475
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
564,830,331✔
2476
    pSchema->type = pSrcSchema->type;
564,830,331✔
2477
    pSchema->flags = pSrcSchema->flags;
564,830,711✔
2478
    pSchema->colId = pSrcSchema->colId;
564,830,711✔
2479
    pSchema->bytes = pSrcSchema->bytes;
564,830,711✔
2480
  }
2481
  
2482
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
97,576,147✔
2483
    SSchema *pSchema = &pRsp->pSchemas[i + pStb->numOfColumns];
76,333,544✔
2484
    SSchema *pSrcSchema = &pStb->pTags[i];
76,333,544✔
2485
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
76,333,544✔
2486
    pSchema->type = pSrcSchema->type;
76,333,544✔
2487
    pSchema->flags = pSrcSchema->flags;
76,333,544✔
2488
    pSchema->colId = pSrcSchema->colId;
76,333,544✔
2489
    pSchema->bytes = pSrcSchema->bytes;
76,333,544✔
2490
  }
2491

2492
  if (refByStm) {
21,242,603✔
2493
    mndStreamUpdateTagsRefFlag(pMnode, pStb->uid, &pRsp->pSchemas[pStb->numOfColumns], pStb->numOfTags);
14,949,359✔
2494
  }
2495

2496
  for (int32_t i = 0; i < pStb->numOfColumns; i++) {
586,073,314✔
2497
    SColCmpr   *pCmpr = &pStb->pCmpr[i];
564,830,331✔
2498
    SSchemaExt *pSchEx = &pRsp->pSchemaExt[i];
564,830,331✔
2499
    pSchEx->colId = pCmpr->id;
564,830,331✔
2500
    pSchEx->compress = pCmpr->alg;
564,830,711✔
2501
    if (pStb->pExtSchemas) {
564,830,711✔
2502
      pSchEx->typeMod = pStb->pExtSchemas[i].typeMod;
276,329,711✔
2503
    }
2504
  }
2505

2506
  taosRUnLockLatch(&pStb->lock);
21,242,603✔
2507
  TAOS_RETURN(code);
21,242,603✔
2508
}
2509

2510
static int32_t mndBuildStbCfgImp(SDbObj *pDb, SStbObj *pStb, const char *tbName, STableCfgRsp *pRsp) {
24,760✔
2511
  int32_t code = 0;
24,760✔
2512
  taosRLockLatch(&pStb->lock);
24,760✔
2513

2514
  int32_t totalCols = pStb->numOfColumns + pStb->numOfTags;
24,760✔
2515
  pRsp->pSchemas = taosMemoryCalloc(totalCols, sizeof(SSchema));
24,760✔
2516
  if (pRsp->pSchemas == NULL) {
24,760✔
UNCOV
2517
    taosRUnLockLatch(&pStb->lock);
×
UNCOV
2518
    code = terrno;
×
UNCOV
2519
    TAOS_RETURN(code);
×
2520
  }
2521

2522
  tstrncpy(pRsp->dbFName, pStb->db, sizeof(pRsp->dbFName));
24,760✔
2523
  tstrncpy(pRsp->tbName, tbName, sizeof(pRsp->tbName));
24,760✔
2524
  tstrncpy(pRsp->stbName, tbName, sizeof(pRsp->stbName));
24,760✔
2525
  pRsp->numOfTags = pStb->numOfTags;
24,760✔
2526
  pRsp->numOfColumns = pStb->numOfColumns;
24,760✔
2527
  pRsp->tableType = TSDB_SUPER_TABLE;
24,760✔
2528
  pRsp->delay1 = pStb->maxdelay[0];
24,760✔
2529
  pRsp->delay2 = pStb->maxdelay[1];
24,760✔
2530
  pRsp->watermark1 = pStb->watermark[0];
24,760✔
2531
  pRsp->watermark2 = pStb->watermark[1];
24,760✔
2532
  pRsp->ttl = pStb->ttl;
24,760✔
2533
  pRsp->keep = pStb->keep;
24,760✔
2534
  pRsp->commentLen = pStb->commentLen;
24,760✔
2535
  if (pStb->commentLen > 0) {
24,760✔
UNCOV
2536
    pRsp->pComment = taosStrdup(pStb->comment);
×
2537
  }
2538

2539
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
141,937✔
2540
    SSchema *pSchema = &pRsp->pSchemas[i];
117,177✔
2541
    SSchema *pSrcSchema = &pStb->pColumns[i];
117,177✔
2542
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
117,177✔
2543
    pSchema->type = pSrcSchema->type;
117,177✔
2544
    pSchema->flags = pSrcSchema->flags;
117,177✔
2545
    pSchema->colId = pSrcSchema->colId;
117,177✔
2546
    pSchema->bytes = pSrcSchema->bytes;
117,177✔
2547
  }
2548

2549
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
70,173✔
2550
    SSchema *pSchema = &pRsp->pSchemas[i + pStb->numOfColumns];
45,413✔
2551
    SSchema *pSrcSchema = &pStb->pTags[i];
45,413✔
2552
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
45,413✔
2553
    pSchema->type = pSrcSchema->type;
45,413✔
2554
    pSchema->flags = pSrcSchema->flags;
45,413✔
2555
    pSchema->colId = pSrcSchema->colId;
45,413✔
2556
    pSchema->bytes = pSrcSchema->bytes;
45,413✔
2557
  }
2558

2559
  if (pStb->numOfFuncs > 0) {
24,760✔
UNCOV
2560
    pRsp->pFuncs = taosArrayDup(pStb->pFuncs, NULL);
×
2561
  }
2562

2563
  pRsp->pSchemaExt = taosMemoryCalloc(pStb->numOfColumns, sizeof(SSchemaExt));
24,760✔
2564
  for (int32_t i = 0; i < pStb->numOfColumns; i++) {
141,937✔
2565
    SColCmpr *pCmpr = &pStb->pCmpr[i];
117,177✔
2566

2567
    SSchemaExt *pSchExt = &pRsp->pSchemaExt[i];
117,177✔
2568
    pSchExt->colId = pCmpr->id;
117,177✔
2569
    pSchExt->compress = pCmpr->alg;
117,177✔
2570
    if (pStb->pExtSchemas) {
117,177✔
2571
      pSchExt->typeMod = pStb->pExtSchemas[i].typeMod;
31,524✔
2572
    }
2573
  }
2574
  pRsp->virtualStb = pStb->virtualStb;
24,760✔
2575
  pRsp->pColRefs = NULL;
24,760✔
2576

2577
  taosRUnLockLatch(&pStb->lock);
24,760✔
2578
  TAOS_RETURN(code);
24,760✔
2579
}
2580

2581
static int32_t mndValidateStbVersion(SMnode *pMnode, SSTableVersion *pStbVer, bool *schema, bool *sma) {
7,563,342✔
2582
  int32_t code = 0;
7,563,342✔
2583
  char    tbFName[TSDB_TABLE_FNAME_LEN] = {0};
7,563,342✔
2584
  snprintf(tbFName, sizeof(tbFName), "%s.%s", pStbVer->dbFName, pStbVer->stbName);
7,563,342✔
2585

2586
  SDbObj *pDb = mndAcquireDb(pMnode, pStbVer->dbFName);
7,563,342✔
2587
  if (pDb == NULL) {
7,563,342✔
2588
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
27,123✔
2589
    TAOS_RETURN(code);
27,123✔
2590
  }
2591

2592
  if (pDb->uid != pStbVer->dbId) {
7,536,219✔
2593
    mndReleaseDb(pMnode, pDb);
8,550✔
2594
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
8,550✔
2595
    TAOS_RETURN(code);
8,550✔
2596
  }
2597

2598
  SStbObj *pStb = mndAcquireStb(pMnode, tbFName);
7,527,669✔
2599
  if (pStb == NULL) {
7,527,669✔
2600
    mndReleaseDb(pMnode, pDb);
2,002✔
2601
    code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
2,002✔
2602
    TAOS_RETURN(code);
2,002✔
2603
  }
2604

2605
  taosRLockLatch(&pStb->lock);
7,525,667✔
2606

2607
  if (pStbVer->sversion != pStb->colVer || pStbVer->tversion != pStb->tagVer) {
7,525,667✔
2608
    *schema = true;
14,685✔
2609
  } else {
2610
    *schema = false;
7,510,982✔
2611
  }
2612

2613
  if (pStbVer->smaVer && pStbVer->smaVer != pStb->smaVer) {
7,525,667✔
UNCOV
2614
    *sma = true;
×
2615
  } else {
2616
    *sma = false;
7,525,667✔
2617
  }
2618

2619
  taosRUnLockLatch(&pStb->lock);
7,525,667✔
2620

2621
  mndReleaseDb(pMnode, pDb);
7,525,667✔
2622
  mndReleaseStb(pMnode, pStb);
7,525,667✔
2623
  return TSDB_CODE_SUCCESS;
7,525,667✔
2624
}
2625

2626
static int32_t mndBuildStbSchema(SMnode *pMnode, const char *dbFName, const char *tbName, STableMetaRsp *pRsp, bool refByStm) {
15,684,505✔
2627
  int32_t code = 0;
15,684,505✔
2628
  char    tbFName[TSDB_TABLE_FNAME_LEN] = {0};
15,684,505✔
2629
  snprintf(tbFName, sizeof(tbFName), "%s.%s", dbFName, tbName);
15,684,505✔
2630

2631
  SDbObj *pDb = mndAcquireDb(pMnode, dbFName);
15,684,505✔
2632
  if (pDb == NULL) {
15,684,505✔
2633
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
2634
    TAOS_RETURN(code);
×
2635
  }
2636

2637
  SStbObj *pStb = mndAcquireStb(pMnode, tbFName);
15,684,505✔
2638
  if (pStb == NULL) {
15,684,505✔
2639
    mndReleaseDb(pMnode, pDb);
720,461✔
2640
    code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
720,461✔
2641
    TAOS_RETURN(code);
720,461✔
2642
  }
2643

2644
  code = mndBuildStbSchemaImp(pMnode, pDb, pStb, tbName, pRsp, refByStm);
14,964,044✔
2645
  mndReleaseDb(pMnode, pDb);
14,964,044✔
2646
  mndReleaseStb(pMnode, pStb);
14,964,044✔
2647
  TAOS_RETURN(code);
14,964,044✔
2648
}
2649

2650
static int32_t mndBuildStbCfg(SMnode *pMnode, const char *dbFName, const char *tbName, STableCfgRsp *pRsp) {
24,760✔
2651
  int32_t code = 0;
24,760✔
2652
  char    tbFName[TSDB_TABLE_FNAME_LEN] = {0};
24,760✔
2653
  snprintf(tbFName, sizeof(tbFName), "%s.%s", dbFName, tbName);
24,760✔
2654

2655
  SDbObj *pDb = mndAcquireDb(pMnode, dbFName);
24,760✔
2656
  if (pDb == NULL) {
24,760✔
UNCOV
2657
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
UNCOV
2658
    TAOS_RETURN(code);
×
2659
  }
2660

2661
  SStbObj *pStb = mndAcquireStb(pMnode, tbFName);
24,760✔
2662
  if (pStb == NULL) {
24,760✔
2663
    mndReleaseDb(pMnode, pDb);
×
2664
    code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
×
2665
    TAOS_RETURN(code);
×
2666
  }
2667

2668
  code = mndBuildStbCfgImp(pDb, pStb, tbName, pRsp);
24,760✔
2669

2670
  mndReleaseDb(pMnode, pDb);
24,760✔
2671
  mndReleaseStb(pMnode, pStb);
24,760✔
2672
  TAOS_RETURN(code);
24,760✔
2673
}
2674

2675
static int32_t mndBuildSMAlterStbRsp(SDbObj *pDb, SStbObj *pObj, void **pCont, int32_t *pLen) {
4,464,894✔
2676
  int32_t       code = 0;
4,464,894✔
2677
  SEncoder      ec = {0};
4,464,894✔
2678
  uint32_t      contLen = 0;
4,464,894✔
2679
  SMAlterStbRsp alterRsp = {0};
4,464,894✔
2680
  SName         name = {0};
4,464,894✔
2681
  TAOS_CHECK_RETURN(tNameFromString(&name, pObj->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
4,464,894✔
2682

2683
  alterRsp.pMeta = taosMemoryCalloc(1, sizeof(STableMetaRsp));
4,464,894✔
2684
  if (NULL == alterRsp.pMeta) {
4,464,894✔
UNCOV
2685
    code = terrno;
×
UNCOV
2686
    TAOS_RETURN(code);
×
2687
  }
2688

2689
  code = mndBuildStbSchemaImp(NULL, pDb, pObj, name.tname, alterRsp.pMeta, false);
4,464,894✔
2690
  if (code) {
4,464,894✔
UNCOV
2691
    tFreeSMAlterStbRsp(&alterRsp);
×
UNCOV
2692
    return code;
×
2693
  }
2694

2695
  tEncodeSize(tEncodeSMAlterStbRsp, &alterRsp, contLen, code);
4,464,894✔
2696
  if (code) {
4,464,894✔
UNCOV
2697
    tFreeSMAlterStbRsp(&alterRsp);
×
UNCOV
2698
    return code;
×
2699
  }
2700

2701
  void *cont = taosMemoryMalloc(contLen);
4,464,894✔
2702
  if (NULL == cont) {
4,464,894✔
UNCOV
2703
    code = terrno;
×
UNCOV
2704
    tFreeSMAlterStbRsp(&alterRsp);
×
UNCOV
2705
    TAOS_RETURN(code);
×
2706
  }
2707
  tEncoderInit(&ec, cont, contLen);
4,464,894✔
2708
  code = tEncodeSMAlterStbRsp(&ec, &alterRsp);
4,464,894✔
2709
  tEncoderClear(&ec);
4,464,894✔
2710

2711
  tFreeSMAlterStbRsp(&alterRsp);
4,464,894✔
2712

2713
  if (code < 0) TAOS_RETURN(code);
4,464,894✔
2714

2715
  *pCont = cont;
4,464,894✔
2716
  *pLen = contLen;
4,464,894✔
2717

2718
  TAOS_RETURN(code);
4,464,894✔
2719
}
2720

2721
int32_t mndBuildSMCreateStbRsp(SMnode *pMnode, char *dbFName, char *stbFName, void **pCont, int32_t *pLen) {
1,815,153✔
2722
  int32_t code = -1;
1,815,153✔
2723
  SDbObj *pDb = mndAcquireDb(pMnode, dbFName);
1,815,153✔
2724
  if (NULL == pDb) {
1,815,153✔
UNCOV
2725
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2726
    if (terrno != 0) code = terrno;
×
UNCOV
2727
    TAOS_RETURN(code);
×
2728
  }
2729

2730
  SStbObj *pObj = mndAcquireStb(pMnode, stbFName);
1,815,153✔
2731
  if (NULL == pObj) {
1,815,153✔
2732
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
1,488✔
2733
    if (terrno != 0) code = terrno;
1,488✔
2734
    goto _OVER;
1,488✔
2735
  }
2736

2737
  SEncoder       ec = {0};
1,813,665✔
2738
  uint32_t       contLen = 0;
1,813,665✔
2739
  SMCreateStbRsp stbRsp = {0};
1,813,665✔
2740
  SName          name = {0};
1,813,665✔
2741
  TAOS_CHECK_GOTO(tNameFromString(&name, pObj->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE), NULL, _OVER);
1,813,665✔
2742

2743
  stbRsp.pMeta = taosMemoryCalloc(1, sizeof(STableMetaRsp));
1,813,665✔
2744
  if (NULL == stbRsp.pMeta) {
1,813,665✔
UNCOV
2745
    code = terrno;
×
UNCOV
2746
    goto _OVER;
×
2747
  }
2748

2749
  code = mndBuildStbSchemaImp(NULL, pDb, pObj, name.tname, stbRsp.pMeta, false);
1,813,665✔
2750
  if (code) {
1,813,665✔
UNCOV
2751
    tFreeSMCreateStbRsp(&stbRsp);
×
UNCOV
2752
    goto _OVER;
×
2753
  }
2754

2755
  tEncodeSize(tEncodeSMCreateStbRsp, &stbRsp, contLen, code);
1,813,665✔
2756
  if (code) {
1,813,665✔
UNCOV
2757
    tFreeSMCreateStbRsp(&stbRsp);
×
UNCOV
2758
    goto _OVER;
×
2759
  }
2760

2761
  void *cont = taosMemoryMalloc(contLen);
1,813,665✔
2762
  if (NULL == cont) {
1,813,665✔
UNCOV
2763
    code = terrno;
×
UNCOV
2764
    tFreeSMCreateStbRsp(&stbRsp);
×
UNCOV
2765
    goto _OVER;
×
2766
  }
2767
  tEncoderInit(&ec, cont, contLen);
1,813,665✔
2768
  TAOS_CHECK_GOTO(tEncodeSMCreateStbRsp(&ec, &stbRsp), NULL, _OVER);
1,813,665✔
2769
  tEncoderClear(&ec);
1,813,665✔
2770

2771
  tFreeSMCreateStbRsp(&stbRsp);
1,813,665✔
2772

2773
  *pCont = cont;
1,813,665✔
2774
  *pLen = contLen;
1,813,665✔
2775

2776
  code = 0;
1,813,665✔
2777

2778
_OVER:
1,815,153✔
2779
  if (pObj) {
1,815,153✔
2780
    mndReleaseStb(pMnode, pObj);
1,813,665✔
2781
  }
2782

2783
  if (pDb) {
1,815,153✔
2784
    mndReleaseDb(pMnode, pDb);
1,815,153✔
2785
  }
2786

2787
  TAOS_RETURN(code);
1,815,153✔
2788
}
2789

2790
static int32_t mndAlterStbImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
4,472,859✔
2791
                              void *alterOriData, int32_t alterOriDataLen) {
2792
  int32_t code = -1;
4,472,859✔
2793
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "alter-stb");
4,472,859✔
2794
  if (pTrans == NULL) {
4,472,859✔
UNCOV
2795
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2796
    if (terrno != 0) code = terrno;
×
UNCOV
2797
    goto _OVER;
×
2798
  }
2799

2800
  mInfo("trans:%d, used to alter stb:%s, alterOriDataLen:%d", pTrans->id, pStb->name, alterOriDataLen);
4,472,859✔
2801
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
4,472,859✔
2802
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
4,472,859✔
2803

2804
  if (needRsp) {
4,314,681✔
2805
    void   *pCont = NULL;
4,257,605✔
2806
    int32_t contLen = 0;
4,257,605✔
2807
    TAOS_CHECK_GOTO(mndBuildSMAlterStbRsp(pDb, pStb, &pCont, &contLen), NULL, _OVER);
4,257,605✔
2808
    mndTransSetRpcRsp(pTrans, pCont, contLen);
4,257,605✔
2809
  }
2810

2811
  TAOS_CHECK_GOTO(mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
4,314,681✔
2812
  TAOS_CHECK_GOTO(mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
4,314,681✔
2813
  TAOS_CHECK_GOTO(mndSetAlterStbRedoActions(pMnode, pTrans, pDb, pStb, alterOriData, alterOriDataLen), NULL, _OVER);
4,314,681✔
2814
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
4,314,681✔
2815

2816
  code = 0;
4,314,681✔
2817

2818
_OVER:
4,472,859✔
2819
  mndTransDrop(pTrans);
4,472,859✔
2820
  TAOS_RETURN(code);
4,472,859✔
2821
}
2822

2823
static int32_t mndAlterStbAndUpdateTagIdxImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
207,289✔
2824
                                             void *alterOriData, int32_t alterOriDataLen, const SMAlterStbReq *pAlter) {
2825
  int32_t code = -1;
207,289✔
2826
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "alter-stb");
207,289✔
2827
  if (pTrans == NULL) {
207,289✔
UNCOV
2828
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
2829
    if (terrno != 0) code = terrno;
×
UNCOV
2830
    goto _OVER;
×
2831
  }
2832

2833
  mInfo("trans:%d, used to alter stb:%s", pTrans->id, pStb->name);
207,289✔
2834
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
207,289✔
2835

2836
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
207,289✔
2837

2838
  if (needRsp) {
207,289✔
2839
    void   *pCont = NULL;
207,289✔
2840
    int32_t contLen = 0;
207,289✔
2841
    TAOS_CHECK_GOTO(mndBuildSMAlterStbRsp(pDb, pStb, &pCont, &contLen), NULL, _OVER);
207,289✔
2842
    mndTransSetRpcRsp(pTrans, pCont, contLen);
207,289✔
2843
  }
2844

2845
  if (pAlter->alterType == TSDB_ALTER_TABLE_DROP_TAG) {
207,289✔
2846
    SIdxObj idxObj = {0};
100,763✔
2847
    SField *pField0 = taosArrayGet(pAlter->pFields, 0);
100,763✔
2848
    bool    exist = false;
100,763✔
2849
    if (mndGetIdxsByTagName(pMnode, pStb, pField0->name, &idxObj) == 0) {
100,763✔
2850
      exist = true;
4,361✔
2851
    }
2852
    TAOS_CHECK_GOTO(mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
100,763✔
2853
    TAOS_CHECK_GOTO(mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
100,763✔
2854

2855
    if (exist == true) {
100,763✔
2856
      TAOS_CHECK_GOTO(mndSetDropIdxPrepareLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
4,361✔
2857
      TAOS_CHECK_GOTO(mndSetDropIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
4,361✔
2858
    }
2859

2860
    TAOS_CHECK_GOTO(mndSetAlterStbRedoActions(pMnode, pTrans, pDb, pStb, alterOriData, alterOriDataLen), NULL, _OVER);
100,763✔
2861
    TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
100,763✔
2862

2863
  } else if (pAlter->alterType == TSDB_ALTER_TABLE_UPDATE_TAG_NAME) {
106,526✔
2864
    SIdxObj     idxObj = {0};
106,526✔
2865
    SField     *pField0 = taosArrayGet(pAlter->pFields, 0);
106,526✔
2866
    SField     *pField1 = taosArrayGet(pAlter->pFields, 1);
106,526✔
2867
    const char *oTagName = pField0->name;
106,526✔
2868
    const char *nTagName = pField1->name;
106,526✔
2869
    bool        exist = false;
106,526✔
2870

2871
    if (mndGetIdxsByTagName(pMnode, pStb, pField0->name, &idxObj) == 0) {
106,526✔
2872
      exist = true;
13,606✔
2873
    }
2874

2875
    TAOS_CHECK_GOTO(mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
106,526✔
2876
    TAOS_CHECK_GOTO(mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
106,526✔
2877

2878
    if (exist == true) {
106,526✔
2879
      memcpy(idxObj.colName, nTagName, strlen(nTagName));
13,606✔
2880
      idxObj.colName[strlen(nTagName)] = 0;
13,606✔
2881
      TAOS_CHECK_GOTO(mndSetAlterIdxPrepareLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
13,606✔
2882
      TAOS_CHECK_GOTO(mndSetAlterIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
13,606✔
2883
    }
2884

2885
    TAOS_CHECK_GOTO(mndSetAlterStbRedoActions(pMnode, pTrans, pDb, pStb, alterOriData, alterOriDataLen), NULL, _OVER);
106,526✔
2886
    TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
106,526✔
2887
  }
2888
  code = 0;
207,289✔
2889

2890
_OVER:
207,289✔
2891
  mndTransDrop(pTrans);
207,289✔
2892
  TAOS_RETURN(code);
207,289✔
2893
}
2894

2895
static int32_t mndAlterStb(SMnode *pMnode, SRpcMsg *pReq, const SMAlterStbReq *pAlter, SDbObj *pDb, SStbObj *pOld) {
5,465,323✔
2896
  bool    needRsp = true;
5,465,323✔
2897
  int32_t code = -1;
5,465,323✔
2898
  SField *pField0 = NULL;
5,465,323✔
2899

2900
  SStbObj stbObj = {0};
5,465,323✔
2901
  taosRLockLatch(&pOld->lock);
5,465,323✔
2902
  memcpy(&stbObj, pOld, sizeof(SStbObj));
5,465,323✔
2903
  taosRUnLockLatch(&pOld->lock);
5,465,323✔
2904
  stbObj.pColumns = NULL;
5,465,323✔
2905
  stbObj.pTags = NULL;
5,465,323✔
2906
  stbObj.pFuncs = NULL;
5,465,323✔
2907
  stbObj.pCmpr = NULL;
5,465,323✔
2908
  stbObj.pExtSchemas = NULL;
5,465,323✔
2909
  stbObj.updateTime = taosGetTimestampMs();
5,465,323✔
2910
  stbObj.lock = 0;
5,465,323✔
2911
  stbObj.virtualStb = pOld->virtualStb;
5,465,323✔
2912
  bool updateTagIndex = false;
5,465,323✔
2913
  switch (pAlter->alterType) {
5,465,323✔
2914
    case TSDB_ALTER_TABLE_ADD_TAG:
273,665✔
2915
      code = mndAddSuperTableTag(pOld, &stbObj, pAlter->pFields, pAlter->numOfFields);
273,665✔
2916
      break;
273,665✔
2917
    case TSDB_ALTER_TABLE_DROP_TAG:
100,873✔
2918
      pField0 = taosArrayGet(pAlter->pFields, 0);
100,873✔
2919
      code = mndDropSuperTableTag(pMnode, pOld, &stbObj, pField0->name);
100,873✔
2920
      updateTagIndex = true;
100,873✔
2921
      break;
100,873✔
2922
    case TSDB_ALTER_TABLE_UPDATE_TAG_NAME:
115,659✔
2923
      code = mndAlterStbTagName(pMnode, pOld, &stbObj, pAlter->pFields);
115,659✔
2924
      updateTagIndex = true;
115,659✔
2925
      break;
115,659✔
2926
    case TSDB_ALTER_TABLE_UPDATE_TAG_BYTES:
314,551✔
2927
      pField0 = taosArrayGet(pAlter->pFields, 0);
314,551✔
2928
      code = mndAlterStbTagBytes(pMnode, pOld, &stbObj, pField0);
314,551✔
2929
      break;
314,551✔
2930
    case TSDB_ALTER_TABLE_ADD_COLUMN:
2,313,184✔
2931
      code = mndAddSuperTableColumn(pOld, &stbObj, pAlter, pAlter->numOfFields, 0);
2,313,184✔
2932
      break;
2,313,184✔
2933
    case TSDB_ALTER_TABLE_DROP_COLUMN:
1,495,784✔
2934
      pField0 = taosArrayGet(pAlter->pFields, 0);
1,495,784✔
2935
      code = mndDropSuperTableColumn(pMnode, pOld, &stbObj, pField0->name);
1,495,784✔
2936
      break;
1,495,784✔
2937
    case TSDB_ALTER_TABLE_UPDATE_COLUMN_BYTES:
491,507✔
2938
      pField0 = taosArrayGet(pAlter->pFields, 0);
491,507✔
2939
      code = mndAlterStbColumnBytes(pMnode, pOld, &stbObj, pField0);
491,507✔
2940
      break;
491,507✔
2941
    case TSDB_ALTER_TABLE_UPDATE_OPTIONS:
23,414✔
2942
      needRsp = false;
23,414✔
2943
      code = mndUpdateTableOptions(pOld, &stbObj, pAlter->comment, pAlter->commentLen, pAlter->ttl, pAlter->keep);
23,414✔
2944
      break;
23,414✔
2945
    case TSDB_ALTER_TABLE_UPDATE_COLUMN_COMPRESS:
89,592✔
2946
      code = mndUpdateSuperTableColumnCompress(pMnode, pOld, &stbObj, pAlter->pFields, pAlter->numOfFields);
89,592✔
2947
      break;
89,592✔
2948
    case TSDB_ALTER_TABLE_ADD_COLUMN_WITH_COMPRESS_OPTION:
247,094✔
2949
      code = mndAddSuperTableColumn(pOld, &stbObj, pAlter, pAlter->numOfFields, 1);
247,094✔
2950
      break;
247,094✔
UNCOV
2951
    default:
×
UNCOV
2952
      needRsp = false;
×
UNCOV
2953
      terrno = TSDB_CODE_OPS_NOT_SUPPORT;
×
UNCOV
2954
      break;
×
2955
  }
2956

2957
  if (code != 0) goto _OVER;
5,465,323✔
2958
  if (updateTagIndex == false) {
4,646,486✔
2959
    code = mndAlterStbImp(pMnode, pReq, pDb, &stbObj, needRsp, pReq->pCont, pReq->contLen);
4,439,197✔
2960
  } else {
2961
    code = mndAlterStbAndUpdateTagIdxImp(pMnode, pReq, pDb, &stbObj, needRsp, pReq->pCont, pReq->contLen, pAlter);
207,289✔
2962
  }
2963

2964
_OVER:
5,465,323✔
2965
  taosMemoryFreeClear(stbObj.pTags);
5,465,323✔
2966
  taosMemoryFreeClear(stbObj.pColumns);
5,465,323✔
2967
  taosMemoryFreeClear(stbObj.pCmpr);
5,465,323✔
2968
  if (pAlter->commentLen > 0) {
5,465,323✔
2969
    taosMemoryFreeClear(stbObj.comment);
5,900✔
2970
  }
2971
  taosMemoryFreeClear(stbObj.pExtSchemas);
5,465,323✔
2972
  TAOS_RETURN(code);
5,465,323✔
2973
}
2974

2975
static int32_t mndProcessAlterStbReq(SRpcMsg *pReq) {
5,479,721✔
2976
  SMnode       *pMnode = pReq->info.node;
5,479,721✔
2977
  int32_t       code = -1;
5,479,721✔
2978
  SDbObj       *pDb = NULL;
5,479,721✔
2979
  SStbObj      *pStb = NULL;
5,479,721✔
2980
  SUserObj     *pOperUser = NULL;
5,479,721✔
2981
  SMAlterStbReq alterReq = {0};
5,479,721✔
2982
  int64_t       tss = taosGetTimestampMs();
5,479,721✔
2983

2984
  if (tDeserializeSMAlterStbReq(pReq->pCont, pReq->contLen, &alterReq) != 0) {
5,479,721✔
UNCOV
2985
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
2986
    goto _OVER;
×
2987
  }
2988

2989
  mInfo("stb:%s, start to alter", alterReq.name);
5,479,721✔
2990
  if (mndCheckAlterStbReq(&alterReq) != 0) goto _OVER;
5,479,721✔
2991

2992
  pDb = mndAcquireDbByStb(pMnode, alterReq.name);
5,479,721✔
2993
  if (pDb == NULL) {
5,479,721✔
UNCOV
2994
    code = TSDB_CODE_MND_DB_NOT_EXIST;
×
UNCOV
2995
    goto _OVER;
×
2996
  }
2997
  if (pDb->cfg.isMount) {
5,479,721✔
2998
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
252✔
2999
    goto _OVER;
252✔
3000
  }
3001

3002
  pStb = mndAcquireStb(pMnode, alterReq.name);
5,479,469✔
3003
  if (pStb == NULL) {
5,479,469✔
3004
    code = TSDB_CODE_MND_STB_NOT_EXIST;
14,146✔
3005
    goto _OVER;
14,146✔
3006
  }
3007

3008
  SName   name = {0};
5,465,323✔
3009
  int32_t ret = 0;
5,465,323✔
3010
  if ((ret = tNameFromString(&name, alterReq.name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0)
5,465,323✔
UNCOV
3011
    mError("stb:%s, failed to tNameFromString since %s", alterReq.name, tstrerror(ret));
×
3012

3013
  // if ((code = mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), MND_OPER_WRITE_DB, pDb)) != 0) {
3014
  //   goto _OVER;
3015
  // }
3016
  TAOS_CHECK_GOTO(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser), NULL, _OVER);
5,465,323✔
3017
  TAOS_CHECK_GOTO(mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB, pDb), NULL,
5,465,323✔
3018
                  _OVER);
3019
  TAOS_CHECK_GOTO(mndCheckDbPrivilegeByNameRecF(pMnode, pOperUser, PRIV_CM_ALTER, PRIV_OBJ_TBL, pDb->name, name.tname),
5,465,323✔
3020
                  NULL, _OVER);
3021

3022
  code = mndAlterStb(pMnode, pReq, &alterReq, pDb, pStb);
5,465,323✔
3023
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
5,465,323✔
3024

3025
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
5,465,323✔
3026
    int64_t tse = taosGetTimestampMs();
5,465,323✔
3027
    double  duration = (double)(tse - tss);
5,465,323✔
3028
    duration = duration / 1000;
5,465,323✔
3029
    auditRecord(pReq, pMnode->clusterId, "alterStb", name.dbname, name.tname, alterReq.sql, alterReq.sqlLen, duration,
5,465,323✔
3030
                0);
3031
  }
3032
_OVER:
5,479,721✔
3033
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
5,479,721✔
3034
    mError("stb:%s, failed to alter since %s", alterReq.name, tstrerror(code));
991,413✔
3035
  }
3036

3037
  mndReleaseStb(pMnode, pStb);
5,479,721✔
3038
  mndReleaseDb(pMnode, pDb);
5,479,721✔
3039
  mndReleaseUser(pMnode, pOperUser);
5,479,721✔
3040
  tFreeSMAltertbReq(&alterReq);
5,479,721✔
3041

3042
  TAOS_RETURN(code);
5,479,721✔
3043
}
3044

3045
static int32_t mndSetDropStbPrepareLogs(SMnode *pMnode, STrans *pTrans, SStbObj *pStb) {
449,175✔
3046
  int32_t  code = 0;
449,175✔
3047
  SSdbRaw *pRedoRaw = mndStbActionEncode(pStb);
449,175✔
3048
  if (pRedoRaw == NULL) {
449,175✔
3049
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
3050
    if (terrno != 0) code = terrno;
×
UNCOV
3051
    TAOS_RETURN(code);
×
3052
  }
3053
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
449,175✔
UNCOV
3054
    sdbFreeRaw(pRedoRaw);
×
UNCOV
3055
    TAOS_RETURN(code);
×
3056
  }
3057
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_DROPPING));
449,175✔
3058

3059
  TAOS_RETURN(code);
449,175✔
3060
}
3061

3062
static int32_t mndSetDropStbCommitLogs(SMnode *pMnode, STrans *pTrans, SStbObj *pStb) {
449,175✔
3063
  int32_t  code = 0;
449,175✔
3064
  SSdbRaw *pCommitRaw = mndStbActionEncode(pStb);
449,175✔
3065
  if (pCommitRaw == NULL) {
449,175✔
UNCOV
3066
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
3067
    if (terrno != 0) code = terrno;
×
UNCOV
3068
    TAOS_RETURN(code);
×
3069
  }
3070
  if (mndTransAppendCommitlog(pTrans, pCommitRaw) != 0) {
449,175✔
UNCOV
3071
    sdbFreeRaw(pCommitRaw);
×
UNCOV
3072
    TAOS_RETURN(code);
×
3073
  }
3074
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_DROPPED));
449,175✔
3075

3076
  TAOS_RETURN(code);
449,175✔
3077
}
3078

3079
static int32_t mndSetDropStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
449,175✔
3080
  int32_t code = 0;
449,175✔
3081
  SSdb   *pSdb = pMnode->pSdb;
449,175✔
3082
  SVgObj *pVgroup = NULL;
449,175✔
3083
  void   *pIter = NULL;
449,175✔
3084

3085
  while (1) {
1,225,521✔
3086
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
1,674,696✔
3087
    if (pIter == NULL) break;
1,674,696✔
3088
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
1,225,521✔
3089
      sdbRelease(pSdb, pVgroup);
329,476✔
3090
      continue;
329,476✔
3091
    }
3092

3093
    int32_t contLen = 0;
896,045✔
3094
    void   *pReq = mndBuildVDropStbReq(pMnode, pVgroup, pStb, &contLen);
896,045✔
3095
    if (pReq == NULL) {
896,045✔
UNCOV
3096
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
3097
      sdbRelease(pSdb, pVgroup);
×
UNCOV
3098
      code = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
3099
      TAOS_RETURN(code);
×
3100
    }
3101

3102
    STransAction action = {0};
896,045✔
3103
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
896,045✔
3104
    action.pCont = pReq;
896,045✔
3105
    action.contLen = contLen;
896,045✔
3106
    action.msgType = TDMT_VND_DROP_STB;
896,045✔
3107
    action.acceptableCode = TSDB_CODE_TDB_STB_NOT_EXIST;
896,045✔
3108
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
896,045✔
UNCOV
3109
      taosMemoryFree(pReq);
×
UNCOV
3110
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
3111
      sdbRelease(pSdb, pVgroup);
×
UNCOV
3112
      TAOS_RETURN(code);
×
3113
    }
3114
    sdbRelease(pSdb, pVgroup);
896,045✔
3115
  }
3116

3117
  TAOS_RETURN(code);
449,175✔
3118
}
3119

3120
static int32_t mndDropStb(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb) {
449,175✔
3121
  int32_t code = -1;
449,175✔
3122
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "drop-stb");
449,175✔
3123
  if (pTrans == NULL) {
449,175✔
UNCOV
3124
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
3125
    if (terrno != 0) code = terrno;
×
UNCOV
3126
    goto _OVER;
×
3127
  }
3128

3129
  mInfo("trans:%d, used to drop stb:%s", pTrans->id, pStb->name);
449,175✔
3130
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
449,175✔
3131
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
449,175✔
3132

3133
  TAOS_CHECK_GOTO(mndSetDropStbPrepareLogs(pMnode, pTrans, pStb), NULL, _OVER);
449,175✔
3134
  TAOS_CHECK_GOTO(mndSetDropStbCommitLogs(pMnode, pTrans, pStb), NULL, _OVER);
449,175✔
3135
  TAOS_CHECK_GOTO(mndSetDropStbRedoActions(pMnode, pTrans, pDb, pStb), NULL, _OVER);
449,175✔
3136
  TAOS_CHECK_GOTO(mndDropIdxsByStb(pMnode, pTrans, pDb, pStb), NULL, _OVER);
449,175✔
3137
  TAOS_CHECK_GOTO(mndDropRsmaByStb(pMnode, pTrans, pDb, pStb), NULL, _OVER);
449,175✔
3138
  TAOS_CHECK_GOTO(mndUserRemoveStb(pMnode, pTrans, pStb->name), NULL, _OVER);
449,175✔
3139
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
449,175✔
3140
  code = 0;
449,175✔
3141

3142
_OVER:
449,175✔
3143
  mndTransDrop(pTrans);
449,175✔
3144
  TAOS_RETURN(code);
449,175✔
3145
}
3146

3147
static int32_t mndCheckDropStbForTopic(SMnode *pMnode, const char *stbFullName, int64_t suid) {
449,427✔
3148
  int32_t code = 0;
449,427✔
3149
  SSdb   *pSdb = pMnode->pSdb;
449,427✔
3150
  void   *pIter = NULL;
449,427✔
3151
  while (1) {
21,639✔
3152
    SMqTopicObj *pTopic = NULL;
471,066✔
3153
    pIter = sdbFetch(pSdb, SDB_TOPIC, pIter, (void **)&pTopic);
471,066✔
3154
    if (pIter == NULL) break;
471,066✔
3155

3156
    if (pTopic->stbUid == suid) {
21,639✔
UNCOV
3157
      sdbRelease(pSdb, pTopic);
×
UNCOV
3158
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
3159
      TAOS_RETURN(TSDB_CODE_MND_TOPIC_MUST_BE_DELETED);
×
3160
    }
3161
    sdbRelease(pSdb, pTopic);
21,639✔
3162
  }
3163
  TAOS_RETURN(code);
449,427✔
3164
}
3165

UNCOV
3166
static int32_t mndCheckDropStbForStream(SMnode *pMnode, const char *stbFullName, int64_t suid) {
×
UNCOV
3167
  int32_t code = 0;
×
UNCOV
3168
  SSdb   *pSdb = pMnode->pSdb;
×
UNCOV
3169
  void   *pIter = NULL;
×
3170
  while (1) {
×
3171
    SStreamObj *pStream = NULL;
×
3172
    pIter = sdbFetch(pSdb, SDB_STREAM, pIter, (void **)&pStream);
×
3173
    if (pIter == NULL) break;
×
3174

UNCOV
3175
    if (pStream->pCreate->outStbUid == suid) {
×
UNCOV
3176
      sdbCancelFetch(pSdb, pIter);
×
UNCOV
3177
      sdbRelease(pSdb, pStream);
×
UNCOV
3178
      TAOS_RETURN(-1);
×
3179
    }
3180

UNCOV
3181
    sdbRelease(pSdb, pStream);
×
3182
  }
UNCOV
3183
  TAOS_RETURN(code);
×
3184
}
3185

UNCOV
3186
static int32_t mndProcessDropTtltbRsp(SRpcMsg *pRsp) { return 0; }
×
UNCOV
3187
static int32_t mndProcessTrimDbRsp(SRpcMsg *pRsp) { return 0; }
×
3188
static int32_t mndProcessTrimDbWalRsp(SRpcMsg *pRsp) { return 0; }
2,232✔
UNCOV
3189
static int32_t mndProcessS3MigrateDbRsp(SRpcMsg *pRsp) { return 0; }
×
3190

3191
static int32_t mndProcessDropStbReq(SRpcMsg *pReq) {
817,257✔
3192
  SMnode      *pMnode = pReq->info.node;
817,257✔
3193
  int32_t      code = -1;
817,257✔
3194
  SDbObj      *pDb = NULL;
817,257✔
3195
  SStbObj     *pStb = NULL;
817,257✔
3196
  SUserObj    *pOperUser = NULL;
817,257✔
3197
  SMDropStbReq dropReq = {0};
817,257✔
3198
  int64_t      tss = taosGetTimestampMs();
817,257✔
3199

3200
  TAOS_CHECK_GOTO(tDeserializeSMDropStbReq(pReq->pCont, pReq->contLen, &dropReq), NULL, _OVER);
817,257✔
3201

3202
  mInfo("stb:%s, start to drop", dropReq.name);
817,257✔
3203

3204
  pStb = mndAcquireStb(pMnode, dropReq.name);
817,257✔
3205
  if (pStb == NULL) {
817,257✔
3206
    if (dropReq.igNotExists) {
367,830✔
3207
      mInfo("stb:%s, not exist, ignore not exist is set", dropReq.name);
366,957✔
3208
      code = 0;
366,957✔
3209
      goto _OVER;
366,957✔
3210
    } else {
3211
      code = TSDB_CODE_MND_STB_NOT_EXIST;
873✔
3212
      goto _OVER;
873✔
3213
    }
3214
  }
3215

3216
  if ((dropReq.source == TD_REQ_FROM_TAOX_OLD || dropReq.source == TD_REQ_FROM_TAOX) && pStb->uid != dropReq.suid) {
449,427✔
UNCOV
3217
    code = 0;
×
UNCOV
3218
    goto _OVER;
×
3219
  }
3220

3221
  pDb = mndAcquireDbByStb(pMnode, dropReq.name);
449,427✔
3222
  if (pDb == NULL) {
449,427✔
UNCOV
3223
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
UNCOV
3224
    goto _OVER;
×
3225
  }
3226

3227
  SName   name = {0};
449,427✔
3228
  int32_t ret = 0;
449,427✔
3229
  if ((ret = tNameFromString(&name, dropReq.name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0)
449,427✔
3230
    mError("stb:%s, failed to tNameFromString since %s", dropReq.name, tstrerror(ret));
×
3231

3232
  // if ((code = mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), MND_OPER_WRITE_DB, pDb)) != 0) {
3233
  //   goto _OVER;
3234
  // }
3235
  TAOS_CHECK_GOTO(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser), NULL, _OVER);
449,427✔
3236
  TAOS_CHECK_GOTO(mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB, pDb), NULL,
449,427✔
3237
                  _OVER);
3238
  TAOS_CHECK_GOTO(
449,427✔
3239
      mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_DROP, PRIV_OBJ_TBL, pStb->ownerId, pDb->name, name.tname),
3240
      NULL, _OVER);
3241
  if ((code = mndCheckDropStbForTopic(pMnode, dropReq.name, pStb->uid)) != 0) {
449,427✔
UNCOV
3242
    goto _OVER;
×
3243
  }
3244

3245
  if (pDb->cfg.isMount) {
449,427✔
3246
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
252✔
3247
    goto _OVER;
252✔
3248
  }
3249

3250
  code = mndDropStb(pMnode, pReq, pDb, pStb);
449,175✔
3251
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
449,175✔
3252

3253
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
449,175✔
3254
    int64_t tse = taosGetTimestampMs();
449,175✔
3255
    double  duration = (double)(tse - tss);
449,175✔
3256
    duration = duration / 1000;
449,175✔
3257
    auditRecord(pReq, pMnode->clusterId, "dropStb", name.dbname, name.tname, dropReq.sql, dropReq.sqlLen, duration, 0);
449,175✔
3258
  }
3259
_OVER:
817,257✔
3260
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
817,257✔
3261
    mError("stb:%s, failed to drop since %s", dropReq.name, tstrerror(code));
1,125✔
3262
  }
3263

3264
  mndReleaseDb(pMnode, pDb);
817,257✔
3265
  mndReleaseStb(pMnode, pStb);
817,257✔
3266
  mndReleaseUser(pMnode, pOperUser);
817,257✔
3267
  tFreeSMDropStbReq(&dropReq);
817,257✔
3268
  TAOS_RETURN(code);
817,257✔
3269
}
3270

3271
static int32_t mndProcessTableMetaReq(SRpcMsg *pReq) {
17,604,134✔
3272
  SMnode       *pMnode = pReq->info.node;
17,604,134✔
3273
  int32_t       code = -1;
17,604,134✔
3274
  STableInfoReq infoReq = {0};
17,604,134✔
3275
  STableMetaRsp metaRsp = {0};
17,604,134✔
3276
  SUserObj     *pUser = NULL;
17,604,134✔
3277

3278
  code = mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pUser);
17,604,134✔
3279
  if (pUser == NULL) return 0;
17,604,134✔
3280
  bool sysinfo = pUser->sysInfo;
17,604,134✔
3281

3282
  TAOS_CHECK_GOTO(tDeserializeSTableInfoReq(pReq->pCont, pReq->contLen, &infoReq), NULL, _OVER);
17,604,134✔
3283

3284
  if (0 == strcmp(infoReq.dbFName, TSDB_INFORMATION_SCHEMA_DB)) {
17,604,134✔
3285
    mInfo("information_schema table:%s.%s, start to retrieve meta", infoReq.dbFName, infoReq.tbName);
1,799,326✔
3286
    TAOS_CHECK_GOTO(mndBuildInsTableSchema(pMnode, infoReq.dbFName, infoReq.tbName, sysinfo, &metaRsp), NULL, _OVER);
1,799,326✔
3287
  } else if (0 == strcmp(infoReq.dbFName, TSDB_PERFORMANCE_SCHEMA_DB)) {
15,804,808✔
3288
    mInfo("performance_schema table:%s.%s, start to retrieve meta", infoReq.dbFName, infoReq.tbName);
134,988✔
3289
    TAOS_CHECK_GOTO(mndBuildPerfsTableSchema(pMnode, infoReq.dbFName, infoReq.tbName, &metaRsp), NULL, _OVER);
134,988✔
3290
  } else {
3291
    mInfo("stb:%s.%s, start to retrieve meta", infoReq.dbFName, infoReq.tbName);
15,669,820✔
3292
    TAOS_CHECK_GOTO(mndBuildStbSchema(pMnode, infoReq.dbFName, infoReq.tbName, &metaRsp, true), NULL, _OVER);
15,669,820✔
3293
  }
3294

3295
  int32_t rspLen = tSerializeSTableMetaRsp(NULL, 0, &metaRsp);
16,718,923✔
3296
  if (rspLen < 0) {
16,718,923✔
UNCOV
3297
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
3298
    goto _OVER;
×
3299
  }
3300

3301
  void *pRsp = rpcMallocCont(rspLen);
16,718,923✔
3302
  if (pRsp == NULL) {
16,718,923✔
UNCOV
3303
    code = terrno;
×
UNCOV
3304
    goto _OVER;
×
3305
  }
3306

3307
  if ((rspLen = tSerializeSTableMetaRsp(pRsp, rspLen, &metaRsp)) < 0) {
16,718,923✔
UNCOV
3308
    code = rspLen;
×
UNCOV
3309
    goto _OVER;
×
3310
  }
3311
  pReq->info.rsp = pRsp;
16,718,923✔
3312
  pReq->info.rspLen = rspLen;
16,718,923✔
3313
  code = 0;
16,718,923✔
3314

3315
  mTrace("%s.%s, meta is retrieved", infoReq.dbFName, infoReq.tbName);
16,718,923✔
3316

3317
_OVER:
17,604,134✔
3318
  if (code != 0) {
17,604,134✔
3319
    mError("stb:%s.%s, failed to retrieve meta since %s", infoReq.dbFName, infoReq.tbName, tstrerror(code));
885,211✔
3320
  }
3321

3322
  mndReleaseUser(pMnode, pUser);
17,604,134✔
3323
  tFreeSTableMetaRsp(&metaRsp);
17,604,134✔
3324
  // TODO change to TAOS_RETURN
3325
  return code;
17,604,134✔
3326
}
3327

3328
static int32_t mndProcessTableCfgReq(SRpcMsg *pReq) {
29,980✔
3329
  SMnode      *pMnode = pReq->info.node;
29,980✔
3330
  int32_t      code = -1;
29,980✔
3331
  STableCfgReq cfgReq = {0};
29,980✔
3332
  STableCfgRsp cfgRsp = {0};
29,980✔
3333

3334
  TAOS_CHECK_GOTO(tDeserializeSTableCfgReq(pReq->pCont, pReq->contLen, &cfgReq), NULL, _OVER);
29,980✔
3335

3336
  char dbName[TSDB_DB_NAME_LEN] = {0};
29,980✔
3337
  TAOS_CHECK_GOTO(mndExtractShortDbNameFromDbFullName(cfgReq.dbFName, dbName), NULL, _OVER);
29,980✔
3338
  if (0 == strcmp(dbName, TSDB_INFORMATION_SCHEMA_DB)) {
29,980✔
3339
    mInfo("information_schema table:%s.%s, start to retrieve cfg", cfgReq.dbFName, cfgReq.tbName);
3,480✔
3340
    TAOS_CHECK_GOTO(mndBuildInsTableCfg(pMnode, cfgReq.dbFName, cfgReq.tbName, &cfgRsp), NULL, _OVER);
3,480✔
3341
  } else if (0 == strcmp(dbName, TSDB_PERFORMANCE_SCHEMA_DB)) {
26,500✔
3342
    mInfo("performance_schema table:%s.%s, start to retrieve cfg", cfgReq.dbFName, cfgReq.tbName);
1,740✔
3343
    TAOS_CHECK_GOTO(mndBuildPerfsTableCfg(pMnode, cfgReq.dbFName, cfgReq.tbName, &cfgRsp), NULL, _OVER);
1,740✔
3344
  } else {
3345
    mInfo("stb:%s.%s, start to retrieve cfg", cfgReq.dbFName, cfgReq.tbName);
24,760✔
3346
    TAOS_CHECK_GOTO(mndBuildStbCfg(pMnode, cfgReq.dbFName, cfgReq.tbName, &cfgRsp), NULL, _OVER);
24,760✔
3347
  }
3348

3349
  int32_t rspLen = tSerializeSTableCfgRsp(NULL, 0, &cfgRsp);
29,980✔
3350
  if (rspLen < 0) {
29,980✔
UNCOV
3351
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
3352
    goto _OVER;
×
3353
  }
3354

3355
  void *pRsp = rpcMallocCont(rspLen);
29,980✔
3356
  if (pRsp == NULL) {
29,980✔
UNCOV
3357
    code = terrno;
×
UNCOV
3358
    goto _OVER;
×
3359
  }
3360

3361
  if ((rspLen = tSerializeSTableCfgRsp(pRsp, rspLen, &cfgRsp)) < 0) {
29,980✔
UNCOV
3362
    code = rspLen;
×
UNCOV
3363
    goto _OVER;
×
3364
  }
3365
  pReq->info.rsp = pRsp;
29,980✔
3366
  pReq->info.rspLen = rspLen;
29,980✔
3367
  code = 0;
29,980✔
3368

3369
  mTrace("%s.%s, cfg is retrieved", cfgReq.dbFName, cfgReq.tbName);
29,980✔
3370

3371
_OVER:
29,980✔
3372
  if (code != 0) {
29,980✔
UNCOV
3373
    mError("stb:%s.%s, failed to retrieve cfg since %s", cfgReq.dbFName, cfgReq.tbName, tstrerror(code));
×
3374
  }
3375

3376
  tFreeSTableCfgRsp(&cfgRsp);
29,980✔
3377
  TAOS_RETURN(code);
29,980✔
3378
}
3379

3380
int32_t mndValidateStbInfo(SMnode *pMnode, SSTableVersion *pStbVersions, int32_t numOfStbs, void **ppRsp,
5,313,093✔
3381
                           int32_t *pRspLen) {
3382
  int32_t   code = 0;
5,313,093✔
3383
  SSTbHbRsp hbRsp = {0};
5,313,093✔
3384
  hbRsp.pMetaRsp = taosArrayInit(numOfStbs, sizeof(STableMetaRsp));
5,313,093✔
3385
  if (hbRsp.pMetaRsp == NULL) {
5,313,093✔
3386
    code = terrno;
×
3387
    TAOS_RETURN(code);
×
3388
  }
3389

3390
  hbRsp.pIndexRsp = taosArrayInit(numOfStbs, sizeof(STableIndexRsp));
5,313,093✔
3391
  if (NULL == hbRsp.pIndexRsp) {
5,313,093✔
3392
    taosArrayDestroy(hbRsp.pMetaRsp);
×
UNCOV
3393
    code = terrno;
×
3394
    TAOS_RETURN(code);
×
3395
  }
3396

3397
  for (int32_t i = 0; i < numOfStbs; ++i) {
12,876,435✔
3398
    SSTableVersion *pStbVersion = &pStbVersions[i];
7,563,342✔
3399
    pStbVersion->suid = be64toh(pStbVersion->suid);
7,563,342✔
3400
    pStbVersion->sversion = ntohl(pStbVersion->sversion);
7,563,342✔
3401
    pStbVersion->tversion = ntohl(pStbVersion->tversion);
7,563,342✔
3402
    pStbVersion->smaVer = ntohl(pStbVersion->smaVer);
7,563,342✔
3403

3404
    bool    schema = false;
7,563,342✔
3405
    bool    sma = false;
7,563,342✔
3406
    int32_t code = mndValidateStbVersion(pMnode, pStbVersion, &schema, &sma);
7,563,342✔
3407
    if (TSDB_CODE_SUCCESS != code) {
7,563,342✔
3408
      STableMetaRsp metaRsp = {0};
37,675✔
3409
      metaRsp.numOfColumns = -1;
37,675✔
3410
      metaRsp.suid = pStbVersion->suid;
37,675✔
3411
      tstrncpy(metaRsp.dbFName, pStbVersion->dbFName, sizeof(metaRsp.dbFName));
37,675✔
3412
      tstrncpy(metaRsp.tbName, pStbVersion->stbName, sizeof(metaRsp.tbName));
37,675✔
3413
      tstrncpy(metaRsp.stbName, pStbVersion->stbName, sizeof(metaRsp.stbName));
37,675✔
3414
      if (taosArrayPush(hbRsp.pMetaRsp, &metaRsp) == NULL) {
75,350✔
UNCOV
3415
        code = terrno;
×
UNCOV
3416
        return code;
×
3417
      }
3418
      continue;
37,675✔
3419
    }
3420

3421
    if (schema) {
7,525,667✔
3422
      STableMetaRsp metaRsp = {0};
14,685✔
3423
      mInfo("stb:%s.%s, start to retrieve meta", pStbVersion->dbFName, pStbVersion->stbName);
14,685✔
3424
      if (mndBuildStbSchema(pMnode, pStbVersion->dbFName, pStbVersion->stbName, &metaRsp, false) != 0) {
14,685✔
UNCOV
3425
        metaRsp.numOfColumns = -1;
×
UNCOV
3426
        metaRsp.suid = pStbVersion->suid;
×
UNCOV
3427
        tstrncpy(metaRsp.dbFName, pStbVersion->dbFName, sizeof(metaRsp.dbFName));
×
UNCOV
3428
        tstrncpy(metaRsp.tbName, pStbVersion->stbName, sizeof(metaRsp.tbName));
×
UNCOV
3429
        tstrncpy(metaRsp.stbName, pStbVersion->stbName, sizeof(metaRsp.stbName));
×
UNCOV
3430
        if (taosArrayPush(hbRsp.pMetaRsp, &metaRsp) == NULL) {
×
UNCOV
3431
          code = terrno;
×
UNCOV
3432
          return code;
×
3433
        }
UNCOV
3434
        continue;
×
3435
      }
3436

3437
      if (taosArrayPush(hbRsp.pMetaRsp, &metaRsp) == NULL) {
29,370✔
UNCOV
3438
        code = terrno;
×
UNCOV
3439
        return code;
×
3440
      }
3441
    }
3442

3443
    if (sma) {
7,525,667✔
UNCOV
3444
      bool           exist = false;
×
UNCOV
3445
      char           tbFName[TSDB_TABLE_FNAME_LEN];
×
UNCOV
3446
      STableIndexRsp indexRsp = {0};
×
UNCOV
3447
      indexRsp.pIndex = taosArrayInit(10, sizeof(STableIndexInfo));
×
UNCOV
3448
      if (NULL == indexRsp.pIndex) {
×
3449
        code = terrno;
×
UNCOV
3450
        TAOS_RETURN(code);
×
3451
      }
3452

UNCOV
3453
      (void)tsnprintf(tbFName, sizeof(tbFName), "%s.%s", pStbVersion->dbFName, pStbVersion->stbName);
×
UNCOV
3454
      tstrncpy(indexRsp.dbFName, pStbVersion->dbFName, sizeof(indexRsp.dbFName));
×
UNCOV
3455
      tstrncpy(indexRsp.tbName, pStbVersion->stbName, sizeof(indexRsp.tbName));
×
3456

UNCOV
3457
      if (taosArrayPush(hbRsp.pIndexRsp, &indexRsp) == NULL) {
×
UNCOV
3458
        code = terrno;
×
UNCOV
3459
        return code;
×
3460
      }
3461
    }
3462
  }
3463

3464
  int32_t rspLen = tSerializeSSTbHbRsp(NULL, 0, &hbRsp);
5,313,093✔
3465
  if (rspLen < 0) {
5,313,093✔
UNCOV
3466
    tFreeSSTbHbRsp(&hbRsp);
×
UNCOV
3467
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
3468
    TAOS_RETURN(code);
×
3469
  }
3470

3471
  void *pRsp = taosMemoryMalloc(rspLen);
5,313,093✔
3472
  if (pRsp == NULL) {
5,313,093✔
UNCOV
3473
    tFreeSSTbHbRsp(&hbRsp);
×
UNCOV
3474
    code = terrno;
×
UNCOV
3475
    TAOS_RETURN(code);
×
3476
  }
3477

3478
  rspLen = tSerializeSSTbHbRsp(pRsp, rspLen, &hbRsp);
5,313,093✔
3479
  tFreeSSTbHbRsp(&hbRsp);
5,313,093✔
3480
  if (rspLen < 0) return rspLen;
5,313,093✔
3481
  *ppRsp = pRsp;
5,313,093✔
3482
  *pRspLen = rspLen;
5,313,093✔
3483
  TAOS_RETURN(code);
5,313,093✔
3484
}
3485

3486
int32_t mndGetNumOfStbs(SMnode *pMnode, char *dbName, int32_t *pNumOfStbs) {
1,877,518✔
3487
  int32_t code = 0;
1,877,518✔
3488
  SSdb   *pSdb = pMnode->pSdb;
1,877,518✔
3489
  SDbObj *pDb = mndAcquireDb(pMnode, dbName);
1,877,518✔
3490
  if (pDb == NULL) {
1,877,518✔
UNCOV
3491
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
UNCOV
3492
    TAOS_RETURN(code);
×
3493
  }
3494

3495
  int32_t numOfStbs = 0;
1,877,518✔
3496
  void   *pIter = NULL;
1,877,518✔
3497
  while (1) {
29,887,669✔
3498
    SStbObj *pStb = NULL;
31,765,187✔
3499
    pIter = sdbFetch(pSdb, SDB_STB, pIter, (void **)&pStb);
31,765,187✔
3500
    if (pIter == NULL) break;
31,765,187✔
3501

3502
    if (pStb->dbUid == pDb->uid) {
29,887,669✔
3503
      numOfStbs++;
19,930,602✔
3504
    }
3505

3506
    sdbRelease(pSdb, pStb);
29,887,669✔
3507
  }
3508

3509
  *pNumOfStbs = numOfStbs;
1,877,518✔
3510
  mndReleaseDb(pMnode, pDb);
1,877,518✔
3511
  TAOS_RETURN(code);
1,877,518✔
3512
}
3513

UNCOV
3514
int32_t mndExtractDbNameFromStbFullName(const char *stbFullName, char *dst) {
×
UNCOV
3515
  SName name = {0};
×
3516
  TAOS_CHECK_RETURN(tNameFromString(&name, stbFullName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
×
3517

UNCOV
3518
  TAOS_CHECK_RETURN(tNameGetFullDbName(&name, dst));
×
3519

UNCOV
3520
  return 0;
×
3521
}
3522

3523
int32_t mndExtractShortDbNameFromStbFullName(const char *stbFullName, char *dst) {
×
UNCOV
3524
  SName name = {0};
×
UNCOV
3525
  TAOS_CHECK_RETURN(tNameFromString(&name, stbFullName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
×
3526

3527
  TAOS_CHECK_RETURN(tNameGetDbName(&name, dst));
×
3528

UNCOV
3529
  return 0;
×
3530
}
3531

3532
int32_t mndExtractShortDbNameFromDbFullName(const char *stbFullName, char *dst) {
29,980✔
3533
  SName name = {0};
29,980✔
3534
  TAOS_CHECK_RETURN(tNameFromString(&name, stbFullName, T_NAME_ACCT | T_NAME_DB));
29,980✔
3535

3536
  TAOS_CHECK_RETURN(tNameGetDbName(&name, dst));
29,980✔
3537

3538
  return 0;
29,980✔
3539
}
3540

3541
void mndExtractTbNameFromStbFullName(const char *stbFullName, char *dst, int32_t dstSize) {
2,754,310✔
3542
  int32_t pos = -1;
2,754,310✔
3543
  int32_t num = 0;
2,754,310✔
3544
  for (pos = 0; stbFullName[pos] != 0; ++pos) {
23,841,604✔
3545
    if (stbFullName[pos] == TS_PATH_DELIMITER[0]) num++;
23,841,604✔
3546
    if (num == 2) break;
23,841,604✔
3547
  }
3548

3549
  if (num == 2) {
2,754,310✔
3550
    tstrncpy(dst, stbFullName + pos + 1, dstSize);
2,754,310✔
3551
  }
3552
}
2,754,310✔
3553

3554
static int32_t mndRetrieveStb(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
265,211✔
3555
  SMnode    *pMnode = pReq->info.node;
265,211✔
3556
  SSdb      *pSdb = pMnode->pSdb;
265,211✔
3557
  int32_t    numOfRows = 0;
265,211✔
3558
  SStbObj   *pStb = NULL;
265,211✔
3559
  SUserObj  *pOperUser = NULL;
265,211✔
3560
  SSHashObj *pUidNames = NULL;
265,211✔
3561
  int32_t    cols = 0;
265,211✔
3562
  int32_t    lino = 0;
265,211✔
3563
  int32_t    code = 0;
265,211✔
3564
  char       objFName[TSDB_OBJ_FNAME_LEN + 1] = {0};
265,211✔
3565
  bool       showAll = false;
265,211✔
3566

3567
  SDbObj *pDb = NULL;
265,211✔
3568
  if (strlen(pShow->db) > 0) {
265,211✔
3569
    pDb = mndAcquireDb(pMnode, pShow->db);
215,697✔
3570
    if (pDb == NULL) return terrno;
215,697✔
3571
  }
3572

3573
  if ((code = mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser)) != 0) {
264,255✔
UNCOV
3574
    goto _ERROR;
×
3575
  }
3576

3577
  (void)snprintf(objFName, sizeof(objFName), "%d.*", pOperUser->acctId);
264,255✔
3578
  showAll = (0 == mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_SHOW, PRIV_OBJ_TBL, pDb ? pDb->ownerId : 0,
264,255✔
3579
                                           pDb ? pDb->name : objFName, "*"));
3580
  showAll = showAll && (0 == mndCheckDbPrivilegeByName(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB,
264,255✔
3581
                                                       pDb ? pDb->name : objFName, false));
3582

3583
  while (numOfRows < rows) {
2,063,229✔
3584
    pShow->pIter = sdbFetch(pSdb, SDB_STB, pShow->pIter, (void **)&pStb);
2,062,262✔
3585
    if (pShow->pIter == NULL) break;
2,062,262✔
3586

3587
    if (pDb != NULL && pStb->dbUid != pDb->uid) {
1,798,974✔
3588
      sdbRelease(pSdb, pStb);
907,212✔
3589
      continue;
907,212✔
3590
    }
3591

3592
    if (isTsmaResSTb(pStb->name)) {
891,762✔
UNCOV
3593
      sdbRelease(pSdb, pStb);
×
UNCOV
3594
      continue;
×
3595
    }
3596

3597
#if 0
3598
    if ((0 == pUser->superUser) && mndCheckStbPrivilege(pMnode, pUser, RPC_MSG_TOKEN(pReq), MND_OPER_SHOW_STB, pStb) != 0) {
3599
      sdbRelease(pSdb, pStb);
3600
      terrno = 0;
3601
      continue;
3602
    }
3603
#endif
3604
    cols = 0;
891,762✔
3605

3606
    SName name = {0};
891,762✔
3607

3608
    char stbName[TSDB_TABLE_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
891,762✔
3609
    mndExtractTbNameFromStbFullName(pStb->name, &stbName[VARSTR_HEADER_SIZE], TSDB_TABLE_NAME_LEN);
891,762✔
3610

3611
    if (!showAll && (mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_SHOW, PRIV_OBJ_TBL, pStb->ownerId, pStb->db,
891,762✔
3612
                                              &stbName[VARSTR_HEADER_SIZE]) ||
3,184✔
3613
                     mndCheckDbPrivilegeByName(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB,
3,184✔
3614
                                               pStb->db, false))) {
3,184✔
3615
      sdbRelease(pSdb, pStb);
2,015✔
3616
      terrno = 0;
2,015✔
3617
      continue;
2,015✔
3618
    }
3619

3620
    varDataSetLen(stbName, strlen(&stbName[VARSTR_HEADER_SIZE]));
889,747✔
3621
    SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
889,747✔
3622
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)stbName, false), pStb, &lino, _ERROR);
889,747✔
3623

3624
    char db[TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
889,747✔
3625
    RETRIEVE_CHECK_GOTO(tNameFromString(&name, pStb->db, T_NAME_ACCT | T_NAME_DB), pStb, &lino, _ERROR);
889,747✔
3626
    RETRIEVE_CHECK_GOTO(tNameGetDbName(&name, varDataVal(db)), pStb, &lino, _ERROR);
889,747✔
3627
    varDataSetLen(db, strlen(varDataVal(db)));
889,747✔
3628
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
889,747✔
3629
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)db, false), pStb, &lino, _ERROR);
889,747✔
3630

3631
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
889,747✔
3632
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->createdTime, false), pStb, &lino,
889,747✔
3633
                        _ERROR);
3634

3635
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
889,747✔
3636
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->numOfColumns, false), pStb, &lino,
889,747✔
3637
                        _ERROR);
3638

3639
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
889,747✔
3640
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->numOfTags, false), pStb, &lino, _ERROR);
889,747✔
3641

3642
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
889,747✔
3643
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->updateTime, false), pStb, &lino,
889,747✔
3644
                        _ERROR);  // number of tables
3645

3646
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
889,747✔
3647
    if (pStb->commentLen > 0) {
889,747✔
3648
      char comment[TSDB_TB_COMMENT_LEN + VARSTR_HEADER_SIZE] = {0};
18,292✔
3649
      STR_TO_VARSTR(comment, pStb->comment);
18,292✔
3650
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, comment, false), pStb, &lino, _ERROR);
18,292✔
3651
    } else if (pStb->commentLen == 0) {
871,455✔
3652
      char comment[VARSTR_HEADER_SIZE + VARSTR_HEADER_SIZE] = {0};
117,174✔
3653
      STR_TO_VARSTR(comment, "");
117,174✔
3654
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, comment, false), pStb, &lino, _ERROR);
117,174✔
3655
    } else {
3656
      colDataSetNULL(pColInfo, numOfRows);
754,281✔
3657
    }
3658

3659
    char watermark[64 + VARSTR_HEADER_SIZE] = {0};
889,747✔
3660
    (void)tsnprintf(varDataVal(watermark), sizeof(watermark) - VARSTR_HEADER_SIZE, "%" PRId64 "a,%" PRId64 "a",
1,779,494✔
3661
              pStb->watermark[0], pStb->watermark[1]);
1,779,494✔
3662
    varDataSetLen(watermark, strlen(varDataVal(watermark)));
889,747✔
3663

3664
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
889,747✔
3665
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)watermark, false), pStb, &lino, _ERROR);
889,747✔
3666

3667
    char maxDelay[64 + VARSTR_HEADER_SIZE] = {0};
889,747✔
3668
    (void)tsnprintf(varDataVal(maxDelay), sizeof(maxDelay) - VARSTR_HEADER_SIZE, "%" PRId64 "a,%" PRId64 "a",
1,779,494✔
3669
              pStb->maxdelay[0], pStb->maxdelay[1]);
1,779,494✔
3670
    varDataSetLen(maxDelay, strlen(varDataVal(maxDelay)));
889,747✔
3671

3672
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
889,747✔
3673
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)maxDelay, false), pStb, &lino, _ERROR);
889,747✔
3674

3675
    char    rollup[160 + VARSTR_HEADER_SIZE] = {0};
889,747✔
3676
    int32_t rollupNum = (int32_t)taosArrayGetSize(pStb->pFuncs);
889,747✔
3677
    char   *sep = ", ";
889,747✔
3678
    int32_t sepLen = strlen(sep);
889,747✔
3679
    int32_t rollupLen = sizeof(rollup) - VARSTR_HEADER_SIZE - 2;
889,747✔
3680
    for (int32_t i = 0; i < rollupNum; ++i) {
889,747✔
UNCOV
3681
      char *funcName = taosArrayGet(pStb->pFuncs, i);
×
UNCOV
3682
      if (i) {
×
UNCOV
3683
        (void)strncat(varDataVal(rollup), sep, rollupLen);
×
UNCOV
3684
        rollupLen -= sepLen;
×
3685
      }
3686
      (void)strncat(varDataVal(rollup), funcName, rollupLen);
×
3687
      rollupLen -= strlen(funcName);
×
3688
    }
3689
    varDataSetLen(rollup, strlen(varDataVal(rollup)));
889,747✔
3690

3691
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
889,747✔
3692
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)rollup, false), pStb, &lino, _ERROR);
889,747✔
3693

3694
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
889,747✔
3695
    if (pColInfo) {
889,747✔
3696
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)(&pStb->uid), false), pStb, &lino, _ERROR);
889,747✔
3697
    }
3698

3699
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
889,747✔
3700
    if (pColInfo) {
889,747✔
3701
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)(&pStb->virtualStb), false), pStb, &lino, _ERROR);
889,747✔
3702
    }
3703

3704
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
889,747✔
3705
    if (pColInfo) {
889,747✔
3706
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)(&pStb->keep), false), pStb, &lino, _ERROR);
889,747✔
3707
    }
3708

3709
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
889,747✔
3710
    if (pColInfo) {
889,747✔
3711
      if (!pUidNames) {
889,747✔
3712
        TAOS_CHECK_GOTO(mndBuildUidNamesHash(pMnode, &pUidNames), &lino, _OVER);
204,934✔
3713
      }
3714
      const char *ownerName = tSimpleHashGet(pUidNames, (const char *)&pStb->ownerId, sizeof(pStb->ownerId));
889,747✔
3715
      char        owner[TSDB_USER_LEN + VARSTR_HEADER_SIZE] = {0};
889,747✔
3716
      STR_WITH_MAXSIZE_TO_VARSTR(owner, ownerName ? ownerName : "[unknown]", sizeof(owner));
889,747✔
3717
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)owner, false), pStb, &lino, _ERROR);
889,747✔
3718
    }
3719

3720
    numOfRows++;
889,747✔
3721
    sdbRelease(pSdb, pStb);
889,747✔
3722
  }
3723

3724
  if (pDb != NULL) {
264,255✔
3725
    mndReleaseDb(pMnode, pDb);
214,741✔
3726
  }
3727
  if (pOperUser != NULL) {
264,255✔
3728
    mndReleaseUser(pMnode, pOperUser);
264,255✔
3729
  }
3730

3731
  goto _OVER;
264,255✔
3732

3733
_ERROR:
×
3734
  if (pDb != NULL) {
×
3735
    mndReleaseDb(pMnode, pDb);
×
3736
  }
3737
  if (pOperUser != NULL) {
×
UNCOV
3738
    mndReleaseUser(pMnode, pOperUser);
×
3739
  }
UNCOV
3740
  mError("show:0x%" PRIx64 ", failed to retrieve data at %s:%d since %s", pShow->id, __FUNCTION__, lino,
×
3741
         tstrerror(code));
3742

3743
_OVER:
264,255✔
3744
  pShow->numOfRows += numOfRows;
264,255✔
3745
  tSimpleHashCleanup(pUidNames);
264,255✔
3746
  return numOfRows;
264,255✔
3747
}
3748

3749
static int32_t buildDbColsInfoBlock(const SSDataBlock *p, const SSysTableMeta *pSysDbTableMeta, size_t size,
1,756,348✔
3750
                                    const char *dbName, const char *tbName) {
3751
  char    tName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
1,756,348✔
3752
  char    dName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
1,756,348✔
3753
  char    typeName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
1,756,348✔
3754
  int32_t numOfRows = p->info.rows;
1,756,348✔
3755
  int32_t lino = 0;
1,756,348✔
3756
  int32_t code = 0;
1,755,848✔
3757

3758
  STR_TO_VARSTR(dName, dbName);
1,755,848✔
3759
  STR_TO_VARSTR(typeName, "SYSTEM_TABLE");
1,756,348✔
3760

3761
  for (int32_t i = 0; i < size; ++i) {
57,958,484✔
3762
    const SSysTableMeta *pm = &pSysDbTableMeta[i];
56,201,636✔
3763
    //    if (pm->sysInfo) {
3764
    //      continue;
3765
    //    }
3766
    if (tbName[0] && strncmp(tbName, pm->name, TSDB_TABLE_NAME_LEN) != 0) {
56,189,636✔
UNCOV
3767
      continue;
×
3768
    }
3769

3770
    STR_TO_VARSTR(tName, pm->name);
56,200,636✔
3771

3772
    for (int32_t j = 0; j < pm->colNum; j++) {
544,368,880✔
3773
      // table name
3774
      SColumnInfoData *pColInfoData = taosArrayGet(p->pDataBlock, 0);
488,174,244✔
3775
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, tName, false), &lino, _OVER);
487,959,744✔
3776

3777
      // database name
3778
      pColInfoData = taosArrayGet(p->pDataBlock, 1);
488,075,244✔
3779
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, dName, false), &lino, _OVER);
488,072,244✔
3780

3781
      pColInfoData = taosArrayGet(p->pDataBlock, 2);
488,073,744✔
3782
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, typeName, false), &lino, _OVER);
488,058,244✔
3783

3784
      // col name
3785
      char colName[TSDB_COL_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
488,071,244✔
3786
      STR_TO_VARSTR(colName, pm->schema[j].name);
488,070,244✔
3787
      pColInfoData = taosArrayGet(p->pDataBlock, 3);
488,188,744✔
3788
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, colName, false), &lino, _OVER);
488,123,244✔
3789

3790
      // col type
3791
      int8_t colType = pm->schema[j].type;
488,125,244✔
3792
      pColInfoData = taosArrayGet(p->pDataBlock, 4);
488,128,744✔
3793
      char colTypeStr[VARSTR_HEADER_SIZE + 32];
488,139,244✔
3794
      int  colTypeLen =
488,180,744✔
3795
          tsnprintf(varDataVal(colTypeStr), sizeof(colTypeStr) - VARSTR_HEADER_SIZE, "%s", tDataTypes[colType].name);
488,140,744✔
3796
      if (colType == TSDB_DATA_TYPE_VARCHAR) {
488,180,744✔
3797
        colTypeLen +=
253,755,786✔
3798
            tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE, "(%d)",
253,601,286✔
3799
                      (int32_t)(pm->schema[j].bytes - VARSTR_HEADER_SIZE));
253,740,286✔
3800
      } else if (colType == TSDB_DATA_TYPE_NCHAR) {
234,440,458✔
UNCOV
3801
        colTypeLen +=
×
UNCOV
3802
            tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE, "(%d)",
×
UNCOV
3803
                      (int32_t)((pm->schema[j].bytes - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE));
×
3804
      }
3805
      varDataSetLen(colTypeStr, colTypeLen);
488,196,244✔
3806
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, (char *)colTypeStr, false), &lino, _OVER);
488,010,244✔
3807

3808
      // col length
3809
      pColInfoData = taosArrayGet(p->pDataBlock, 5);
488,139,744✔
3810
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, (const char *)&pm->schema[j].bytes, false), &lino, _OVER);
488,127,244✔
3811

3812
      // col precision, col scale, col nullable, col source
3813
      for (int32_t k = 6; k <= 10; ++k) {
2,147,483,647✔
3814
        pColInfoData = taosArrayGet(p->pDataBlock, k);
2,147,483,647✔
3815
        colDataSetNULL(pColInfoData, numOfRows);
2,147,483,647✔
3816
      }
3817

3818
      numOfRows += 1;
493,062,244✔
3819
    }
3820
  }
3821
  return numOfRows;
1,756,848✔
UNCOV
3822
_OVER:
×
UNCOV
3823
  mError("failed at %s:%d since %s", __FUNCTION__, lino, tstrerror(code));
×
UNCOV
3824
  return numOfRows;
×
3825
}
3826
#define BUILD_COL_FOR_INFO_DB 1
3827
#define BUILD_COL_FOR_PERF_DB 1 << 1
3828
#define BUILD_COL_FOR_USER_DB 1 << 2
3829
#define BUILD_COL_FOR_ALL_DB  (BUILD_COL_FOR_INFO_DB | BUILD_COL_FOR_PERF_DB | BUILD_COL_FOR_USER_DB)
3830

3831
static int32_t buildSysDbColsInfo(SSDataBlock *p, int8_t buildWhichDBs, char *tb) {
910,725✔
3832
  size_t               size = 0;
910,725✔
3833
  const SSysTableMeta *pSysDbTableMeta = NULL;
910,725✔
3834

3835
  if (buildWhichDBs & BUILD_COL_FOR_INFO_DB) {
910,725✔
3836
    getInfosDbMeta(&pSysDbTableMeta, &size);
878,174✔
3837
    p->info.rows = buildDbColsInfoBlock(p, pSysDbTableMeta, size, TSDB_INFORMATION_SCHEMA_DB, tb);
878,174✔
3838
  }
3839

3840
  if (buildWhichDBs & BUILD_COL_FOR_PERF_DB) {
910,725✔
3841
    getPerfDbMeta(&pSysDbTableMeta, &size);
878,174✔
3842
    p->info.rows = buildDbColsInfoBlock(p, pSysDbTableMeta, size, TSDB_PERFORMANCE_SCHEMA_DB, tb);
878,174✔
3843
  }
3844

3845
  return p->info.rows;
910,725✔
3846
}
3847

3848
static int8_t determineBuildColForWhichDBs(const char *db) {
914,181✔
3849
  int8_t buildWhichDBs;
3850
  if (!db[0])
914,181✔
3851
    buildWhichDBs = BUILD_COL_FOR_ALL_DB;
878,030✔
3852
  else {
3853
    char *p = strchr(db, '.');
36,151✔
3854
    if (p && strcmp(p + 1, TSDB_INFORMATION_SCHEMA_DB) == 0) {
36,151✔
3855
      buildWhichDBs = BUILD_COL_FOR_INFO_DB;
144✔
3856
    } else if (p && strcmp(p + 1, TSDB_PERFORMANCE_SCHEMA_DB) == 0) {
36,007✔
3857
      buildWhichDBs = BUILD_COL_FOR_PERF_DB;
144✔
3858
    } else {
3859
      buildWhichDBs = BUILD_COL_FOR_USER_DB;
35,863✔
3860
    }
3861
  }
3862
  return buildWhichDBs;
914,181✔
3863
}
3864

3865
static int32_t mndRetrieveStbCol(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
914,181✔
3866
  uint8_t  buildWhichDBs;
3867
  SMnode  *pMnode = pReq->info.node;
914,181✔
3868
  SSdb    *pSdb = pMnode->pSdb;
914,181✔
3869
  SStbObj *pStb = NULL;
914,181✔
3870
  int32_t  numOfRows = 0;
914,181✔
3871
  int32_t  lino = 0;
914,181✔
3872
  int32_t  code = 0;
914,181✔
3873

3874
  buildWhichDBs = determineBuildColForWhichDBs(pShow->db);
914,181✔
3875

3876
  if (!pShow->sysDbRsp) {
914,181✔
3877
    numOfRows = buildSysDbColsInfo(pBlock, buildWhichDBs, pShow->filterTb);
910,725✔
3878
    mDebug("mndRetrieveStbCol get system table cols, rows:%d, db:%s", numOfRows, pShow->db);
910,725✔
3879
    pShow->sysDbRsp = true;
910,725✔
3880
  }
3881

3882
  if (buildWhichDBs & BUILD_COL_FOR_USER_DB) {
914,181✔
3883
    SDbObj *pDb = NULL;
913,893✔
3884
    if (strlen(pShow->db) > 0) {
913,893✔
3885
      pDb = mndAcquireDb(pMnode, pShow->db);
35,863✔
3886
      if (pDb == NULL && TSDB_CODE_MND_DB_NOT_EXIST != terrno && pBlock->info.rows == 0) return terrno;
35,863✔
3887
    }
3888

3889
    char typeName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
913,893✔
3890
    STR_TO_VARSTR(typeName, "SUPER_TABLE");
913,893✔
3891
    bool fetch = pShow->restore ? false : true;
913,893✔
3892
    pShow->restore = false;
913,893✔
3893
    while (numOfRows < rows) {
2,679,974✔
3894
      if (fetch) {
2,679,974✔
3895
        pShow->pIter = sdbFetch(pSdb, SDB_STB, pShow->pIter, (void **)&pStb);
2,676,518✔
3896
        if (pShow->pIter == NULL) break;
2,676,518✔
3897
      } else {
3898
        fetch = true;
3,456✔
3899
        void *pKey = taosHashGetKey(pShow->pIter, NULL);
3,456✔
3900
        pStb = sdbAcquire(pSdb, SDB_STB, pKey);
3,456✔
3901
        if (!pStb) continue;
3,456✔
3902
      }
3903

3904
      if (pDb != NULL && pStb->dbUid != pDb->uid) {
1,769,537✔
3905
        sdbRelease(pSdb, pStb);
2,428✔
3906
        continue;
2,428✔
3907
      }
3908

3909
      SName name = {0};
1,767,109✔
3910
      char  stbName[TSDB_TABLE_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
1,767,109✔
3911
      mndExtractTbNameFromStbFullName(pStb->name, &stbName[VARSTR_HEADER_SIZE], TSDB_TABLE_NAME_LEN);
1,767,109✔
3912
      if (pShow->filterTb[0] && strncmp(pShow->filterTb, &stbName[VARSTR_HEADER_SIZE], TSDB_TABLE_NAME_LEN) != 0) {
1,767,109✔
UNCOV
3913
        sdbRelease(pSdb, pStb);
×
UNCOV
3914
        continue;
×
3915
      }
3916

3917
      if ((numOfRows + pStb->numOfColumns) > rows) {
1,767,109✔
3918
        pShow->restore = true;
3,456✔
3919
        if (numOfRows == 0) {
3,456✔
UNCOV
3920
          mError("mndRetrieveStbCol failed to get stable cols since buf:%d less than result:%d, stable name:%s, db:%s",
×
3921
                 rows, pStb->numOfColumns, pStb->name, pStb->db);
3922
        }
3923
        sdbRelease(pSdb, pStb);
3,456✔
3924
        break;
3,456✔
3925
      }
3926

3927
      varDataSetLen(stbName, strlen(&stbName[VARSTR_HEADER_SIZE]));
1,763,653✔
3928

3929
      mDebug("mndRetrieveStbCol get stable cols, stable name:%s, db:%s", pStb->name, pStb->db);
1,763,653✔
3930

3931
      char db[TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
1,763,653✔
3932
      RETRIEVE_CHECK_GOTO(tNameFromString(&name, pStb->db, T_NAME_ACCT | T_NAME_DB), pStb, &lino, _OVER);
1,763,653✔
3933
      RETRIEVE_CHECK_GOTO(tNameGetDbName(&name, varDataVal(db)), pStb, &lino, _OVER);
1,763,653✔
3934
      varDataSetLen(db, strlen(varDataVal(db)));
1,763,653✔
3935

3936
      for (int i = 0; i < pStb->numOfColumns; i++) {
31,727,464✔
3937
        int32_t          cols = 0;
29,963,811✔
3938
        SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
29,963,811✔
3939
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)stbName, false), pStb, &lino, _OVER);
29,963,811✔
3940

3941
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
29,963,811✔
3942
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)db, false), pStb, &lino, _OVER);
29,963,811✔
3943

3944
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
29,963,811✔
3945
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, typeName, false), pStb, &lino, _OVER);
29,963,811✔
3946

3947
        // col name
3948
        char colName[TSDB_COL_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
29,963,811✔
3949
        STR_TO_VARSTR(colName, pStb->pColumns[i].name);
29,963,811✔
3950
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
29,963,811✔
3951
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, colName, false), pStb, &lino, _OVER);
29,963,811✔
3952

3953
        // col type
3954
        int8_t colType = pStb->pColumns[i].type;
29,963,811✔
3955
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
29,963,811✔
3956
        char colTypeStr[VARSTR_HEADER_SIZE + 32];
29,963,811✔
3957
        int  colTypeLen =
29,963,811✔
3958
            tsnprintf(varDataVal(colTypeStr), sizeof(colTypeStr) - VARSTR_HEADER_SIZE, "%s", tDataTypes[colType].name);
29,963,811✔
3959
        if (colType == TSDB_DATA_TYPE_VARCHAR) {
29,963,811✔
3960
          colTypeLen +=
973,878✔
3961
              tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE,
973,878✔
3962
                        "(%d)", (int32_t)(pStb->pColumns[i].bytes - VARSTR_HEADER_SIZE));
973,878✔
3963
        } else if (colType == TSDB_DATA_TYPE_NCHAR) {
28,989,933✔
3964
          colTypeLen +=
973,038✔
3965
              tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE,
973,538✔
3966
                        "(%d)", (int32_t)((pStb->pColumns[i].bytes - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE));
973,538✔
3967
        } else if (IS_DECIMAL_TYPE(colType)) {
28,016,395✔
UNCOV
3968
          STypeMod typeMod = pStb->pExtSchemas[i].typeMod;
×
UNCOV
3969
          uint8_t prec = 0, scale = 0;
×
UNCOV
3970
          decimalFromTypeMod(typeMod, &prec, &scale);
×
UNCOV
3971
          colTypeLen += sprintf(varDataVal(colTypeStr) + colTypeLen, "(%d,%d)", prec, scale);
×
3972
        }
3973
        varDataSetLen(colTypeStr, colTypeLen);
29,963,311✔
3974
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (char *)colTypeStr, false), pStb, &lino, _OVER);
29,963,311✔
3975

3976
        // col length
3977
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
29,963,311✔
3978
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->pColumns[i].bytes, false), pStb,
29,963,311✔
3979
                            &lino, _OVER);
3980
        
3981
        // col precision, col scale, col nullable, col source
3982
        for (int32_t j = 6; j <= 9; ++j) {
149,816,055✔
3983
          pColInfo = taosArrayGet(pBlock->pDataBlock, j);
119,853,744✔
3984
          colDataSetNULL(pColInfo, numOfRows);
119,853,244✔
3985
        }
3986

3987
        // col id
3988
        pColInfo = taosArrayGet(pBlock->pDataBlock, 10);
29,962,311✔
3989
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->pColumns[i].colId, false), pStb,
29,963,811✔
3990
                            &lino, _OVER);
3991
        numOfRows++;
29,963,811✔
3992
      }
3993

3994
      sdbRelease(pSdb, pStb);
1,763,653✔
3995
    }
3996

3997
    if (pDb != NULL) {
913,893✔
3998
      mndReleaseDb(pMnode, pDb);
35,689✔
3999
    }
4000
  }
4001

4002
  mDebug("mndRetrieveStbCol success, rows:%d, pShow->numOfRows:%d", numOfRows, pShow->numOfRows);
914,181✔
4003
  goto _OVER;
914,181✔
4004

4005
_ERROR:
4006
  mError("failed to mndRetrieveStbCol, rows:%d, pShow->numOfRows:%d, at %s:%d since %s", numOfRows, pShow->numOfRows,
4007
         __FUNCTION__, lino, tstrerror(code));
4008

4009
_OVER:
914,181✔
4010
  pShow->numOfRows += numOfRows;
914,181✔
4011
  return numOfRows;
914,181✔
4012
}
4013

4014
static void mndCancelGetNextStb(SMnode *pMnode, void *pIter) {
144✔
4015
  SSdb *pSdb = pMnode->pSdb;
144✔
4016
  sdbCancelFetchByType(pSdb, pIter, SDB_STB);
144✔
4017
}
144✔
4018

UNCOV
4019
const char *mndGetStbStr(const char *src) {
×
4020
  char *posDb = strstr(src, TS_PATH_DELIMITER);
×
4021
  if (posDb != NULL) ++posDb;
×
4022
  if (posDb == NULL) return src;
×
4023

UNCOV
4024
  char *posStb = strstr(posDb, TS_PATH_DELIMITER);
×
UNCOV
4025
  if (posStb != NULL) ++posStb;
×
UNCOV
4026
  if (posStb == NULL) return posDb;
×
UNCOV
4027
  return posStb;
×
4028
}
4029

UNCOV
4030
static int32_t mndCheckIndexReq(SCreateTagIndexReq *pReq) {
×
4031
  // impl
UNCOV
4032
  return TSDB_CODE_SUCCESS;
×
4033
}
4034

4035
/*int32_t mndAddIndexImpl(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp, void *sql,
4036
                        int32_t len) {
4037
  // impl later
4038
  int32_t code = 0;
4039
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "create-stb-index");
4040
  if (pTrans == NULL) goto _OVER;
4041

4042
  mInfo("trans:%d, used to add index to stb:%s", pTrans->id, pStb->name);
4043
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
4044
  if (mndTransCheckConflict(pMnode, pTrans) != 0) goto _OVER;
4045

4046
  if (mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb) != 0) goto _OVER;
4047
  if (mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb) != 0) goto _OVER;
4048
  if (mndSetAlterStbRedoActions2(pMnode, pTrans, pDb, pStb, sql, len) != 0) goto _OVER;
4049
  if (mndTransPrepare(pMnode, pTrans) != 0) goto _OVER;
4050

4051
  return code;
4052

4053
_OVER:
4054
  mndTransDrop(pTrans);
4055
  return code;
4056
}
4057
static int32_t mndAddIndex(SMnode *pMnode, SRpcMsg *pReq, SCreateTagIndexReq *tagIdxReq, SDbObj *pDb, SStbObj *pOld) {
4058
  bool    needRsp = true;
4059
  int32_t code = -1;
4060
  SField *pField0 = NULL;
4061

4062
  SStbObj  stbObj = {0};
4063
  SStbObj *pNew = &stbObj;
4064

4065
  taosRLockLatch(&pOld->lock);
4066
  memcpy(&stbObj, pOld, sizeof(SStbObj));
4067
  taosRUnLockLatch(&pOld->lock);
4068

4069
  stbObj.pColumns = NULL;
4070
  stbObj.pTags = NULL;
4071
  stbObj.updateTime = taosGetTimestampMs();
4072
  stbObj.lock = 0;
4073

4074
  int32_t tag = mndFindSuperTableTagIndex(pOld, tagIdxReq->colName);
4075
  if (tag < 0) {
4076
    terrno = TSDB_CODE_MND_TAG_NOT_EXIST;
4077
    return -1;
4078
  }
4079
  if (mndAllocStbSchemas(pOld, pNew) != 0) {
4080
    return -1;
4081
  }
4082

4083
  SSchema *pTag = pNew->pTags + tag;
4084
  if (IS_IDX_ON(pTag)) {
4085
    terrno = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
4086
    return -1;
4087
  } else {
4088
    pTag->flags |= COL_IDX_ON;
4089
  }
4090
  pNew->tagVer++;
4091

4092
  code = mndAddIndexImpl(pMnode, pReq, pDb, pNew, needRsp, pReq->pCont, pReq->contLen);
4093

4094
  return code;
4095
}
4096
static int32_t mndProcessCreateIndexReq(SRpcMsg *pReq) {
4097
  SMnode            *pMnode = pReq->info.node;
4098
  int32_t            code = -1;
4099
  SDbObj            *pDb = NULL;
4100
  SStbObj           *pStb = NULL;
4101
  SCreateTagIndexReq tagIdxReq = {0};
4102

4103
  if (tDeserializeSCreateTagIdxReq(pReq->pCont, pReq->contLen, &tagIdxReq) != 0) {
4104
    terrno = TSDB_CODE_INVALID_MSG;
4105
    goto _OVER;
4106
  }
4107

4108
  mInfo("stb:%s, start to alter", tagIdxReq.stbName);
4109

4110
  if (mndCheckIndexReq(&tagIdxReq) != TSDB_CODE_SUCCESS) {
4111
    goto _OVER;
4112
  }
4113

4114
  pDb = mndAcquireDbByStb(pMnode, tagIdxReq.dbFName);
4115
  if (pDb == NULL) {
4116
    terrno = TSDB_CODE_MND_DB_NOT_EXIST;
4117
    goto _OVER;
4118
  }
4119

4120
  pStb = mndAcquireStb(pMnode, tagIdxReq.stbName);
4121
  if (pStb == NULL) {
4122
    terrno = TSDB_CODE_MND_STB_NOT_EXIST;
4123
    goto _OVER;
4124
  }
4125
  if (mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_WRITE_DB, pDb) != 0) {
4126
    goto _OVER;
4127
  }
4128

4129
  code = mndAddIndex(pMnode, pReq, &tagIdxReq, pDb, pStb);
4130
  if (terrno == TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST || terrno == TSDB_CODE_MND_TAG_NOT_EXIST) {
4131
    return terrno;
4132
  } else {
4133
    if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
4134
  }
4135
_OVER:
4136
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
4137
    mError("stb:%s, failed to create index since %s", tagIdxReq.stbName, terrstr());
4138
  }
4139
  mndReleaseStb(pMnode, pStb);
4140
  mndReleaseDb(pMnode, pDb);
4141
  return code;
4142
}
4143
static int32_t mndProcessDropIndexReq(SRpcMsg *pReq) {
4144
  SMnode          *pMnode = pReq->info.node;
4145
  int32_t          code = -1;
4146
  SDbObj          *pDb = NULL;
4147
  SStbObj         *pStb = NULL;
4148
  SDropTagIndexReq dropReq = {0};
4149
  if (tDeserializeSDropTagIdxReq(pReq->pCont, pReq->contLen, &dropReq) != 0) {
4150
    terrno = TSDB_CODE_INVALID_MSG;
4151
    goto _OVER;
4152
  }
4153
  //
4154
  return TSDB_CODE_SUCCESS;
4155
_OVER:
4156
  return code;
4157
}*/
4158

4159
static int32_t mndProcessDropStbReqFromMNode(SRpcMsg *pReq) {
2,103✔
4160
  int32_t code = mndProcessDropStbReq(pReq);
2,103✔
4161
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
2,103✔
UNCOV
4162
    pReq->info.rsp = rpcMallocCont(1);
×
UNCOV
4163
    pReq->info.rspLen = 1;
×
UNCOV
4164
    pReq->info.noResp = false;
×
UNCOV
4165
    pReq->code = code;
×
4166
  }
4167
  return code;
2,103✔
4168
}
4169

4170
typedef struct SVDropTbVgReqs {
4171
  SArray     *pBatchReqs;
4172
  SVgroupInfo info;
4173
} SVDropTbVgReqs;
4174

4175
typedef struct SMDropTbDbInfo {
4176
  SArray *dbVgInfos;
4177
  int32_t hashPrefix;
4178
  int32_t hashSuffix;
4179
  int32_t hashMethod;
4180
} SMDropTbDbInfo;
4181

4182
typedef struct SMDropTbTsmaInfo {
4183
  char           tsmaResTbDbFName[TSDB_DB_FNAME_LEN];
4184
  char           tsmaResTbNamePrefix[TSDB_TABLE_FNAME_LEN];
4185
  int32_t        suid;
4186
  SMDropTbDbInfo dbInfo;  // reference to DbInfo in pDbMap
4187
} SMDropTbTsmaInfo;
4188

4189
typedef struct SMDropTbTsmaInfos {
4190
  SArray *pTsmaInfos;  // SMDropTbTsmaInfo
4191
} SMDropTbTsmaInfos;
4192

4193
typedef struct SMndDropTbsWithTsmaCtx {
4194
  SHashObj *pVgMap;  // <vgId, SVDropTbVgReqs>
4195
} SMndDropTbsWithTsmaCtx;
4196

4197
static int32_t mndDropTbForSingleVg(SMnode *pMnode, SMndDropTbsWithTsmaCtx *pCtx, SArray *pTbs, int32_t vgId);
4198

4199
static void destroySVDropTbBatchReqs(void *p);
4200
static void mndDestroyDropTbsWithTsmaCtx(SMndDropTbsWithTsmaCtx *p) {
11,640✔
4201
  if (!p) return;
11,640✔
4202

4203
  if (p->pVgMap) {
11,640✔
4204
    void *pIter = taosHashIterate(p->pVgMap, NULL);
11,640✔
4205
    while (pIter) {
23,280✔
4206
      SVDropTbVgReqs *pReqs = pIter;
11,640✔
4207
      taosArrayDestroyEx(pReqs->pBatchReqs, destroySVDropTbBatchReqs);
11,640✔
4208
      pIter = taosHashIterate(p->pVgMap, pIter);
11,640✔
4209
    }
4210
    taosHashCleanup(p->pVgMap);
11,640✔
4211
  }
4212
  taosMemoryFree(p);
11,640✔
4213
}
4214

4215
static int32_t mndInitDropTbsWithTsmaCtx(SMndDropTbsWithTsmaCtx **ppCtx) {
11,640✔
4216
  int32_t                 code = 0;
11,640✔
4217
  SMndDropTbsWithTsmaCtx *pCtx = taosMemoryCalloc(1, sizeof(SMndDropTbsWithTsmaCtx));
11,640✔
4218
  if (!pCtx) return terrno;
11,640✔
4219

4220
  pCtx->pVgMap = taosHashInit(4, taosGetDefaultHashFunction(TSDB_DATA_TYPE_INT), false, HASH_NO_LOCK);
11,640✔
4221
  if (!pCtx->pVgMap) {
11,640✔
UNCOV
4222
    code = terrno;
×
UNCOV
4223
    goto _end;
×
4224
  }
4225

4226
  *ppCtx = pCtx;
11,640✔
4227
_end:
11,640✔
4228
  if (code) mndDestroyDropTbsWithTsmaCtx(pCtx);
11,640✔
4229
  return code;
11,640✔
4230
}
4231

4232
static void *mndBuildVDropTbsReq(SMnode *pMnode, const SVgroupInfo *pVgInfo, const SVDropTbBatchReq *pReq,
33,680✔
4233
                                 int32_t *len) {
4234
  int32_t   contLen = 0;
33,680✔
4235
  int32_t   ret = 0;
33,680✔
4236
  SMsgHead *pHead = NULL;
33,680✔
4237
  SEncoder  encoder = {0};
33,680✔
4238

4239
  tEncodeSize(tEncodeSVDropTbBatchReq, pReq, contLen, ret);
33,680✔
4240
  if (ret < 0) return NULL;
33,680✔
4241

4242
  contLen += sizeof(SMsgHead);
33,680✔
4243
  pHead = taosMemoryMalloc(contLen);
33,680✔
4244
  if (pHead == NULL) {
33,680✔
4245
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
4246
    return NULL;
×
4247
  }
4248

4249
  pHead->contLen = htonl(contLen);
33,680✔
4250
  pHead->vgId = htonl(pVgInfo->vgId);
33,680✔
4251

4252
  void *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
33,680✔
4253

4254
  tEncoderInit(&encoder, pBuf, contLen - sizeof(SMsgHead));
33,680✔
4255
  int32_t code = tEncodeSVDropTbBatchReq(&encoder, pReq);
33,680✔
4256
  tEncoderClear(&encoder);
33,680✔
4257
  if (code != 0) return NULL;
33,680✔
4258

4259
  *len = contLen;
33,680✔
4260
  return pHead;
33,680✔
4261
}
4262

4263
static int32_t mndSetDropTbsRedoActions(SMnode *pMnode, STrans *pTrans, const SVDropTbVgReqs *pVgReqs, void *pCont,
33,680✔
4264
                                        int32_t contLen, tmsg_t msgType) {
4265
  STransAction action = {0};
33,680✔
4266
  action.epSet = pVgReqs->info.epSet;
33,680✔
4267
  action.pCont = pCont;
33,680✔
4268
  action.contLen = contLen;
33,680✔
4269
  action.msgType = msgType;
33,680✔
4270
  action.acceptableCode = TSDB_CODE_TDB_TABLE_NOT_EXIST;
33,680✔
4271
  return mndTransAppendRedoAction(pTrans, &action);
33,680✔
4272
}
4273

4274
static int32_t mndBuildDropTbRedoActions(SMnode *pMnode, STrans *pTrans, SHashObj *pVgMap, tmsg_t msgType) {
8,420✔
4275
  int32_t code = 0;
8,420✔
4276
  void   *pIter = taosHashIterate(pVgMap, NULL);
8,420✔
4277
  while (pIter) {
16,840✔
4278
    const SVDropTbVgReqs *pVgReqs = pIter;
8,420✔
4279
    int32_t               len = 0;
8,420✔
4280
    for (int32_t i = 0; i < taosArrayGetSize(pVgReqs->pBatchReqs) && code == TSDB_CODE_SUCCESS; ++i) {
42,100✔
4281
      SVDropTbBatchReq *pBatchReq = taosArrayGet(pVgReqs->pBatchReqs, i);
33,680✔
4282
      void             *p = mndBuildVDropTbsReq(pMnode, &pVgReqs->info, pBatchReq, &len);
33,680✔
4283
      if (!p) {
33,680✔
UNCOV
4284
        code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
4285
        if (terrno != 0) code = terrno;
×
UNCOV
4286
        break;
×
4287
      }
4288
      if ((code = mndSetDropTbsRedoActions(pMnode, pTrans, pVgReqs, p, len, msgType)) != 0) {
33,680✔
UNCOV
4289
        break;
×
4290
      }
4291
    }
4292
    if (TSDB_CODE_SUCCESS != code) {
8,420✔
UNCOV
4293
      taosHashCancelIterate(pVgMap, pIter);
×
UNCOV
4294
      break;
×
4295
    }
4296
    pIter = taosHashIterate(pVgMap, pIter);
8,420✔
4297
  }
4298
  return code;
8,420✔
4299
}
4300

4301
static int32_t mndCreateDropTbsTxnPrepare(SRpcMsg *pRsp, SMndDropTbsWithTsmaCtx *pCtx) {
11,640✔
4302
  int32_t code = 0;
11,640✔
4303
  SMnode *pMnode = pRsp->info.node;
11,640✔
4304
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_GLOBAL, pRsp, "drop-tbs");
11,640✔
4305
  mndTransSetChangeless(pTrans);
11,640✔
4306
  mndTransSetSerial(pTrans);
11,640✔
4307
  if (pTrans == NULL) {
11,640✔
UNCOV
4308
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
4309
    if (terrno != 0) code = terrno;
×
UNCOV
4310
    goto _OVER;
×
4311
  }
4312

4313
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
11,640✔
4314

4315
  if ((code = mndBuildDropTbRedoActions(pMnode, pTrans, pCtx->pVgMap, TDMT_VND_DROP_TABLE)) != 0) goto _OVER;
8,420✔
4316
  if ((code = mndTransPrepare(pMnode, pTrans)) != 0) goto _OVER;
8,420✔
4317

4318
_OVER:
8,420✔
4319
  mndTransDrop(pTrans);
11,640✔
4320
  TAOS_RETURN(code);
11,640✔
4321
}
4322

UNCOV
4323
static int32_t mndProcessDropTbWithTsma(SRpcMsg *pReq) {
×
UNCOV
4324
  int32_t      code = -1;
×
UNCOV
4325
  SMnode      *pMnode = pReq->info.node;
×
UNCOV
4326
  SDbObj      *pDb = NULL;
×
UNCOV
4327
  SStbObj     *pStb = NULL;
×
UNCOV
4328
  SMDropTbsReq dropReq = {0};
×
UNCOV
4329
  bool         locked = false;
×
UNCOV
4330
  if (tDeserializeSMDropTbsReq(pReq->pCont, pReq->contLen, &dropReq) != 0) {
×
UNCOV
4331
    code = TSDB_CODE_INVALID_MSG;
×
UNCOV
4332
    goto _OVER;
×
4333
  }
4334

UNCOV
4335
  SMndDropTbsWithTsmaCtx *pCtx = NULL;
×
UNCOV
4336
  code = mndInitDropTbsWithTsmaCtx(&pCtx);
×
UNCOV
4337
  if (code) goto _OVER;
×
UNCOV
4338
  for (int32_t i = 0; i < dropReq.pVgReqs->size; ++i) {
×
UNCOV
4339
    SMDropTbReqsOnSingleVg *pReq = taosArrayGet(dropReq.pVgReqs, i);
×
UNCOV
4340
    code = mndDropTbForSingleVg(pMnode, pCtx, pReq->pTbs, pReq->vgInfo.vgId);
×
UNCOV
4341
    if (code) goto _OVER;
×
4342
  }
UNCOV
4343
  code = mndCreateDropTbsTxnPrepare(pReq, pCtx);
×
UNCOV
4344
  if (code == 0) {
×
UNCOV
4345
    code = TSDB_CODE_ACTION_IN_PROGRESS;
×
4346
  }
UNCOV
4347
_OVER:
×
UNCOV
4348
  tFreeSMDropTbsReq(&dropReq);
×
UNCOV
4349
  if (pCtx) mndDestroyDropTbsWithTsmaCtx(pCtx);
×
UNCOV
4350
  TAOS_RETURN(code);
×
4351
}
4352

4353
static int32_t createDropTbBatchReq(const SVDropTbReq *pReq, SVDropTbBatchReq *pBatchReq) {
47,204✔
4354
  pBatchReq->nReqs = 1;
47,204✔
4355
  pBatchReq->pArray = taosArrayInit(TARRAY_MIN_SIZE, sizeof(SVDropTbReq));
47,204✔
4356
  if (!pBatchReq->pArray) return terrno;
47,204✔
4357
  if (taosArrayPush(pBatchReq->pArray, pReq) == NULL) {
94,408✔
UNCOV
4358
    taosArrayDestroy(pBatchReq->pArray);
×
UNCOV
4359
    pBatchReq->pArray = NULL;
×
UNCOV
4360
    return terrno;
×
4361
  }
4362
  return TSDB_CODE_SUCCESS;
47,204✔
4363
}
4364

4365
static void destroySVDropTbBatchReqs(void *p) {
47,204✔
4366
  SVDropTbBatchReq *pReq = p;
47,204✔
4367
  taosArrayDestroy(pReq->pArray);
47,204✔
4368
  pReq->pArray = NULL;
47,204✔
4369
}
47,204✔
4370

4371
static int32_t mndDropTbAdd(SMnode *pMnode, SHashObj *pVgHashMap, const SVgroupInfo *pVgInfo, char *name, tb_uid_t suid,
47,204✔
4372
                            bool ignoreNotExists) {
4373
  SVDropTbReq req = {.name = name, .suid = suid, .igNotExists = ignoreNotExists, .uid = 0};
47,204✔
4374

4375
  SVDropTbVgReqs *pVgReqs = taosHashGet(pVgHashMap, &pVgInfo->vgId, sizeof(pVgInfo->vgId));
47,204✔
4376
  SVDropTbVgReqs  vgReqs = {0};
47,204✔
4377
  if (pVgReqs == NULL) {
47,204✔
4378
    vgReqs.info = *pVgInfo;
11,640✔
4379
    vgReqs.pBatchReqs = taosArrayInit(TARRAY_MIN_SIZE, sizeof(SVDropTbBatchReq));
11,640✔
4380
    if (!vgReqs.pBatchReqs) return terrno;
11,640✔
4381
    SVDropTbBatchReq batchReq = {0};
11,640✔
4382
    int32_t          code = createDropTbBatchReq(&req, &batchReq);
11,640✔
4383
    if (TSDB_CODE_SUCCESS != code) return code;
11,640✔
4384
    if (taosArrayPush(vgReqs.pBatchReqs, &batchReq) == NULL) {
23,280✔
UNCOV
4385
      taosArrayDestroy(batchReq.pArray);
×
UNCOV
4386
      return terrno;
×
4387
    }
4388
    if (taosHashPut(pVgHashMap, &pVgInfo->vgId, sizeof(pVgInfo->vgId), &vgReqs, sizeof(vgReqs)) != 0) {
11,640✔
UNCOV
4389
      taosArrayDestroyEx(vgReqs.pBatchReqs, destroySVDropTbBatchReqs);
×
UNCOV
4390
      return terrno;
×
4391
    }
4392
  } else {
4393
    SVDropTbBatchReq batchReq = {0};
35,564✔
4394
    int32_t          code = createDropTbBatchReq(&req, &batchReq);
35,564✔
4395
    if (TSDB_CODE_SUCCESS != code) return code;
35,564✔
4396
    if (taosArrayPush(pVgReqs->pBatchReqs, &batchReq) == NULL) {
71,128✔
UNCOV
4397
      taosArrayDestroy(batchReq.pArray);
×
UNCOV
4398
      return terrno;
×
4399
    }
4400
  }
4401
  return 0;
47,204✔
4402
}
4403

4404
static int32_t mndDropTbForSingleVg(SMnode *pMnode, SMndDropTbsWithTsmaCtx *pCtx, SArray *pTbs, int32_t vgId) {
11,640✔
4405
  int32_t code = 0;
11,640✔
4406

4407
  SVgObj *pVgObj = mndAcquireVgroup(pMnode, vgId);
11,640✔
4408
  if (!pVgObj) {
11,640✔
UNCOV
4409
    code = 0;
×
UNCOV
4410
    goto _end;
×
4411
  }
4412
  SVgroupInfo vgInfo = {.hashBegin = pVgObj->hashBegin,
23,280✔
4413
                        .hashEnd = pVgObj->hashEnd,
11,640✔
4414
                        .numOfTable = pVgObj->numOfTables,
11,640✔
4415
                        .vgId = pVgObj->vgId};
11,640✔
4416
  vgInfo.epSet = mndGetVgroupEpset(pMnode, pVgObj);
11,640✔
4417
  mndReleaseVgroup(pMnode, pVgObj);
11,640✔
4418

4419
  for (int32_t i = 0; i < pTbs->size; ++i) {
58,844✔
4420
    SVDropTbReq *pTb = taosArrayGet(pTbs, i);
47,204✔
4421
    TAOS_CHECK_GOTO(mndDropTbAdd(pMnode, pCtx->pVgMap, &vgInfo, pTb->name, pTb->suid, pTb->igNotExists), NULL, _end);
47,204✔
4422
  }
4423
_end:
11,640✔
4424
  return code;
11,640✔
4425
}
4426

4427
static int32_t mndProcessFetchTtlExpiredTbs(SRpcMsg *pRsp) {
11,077,420✔
4428
  int32_t                 code = -1;
11,077,420✔
4429
  SDecoder                decoder = {0};
11,077,420✔
4430
  SMnode                 *pMnode = pRsp->info.node;
11,077,420✔
4431
  SVFetchTtlExpiredTbsRsp rsp = {0};
11,077,420✔
4432
  SMndDropTbsWithTsmaCtx *pCtx = NULL;
11,077,420✔
4433
  if (pRsp->code != TSDB_CODE_SUCCESS) {
11,077,420✔
4434
    code = pRsp->code;
101,691✔
4435
    goto _end;
101,691✔
4436
  }
4437
  if (pRsp->contLen == 0) {
10,975,729✔
4438
    code = 0;
10,964,089✔
4439
    goto _end;
10,964,089✔
4440
  }
4441

4442
  tDecoderInit(&decoder, pRsp->pCont, pRsp->contLen);
11,640✔
4443
  code = tDecodeVFetchTtlExpiredTbsRsp(&decoder, &rsp);
11,640✔
4444
  if (code) goto _end;
11,640✔
4445

4446
  code = mndInitDropTbsWithTsmaCtx(&pCtx);
11,640✔
4447
  if (code) goto _end;
11,640✔
4448

4449
  code = mndDropTbForSingleVg(pMnode, pCtx, rsp.pExpiredTbs, rsp.vgId);
11,640✔
4450
  if (code) goto _end;
11,640✔
4451
  code = mndCreateDropTbsTxnPrepare(pRsp, pCtx);
11,640✔
4452
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
11,640✔
4453
_end:
11,076,964✔
4454
  if (pCtx) mndDestroyDropTbsWithTsmaCtx(pCtx);
11,077,420✔
4455
  tDecoderClear(&decoder);
11,077,420✔
4456
  tFreeFetchTtlExpiredTbsRsp(&rsp);
11,077,420✔
4457
  TAOS_RETURN(code);
11,077,420✔
4458
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc