• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

opendefensecloud / solution-arsenal / 23052990701

13 Mar 2026 01:27PM UTC coverage: 71.23% (-0.8%) from 72.012%
23052990701

Pull #273

github

web-flow
Merge 93b67a195 into b27e7dfd8
Pull Request #273: Target e2e test

5 of 7 new or added lines in 2 files covered. (71.43%)

78 existing lines in 8 files now uncovered.

2102 of 2951 relevant lines covered (71.23%)

19.05 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.91
/pkg/controller/hydratedtarget_controller.go
1
// Copyright 2026 BWI GmbH and Solution Arsenal contributors
2
// SPDX-License-Identifier: Apache-2.0
3

4
package controller
5

6
import (
7
        "context"
8
        "fmt"
9
        "net/url"
10
        "slices"
11
        "strings"
12
        "time"
13

14
        ociname "github.com/google/go-containerregistry/pkg/name"
15
        corev1 "k8s.io/api/core/v1"
16
        apierrors "k8s.io/apimachinery/pkg/api/errors"
17
        apimeta "k8s.io/apimachinery/pkg/api/meta"
18
        metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
19
        "k8s.io/apimachinery/pkg/runtime"
20
        "k8s.io/client-go/tools/events"
21
        ctrl "sigs.k8s.io/controller-runtime"
22
        "sigs.k8s.io/controller-runtime/pkg/client"
23
        "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
24

25
        solarv1alpha1 "go.opendefense.cloud/solar/api/solar/v1alpha1"
26
)
27

28
const (
29
        hydratedTargetFinalizer = "solar.opendefense.cloud/hydrated-target-finalizer"
30
)
31

32
// HydratedTargetReconciler reconciles a HydratedTarget object
33
type HydratedTargetReconciler struct {
34
        client.Client
35
        Scheme   *runtime.Scheme
36
        Recorder events.EventRecorder
37
}
38

39
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=hydratedtargets,verbs=get;list;watch;create;update;patch;delete
40
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=hydratedtargets/status,verbs=get;update;patch
41
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=hydratedtargets/finalizers,verbs=update
42
// FIXME: Switch out releases for profiles                      👇
43
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=releases,verbs=get;list;watch
44
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=rendertasks,verbs=get;list;watch;create;update;patch;delete
45
//+kubebuilder:rbac:groups=core,resources=events,verbs=create;patch
46
//+kubebuilder:rbac:groups=events.k8s.io,resources=events,verbs=create;patch
47

48
// Reconcile moves the current state of the cluster closer to the desired state
49
//
50
// Reconciliation Flow:
51
//
52
//        HydratedTarget created
53
//            ↓
54
//        Add finalizer
55
//            ↓
56
//        Check if already succeeded → YES → Return (no-op)
57
//            ↓ NO
58
//        Get or create RenderTask
59
//            ↓
60
//        Update status from RenderTask
61

62
func (r *HydratedTargetReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
112✔
63
        log := ctrl.LoggerFrom(ctx)
112✔
64
        ctrlResult := ctrl.Result{}
112✔
65

112✔
66
        log.V(1).Info("HydratedTarget is being reconciled", "req", req)
112✔
67

112✔
68
        // Fetch the HydratedTarget instance
112✔
69
        res := &solarv1alpha1.HydratedTarget{}
112✔
70
        if err := r.Get(ctx, req.NamespacedName, res); err != nil {
114✔
71
                if apierrors.IsNotFound(err) {
4✔
72
                        // Object not found, return. Created objects are automatically garbage collected.
2✔
73
                        return ctrlResult, nil
2✔
74
                }
2✔
75

76
                return ctrlResult, errLogAndWrap(log, err, "failed to get object")
×
77
        }
78

79
        // Handle deletion: cleanup rendertask, then remove finalizer
80
        if !res.DeletionTimestamp.IsZero() {
112✔
81
                log.V(1).Info("HydratedTarget is being deleted")
2✔
82
                r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "Deleting", "Delete", "HydratedTarget is being deleted, cleaning up resources")
2✔
83

2✔
84
                if err := r.deleteRenderTask(ctx, res); client.IgnoreNotFound(err) != nil {
2✔
85
                        return ctrlResult, errLogAndWrap(log, err, "failed to delete render task")
×
86
                }
×
87

88
                // Remove finalizer
89
                if slices.Contains(res.Finalizers, hydratedTargetFinalizer) {
4✔
90
                        log.V(1).Info("Removing finalizer from resource")
2✔
91
                        res.Finalizers = slices.DeleteFunc(res.Finalizers, func(f string) bool {
4✔
92
                                return f == hydratedTargetFinalizer
2✔
93
                        })
2✔
94
                        if err := r.Update(ctx, res); err != nil {
2✔
95
                                return ctrlResult, errLogAndWrap(log, err, "failed to remove finalizer")
×
96
                        }
×
97
                }
98

99
                return ctrlResult, nil
2✔
100
        }
101

102
        // Add finalizer if not present and not deleting
103
        if res.DeletionTimestamp.IsZero() {
216✔
104
                if !slices.Contains(res.Finalizers, hydratedTargetFinalizer) {
127✔
105
                        log.V(1).Info("Adding finalizer to resource")
19✔
106
                        res.Finalizers = append(res.Finalizers, hydratedTargetFinalizer)
19✔
107
                        if err := r.Update(ctx, res); err != nil {
19✔
108
                                return ctrlResult, errLogAndWrap(log, err, "failed to add finalizer")
×
109
                        }
×
110
                        // Return without requeue; the Update event will trigger reconciliation again
111
                        return ctrlResult, nil
19✔
112
                }
113
        }
114

115
        // Check if rendertask has already completed successfully
116
        sc := apimeta.FindStatusCondition(res.Status.Conditions, ConditionTypeTaskCompleted)
89✔
117
        if sc != nil && sc.ObservedGeneration >= res.Generation && sc.Status == metav1.ConditionTrue {
90✔
118
                log.V(1).Info("RenderTask has already completed successfully, no further action needed")
1✔
119
                return ctrlResult, nil
1✔
120
        }
1✔
121

122
        // Check if rendertask has already failed
123
        fc := apimeta.FindStatusCondition(res.Status.Conditions, ConditionTypeTaskFailed)
88✔
124
        if fc != nil && fc.ObservedGeneration >= res.Generation && fc.Status == metav1.ConditionTrue {
89✔
125
                log.V(1).Info("RenderTask has already failed, no further action needed")
1✔
126
                return ctrlResult, nil
1✔
127
        }
1✔
128

129
        // Reconcile RenderTask
130
        rt := &solarv1alpha1.RenderTask{}
87✔
131
        err := r.Get(ctx, client.ObjectKey{Name: generationName(res), Namespace: res.Namespace}, rt)
87✔
132
        if client.IgnoreNotFound(err) != nil {
87✔
133
                return ctrlResult, errLogAndWrap(log, err, "failed to get RenderTask")
×
134
        }
×
135

136
        if apierrors.IsNotFound(err) {
128✔
137
                if err := r.createRenderTask(ctx, res); err != nil {
60✔
138
                        log.V(1).Error(err, "Failed to create RenderTask")
19✔
139
                        r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "CreationFailed", "Create", fmt.Sprintf("failed to create RenderTask: %q", err))
19✔
140

19✔
141
                        if apierrors.IsNotFound(err) {
23✔
142
                                return ctrl.Result{RequeueAfter: 30 * time.Second}, nil
4✔
143
                        }
4✔
144

145
                        return ctrlResult, errLogAndWrap(log, err, "failed to create RenderTask")
15✔
146
                }
147
                log.V(1).Info("Created RenderTask", "res", res)
22✔
148
                r.Recorder.Eventf(res, rt, corev1.EventTypeNormal, "Created", "Create", "RenderTask was created")
22✔
149
        }
150

151
        if changed := r.updateStatusConditionsFromRenderTask(ctx, res, rt); changed {
70✔
152
                if err := r.Status().Update(ctx, res); err != nil {
2✔
153
                        return ctrlResult, errLogAndWrap(log, err, "failed to update status")
×
154
                }
×
155
        }
156

157
        // RenderTask still running, requeue
158
        return ctrl.Result{RequeueAfter: 5 * time.Second}, nil
68✔
159
}
160

161
func (r *HydratedTargetReconciler) updateStatusConditionsFromRenderTask(ctx context.Context, res *solarv1alpha1.HydratedTarget, rt *solarv1alpha1.RenderTask) (changed bool) {
68✔
162
        if rt == nil || res == nil {
68✔
163
                return false
×
164
        }
×
165

166
        log := ctrl.LoggerFrom(ctx)
68✔
167

68✔
168
        if apimeta.IsStatusConditionTrue(rt.Status.Conditions, ConditionTypeJobFailed) {
69✔
169
                changed = apimeta.SetStatusCondition(&res.Status.Conditions, metav1.Condition{
1✔
170
                        Type:               ConditionTypeTaskFailed,
1✔
171
                        Status:             metav1.ConditionTrue,
1✔
172
                        ObservedGeneration: res.Generation,
1✔
173
                        Reason:             "TaskFailed",
1✔
174
                        Message:            "RenderTask failed",
1✔
175
                })
1✔
176

1✔
177
                log.V(1).Info("RenderTask failed", "name", rt.Name)
1✔
178
                r.Recorder.Eventf(res, rt, corev1.EventTypeWarning, "TaskFailed", "RunTask", "RenderTask failed")
1✔
179

1✔
180
                return changed
1✔
181
        }
1✔
182

183
        if apimeta.IsStatusConditionTrue(rt.Status.Conditions, ConditionTypeJobSucceeded) {
68✔
184
                changed = apimeta.SetStatusCondition(&res.Status.Conditions, metav1.Condition{
1✔
185
                        Type:               ConditionTypeTaskCompleted,
1✔
186
                        Status:             metav1.ConditionTrue,
1✔
187
                        ObservedGeneration: res.Generation,
1✔
188
                        Reason:             "TaskCompleted",
1✔
189
                        Message:            "RenderTask completed",
1✔
190
                })
1✔
191

1✔
192
                log.V(1).Info("RenderTask completed", "name", rt.Name)
1✔
193
                r.Recorder.Eventf(res, rt, corev1.EventTypeWarning, "TaskCompleted", "RunTask", "RenderTask completed successfully")
1✔
194

1✔
195
                return changed
1✔
196
        }
1✔
197

198
        log.V(1).Info("RenderTask has no final condtions yet", "name", rt.Name)
66✔
199

66✔
200
        return false
66✔
201
}
202

203
func (r *HydratedTargetReconciler) createRenderTask(ctx context.Context, res *solarv1alpha1.HydratedTarget) error {
41✔
204
        log := ctrl.LoggerFrom(ctx)
41✔
205

41✔
206
        // Check if we need to cleanup an old task
41✔
207
        if res.Status.RenderTaskRef != nil && res.Status.RenderTaskRef.Name != "" {
60✔
208
                if err := r.deleteRenderTask(ctx, res); err != nil {
19✔
UNCOV
209
                        return errLogAndWrap(log, err, "failed to cleanup old task")
×
UNCOV
210
                }
×
211
        }
212

213
        spec, err := r.computeRenderTaskSpec(ctx, res)
41✔
214
        if err != nil {
45✔
215
                return err
4✔
216
        }
4✔
217
        rt := &solarv1alpha1.RenderTask{
37✔
218
                ObjectMeta: metav1.ObjectMeta{
37✔
219
                        Name:      generationName(res),
37✔
220
                        Namespace: res.Namespace,
37✔
221
                },
37✔
222
                Spec: spec,
37✔
223
        }
37✔
224

37✔
225
        if err := r.Create(ctx, rt); err != nil {
49✔
226
                r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "CreationFailed", "Create", "Failed to create RenderTask", err)
12✔
227
                return errLogAndWrap(log, err, "secret creation failed")
12✔
228
        }
12✔
229

230
        // Set owner references
231
        if err := controllerutil.SetControllerReference(res, rt, r.Scheme); err != nil {
25✔
232
                return errLogAndWrap(log, err, "failed to set controller reference")
×
233
        }
×
234

235
        // Set Reference in Status
236
        res.Status.RenderTaskRef = &corev1.ObjectReference{
25✔
237
                APIVersion: solarv1alpha1.SchemeGroupVersion.String(),
25✔
238
                Kind:       "RenderTask",
25✔
239
                Namespace:  rt.Namespace,
25✔
240
                Name:       rt.Name,
25✔
241
        }
25✔
242

25✔
243
        if err := r.Status().Update(ctx, res); err != nil {
28✔
244
                return errLogAndWrap(log, err, "failed to update status")
3✔
245
        }
3✔
246

247
        return nil
22✔
248
}
249

250
func (r *HydratedTargetReconciler) deleteRenderTask(ctx context.Context, res *solarv1alpha1.HydratedTarget) error {
21✔
251
        if res.Status.RenderTaskRef == nil {
22✔
252
                return nil
1✔
253
        }
1✔
254

255
        rt := &solarv1alpha1.RenderTask{}
20✔
256
        if err := r.Get(ctx, client.ObjectKey{Name: res.Status.RenderTaskRef.Name, Namespace: res.Status.RenderTaskRef.Namespace}, rt); client.IgnoreNotFound(err) != nil {
20✔
257
                return err
×
258
        } else if err == nil {
29✔
259
                return r.Delete(ctx, rt, client.PropagationPolicy(metav1.DeletePropagationBackground))
9✔
260
        }
9✔
261

262
        return nil
11✔
263
}
264

265
func (r *HydratedTargetReconciler) computeRenderTaskSpec(ctx context.Context, res *solarv1alpha1.HydratedTarget) (solarv1alpha1.RenderTaskSpec, error) {
41✔
266
        spec := solarv1alpha1.RenderTaskSpec{}
41✔
267

41✔
268
        resolvedReleases := map[string]solarv1alpha1.ResourceAccess{}
41✔
269
        for k, v := range res.Spec.Releases {
54✔
270
                rel := &solarv1alpha1.Release{}
13✔
271
                if err := r.Get(ctx, client.ObjectKey{Name: v.Name, Namespace: res.Namespace}, rel); err != nil {
17✔
272
                        return spec, err
4✔
273
                }
4✔
274

275
                if rel.Status.ChartURL == "" {
9✔
NEW
276
                        return spec, fmt.Errorf("Release reference was empty, check if the release chart was rendered correctly.")
×
NEW
277
                }
×
278

279
                ref, err := ociname.ParseReference(rel.Status.ChartURL)
9✔
280
                if err != nil {
9✔
281
                        return spec, err
×
282
                }
×
283

284
                repo, err := url.JoinPath(ref.Context().RegistryStr(), ref.Context().RepositoryStr())
9✔
285
                if err != nil {
9✔
286
                        return spec, err
×
287
                }
×
288

289
                resolvedReleases[k] = solarv1alpha1.ResourceAccess{
9✔
290
                        Repository: strings.TrimPrefix(repo, "oci://"),
9✔
291
                        Tag:        ref.Identifier(),
9✔
292
                }
9✔
293
        }
294

295
        resolvedReleaseNames := []string{}
37✔
296
        for k := range resolvedReleases {
46✔
297
                resolvedReleaseNames = append(resolvedReleaseNames, k)
9✔
298
        }
9✔
299

300
        chartName := fmt.Sprintf("ht-%s", res.Name)
37✔
301
        repo, err := url.JoinPath(res.Namespace, chartName)
37✔
302
        if err != nil {
37✔
303
                return spec, err
×
304
        }
×
305

306
        tag := fmt.Sprintf("v0.0.%d", res.GetGeneration())
37✔
307

37✔
308
        spec.RendererConfig = solarv1alpha1.RendererConfig{
37✔
309
                Type: solarv1alpha1.RendererConfigTypeHydratedTarget,
37✔
310
                HydratedTargetConfig: solarv1alpha1.HydratedTargetConfig{
37✔
311
                        Chart: solarv1alpha1.ChartConfig{
37✔
312
                                Name:        chartName,
37✔
313
                                Description: fmt.Sprintf("HydratedTarget of %v", resolvedReleaseNames),
37✔
314
                                Version:     tag,
37✔
315
                                AppVersion:  tag,
37✔
316
                        },
37✔
317
                        Input: solarv1alpha1.HydratedTargetInput{
37✔
318
                                Releases: resolvedReleases,
37✔
319
                                Userdata: res.Spec.Userdata,
37✔
320
                        },
37✔
321
                },
37✔
322
        }
37✔
323
        spec.Repository = repo
37✔
324
        spec.Tag = tag
37✔
325

37✔
326
        return spec, nil
37✔
327
}
328

329
// SetupWithManager sets up the controller with the Manager.
330
func (r *HydratedTargetReconciler) SetupWithManager(mgr ctrl.Manager) error {
1✔
331
        return ctrl.NewControllerManagedBy(mgr).
1✔
332
                For(&solarv1alpha1.HydratedTarget{}).
1✔
333
                Owns(&solarv1alpha1.RenderTask{}).
1✔
334
                Complete(r)
1✔
335
}
1✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc