22873444665

Committed 08 Mar 2026 06:10PM UTC coverage: 79.306% (-0.009%) from 79.315%

Build # 22873444665

Build Type

push

github

Committed by

victorjulien

Commit Message

dpdk: adjust burst size to mempool size

When mempool size was configured really low (<32), Suricata exhausted
the mempool with the rx_burst call, which led to undefined behavior.
The current fix ensures the burst size is at most the size of the mempool,
if the mempool is smaller than BURST_SIZE macro.

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

678 existing lines in 28 files now uncovered.

265817 of 335177 relevant lines covered (79.31%)

4878829.65 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

91.71

/src/detect-http-raw-header.c

/* Copyright (C) 2007-2022 Open Information Security Foundation
 *
 * You can copy, redistribute or modify this Program under the terms of
 * the GNU General Public License version 2 as published by the Free
 * Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * version 2 along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
 * 02110-1301, USA.
 */

/**
 * \ingroup httplayer
 *
 * @{
 */


/**
 * \file
 *
 * \author Pablo Rincon <pablo.rincon.crespo@gmail.com>
 *
 * Implements support for http_raw_header keyword.
 */

#include "suricata-common.h"
#include "threads.h"
#include "decode.h"

#include "detect.h"
#include "detect-parse.h"
#include "detect-engine.h"
#include "detect-engine-buffer.h"
#include "detect-engine-mpm.h"
#include "detect-engine-prefilter.h"
#include "detect-content.h"

#include "flow.h"
#include "flow-var.h"
#include "flow-util.h"

#include "util-debug.h"
#include "util-profiling.h"

#include "app-layer.h"
#include "app-layer-parser.h"
#include "app-layer-htp.h"
#include "detect-http-raw-header.h"

static int DetectHttpRawHeaderSetup(DetectEngineCtx *, Signature *, const char *);
static int DetectHttpRawHeaderSetupSticky(DetectEngineCtx *de_ctx, Signature *s, const char *str);
#ifdef UNITTESTS
static void DetectHttpRawHeaderRegisterTests(void);
#endif
static bool DetectHttpRawHeaderValidateCallback(
        const Signature *s, const char **sigerror, const DetectBufferType *dbt);
static int g_http_raw_header_buffer_id = 0;
static InspectionBuffer *GetData(DetectEngineThreadCtx *det_ctx,
        const DetectEngineTransforms *transforms, Flow *_f,
        const uint8_t flow_flags, void *txv, const int list_id);
static InspectionBuffer *GetData2(DetectEngineThreadCtx *det_ctx,
        const DetectEngineTransforms *transforms, Flow *_f, const uint8_t flow_flags, void *txv,
        const int list_id);

static int PrefilterMpmHttpHeaderRawRequestRegister(DetectEngineCtx *de_ctx, SigGroupHead *sgh,
        MpmCtx *mpm_ctx, const DetectBufferMpmRegistry *mpm_reg, int list_id);
static int PrefilterMpmHttpHeaderRawResponseRegister(DetectEngineCtx *de_ctx, SigGroupHead *sgh,
        MpmCtx *mpm_ctx, const DetectBufferMpmRegistry *mpm_reg, int list_id);

/**
 * \brief Registers the keyword handlers for the "http_raw_header" keyword.
 */
void DetectHttpRawHeaderRegister(void)
{
    /* http_raw_header content modifier */
    sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].name = "http_raw_header";
    sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].desc =
            "content modifier to match the raw HTTP header buffer";
    sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].url =
            "/rules/http-keywords.html#http-header-and-http-raw-header";
    sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].Setup = DetectHttpRawHeaderSetup;
#ifdef UNITTESTS
    sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].RegisterTests = DetectHttpRawHeaderRegisterTests;
#endif
    sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].flags |=
            SIGMATCH_NOOPT | SIGMATCH_INFO_CONTENT_MODIFIER;
    sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].alternative = DETECT_HTTP_RAW_HEADER;

    /* http.header.raw sticky buffer */
    sigmatch_table[DETECT_HTTP_RAW_HEADER].name = "http.header.raw";
    sigmatch_table[DETECT_HTTP_RAW_HEADER].desc = "sticky buffer to match the raw HTTP header buffer";
    sigmatch_table[DETECT_HTTP_RAW_HEADER].url = "/rules/http-keywords.html#http-header-and-http-raw-header";
    sigmatch_table[DETECT_HTTP_RAW_HEADER].Setup = DetectHttpRawHeaderSetupSticky;
    sigmatch_table[DETECT_HTTP_RAW_HEADER].flags |= SIGMATCH_NOOPT|SIGMATCH_INFO_STICKY_BUFFER;

    DetectAppLayerInspectEngineRegister("http_raw_header", ALPROTO_HTTP1, SIG_FLAG_TOSERVER,
            HTP_REQUEST_PROGRESS_HEADERS + 1, DetectEngineInspectBufferGeneric, GetData);
    DetectAppLayerInspectEngineRegister("http_raw_header", ALPROTO_HTTP1, SIG_FLAG_TOCLIENT,
            HTP_RESPONSE_PROGRESS_HEADERS + 1, DetectEngineInspectBufferGeneric, GetData);

    DetectAppLayerMpmRegister("http_raw_header", SIG_FLAG_TOSERVER, 2,
            PrefilterMpmHttpHeaderRawRequestRegister, NULL, ALPROTO_HTTP1,
            0); /* progress handled in register */
    DetectAppLayerMpmRegister("http_raw_header", SIG_FLAG_TOCLIENT, 2,
            PrefilterMpmHttpHeaderRawResponseRegister, NULL, ALPROTO_HTTP1,
            0); /* progress handled in register */

    DetectAppLayerInspectEngineRegister("http_raw_header", ALPROTO_HTTP2, SIG_FLAG_TOSERVER,
            HTTP2StateDataClient, DetectEngineInspectBufferGeneric, GetData2);
    DetectAppLayerInspectEngineRegister("http_raw_header", ALPROTO_HTTP2, SIG_FLAG_TOCLIENT,
            HTTP2StateDataServer, DetectEngineInspectBufferGeneric, GetData2);

    DetectAppLayerMpmRegister("http_raw_header", SIG_FLAG_TOSERVER, 2, PrefilterGenericMpmRegister,
            GetData2, ALPROTO_HTTP2, HTTP2StateDataClient);
    DetectAppLayerMpmRegister("http_raw_header", SIG_FLAG_TOCLIENT, 2, PrefilterGenericMpmRegister,
            GetData2, ALPROTO_HTTP2, HTTP2StateDataServer);

    DetectBufferTypeSetDescriptionByName("http_raw_header",
            "raw http headers");

    DetectBufferTypeRegisterValidateCallback("http_raw_header",
            DetectHttpRawHeaderValidateCallback);

    g_http_raw_header_buffer_id = DetectBufferTypeGetByName("http_raw_header");
}

/**
 * \brief The setup function for the http_raw_header keyword for a signature.
 *
 * \param de_ctx Pointer to the detection engine context.
 * \param s      Pointer to signature for the current Signature being parsed
 *               from the rules.
 * \param m      Pointer to the head of the SigMatchs for the current rule
 *               being parsed.
 * \param arg    Pointer to the string holding the keyword value.
 *
 * \retval  0 On success.
 * \retval -1 On failure.
 */
int DetectHttpRawHeaderSetup(DetectEngineCtx *de_ctx, Signature *s, const char *arg)
{
    return DetectEngineContentModifierBufferSetup(
            de_ctx, s, arg, DETECT_HTTP_RAW_HEADER_CM, g_http_raw_header_buffer_id, ALPROTO_HTTP1);
}

/**
 * \brief this function setup the http.header.raw keyword used in the rule
 *
 * \param de_ctx   Pointer to the Detection Engine Context
 * \param s        Pointer to the Signature to which the current keyword belongs
 * \param str      Should hold an empty string always
 *
 * \retval 0       On success
 */
static int DetectHttpRawHeaderSetupSticky(DetectEngineCtx *de_ctx, Signature *s, const char *str)
{
    if (SCDetectBufferSetActiveList(de_ctx, s, g_http_raw_header_buffer_id) < 0)
        return -1;
    if (SCDetectSignatureSetAppProto(s, ALPROTO_HTTP) < 0)
        return -1;
    return 0;
}

static bool DetectHttpRawHeaderValidateCallback(
        const Signature *s, const char **sigerror, const DetectBufferType *dbt)
{
    if ((s->flags & (SIG_FLAG_TOCLIENT|SIG_FLAG_TOSERVER)) == (SIG_FLAG_TOCLIENT|SIG_FLAG_TOSERVER)) {
        *sigerror = "http_raw_header signature "
                "without a flow direction. Use flow:to_server for "
                "inspecting request headers or flow:to_client for "
                "inspecting response headers.";

        SCLogError("%s", *sigerror);
        SCReturnInt(false);
    }
    return true;
}

static InspectionBuffer *GetData(DetectEngineThreadCtx *det_ctx,
        const DetectEngineTransforms *transforms, Flow *_f,
        const uint8_t flow_flags, void *txv, const int list_id)
{
    InspectionBuffer *buffer = InspectionBufferGet(det_ctx, list_id);
    if (buffer->inspect == NULL) {
        htp_tx_t *tx = (htp_tx_t *)txv;

        HtpTxUserData *tx_ud = htp_tx_get_user_data(tx);

        const bool ts = ((flow_flags & STREAM_TOSERVER) != 0);
        const uint8_t *data = ts ?
            tx_ud->request_headers_raw : tx_ud->response_headers_raw;
        if (data == NULL)
            return NULL;
        const uint32_t data_len = ts ?
            tx_ud->request_headers_raw_len : tx_ud->response_headers_raw_len;

        InspectionBufferSetupAndApplyTransforms(
                det_ctx, list_id, buffer, data, data_len, transforms);
    }

    return buffer;
}

static InspectionBuffer *GetData2(DetectEngineThreadCtx *det_ctx,
        const DetectEngineTransforms *transforms, Flow *_f, const uint8_t flow_flags, void *txv,
        const int list_id)
{
    InspectionBuffer *buffer = InspectionBufferGet(det_ctx, list_id);
    if (buffer->inspect == NULL) {
        uint32_t b_len = 0;
        const uint8_t *b = NULL;

        if (SCHttp2TxGetHeadersRaw(txv, flow_flags, &b, &b_len) != 1)
            return NULL;
        if (b == NULL || b_len == 0)
            return NULL;

        InspectionBufferSetupAndApplyTransforms(det_ctx, list_id, buffer, b, b_len, transforms);
    }

    return buffer;
}

typedef struct PrefilterMpmHttpHeaderRawCtx {
    int list_id;
    const MpmCtx *mpm_ctx;
    const DetectEngineTransforms *transforms;
} PrefilterMpmHttpHeaderRawCtx;

/** \brief Generic Mpm prefilter callback
 *
 *  \param det_ctx detection engine thread ctx
 *  \param p packet to inspect
 *  \param f flow to inspect
 *  \param txv tx to inspect
 *  \param pectx inspection context
 */
static void PrefilterMpmHttpHeaderRaw(DetectEngineThreadCtx *det_ctx, const void *pectx, Packet *p,
        Flow *f, void *txv, const uint64_t idx, const AppLayerTxData *_txd, const uint8_t flags)
{
    SCEnter();

    const PrefilterMpmHttpHeaderRawCtx *ctx = pectx;
    const MpmCtx *mpm_ctx = ctx->mpm_ctx;
    SCLogDebug("running on list %d", ctx->list_id);

    const int list_id = ctx->list_id;

    InspectionBuffer *buffer = GetData(det_ctx, ctx->transforms, f,
            flags, txv, list_id);
    if (buffer == NULL)
        return;

    const uint32_t data_len = buffer->inspect_len;
    const uint8_t *data = buffer->inspect;

    SCLogDebug("mpm'ing buffer:");
    //PrintRawDataFp(stdout, data, data_len);

    if (data != NULL && data_len >= mpm_ctx->minlen) {
        (void)mpm_table[mpm_ctx->mpm_type].Search(
                mpm_ctx, &det_ctx->mtc, &det_ctx->pmq, data, data_len);
        PREFILTER_PROFILING_ADD_BYTES(det_ctx, data_len);
    }
}

static void PrefilterMpmHttpTrailerRaw(DetectEngineThreadCtx *det_ctx, const void *pectx, Packet *p,
        Flow *f, void *txv, const uint64_t idx, const AppLayerTxData *_txd, const uint8_t flags)
{
    SCEnter();

    htp_tx_t *tx = txv;
    const HtpTxUserData *htud = (const HtpTxUserData *)htp_tx_get_user_data(tx);
    /* if the request wasn't flagged as having a trailer, we skip */
    if (((flags & STREAM_TOSERVER) && !htud->request_has_trailers) ||
            ((flags & STREAM_TOCLIENT) && !htud->response_has_trailers)) {
        SCReturn;
    }
    PrefilterMpmHttpHeaderRaw(det_ctx, pectx, p, f, txv, idx, _txd, flags);
    SCReturn;
}

static void PrefilterMpmHttpHeaderRawFree(void *ptr)
{
    SCFree(ptr);
}

static int PrefilterMpmHttpHeaderRawRequestRegister(DetectEngineCtx *de_ctx, SigGroupHead *sgh,
        MpmCtx *mpm_ctx, const DetectBufferMpmRegistry *mpm_reg, int list_id)
{
    SCEnter();

    /* header */
    PrefilterMpmHttpHeaderRawCtx *pectx = SCCalloc(1, sizeof(*pectx));
    if (pectx == NULL)
        return -1;
    pectx->list_id = list_id;
    pectx->mpm_ctx = mpm_ctx;
    pectx->transforms = &mpm_reg->transforms;

    int r = PrefilterAppendTxEngine(de_ctx, sgh, PrefilterMpmHttpHeaderRaw, mpm_reg->app_v2.alproto,
            HTP_REQUEST_PROGRESS_HEADERS + 1, pectx, PrefilterMpmHttpHeaderRawFree, mpm_reg->pname);
    if (r != 0) {
        SCFree(pectx);
        return r;
    }

    /* trailer */
    pectx = SCCalloc(1, sizeof(*pectx));
    if (pectx == NULL)
        return -1;
    pectx->list_id = list_id;
    pectx->mpm_ctx = mpm_ctx;
    pectx->transforms = &mpm_reg->transforms;

    r = PrefilterAppendTxEngine(de_ctx, sgh, PrefilterMpmHttpTrailerRaw, mpm_reg->app_v2.alproto,
            HTP_REQUEST_PROGRESS_TRAILER + 1, pectx, PrefilterMpmHttpHeaderRawFree, mpm_reg->pname);
    if (r != 0) {
        SCFree(pectx);
    }
    return r;
}

static int PrefilterMpmHttpHeaderRawResponseRegister(DetectEngineCtx *de_ctx, SigGroupHead *sgh,
        MpmCtx *mpm_ctx, const DetectBufferMpmRegistry *mpm_reg, int list_id)
{
    SCEnter();

    /* header */
    PrefilterMpmHttpHeaderRawCtx *pectx = SCCalloc(1, sizeof(*pectx));
    if (pectx == NULL)
        return -1;
    pectx->list_id = list_id;
    pectx->mpm_ctx = mpm_ctx;
    pectx->transforms = &mpm_reg->transforms;

    int r = PrefilterAppendTxEngine(de_ctx, sgh, PrefilterMpmHttpHeaderRaw, mpm_reg->app_v2.alproto,
            HTP_RESPONSE_PROGRESS_HEADERS, pectx, PrefilterMpmHttpHeaderRawFree, mpm_reg->pname);
    if (r != 0) {
        SCFree(pectx);
        return r;
    }

    /* trailer */
    pectx = SCCalloc(1, sizeof(*pectx));
    if (pectx == NULL)
        return -1;
    pectx->list_id = list_id;
    pectx->mpm_ctx = mpm_ctx;
    pectx->transforms = &mpm_reg->transforms;

    r = PrefilterAppendTxEngine(de_ctx, sgh, PrefilterMpmHttpTrailerRaw, mpm_reg->app_v2.alproto,
            HTP_RESPONSE_PROGRESS_TRAILER, pectx, PrefilterMpmHttpHeaderRawFree, mpm_reg->pname);
    if (r != 0) {
        SCFree(pectx);
    }
    return r;
}

/************************************Unittests*********************************/

#ifdef UNITTESTS
#include "tests/detect-http-raw-header.c"
#endif

/**
 * @}
 */

1	/* Copyright (C) 2007-2022 Open Information Security Foundation
2	*
3	* You can copy, redistribute or modify this Program under the terms of
4	* the GNU General Public License version 2 as published by the Free
5	* Software Foundation.
6	*
7	* This program is distributed in the hope that it will be useful,
8	* but WITHOUT ANY WARRANTY; without even the implied warranty of
9	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10	* GNU General Public License for more details.
11	*
12	* You should have received a copy of the GNU General Public License
13	* version 2 along with this program; if not, write to the Free Software
14	* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
15	* 02110-1301, USA.
16	*/
17
18	/**
19	* \ingroup httplayer
20	*
21	* @{
22	*/
23
24
25	/**
26	* \file
27	*
28	* \author Pablo Rincon <pablo.rincon.crespo@gmail.com>
29	*
30	* Implements support for http_raw_header keyword.
31	*/
32
33	#include "suricata-common.h"
34	#include "threads.h"
35	#include "decode.h"
36
37	#include "detect.h"
38	#include "detect-parse.h"
39	#include "detect-engine.h"
40	#include "detect-engine-buffer.h"
41	#include "detect-engine-mpm.h"
42	#include "detect-engine-prefilter.h"
43	#include "detect-content.h"
44
45	#include "flow.h"
46	#include "flow-var.h"
47	#include "flow-util.h"
48
49	#include "util-debug.h"
50	#include "util-profiling.h"
51
52	#include "app-layer.h"
53	#include "app-layer-parser.h"
54	#include "app-layer-htp.h"
55	#include "detect-http-raw-header.h"
56
57	static int DetectHttpRawHeaderSetup(DetectEngineCtx , Signature , const char *);
58	static int DetectHttpRawHeaderSetupSticky(DetectEngineCtx de_ctx, Signature s, const char *str);
59	#ifdef UNITTESTS
60	static void DetectHttpRawHeaderRegisterTests(void);
61	#endif
62	static bool DetectHttpRawHeaderValidateCallback(
63	const Signature s, const char sigerror, const DetectBufferType dbt);
64	static int g_http_raw_header_buffer_id = 0;
65	static InspectionBuffer GetData(DetectEngineThreadCtx det_ctx,
66	const DetectEngineTransforms transforms, Flow _f,
67	const uint8_t flow_flags, void *txv, const int list_id);
68	static InspectionBuffer GetData2(DetectEngineThreadCtx det_ctx,
69	const DetectEngineTransforms transforms, Flow _f, const uint8_t flow_flags, void *txv,
70	const int list_id);
71
72	static int PrefilterMpmHttpHeaderRawRequestRegister(DetectEngineCtx de_ctx, SigGroupHead sgh,
73	MpmCtx mpm_ctx, const DetectBufferMpmRegistry mpm_reg, int list_id);
74	static int PrefilterMpmHttpHeaderRawResponseRegister(DetectEngineCtx de_ctx, SigGroupHead sgh,
75	MpmCtx mpm_ctx, const DetectBufferMpmRegistry mpm_reg, int list_id);
76
77	/**
78	* \brief Registers the keyword handlers for the "http_raw_header" keyword.
79	*/
80	void DetectHttpRawHeaderRegister(void)
81	{	2,223✔
82	/* http_raw_header content modifier */
83	sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].name = "http_raw_header";	2,223✔
84	sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].desc =	2,223✔
85	"content modifier to match the raw HTTP header buffer";	2,223✔
86	sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].url =	2,223✔
87	"/rules/http-keywords.html#http-header-and-http-raw-header";	2,223✔
88	sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].Setup = DetectHttpRawHeaderSetup;	2,223✔
89	#ifdef UNITTESTS	3✔
90	sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].RegisterTests = DetectHttpRawHeaderRegisterTests;	3✔
91	#endif	3✔
92	sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].flags \|=	2,223✔
93	SIGMATCH_NOOPT \| SIGMATCH_INFO_CONTENT_MODIFIER;	2,223✔
94	sigmatch_table[DETECT_HTTP_RAW_HEADER_CM].alternative = DETECT_HTTP_RAW_HEADER;	2,223✔
95
96	/* http.header.raw sticky buffer */
97	sigmatch_table[DETECT_HTTP_RAW_HEADER].name = "http.header.raw";	2,223✔
98	sigmatch_table[DETECT_HTTP_RAW_HEADER].desc = "sticky buffer to match the raw HTTP header buffer";	2,223✔
99	sigmatch_table[DETECT_HTTP_RAW_HEADER].url = "/rules/http-keywords.html#http-header-and-http-raw-header";	2,223✔
100	sigmatch_table[DETECT_HTTP_RAW_HEADER].Setup = DetectHttpRawHeaderSetupSticky;	2,223✔
101	sigmatch_table[DETECT_HTTP_RAW_HEADER].flags \|= SIGMATCH_NOOPT\|SIGMATCH_INFO_STICKY_BUFFER;	2,223✔
102
103	DetectAppLayerInspectEngineRegister("http_raw_header", ALPROTO_HTTP1, SIG_FLAG_TOSERVER,	2,223✔
104	HTP_REQUEST_PROGRESS_HEADERS + 1, DetectEngineInspectBufferGeneric, GetData);	2,223✔
105	DetectAppLayerInspectEngineRegister("http_raw_header", ALPROTO_HTTP1, SIG_FLAG_TOCLIENT,	2,223✔
106	HTP_RESPONSE_PROGRESS_HEADERS + 1, DetectEngineInspectBufferGeneric, GetData);	2,223✔
107
108	DetectAppLayerMpmRegister("http_raw_header", SIG_FLAG_TOSERVER, 2,	2,223✔
109	PrefilterMpmHttpHeaderRawRequestRegister, NULL, ALPROTO_HTTP1,	2,223✔
110	0); /* progress handled in register */	2,223✔
111	DetectAppLayerMpmRegister("http_raw_header", SIG_FLAG_TOCLIENT, 2,	2,223✔
112	PrefilterMpmHttpHeaderRawResponseRegister, NULL, ALPROTO_HTTP1,	2,223✔
113	0); /* progress handled in register */	2,223✔
114
115	DetectAppLayerInspectEngineRegister("http_raw_header", ALPROTO_HTTP2, SIG_FLAG_TOSERVER,	2,223✔
116	HTTP2StateDataClient, DetectEngineInspectBufferGeneric, GetData2);	2,223✔
117	DetectAppLayerInspectEngineRegister("http_raw_header", ALPROTO_HTTP2, SIG_FLAG_TOCLIENT,	2,223✔
118	HTTP2StateDataServer, DetectEngineInspectBufferGeneric, GetData2);	2,223✔
119
120	DetectAppLayerMpmRegister("http_raw_header", SIG_FLAG_TOSERVER, 2, PrefilterGenericMpmRegister,	2,223✔
121	GetData2, ALPROTO_HTTP2, HTTP2StateDataClient);	2,223✔
122	DetectAppLayerMpmRegister("http_raw_header", SIG_FLAG_TOCLIENT, 2, PrefilterGenericMpmRegister,	2,223✔
123	GetData2, ALPROTO_HTTP2, HTTP2StateDataServer);	2,223✔
124
125	DetectBufferTypeSetDescriptionByName("http_raw_header",	2,223✔
126	"raw http headers");	2,223✔
127
128	DetectBufferTypeRegisterValidateCallback("http_raw_header",	2,223✔
129	DetectHttpRawHeaderValidateCallback);	2,223✔
130
131	g_http_raw_header_buffer_id = DetectBufferTypeGetByName("http_raw_header");	2,223✔
132	}	2,223✔
133
134	/**
135	* \brief The setup function for the http_raw_header keyword for a signature.
136	*
137	* \param de_ctx Pointer to the detection engine context.
138	* \param s Pointer to signature for the current Signature being parsed
139	* from the rules.
140	* \param m Pointer to the head of the SigMatchs for the current rule
141	* being parsed.
142	* \param arg Pointer to the string holding the keyword value.
143	*
144	* \retval 0 On success.
145	* \retval -1 On failure.
146	*/
147	int DetectHttpRawHeaderSetup(DetectEngineCtx de_ctx, Signature s, const char *arg)
148	{	346✔
149	return DetectEngineContentModifierBufferSetup(	346✔
150	de_ctx, s, arg, DETECT_HTTP_RAW_HEADER_CM, g_http_raw_header_buffer_id, ALPROTO_HTTP1);	346✔
151	}	346✔
152
153	/**
154	* \brief this function setup the http.header.raw keyword used in the rule
155	*
156	* \param de_ctx Pointer to the Detection Engine Context
157	* \param s Pointer to the Signature to which the current keyword belongs
158	* \param str Should hold an empty string always
159	*
160	* \retval 0 On success
161	*/
162	static int DetectHttpRawHeaderSetupSticky(DetectEngineCtx de_ctx, Signature s, const char *str)
163	{	2,767✔
164	if (SCDetectBufferSetActiveList(de_ctx, s, g_http_raw_header_buffer_id) < 0)	2,767✔
165	return -1;	28✔
166	if (SCDetectSignatureSetAppProto(s, ALPROTO_HTTP) < 0)	2,739✔
167	return -1;	15✔
168	return 0;	2,724✔
169	}	2,739✔
170
171	static bool DetectHttpRawHeaderValidateCallback(
172	const Signature s, const char sigerror, const DetectBufferType dbt)
173	{	3,273✔
174	if ((s->flags & (SIG_FLAG_TOCLIENT\|SIG_FLAG_TOSERVER)) == (SIG_FLAG_TOCLIENT\|SIG_FLAG_TOSERVER)) {	3,273✔
175	*sigerror = "http_raw_header signature "	611✔
176	"without a flow direction. Use flow:to_server for "	611✔
177	"inspecting request headers or flow:to_client for "	611✔
178	"inspecting response headers.";	611✔
179
180	SCLogError("%s", *sigerror);	611✔
181	SCReturnInt(false);	611✔
182	}	611✔
183	return true;	2,662✔
184	}	3,273✔
185
186	static InspectionBuffer GetData(DetectEngineThreadCtx det_ctx,
187	const DetectEngineTransforms transforms, Flow _f,
188	const uint8_t flow_flags, void *txv, const int list_id)
189	{	5,246✔
190	InspectionBuffer *buffer = InspectionBufferGet(det_ctx, list_id);	5,246✔
191	if (buffer->inspect == NULL) {	5,246✔
192	htp_tx_t tx = (htp_tx_t )txv;	4,812✔
193
194	HtpTxUserData *tx_ud = htp_tx_get_user_data(tx);	4,812✔
195
196	const bool ts = ((flow_flags & STREAM_TOSERVER) != 0);	4,812✔
197	const uint8_t *data = ts ?	4,812✔
198	tx_ud->request_headers_raw : tx_ud->response_headers_raw;	2,543✔
199	if (data == NULL)	4,812✔
200	return NULL;	133✔
201	const uint32_t data_len = ts ?	4,679✔
202	tx_ud->request_headers_raw_len : tx_ud->response_headers_raw_len;	2,489✔
203
204	InspectionBufferSetupAndApplyTransforms(	4,679✔
205	det_ctx, list_id, buffer, data, data_len, transforms);	4,679✔
206	}	4,679✔
207
208	return buffer;	5,113✔
209	}	5,246✔
210
211	static InspectionBuffer GetData2(DetectEngineThreadCtx det_ctx,
212	const DetectEngineTransforms transforms, Flow _f, const uint8_t flow_flags, void *txv,
213	const int list_id)
214	{	497✔
215	InspectionBuffer *buffer = InspectionBufferGet(det_ctx, list_id);	497✔
216	if (buffer->inspect == NULL) {	497✔
217	uint32_t b_len = 0;	492✔
218	const uint8_t *b = NULL;	492✔
219
220	if (SCHttp2TxGetHeadersRaw(txv, flow_flags, &b, &b_len) != 1)	492✔
221	return NULL;	286✔
222	if (b == NULL \|\| b_len == 0)	206✔
UNCOV 223	return NULL;	×
224
225	InspectionBufferSetupAndApplyTransforms(det_ctx, list_id, buffer, b, b_len, transforms);	206✔
226	}	206✔
227
228	return buffer;	211✔
229	}	497✔
230
231	typedef struct PrefilterMpmHttpHeaderRawCtx {
232	int list_id;
233	const MpmCtx *mpm_ctx;
234	const DetectEngineTransforms *transforms;
235	} PrefilterMpmHttpHeaderRawCtx;
236
237	/** \brief Generic Mpm prefilter callback
238	*
239	* \param det_ctx detection engine thread ctx
240	* \param p packet to inspect
241	* \param f flow to inspect
242	* \param txv tx to inspect
243	* \param pectx inspection context
244	*/
245	static void PrefilterMpmHttpHeaderRaw(DetectEngineThreadCtx det_ctx, const void pectx, Packet *p,
246	Flow f, void txv, const uint64_t idx, const AppLayerTxData *_txd, const uint8_t flags)
247	{	5,049✔
248	SCEnter();	5,049✔
249
250	const PrefilterMpmHttpHeaderRawCtx *ctx = pectx;	5,049✔
251	const MpmCtx *mpm_ctx = ctx->mpm_ctx;	5,049✔
252	SCLogDebug("running on list %d", ctx->list_id);	5,049✔
253
254	const int list_id = ctx->list_id;	5,049✔
255
256	InspectionBuffer *buffer = GetData(det_ctx, ctx->transforms, f,	5,049✔
257	flags, txv, list_id);	5,049✔
258	if (buffer == NULL)	5,049✔
259	return;	133✔
260
261	const uint32_t data_len = buffer->inspect_len;	4,916✔
262	const uint8_t *data = buffer->inspect;	4,916✔
263
264	SCLogDebug("mpm'ing buffer:");	4,916✔
265	//PrintRawDataFp(stdout, data, data_len);
266
267	if (data != NULL && data_len >= mpm_ctx->minlen) {	4,916✔
268	(void)mpm_table[mpm_ctx->mpm_type].Search(	4,753✔
269	mpm_ctx, &det_ctx->mtc, &det_ctx->pmq, data, data_len);	4,753✔
270	PREFILTER_PROFILING_ADD_BYTES(det_ctx, data_len);	4,753✔
271	}	4,753✔
272	}	4,916✔
273
274	static void PrefilterMpmHttpTrailerRaw(DetectEngineThreadCtx det_ctx, const void pectx, Packet *p,
275	Flow f, void txv, const uint64_t idx, const AppLayerTxData *_txd, const uint8_t flags)
276	{	4,630✔
277	SCEnter();	4,630✔
278
279	htp_tx_t *tx = txv;	4,630✔
280	const HtpTxUserData htud = (const HtpTxUserData )htp_tx_get_user_data(tx);	4,630✔
281	/* if the request wasn't flagged as having a trailer, we skip */
282	if (((flags & STREAM_TOSERVER) && !htud->request_has_trailers) \|\|	4,630✔
283	((flags & STREAM_TOCLIENT) && !htud->response_has_trailers)) {	4,630✔
284	SCReturn;	4,301✔
285	}	4,301✔
286	PrefilterMpmHttpHeaderRaw(det_ctx, pectx, p, f, txv, idx, _txd, flags);	329✔
287	SCReturn;	329✔
288	}	4,630✔
289
290	static void PrefilterMpmHttpHeaderRawFree(void *ptr)
291	{	1,482✔
292	SCFree(ptr);	1,482✔
293	}	1,482✔
294
295	static int PrefilterMpmHttpHeaderRawRequestRegister(DetectEngineCtx de_ctx, SigGroupHead sgh,
296	MpmCtx mpm_ctx, const DetectBufferMpmRegistry mpm_reg, int list_id)
297	{	459✔
298	SCEnter();	459✔
299
300	/* header */
301	PrefilterMpmHttpHeaderRawCtx pectx = SCCalloc(1, sizeof(pectx));	459✔
302	if (pectx == NULL)	459✔
UNCOV 303	return -1;	×
304	pectx->list_id = list_id;	459✔
305	pectx->mpm_ctx = mpm_ctx;	459✔
306	pectx->transforms = &mpm_reg->transforms;	459✔
307
308	int r = PrefilterAppendTxEngine(de_ctx, sgh, PrefilterMpmHttpHeaderRaw, mpm_reg->app_v2.alproto,	459✔
309	HTP_REQUEST_PROGRESS_HEADERS + 1, pectx, PrefilterMpmHttpHeaderRawFree, mpm_reg->pname);	459✔
310	if (r != 0) {	459✔
UNCOV 311	SCFree(pectx);	×
UNCOV 312	return r;	×
UNCOV 313	}	×
314
315	/* trailer */
316	pectx = SCCalloc(1, sizeof(*pectx));	459✔
317	if (pectx == NULL)	459✔
318	return -1;	×
319	pectx->list_id = list_id;	459✔
320	pectx->mpm_ctx = mpm_ctx;	459✔
321	pectx->transforms = &mpm_reg->transforms;	459✔
322
323	r = PrefilterAppendTxEngine(de_ctx, sgh, PrefilterMpmHttpTrailerRaw, mpm_reg->app_v2.alproto,	459✔
324	HTP_REQUEST_PROGRESS_TRAILER + 1, pectx, PrefilterMpmHttpHeaderRawFree, mpm_reg->pname);	459✔
325	if (r != 0) {	459✔
UNCOV 326	SCFree(pectx);	×
UNCOV 327	}	×
328	return r;	459✔
329	}	459✔
330
331	static int PrefilterMpmHttpHeaderRawResponseRegister(DetectEngineCtx de_ctx, SigGroupHead sgh,
332	MpmCtx mpm_ctx, const DetectBufferMpmRegistry mpm_reg, int list_id)
333	{	45✔
334	SCEnter();	45✔
335
336	/* header */
337	PrefilterMpmHttpHeaderRawCtx pectx = SCCalloc(1, sizeof(pectx));	45✔
338	if (pectx == NULL)	45✔
UNCOV 339	return -1;	×
340	pectx->list_id = list_id;	45✔
341	pectx->mpm_ctx = mpm_ctx;	45✔
342	pectx->transforms = &mpm_reg->transforms;	45✔
343
344	int r = PrefilterAppendTxEngine(de_ctx, sgh, PrefilterMpmHttpHeaderRaw, mpm_reg->app_v2.alproto,	45✔
345	HTP_RESPONSE_PROGRESS_HEADERS, pectx, PrefilterMpmHttpHeaderRawFree, mpm_reg->pname);	45✔
346	if (r != 0) {	45✔
UNCOV 347	SCFree(pectx);	×
UNCOV 348	return r;	×
UNCOV 349	}	×
350
351	/* trailer */
352	pectx = SCCalloc(1, sizeof(*pectx));	45✔
353	if (pectx == NULL)	45✔
354	return -1;	×
355	pectx->list_id = list_id;	45✔
356	pectx->mpm_ctx = mpm_ctx;	45✔
357	pectx->transforms = &mpm_reg->transforms;	45✔
358
359	r = PrefilterAppendTxEngine(de_ctx, sgh, PrefilterMpmHttpTrailerRaw, mpm_reg->app_v2.alproto,	45✔
360	HTP_RESPONSE_PROGRESS_TRAILER, pectx, PrefilterMpmHttpHeaderRawFree, mpm_reg->pname);	45✔
361	if (r != 0) {	45✔
UNCOV 362	SCFree(pectx);	×
UNCOV 363	}	×
364	return r;	45✔
365	}	45✔
366
367	/**********************************Unittests*******************************/
368
369	#ifdef UNITTESTS
370	#include "tests/detect-http-raw-header.c"
371	#endif
372
373	/**
374	* @}
375	*/

jasonish / suricata / 22873444665

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous