Azure / karpenter-provider-azure / 22814775938

Pull #1455

github

refactor: extract shared field-clearing functions, add realistic batch tests

Address PR review comments:

1. Extract clearPerMachineFields() and clearReadOnlyFields() as shared
   functions used by both computeTemplateHash and Coordinator.ExecuteBatch.
   Adding a new per-machine field requires updating one function, and both
   the hash and body-clearing automatically pick it up.

2. Remove creationtimestamp tag from TestComputeTemplateHash_TagsExcluded
   (tag being deprecated in a separate PR).

3. Add production-like pressure tests:
   - realisticMachineProps() builds fully-populated MachineProperties
     matching buildAKSMachineTemplate output
   - TestComputeTemplateHash_RealisticMachinesBatchTogether: 10 machines
     with same config but different names/zones/tags produce same hash
   - TestComputeTemplateHash_RealisticMachinesDifferentConfigsSplit:
     table-driven test verifying 8 config dimensions produce distinct hashes
   - TestGrouperBatchesRealisticMixedWorkload: 10 machines across 3 configs
     (D4s regular, D8s regular, D4s spot) land in correct batches

4. Add TestClearFieldFunctions_MatchExcludeList: verifies the clear
   functions zero exactly the expected fields and leave template fields
   untouched.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

326 of 474 new or added lines in 9 files covered. (68.78%)

59121 of 62860 relevant lines covered (94.05%)

0.96 hits per line