mybatis / redis-cache / 719

Committed 04 Mar 2026 03:25AM UTC coverage: 82.915% (-0.2%) from 83.163%

Build # 719

Build Type

Pull #353

github

Committed by

Copilot

Commit Message

Fix KryoSerializer ThreadLocal ClassLoader leak (Issue #351)

Add reset() default method to Serializer interface and implement it
in KryoSerializer to call kryos.remove(), preventing ClassLoader
pinning / Metaspace leaks in web-container environments.

Co-authored-by: hazendaz <975267+hazendaz@users.noreply.github.com>

Pull Request Pull Request #353: Fix KryoSerializer ThreadLocal ClassLoader leak in web containers

Run Details

51 of 80 branches covered (63.75%)

2 of 3 new or added lines in 2 files covered. (66.67%)

165 of 199 relevant lines covered (82.91%)

0.83 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/main/java/org/mybatis/caches/redis/Serializer.java

/*
 *    Copyright 2015-2026 the original author or authors.
 *
 *    Licensed under the Apache License, Version 2.0 (the "License");
 *    you may not use this file except in compliance with the License.
 *    You may obtain a copy of the License at
 *
 *       https://www.apache.org/licenses/LICENSE-2.0
 *
 *    Unless required by applicable law or agreed to in writing, software
 *    distributed under the License is distributed on an "AS IS" BASIS,
 *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 *    See the License for the specific language governing permissions and
 *    limitations under the License.
 */
package org.mybatis.caches.redis;

public interface Serializer {

  /**
   * Serialize method
   *
   * @param object
   *
   * @return serialized bytes
   */
  byte[] serialize(Object object);

  /**
   * Unserialize method
   *
   * @param bytes
   *
   * @return unserialized object
   */
  Object unserialize(byte[] bytes);

  /**
   * Releases any thread-local resources held by this serializer for the current thread. Implementations that use
   * {@link ThreadLocal} storage (e.g. {@link KryoSerializer}) should override this method to call
   * {@link ThreadLocal#remove()} and prevent ClassLoader pinning / Metaspace leaks in web-container environments
   * (Tomcat, etc.) where container threads are reused across redeployments. Callers (e.g. a
   * {@code ServletContextListener}) should invoke this method for each thread that has used the serializer before the
   * application is stopped.
   */
  default void reset() {
    // no-op by default
  }

}

1	/*
2	* Copyright 2015-2026 the original author or authors.
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* https://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16	package org.mybatis.caches.redis;
17
18	public interface Serializer {
19
20	/**
21	* Serialize method
22	*
23	* @param object
24	*
25	* @return serialized bytes
26	*/
27	byte[] serialize(Object object);
28
29	/**
30	* Unserialize method
31	*
32	* @param bytes
33	*
34	* @return unserialized object
35	*/
36	Object unserialize(byte[] bytes);
37
38	/**
39	* Releases any thread-local resources held by this serializer for the current thread. Implementations that use
40	* {@link ThreadLocal} storage (e.g. {@link KryoSerializer}) should override this method to call
41	* {@link ThreadLocal#remove()} and prevent ClassLoader pinning / Metaspace leaks in web-container environments
42	* (Tomcat, etc.) where container threads are reused across redeployments. Callers (e.g. a
43	* {@code ServletContextListener}) should invoke this method for each thread that has used the serializer before the
44	* application is stopped.
45	*/
46	default void reset() {
47	// no-op by default
NEW 48	}	×
49
50	}

mybatis / redis-cache / 719

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous