CyclopsMC / EvilCraft / 22777597426

Pull #1168

github

Fix crash when breaking entangled chalice full of blood

- Fix RenderItemStackBlockEntityEntangledChalice: avoid blockEntityRenderDispatcher.submit with new CameraRenderState() which caused JOML Matrix4fStack overflow in deeply nested GUI picture-in-picture rendering. Now renders fluid directly via WorldSharedTankCache + submitCustomGeometry. Also adds null/empty check for @Nullable itemStack parameter.
- Fix LootFunctionCopyEntangledChaliceData: add null check for fluidHandler to prevent NPE if fluid capability is not available.
- Add game test testEntangledChaliceBreakFull verifying that breaking a full chalice drops an item with the correct tank ID and fluid content.

Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>

990 of 5322 branches covered (18.6%)

Branch coverage included in aggregate %.

6191 of 15323 relevant lines covered (40.4%)

1.93 hits per line