b3c0442afc293243f26ad6215964c7414d11d6ad

Committed 24 Feb 2026 02:56PM UTC coverage: 53.194% (-0.5%) from 53.688%

Build # b3c0442afc293243f26ad6215964c7414d11d6ad

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #23025 from Yoast/ob-flush-check

Add if condition to only ob_flush when its needed otherwise rely on the flush to work.

Coverage Stats

8482 of 15955 branches covered (53.16%)

Branch coverage included in aggregate %.

0 of 2 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

33225 of 62450 relevant lines covered (53.2%)

47907.05 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/schema-aggregator/infrastructure/schema_map/schema-map-header-adapter.php

<?php
// phpcs:disable Yoast.NamingConventions.NamespaceName.TooLong -- Needed in the folder structure.
namespace Yoast\WP\SEO\Schema_Aggregator\Infrastructure\Schema_Map;

use WP_REST_Response;

/**
 * Adapter to set proper response headers for Schema Map responses.
 */
class Schema_Map_Header_Adapter {

        /**
         * Set proper headers for Schema Map responses.
         *
         * @param WP_REST_Response $response The REST response object.
         *
         * @return void
         */
        public function set_header_for_request( WP_REST_Response $response ) {
                $data = $response->get_data();

                foreach ( $response->get_headers() as $key => $value ) {
                        \header( \sprintf( '%s: %s', $key, $value ) );
                }

                $headers      = $response->get_headers();
                $content_type = ( $headers['Content-Type'] ?? 'application/json; charset=UTF-8' );

                if ( \strpos( $content_type, 'application/xml' ) !== false ) {
                        \header( 'Content-Type: application/xml; charset=UTF-8' );
                        echo $data; //@phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- $data should already be escaped here since this just adds headers to the request.
                }
                else {
                        \header( 'X-Accel-Buffering: no' );
                        \header( 'Content-Type: application/json; charset=UTF-8' );
                        foreach ( $data as $schema_piece ) {
                                // @phpcs:disable Yoast.Yoast.JsonEncodeAlternative.FoundWithAdditionalParams -- The pretty print option breaks the JSONL format.
                                echo \wp_json_encode( $schema_piece, ( \JSON_UNESCAPED_SLASHES | \JSON_UNESCAPED_UNICODE ) ) . \PHP_EOL; // @phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- $data should already be escaped here since this just adds headers to the request.
                                if ( \ob_get_level() > 0 ) {
                                        \ob_flush();
                                }
                                \flush();
                                // @phpcs:enable
                        }
                }
        }
}

1	<?php
2	// phpcs:disable Yoast.NamingConventions.NamespaceName.TooLong -- Needed in the folder structure.
3	namespace Yoast\WP\SEO\Schema_Aggregator\Infrastructure\Schema_Map;
4
5	use WP_REST_Response;
6
7	/**
8	* Adapter to set proper response headers for Schema Map responses.
9	*/
10	class Schema_Map_Header_Adapter {
11
12	/**
13	* Set proper headers for Schema Map responses.
14	*
15	* @param WP_REST_Response $response The REST response object.
16	*
17	* @return void
18	*/
19	public function set_header_for_request( WP_REST_Response $response ) {	×
20	$data = $response->get_data();	×
21
22	foreach ( $response->get_headers() as $key => $value ) {	×
23	\header( \sprintf( '%s: %s', $key, $value ) );	×
24	}
25
26	$headers = $response->get_headers();	×
27	$content_type = ( $headers['Content-Type'] ?? 'application/json; charset=UTF-8' );	×
28
29	if ( \strpos( $content_type, 'application/xml' ) !== false ) {	×
30	\header( 'Content-Type: application/xml; charset=UTF-8' );	×
31	echo $data; //@phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- $data should already be escaped here since this just adds headers to the request.	×
32	}
33	else {
34	\header( 'X-Accel-Buffering: no' );	×
35	\header( 'Content-Type: application/json; charset=UTF-8' );	×
36	foreach ( $data as $schema_piece ) {	×
37	// @phpcs:disable Yoast.Yoast.JsonEncodeAlternative.FoundWithAdditionalParams -- The pretty print option breaks the JSONL format.
38	echo \wp_json_encode( $schema_piece, ( \JSON_UNESCAPED_SLASHES \| \JSON_UNESCAPED_UNICODE ) ) . \PHP_EOL; // @phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- $data should already be escaped here since this just adds headers to the request.	×
NEW 39	if ( \ob_get_level() > 0 ) {	×
NEW 40	\ob_flush();	×
41	}
UNCOV 42	\flush();	×
43	// @phpcs:enable
44	}
45	}
46	}
47	}

Yoast / wordpress-seo / b3c0442afc293243f26ad6215964c7414d11d6ad

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous