stacklok / toolhive / 22137563574

push

github

Report discovered auth config errors via conditions (#3822)

* Report discovered auth config errors via conditions

Enhance VirtualMCPServer controller to continue in degraded mode when
discovered authentication configurations fail to convert, while
exposing failures via Kubernetes status conditions for better
observability.

Previously, when authentication configuration discovery failed (e.g.,
missing MCPExternalAuthConfig), errors were silently skipped with only
log messages. Users had no visibility into these failures via kubectl
or the Kubernetes API.

Closes: #2838

Report discovered auth config errors via conditions

Enhance VirtualMCPServer controller to continue in degraded mode when
discovered authentication configurations fail to convert, while
exposing failures via Kubernetes status conditions for better
observability.

Previously, when authentication configuration discovery failed (e.g.,
missing MCPExternalAuthConfig), errors were silently skipped with only
log messages. Users had no visibility into these failures via kubectl
or the Kubernetes API.

Changes:
- Add AuthConfigError type to capture conversion failure context
- Modify discoverExternalAuthConfigs() to return error list instead of
  silently skipping
- Add SetAuthConfigCondition() to StatusManager for granular conditions
- Add setDiscoveredAuthConfigConditions() helper to set individual
  conditions per discovered auth error
- Update ensureVmcpConfigConfigMap() to accept statusManager and set
  conditions for auth failures
- Update all tests to pass statusManager parameter

The controller now sets DiscoveredAuthConfig-<backend-name> conditions
with status False when discovered auth configs fail, allowing users to
see issues in VirtualMCPServer status while the system continues
operating with available backends.

This addresses part of issue #2838. Future PRs will handle default and
backend-specific auth config errors.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

*... (continued)

226 of 257 new or added lines in 4 files covered. (87.94%)

45068 of 72265 relevant lines covered (62.36%)

75.4 hits per line