• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

opendefensecloud / solution-arsenal / 22091412646

17 Feb 2026 08:36AM UTC coverage: 70.186% (+9.1%) from 61.119%
22091412646

push

github

jastBytes
Adopt events API to new controllers

17 of 21 new or added lines in 3 files covered. (80.95%)

49 existing lines in 4 files now uncovered.

1509 of 2150 relevant lines covered (70.19%)

15.44 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.71
/pkg/controller/hydratedtarget_controller.go
1
// Copyright 2026 BWI GmbH and Solution Arsenal contributors
2
// SPDX-License-Identifier: Apache-2.0
3

4
package controller
5

6
import (
7
        "context"
8
        "fmt"
9
        "net/url"
10
        "slices"
11
        "strings"
12
        "time"
13

14
        ociname "github.com/google/go-containerregistry/pkg/name"
15
        corev1 "k8s.io/api/core/v1"
16
        apierrors "k8s.io/apimachinery/pkg/api/errors"
17
        apimeta "k8s.io/apimachinery/pkg/api/meta"
18
        metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
19
        "k8s.io/apimachinery/pkg/runtime"
20
        "k8s.io/client-go/tools/events"
21
        ctrl "sigs.k8s.io/controller-runtime"
22
        "sigs.k8s.io/controller-runtime/pkg/client"
23
        "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
24

25
        solarv1alpha1 "go.opendefense.cloud/solar/api/solar/v1alpha1"
26
)
27

28
const (
29
        hydratedTargetFinalizer = "solar.opendefense.cloud/hydrated-target-finalizer"
30
)
31

32
// HydratedTargetReconciler reconciles a HydratedTarget object
33
type HydratedTargetReconciler struct {
34
        client.Client
35
        Scheme      *runtime.Scheme
36
        Recorder    events.EventRecorder
37
        PushOptions solarv1alpha1.PushOptions
38
}
39

40
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=hydratedtargets,verbs=get;list;watch;create;update;patch;delete
41
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=hydratedtargets/status,verbs=get;update;patch
42
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=hydratedtargets/finalizers,verbs=update
43
// FIXME: Switch out releases for profiles                      👇
44
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=releases,verbs=get;list;watch
45
//+kubebuilder:rbac:groups=solar.opendefense.cloud,resources=rendertasks,verbs=get;list;watch;create;update;patch;delete
46
//+kubebuilder:rbac:groups=core,resources=events,verbs=create;patch
47

48
// Reconcile moves the current state of the cluster closer to the desired state
49
//
50
// Reconciliation Flow:
51
//
52
//        HydratedTarget created
53
//            ↓
54
//        Add finalizer
55
//            ↓
56
//        Check if already succeeded → YES → Return (no-op)
57
//            ↓ NO
58
//        Get or create RenderTask
59
//            ↓
60
//        Update status from RenderTask
61

62
func (r *HydratedTargetReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
95✔
63
        log := ctrl.LoggerFrom(ctx)
95✔
64
        ctrlResult := ctrl.Result{}
95✔
65

95✔
66
        log.V(1).Info("HydratedTarget is being reconciled", "req", req)
95✔
67

95✔
68
        // Fetch the HydratedTarget instance
95✔
69
        res := &solarv1alpha1.HydratedTarget{}
95✔
70
        if err := r.Get(ctx, req.NamespacedName, res); err != nil {
97✔
71
                if apierrors.IsNotFound(err) {
4✔
72
                        // Object not found, return. Created objects are automatically garbage collected.
2✔
73
                        return ctrlResult, nil
2✔
74
                }
2✔
75

76
                return ctrlResult, errLogAndWrap(log, err, "failed to get object")
×
77
        }
78

79
        // Handle deletion: cleanup rendertask, then remove finalizer
80
        if !res.DeletionTimestamp.IsZero() {
95✔
81
                log.V(1).Info("HydratedTarget is being deleted")
2✔
82
                r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "Deleting", "Delete", "HydratedTarget is being deleted, cleaning up resources")
2✔
83

2✔
84
                if err := r.deleteRenderTask(ctx, res); client.IgnoreNotFound(err) != nil {
2✔
85
                        return ctrlResult, errLogAndWrap(log, err, "failed to delete render task")
×
86
                }
×
87

88
                // Remove finalizer
89
                if slices.Contains(res.Finalizers, hydratedTargetFinalizer) {
4✔
90
                        log.V(1).Info("Removing finalizer from resource")
2✔
91
                        res.Finalizers = slices.DeleteFunc(res.Finalizers, func(f string) bool {
4✔
92
                                return f == hydratedTargetFinalizer
2✔
93
                        })
2✔
94
                        if err := r.Update(ctx, res); err != nil {
2✔
95
                                return ctrlResult, errLogAndWrap(log, err, "failed to remove finalizer")
×
96
                        }
×
97
                }
98

99
                return ctrlResult, nil
2✔
100
        }
101

102
        // Add finalizer if not present and not deleting
103
        if res.DeletionTimestamp.IsZero() {
182✔
104
                if !slices.Contains(res.Finalizers, hydratedTargetFinalizer) {
101✔
105
                        log.V(1).Info("Adding finalizer to resource")
10✔
106
                        res.Finalizers = append(res.Finalizers, hydratedTargetFinalizer)
10✔
107
                        if err := r.Update(ctx, res); err != nil {
10✔
108
                                return ctrlResult, errLogAndWrap(log, err, "failed to add finalizer")
×
109
                        }
×
110
                        // Return without requeue; the Update event will trigger reconciliation again
111
                        return ctrlResult, nil
10✔
112
                }
113
        }
114

115
        // Check if rendertask has already completed successfully
116
        sc := apimeta.FindStatusCondition(res.Status.Conditions, ConditionTypeTaskCompleted)
81✔
117
        if sc != nil && sc.ObservedGeneration >= res.Generation && sc.Status == metav1.ConditionTrue {
82✔
118
                log.V(1).Info("RenderTask has already completed successfully, no further action needed")
1✔
119
                return ctrlResult, nil
1✔
120
        }
1✔
121

122
        // Check if rendertask has already failed
123
        fc := apimeta.FindStatusCondition(res.Status.Conditions, ConditionTypeTaskFailed)
80✔
124
        if fc != nil && fc.ObservedGeneration >= res.Generation && fc.Status == metav1.ConditionTrue {
81✔
125
                log.V(1).Info("RenderTask has already failed, no further action needed")
1✔
126
                return ctrlResult, nil
1✔
127
        }
1✔
128

129
        // Reconcile RenderTask
130
        rt := &solarv1alpha1.RenderTask{}
79✔
131
        err := r.Get(ctx, client.ObjectKey{Name: generationName(res), Namespace: res.Namespace}, rt)
79✔
132
        if client.IgnoreNotFound(err) != nil {
79✔
133
                log.V(1).Info("Failed to get render task", "res", res)
×
134
                return ctrlResult, errLogAndWrap(log, err, "failed to get RenderTask")
×
135
        }
×
136

137
        if apierrors.IsNotFound(err) {
123✔
138
                if err := r.createRenderTask(ctx, res); err != nil {
80✔
139
                        log.V(1).Info("Failed to create RenderTask", "res", res)
36✔
140
                        r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "CreationFailed", "Create", "failed to create RenderTask")
36✔
141

36✔
142
                        return ctrl.Result{RequeueAfter: 30 * time.Second}, errLogAndWrap(log, err, "failed to create RenderTask")
36✔
143
                }
36✔
144
                log.V(1).Info("Created RenderTask", "res", res)
8✔
145
                r.Recorder.Eventf(res, rt, corev1.EventTypeNormal, "Created", "Create", "RenderTask was created")
8✔
146
        }
147

148
        if changed := r.updateStatusConditionsFromRenderTask(ctx, res, rt); changed {
45✔
149
                if err := r.Status().Update(ctx, res); err != nil {
2✔
150
                        return ctrlResult, errLogAndWrap(log, err, "failed to update status")
×
151
                }
×
152
        }
153

154
        // RenderTask still running, requeue
155
        return ctrl.Result{RequeueAfter: 5 * time.Second}, nil
43✔
156
}
157

158
func (r *HydratedTargetReconciler) updateStatusConditionsFromRenderTask(ctx context.Context, res *solarv1alpha1.HydratedTarget, rt *solarv1alpha1.RenderTask) (changed bool) {
43✔
159
        if rt == nil || res == nil {
43✔
160
                return false
×
161
        }
×
162

163
        log := ctrl.LoggerFrom(ctx)
43✔
164

43✔
165
        if apimeta.IsStatusConditionTrue(rt.Status.Conditions, ConditionTypeJobFailed) {
44✔
166
                changed = apimeta.SetStatusCondition(&res.Status.Conditions, metav1.Condition{
1✔
167
                        Type:               ConditionTypeTaskFailed,
1✔
168
                        Status:             metav1.ConditionTrue,
1✔
169
                        ObservedGeneration: res.Generation,
1✔
170
                        Reason:             "TaskFailed",
1✔
171
                        Message:            "RenderTask failed",
1✔
172
                })
1✔
173

1✔
174
                log.V(1).Info("RenderTask failed", "name", rt.Name)
1✔
175
                r.Recorder.Eventf(res, rt, corev1.EventTypeWarning, "TaskFailed", "RunTask", "RenderTask failed")
1✔
176

1✔
177
                return changed
1✔
178
        }
1✔
179

180
        if apimeta.IsStatusConditionTrue(rt.Status.Conditions, ConditionTypeJobSucceeded) {
43✔
181
                changed = apimeta.SetStatusCondition(&res.Status.Conditions, metav1.Condition{
1✔
182
                        Type:               ConditionTypeTaskCompleted,
1✔
183
                        Status:             metav1.ConditionTrue,
1✔
184
                        ObservedGeneration: res.Generation,
1✔
185
                        Reason:             "TaskCompleted",
1✔
186
                        Message:            "RenderTask completed",
1✔
187
                })
1✔
188

1✔
189
                log.V(1).Info("RenderTask completed", "name", rt.Name)
1✔
190
                r.Recorder.Eventf(res, rt, corev1.EventTypeWarning, "TaskCompleted", "RunTask", "RenderTask completed successfully")
1✔
191

1✔
192
                return changed
1✔
193
        }
1✔
194

195
        log.V(1).Info("RenderTask has no final condtions yet", "name", rt.Name)
41✔
196

41✔
197
        return false
41✔
198
}
199

200
func (r *HydratedTargetReconciler) createRenderTask(ctx context.Context, res *solarv1alpha1.HydratedTarget) error {
44✔
201
        log := ctrl.LoggerFrom(ctx)
44✔
202

44✔
203
        // Check if we need to cleanup an old task
44✔
204
        if res.Status.RenderTaskRef != nil && res.Status.RenderTaskRef.Name != "" {
45✔
205
                if err := r.deleteRenderTask(ctx, res); err != nil {
1✔
206
                        return errLogAndWrap(log, err, "failed to cleanup old task")
×
207
                }
×
208
        }
209

210
        cfg, err := r.computeRendererConfig(ctx, res)
44✔
211
        if err != nil {
79✔
212
                return err
35✔
213
        }
35✔
214
        if cfg == nil {
9✔
215
                return fmt.Errorf("unexpected nil RendererConfig")
×
216
        }
×
217

218
        rt := &solarv1alpha1.RenderTask{
9✔
219
                ObjectMeta: metav1.ObjectMeta{
9✔
220
                        Name:      generationName(res),
9✔
221
                        Namespace: res.Namespace,
9✔
222
                },
9✔
223
                Spec: solarv1alpha1.RenderTaskSpec{
9✔
224
                        RendererConfig: *cfg,
9✔
225
                },
9✔
226
        }
9✔
227

9✔
228
        if err := r.Create(ctx, rt); err != nil {
9✔
NEW
229
                r.Recorder.Eventf(res, nil, corev1.EventTypeWarning, "CreationFailed", "Create", "Failed to create RenderTask", err)
×
230
                return errLogAndWrap(log, err, "secret creation failed")
×
231
        }
×
232

233
        // Set owner references
234
        if err := controllerutil.SetControllerReference(res, rt, r.Scheme); err != nil {
9✔
235
                return errLogAndWrap(log, err, "failed to set controller reference")
×
236
        }
×
237

238
        // Set Reference in Status
239
        res.Status.RenderTaskRef = &corev1.ObjectReference{
9✔
240
                APIVersion: solarv1alpha1.SchemeGroupVersion.String(),
9✔
241
                Kind:       "RenderTask",
9✔
242
                Namespace:  rt.Namespace,
9✔
243
                Name:       rt.Name,
9✔
244
        }
9✔
245

9✔
246
        if err := r.Status().Update(ctx, res); err != nil {
10✔
247
                return errLogAndWrap(log, err, "failed to update status")
1✔
248
        }
1✔
249

250
        return nil
8✔
251
}
252

253
func (r *HydratedTargetReconciler) deleteRenderTask(ctx context.Context, res *solarv1alpha1.HydratedTarget) error {
3✔
254
        if res.Status.RenderTaskRef == nil {
4✔
255
                return nil
1✔
256
        }
1✔
257

258
        rt := &solarv1alpha1.RenderTask{}
2✔
259
        if err := r.Get(ctx, client.ObjectKey{Name: res.Status.RenderTaskRef.Name, Namespace: res.Status.RenderTaskRef.Namespace}, rt); client.IgnoreNotFound(err) != nil {
2✔
260
                return err
×
261
        } else if err == nil {
4✔
262
                return r.Delete(ctx, rt, client.PropagationPolicy(metav1.DeletePropagationBackground))
2✔
263
        }
2✔
264

265
        return nil
×
266
}
267

268
func (r *HydratedTargetReconciler) computeRendererConfig(ctx context.Context, res *solarv1alpha1.HydratedTarget) (*solarv1alpha1.RendererConfig, error) {
44✔
269
        resolvedReleases := map[string]solarv1alpha1.ResourceAccess{}
44✔
270
        for k, v := range res.Spec.Releases {
88✔
271
                rel := &solarv1alpha1.Release{}
44✔
272
                if err := r.Get(ctx, client.ObjectKey{Name: v.Name, Namespace: res.Namespace}, rel); err != nil {
79✔
273
                        return nil, err
35✔
274
                }
35✔
275

276
                ref, err := ociname.ParseReference(rel.Status.ChartURL)
9✔
277
                if err != nil {
9✔
278
                        return nil, err
×
279
                }
×
280

281
                repo, err := url.JoinPath(ref.Context().RegistryStr(), ref.Context().RepositoryStr())
9✔
282
                if err != nil {
9✔
283
                        return nil, err
×
284
                }
×
285

286
                resolvedReleases[k] = solarv1alpha1.ResourceAccess{
9✔
287
                        Repository: strings.TrimPrefix(repo, "oci://"),
9✔
288
                        Tag:        ref.Identifier(),
9✔
289
                }
9✔
290
        }
291

292
        resolvedReleaseNames := []string{}
9✔
293
        for k := range resolvedReleases {
18✔
294
                resolvedReleaseNames = append(resolvedReleaseNames, k)
9✔
295
        }
9✔
296

297
        po := r.PushOptions
9✔
298
        url, err := url.JoinPath(po.ReferenceURL, res.Namespace, fmt.Sprintf("ht-%s", res.Name))
9✔
299
        if err != nil {
9✔
300
                return nil, err
×
301
        }
×
302

303
        if !strings.HasPrefix(url, "oci://") {
18✔
304
                url = fmt.Sprintf("oci://%s", url)
9✔
305
        }
9✔
306

307
        version := fmt.Sprintf("v0.0.%d", res.GetGeneration())
9✔
308
        url = fmt.Sprintf("%s:%s", url, version)
9✔
309

9✔
310
        po.ReferenceURL = url
9✔
311

9✔
312
        return &solarv1alpha1.RendererConfig{
9✔
313
                Type: solarv1alpha1.RendererConfigTypeHydratedTarget,
9✔
314
                HydratedTargetConfig: solarv1alpha1.HydratedTargetConfig{
9✔
315
                        Chart: solarv1alpha1.ChartConfig{
9✔
316
                                Name:        res.Name,
9✔
317
                                Description: fmt.Sprintf("HydratedTarget of %v", resolvedReleaseNames),
9✔
318
                                Version:     version,
9✔
319
                                AppVersion:  version,
9✔
320
                        },
9✔
321
                        Input: solarv1alpha1.HydratedTargetInput{
9✔
322
                                Releases: resolvedReleases,
9✔
323
                                Userdata: res.Spec.Userdata,
9✔
324
                        },
9✔
325
                },
9✔
326
                PushOptions: po,
9✔
327
        }, nil
9✔
328
}
329

330
// SetupWithManager sets up the controller with the Manager.
331
func (r *HydratedTargetReconciler) SetupWithManager(mgr ctrl.Manager) error {
1✔
332
        return ctrl.NewControllerManagedBy(mgr).
1✔
333
                For(&solarv1alpha1.HydratedTarget{}).
1✔
334
                Owns(&solarv1alpha1.RenderTask{}).
1✔
335
                Complete(r)
1✔
336
}
1✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc