stacklok / toolhive / 21886536212

push

github

Fix SSE gauge leak, config bool handling, and metric error logging (#3756)

- Fix SSE active connections gauge that was incremented but never
  decremented. Move increment into Handler with a defer decrement so
  the gauge correctly tracks SSE connection lifecycle.

- Fix config file `use-legacy-attributes: false` being silently ignored.
  Change UseLegacyAttributes from bool to *bool in app config so nil
  (not set) is distinguishable from explicit false. Add two test cases
  covering both scenarios.

- Log metric creation errors at debug level instead of silently
  discarding them. The OTEL SDK returns no-op instruments on error so
  there is no runtime risk, but logging aids troubleshooting.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

20 of 28 new or added lines in 2 files covered. (71.43%)

42762 of 69445 relevant lines covered (61.58%)

77.17 hits per line