stacklok / toolhive / 21871986343

push

github

Gate legacy span attributes behind UseLegacyAttributes flag (#3747)

Wrap all existing span attribute emissions in conditional blocks
controlled by the UseLegacyAttributes config flag. Since the flag
defaults to true, this is a behavioral no-op — all the same attributes
are still emitted. This structural change prepares for the follow-up
PR that adds new OTEL semantic convention attribute names alongside
the legacy names.

Attributes gated (emitted only when UseLegacyAttributes=true):
- HTTP: http.method, http.url, http.scheme, http.host, http.target,
  http.user_agent, http.request_content_length, http.query,
  http.status_code, http.response_content_length, http.duration_ms
- MCP: mcp.method, rpc.system, rpc.service, mcp.request.id,
  mcp.resource.id, mcp.transport
- Method-specific: mcp.tool.name, mcp.tool.arguments,
  mcp.resource.uri, mcp.prompt.name, mcp.client.name

Attributes kept unconditional (not renamed in follow-up):
- mcp.server.name, mcp.is_batch, sse.event_type
- Span status (Ok/Error)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

44 of 48 new or added lines in 1 file covered. (91.67%)

42443 of 69110 relevant lines covered (61.41%)

78.54 hits per line