21782759586

Committed 07 Feb 2026 12:31PM UTC coverage: 90.073% (-0.001%) from 90.074%

Build # 21782759586

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #5289 from randombit/jack/header-patrol-2

Further misc header reductions, forward declarations, etc

Run Details

102244 of 113513 relevant lines covered (90.07%)

11458499.72 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.19

/src/tests/unit_tls_policy.cpp

/*
* TLS Policy tests
*
* (C) 2016 Juraj Somorovsky
*
* Botan is released under the Simplified BSD License (see license.txt)
*/

#include "tests.h"

#if defined(BOTAN_HAS_TLS)
   #include <botan/tls_exceptn.h>
   #include <botan/tls_policy.h>
#endif

#if defined(BOTAN_HAS_RSA)
   #include <botan/rsa.h>
#endif

#if defined(BOTAN_HAS_ECC_GROUP)
   #include <botan/ec_group.h>
#endif

#if defined(BOTAN_HAS_ECDH)
   #include <botan/ecdh.h>
#endif

#if defined(BOTAN_HAS_ECDSA)
   #include <botan/ecdsa.h>
#endif

#if defined(BOTAN_HAS_DIFFIE_HELLMAN)
   #include <botan/dh.h>
   #include <botan/dl_group.h>
#endif

namespace Botan_Tests {

namespace {

#if defined(BOTAN_HAS_TLS)
class TLS_Policy_Unit_Tests final : public Test {
   public:
      std::vector<Test::Result> run() override {
         std::vector<Test::Result> results;

         results.push_back(test_peer_key_acceptable_rsa(this->rng()));
         results.push_back(test_peer_key_acceptable_ecdh(this->rng()));
         results.push_back(test_peer_key_acceptable_ecdsa(this->rng()));
         results.push_back(test_peer_key_acceptable_dh());
         results.push_back(test_key_exchange_groups_to_offer());

         return results;
      }

   private:
      static Test::Result test_peer_key_acceptable_rsa(Botan::RandomNumberGenerator& rng) {
         Test::Result result("TLS Policy RSA key verification");
   #if defined(BOTAN_HAS_RSA)
         auto rsa_key_1024 = std::make_unique<Botan::RSA_PrivateKey>(rng, 1024);
         const Botan::TLS::Policy policy;

         try {
            policy.check_peer_key_acceptable(*rsa_key_1024);
            result.test_failure("Incorrectly accepting 1024 bit RSA keys");
         } catch(Botan::TLS::TLS_Exception&) {
            result.test_success("Correctly rejecting 1024 bit RSA keys");
         }

         auto rsa_key_2048 = std::make_unique<Botan::RSA_PrivateKey>(rng, 2048);
         policy.check_peer_key_acceptable(*rsa_key_2048);
         result.test_success("Correctly accepting 2048 bit RSA keys");
   #endif
         return result;
      }

      static Test::Result test_peer_key_acceptable_ecdh(Botan::RandomNumberGenerator& rng) {
         Test::Result result("TLS Policy ECDH key verification");
   #if defined(BOTAN_HAS_ECDH)

         const Botan::TLS::Policy policy;

         if(Botan::EC_Group::supports_named_group("secp192r1")) {
            const auto group_192 = Botan::EC_Group::from_name("secp192r1");
            auto ecdh_192 = std::make_unique<Botan::ECDH_PrivateKey>(rng, group_192);

            try {
               policy.check_peer_key_acceptable(*ecdh_192);
               result.test_failure("Incorrectly accepting 192 bit EC keys");
            } catch(Botan::TLS::TLS_Exception&) {
               result.test_success("Correctly rejecting 192 bit EC keys");
            }
         }

         if(Botan::EC_Group::supports_named_group("secp256r1")) {
            const auto group_256 = Botan::EC_Group::from_name("secp256r1");
            auto ecdh_256 = std::make_unique<Botan::ECDH_PrivateKey>(rng, group_256);
            policy.check_peer_key_acceptable(*ecdh_256);
            result.test_success("Correctly accepting 256 bit EC keys");
         }
   #endif
         return result;
      }

      static Test::Result test_peer_key_acceptable_ecdsa(Botan::RandomNumberGenerator& rng) {
         Test::Result result("TLS Policy ECDSA key verification");
   #if defined(BOTAN_HAS_ECDSA)
         const Botan::TLS::Policy policy;

         if(Botan::EC_Group::supports_named_group("secp192r1")) {
            const auto group_192 = Botan::EC_Group::from_name("secp192r1");
            auto ecdsa_192 = std::make_unique<Botan::ECDSA_PrivateKey>(rng, group_192);

            try {
               policy.check_peer_key_acceptable(*ecdsa_192);
               result.test_failure("Incorrectly accepting 192 bit EC keys");
            } catch(Botan::TLS::TLS_Exception&) {
               result.test_success("Correctly rejecting 192 bit EC keys");
            }
         }

         if(Botan::EC_Group::supports_named_group("secp256r1")) {
            const auto group_256 = Botan::EC_Group::from_name("secp256r1");
            auto ecdsa_256 = std::make_unique<Botan::ECDSA_PrivateKey>(rng, group_256);
            policy.check_peer_key_acceptable(*ecdsa_256);
            result.test_success("Correctly accepting 256 bit EC keys");
         }
   #endif
         return result;
      }

      static Test::Result test_peer_key_acceptable_dh() {
         Test::Result result("TLS Policy DH key verification");
   #if defined(BOTAN_HAS_DIFFIE_HELLMAN)
         const BigInt g("2");
         const BigInt p("58458002095536094658683755258523362961421200751439456159756164191494576279467");
         const Botan::DL_Group grp(p, g);
         const Botan::BigInt x("46205663093589612668746163860870963912226379131190812163519349848291472898748");
         auto dhkey = std::make_unique<Botan::DH_PrivateKey>(grp, x);

         const Botan::TLS::Policy policy;
         try {
            policy.check_peer_key_acceptable(*dhkey);
            result.test_failure("Incorrectly accepting short bit DH keys");
         } catch(Botan::TLS::TLS_Exception&) {
            result.test_success("Correctly rejecting short bit DH keys");
         }
   #endif
         return result;
      }

      static Test::Result test_key_exchange_groups_to_offer() {
         Test::Result result("TLS Policy key share offering");

         const Botan::TLS::Policy default_policy;
         result.test_eq(
            "default TLS Policy offers exactly one", default_policy.key_exchange_groups_to_offer().size(), 1);
         result.confirm(
            "default TLS Policy offers preferred group",
            default_policy.key_exchange_groups().front() == default_policy.key_exchange_groups_to_offer().front());

         using TP = Botan::TLS::Text_Policy;

         result.test_eq("default behaviour from text policy (size)", TP("").key_exchange_groups_to_offer().size(), 1);
         result.confirm("default behaviour from text policy (preferred)",
                        TP("").key_exchange_groups().front() == TP("").key_exchange_groups_to_offer().front());

         result.confirm("no offerings",
                        TP("key_exchange_groups_to_offer = none").key_exchange_groups_to_offer().empty());

         const std::string two_groups = "key_exchange_groups_to_offer = secp256r1 ffdhe/ietf/4096";
         result.test_eq("list of offerings (size)", TP(two_groups).key_exchange_groups_to_offer().size(), 2);
         result.confirm("list of offerings (0)",
                        TP(two_groups).key_exchange_groups_to_offer()[0] == Botan::TLS::Group_Params::SECP256R1);
         result.confirm("list of offerings (1)",
                        TP(two_groups).key_exchange_groups_to_offer()[1] == Botan::TLS::Group_Params::FFDHE_4096);

         return result;
      }
};

BOTAN_REGISTER_TEST("tls", "tls_policy", TLS_Policy_Unit_Tests);

#endif

}  // namespace

}  // namespace Botan_Tests

1	/*
2	* TLS Policy tests
3	*
4	* (C) 2016 Juraj Somorovsky
5	*
6	* Botan is released under the Simplified BSD License (see license.txt)
7	*/
8
9	#include "tests.h"
10
11	#if defined(BOTAN_HAS_TLS)
12	#include <botan/tls_exceptn.h>
13	#include <botan/tls_policy.h>
14	#endif
15
16	#if defined(BOTAN_HAS_RSA)
17	#include <botan/rsa.h>
18	#endif
19
20	#if defined(BOTAN_HAS_ECC_GROUP)
21	#include <botan/ec_group.h>
22	#endif
23
24	#if defined(BOTAN_HAS_ECDH)
25	#include <botan/ecdh.h>
26	#endif
27
28	#if defined(BOTAN_HAS_ECDSA)
29	#include <botan/ecdsa.h>
30	#endif
31
32	#if defined(BOTAN_HAS_DIFFIE_HELLMAN)
33	#include <botan/dh.h>
34	#include <botan/dl_group.h>
35	#endif
36
37	namespace Botan_Tests {
38
39	namespace {
40
41	#if defined(BOTAN_HAS_TLS)
42	class TLS_Policy_Unit_Tests final : public Test {	1✔
43	public:
44	std::vector<Test::Result> run() override {	1✔
45	std::vector<Test::Result> results;	1✔
46
47	results.push_back(test_peer_key_acceptable_rsa(this->rng()));	2✔
48	results.push_back(test_peer_key_acceptable_ecdh(this->rng()));	2✔
49	results.push_back(test_peer_key_acceptable_ecdsa(this->rng()));	2✔
50	results.push_back(test_peer_key_acceptable_dh());	2✔
51	results.push_back(test_key_exchange_groups_to_offer());	2✔
52
53	return results;	1✔
54	}	×
55
56	private:
57	static Test::Result test_peer_key_acceptable_rsa(Botan::RandomNumberGenerator& rng) {	1✔
58	Test::Result result("TLS Policy RSA key verification");	1✔
59	#if defined(BOTAN_HAS_RSA)
60	auto rsa_key_1024 = std::make_unique<Botan::RSA_PrivateKey>(rng, 1024);	1✔
61	const Botan::TLS::Policy policy;	1✔
62
63	try {	1✔
64	policy.check_peer_key_acceptable(*rsa_key_1024);	1✔
65	result.test_failure("Incorrectly accepting 1024 bit RSA keys");	×
66	} catch(Botan::TLS::TLS_Exception&) {	1✔
67	result.test_success("Correctly rejecting 1024 bit RSA keys");	1✔
68	}	1✔
69
70	auto rsa_key_2048 = std::make_unique<Botan::RSA_PrivateKey>(rng, 2048);	1✔
71	policy.check_peer_key_acceptable(*rsa_key_2048);	1✔
72	result.test_success("Correctly accepting 2048 bit RSA keys");	1✔
73	#endif
74	return result;	1✔
75	}	1✔
76
77	static Test::Result test_peer_key_acceptable_ecdh(Botan::RandomNumberGenerator& rng) {	1✔
78	Test::Result result("TLS Policy ECDH key verification");	1✔
79	#if defined(BOTAN_HAS_ECDH)
80
81	const Botan::TLS::Policy policy;	1✔
82
83	if(Botan::EC_Group::supports_named_group("secp192r1")) {	1✔
84	const auto group_192 = Botan::EC_Group::from_name("secp192r1");	1✔
85	auto ecdh_192 = std::make_unique<Botan::ECDH_PrivateKey>(rng, group_192);	1✔
86
87	try {	1✔
88	policy.check_peer_key_acceptable(*ecdh_192);	1✔
89	result.test_failure("Incorrectly accepting 192 bit EC keys");	×
90	} catch(Botan::TLS::TLS_Exception&) {	1✔
91	result.test_success("Correctly rejecting 192 bit EC keys");	1✔
92	}	1✔
93	}	1✔
94
95	if(Botan::EC_Group::supports_named_group("secp256r1")) {	1✔
96	const auto group_256 = Botan::EC_Group::from_name("secp256r1");	1✔
97	auto ecdh_256 = std::make_unique<Botan::ECDH_PrivateKey>(rng, group_256);	1✔
98	policy.check_peer_key_acceptable(*ecdh_256);	1✔
99	result.test_success("Correctly accepting 256 bit EC keys");	1✔
100	}	1✔
101	#endif
102	return result;	1✔
103	}	1✔
104
105	static Test::Result test_peer_key_acceptable_ecdsa(Botan::RandomNumberGenerator& rng) {	1✔
106	Test::Result result("TLS Policy ECDSA key verification");	1✔
107	#if defined(BOTAN_HAS_ECDSA)
108	const Botan::TLS::Policy policy;	1✔
109
110	if(Botan::EC_Group::supports_named_group("secp192r1")) {	1✔
111	const auto group_192 = Botan::EC_Group::from_name("secp192r1");	1✔
112	auto ecdsa_192 = std::make_unique<Botan::ECDSA_PrivateKey>(rng, group_192);	1✔
113
114	try {	1✔
115	policy.check_peer_key_acceptable(*ecdsa_192);	1✔
116	result.test_failure("Incorrectly accepting 192 bit EC keys");	×
117	} catch(Botan::TLS::TLS_Exception&) {	1✔
118	result.test_success("Correctly rejecting 192 bit EC keys");	1✔
119	}	1✔
120	}	1✔
121
122	if(Botan::EC_Group::supports_named_group("secp256r1")) {	1✔
123	const auto group_256 = Botan::EC_Group::from_name("secp256r1");	1✔
124	auto ecdsa_256 = std::make_unique<Botan::ECDSA_PrivateKey>(rng, group_256);	1✔
125	policy.check_peer_key_acceptable(*ecdsa_256);	1✔
126	result.test_success("Correctly accepting 256 bit EC keys");	1✔
127	}	1✔
128	#endif
129	return result;	1✔
130	}	1✔
131
132	static Test::Result test_peer_key_acceptable_dh() {	1✔
133	Test::Result result("TLS Policy DH key verification");	1✔
134	#if defined(BOTAN_HAS_DIFFIE_HELLMAN)
135	const BigInt g("2");	1✔
136	const BigInt p("58458002095536094658683755258523362961421200751439456159756164191494576279467");	1✔
137	const Botan::DL_Group grp(p, g);	1✔
138	const Botan::BigInt x("46205663093589612668746163860870963912226379131190812163519349848291472898748");	1✔
139	auto dhkey = std::make_unique<Botan::DH_PrivateKey>(grp, x);	1✔
140
141	const Botan::TLS::Policy policy;	1✔
142	try {	1✔
143	policy.check_peer_key_acceptable(*dhkey);	1✔
144	result.test_failure("Incorrectly accepting short bit DH keys");	×
145	} catch(Botan::TLS::TLS_Exception&) {	1✔
146	result.test_success("Correctly rejecting short bit DH keys");	1✔
147	}	1✔
148	#endif
149	return result;	2✔
150	}	2✔
151
152	static Test::Result test_key_exchange_groups_to_offer() {	1✔
153	Test::Result result("TLS Policy key share offering");	1✔
154
155	const Botan::TLS::Policy default_policy;	1✔
156	result.test_eq(	2✔
157	"default TLS Policy offers exactly one", default_policy.key_exchange_groups_to_offer().size(), 1);	1✔
158	result.confirm(	2✔
159	"default TLS Policy offers preferred group",
160	default_policy.key_exchange_groups().front() == default_policy.key_exchange_groups_to_offer().front());	2✔
161
162	using TP = Botan::TLS::Text_Policy;	1✔
163
164	result.test_eq("default behaviour from text policy (size)", TP("").key_exchange_groups_to_offer().size(), 1);	3✔
165	result.confirm("default behaviour from text policy (preferred)",	3✔
166	TP("").key_exchange_groups().front() == TP("").key_exchange_groups_to_offer().front());	3✔
167
168	result.confirm("no offerings",	2✔
169	TP("key_exchange_groups_to_offer = none").key_exchange_groups_to_offer().empty());	2✔
170
171	const std::string two_groups = "key_exchange_groups_to_offer = secp256r1 ffdhe/ietf/4096";	1✔
172	result.test_eq("list of offerings (size)", TP(two_groups).key_exchange_groups_to_offer().size(), 2);	3✔
173	result.confirm("list of offerings (0)",	3✔
174	TP(two_groups).key_exchange_groups_to_offer()[0] == Botan::TLS::Group_Params::SECP256R1);	2✔
175	result.confirm("list of offerings (1)",	3✔
176	TP(two_groups).key_exchange_groups_to_offer()[1] == Botan::TLS::Group_Params::FFDHE_4096);	2✔
177
178	return result;	1✔
179	}	1✔
180	};
181
182	BOTAN_REGISTER_TEST("tls", "tls_policy", TLS_Policy_Unit_Tests);
183
184	#endif
185
186	} // namespace
187
188	} // namespace Botan_Tests

randombit / botan / 21782759586

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous