stacklok / toolhive / 21760661463

push

github

Simplify authserver's upstream provider interface (#3638)

Follow-up to an earlier discussion in a previous PR:
https://github.com/stacklok/toolhive/pull/3580#discussion_r2762417865

Combine ExchangeCode and ResolveIdentity into atomic ExchangeCodeForIdentity

Merge the two-step exchange+identity flow into a single interface method
to prevent OIDC nonce validation from being accidentally skipped. This
ensures replay protection is always enforced when exchanging authorization
codes with OIDC providers.

The OAuth2Provider interface shrinks from 6 to 4 methods by removing
ExchangeCode, ResolveIdentity, and FetchUserInfo (now package-private).
The UserInfo struct is also made private and moved to oauth2.go.

38 of 47 new or added lines in 4 files covered. (80.85%)

41589 of 68102 relevant lines covered (61.07%)

77.44 hits per line