stacklok / toolhive / 21684042122

Build # 21684042122

Build Type

push

github

Committed by web-flow

Commit Message

Add omitempty to UserinfoEndpoint JSON tag (#3601)

The authserver does not implement a UserInfo endpoint: no /userinfo
handler is registered and buildOAuthMetadata() never populates the
field. Without omitempty the empty string was serialized into
discovery documents, which is misleading and could cause clients to
attempt requests against a non-existent endpoint.

Omitting the field is standards-compliant: userinfo_endpoint is not
defined in RFC 8414 (OAuth 2.0 AS Metadata) and is only RECOMMENDED
(not REQUIRED) by OIDC Discovery 1.0. Consumers in the codebase
already guard with `if doc.UserinfoEndpoint != ""` before use.

Run Details

40416 of 66495 relevant lines covered (60.78%)

76.03 hits per line

Source File

Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available