• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

openmc-dev / openmc / 21597104861

02 Feb 2026 03:53PM UTC coverage: 81.674% (-0.3%) from 81.968%
21597104861

Pull #3751

github

web-flow
Merge 4a6501226 into 6041ee6ae
Pull Request #3751: Resolve conflict with weight windows and global russian roulette

16697 of 23049 branches covered (72.44%)

Branch coverage included in aggregate %.

76 of 84 new or added lines in 5 files covered. (90.48%)

471 existing lines in 31 files now uncovered.

54833 of 64531 relevant lines covered (84.97%)

37154420.72 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.85
/src/tallies/filter_cell_instance.cpp
1
#include "openmc/tallies/filter_cell_instance.h"
2

3
#include <cassert>
4
#include <string>
5

6
#include <fmt/core.h>
7

8
#include "openmc/capi.h"
9
#include "openmc/cell.h"
10
#include "openmc/error.h"
11
#include "openmc/geometry.h"
12
#include "openmc/xml_interface.h"
13

14
namespace openmc {
15

16
CellInstanceFilter::CellInstanceFilter(span<CellInstance> instances)
×
17
{
18
  this->set_cell_instances(instances);
×
19
}
×
20

21
void CellInstanceFilter::from_xml(pugi::xml_node node)
24✔
22
{
23
  // Get cell IDs/instances
24
  auto cells = get_node_array<int32_t>(node, "bins");
24✔
25
  assert(cells.size() % 2 == 0);
20!
26

27
  // Convert into vector of CellInstance
28
  vector<CellInstance> instances;
24✔
29
  for (int64_t i = 0; i < cells.size() / 2; ++i) {
504✔
30
    int32_t cell_id = cells[2 * i];
480✔
31
    int64_t instance = cells[2 * i + 1];
480✔
32
    auto search = model::cell_map.find(cell_id);
480✔
33
    if (search == model::cell_map.end()) {
480!
34
      throw std::runtime_error {fmt::format(
×
35
        "Could not find cell {} specified on tally filter.", cell_id)};
×
36
    }
37
    int64_t index = search->second;
480✔
38
    instances.push_back({index, instance});
480✔
39
  }
40

41
  this->set_cell_instances(instances);
24✔
42
}
24✔
43

44
void CellInstanceFilter::set_cell_instances(span<CellInstance> instances)
24✔
45
{
46
  // Clear existing cells
47
  cell_instances_.clear();
24✔
48
  cell_instances_.reserve(instances.size());
24✔
49
  cells_.clear();
24✔
50
  map_.clear();
24✔
51

52
  // Update cells and mapping
53
  for (auto& x : instances) {
504✔
54
    assert(x.index_cell >= 0);
400!
55
    assert(x.index_cell < model::cells.size());
400!
56
    cell_instances_.push_back(x);
480✔
57
    cells_.insert(x.index_cell);
480✔
58
    map_[x] = cell_instances_.size() - 1;
480✔
59
  }
60

61
  n_bins_ = cell_instances_.size();
24✔
62

63
  material_cells_only_ = true;
24✔
64
  for (const auto& cell_inst : cell_instances_) {
216!
65
    const auto& c = *model::cells[cell_inst.index_cell];
216✔
66
    if (c.type_ == Fill::MATERIAL)
216✔
67
      continue;
192✔
68
    material_cells_only_ = false;
24✔
69
    break;
24✔
70
  }
71
}
24✔
72

73
void CellInstanceFilter::get_all_bins(
5,535,264✔
74
  const Particle& p, TallyEstimator estimator, FilterMatch& match) const
75
{
76
  int64_t index_cell = p.lowest_coord().cell();
5,535,264✔
77
  int64_t instance = p.cell_instance();
5,535,264✔
78

79
  if (cells_.count(index_cell) > 0) {
5,535,264✔
80
    auto search = map_.find({index_cell, instance});
1,497,808✔
81
    if (search != map_.end()) {
1,497,808!
82
      int index_bin = search->second;
1,497,808✔
83
      match.bins_.push_back(index_bin);
1,497,808✔
84
      match.weights_.push_back(1.0);
1,497,808✔
85
    }
86
  }
87

88
  if (material_cells_only_)
5,535,264!
UNCOV
89
    return;
×
90

91
  for (int i = 0; i < p.n_coord() - 1; i++) {
12,478,352✔
92
    int64_t index_cell = p.coord(i).cell();
6,943,088✔
93
    // if this cell isn't used on the filter, move on
94
    if (cells_.count(index_cell) == 0)
6,943,088✔
95
      continue;
5,535,264✔
96

97
    // if this cell is used in the filter, check the instance as well
98
    int64_t instance = cell_instance_at_level(p, i);
1,407,824✔
99
    auto search = map_.find({index_cell, instance});
1,407,824✔
100
    if (search != map_.end()) {
1,407,824!
101
      match.bins_.push_back(search->second);
1,407,824✔
102
      match.weights_.push_back(1.0);
1,407,824✔
103
    }
104
  }
105
}
106

107
void CellInstanceFilter::to_statepoint(hid_t filter_group) const
16✔
108
{
109
  Filter::to_statepoint(filter_group);
16✔
110
  size_t n = cell_instances_.size();
16✔
111
  xt::xtensor<size_t, 2> data({n, 2});
16✔
112
  for (int64_t i = 0; i < n; ++i) {
336✔
113
    const auto& x = cell_instances_[i];
320✔
114
    data(i, 0) = model::cells[x.index_cell]->id_;
320✔
115
    data(i, 1) = x.instance;
320✔
116
  }
117
  write_dataset(filter_group, "bins", data);
16✔
118
}
16✔
119

120
std::string CellInstanceFilter::text_label(int bin) const
320✔
121
{
122
  const auto& x = cell_instances_[bin];
320✔
123
  auto cell_id = model::cells[x.index_cell]->id_;
320✔
124
  return "Cell " + std::to_string(cell_id) + ", Instance " +
640✔
125
         std::to_string(x.instance);
960✔
126
}
127

128
} // namespace openmc
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc