• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4945

30 Jan 2026 06:19AM UTC coverage: 66.87% (+0.02%) from 66.849%
#4945

push

travis-ci

web-flow
merge: from main to 3.0 #34453

1126 of 2018 new or added lines in 72 files covered. (55.8%)

13708 existing lines in 159 files now uncovered.

205277 of 306978 relevant lines covered (66.87%)

126353544.65 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

75.96
/source/dnode/mnode/impl/src/mndTopic.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *f
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "mndTopic.h"
17
#include "audit.h"
18
#include "mndConsumer.h"
19
#include "mndDb.h"
20
#include "mndDnode.h"
21
#include "mndMnode.h"
22
#include "mndPrivilege.h"
23
#include "mndShow.h"
24
#include "mndStb.h"
25
#include "mndSubscribe.h"
26
#include "mndTrans.h"
27
#include "mndUser.h"
28
#include "mndVgroup.h"
29
#include "osMemPool.h"
30
#include "parser.h"
31
#include "tlockfree.h"
32
#include "tname.h"
33

34
#define MND_TOPIC_VER_SUPPORT_OWNER 4
35
#define MND_TOPIC_VER_NUMBER        MND_TOPIC_VER_SUPPORT_OWNER
36
#define MND_TOPIC_RESERVE_SIZE      64
37

38
SHashObj *topicsToReload = NULL;
39

40
SSdbRaw *mndTopicActionEncode(SMqTopicObj *pTopic);
41
SSdbRow *mndTopicActionDecode(SSdbRaw *pRaw);
42

43
static int32_t mndTopicActionInsert(SSdb *pSdb, SMqTopicObj *pTopic);
44
static int32_t mndTopicActionDelete(SSdb *pSdb, SMqTopicObj *pTopic);
45
static int32_t mndTopicActionUpdate(SSdb *pSdb, SMqTopicObj *pOldTopic, SMqTopicObj *pNewTopic);
46
static int32_t mndProcessCreateTopicReq(SRpcMsg *pReq);
47
static int32_t mndProcessDropTopicReq(SRpcMsg *pReq);
48

49
static int32_t mndRetrieveTopic(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
50
static void    mndCancelGetNextTopic(SMnode *pMnode, void *pIter);
51
static int32_t processAst(SMqTopicObj *topicObj, const char *ast);
52

53
int32_t mndInitTopic(SMnode *pMnode) {
399,391✔
54
  SSdbTable table = {
399,391✔
55
      .sdbType = SDB_TOPIC,
56
      .keyType = SDB_KEY_BINARY,
57
      .encodeFp = (SdbEncodeFp)mndTopicActionEncode,
58
      .decodeFp = (SdbDecodeFp)mndTopicActionDecode,
59
      .insertFp = (SdbInsertFp)mndTopicActionInsert,
60
      .updateFp = (SdbUpdateFp)mndTopicActionUpdate,
61
      .deleteFp = (SdbDeleteFp)mndTopicActionDelete,
62
  };
63

64
  if (pMnode == NULL) {
399,391✔
65
    return TSDB_CODE_INVALID_PARA;
×
66
  }
67
  mndSetMsgHandle(pMnode, TDMT_MND_TMQ_CREATE_TOPIC, mndProcessCreateTopicReq);
399,391✔
68
  mndSetMsgHandle(pMnode, TDMT_MND_TMQ_DROP_TOPIC, mndProcessDropTopicReq);
399,391✔
69

70
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_TOPICS, mndRetrieveTopic);
399,391✔
71
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_TOPICS, mndCancelGetNextTopic);
399,391✔
72

73
  return sdbSetTable(pMnode->pSdb, table);
399,391✔
74
}
75

76
void mndCleanupTopic(SMnode *pMnode) {}
399,333✔
77

78
void mndTopicGetShowName(const char *fullTopic, char *topic) {
164,376✔
79
  if (fullTopic == NULL) {
164,376✔
80
    return;
×
81
  }
82
  char *tmp = strchr(fullTopic, '.');
164,376✔
83
  if (tmp == NULL) {
164,376✔
84
    tstrncpy(topic, fullTopic, TSDB_TOPIC_FNAME_LEN);
×
85
  } else {
86
    tstrncpy(topic, tmp + 1, TSDB_TOPIC_FNAME_LEN);
164,376✔
87
  }
88
}
89
SSdbRaw *mndTopicActionEncode(SMqTopicObj *pTopic) {
272,765✔
90
  if (pTopic == NULL) {
272,765✔
91
    return NULL;
×
92
  }
93
  int32_t code = 0;
272,765✔
94
  int32_t lino = 0;
272,765✔
95
  terrno = TSDB_CODE_OUT_OF_MEMORY;
272,765✔
96

97
  void *  swBuf = NULL;
272,765✔
98
  int32_t physicalPlanLen = 0;
272,765✔
99
  if (pTopic->physicalPlan) {
272,765✔
100
    physicalPlanLen = strlen(pTopic->physicalPlan) + 1;
272,765✔
101
  }
102

103
  int32_t schemaLen = 0;
272,765✔
104
  if (pTopic->schema.nCols) {
272,765✔
105
    schemaLen = taosEncodeSSchemaWrapper(NULL, &pTopic->schema);
422,232✔
106
  }
107

108
  int32_t  size = sizeof(SMqTopicObj) + physicalPlanLen + pTopic->sqlLen + schemaLen + MND_TOPIC_RESERVE_SIZE;
272,765✔
109
  SSdbRaw *pRaw = sdbAllocRaw(SDB_TOPIC, MND_TOPIC_VER_NUMBER, size);
272,765✔
110
  if (pRaw == NULL) {
272,765✔
111
    goto TOPIC_ENCODE_OVER;
×
112
  }
113

114
  int32_t dataPos = 0;
272,765✔
115
  SDB_SET_BINARY(pRaw, dataPos, pTopic->name, TSDB_TOPIC_FNAME_LEN, TOPIC_ENCODE_OVER);
272,765✔
116
  SDB_SET_BINARY(pRaw, dataPos, pTopic->db, TSDB_DB_FNAME_LEN, TOPIC_ENCODE_OVER);
272,765✔
117
  SDB_SET_BINARY(pRaw, dataPos, pTopic->createUser, TSDB_USER_LEN, TOPIC_ENCODE_OVER);
272,765✔
118
  SDB_SET_INT64(pRaw, dataPos, pTopic->createTime, TOPIC_ENCODE_OVER);
272,765✔
119
  SDB_SET_INT64(pRaw, dataPos, pTopic->updateTime, TOPIC_ENCODE_OVER);
272,765✔
120
  SDB_SET_INT64(pRaw, dataPos, pTopic->uid, TOPIC_ENCODE_OVER);
272,765✔
121
  SDB_SET_INT64(pRaw, dataPos, pTopic->dbUid, TOPIC_ENCODE_OVER);
272,765✔
122
  SDB_SET_INT32(pRaw, dataPos, pTopic->version, TOPIC_ENCODE_OVER);
272,765✔
123
  SDB_SET_INT8(pRaw, dataPos, pTopic->subType, TOPIC_ENCODE_OVER);
272,765✔
124
  SDB_SET_INT8(pRaw, dataPos, pTopic->withMeta, TOPIC_ENCODE_OVER);
272,765✔
125

126
  SDB_SET_INT64(pRaw, dataPos, pTopic->stbUid, TOPIC_ENCODE_OVER);
272,765✔
127
  SDB_SET_BINARY(pRaw, dataPos, pTopic->stbName, TSDB_TABLE_FNAME_LEN, TOPIC_ENCODE_OVER);
272,765✔
128
  SDB_SET_INT32(pRaw, dataPos, pTopic->sqlLen, TOPIC_ENCODE_OVER);
272,765✔
129
  SDB_SET_BINARY(pRaw, dataPos, pTopic->sql, pTopic->sqlLen, TOPIC_ENCODE_OVER);
272,765✔
130
  SDB_SET_INT32(pRaw, dataPos, physicalPlanLen, TOPIC_ENCODE_OVER);
272,765✔
131
  if (physicalPlanLen) {
272,765✔
132
    SDB_SET_BINARY(pRaw, dataPos, pTopic->physicalPlan, physicalPlanLen, TOPIC_ENCODE_OVER);
272,765✔
133
  }
134
  SDB_SET_INT32(pRaw, dataPos, schemaLen, TOPIC_ENCODE_OVER);
272,765✔
135
  if (schemaLen) {
272,765✔
136
    swBuf = taosMemoryMalloc(schemaLen);
211,116✔
137
    if (swBuf == NULL) {
211,116✔
138
      goto TOPIC_ENCODE_OVER;
×
139
    }
140
    void *aswBuf = swBuf;
211,116✔
141
    if (taosEncodeSSchemaWrapper(&aswBuf, &pTopic->schema) < 0) {
422,232✔
142
      goto TOPIC_ENCODE_OVER;
×
143
    }
144
    SDB_SET_BINARY(pRaw, dataPos, swBuf, schemaLen, TOPIC_ENCODE_OVER);
211,116✔
145
  }
146
  SDB_SET_INT64(pRaw, dataPos, pTopic->ownerId, TOPIC_ENCODE_OVER); // since ver 4
272,765✔
147
  SDB_SET_RESERVE(pRaw, dataPos, MND_TOPIC_RESERVE_SIZE, TOPIC_ENCODE_OVER);
272,765✔
148
  SDB_SET_DATALEN(pRaw, dataPos, TOPIC_ENCODE_OVER);
272,765✔
149

150
  terrno = TSDB_CODE_SUCCESS;
272,765✔
151

152
TOPIC_ENCODE_OVER:
272,765✔
153
  if (swBuf) taosMemoryFree(swBuf);
272,765✔
154
  if (terrno != TSDB_CODE_SUCCESS) {
272,765✔
155
    mError("topic:%s, failed to encode to raw:%p since %s", pTopic->name, pRaw, terrstr());
×
156
    sdbFreeRaw(pRaw);
×
157
    return NULL;
×
158
  }
159

160
  mDebug("topic:%s, encode to raw:%p, row:%p", pTopic->name, pRaw, pTopic);
272,765✔
161
  return pRaw;
272,765✔
162
}
163

164
SSdbRow *mndTopicActionDecode(SSdbRaw *pRaw) {
234,729✔
165
  if (pRaw == NULL) return NULL;
234,729✔
166
  int32_t code = 0;
234,729✔
167
  int32_t lino = 0;
234,729✔
168
  terrno = TSDB_CODE_OUT_OF_MEMORY;
234,729✔
169
  SSdbRow *    pRow = NULL;
234,729✔
170
  SMqTopicObj *pTopic = NULL;
234,729✔
171
  void *       buf = NULL;
234,729✔
172
  char*        ast = NULL;
234,729✔
173

174
  int8_t sver = 0;
234,729✔
175
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) goto TOPIC_DECODE_OVER;
234,729✔
176

177
  if (sver < 1 || sver > MND_TOPIC_VER_NUMBER) {
234,729✔
178
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
179
    goto TOPIC_DECODE_OVER;
×
180
  }
181

182
  pRow = sdbAllocRow(sizeof(SMqTopicObj));
234,729✔
183
  if (pRow == NULL) goto TOPIC_DECODE_OVER;
234,729✔
184

185
  pTopic = sdbGetRowObj(pRow);
234,729✔
186
  if (pTopic == NULL) goto TOPIC_DECODE_OVER;
234,729✔
187

188
  int32_t len = 0;
234,729✔
189
  int32_t dataPos = 0;
234,729✔
190
  SDB_GET_BINARY(pRaw, dataPos, pTopic->name, TSDB_TOPIC_FNAME_LEN, TOPIC_DECODE_OVER);
234,729✔
191
  SDB_GET_BINARY(pRaw, dataPos, pTopic->db, TSDB_DB_FNAME_LEN, TOPIC_DECODE_OVER);
234,729✔
192
  if (sver >= 2) {
234,729✔
193
    SDB_GET_BINARY(pRaw, dataPos, pTopic->createUser, TSDB_USER_LEN, TOPIC_DECODE_OVER);
234,729✔
194
  }
195
  SDB_GET_INT64(pRaw, dataPos, &pTopic->createTime, TOPIC_DECODE_OVER);
234,729✔
196
  SDB_GET_INT64(pRaw, dataPos, &pTopic->updateTime, TOPIC_DECODE_OVER);
234,729✔
197
  SDB_GET_INT64(pRaw, dataPos, &pTopic->uid, TOPIC_DECODE_OVER);
234,729✔
198
  SDB_GET_INT64(pRaw, dataPos, &pTopic->dbUid, TOPIC_DECODE_OVER);
234,729✔
199
  SDB_GET_INT32(pRaw, dataPos, &pTopic->version, TOPIC_DECODE_OVER);
234,729✔
200
  SDB_GET_INT8(pRaw, dataPos, &pTopic->subType, TOPIC_DECODE_OVER);
234,729✔
201
  SDB_GET_INT8(pRaw, dataPos, &pTopic->withMeta, TOPIC_DECODE_OVER);
234,729✔
202

203
  SDB_GET_INT64(pRaw, dataPos, &pTopic->stbUid, TOPIC_DECODE_OVER);
234,729✔
204
  if (sver >= 3) {
234,729✔
205
    SDB_GET_BINARY(pRaw, dataPos, pTopic->stbName, TSDB_TABLE_FNAME_LEN, TOPIC_DECODE_OVER);
234,729✔
206
  }
207
  SDB_GET_INT32(pRaw, dataPos, &pTopic->sqlLen, TOPIC_DECODE_OVER);
234,729✔
208
  pTopic->sql = taosMemoryCalloc(pTopic->sqlLen, sizeof(char));
234,729✔
209
  if (pTopic->sql == NULL) {
234,729✔
210
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
211
    goto TOPIC_DECODE_OVER;
×
212
  }
213
  SDB_GET_BINARY(pRaw, dataPos, pTopic->sql, pTopic->sqlLen, TOPIC_DECODE_OVER);
234,729✔
214

215
  if (sver < MND_TOPIC_VER_SUPPORT_OWNER) {
234,729✔
216
    int32_t astLen = 0;
×
217
    SDB_GET_INT32(pRaw, dataPos, &astLen, TOPIC_DECODE_OVER);
×
218
    if (astLen) {
×
219
      ast = taosMemoryCalloc(astLen, sizeof(char));
×
220
      if (ast == NULL) {
×
221
        terrno = TSDB_CODE_OUT_OF_MEMORY;
×
222
        goto TOPIC_DECODE_OVER;
×
223
      }
224
      SDB_GET_BINARY(pRaw, dataPos, ast, astLen, TOPIC_DECODE_OVER);
×
225
      terrno = processAst(pTopic, ast);
×
226
      if (terrno != TSDB_CODE_SUCCESS) {
×
227
        goto TOPIC_DECODE_OVER;
×
228
      }
229
    }
230
  } else {
231
    SDB_GET_INT32(pRaw, dataPos, &len, TOPIC_DECODE_OVER);
234,729✔
232
    if (len) {
234,729✔
233
      pTopic->physicalPlan = taosMemoryCalloc(len, sizeof(char));
234,729✔
234
      if (pTopic->physicalPlan == NULL) {
234,729✔
235
        terrno = TSDB_CODE_OUT_OF_MEMORY;
×
236
        goto TOPIC_DECODE_OVER;
×
237
      }
238
      SDB_GET_BINARY(pRaw, dataPos, pTopic->physicalPlan, len, TOPIC_DECODE_OVER);
234,729✔
239
    } else {
240
      pTopic->physicalPlan = NULL;
×
241
    }
242

243
    SDB_GET_INT32(pRaw, dataPos, &len, TOPIC_DECODE_OVER);
234,729✔
244
    if (len) {
234,729✔
245
      buf = taosMemoryMalloc(len);
183,393✔
246
      if (buf == NULL) {
183,393✔
247
        terrno = TSDB_CODE_OUT_OF_MEMORY;
×
248
        goto TOPIC_DECODE_OVER;
×
249
      }
250
      SDB_GET_BINARY(pRaw, dataPos, buf, len, TOPIC_DECODE_OVER);
183,393✔
251
      if (taosDecodeSSchemaWrapper(buf, &pTopic->schema) == NULL) {
366,786✔
252
        goto TOPIC_DECODE_OVER;
×
253
      }
254
    } else {
255
      pTopic->schema.nCols = 0;
51,336✔
256
      pTopic->schema.version = 0;
51,336✔
257
      pTopic->schema.pSchema = NULL;
51,336✔
258
    }
259
    SDB_GET_INT64(pRaw, dataPos, &pTopic->ownerId, TOPIC_DECODE_OVER);
234,729✔
260
  }
261

262
  SDB_GET_RESERVE(pRaw, dataPos, MND_TOPIC_RESERVE_SIZE, TOPIC_DECODE_OVER);
234,729✔
263
  terrno = TSDB_CODE_SUCCESS;
234,729✔
264

265
TOPIC_DECODE_OVER:
234,729✔
266
  taosMemoryFreeClear(buf);
234,729✔
267
  taosMemoryFreeClear(ast);
234,729✔
268

269
  if (terrno != TSDB_CODE_SUCCESS) {
234,729✔
270
    mError("topic:%s, failed to decode from raw:%p since %s", pTopic == NULL ? "null" : pTopic->name, pRaw, terrstr());
×
271
    taosMemoryFreeClear(pRow);
×
272
    return NULL;
×
273
  }
274

275
  mDebug("topic:%s, decode from raw:%p, row:%p", pTopic->name, pRaw, pTopic);
234,729✔
276
  return pRow;
234,729✔
277
}
278

279
static int32_t mndTopicActionInsert(SSdb *pSdb, SMqTopicObj *pTopic) {
139,862✔
280
  mDebug("topic:%s perform insert action", pTopic != NULL ? pTopic->name : "null");
139,862✔
281
  return 0;
139,862✔
282
}
283

284
static int32_t mndTopicActionDelete(SSdb *pSdb, SMqTopicObj *pTopic) {
234,729✔
285
  if (pTopic == NULL) return 0;
234,729✔
286
  mDebug("%p topic:%s perform delete action", pTopic, pTopic->name);
234,729✔
287
  taosMemoryFreeClear(pTopic->sql);
234,729✔
288
  taosMemoryFreeClear(pTopic->physicalPlan);
234,729✔
289
  if (pTopic->schema.nCols) taosMemoryFreeClear(pTopic->schema.pSchema);
234,729✔
290
  return 0;
234,729✔
291
}
292

293
static int32_t mndTopicActionUpdate(SSdb *pSdb, SMqTopicObj *pOldTopic, SMqTopicObj *pNewTopic) {
×
294
  if (pOldTopic == NULL || pNewTopic == NULL) return 0;
×
295
  mDebug("topic:%s perform update action", pOldTopic->name);
×
296
  taosWLockLatch(&pOldTopic->lock);
×
297
  SMqTopicObj tmpTopic = *pOldTopic;
×
298
  (void)memcpy(pOldTopic, pNewTopic, offsetof(SMqTopicObj, lock));
×
299
  *pNewTopic = tmpTopic;
×
300
  taosWUnLockLatch(&pOldTopic->lock);
×
301
  return 0;
×
302
}
303

304
int32_t mndAcquireTopic(SMnode *pMnode, const char *topicName, SMqTopicObj **pTopic) {
2,125,713✔
305
  if (pMnode == NULL || topicName == NULL || pTopic == NULL) {
2,125,713✔
306
    return TSDB_CODE_INVALID_PARA;
×
307
  }
308
  SSdb *pSdb = pMnode->pSdb;
2,125,713✔
309
  *pTopic = sdbAcquire(pSdb, SDB_TOPIC, topicName);
2,125,713✔
310
  if (*pTopic == NULL) {
2,125,713✔
311
    return TSDB_CODE_MND_TOPIC_NOT_EXIST;
129,633✔
312
  }
313
  return TSDB_CODE_SUCCESS;
1,996,080✔
314
}
315

316
void mndReleaseTopic(SMnode *pMnode, SMqTopicObj *pTopic) {
2,288,188✔
317
  if (pMnode == NULL) return;
2,288,188✔
318
  SSdb *pSdb = pMnode->pSdb;
2,288,188✔
319
  sdbRelease(pSdb, pTopic);
2,288,188✔
320
}
321

322
static int32_t mndCheckCreateTopicReq(SCMCreateTopicReq *pCreate) {
121,794✔
323
  if (pCreate == NULL) return TSDB_CODE_INVALID_PARA;
121,794✔
324
  if (pCreate->sql == NULL) return TSDB_CODE_MND_INVALID_TOPIC;
121,794✔
325

326
  if (pCreate->subType == TOPIC_SUB_TYPE__COLUMN) {
121,794✔
327
    if (pCreate->ast == NULL || pCreate->ast[0] == 0) return TSDB_CODE_MND_INVALID_TOPIC;
89,288✔
328
  } else if (pCreate->subType == TOPIC_SUB_TYPE__TABLE) {
32,506✔
329
    if (pCreate->subStbName[0] == 0) return TSDB_CODE_MND_INVALID_TOPIC;
9,057✔
330
  } else if (pCreate->subType == TOPIC_SUB_TYPE__DB) {
23,449✔
331
    if (pCreate->subDbName[0] == 0) return TSDB_CODE_MND_INVALID_TOPIC;
23,449✔
332
  }
333

334
  return 0;
121,794✔
335
}
336

337
static int32_t processAst(SMqTopicObj *topicObj, const char *ast) {
119,152✔
338
  SNode *     pAst = NULL;
119,152✔
339
  SQueryPlan *pPlan = NULL;
119,152✔
340
  int32_t     code = TSDB_CODE_SUCCESS;
119,152✔
341
  int32_t     lino = 0;
119,152✔
342

343
  PRINT_LOG_START
119,152✔
344
  if (ast == NULL) {
119,152✔
345
    topicObj->physicalPlan = taosStrdup("");
26,981✔
346
    goto END;
26,981✔
347
  }
348
  qDebugL("%s topic:%s ast %s", __func__, topicObj->name, ast);
92,171✔
349
  MND_TMQ_RETURN_CHECK(nodesStringToNode(ast, &pAst));
92,171✔
350
  MND_TMQ_RETURN_CHECK(qExtractResultSchema(pAst, &topicObj->schema.nCols, &topicObj->schema.pSchema));
92,171✔
351

352
  SPlanContext cxt = {.pAstRoot = pAst, .topicQuery = true};
92,171✔
353
  MND_TMQ_RETURN_CHECK(qCreateQueryPlan(&cxt, &pPlan, NULL));
92,171✔
354
  if (pPlan == NULL) {
92,171✔
355
    code = TSDB_CODE_MND_INVALID_TOPIC_QUERY;
×
356
    goto END;
×
357
  }
358
  int32_t levelNum = LIST_LENGTH(pPlan->pSubplans);
92,171✔
359
  if (levelNum != 1) {
92,171✔
360
    code = TSDB_CODE_MND_INVALID_TOPIC_QUERY;
×
361
    goto END;
×
362
  }
363

364
  SNodeListNode *pNodeListNode = (SNodeListNode *)nodesListGetNode(pPlan->pSubplans, 0);
92,171✔
365
  MND_TMQ_NULL_CHECK(pNodeListNode);
92,171✔
366
  int32_t opNum = LIST_LENGTH(pNodeListNode->pNodeList);
92,171✔
367
  if (opNum != 1) {
92,171✔
368
    code = TSDB_CODE_MND_INVALID_TOPIC_QUERY;
×
369
    goto END;
×
370
  }
371

372
  code = nodesNodeToString(nodesListGetNode(pNodeListNode->pNodeList, 0), false, &topicObj->physicalPlan, NULL);
92,171✔
373

374
END:
119,152✔
375
  nodesDestroyNode(pAst);
119,152✔
376
  qDestroyQueryPlan(pPlan);
119,152✔
377
  PRINT_LOG_END
119,152✔
378
  return code;
119,152✔
379
}
380

381
static int32_t mndCreateTopic(SMnode *pMnode, SRpcMsg *pReq, SCMCreateTopicReq *pCreate, SDbObj *pDb,
119,152✔
382
                              SUserObj *pOperUser) {
383
  if (pMnode == NULL || pReq == NULL || pCreate == NULL || pDb == NULL || pOperUser == NULL)
119,152✔
384
    return TSDB_CODE_INVALID_PARA;
×
385
  STrans *    pTrans = NULL;
119,152✔
386
  int32_t     code = 0;
119,152✔
387
  int32_t     lino = 0;
119,152✔
388
  SMqTopicObj topicObj = {0};
119,152✔
389

390
  PRINT_LOG_START
119,152✔
391
  mInfo("start to create topic:%s", pCreate->name);
119,152✔
392
  pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB, pReq, "create-topic");
119,152✔
393
  MND_TMQ_NULL_CHECK(pTrans);
119,152✔
394
  mndTransSetDbName(pTrans, pDb->name, NULL);
119,152✔
395
  MND_TMQ_RETURN_CHECK(mndTransCheckConflict(pMnode, pTrans));
119,152✔
396

397
  tstrncpy(topicObj.name, pCreate->name, TSDB_TOPIC_FNAME_LEN);
119,152✔
398
  tstrncpy(topicObj.db, pDb->name, TSDB_DB_FNAME_LEN);
119,152✔
399
  tstrncpy(topicObj.createUser, pOperUser->name, TSDB_USER_LEN);
119,152✔
400
  topicObj.ownerId = pOperUser->uid;
119,152✔
401

402
  // MND_TMQ_RETURN_CHECK(mndCheckTopicPrivilege(pMnode, RPC_MSG_USER(pReq), MND_OPER_CREATE_TOPIC, &topicObj));
403
  if (pDb) {
119,152✔
404
    // already checked in parser, just check db use privilege here
405
    MND_TMQ_RETURN_CHECK(
119,152✔
406
        mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_CREATE_TOPIC, pDb));
407
  }
408

409
  topicObj.createTime = taosGetTimestampMs();
119,152✔
410
  topicObj.updateTime = topicObj.createTime;
119,152✔
411
  topicObj.uid = mndGenerateUid(pCreate->name, strlen(pCreate->name));
119,152✔
412
  topicObj.dbUid = pDb->uid;
119,152✔
413
  topicObj.version = 1;
119,152✔
414
  topicObj.sql = taosStrdup(pCreate->sql);
119,152✔
415
  MND_TMQ_NULL_CHECK(topicObj.sql);
119,152✔
416
  topicObj.sqlLen = strlen(pCreate->sql) + 1;
119,152✔
417
  topicObj.subType = pCreate->subType;
119,152✔
418
  topicObj.withMeta = pCreate->withMeta;
119,152✔
419
  taosInitRWLatch(&topicObj.lock);
119,152✔
420

421
  MND_TMQ_RETURN_CHECK(processAst(&topicObj, pCreate->ast));
119,152✔
422

423
  if (pCreate->subStbName[0] != 0) {
119,152✔
424
    tstrncpy(topicObj.stbName, pCreate->subStbName, TSDB_TABLE_FNAME_LEN);
88,380✔
425
    SStbObj *pStb = mndAcquireStb(pMnode, topicObj.stbName);
88,380✔
426
    MND_TMQ_NULL_CHECK(pStb);
88,380✔
427
    char stbName[TSDB_TABLE_NAME_LEN] = {0};
86,978✔
428
    mndExtractTbNameFromStbFullName(pStb->name, stbName, TSDB_TABLE_NAME_LEN);
86,978✔
429
    MND_TMQ_RETURN_CHECK(
86,978✔
430
        mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_TOPIC_CREATE, PRIV_OBJ_DB, pStb->ownerId, pDb->name, NULL));
431
    MND_TMQ_RETURN_CHECK(
86,978✔
432
        mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_TBL_SELECT, PRIV_OBJ_TBL, pStb->ownerId, pDb->name, stbName));
433
    topicObj.stbUid = pStb->uid;
86,978✔
434
    mndReleaseStb(pMnode, pStb);
86,978✔
435
  }
436

437
  if (pCreate->subType == TOPIC_SUB_TYPE__DB) {
117,750✔
438
    MND_TMQ_RETURN_CHECK(
22,481✔
439
        mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_TOPIC_CREATE, PRIV_OBJ_DB, pDb->ownerId, pDb->name, NULL));
440
    MND_TMQ_RETURN_CHECK(mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_TBL_SELECT, PRIV_OBJ_TBL, 0, pDb->name, "*"));
22,481✔
441
  } else if (pCreate->subType == TOPIC_SUB_TYPE__COLUMN) {
95,269✔
442
    // TODO: check privilege on table
443
  }
444

445
  SSdbRaw *pCommitRaw = mndTopicActionEncode(&topicObj);
117,750✔
446
  MND_TMQ_NULL_CHECK(pCommitRaw);
117,750✔
447
  code = mndTransAppendCommitlog(pTrans, pCommitRaw);
117,750✔
448
  if (code != 0) {
117,750✔
449
    sdbFreeRaw(pCommitRaw);
×
450
    goto END;
×
451
  }
452

453
  MND_TMQ_RETURN_CHECK(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
117,750✔
454
  MND_TMQ_RETURN_CHECK(mndTransPrepare(pMnode, pTrans));
117,750✔
455

456
END:
119,152✔
457
  PRINT_LOG_END
119,152✔
458
  taosMemoryFreeClear(topicObj.sql);
119,152✔
459
  taosMemoryFreeClear(topicObj.physicalPlan);
119,152✔
460
  if (topicObj.schema.nCols) {
119,152✔
461
    taosMemoryFreeClear(topicObj.schema.pSchema);
92,171✔
462
  }
463
  mndTransDrop(pTrans);
119,152✔
464
  return code;
119,152✔
465
}
466

467
static int32_t mndReloadTopic(SMnode *pMnode, SRpcMsg *pReq, SCMCreateTopicReq *pCreate, SDbObj *pDb,
×
468
                              const char *userName, SMqTopicObj *topicObjOri) {
469
  if (pMnode == NULL || pReq == NULL || pCreate == NULL || pDb == NULL || userName == NULL)
×
470
    return TSDB_CODE_INVALID_PARA;
×
471
  STrans *    pTrans = NULL;
×
472
  int32_t     code = 0;
×
473
  int32_t     lino = 0;
×
474
  SMqTopicObj topicObj = {0};
×
475

476
  PRINT_LOG_START
×
477
  mInfo("start to reload topic:%s", pCreate->name);
×
478
  pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB, pReq, "reload-topic");
×
479
  MND_TMQ_NULL_CHECK(pTrans);
×
480
  mndTransSetDbName(pTrans, pDb->name, NULL);
×
481
  MND_TMQ_RETURN_CHECK(mndTransCheckConflict(pMnode, pTrans));
×
482

483
  tstrncpy(topicObj.name, pCreate->name, TSDB_TOPIC_FNAME_LEN);
×
484
  tstrncpy(topicObj.db, pDb->name, TSDB_DB_FNAME_LEN);
×
485
  tstrncpy(topicObj.createUser, userName, TSDB_USER_LEN);
×
486

487
  MND_TMQ_RETURN_CHECK(mndCheckTopicPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_CREATE_TOPIC, &topicObj));
×
488

489
  taosRLockLatch(&topicObjOri->lock);
×
490
  topicObj.createTime = topicObjOri->createTime;
×
491
  topicObj.updateTime = taosGetTimestampMs();
×
492
  topicObj.uid = topicObjOri->uid;
×
493
  topicObj.dbUid = pDb->uid;
×
494
  topicObj.version = topicObjOri->version + 1;
×
495
  topicObj.sql = taosStrdup(pCreate->sql);
×
496
  topicObj.sqlLen = strlen(pCreate->sql) + 1;
×
497
  topicObj.subType = pCreate->subType;
×
498
  topicObj.withMeta = pCreate->withMeta;
×
499
  taosInitRWLatch(&topicObj.lock);
×
500
  taosRUnLockLatch(&topicObjOri->lock);
×
501

502
  MND_TMQ_RETURN_CHECK(processAst(&topicObj, pCreate->ast));
×
503

504
  if (pCreate->subStbName[0] != 0) {
×
505
    tstrncpy(topicObj.stbName, pCreate->subStbName, TSDB_TABLE_FNAME_LEN);
×
506
    SStbObj *pStb = mndAcquireStb(pMnode, topicObj.stbName);
×
507
    MND_TMQ_NULL_CHECK(pStb);
×
508
    topicObj.stbUid = pStb->uid;
×
509
    mndReleaseStb(pMnode, pStb);
×
510
  }
511

512
  SSdbRaw *pCommitRaw = mndTopicActionEncode(&topicObj);
×
513
  MND_TMQ_NULL_CHECK(pCommitRaw);
×
514
  code = mndTransAppendCommitlog(pTrans, pCommitRaw);
×
515
  if (code != 0) {
×
516
    sdbFreeRaw(pCommitRaw);
×
517
    goto END;
×
518
  }
519

520
  MND_TMQ_RETURN_CHECK(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
×
521
  MND_TMQ_RETURN_CHECK(mndTransPrepare(pMnode, pTrans));
×
522

523
END:
×
524
  PRINT_LOG_END
×
525
  taosMemoryFreeClear(topicObj.sql);
×
526
  taosMemoryFreeClear(topicObj.physicalPlan);
×
527
  if (topicObj.schema.nCols) {
×
528
    taosMemoryFreeClear(topicObj.schema.pSchema);
×
529
  }
530
  mndTransDrop(pTrans);
×
531
  return code;
×
532
}
533

534
static int32_t creatTopic(SRpcMsg *pReq, SCMCreateTopicReq *createTopicReq, SUserObj *pOperUser) {
121,794✔
535
  SMqTopicObj *pTopic = NULL;
121,794✔
536
  SDbObj *     pDb = NULL;
121,794✔
537
  int32_t      code = TSDB_CODE_SUCCESS;
121,794✔
538
  int32_t      lino = 0;
121,794✔
539
  SMnode *     pMnode = pReq->info.node;
121,794✔
540
  int64_t      tss = taosGetTimestampMs();
121,794✔
541

542
  PRINT_LOG_START
121,794✔
543
  mInfo("topic:%s start to create, sql:%s", createTopicReq->name, createTopicReq->sql);
121,794✔
544
  code = mndAcquireTopic(pMnode, createTopicReq->name, &pTopic);
121,794✔
545
  if (code == TSDB_CODE_SUCCESS) {
121,794✔
546
    mndReleaseTopic(pMnode, pTopic);
672✔
547
    if (createTopicReq->igExists) {
672✔
548
      mInfo("topic:%s already exist, ignore exist is set", createTopicReq->name);
672✔
549
    } else {
550
      code = TSDB_CODE_MND_TOPIC_ALREADY_EXIST;
×
551
    }
552
    goto END;
672✔
553
  } else if (code != TSDB_CODE_MND_TOPIC_NOT_EXIST) {
121,122✔
554
    goto END;
×
555
  }
556

557
  pDb = mndAcquireDb(pMnode, createTopicReq->subDbName);
121,122✔
558
  MND_TMQ_NULL_CHECK(pDb);
121,122✔
559

560
  if (pDb->cfg.walRetentionPeriod == 0) {
120,494✔
561
    code = TSDB_CODE_MND_DB_RETENTION_PERIOD_ZERO;
×
562
    goto END;
×
563
  }
564

565
  if (sdbGetSize(pMnode->pSdb, SDB_TOPIC) >= tmqMaxTopicNum) {
120,494✔
566
    code = TSDB_CODE_TMQ_TOPIC_OUT_OF_RANGE;
1,342✔
567
    goto END;
1,342✔
568
  }
569

570
  MND_TMQ_RETURN_CHECK(grantCheck(TSDB_GRANT_SUBSCRIPTION));
119,152✔
571
  MND_TMQ_RETURN_CHECK(mndCreateTopic(pMnode, pReq, createTopicReq, pDb, pOperUser));
119,152✔
572
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
117,750✔
573
    int64_t tse = taosGetTimestampMs();
117,750✔
574
    double  duration = (double)(tse - tss);
117,750✔
575
    duration = duration / 1000;
117,750✔
576
    auditRecord(pReq, pMnode->clusterId, "createTopic", createTopicReq->subDbName, createTopicReq->name,
117,750✔
577
                createTopicReq->sql, strlen(createTopicReq->sql), duration, 0);
117,750✔
578
  }
579
  code = TSDB_CODE_ACTION_IN_PROGRESS;
117,750✔
580

581
END:
121,794✔
582
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
121,794✔
583
    mError("%s failed, topic:%s since %s", __func__, createTopicReq->name, tstrerror(code));
3,372✔
584
  } else {
585
    mInfo("topic:%s create successfully", createTopicReq->name);
118,422✔
586
  }
587
  mndReleaseDb(pMnode, pDb);
121,794✔
588
  return code;
121,794✔
589
}
590

591
static int32_t reloadTopic(SRpcMsg *pReq, SCMCreateTopicReq *createTopicReq) {
×
592
  SMnode *     pMnode = pReq->info.node;
×
593
  int32_t      code = TSDB_CODE_SUCCESS;
×
594
  int32_t      lino = 0;
×
595
  SDbObj *     pDb = NULL;
×
596
  SMqTopicObj *pTopic = NULL;
×
597
  int64_t      tss = taosGetTimestampMs();
×
598

599
  PRINT_LOG_START
×
600
  code = mndAcquireTopic(pMnode, createTopicReq->name, &pTopic);
×
601
  if (code != 0) {
×
602
    if (createTopicReq->igExists) {
×
603
      mInfo("topic:%s, not exist, ignore not exist is set", createTopicReq->name);
×
604
      code = 0;
×
605
      goto END;
×
606
    } else {
607
      mError("topic:%s, failed to reload since %s", createTopicReq->name, tstrerror(code));
×
608
      goto END;
×
609
    }
610
  }
611

612
  pDb = mndAcquireDb(pMnode, createTopicReq->subDbName);
×
613
  MND_TMQ_NULL_CHECK(pDb);
×
614

615
  MND_TMQ_RETURN_CHECK(grantCheck(TSDB_GRANT_SUBSCRIPTION));
×
616
  MND_TMQ_RETURN_CHECK(mndReloadTopic(pMnode, pReq, createTopicReq, pDb, RPC_MSG_USER(pReq), pTopic));
×
617

618
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
×
619
    int64_t tse = taosGetTimestampMs();
×
620
    double  duration = (double)(tse - tss);
×
621
    duration = duration / 1000;
×
622
    auditRecord(pReq, pMnode->clusterId, "reloadTopic", createTopicReq->subDbName, createTopicReq->name,
×
623
                createTopicReq->sql, strlen(createTopicReq->sql), duration, 0);
×
624
  }
625

626
  code = TSDB_CODE_ACTION_IN_PROGRESS;
×
627

628
  if (topicsToReload == NULL) {
×
629
    topicsToReload = taosHashInit(4, taosGetDefaultHashFunction(TSDB_DATA_TYPE_BINARY), true, HASH_NO_LOCK);
×
630
    MND_TMQ_NULL_CHECK(topicsToReload);
×
631
  }
632
  MND_TMQ_RETURN_CHECK(
×
633
      taosHashPut(topicsToReload, createTopicReq->name, strlen(createTopicReq->name), createTopicReq->name, 1));
634
  mInfo("topic:%s, marked to reload", createTopicReq->name);
×
635

636
END:
×
637
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
×
638
    mError("%s failed, topic:%s since %s", __func__, createTopicReq->name, tstrerror(code));
×
639
  } else {
640
    mInfo("topic:%s create successfully", createTopicReq->name);
×
641
  }
642
  mndReleaseTopic(pMnode, pTopic);
×
643
  mndReleaseDb(pMnode, pDb);
×
644

645
  return code;
×
646
}
647

648
static int32_t mndProcessCreateTopicReq(SRpcMsg *pReq) {
121,794✔
649
  if (pReq == NULL || pReq->contLen <= 0) {
121,794✔
650
    return TSDB_CODE_INVALID_MSG;
×
651
  }
652
  SMnode *pMnode = pReq->info.node;
121,794✔
653
  SUserObj *pOperUser = NULL;
121,794✔
654
  int32_t code = TSDB_CODE_SUCCESS;
121,794✔
655
  int32_t lino = 0;
121,794✔
656

657
  SCMCreateTopicReq createTopicReq = {0};
121,794✔
658

659
  PRINT_LOG_START
121,794✔
660
  MND_TMQ_RETURN_CHECK(tDeserializeSCMCreateTopicReq(pReq->pCont, pReq->contLen, &createTopicReq));
121,794✔
661

662
  if ((code = mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser)) != 0) goto END;
121,794✔
663

664
  mInfo("topic:%s start to create, sql:%s", createTopicReq.name, createTopicReq.sql);
121,794✔
665

666
  MND_TMQ_RETURN_CHECK(mndCheckCreateTopicReq(&createTopicReq));
121,794✔
667

668
  if (createTopicReq.reload) {
121,794✔
669
    MND_TMQ_RETURN_CHECK(reloadTopic(pReq, &createTopicReq));
×
670
  } else {
671
    MND_TMQ_RETURN_CHECK(creatTopic(pReq, &createTopicReq, pOperUser));
121,794✔
672
  }
673

674
END:
121,742✔
675
  tFreeSCMCreateTopicReq(&createTopicReq);
121,794✔
676
  mndReleaseUser(pMnode, pOperUser);
121,794✔
677
  return code;
121,794✔
678
}
679

680
static int32_t mndDropTopic(SMnode *pMnode, STrans *pTrans, SRpcMsg *pReq, SMqTopicObj *pTopic) {
94,595✔
681
  if (pMnode == NULL || pTrans == NULL || pReq == NULL || pTopic == NULL) {
94,595✔
682
    return TSDB_CODE_INVALID_MSG;
×
683
  }
684
  int32_t  code = 0;
94,595✔
685
  int32_t  lino = 0;
94,595✔
686
  SSdbRaw *pCommitRaw = NULL;
94,595✔
687
  PRINT_LOG_START
94,595✔
688
  char topicFName[TSDB_TOPIC_FNAME_LEN + 1] = {0};                       // 1.topic
94,595✔
689
  mndTopicGetShowName(pTopic->name, topicFName);
94,595✔
690
  char topicDbFName[TSDB_DB_NAME_LEN + TSDB_TOPIC_FNAME_LEN + 1] = {0};  // 1.db.topic
94,595✔
691
  (void)snprintf(topicDbFName, sizeof(topicDbFName), "%s.%s", pTopic->db, topicFName);
94,595✔
692
  MND_TMQ_RETURN_CHECK(mndUserRemoveTopic(pMnode, pTrans, topicDbFName));
94,595✔
693
  pCommitRaw = mndTopicActionEncode(pTopic);
94,595✔
694
  MND_TMQ_NULL_CHECK(pCommitRaw);
94,595✔
695
  code = mndTransAppendCommitlog(pTrans, pCommitRaw);
94,595✔
696
  if (code != 0) {
94,595✔
UNCOV
697
    sdbFreeRaw(pCommitRaw);
×
UNCOV
698
    goto END;
×
699
  }
700
  MND_TMQ_RETURN_CHECK(sdbSetRawStatus(pCommitRaw, SDB_STATUS_DROPPED));
94,595✔
701
  MND_TMQ_RETURN_CHECK(mndTransPrepare(pMnode, pTrans));
94,595✔
702

703
END:
94,595✔
704
  PRINT_LOG_END
94,595✔
705
  return code;
94,595✔
706
}
707

708
bool checkTopic(SArray *topics, char *topicName) {
97,740✔
709
  if (topics == NULL || topicName == NULL) {
97,740✔
UNCOV
710
    return false;
×
711
  }
712
  int32_t sz = taosArrayGetSize(topics);
97,740✔
713
  for (int32_t i = 0; i < sz; i++) {
98,346✔
714
    char *name = taosArrayGetP(topics, i);
1,886✔
715
    if (name && strcmp(name, topicName) == 0) {
1,886✔
716
      return true;
1,280✔
717
    }
718
  }
719
  return false;
96,460✔
720
}
721

722
static int32_t checkConsumer(STrans *pTrans, SMqConsumerObj *pConsumer, bool deleteConsumer, char *topicName) {
32,008✔
723
  int32_t         code = 0;
32,008✔
724
  int32_t         lino = 0;
32,008✔
725
  SMqConsumerObj *pConsumerNew = NULL;
32,008✔
726

727
  taosRLockLatch(&pConsumer->lock);
32,008✔
728
  bool found1 = checkTopic(pConsumer->assignedTopics, topicName);
32,008✔
729
  bool found2 = checkTopic(pConsumer->rebRemovedTopics, topicName);
32,008✔
730
  bool found3 = checkTopic(pConsumer->rebNewTopics, topicName);
32,008✔
731
  if (found1 || found2 || found3) {
32,008✔
732
    if (deleteConsumer) {
966✔
733
      MND_TMQ_RETURN_CHECK(tNewSMqConsumerObj(pConsumer->consumerId, pConsumer->cgroup, CONSUMER_CLEAR, NULL, NULL, &pConsumerNew));
662✔
734
      MND_TMQ_RETURN_CHECK(mndSetConsumerDropLogs(pTrans, pConsumerNew));
662✔
735
      tDeleteSMqConsumerObj(pConsumerNew);
662✔
736
      pConsumerNew = NULL;
662✔
737
    } else {
738
      mError("topic:%s, failed to drop since subscribed by consumer:0x%" PRIx64 ", in consumer group %s", topicName,
304✔
739
             pConsumer->consumerId, pConsumer->cgroup);
740
      code = TSDB_CODE_MND_TOPIC_SUBSCRIBED;
304✔
741
      goto END;
304✔
742
    }
743
  }
744
END:
32,008✔
745
  taosRUnLockLatch(&pConsumer->lock);
32,008✔
746
  tDeleteSMqConsumerObj(pConsumerNew);
32,008✔
747
  return code;
32,008✔
748
}
749

750
static int32_t mndCheckConsumerByTopic(SMnode *pMnode, STrans *pTrans, char *topicName, bool deleteConsumer) {
94,899✔
751
  if (pMnode == NULL || pTrans == NULL || topicName == NULL) {
94,899✔
UNCOV
752
    return TSDB_CODE_INVALID_MSG;
×
753
  }
754
  int32_t         code = 0;
94,899✔
755
  int32_t         lino = 0;
94,899✔
756
  SSdb *          pSdb = pMnode->pSdb;
94,899✔
757
  void *          pIter = NULL;
94,899✔
758
  SMqConsumerObj *pConsumer = NULL;
94,899✔
759

760
  PRINT_LOG_START
94,899✔
761
  while (1) {
762
    pIter = sdbFetch(pSdb, SDB_CONSUMER, pIter, (void **)&pConsumer);
126,603✔
763
    if (pIter == NULL) {
126,603✔
764
      break;
94,595✔
765
    }
766

767
    MND_TMQ_RETURN_CHECK(checkConsumer(pTrans, pConsumer, deleteConsumer, topicName));
32,008✔
768
    sdbRelease(pSdb, pConsumer);
31,704✔
769
  }
770

771
END:
94,899✔
772
  PRINT_LOG_END
94,899✔
773
  sdbRelease(pSdb, pConsumer);
94,899✔
774
  sdbCancelFetch(pSdb, pIter);
94,899✔
775
  return code;
94,899✔
776
}
777

778
static int32_t mndProcessDropTopicReq(SRpcMsg *pReq) {
102,168✔
779
  if (pReq == NULL) {
102,168✔
UNCOV
780
    return TSDB_CODE_INVALID_MSG;
×
781
  }
782
  SMnode *       pMnode = pReq->info.node;
102,168✔
783
  SMDropTopicReq dropReq = {0};
102,168✔
784
  int32_t        code = 0;
102,168✔
785
  int32_t        lino = 0;
102,168✔
786
  SMqTopicObj *  pTopic = NULL;
102,168✔
787
  STrans *       pTrans = NULL;
102,168✔
788
  SUserObj      *pOperUser = NULL;
102,168✔
789
  int64_t        tss = taosGetTimestampMs();
102,168✔
790

791
  PRINT_LOG_START
102,168✔
792
  MND_TMQ_RETURN_CHECK(tDeserializeSMDropTopicReq(pReq->pCont, pReq->contLen, &dropReq));
102,168✔
793

794
  code = mndAcquireTopic(pMnode, dropReq.name, &pTopic);
102,168✔
795
  if (code != 0) {
102,168✔
796
    if (dropReq.igNotExists) {
7,109✔
797
      mInfo("topic:%s, not exist, ignore not exist is set", dropReq.name);
7,109✔
798
      code = 0;
7,109✔
799
    }
800
    goto END;
7,109✔
801
  }
802
  taosRLockLatch(&pTopic->lock);
95,059✔
803

804
  pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB, pReq, "drop-topic");
95,059✔
805
  MND_TMQ_NULL_CHECK(pTrans);
95,059✔
806

807
  mndTransSetDbName(pTrans, pTopic->db, NULL);
95,059✔
808
  MND_TMQ_RETURN_CHECK(mndTransCheckConflict(pMnode, pTrans));
95,059✔
809
  mInfo("trans:%d, used to drop topic:%s, force:%d", pTrans->id, pTopic->name, dropReq.force);
95,059✔
810

811
  MND_TMQ_RETURN_CHECK(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser));
95,059✔
812

813
  // MND_TMQ_RETURN_CHECK(mndCheckTopicPrivilege(pMnode, RPC_MSG_USER(pReq), MND_OPER_DROP_TOPIC, pTopic));
814
  // MND_TMQ_RETURN_CHECK(mndCheckDbPrivilegeByName(pMnode, RPC_MSG_USER(pReq), MND_OPER_READ_DB, pTopic->db));
815
  MND_TMQ_RETURN_CHECK(
95,059✔
816
      mndCheckDbPrivilegeByName(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB, pTopic->db));
817
  MND_TMQ_RETURN_CHECK(mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_DROP, PRIV_OBJ_TOPIC, pTopic->ownerId,
95,059✔
818
                                                pTopic->db, mndGetDbStr(pTopic->name)));
819
  MND_TMQ_RETURN_CHECK(mndCheckConsumerByTopic(pMnode, pTrans, dropReq.name, dropReq.force));
94,899✔
820
  MND_TMQ_RETURN_CHECK(mndDropSubByTopic(pMnode, pTrans, dropReq.name, dropReq.force));
94,595✔
821
  MND_TMQ_RETURN_CHECK(mndDropTopic(pMnode, pTrans, pReq, pTopic));
94,595✔
822
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
94,595✔
823
    int64_t tse = taosGetTimestampMs();
94,595✔
824
    double  duration = (double)(tse - tss);
94,595✔
825
    duration = duration / 1000;
94,595✔
826
    auditRecord(pReq, pMnode->clusterId, "dropTopic", pTopic->db, dropReq.name, dropReq.sql, dropReq.sqlLen, duration,
94,595✔
827
                0);
828
  }
829

830
  code = TSDB_CODE_ACTION_IN_PROGRESS;
94,595✔
831

832
END:
102,168✔
833
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
102,168✔
834
    mError("%s failed, topic:%s since %s", __func__, dropReq.name, tstrerror(code));
464✔
835
  } else {
836
    mInfo("topic:%s dropped successfully", dropReq.name);
101,704✔
837
  }
838
  if (pTopic != NULL) {
102,168✔
839
    taosRUnLockLatch(&pTopic->lock);
95,059✔
840
  }
841
  mndReleaseTopic(pMnode, pTopic);
102,168✔
842
  mndReleaseUser(pMnode, pOperUser);
102,168✔
843
  mndTransDrop(pTrans);
102,168✔
844
  tFreeSMDropTopicReq(&dropReq);
102,168✔
845
  return code;
102,168✔
846
}
847

848
int32_t mndGetNumOfTopics(SMnode *pMnode, char *dbName, int32_t *pNumOfTopics) {
108,635✔
849
  if (pMnode == NULL || dbName == NULL || pNumOfTopics == NULL) {
108,635✔
UNCOV
850
    return TSDB_CODE_INVALID_MSG;
×
851
  }
852
  *pNumOfTopics = 0;
108,635✔
853

854
  SSdb *  pSdb = pMnode->pSdb;
108,635✔
855
  SDbObj *pDb = mndAcquireDb(pMnode, dbName);
108,635✔
856
  if (pDb == NULL) {
108,635✔
UNCOV
857
    return TSDB_CODE_MND_DB_NOT_SELECTED;
×
858
  }
859

860
  int32_t numOfTopics = 0;
108,635✔
861
  void *  pIter = NULL;
108,635✔
862
  while (1) {
×
863
    SMqTopicObj *pTopic = NULL;
108,635✔
864
    pIter = sdbFetch(pSdb, SDB_TOPIC, pIter, (void **)&pTopic);
108,635✔
865
    if (pIter == NULL) {
108,635✔
866
      break;
108,635✔
867
    }
UNCOV
868
    taosRLockLatch(&pTopic->lock);
×
UNCOV
869
    if (pTopic->dbUid == pDb->uid) {
×
UNCOV
870
      numOfTopics++;
×
871
    }
UNCOV
872
    taosRUnLockLatch(&pTopic->lock);
×
873

874
    sdbRelease(pSdb, pTopic);
×
875
  }
876

877
  *pNumOfTopics = numOfTopics;
108,635✔
878
  mndReleaseDb(pMnode, pDb);
108,635✔
879
  return 0;
108,635✔
880
}
881

882
static void schemaToJson(SSchema *schema, int32_t nCols, char *schemaJson) {
46,418✔
883
  if (schema == NULL || schemaJson == NULL) {
46,418✔
UNCOV
884
    return;
×
885
  }
886
  char *  string = NULL;
46,418✔
887
  int32_t code = 0;
46,418✔
888
  int32_t lino = 0;
46,418✔
889

890
  cJSON *cbytes = NULL;
46,418✔
891
  cJSON *ctype = NULL;
46,418✔
892
  cJSON *cname = NULL;
46,418✔
893
  cJSON *column = NULL;
46,418✔
894
  cJSON *columns = cJSON_CreateArray();
46,418✔
895
  MND_TMQ_NULL_CHECK(columns);
46,418✔
896
  for (int i = 0; i < nCols; i++) {
519,716✔
897
    column = cJSON_CreateObject();
473,298✔
898
    MND_TMQ_NULL_CHECK(column);
473,298✔
899
    SSchema *s = schema + i;
473,298✔
900
    cname = cJSON_CreateString(s->name);
473,298✔
901
    MND_TMQ_NULL_CHECK(cname);
473,298✔
902
    MND_TMQ_CONDITION_CHECK(cJSON_AddItemToObject(column, "name", cname), 0);
473,298✔
903
    cname = NULL;  // ownership transferred to column object
473,298✔
904

905
    ctype = cJSON_CreateString(tDataTypes[s->type].name);
473,298✔
906
    MND_TMQ_NULL_CHECK(ctype);
473,298✔
907
    MND_TMQ_CONDITION_CHECK(cJSON_AddItemToObject(column, "type", ctype), 0);
473,298✔
908
    ctype = NULL;  // ownership transferred to column object
473,298✔
909

910
    int32_t length = 0;
473,298✔
911
    if (s->type == TSDB_DATA_TYPE_BINARY || s->type == TSDB_DATA_TYPE_VARBINARY || s->type == TSDB_DATA_TYPE_GEOMETRY) {
473,298✔
912
      length = s->bytes - VARSTR_HEADER_SIZE;
88,484✔
913
    } else if (s->type == TSDB_DATA_TYPE_NCHAR || s->type == TSDB_DATA_TYPE_JSON) {
384,814✔
914
      length = (s->bytes - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE;
59,698✔
915
    } else {
916
      length = s->bytes;
325,116✔
917
    }
918
    cbytes = cJSON_CreateNumber(length);
473,298✔
919
    MND_TMQ_NULL_CHECK(cbytes);
473,298✔
920
    MND_TMQ_CONDITION_CHECK(cJSON_AddItemToObject(column, "length", cbytes), 0);
473,298✔
921
    cbytes = NULL;  // ownership transferred to column object
473,298✔
922

923
    MND_TMQ_CONDITION_CHECK(cJSON_AddItemToArray(columns, column), 0);
473,298✔
924
    column = NULL;  // ownership transferred to columns array
473,298✔
925
  }
926

927
END:
46,418✔
928
  string = cJSON_PrintUnformatted(columns);
46,418✔
929
  cJSON_Delete(columns);
46,418✔
930
  cJSON_Delete(column);
46,418✔
931
  cJSON_Delete(cname);
46,418✔
932
  cJSON_Delete(ctype);
46,418✔
933
  cJSON_Delete(cbytes);
46,418✔
934

935
  size_t len = strlen(string);
46,418✔
936
  if (string && len <= TSDB_SHOW_SCHEMA_JSON_LEN) {
46,418✔
937
    STR_TO_VARSTR(schemaJson, string);
46,418✔
938
  } else {
UNCOV
939
    mError("mndRetrieveTopic build schema error json:%p, json len:%zu", string, len);
×
UNCOV
940
    STR_TO_VARSTR(schemaJson, "NULL");
×
941
  }
942
  taosMemoryFree(string);
46,418✔
943
}
944

945
static int32_t buildResult(SMqTopicObj *pTopic, int32_t *numOfRows, SMnode *pMnode, SSDataBlock *pBlock) {
47,790✔
946
  SColumnInfoData *pColInfo = NULL;
47,790✔
947
  SName            n = {0};
47,790✔
948
  int32_t          cols = 0;
47,790✔
949
  char *           schemaJson = NULL;
47,790✔
950
  char *           sql = NULL;
47,790✔
951
  int32_t          code = 0;
47,790✔
952
  int32_t          lino = 0;
47,790✔
953

954
  taosRLockLatch(&pTopic->lock);
47,790✔
955

956
  char        topicName[TSDB_TOPIC_NAME_LEN + VARSTR_HEADER_SIZE + 5] = {0};
47,790✔
957
  const char *pName = mndGetDbStr(pTopic->name);
47,790✔
958
  STR_TO_VARSTR(topicName, pName);
47,790✔
959

960
  pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
47,790✔
961
  MND_TMQ_NULL_CHECK(pColInfo);
47,790✔
962
  MND_TMQ_RETURN_CHECK(colDataSetVal(pColInfo, *numOfRows, (const char *)topicName, false));
47,790✔
963

964
  char dbName[TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
47,790✔
965
  MND_TMQ_RETURN_CHECK(tNameFromString(&n, pTopic->db, T_NAME_ACCT | T_NAME_DB));
47,790✔
966
  MND_TMQ_RETURN_CHECK(tNameGetDbName(&n, varDataVal(dbName)));
47,790✔
967
  varDataSetLen(dbName, strlen(varDataVal(dbName)));
47,790✔
968

969
  pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
47,790✔
970
  MND_TMQ_NULL_CHECK(pColInfo);
47,790✔
971
  MND_TMQ_RETURN_CHECK(colDataSetVal(pColInfo, *numOfRows, (const char *)dbName, false));
47,790✔
972

973
  pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
47,790✔
974
  MND_TMQ_NULL_CHECK(pColInfo);
47,790✔
975
  MND_TMQ_RETURN_CHECK(colDataSetVal(pColInfo, *numOfRows, (const char *)&pTopic->createTime, false));
47,790✔
976

977
  sql = taosMemoryMalloc(strlen(pTopic->sql) + VARSTR_HEADER_SIZE);
47,790✔
978
  MND_TMQ_NULL_CHECK(sql);
47,790✔
979
  STR_TO_VARSTR(sql, pTopic->sql);
47,790✔
980

981
  pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
47,790✔
982
  MND_TMQ_NULL_CHECK(pColInfo);
47,790✔
983
  MND_TMQ_RETURN_CHECK(colDataSetVal(pColInfo, *numOfRows, (const char *)sql, false));
47,790✔
984

985
  taosMemoryFreeClear(sql);
47,790✔
986

987
  schemaJson = taosMemoryMalloc(TSDB_SHOW_SCHEMA_JSON_LEN + VARSTR_HEADER_SIZE);
47,790✔
988
  MND_TMQ_NULL_CHECK(schemaJson);
47,790✔
989
  if (pTopic->subType == TOPIC_SUB_TYPE__COLUMN) {
47,790✔
990
    schemaToJson(pTopic->schema.pSchema, pTopic->schema.nCols, schemaJson);
46,090✔
991
  } else if (pTopic->subType == TOPIC_SUB_TYPE__TABLE) {
1,700✔
992
    SStbObj *pStb = mndAcquireStb(pMnode, pTopic->stbName);
328✔
993
    if (pStb == NULL) {
328✔
UNCOV
994
      STR_TO_VARSTR(schemaJson, "NULL");
×
UNCOV
995
      mError("mndRetrieveTopic mndAcquireStb null stbName:%s", pTopic->stbName);
×
996
    } else {
997
      schemaToJson(pStb->pColumns, pStb->numOfColumns, schemaJson);
328✔
998
      mndReleaseStb(pMnode, pStb);
328✔
999
    }
1000
  } else {
1001
    STR_TO_VARSTR(schemaJson, "NULL");
1,372✔
1002
  }
1003

1004
  pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
47,790✔
1005
  MND_TMQ_NULL_CHECK(pColInfo);
47,790✔
1006
  MND_TMQ_RETURN_CHECK(colDataSetVal(pColInfo, *numOfRows, (const char *)schemaJson, false));
47,790✔
1007
  taosMemoryFreeClear(schemaJson);
47,790✔
1008

1009
  (*numOfRows)++;
47,790✔
1010

1011
END:
47,790✔
1012
  taosRUnLockLatch(&pTopic->lock);
47,790✔
1013

1014
  taosMemoryFreeClear(sql);
47,790✔
1015
  taosMemoryFreeClear(schemaJson);
47,790✔
1016
  return code;
47,790✔
1017
}
1018

1019
static int32_t mndRetrieveTopic(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rowsCapacity) {
17,175✔
1020
  if (pReq == NULL || pShow == NULL || pBlock == NULL) {
17,175✔
UNCOV
1021
    return TSDB_CODE_INVALID_MSG;
×
1022
  }
1023
  SMnode      *pMnode = pReq->info.node;
17,175✔
1024
  SSdb        *pSdb = pMnode->pSdb;
17,175✔
1025
  int32_t      numOfRows = 0;
17,175✔
1026
  SMqTopicObj *pTopic = NULL;
17,175✔
1027
  SUserObj    *pOperUser = NULL;
17,175✔
1028
  int32_t      code = 0, lino = 0;
17,175✔
1029
  char        *sql = NULL;
17,175✔
1030
  char        *schemaJson = NULL;
17,175✔
1031
  char         objFName[TSDB_OBJ_FNAME_LEN + 1] = {0};
17,175✔
1032
  bool         showAll = false;
17,175✔
1033

1034
  MND_TMQ_RETURN_CHECK(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser));
17,175✔
1035
  (void)snprintf(objFName, sizeof(objFName), "%d.*", pOperUser->acctId);
17,175✔
1036
  int32_t objLevel = privObjGetLevel(PRIV_OBJ_TOPIC);
17,175✔
1037
  showAll =
17,175✔
1038
      (0 == mndCheckSysObjPrivilege(pMnode, pOperUser, RPC_MSG_TOKEN(pReq), PRIV_CM_SHOW, PRIV_OBJ_TOPIC, 0, objFName,
17,175✔
1039
                                    objLevel == 0 ? NULL : "*"));  // 1.*.*
1040

1041
  PRINT_LOG_START
17,175✔
1042

1043
  while (numOfRows < rowsCapacity) {
64,965✔
1044
    pShow->pIter = sdbFetch(pSdb, SDB_TOPIC, pShow->pIter, (void **)&pTopic);
64,965✔
1045
    if (pShow->pIter == NULL) break;
64,965✔
1046

1047
    if (!showAll) {
47,790✔
UNCOV
1048
      if (mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_SHOW, PRIV_OBJ_TOPIC, pTopic->ownerId, pTopic->db,
×
UNCOV
1049
                                   objLevel == 0 ? NULL : mndGetDbStr(pTopic->name)) != 0) {  // 1.topic1
×
UNCOV
1050
        sdbRelease(pSdb, pTopic);
×
UNCOV
1051
        continue;
×
1052
      }
1053
    }
1054

1055
    MND_TMQ_RETURN_CHECK(buildResult(pTopic, &numOfRows, pMnode, pBlock));
47,790✔
1056
    sdbRelease(pSdb, pTopic);
47,790✔
1057
    pTopic = NULL;
47,790✔
1058
  }
1059
  pShow->numOfRows += numOfRows;
17,175✔
1060

1061
END:
17,175✔
1062
  sdbCancelFetch(pSdb, pShow->pIter);
17,175✔
1063
  sdbRelease(pSdb, pTopic);
17,175✔
1064
  mndReleaseUser(pMnode, pOperUser);
17,175✔
1065
  if (code != TSDB_CODE_SUCCESS) {
17,175✔
UNCOV
1066
    mError("%s failed since %s", __func__, tstrerror(code));
×
UNCOV
1067
    return code;
×
1068
  } else {
1069
    mDebug("%s retrieved %d rows successfully", __func__, numOfRows);
17,175✔
1070
    return numOfRows;
17,175✔
1071
  }
1072
}
1073

UNCOV
1074
static void mndCancelGetNextTopic(SMnode *pMnode, void *pIter) {
×
UNCOV
1075
  if (pMnode == NULL) return;
×
UNCOV
1076
  SSdb *pSdb = pMnode->pSdb;
×
UNCOV
1077
  sdbCancelFetchByType(pSdb, pIter, SDB_TOPIC);
×
1078
}
1079

1080
bool mndTopicExistsForDb(SMnode *pMnode, SDbObj *pDb) {
604,510✔
1081
  if (pMnode == NULL || pDb == NULL) {
604,510✔
1082
    return false;
×
1083
  }
1084
  SSdb *       pSdb = pMnode->pSdb;
604,510✔
1085
  void *       pIter = NULL;
604,510✔
1086
  SMqTopicObj *pTopic = NULL;
604,510✔
1087

1088
  while (1) {
48,869✔
1089
    pIter = sdbFetch(pSdb, SDB_TOPIC, pIter, (void **)&pTopic);
653,379✔
1090
    if (pIter == NULL) {
653,379✔
1091
      break;
604,176✔
1092
    }
1093

1094
    taosRLockLatch(&pTopic->lock);
49,203✔
1095
    bool found = pTopic->dbUid == pDb->uid;
49,203✔
1096
    taosRUnLockLatch(&pTopic->lock);
49,203✔
1097

1098
    if (found) {
49,203✔
1099
      sdbRelease(pSdb, pTopic);
334✔
1100
      sdbCancelFetch(pSdb, pIter);
334✔
1101
      return true;
334✔
1102
    }
1103

1104
    sdbRelease(pSdb, pTopic);
48,869✔
1105
  }
1106

1107
  return false;
604,176✔
1108
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc