• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4945

30 Jan 2026 06:19AM UTC coverage: 66.87% (+0.02%) from 66.849%
#4945

push

travis-ci

web-flow
merge: from main to 3.0 #34453

1126 of 2018 new or added lines in 72 files covered. (55.8%)

13708 existing lines in 159 files now uncovered.

205277 of 306978 relevant lines covered (66.87%)

126353544.65 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

76.48
/source/dnode/mnode/impl/src/mndIndex.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "mndIndex.h"
18
#include "mndDb.h"
19
#include "mndDnode.h"
20
#include "mndIndexComm.h"
21
#include "mndInfoSchema.h"
22
#include "mndMnode.h"
23
#include "mndPrivilege.h"
24
#include "mndShow.h"
25
#include "mndStb.h"
26
#include "mndStream.h"
27
#include "mndTrans.h"
28
#include "mndUser.h"
29
#include "mndVgroup.h"
30
#include "parser.h"
31
#include "tname.h"
32

33
#define TSDB_IDX_VER_NUMBER   1
34
#define TSDB_IDX_RESERVE_SIZE 32
35

36
static SSdbRaw *mndIdxActionEncode(SIdxObj *pSma);
37
static SSdbRow *mndIdxActionDecode(SSdbRaw *pRaw);
38
static int32_t  mndIdxActionInsert(SSdb *pSdb, SIdxObj *pIdx);
39
static int32_t  mndIdxActionDelete(SSdb *pSdb, SIdxObj *pIdx);
40
static int32_t  mndIdxActionUpdate(SSdb *pSdb, SIdxObj *pOld, SIdxObj *pNew);
41
static int32_t  mndProcessCreateIdxReq(SRpcMsg *pReq);
42
// static int32_t  mndProcessDropIdxReq(SRpcMsg *pReq);
43
static int32_t mndProcessGetIdxReq(SRpcMsg *pReq);
44
static int32_t mndProcessGetTbIdxReq(SRpcMsg *pReq);
45
// static int32_t mndRetrieveIdx(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
46
//  static void    mndCancelGetNextIdx(SMnode *pMnode, void *pIter);
47
static void mndDestroyIdxObj(SIdxObj *pIdxObj);
48

49
static int32_t mndAddIndex(SMnode *pMnode, SRpcMsg *pReq, SCreateTagIndexReq *req, SDbObj *pDb, SStbObj *pStb,
50
                           SUserObj *pOp);
51

52
int32_t mndInitIdx(SMnode *pMnode) {
399,351✔
53
  SSdbTable table = {
399,351✔
54
      .sdbType = SDB_IDX,
55
      .keyType = SDB_KEY_BINARY,
56
      .encodeFp = (SdbEncodeFp)mndIdxActionEncode,
57
      .decodeFp = (SdbDecodeFp)mndIdxActionDecode,
58
      .insertFp = (SdbInsertFp)mndIdxActionInsert,
59
      .updateFp = (SdbUpdateFp)mndIdxActionUpdate,
60
      .deleteFp = (SdbDeleteFp)mndIdxActionDelete,
61
  };
62

63
  mndSetMsgHandle(pMnode, TDMT_MND_CREATE_INDEX, mndProcessCreateIdxReq);
399,351✔
64
  // mndSetMsgHandle(pMnode, TDMT_MND_DROP_INDEX, mndProcessDropIdxReq);
65

66
  mndSetMsgHandle(pMnode, TDMT_VND_CREATE_INDEX_RSP, mndTransProcessRsp);
399,351✔
67
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_INDEX_RSP, mndTransProcessRsp);
399,351✔
68

69
  // mndSetMsgHandle(pMnode, TDMT_MND_CREATE_SMA, mndProcessCreateIdxReq);
70
  // mndSetMsgHandle(pMnode, TDMT_MND_DROP_SMA, mndProcessDropIdxReq);
71
  // mndSetMsgHandle(pMnode, TDMT_VND_CREATE_SMA_RSP, mndTransProcessRsp);
72
  // mndSetMsgHandle(pMnode, TDMT_VND_DROP_SMA_RSP, mndTransProcessRsp);
73
  // mndSetMsgHandle(pMnode, TDMT_MND_GET_INDEX, mndProcessGetIdxReq);
74
  // mndSetMsgHandle(pMnode, TDMT_MND_GET_TABLE_INDEX, mndProcessGetTbIdxReq);
75

76
  // type same with sma
77
  // mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_INDEX, mndRetrieveIdx);
78
  // mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_INDEX, mndCancelGetNextIdx);
79
  return sdbSetTable(pMnode->pSdb, table);
399,351✔
80
}
81

82
static int32_t mndFindSuperTableTagId(const SStbObj *pStb, const char *tagName, int8_t *hasIdx) {
9,137✔
83
  for (int32_t tag = 0; tag < pStb->numOfTags; tag++) {
19,351✔
84
    if (taosStrcasecmp(pStb->pTags[tag].name, tagName) == 0) {
19,351✔
85
      if (IS_IDX_ON(&pStb->pTags[tag])) {
9,137✔
86
        *hasIdx = 1;
4,287✔
87
      }
88
      return tag;
9,137✔
89
    }
90
  }
91

92
  return TSDB_CODE_MND_TAG_NOT_EXIST;
×
93
}
94

95
int mndSetCreateIdxRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb, SIdxObj *pIdx) {
2,425✔
96
  int32_t code = 0;
2,425✔
97
  SSdb   *pSdb = pMnode->pSdb;
2,425✔
98
  SVgObj *pVgroup = NULL;
2,425✔
99
  void   *pIter = NULL;
2,425✔
100
  int32_t contLen;
2,425✔
101

102
  while (1) {
5,895✔
103
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
8,320✔
104
    if (pIter == NULL) break;
8,320✔
105
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
5,895✔
106
      sdbRelease(pSdb, pVgroup);
1,565✔
107
      continue;
1,565✔
108
    }
109

110
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, NULL, 0);
4,330✔
111
    if (pReq == NULL) {
4,330✔
112
      sdbCancelFetch(pSdb, pIter);
×
113
      sdbRelease(pSdb, pVgroup);
×
114
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
115
      if (terrno != 0) code = terrno;
×
116
      TAOS_RETURN(code);
×
117
    }
118
    STransAction action = {0};
4,330✔
119
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
4,330✔
120
    action.pCont = pReq;
4,330✔
121
    action.contLen = contLen;
4,330✔
122
    action.msgType = TDMT_VND_CREATE_INDEX;
4,330✔
123
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
4,330✔
124
      taosMemoryFree(pReq);
×
125
      sdbCancelFetch(pSdb, pIter);
×
126
      sdbRelease(pSdb, pVgroup);
×
127
      TAOS_RETURN(code);
×
128
    }
129
    sdbRelease(pSdb, pVgroup);
4,330✔
130
  }
131

132
  return 0;
2,425✔
133
}
134
static void *mndBuildDropIdxReq(SMnode *pMnode, SVgObj *pVgroup, SStbObj *pStbObj, SIdxObj *pIdx, int32_t *contLen) {
2,858✔
135
  int32_t len = 0;
2,858✔
136

137
  SDropIndexReq req = {0};
2,858✔
138
  memcpy(req.colName, pIdx->colName, sizeof(pIdx->colName));
2,858✔
139
  memcpy(req.stb, pIdx->stb, sizeof(pIdx->stb));
2,858✔
140
  req.dbUid = pIdx->dbUid;
2,858✔
141
  req.stbUid = pIdx->stbUid;
2,858✔
142

143
  mInfo("idx: %s start to build drop index req", pIdx->name);
2,858✔
144

145
  len = tSerializeSDropIdxReq(NULL, 0, &req);
2,858✔
146
  if (len < 0) {
2,858✔
147
    goto _err;
×
148
  }
149

150
  len += sizeof(SMsgHead);
2,858✔
151
  SMsgHead *pHead = taosMemoryCalloc(1, len);
2,858✔
152
  if (pHead == NULL) {
2,858✔
153
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
154
    goto _err;
×
155
  }
156

157
  pHead->contLen = htonl(len);
2,858✔
158
  pHead->vgId = htonl(pVgroup->vgId);
2,858✔
159

160
  void   *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
2,858✔
161
  int32_t ret = 0;
2,858✔
162
  if ((ret = tSerializeSDropIdxReq(pBuf, len - sizeof(SMsgHead), &req)) < 0) {
2,858✔
163
    terrno = ret;
×
164
    return NULL;
×
165
  }
166
  *contLen = len;
2,858✔
167
  return pHead;
2,858✔
168
_err:
×
169

170
  return NULL;
×
171
}
172
int mndSetDropIdxRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb, SIdxObj *pIdx) {
1,429✔
173
  int32_t code = 0;
1,429✔
174
  SSdb   *pSdb = pMnode->pSdb;
1,429✔
175
  SVgObj *pVgroup = NULL;
1,429✔
176
  void   *pIter = NULL;
1,429✔
177
  int32_t contLen;
178

179
  while (1) {
2,858✔
180
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
4,287✔
181
    if (pIter == NULL) break;
4,287✔
182
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
2,858✔
183
      sdbRelease(pSdb, pVgroup);
×
184
      continue;
×
185
    }
186

187
    int32_t len;
2,858✔
188
    void   *pReq = mndBuildDropIdxReq(pMnode, pVgroup, pStb, pIdx, &len);
2,858✔
189
    if (pReq == NULL) {
2,858✔
190
      sdbCancelFetch(pSdb, pIter);
×
191
      sdbRelease(pSdb, pVgroup);
×
192
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
193
      if (terrno != 0) code = terrno;
×
194
      return code;
×
195
    }
196
    STransAction action = {0};
2,858✔
197
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
2,858✔
198
    action.pCont = pReq;
2,858✔
199
    action.contLen = len;
2,858✔
200
    action.msgType = TDMT_VND_DROP_INDEX;
2,858✔
201
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
2,858✔
202
      taosMemoryFree(pReq);
×
203
      sdbCancelFetch(pSdb, pIter);
×
204
      sdbRelease(pSdb, pVgroup);
×
205
      return code;
×
206
    }
207
    sdbRelease(pSdb, pVgroup);
2,858✔
208
  }
209

210
  TAOS_RETURN(code);
1,429✔
211
}
212

213
void mndCleanupIdx(SMnode *pMnode) {
399,293✔
214
  // do nothing
215
  return;
399,293✔
216
}
217

218
static SSdbRaw *mndIdxActionEncode(SIdxObj *pIdx) {
4,166,879✔
219
  int32_t code = 0;
4,166,879✔
220
  int32_t lino = 0;
4,166,879✔
221
  terrno = TSDB_CODE_OUT_OF_MEMORY;
4,166,879✔
222

223
  // int32_t size =
224
  //     sizeof(SSmaObj) + pSma->exprLen + pSma->tagsFilterLen + pSma->sqlLen + pSma->astLen + TSDB_IDX_RESERVE_SIZE;
225
  int32_t size = sizeof(SIdxObj) + TSDB_IDX_RESERVE_SIZE;
4,166,879✔
226

227
  SSdbRaw *pRaw = sdbAllocRaw(SDB_IDX, TSDB_IDX_VER_NUMBER, size);
4,166,879✔
228
  if (pRaw == NULL) goto _OVER;
4,166,879✔
229

230
  int32_t dataPos = 0;
4,166,879✔
231
  SDB_SET_BINARY(pRaw, dataPos, pIdx->name, TSDB_TABLE_FNAME_LEN, _OVER)
4,166,879✔
232
  SDB_SET_BINARY(pRaw, dataPos, pIdx->stb, TSDB_TABLE_FNAME_LEN, _OVER)
4,166,879✔
233
  SDB_SET_BINARY(pRaw, dataPos, pIdx->db, TSDB_DB_FNAME_LEN, _OVER)
4,166,879✔
234
  SDB_SET_BINARY(pRaw, dataPos, pIdx->dstTbName, TSDB_DB_FNAME_LEN, _OVER)
4,166,879✔
235
  SDB_SET_BINARY(pRaw, dataPos, pIdx->colName, TSDB_COL_NAME_LEN, _OVER)
4,166,879✔
236
  SDB_SET_INT64(pRaw, dataPos, pIdx->createdTime, _OVER)
4,166,879✔
237
  SDB_SET_INT64(pRaw, dataPos, pIdx->uid, _OVER)
4,166,879✔
238
  SDB_SET_INT64(pRaw, dataPos, pIdx->stbUid, _OVER)
4,166,879✔
239
  SDB_SET_INT64(pRaw, dataPos, pIdx->dbUid, _OVER)
4,166,879✔
240

241
  SDB_SET_BINARY(pRaw, dataPos, pIdx->createUser, TSDB_USER_LEN, _OVER)
4,166,879✔
242
  SDB_SET_INT64(pRaw, dataPos, pIdx->ownerId, _OVER)
4,166,879✔
243
  SDB_SET_RESERVE(pRaw, dataPos, TSDB_IDX_RESERVE_SIZE, _OVER)
4,166,879✔
244
  SDB_SET_DATALEN(pRaw, dataPos, _OVER)
4,166,879✔
245

246
  terrno = 0;
4,166,879✔
247

248
_OVER:
4,166,879✔
249
  if (terrno != 0) {
4,166,879✔
250
    mError("idx:%s, failed to encode to raw:%p since %s", pIdx->name, pRaw, terrstr());
×
251
    sdbFreeRaw(pRaw);
×
252
    return NULL;
×
253
  }
254

255
  mTrace("idx:%s, encode to raw:%p, row:%p", pIdx->name, pRaw, pIdx);
4,166,879✔
256
  return pRaw;
4,166,879✔
257
}
258

259
static SSdbRow *mndIdxActionDecode(SSdbRaw *pRaw) {
3,061,684✔
260
  int32_t code = 0;
3,061,684✔
261
  int32_t lino = 0;
3,061,684✔
262
  terrno = TSDB_CODE_OUT_OF_MEMORY;
3,061,684✔
263
  SSdbRow *pRow = NULL;
3,061,684✔
264
  SIdxObj *pIdx = NULL;
3,061,684✔
265

266
  int8_t sver = 0;
3,061,684✔
267
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) goto _OVER;
3,061,684✔
268

269
  if (sver != TSDB_IDX_VER_NUMBER) {
3,061,684✔
270
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
271
    goto _OVER;
×
272
  }
273

274
  pRow = sdbAllocRow(sizeof(SIdxObj));
3,061,684✔
275
  if (pRow == NULL) goto _OVER;
3,061,684✔
276

277
  pIdx = sdbGetRowObj(pRow);
3,061,684✔
278
  if (pIdx == NULL) goto _OVER;
3,061,684✔
279

280
  int32_t dataPos = 0;
3,061,684✔
281

282
  SDB_GET_BINARY(pRaw, dataPos, pIdx->name, TSDB_TABLE_FNAME_LEN, _OVER)
3,061,684✔
283
  SDB_GET_BINARY(pRaw, dataPos, pIdx->stb, TSDB_TABLE_FNAME_LEN, _OVER)
3,061,684✔
284
  SDB_GET_BINARY(pRaw, dataPos, pIdx->db, TSDB_DB_FNAME_LEN, _OVER)
3,061,684✔
285
  SDB_GET_BINARY(pRaw, dataPos, pIdx->dstTbName, TSDB_DB_FNAME_LEN, _OVER)
3,061,684✔
286
  SDB_GET_BINARY(pRaw, dataPos, pIdx->colName, TSDB_COL_NAME_LEN, _OVER)
3,061,684✔
287
  SDB_GET_INT64(pRaw, dataPos, &pIdx->createdTime, _OVER)
3,061,684✔
288
  SDB_GET_INT64(pRaw, dataPos, &pIdx->uid, _OVER)
3,061,684✔
289
  SDB_GET_INT64(pRaw, dataPos, &pIdx->stbUid, _OVER)
3,061,684✔
290
  SDB_GET_INT64(pRaw, dataPos, &pIdx->dbUid, _OVER)
3,061,684✔
291
  SDB_GET_BINARY(pRaw, dataPos, pIdx->createUser, TSDB_USER_LEN, _OVER)
3,061,684✔
292
  SDB_GET_INT64(pRaw, dataPos, &pIdx->ownerId, _OVER)
3,061,684✔
293
  SDB_GET_RESERVE(pRaw, dataPos, TSDB_IDX_RESERVE_SIZE, _OVER)
3,061,684✔
294

295
  terrno = 0;
3,061,684✔
296

297
_OVER:
3,061,684✔
298
  if (terrno != 0) {
3,061,684✔
299
    taosMemoryFree(pRow);
×
300
    return NULL;
×
301
  }
302

303
  mTrace("idx:%s, decode from raw:%p, row:%p", pIdx->name, pRaw, pIdx);
3,061,684✔
304
  return pRow;
3,061,684✔
305
}
306

307
static int32_t mndIdxActionInsert(SSdb *pSdb, SIdxObj *pIdx) {
2,070,791✔
308
  mTrace("idx:%s, perform insert action, row:%p", pIdx->name, pIdx);
2,070,791✔
309
  return 0;
2,070,791✔
310
}
311

312
static int32_t mndIdxActionDelete(SSdb *pSdb, SIdxObj *pIdx) {
3,061,684✔
313
  mTrace("idx:%s, perform delete action, row:%p", pIdx->name, pIdx);
3,061,684✔
314
  return 0;
3,061,684✔
315
}
316

317
static int32_t mndIdxActionUpdate(SSdb *pSdb, SIdxObj *pOld, SIdxObj *pNew) {
34,919✔
318
  // lock no not
319
  if (strncmp(pOld->colName, pNew->colName, TSDB_COL_NAME_LEN) != 0) {
34,919✔
320
    memcpy(pOld->colName, pNew->colName, sizeof(pNew->colName));
13,431✔
321
  }
322
  pOld->ownerId = pNew->ownerId;
34,919✔
323
  mTrace("idx:%s, perform update action, old row:%p new row:%p", pOld->name, pOld, pNew);
34,919✔
324
  return 0;
34,919✔
325
}
326

327
SIdxObj *mndAcquireIdx(SMnode *pMnode, char *idxName) {
×
328
  SSdb    *pSdb = pMnode->pSdb;
×
329
  SIdxObj *pIdx = sdbAcquire(pSdb, SDB_IDX, idxName);
×
330
  if (pIdx == NULL && terrno == TSDB_CODE_SDB_OBJ_NOT_THERE) {
×
331
    terrno = TSDB_CODE_MND_TAG_INDEX_NOT_EXIST;
×
332
  }
333
  return pIdx;
×
334
}
335

336
void mndReleaseIdx(SMnode *pMnode, SIdxObj *pIdx) {
9,206✔
337
  SSdb *pSdb = pMnode->pSdb;
9,206✔
338
  sdbRelease(pSdb, pIdx);
9,206✔
339
}
9,206✔
340

341
SDbObj *mndAcquireDbByIdx(SMnode *pMnode, const char *idxName) {
1,429✔
342
  SName name = {0};
1,429✔
343
  if ((terrno = tNameFromString(&name, idxName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) < 0) return NULL;
1,429✔
344

345
  char db[TSDB_TABLE_FNAME_LEN] = {0};
1,429✔
346
  (void)tNameGetFullDbName(&name, db);
1,429✔
347

348
  return mndAcquireDb(pMnode, db);
1,429✔
349
}
350

351
int32_t mndSetCreateIdxPrepareLogs(SMnode *pMnode, STrans *pTrans, SIdxObj *pIdx) {
2,425✔
352
  int32_t  code = 0;
2,425✔
353
  SSdbRaw *pRedoRaw = mndIdxActionEncode(pIdx);
2,425✔
354
  if (pRedoRaw == NULL) {
2,425✔
355
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
356
    if (terrno != 0) code = terrno;
×
357
    return -1;
×
358
  }
359
  TAOS_CHECK_RETURN(mndTransAppendPrepareLog(pTrans, pRedoRaw));
2,425✔
360
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_CREATING));
2,425✔
361

362
  TAOS_RETURN(code);
2,425✔
363
}
364

365
int32_t mndSetCreateIdxCommitLogs(SMnode *pMnode, STrans *pTrans, SIdxObj *pIdx) {
1,618,962✔
366
  int32_t  code = 0;
1,618,962✔
367
  SSdbRaw *pCommitRaw = mndIdxActionEncode(pIdx);
1,618,962✔
368
  if (pCommitRaw == NULL) {
1,618,962✔
369
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
370
    if (terrno != 0) code = terrno;
×
371
    return -1;
×
372
  }
373
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
1,618,962✔
374
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
1,618,962✔
375

376
  TAOS_RETURN(code);
1,618,962✔
377
}
378

379
int32_t mndSetAlterIdxPrepareLogs(SMnode *pMnode, STrans *pTrans, SIdxObj *pIdx) {
13,101✔
380
  int32_t  code = 0;
13,101✔
381
  SSdbRaw *pRedoRaw = mndIdxActionEncode(pIdx);
13,101✔
382
  if (pRedoRaw == NULL) {
13,101✔
383
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
384
    if (terrno != 0) code = terrno;
×
385
    return -1;
×
386
  }
387
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
13,101✔
388
    sdbFreeRaw(pRedoRaw);
×
389
    return -1;
×
390
  }
391
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_READY));
13,101✔
392

393
  TAOS_RETURN(code);
13,101✔
394
}
395

396
int32_t mndSetAlterIdxCommitLogs(SMnode *pMnode, STrans *pTrans, SIdxObj *pIdx) {
13,101✔
397
  int32_t  code = 0;
13,101✔
398
  SSdbRaw *pCommitRaw = mndIdxActionEncode(pIdx);
13,101✔
399
  if (pCommitRaw == NULL) {
13,101✔
400
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
401
    if (terrno != 0) code = terrno;
×
402
    TAOS_RETURN(code);
×
403
  }
404
  if ((code = mndTransAppendCommitlog(pTrans, pCommitRaw)) != 0) {
13,101✔
405
    sdbFreeRaw(pCommitRaw);
×
406
    TAOS_RETURN(code);
×
407
  }
408
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
13,101✔
409

410
  TAOS_RETURN(code);
13,101✔
411
}
412

413
static int32_t mndSetCreateIdxVgroupRedoLogs(SMnode *pMnode, STrans *pTrans, SVgObj *pVgroup) {
×
414
  int32_t  code = 0;
×
415
  SSdbRaw *pVgRaw = mndVgroupActionEncode(pVgroup);
×
416
  if (pVgRaw == NULL) {
×
417
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
418
    if (terrno != 0) code = terrno;
×
419
    TAOS_RETURN(code);
×
420
  }
421
  TAOS_CHECK_RETURN(mndTransAppendRedolog(pTrans, pVgRaw));
×
422
  TAOS_CHECK_RETURN(sdbSetRawStatus(pVgRaw, SDB_STATUS_CREATING));
×
423
  TAOS_RETURN(code);
×
424
}
425

426
static int32_t mndSetCreateIdxVgroupCommitLogs(SMnode *pMnode, STrans *pTrans, SVgObj *pVgroup) {
×
427
  int32_t  code = 0;
×
428
  SSdbRaw *pVgRaw = mndVgroupActionEncode(pVgroup);
×
429
  if (pVgRaw == NULL) {
×
430
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
431
    if (terrno != 0) code = terrno;
×
432
    TAOS_RETURN(code);
×
433
  }
434
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pVgRaw));
×
435
  TAOS_CHECK_RETURN(sdbSetRawStatus(pVgRaw, SDB_STATUS_READY));
×
436
  TAOS_RETURN(code);
×
437
}
438

439
// static int32_t mndSetUpdateIdxStbCommitLogs(SMnode *pMnode, STrans *pTrans, SStbObj *pStb) {
440
//   SStbObj stbObj = {0};
441
//   taosRLockLatch(&pStb->lock);
442
//   memcpy(&stbObj, pStb, sizeof(SStbObj));
443
//   taosRUnLockLatch(&pStb->lock);
444
//   stbObj.numOfColumns = 0;
445
//   stbObj.pColumns = NULL;
446
//   stbObj.numOfTags = 0;
447
//  stbObj.pTags = NULL;
448
//   stbObj.numOfFuncs = 0;
449
//   stbObj.pFuncs = NULL;
450
//   stbObj.updateTime = taosGetTimestampMs();
451
//   stbObj.lock = 0;
452
//   stbObj.tagVer++;
453

454
// SSdbRaw *pCommitRaw = mndStbActionEncode(&stbObj);
455
// if (pCommitRaw == NULL) return -1;
456
// if (mndTransAppendCommitlog(pTrans, pCommitRaw) != 0) return -1;
457
// if (sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY) != 0) return -1;
458
//
459
// return 0;
460
//}
461

462
static void mndDestroyIdxObj(SIdxObj *pIdxObj) {
×
463
  if (pIdxObj) {
464
    // do nothing
465
  }
466
}
×
467

468
static int32_t mndProcessCreateIdxReq(SRpcMsg *pReq) {
7,422✔
469
  SMnode   *pMnode = pReq->info.node;
7,422✔
470
  int32_t   code = -1;
7,422✔
471
  SStbObj  *pStb = NULL;
7,422✔
472
  SIdxObj  *pIdx = NULL;
7,422✔
473
  SUserObj *pOperUser = NULL;
7,422✔
474

475
  SDbObj            *pDb = NULL;
7,422✔
476
  SCreateTagIndexReq createReq = {0};
7,422✔
477

478
  TAOS_CHECK_GOTO(tDeserializeSCreateTagIdxReq(pReq->pCont, pReq->contLen, &createReq), NULL, _OVER);
7,422✔
479

480
  mInfo("idx:%s start to create", createReq.idxName);
7,422✔
481
  // if (mndCheckCreateIdxReq(&createReq) != 0) {
482
  //   goto _OVER;
483
  // }
484

485
  pDb = mndAcquireDbByStb(pMnode, createReq.stbName);
7,422✔
486
  if (pDb == NULL) {
7,422✔
487
    code = TSDB_CODE_MND_DB_NOT_EXIST;
×
488
    if (terrno != 0) code = terrno;
×
489
    goto _OVER;
×
490
  }
491

492
  if (pDb->cfg.isMount) {
7,422✔
493
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
×
494
    goto _OVER;
×
495
  }
496

497
  pStb = mndAcquireStb(pMnode, createReq.stbName);
7,422✔
498
  if (pStb == NULL) {
7,422✔
499
    mError("idx:%s, failed to create since stb:%s not exist", createReq.idxName, createReq.stbName);
×
500
    code = TSDB_CODE_MND_DB_NOT_EXIST;
×
501
    if (terrno != 0) code = terrno;
×
502
    goto _OVER;
×
503
  }
504
  SSIdx idx = {0};
7,422✔
505
  if ((code = mndAcquireGlobalIdx(pMnode, createReq.idxName, SDB_IDX, &idx)) == 0) {
7,422✔
506
    pIdx = idx.pIdx;
7,422✔
507
  } else {
508
    goto _OVER;
×
509
  }
510
  if (pIdx != NULL) {
7,422✔
511
    code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
2,139✔
512
    goto _OVER;
2,139✔
513
  }
514

515
  TAOS_CHECK_GOTO(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser), NULL, _OVER);
5,283✔
516
  // already check select table/create index privileges in parser
517
  TAOS_CHECK_GOTO(mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB, pDb), NULL, _OVER);
5,283✔
518
  // TAOS_CHECK_GOTO(mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), MND_OPER_WRITE_DB, pDb), NULL, _OVER);
519

520
  code = mndAddIndex(pMnode, pReq, &createReq, pDb, pStb, pOperUser);
5,283✔
521
  if (terrno == TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST || terrno == TSDB_CODE_MND_TAG_NOT_EXIST) {
5,283✔
522
    return terrno;
2,858✔
523
  } else {
524
    if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
2,425✔
525
  }
526

527
_OVER:
4,564✔
528
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
4,564✔
529
    mError("stb:%s, failed to create since %s", createReq.idxName, tstrerror(code));
2,139✔
530
  }
531

532
  mndReleaseStb(pMnode, pStb);
4,564✔
533
  mndReleaseIdx(pMnode, pIdx);
4,564✔
534
  mndReleaseDb(pMnode, pDb);
4,564✔
535
  mndReleaseUser(pMnode, pOperUser);
4,564✔
536

537
  TAOS_RETURN(code);
4,564✔
538
}
539

540
int32_t mndSetDropIdxPrepareLogs(SMnode *pMnode, STrans *pTrans, SIdxObj *pIdx) {
5,632✔
541
  int32_t  code = 0;
5,632✔
542
  SSdbRaw *pRedoRaw = mndIdxActionEncode(pIdx);
5,632✔
543
  if (pRedoRaw == NULL) {
5,632✔
544
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
545
    if (terrno != 0) code = terrno;
×
UNCOV
546
    TAOS_RETURN(code);
×
547
  }
548
  TAOS_CHECK_RETURN(mndTransAppendPrepareLog(pTrans, pRedoRaw));
5,632✔
549
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_DROPPING));
5,632✔
550

551
  TAOS_RETURN(code);
5,632✔
552
}
553

554
int32_t mndSetDropIdxCommitLogs(SMnode *pMnode, STrans *pTrans, SIdxObj *pIdx) {
953,987✔
555
  int32_t  code = 0;
953,987✔
556
  SSdbRaw *pCommitRaw = mndIdxActionEncode(pIdx);
953,987✔
557
  if (pCommitRaw == NULL) {
953,987✔
558
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
559
    if (terrno != 0) code = terrno;
×
UNCOV
560
    TAOS_RETURN(code);
×
561
  }
562
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
953,987✔
563
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_DROPPED));
953,987✔
564

565
  TAOS_RETURN(code);
953,987✔
566
}
567

UNCOV
568
static int32_t mndProcessGetTbIdxReq(SRpcMsg *pReq) {
×
569
  //
UNCOV
570
  return 0;
×
571
}
572

573
int32_t mndRetrieveTagIdx(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
5,540✔
574
  SMnode   *pMnode = pReq->info.node;
5,540✔
575
  SSdb     *pSdb = pMnode->pSdb;
5,540✔
576
  int32_t   numOfRows = 0;
5,540✔
577
  SIdxObj  *pIdx = NULL;
5,540✔
578
  SUserObj *pOperUser = NULL;
5,540✔
579
  int32_t   cols = 0;
5,540✔
580
  int32_t   code = 0;
5,540✔
581
  int32_t   lino = 0;
5,540✔
582
  char      objFName[TSDB_OBJ_FNAME_LEN + 1] = {0};
5,540✔
583
  bool      showAll = false;
5,540✔
584

585
  SDbObj *pDb = NULL;
5,540✔
586
  if (strlen(pShow->db) > 0) {
5,540✔
587
    pDb = mndAcquireDb(pMnode, pShow->db);
3,048✔
588
    if (pDb == NULL) return 0;
3,048✔
589
  }
590

591
  TAOS_CHECK_GOTO(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser), &lino, _OVER);
5,540✔
592
  (void)snprintf(objFName, sizeof(objFName), "%d.*", pOperUser->acctId);
5,540✔
593
  int32_t objLevel = privObjGetLevel(PRIV_OBJ_IDX);
5,540✔
594
  showAll =
5,540✔
595
      (0 == mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_SHOW, PRIV_OBJ_IDX, 0, pDb ? pDb->name : objFName,
5,540✔
596
                                     objLevel == 0 ? NULL : "*"));  // 1.*.*
597

598
  SSmaAndTagIter *pIter = pShow->pIter;
5,540✔
599
  while (numOfRows < rows) {
15,933✔
600
    pIter->pIdxIter = sdbFetch(pSdb, SDB_IDX, pIter->pIdxIter, (void **)&pIdx);
15,933✔
601
    if (pIter->pIdxIter == NULL) break;
15,933✔
602

603
    if (NULL != pDb && pIdx->dbUid != pDb->uid) {
10,393✔
604
      sdbRelease(pSdb, pIdx);
1,092✔
605
      continue;
1,092✔
606
    }
607

608
    if (!showAll) {
9,301✔
609
      SName idxName = {0};
×
610
      if ((code = tNameFromString(&idxName, pIdx->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
×
611
        sdbRelease(pSdb, pIdx);
×
612
        sdbCancelFetch(pSdb, pIter->pIdxIter);
×
613
        lino = __LINE__;
×
UNCOV
614
        goto _OVER;
×
615
      }
NEW
616
      if (mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_SHOW, PRIV_OBJ_IDX, pIdx->ownerId, pIdx->db,
×
617
                                   objLevel == 0 ? NULL : idxName.tname)) {  // 1.db1.idx1
618
        sdbRelease(pSdb, pIdx);
×
UNCOV
619
        continue;
×
620
      }
621
    }
622

623
    cols = 0;
9,301✔
624

625
    SName idxName = {0};
9,301✔
626
    if ((code = tNameFromString(&idxName, pIdx->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
9,301✔
627
      sdbRelease(pSdb, pIdx);
×
628
      sdbCancelFetch(pSdb, pIter->pIdxIter);
×
UNCOV
629
      goto _OVER;
×
630
    }
631
    char n1[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
9,301✔
632

633
    STR_TO_VARSTR(n1, (char *)tNameGetTableName(&idxName));
9,301✔
634

635
    char n2[TSDB_DB_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
9,301✔
636
    STR_TO_VARSTR(n2, (char *)mndGetDbStr(pIdx->db));
9,301✔
637

638
    SName stbName = {0};
9,301✔
639
    if ((code = tNameFromString(&stbName, pIdx->stb, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
9,301✔
640
      sdbRelease(pSdb, pIdx);
×
641
      sdbCancelFetch(pSdb, pIter->pIdxIter);
×
UNCOV
642
      goto _OVER;
×
643
    }
644
    char n3[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
9,301✔
645
    STR_TO_VARSTR(n3, (char *)tNameGetTableName(&stbName));
9,301✔
646

647
    SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
9,301✔
648
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)n1, false), pIdx, &lino, _OVER);
9,301✔
649

650
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
9,301✔
651
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)n2, false), pIdx, &lino, _OVER);
9,301✔
652

653
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
9,301✔
654
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)n3, false), pIdx, &lino, _OVER);
9,301✔
655

656
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
9,301✔
657

658
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, NULL, true), pIdx, &lino, _OVER);
9,301✔
659

660
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
9,301✔
661
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pIdx->createdTime, false), pIdx, &lino,
9,301✔
662
                        _OVER);
663

664
    char col[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
9,301✔
665
    STR_TO_VARSTR(col, (char *)pIdx->colName);
9,301✔
666

667
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
9,301✔
668
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)col, false), pIdx, &lino, _OVER);
9,301✔
669

670
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
9,301✔
671

672
    char tag[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
9,301✔
673
    STR_TO_VARSTR(tag, (char *)"tag_index");
9,301✔
674
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)tag, false), pIdx, &lino, _OVER);
9,301✔
675

676
    numOfRows++;
9,301✔
677
    sdbRelease(pSdb, pIdx);
9,301✔
678
  }
679

680
_OVER:
5,540✔
681
  if (code != 0) mError("failed to retrieve at line:%d, since %s", lino, tstrerror(code));
5,540✔
682

683
  mndReleaseDb(pMnode, pDb);
5,540✔
684
  mndReleaseUser(pMnode, pOperUser);
5,540✔
685
  pShow->numOfRows += numOfRows;
5,540✔
686
  return numOfRows;
5,540✔
687
}
688

689
// static void mndCancelGetNextIdx(SMnode *pMnode, void *pIter) {
690
//   SSdb *pSdb = pMnode->pSdb;
691
//
692
//  sdbCancelFetch(pSdb, pIter);
693
//}
UNCOV
694
static int32_t mndCheckIndexReq(SCreateTagIndexReq *pReq) {
×
695
  // impl
UNCOV
696
  return TSDB_CODE_SUCCESS;
×
697
}
698

699
static int32_t mndSetUpdateIdxStbCommitLogs(SMnode *pMnode, STrans *pTrans, SStbObj *pOld, SStbObj *pNew, char *tagName,
3,854✔
700
                                            int on) {
701
  int32_t code = 0;
3,854✔
702
  taosRLockLatch(&pOld->lock);
3,854✔
703
  memcpy(pNew, pOld, sizeof(SStbObj));
3,854✔
704
  taosRUnLockLatch(&pOld->lock);
3,854✔
705

706
  pNew->pTags = NULL;
3,854✔
707
  pNew->pColumns = NULL;
3,854✔
708
  pNew->pCmpr = NULL;
3,854✔
709
  pNew->pTags = NULL;
3,854✔
710
  pNew->pExtSchemas = NULL;
3,854✔
711
  pNew->updateTime = taosGetTimestampMs();
3,854✔
712
  pNew->lock = 0;
3,854✔
713

714
  int8_t  hasIdx = 0;
3,854✔
715
  int32_t tag = mndFindSuperTableTagId(pOld, tagName, &hasIdx);
3,854✔
716
  if (tag < 0) {
3,854✔
717
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
×
UNCOV
718
    TAOS_RETURN(code);
×
719
  }
720
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
3,854✔
721
  SSchema *pTag = pNew->pTags + tag;
3,854✔
722

723
  if (on == 1) {
3,854✔
724
    if (hasIdx && tag != 0) {
2,425✔
725
      code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
×
UNCOV
726
      TAOS_RETURN(code);
×
727
    } else {
728
      SSCHMEA_SET_IDX_ON(pTag);
2,425✔
729
    }
730
  } else {
731
    if (hasIdx == 0) {
1,429✔
UNCOV
732
      code = TSDB_CODE_MND_SMA_NOT_EXIST;
×
733
    } else {
734
      SSCHMEA_SET_IDX_OFF(pTag);
1,429✔
735
      pTag->flags = 0;
1,429✔
736
    }
737
  }
738
  pNew->tagVer++;
3,854✔
739

740
  SSdbRaw *pCommitRaw = mndStbActionEncode(pNew);
3,854✔
741
  if (pCommitRaw == NULL) {
3,854✔
742
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
743
    if (terrno != 0) code = terrno;
×
UNCOV
744
    TAOS_RETURN(code);
×
745
  }
746
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
3,854✔
747
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
3,854✔
748

749
  TAOS_RETURN(code);
3,854✔
750
}
751
int32_t mndAddIndexImpl(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, SIdxObj *pIdx) {
2,425✔
752
  // impl later
753
  int32_t code = -1;
2,425✔
754
  SStbObj newStb = {0};
2,425✔
755
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "create-stb-index");
2,425✔
756
  if (pTrans == NULL) goto _OVER;
2,425✔
757

758
  // mInfo("trans:%d, used to add index to stb:%s", pTrans->id, pStb->name);
759
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
2,425✔
760
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
2,425✔
761

762
  mndTransSetSerial(pTrans);
2,425✔
763

764
  TAOS_CHECK_GOTO(mndSetCreateIdxPrepareLogs(pMnode, pTrans, pIdx), NULL, _OVER);
2,425✔
765
  TAOS_CHECK_GOTO(mndSetCreateIdxCommitLogs(pMnode, pTrans, pIdx), NULL, _OVER);
2,425✔
766

767
  TAOS_CHECK_GOTO(mndSetUpdateIdxStbCommitLogs(pMnode, pTrans, pStb, &newStb, pIdx->colName, 1), NULL, _OVER);
2,425✔
768
  TAOS_CHECK_GOTO(mndSetCreateIdxRedoActions(pMnode, pTrans, pDb, &newStb, pIdx), NULL, _OVER);
2,425✔
769

770
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
2,425✔
771

772
  code = 0;
2,425✔
773

774
_OVER:
2,425✔
775
  // mndDestoryIdxObj(pIdx);
776
  if (newStb.pTags != NULL) {
2,425✔
777
    taosMemoryFree(newStb.pTags);
2,425✔
778
    taosMemoryFree(newStb.pColumns);
2,425✔
779
    taosMemoryFree(newStb.pCmpr);
2,425✔
780
    taosMemoryFreeClear(newStb.pExtSchemas);
2,425✔
781
  }
782
  mndTransDrop(pTrans);
2,425✔
783
  TAOS_RETURN(code);
2,425✔
784
}
785
int8_t mndCheckIndexNameByTagName(SMnode *pMnode, SIdxObj *pIdxObj) {
2,145✔
786
  // build index on first tag, and no index name;
787
  int8_t  exist = 0;
2,145✔
788
  SDbObj *pDb = NULL;
2,145✔
789
  if (strlen(pIdxObj->db) > 0) {
2,145✔
790
    pDb = mndAcquireDb(pMnode, pIdxObj->db);
2,145✔
791
    if (pDb == NULL) return 0;
2,145✔
792
  }
793
  SSmaAndTagIter *pIter = NULL;
2,145✔
794
  SIdxObj        *pIdx = NULL;
2,145✔
795
  SSdb           *pSdb = pMnode->pSdb;
2,145✔
796

797
  while (1) {
798
    pIter = sdbFetch(pSdb, SDB_IDX, pIter, (void **)&pIdx);
3,577✔
799
    if (pIter == NULL) break;
3,577✔
800

801
    if (NULL != pDb && pIdx->dbUid != pDb->uid) {
3,577✔
802
      sdbRelease(pSdb, pIdx);
×
UNCOV
803
      continue;
×
804
    }
805
    if (pIdxObj->stbUid != pIdx->stbUid) {
3,577✔
806
      sdbRelease(pSdb, pIdx);
×
UNCOV
807
      continue;
×
808
    }
809
    if (strncmp(pIdxObj->colName, pIdx->colName, TSDB_COL_NAME_LEN) == 0) {
3,577✔
810
      sdbCancelFetch(pSdb, pIter);
2,145✔
811
      sdbRelease(pSdb, pIdx);
2,145✔
812
      exist = 1;
2,145✔
813
      break;
2,145✔
814
    }
815
    sdbRelease(pSdb, pIdx);
1,432✔
816
  }
817

818
  mndReleaseDb(pMnode, pDb);
2,145✔
819
  return exist;
2,145✔
820
}
821
static int32_t mndAddIndex(SMnode *pMnode, SRpcMsg *pReq, SCreateTagIndexReq *req, SDbObj *pDb, SStbObj *pStb,
5,283✔
822
                           SUserObj *pOperUser) {
823
  int32_t code = -1;
5,283✔
824
  SIdxObj idxObj = {0};
5,283✔
825
  memcpy(idxObj.name, req->idxName, TSDB_INDEX_FNAME_LEN);
5,283✔
826
  memcpy(idxObj.stb, pStb->name, TSDB_TABLE_FNAME_LEN);
5,283✔
827
  memcpy(idxObj.db, pDb->name, TSDB_DB_FNAME_LEN);
5,283✔
828
  memcpy(idxObj.colName, req->colName, TSDB_COL_NAME_LEN);
5,283✔
829
  (void)snprintf(idxObj.createUser, TSDB_USER_LEN, "%s", pOperUser->name);
5,283✔
830
  idxObj.ownerId = pOperUser->uid;
5,283✔
831

832
  idxObj.createdTime = taosGetTimestampMs();
5,283✔
833
  idxObj.uid = mndGenerateUid(req->idxName, strlen(req->idxName));
5,283✔
834
  idxObj.stbUid = pStb->uid;
5,283✔
835
  idxObj.dbUid = pStb->dbUid;
5,283✔
836
  
837

838
  int8_t  hasIdx = 0;
5,283✔
839
  int32_t tag = mndFindSuperTableTagId(pStb, req->colName, &hasIdx);
5,283✔
840
  if (tag < 0) {
5,283✔
841
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
×
UNCOV
842
    TAOS_RETURN(code);
×
843
  }
844
  int8_t exist = 0;
5,283✔
845
  if (tag == 0 && hasIdx == 1) {
5,283✔
846
    exist = mndCheckIndexNameByTagName(pMnode, &idxObj);
2,145✔
847
    if (exist) {
2,145✔
848
      code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
2,145✔
849
      TAOS_RETURN(code);
2,145✔
850
    }
851
  } else if (hasIdx == 1) {
3,138✔
852
    code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
713✔
853
    TAOS_RETURN(code);
713✔
854
  }
855

856
  code = mndAddIndexImpl(pMnode, pReq, pDb, pStb, &idxObj);
2,425✔
857
  TAOS_RETURN(code);
2,425✔
858
}
859

860
static int32_t mndDropIdx(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SIdxObj *pIdx) {
1,429✔
861
  int32_t  code = -1;
1,429✔
862
  SStbObj *pStb = NULL;
1,429✔
863
  STrans  *pTrans = NULL;
1,429✔
864

865
  SStbObj newObj = {0};
1,429✔
866

867
  pStb = mndAcquireStb(pMnode, pIdx->stb);
1,429✔
868
  if (pStb == NULL) {
1,429✔
869
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
870
    if (terrno != 0) code = terrno;
×
UNCOV
871
    goto _OVER;
×
872
  }
873

874
  pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB, pReq, "drop-index");
1,429✔
875
  if (pTrans == NULL) {
1,429✔
876
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
877
    if (terrno != 0) code = terrno;
×
UNCOV
878
    goto _OVER;
×
879
  }
880

881
  mInfo("trans:%d, used to drop idx:%s", pTrans->id, pIdx->name);
1,429✔
882
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
1,429✔
883
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
1,429✔
884

885
  mndTransSetSerial(pTrans);
1,429✔
886
  TAOS_CHECK_GOTO(mndSetDropIdxPrepareLogs(pMnode, pTrans, pIdx), NULL, _OVER);
1,429✔
887
  TAOS_CHECK_GOTO(mndSetDropIdxCommitLogs(pMnode, pTrans, pIdx), NULL, _OVER);
1,429✔
888

889
  TAOS_CHECK_GOTO(mndSetUpdateIdxStbCommitLogs(pMnode, pTrans, pStb, &newObj, pIdx->colName, 0), NULL, _OVER);
1,429✔
890
  TAOS_CHECK_GOTO(mndSetDropIdxRedoActions(pMnode, pTrans, pDb, &newObj, pIdx), NULL, _OVER);
1,429✔
891
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
1,429✔
892

893
  code = 0;
1,429✔
894

895
_OVER:
1,429✔
896
  taosMemoryFree(newObj.pTags);
1,429✔
897
  taosMemoryFree(newObj.pColumns);
1,429✔
898
  taosMemoryFree(newObj.pCmpr);
1,429✔
899
  taosMemoryFreeClear(newObj.pExtSchemas);
1,429✔
900

901
  mndTransDrop(pTrans);
1,429✔
902
  mndReleaseStb(pMnode, pStb);
1,429✔
903
  TAOS_RETURN(code);
1,429✔
904
}
905
int32_t mndProcessDropTagIdxReq(SRpcMsg *pReq) {
3,213✔
906
  SMnode   *pMnode = pReq->info.node;
3,213✔
907
  int32_t   code = -1;
3,213✔
908
  SDbObj   *pDb = NULL;
3,213✔
909
  SIdxObj  *pIdx = NULL;
3,213✔
910
  SUserObj *pOperUser = NULL;
3,213✔
911

912
  SDropTagIndexReq req = {0};
3,213✔
913
  TAOS_CHECK_GOTO(tDeserializeSDropTagIdxReq(pReq->pCont, pReq->contLen, &req), NULL, _OVER);
3,213✔
914
  mInfo("idx:%s, start to drop", req.name);
3,213✔
915
  SSIdx idx = {0};
3,213✔
916
  if ((code = mndAcquireGlobalIdx(pMnode, req.name, SDB_IDX, &idx)) == 0) {
3,213✔
917
    pIdx = idx.pIdx;
3,213✔
918
  } else {
UNCOV
919
    goto _OVER;
×
920
  }
921
  if (pIdx == NULL) {
3,213✔
922
    if (req.igNotExists) {
1,784✔
923
      mInfo("idx:%s, not exist, ignore not exist is set", req.name);
×
924
      code = 0;
×
UNCOV
925
      goto _OVER;
×
926
    } else {
927
      code = TSDB_CODE_MND_TAG_INDEX_NOT_EXIST;
1,784✔
928
      goto _OVER;
1,784✔
929
    }
930
  }
931

932
  pDb = mndAcquireDbByIdx(pMnode, req.name);
1,429✔
933
  if (pDb == NULL) {
1,429✔
934
    terrno = TSDB_CODE_MND_DB_NOT_SELECTED;
×
935
    if (terrno != 0) code = terrno;
×
UNCOV
936
    goto _OVER;
×
937
  }
938

939
  if(pDb->cfg.isMount) {
1,429✔
940
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
×
UNCOV
941
    goto _OVER;
×
942
  }
943

944
  // TAOS_CHECK_GOTO(mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), MND_OPER_WRITE_DB, pDb), NULL, _OVER);
945
  TAOS_CHECK_GOTO(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser), NULL, _OVER);
1,429✔
946
  TAOS_CHECK_GOTO(
1,429✔
947
      mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_DROP, PRIV_OBJ_IDX, pIdx->ownerId, pIdx->db, pIdx->name),
948
      NULL, _OVER);
949

950
  code = mndDropIdx(pMnode, pReq, pDb, pIdx);
1,429✔
951
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
1,429✔
952

953
_OVER:
3,213✔
954
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
3,213✔
955
    mError("idx:%s, failed to drop since %s", req.name, tstrerror(code));
1,784✔
956
  }
957
  mndReleaseIdx(pMnode, pIdx);
3,213✔
958
  mndReleaseDb(pMnode, pDb);
3,213✔
959
  mndReleaseUser(pMnode, pOperUser);
3,213✔
960
  TAOS_RETURN(code);
3,213✔
961
}
UNCOV
962
static int32_t mndProcessGetIdxReq(SRpcMsg *pReq) {
×
963
  // do nothing
UNCOV
964
  return 0;
×
965
}
966

967
int32_t mndDropIdxsByStb(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
433,738✔
968
  int32_t code = 0;
433,738✔
969
  SSdb   *pSdb = pMnode->pSdb;
433,738✔
970
  void   *pIter = NULL;
433,738✔
971

972
  while (1) {
4,699,083✔
973
    SIdxObj *pIdx = NULL;
5,132,821✔
974
    pIter = sdbFetch(pSdb, SDB_IDX, pIter, (void **)&pIdx);
5,132,821✔
975
    if (pIter == NULL) break;
5,132,821✔
976

977
    if (pIdx->stbUid == pStb->uid) {
4,699,083✔
978
      if ((code = mndSetDropIdxCommitLogs(pMnode, pTrans, pIdx)) != 0) {
433,738✔
979
        sdbCancelFetch(pSdb, pIter);
×
980
        sdbRelease(pSdb, pIdx);
×
UNCOV
981
        TAOS_RETURN(code);
×
982
      }
983
    }
984

985
    sdbRelease(pSdb, pIdx);
4,699,083✔
986
  }
987

988
  TAOS_RETURN(code);
433,738✔
989
}
990

991
int32_t mndGetIdxsByTagName(SMnode *pMnode, SStbObj *pStb, char *tagName, SIdxObj *idx) {
197,220✔
992
  SSdb *pSdb = pMnode->pSdb;
197,220✔
993
  void *pIter = NULL;
197,220✔
994

995
  while (1) {
590,043✔
996
    SIdxObj *pIdx = NULL;
787,263✔
997
    pIter = sdbFetch(pSdb, SDB_IDX, pIter, (void **)&pIdx);
787,263✔
998
    if (pIter == NULL) break;
787,263✔
999

1000
    if (pIdx->stbUid == pStb->uid && taosStrcasecmp(pIdx->colName, tagName) == 0) {
607,347✔
1001
      memcpy((char *)idx, (char *)pIdx, sizeof(SIdxObj));
17,304✔
1002
      sdbRelease(pSdb, pIdx);
17,304✔
1003
      sdbCancelFetch(pSdb, pIter);
17,304✔
1004
      return 0;
17,304✔
1005
    }
1006

1007
    sdbRelease(pSdb, pIdx);
590,043✔
1008
  }
1009

1010
  return -1;
179,916✔
1011
}
1012
int32_t mndDropIdxsByDb(SMnode *pMnode, STrans *pTrans, SDbObj *pDb) {
604,626✔
1013
  int32_t code = 0;
604,626✔
1014
  SSdb   *pSdb = pMnode->pSdb;
604,626✔
1015
  void   *pIter = NULL;
604,626✔
1016

1017
  while (1) {
977,503✔
1018
    SIdxObj *pIdx = NULL;
1,582,129✔
1019
    pIter = sdbFetch(pSdb, SDB_IDX, pIter, (void **)&pIdx);
1,582,129✔
1020
    if (pIter == NULL) break;
1,582,129✔
1021

1022
    if (pIdx->dbUid == pDb->uid) {
977,503✔
1023
      if ((code = mndSetDropIdxCommitLogs(pMnode, pTrans, pIdx)) != 0) {
514,617✔
1024
        sdbRelease(pSdb, pIdx);
×
1025
        sdbCancelFetch(pSdb, pIter);
×
UNCOV
1026
        TAOS_RETURN(code);
×
1027
      }
1028
    }
1029

1030
    sdbRelease(pSdb, pIdx);
977,503✔
1031
  }
1032

1033
  TAOS_RETURN(code);
604,626✔
1034
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc