21108840797

Committed 18 Jan 2026 08:35AM UTC coverage: 60.508% (+0.02%) from 60.492%

Build # 21108840797

Build Type

push

github

Committed by

web-flow

Commit Message

ClangTidy readability-else-after-return (#857)

* trigger tidy

* Automated clang-tidy change: readability-else-after-return

* compile test

* rerun

* Automated clang-tidy change: readability-else-after-return

* trigger..

* Automated clang-tidy change: readability-else-after-return

* manually removed a few

* Automated clang-tidy change: readability-else-after-return

* removed duplicate code

* fix remaining warnings

* fixed scope

---------

Co-authored-by: Clang Tidy <clang-tidy@users.noreply.github.com>

Coverage Stats

837 of 1874 new or added lines in 151 files covered. (44.66%)

46 existing lines in 25 files now uncovered.

44448 of 73458 relevant lines covered (60.51%)

525066.38 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

51.08

/pol-core/pol/multi/house.cpp

/** @file
 *
 * @par History
 * - 2005/06/06 Shinigami: added readobjects - to get a list of statics
 * - 2005/11/26 Shinigami: changed "strcmp" into "stricmp" to suppress Script Errors
 * - 2009/09/03 MuadDib:   Relocation of multi related cpp/h
 * - 2009/09/14 MuadDib:   Squatters code added to register.unregister mobs.
 * - 2009/09/15 MuadDib:   Better cleanup handling on house destroy. Alos clears registered_house
 * off character.
 *                         Houses now only allow mobiles to be registered. May add items later for
 * other storage.
 * - 2012/02/02 Tomi:      Added boat member MBR_MULTIID
 */

#include "house.h"

#include <boost/numeric/conversion/cast.hpp>
#include <iterator>
#include <stdlib.h>

#include "../../bscript/berror.h"
#include "../../bscript/executor.h"
#include "../../bscript/objmembers.h"
#include "../../bscript/objmethods.h"
#include "../../clib/cfgelem.h"
#include "../../clib/clib_endian.h"
#include "../../clib/logfacility.h"
#include "../../clib/passert.h"
#include "../../clib/refptr.h"
#include "../../clib/stlutil.h"
#include "../../clib/streamsaver.h"
#include "../../plib/mapcell.h"
#include "../../plib/mapshape.h"
#include "../../plib/systemstate.h"
#include "../../plib/uconst.h"
#include "../core.h"
#include "../fnsearch.h"
#include "../globals/object_storage.h"
#include "../globals/uvars.h"
#include "../item/itemdesc.h"
#include "../mobile/charactr.h"
#include "../module/uomod.h"
#include "../network/cgdata.h"
#include "../network/client.h"
#include "../realms/realm.h"
#include "../syshookscript.h"
#include "../ufunc.h"
#include "../uobject.h"
#include "../uoexec.h"
#include "../uoscrobj.h"
#include "../uworld.h"
#include "base/range.h"
#include "customhouses.h"
#include "multi.h"
#include "multidef.h"


namespace Pol::Multi
{
Core::Range3d UHouse::current_box() const
{
  if ( IsCustom() )
  {
    const MultiDef& md = multidef();
    return Core::Range3d( pos() + md.minrxyz, pos() + md.maxrxyz + Core::Vec2d( 0, 1 ) );
  }

  return base::current_box();
}

ItemList UHouse::get_working_design_items( UHouse* house )
{
  ItemList itemlist;
  MobileList moblist;
  bool was_editing = house->editing;
  house->editing = false;
  UHouse::list_contents( house, itemlist, moblist );
  house->editing = was_editing;
  return itemlist;
}

void UHouse::list_contents( const UHouse* house, ItemList& items_in, MobileList& chrs_in )
{
  auto box = house->current_box();
  Core::WorldIterator<Core::MobileFilter>::InBox(
      box.range(), house->realm(),
      [&]( Mobile::Character* chr )
      {
        UMulti* multi = house->realm()->find_supporting_multi( chr->pos3d() );
        if ( const_cast<const UMulti*>( multi ) == house )
          chrs_in.push_back( chr );
      } );
  Core::WorldIterator<Core::ItemFilter>::InBox(
      box.range(), house->realm(),
      [&]( Items::Item* item )
      {
        UMulti* multi = house->realm()->find_supporting_multi( item->pos3d() );
        if ( const_cast<const UMulti*>( multi ) == house )
        {
          if ( Plib::tile_flags( item->graphic ) & Plib::FLAG::WALKBLOCK )
            items_in.push_front( item );
          else
            items_in.push_back( item );
        }
      } );
}

UHouse::UHouse( const Items::ItemDesc& itemdesc )
    : UMulti( itemdesc ),
      editing( false ),
      waiting_for_accept( false ),
      editing_floor_num( 1 ),
      revision( 0 ),
      custom( false )
{
}

size_t UHouse::estimatedSize() const
{
  size_t size = base::estimatedSize() + CurrentDesign.estimatedSize() +
                WorkingDesign.estimatedSize() + BackupDesign.estimatedSize() +
                Clib::memsize( CurrentCompressed ) + Clib::memsize( WorkingCompressed ) +
                sizeof( bool )   /*editing*/
                + sizeof( bool ) /*waiting_for_accept*/
                + sizeof( int )  /*editing_floor_num*/
                + sizeof( u32 )  /*revision*/
                + sizeof( bool ) /*custom*/
                // no estimateSize here element is in objhash
                + Clib::memsize( squatters_ ) + Clib::memsize( components_ );
  return size;
}

/**
 * Creates dynamic house components from MultiDef (multis.cfg at the time of writing)
 */
void UHouse::create_components()
{
  const MultiDef& md = multidef();
  for ( unsigned i = 0; i < md.elems.size(); ++i )
  {
    const MULTI_ELEM& elem = md.elems[i];
    if ( !elem.is_static )
    {
      Items::Item* item = Items::Item::create( elem.objtype );
      bool res = add_component( item, elem.relpos.x(), elem.relpos.y(), elem.relpos.z() );
      passert_always_r( res,
                        "Couldn't add newly created item as house component. Please report this "
                        "bug on the forums." );
    }
  }
}

/**
 * Moves the item into the house, adding it as house component
 * (change item coordinates, set it unmovable, etc...)
 *
 * @param item Pointer to the item to be added
 * @param xoff The X offset inside the house
 * @param yoff The Y offset inside the house
 * @param zoff The Z offset inside the house
 * @return true on success, false when the item can't be added
 */
bool UHouse::add_component( Items::Item* item, s32 xoff, s32 yoff, s16 zoff )
{
  if ( !can_add_component( item ) )
    return false;

  u16 newx, newy;
  s8 newz;
  try
  {
    // These casts should be safe, but better check them - 2015-01-25 Bodom
    newx = boost::numeric_cast<u16>( x() + xoff );
    newy = boost::numeric_cast<u16>( y() + yoff );
    newz = boost::numeric_cast<s8>( z() + zoff );
  }
  catch ( boost::bad_numeric_cast& )
  {
    // Printing an error because this is supposed to not happen,
    // so it's probably a bug.
    POLLOG_ERRORLN( "Out-of-range coordinates while trying to add Item {:#x} to House {:#x}",
                    item->serial, serial );
    return false;
  }
  item->setposition( Core::Pos4d( newx, newy, newz, realm() ) );
  item->disable_decay();
  item->movable( false );
  update_item_to_inrange( item );
  add_item_to_world( item );
  add_component_no_check( Component( item ) );
  return true;
}

/**
 * (Re-)Adds a component to the House, without modifying it:
 * the item must already be inside the house, it just gets added to the components list
 *
 * @param item Reference to the item being added
 * @return true on success, false when the item can't be added
 */
bool UHouse::add_component( Component item )
{
  if ( !can_add_component( item.get() ) )
    return false;

  add_component_no_check( item );
  return true;
}

/**
 * Returns list of house components by allocating a new Array to be used by scripts
 *
 * @return ObjArray* pointer to the newly allocated array
 */
Bscript::ObjArray* UHouse::component_list() const
{
  std::unique_ptr<Bscript::ObjArray> arr( new Bscript::ObjArray );
  for ( Components::const_iterator itr = components_.begin(), end = components_.end(); itr != end;
        ++itr )
  {
    Items::Item* item = ( *itr ).get();
    if ( item != nullptr && !item->orphan() )
    {
      arr->addElement( new Module::EItemRefObjImp( item ) );
    }
  }
  return arr.release();
}

Bscript::ObjArray* UHouse::items_list() const
{
  ItemList itemlist;
  MobileList moblist;
  list_contents( this, itemlist, moblist );
  std::unique_ptr<Bscript::ObjArray> arr( new Bscript::ObjArray );
  for ( auto& item : itemlist )
  {
    if ( std::find( components_.cbegin(), components_.cend(), Component( item ) ) ==
         components_.cend() )
    {
      arr->addElement( new Module::EItemRefObjImp( item ) );
    }
  }
  return arr.release();
}

Bscript::ObjArray* UHouse::mobiles_list() const
{
  ItemList itemlist;
  MobileList moblist;
  list_contents( this, itemlist, moblist );
  std::unique_ptr<Bscript::ObjArray> arr( new Bscript::ObjArray );
  for ( auto& chr : moblist )
  {
    arr->addElement( new Module::ECharacterRefObjImp( chr ) );
  }
  return arr.release();
}

UHouse* UHouse::as_house()
{
  return this;
}

Bscript::BObjectImp* UHouse::get_script_member_id( const int id ) const  /// id test
{
  using namespace Bscript;
  BObjectImp* imp = base::get_script_member_id( id );
  if ( imp )
    return imp;

  switch ( id )
  {
  case MBR_COMPONENTS:
    return component_list();
    break;
  case MBR_ITEMS:
    return items_list();
    break;
  case MBR_MOBILES:
    return mobiles_list();
    break;
  case MBR_CUSTOM:
    return new BLong( IsCustom() );
    break;
  case MBR_EDITING:
    return new BLong( IsEditing() );
    break;
  case MBR_MULTIID:
    return new BLong( multiid_ );
    break;
  case MBR_HOUSEPARTS:
    if ( !IsCustom() )
      return new BError( "House is not custom" );
    else if ( IsEditing() )
      return WorkingDesign.list_parts();
    else
      return CurrentDesign.list_parts();
    break;
  default:
    return nullptr;
  }
}

Bscript::BObjectImp* UHouse::get_script_member( const char* membername ) const
{
  Bscript::ObjMember* objmember = Bscript::getKnownObjMember( membername );
  if ( objmember != nullptr )
    return this->get_script_member_id( objmember->id );
  return nullptr;
}

Bscript::BObjectImp* UHouse::script_method_id( const int id, Core::UOExecutor& ex )
{
  using namespace Bscript;
  BObjectImp* imp = base::script_method_id( id, ex );
  if ( imp != nullptr )
    return imp;

  switch ( id )
  {
  case MTH_SETCUSTOM:
  {
    int _custom;
    if ( ex.getParam( 0, _custom ) )
    {
      SetCustom( _custom ? true : false );
      return new BLong( 1 );
    }
    break;
  }
  case MTH_ADD_COMPONENT:
  {
    BApplicObjBase* aob;
    if ( ex.hasParams( 0 ) )
    {
      aob = ex.getApplicObjParam( 0, &Module::eitemrefobjimp_type );
      if ( aob )
      {
        Module::EItemRefObjImp* ir = static_cast<Module::EItemRefObjImp*>( aob );
        Core::ItemRef iref = ir->value();

        if ( add_component( iref ) )
          return new BLong( 1 );

        if ( iref->house() )
          return new BError( "Item is already an house component" );
        return new BError( "Couldn't add component" );
      }
    }
    break;
  }
  case MTH_ERASE_COMPONENT:
  {
    BApplicObjBase* aob;
    if ( ex.hasParams( 0 ) )
    {
      aob = ex.getApplicObjParam( 0, &Module::eitemrefobjimp_type );
      if ( aob )
      {
        Module::EItemRefObjImp* ir = static_cast<Module::EItemRefObjImp*>( aob );
        Core::ItemRef iref = ir->value();
        Components::iterator pos;
        pos = find( components_.begin(), components_.end(), iref );
        if ( pos != components_.end() )
        {
          iref->house( nullptr );
          components_.erase( pos );
        }
        else
          return new BError( "Component not found" );
        return new BLong( 1 );
      }
    }
    break;
  }
  case MTH_ADD_HOUSE_PART:
  {
    if ( !IsCustom() )
      return new BError( "House is not custom" );
    if ( IsEditing() )
      return new BError( "House is currently been edited" );
    if ( !ex.hasParams( 4 ) )
      return new BError( "Not enough parameters" );
    u16 item_graphic;
    int xoff, yoff, item_z;
    if ( ex.getParam( 0, item_graphic ) && ex.getParam( 1, xoff ) && ex.getParam( 2, yoff ) &&
         ex.getParam( 3, item_z ) )
    {
      CUSTOM_HOUSE_ELEMENT elem;
      elem.graphic = item_graphic;
      elem.xoffset = xoff;
      elem.yoffset = yoff;
      elem.z = static_cast<u8>( item_z );
      CurrentDesign.Add( elem );
      // invalidate
      // invalidate
      WorkingDesign = CurrentDesign;
      std::vector<u8> newvec;
      WorkingCompressed.swap( newvec );
      std::vector<u8> newvec2;
      CurrentCompressed.swap( newvec2 );
      revision++;
      CustomHousesSendFullToInRange( this, HOUSE_DESIGN_CURRENT );
      return new BLong( 1 );
    }
    break;
  }
  case MTH_ERASE_HOUSE_PART:
  {
    if ( !IsCustom() )
      return new BError( "House is not custom" );
    if ( IsEditing() )
      return new BError( "House is currently been edited" );
    if ( !ex.hasParams( 4 ) )
      return new BError( "Not enough parameters" );
    int item_graphic, xoff, yoff, item_z;
    if ( ex.getParam( 0, item_graphic ) && ex.getParam( 1, xoff ) && ex.getParam( 2, yoff ) &&
         ex.getParam( 3, item_z ) )
    {
      bool ret =
          CurrentDesign.EraseGraphicAt( static_cast<u16>( item_graphic ), static_cast<u32>( xoff ),
                                        static_cast<u32>( yoff ), static_cast<u8>( item_z ) );
      if ( ret )
      {
        // invalidate
        WorkingDesign = CurrentDesign;
        std::vector<u8> newvec;
        WorkingCompressed.swap( newvec );
        std::vector<u8> newvec2;
        CurrentCompressed.swap( newvec2 );
        CustomHousesSendFullToInRange( this, HOUSE_DESIGN_CURRENT );
      }
      return new BLong( ret ? 1 : 0 );
    }
    break;
  }
  case MTH_ACCEPT_COMMIT:
  {
    if ( !IsCustom() )
      return new BError( "House is not custom" );
    // else if (!IsEditing())
    //  return new BError( "House is currently not been edited" );
    if ( !IsWaitingForAccept() )
      return new BError( "House is currently not waiting for a commit" );
    if ( !ex.hasParams( 2 ) )
      return new BError( "Not enough parameters" );
    int accept;
    Mobile::Character* chr;
    if ( ex.getParam( 1, accept ) && ex.getCharacterParam( 0, chr ) )
    {
      AcceptHouseCommit( chr, accept ? true : false );
      return new BLong( 1 );
    }
    break;
  }
  case MTH_CANCEL_EDITING:
  {
    if ( !IsCustom() )
      return new BError( "House is not custom" );
    if ( !IsEditing() )
      return new BError( "House is currently not been edited" );
    if ( !ex.hasParams( 2 ) )
      return new BError( "Not enough parameters" );
    Mobile::Character* chr;
    int drop_changes;
    if ( ex.getCharacterParam( 0, chr ) && ex.getParam( 1, drop_changes ) )
    {
      if ( chr->client->gd->custom_house_serial == serial )
        CustomHousesQuit( chr, drop_changes ? true : false );
      else
        return new BError( "Character is not editing this house" );
      return new BLong( 1 );
    }
    break;
  }
  case MTH_SET_MULTIID:
  {
    if ( IsEditing() )
      return new BError( "House is currently been edited" );
    if ( !ex.hasParams( 2 ) )
      return new BError( "Not enough parameters" );

    u16 multiid;
    BObjectImp* multiid_imp = ex.getParamImp( 0 );

    // If passing an integer, it's a multiid and NOT an objtype id
    if ( multiid_imp->isa( BObjectImp::OTLong ) )
    {
      multiid = Clib::clamp_convert<u16>( static_cast<BLong*>( multiid_imp )->value() );
    }
    // If a string, get the multiid of the itemdesc of the name passed.
    else if ( multiid_imp->isa( BObjectImp::OTString ) )
    {
      const Items::ItemDesc* itemdesc_out;
      if ( !ex.getObjtypeParam( 0, itemdesc_out ) || itemdesc_out->multiid == 0 )
      {
        return new BError( "Invalid parameter type" );
      }
      multiid = itemdesc_out->multiid;
    }
    else
    {
      break;
    }

    int flags;
    if ( !ex.getParam( 1, flags ) )
      break;

    if ( !MultiDefByMultiIDExists( multiid ) )
    {
      return new Bscript::BError(
          fmt::format( "Multi definition not found for House, multiid=0x{:x}", multiid ) );
    }

    const MultiDef* md = MultiDefByMultiID( multiid );
    std::string why_not;

    if ( !is_valid_position( md, pos(), flags, why_not, this ) )
    {
      return new BError( why_not );
    }

    change_multiid( multiid, flags & CRMULTI_RECREATE_COMPONENTS );

    return new BLong( 1 );
  }

  default:
    return nullptr;
  }
  return new BError( "Invalid parameter type" );
}

Bscript::BObjectImp* UHouse::script_method( const char* methodname, Core::UOExecutor& ex )
{
  Bscript::ObjMethod* objmethod = Bscript::getKnownObjMethod( methodname );
  if ( objmethod != nullptr )
    return this->script_method_id( objmethod->id, ex );
  return nullptr;
}

void UHouse::readProperties( Clib::ConfigElem& elem )
{
  base::readProperties( elem );
  u32 tmp_serial;
  while ( elem.remove_prop( "Component", &tmp_serial ) )
  {
    Items::Item* item = Core::find_toplevel_item( tmp_serial );
    if ( item != nullptr )
    {
      if ( !add_component( Component( item ) ) )
      {
        std::string os =
            fmt::format( "Couldn't add component {:#x} to house {:#x}.\n", item->serial, serial );
        UHouse* contHouse = item->house();
        if ( contHouse == nullptr )
        {
          os += "This is probably a core bug. Please report it on the forums.";
        }
        else
        {
          fmt::format_to( std::back_inserter( os ),
                          "This item is already part of house {:#x}.\n"
                          "Allowing an item to be a component in two different houses was a bug,\n"
                          "please also fix your save data.",
                          contHouse->serial );
        }
        throw std::runtime_error( os );
      }
    }
  }
  custom = elem.remove_bool( "Custom", false );
  if ( custom )
  {
    const MultiDef& def = multidef();
    auto size =
        Core::Pos2d( 1, 2 ) +
        ( def.maxrxyz.xy() - def.minrxyz.xy() );  //+1 to include offset 0 in -3..3, additional y+1
                                                  // for front steps outside of multidef footprint
    Core::Vec2d xybase( (short)std::abs( def.minrxyz.x() ), (short)std::abs( def.minrxyz.y() ) );


    CurrentDesign.InitDesign( size.y(), size.x(), xybase.x(), xybase.y() );
    WorkingDesign.InitDesign( size.y(), size.x(), xybase.x(), xybase.y() );
    BackupDesign.InitDesign( size.y(), size.x(), xybase.x(), xybase.y() );
    CurrentDesign.readProperties( elem, "Current" );
    WorkingDesign.readProperties( elem, "Working" );
    BackupDesign.readProperties( elem, "Backup" );

    elem.remove_prop( "DesignRevision", &revision );
  }
}

void UHouse::printProperties( Clib::StreamWriter& sw ) const
{
  base::printProperties( sw );

  for ( Components::const_iterator itr = components_.begin(), end = components_.end(); itr != end;
        ++itr )
  {
    Items::Item* item = ( *itr ).get();
    if ( item != nullptr && !item->orphan() )
    {
      sw.add( "Component", Clib::hexintv( item->serial ) );
    }
  }
  sw.add( "Custom", custom );
  if ( custom )
  {
    CurrentDesign.printProperties( sw, "Current" );
    WorkingDesign.printProperties( sw, "Working" );
    BackupDesign.printProperties( sw, "Backup" );
    sw.add( "DesignRevision", revision );
  }
}

void UHouse::destroy_components()
{
  while ( !components_.empty() )
  {
    Items::Item* item = components_.back().get();
    if ( Plib::systemstate.config.loglevel >= 5 )
      POLLOGLN( "Destroying component {:#x}, serial={:#x}", item->objtype_, item->serial );
    if ( !item->orphan() )
      Core::destroy_item( item );
    if ( Plib::systemstate.config.loglevel >= 5 )
      POLLOGLN( "Component destroyed" );
    components_.pop_back();
  }
}

void UHouse::change_multiid( u16 multiid, bool recreate_components )
{
  // Used for sorting and difference calculation
  auto comparator = []( Core::UObject* a, Core::UObject* b ) { return a->serial < b->serial; };

  ItemList itemlist;
  MobileList old_moblist;
  list_contents( this, itemlist, old_moblist );
  old_moblist.sort( comparator );

  multiid_ = multiid;
  send_multi_to_inrange( this );

  MobileList new_moblist;
  list_contents( this, itemlist, new_moblist );
  new_moblist.sort( comparator );

  auto on_mob_added = [&]( Mobile::Character* chr )
  {
    register_object( chr );

    if ( chr->registered_multi == 0 )
    {
      chr->registered_multi = this->serial;
      this->walk_on( chr );
    }
  };

  auto on_mob_removed = [&]( Mobile::Character* chr ) { unregister_object( chr ); };

  // Traverse both vectors
  auto old_itr = old_moblist.begin();
  auto new_itr = new_moblist.begin();

  while ( old_itr != old_moblist.end() && new_itr != new_moblist.end() )
  {
    if ( comparator( *old_itr, *new_itr ) )
    {
      on_mob_removed( *old_itr );
      ++old_itr;
    }
    else if ( comparator( *new_itr, *old_itr ) )
    {
      on_mob_added( *new_itr );
      ++new_itr;
    }
    else
    {
      ++old_itr;
      ++new_itr;
    }
  }

  // Remaining elements in old are removed
  while ( old_itr != old_moblist.end() )
  {
    on_mob_removed( *old_itr );
    ++old_itr;
  }

  // Remaining elements in new are added
  while ( new_itr != new_moblist.end() )
  {
    on_mob_added( *new_itr );
    ++new_itr;
  }

  // Recreate components (if specified)
  if ( recreate_components )
  {
    for ( auto& component : components_ )
    {
      if ( !component->orphan() )
        Core::destroy_item( component.get() );
    }

    components_.clear();

    create_components();
  }
}

bool UHouse::readshapes( Plib::MapShapeList& vec, short shape_x, short shape_y, short zbase )
{
  if ( !custom )
    return false;

  bool result = false;
  HouseFloorZColumn* elems;
  HouseFloorZColumn::iterator itr;
  CustomHouseDesign* design;
  design =
      editing
          ? &WorkingDesign
          : &CurrentDesign;  // consider having a list of players that should use the working set

  if ( shape_x + design->xoff < 0 || shape_x + design->xoff >= static_cast<s32>( design->width ) ||
       shape_y + design->yoff < 0 || shape_y + design->yoff >= static_cast<s32>( design->height ) )
    return false;
  for ( int i = 0; i < CUSTOM_HOUSE_NUM_PLANES; i++ )
  {
    elems = design->Elements[i].GetElementsAt( shape_x, shape_y );
    for ( itr = elems->begin(); itr != elems->end(); ++itr )
    {
      Plib::MapShape shape;
      shape.z = itr->z + zbase;
      shape.height = Plib::tileheight( itr->graphic );
      shape.flags = Plib::tile_flags( itr->graphic );
      if ( !shape.height )
      {
        ++shape.height;
        --shape.z;
      }
      vec.push_back( shape );
      result = true;
    }
  }
  // house teleporters are components and replace floors
  for ( const auto& c : components_ )
  {
    Items::Item* item = c.get();
    if ( item == nullptr || item->orphan() )
      continue;
    if ( item->graphic >= TELEPORTER_START && item->graphic <= TELEPORTER_END )
    {
      Plib::MapShape shape;
      shape.z = item->z();
      shape.height = Plib::tileheight( item->graphic );
      shape.flags = Plib::tile_flags( item->graphic );
      if ( !shape.height )
      {
        ++shape.height;
        --shape.z;
      }
      vec.push_back( shape );
      result = true;
    }
  }
  return result;
}

bool UHouse::readobjects( Plib::StaticList& vec, short obj_x, short obj_y, short zbase )
{
  if ( !custom )
    return false;

  bool result = false;
  HouseFloorZColumn* elems;
  HouseFloorZColumn::iterator itr;
  CustomHouseDesign* design;
  design =
      editing
          ? &WorkingDesign
          : &CurrentDesign;  // consider having a list of players that should use the working set

  if ( obj_x + design->xoff < 0 || obj_x + design->xoff >= static_cast<s32>( design->width ) ||
       obj_y + design->yoff < 0 || obj_y + design->yoff >= static_cast<s32>( design->height ) )
    return false;
  for ( int i = 0; i < CUSTOM_HOUSE_NUM_PLANES; i++ )
  {
    elems = design->Elements[i].GetElementsAt( obj_x, obj_y );
    for ( itr = elems->begin(); itr != elems->end(); ++itr )
    {
      Plib::StaticRec rec( itr->graphic, static_cast<signed char>( itr->z + zbase ),
                           Plib::tile_flags( itr->graphic ), Plib::tileheight( itr->graphic ) );
      if ( !rec.height )
      {
        ++rec.height;
        --rec.z;
      }
      vec.push_back( rec );
      result = true;
    }
  }
  return result;
}

// consider: storing editing char serial list on the house, to validate who should see the working
// set
UHouse* UHouse::FindWorkingHouse( u32 chrserial )
{
  Mobile::Character* chr = Core::find_character( chrserial );
  if ( chr == nullptr )
    return nullptr;
  if ( chr->client == nullptr )
    return nullptr;

  u32 house_serial = chr->client->gd->custom_house_serial;

  UMulti* multi = Core::system_find_multi( house_serial );
  if ( multi == nullptr )
    return nullptr;

  UHouse* house = multi->as_house();
  if ( house == nullptr )
    return nullptr;

  return house;
}

bool multis_exist_in( const Core::Pos4d& minpos, const Core::Pos4d& maxpos,
                      Multi::UMulti* ignore_existing )
{
  // TODO Pos maximum multi footprint, gamestate.update_range?
  Core::Range2d mybox( minpos, maxpos );
  Core::Range2d gridarea( Core::zone_convert( minpos - Core::Vec2d( 100, 100 ) ),
                          Core::zone_convert( maxpos + Core::Vec2d( 100, 100 ) ), nullptr );
  for ( const auto& gpos : gridarea )
  {
    for ( const auto& multi : minpos.realm()->getzone_grid( gpos ).multis )
    {
      if ( ignore_existing == multi )
        continue;

      // find out if any of our walls would fall within its footprint.
      auto otherbox = multi->current_box().range();
      if ( mybox.intersect( otherbox ) )
        return true;
    }
  }
  return false;
}

bool objects_exist_in( const Core::Pos4d& p1, const Core::Pos4d& p2,
                       Multi::UMulti* ignore_existing )
{
  Core::Range2d gridarea( Core::zone_convert( p1 ), Core::zone_convert( p2 ), nullptr );
  Core::Range2d worldarea( p1, p2 );
  for ( const auto& gpos : gridarea )
  {
    for ( const auto& chr : p1.realm()->getzone_grid( gpos ).characters )
    {
      if ( ignore_existing != nullptr && chr->registered_multi == ignore_existing->serial )
        continue;

      if ( worldarea.contains( chr->pos2d() ) )
        return true;
    }
    for ( const auto& chr : p1.realm()->getzone_grid( gpos ).npcs )
    {
      if ( ignore_existing != nullptr && chr->registered_multi == ignore_existing->serial )
        continue;

      if ( worldarea.contains( chr->pos2d() ) )
        return true;
    }
    for ( const auto& item : p1.realm()->getzone_grid( gpos ).items )
    {
      if ( ignore_existing != nullptr &&
           ( item->house() == ignore_existing ||
             p1.realm()->find_supporting_multi( item->pos3d() ) == ignore_existing ) )
        continue;

      if ( worldarea.contains( item->pos2d() ) )
        return true;
    }
  }
  return false;
}

bool statics_cause_problems( const Core::Pos4d& p1, const Core::Pos4d& p2,
                             Multi::UMulti* ignore_existing )
{
  Core::Range2d area( p1, p2 );
  for ( const auto& p : area )
  {
    short newz;
    UMulti* multi;
    Items::Item* item;
    if ( !p1.realm()->walkheight( p, p1.z(), &newz, &multi, &item, true, Plib::MOVEMODE_LAND,
                                  nullptr, ignore_existing ) )
    {
      if ( ignore_existing != nullptr && multi != ignore_existing )
      {
        POLLOGLN( "Refusing to place house at {},{}: can't stand there", p, p1.z() );
        return true;
      }
    }
    if ( labs( p1.z() - newz ) > 2 )
    {
      POLLOGLN( "Refusing to place house at {},{}: result Z ({}) is too far afield", p, p1.z(),
                newz );
      return true;
    }
  }
  return false;
}

bool UHouse::is_valid_position( const MultiDef* md, const Core::Pos4d& pos, int flags,
                                std::string& why_not, UMulti* existing )
{
  using namespace Bscript;

  if ( !pos.can_move_to( md->minrxyz.xy() ) || !pos.can_move_to( md->maxrxyz.xy() ) )
    return why_not = "That location is out of bounds", false;

  auto corner_ne = pos + md->minrxyz;
  auto corner_sw = pos + md->maxrxyz;
  if ( ~flags & CRMULTI_IGNORE_MULTIS )
  {
    // TODO: it seems to be more restrictive then original server
    // see https://uo.stratics.com/homes/betterhomes/bhc_placing.shtml
    // should we change it or keep it that way?
    const auto additional_gap = Core::Vec2d( 1, 5 );
    if ( multis_exist_in( corner_ne - additional_gap, corner_sw + additional_gap, existing ) )
      return why_not = "Location intersects with another structure", false;
  }

  if ( ~flags & CRMULTI_IGNORE_OBJECTS )
  {
    if ( objects_exist_in( corner_ne, corner_sw, existing ) )
      return why_not = "Something is blocking that location", false;
  }
  if ( ~flags & CRMULTI_IGNORE_FLATNESS )
  {
    const auto additional_gap = Core::Vec2d( 1, 1 );
    if ( statics_cause_problems( corner_ne - additional_gap, corner_sw + additional_gap,
                                 existing ) )

      return why_not = "That location is not suitable", false;
  }

  return true;
}

Bscript::BObjectImp* UHouse::scripted_create( const Items::ItemDesc& descriptor,
                                              const Core::Pos4d& pos, int flags )
{
  if ( !MultiDefByMultiIDExists( descriptor.multiid ) )
  {
    return new Bscript::BError(
        "Multi definition not found for House, objtype=" + Clib::hexint( descriptor.objtype ) +
        ", multiid=" + Clib::hexint( descriptor.multiid ) );
  }
  const MultiDef* md = MultiDefByMultiID( descriptor.multiid );
  std::string why_not;

  if ( !is_valid_position( md, pos, flags, why_not, nullptr ) )
  {
    return new Bscript::BError( why_not );
  }

  UHouse* house = new UHouse( descriptor );
  house->serial = Core::GetNewItemSerialNumber();
  house->serial_ext = ctBEu32( house->serial );
  house->setposition( pos );
  send_multi_to_inrange( house );
  // update_item_to_inrange( house );
  add_multi_to_world( house );
  house->create_components();

  ////Hash
  Core::objStorageManager.objecthash.Insert( house );
  ////

  return house->make_ref();
}


void move_to_ground( Items::Item* item )
{
  const Core::Pos4d oldpos = item->toplevel_pos();
  item->set_dirty();
  item->movable( true );
  item->set_decay_after( 60 );  // just a dummy in case decay=0
  item->restart_decay_timer();
  for ( unsigned short xd = 0; xd < 5; ++xd )  // TODO POS Range2d for Vectors?
  {
    for ( unsigned short yd = 0; yd < 5; ++yd )
    {
      Items::Item* walkon;
      UMulti* multi;
      short newz;
      item->setposition( Core::Pos4d( item->pos() ).x( 0 ).y( 0 ) );
      auto newpos = oldpos + Core::Vec2d( xd, yd );
      // move 'self' a bit so it doesn't interfere with itself
      bool res = item->realm()->walkheight( newpos.xy(), item->z(), &newz, &multi, &walkon, true,
                                            Plib::MOVEMODE_LAND );
      if ( res )
      {
        item->setposition( newpos.z( static_cast<signed char>( newz ) ) );
        move_item( item, oldpos );
        return;
      }
      item->setposition( oldpos );
    }
  }
  short newz;
  if ( item->realm()->groundheight( item->pos2d(), &newz ) )
  {
    item->setposition( Core::Pos4d( item->pos() ).z( static_cast<signed char>( newz ) ) );
    move_item( item, oldpos );
    return;
  }
}


void move_to_ground( Mobile::Character* chr )
{
  move_character_to( chr, chr->pos(), Core::MOVEITEM_FORCELOCATION );
}

// void send_remove_object_if_inrange( Client *client, const UObject *item );

Bscript::BObjectImp* destroy_house( UHouse* house )
{
  if ( house->IsEditing() )
    return new Bscript::BError( "House currently being customized." );

  house->destroy_components();

  ItemList item_contents;
  MobileList chr_contents;
  UHouse::list_contents( house, item_contents, chr_contents );

  send_remove_object_to_inrange( house );
  remove_multi_from_world( house );

  while ( !item_contents.empty() )
  {
    Items::Item* item = item_contents.front();
    move_to_ground( item );

    item_contents.pop_front();
  }

  while ( !chr_contents.empty() )
  {
    Mobile::Character* chr = chr_contents.back();
    move_to_ground( chr );
    chr->registered_multi = 0;
    chr_contents.pop_back();
  }

  house->ClearSquatters();

  house->destroy();

  return new Bscript::BLong( 1 );
}

void UHouse::register_object( UObject* obj )
{
  if ( !obj->ismobile() )
    return;
  if ( find( squatters_.begin(), squatters_.end(), obj ) == squatters_.end() )
  {
    set_dirty();
    squatters_.emplace_back( obj );
  }
}

void UHouse::unregister_object( UObject* obj )
{
  Squatters::iterator this_squatter = find( squatters_.begin(), squatters_.end(), obj );

  if ( this_squatter != squatters_.end() )
  {
    set_dirty();
    squatters_.erase( this_squatter );
  }
}

void UHouse::ClearSquatters()
{
  squatters_.clear();
}

void UHouse::AcceptHouseCommit( Mobile::Character* chr, bool accept )
{
  waiting_for_accept = false;
  if ( accept )
  {
    auto itemlist = get_working_design_items( this );

    revision++;

    // commit working design to current design
    CurrentDesign = WorkingDesign;

    // invalidate old packet
    std::vector<u8> newvec;
    CurrentCompressed.swap( newvec );

    CustomHouseStopEditing( chr, this, itemlist );

    // send full house
    CustomHousesSendFullToInRange( this, HOUSE_DESIGN_CURRENT );
  }
  else
  {
    WorkingDesign.AddComponents( this );
    WorkingDesign.ClearComponents( this );
    if ( chr && chr->client )
      CustomHousesSendFull( this, chr->client, HOUSE_DESIGN_WORKING );
  }
}

bool UHouse::get_method_hook( const char* methodname, Bscript::Executor* ex,
                              Core::ExportScript** hook, unsigned int* PC ) const
{
  if ( Core::gamestate.system_hooks.get_method_hook(
           Core::gamestate.system_hooks.house_method_script.get(), methodname, ex, hook, PC ) )
    return true;
  return base::get_method_hook( methodname, ex, hook, PC );
}
}  // namespace Pol::Multi

polserver / polserver / 21108840797

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous