21108840797

Committed 18 Jan 2026 08:35AM UTC coverage: 60.508% (+0.02%) from 60.492%

Build # 21108840797

Build Type

push

github

Committed by

web-flow

Commit Message

ClangTidy readability-else-after-return (#857)

* trigger tidy

* Automated clang-tidy change: readability-else-after-return

* compile test

* rerun

* Automated clang-tidy change: readability-else-after-return

* trigger..

* Automated clang-tidy change: readability-else-after-return

* manually removed a few

* Automated clang-tidy change: readability-else-after-return

* removed duplicate code

* fix remaining warnings

* fixed scope

---------

Co-authored-by: Clang Tidy <clang-tidy@users.noreply.github.com>

Run Details

837 of 1874 new or added lines in 151 files covered. (44.66%)

46 existing lines in 25 files now uncovered.

44448 of 73458 relevant lines covered (60.51%)

525066.38 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

30.0

/pol-core/pol/guildscrobj.cpp

#include "guildscrobj.h"

#include "../clib/stlutil.h"
#include "guilds.h"
#include <stddef.h>
#include <string>


namespace Pol::Module
{
using namespace Bscript;

BApplicObjType guild_type;

EGuildRefObjImp::EGuildRefObjImp( Core::GuildRef gref )
    : PolApplicObj<Core::GuildRef>( &guild_type, gref ){};

const char* EGuildRefObjImp::typeOf() const
{
  return "GuildRef";
}
u8 EGuildRefObjImp::typeOfInt() const
{
  return OTGuildRef;
}

BObjectImp* EGuildRefObjImp::copy() const
{
  return new EGuildRefObjImp( obj_ );
}

bool EGuildRefObjImp::isTrue() const
{
  return ( !obj_->_disbanded );
}

bool EGuildRefObjImp::operator==( const BObjectImp& objimp ) const
{
  if ( objimp.isa( BObjectImp::OTApplicObj ) )
  {
    const BApplicObjBase* aob =
        Clib::explicit_cast<const BApplicObjBase*, const BObjectImp*>( &objimp );

    if ( aob->object_type() == &guild_type )
    {
      const EGuildRefObjImp* guildref_imp =
          Clib::explicit_cast<const EGuildRefObjImp*, const BApplicObjBase*>( aob );

      return ( guildref_imp->obj_->_guildid == obj_->_guildid );
    }
    return false;
  }
  if ( objimp.isa( BObjectImp::OTBoolean ) )
    return isTrue() == static_cast<const BBoolean&>( objimp ).isTrue();
  return false;
}


}  // namespace Pol::Module

1	#include "guildscrobj.h"
2
3	#include "../clib/stlutil.h"
4	#include "guilds.h"
5	#include <stddef.h>
6	#include <string>
7
8
9	namespace Pol::Module
10	{
11	using namespace Bscript;
12
13	BApplicObjType guild_type;
14
15	EGuildRefObjImp::EGuildRefObjImp( Core::GuildRef gref )	9✔
16	: PolApplicObj<Core::GuildRef>( &guild_type, gref ){};	9✔
17
18	const char* EGuildRefObjImp::typeOf() const	×
19	{
20	return "GuildRef";	×
21	}
22	u8 EGuildRefObjImp::typeOfInt() const	×
23	{
24	return OTGuildRef;	×
25	}
26
27	BObjectImp* EGuildRefObjImp::copy() const	1✔
28	{
29	return new EGuildRefObjImp( obj_ );	1✔
30	}
31
32	bool EGuildRefObjImp::isTrue() const	4✔
33	{
34	return ( !obj_->_disbanded );	4✔
35	}
36
37	bool EGuildRefObjImp::operator==( const BObjectImp& objimp ) const	×
38	{
39	if ( objimp.isa( BObjectImp::OTApplicObj ) )	×
40	{
41	const BApplicObjBase* aob =
42	Clib::explicit_cast<const BApplicObjBase, const BObjectImp>( &objimp );	×
43
44	if ( aob->object_type() == &guild_type )	×
45	{
46	const EGuildRefObjImp* guildref_imp =
47	Clib::explicit_cast<const EGuildRefObjImp, const BApplicObjBase>( aob );	×
48
49	return ( guildref_imp->obj_->_guildid == obj_->_guildid );	×
50	}
NEW 51	return false;	×
52	}
NEW 53	if ( objimp.isa( BObjectImp::OTBoolean ) )	×
54	return isTrue() == static_cast<const BBoolean&>( objimp ).isTrue();	×
NEW 55	return false;	×
56	}
57
58
59	} // namespace Pol::Module

polserver / polserver / 21108840797

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous