• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

openmc-dev / openmc / 21092019830

17 Jan 2026 09:18AM UTC coverage: 80.822% (-1.2%) from 82.044%
21092019830

Pull #3732

github

web-flow
Merge 81036cf07 into 5847b0de2
Pull Request #3732: Volume Calculation enhancement including refactoring and real-valued scoring implementation

15996 of 22249 branches covered (71.9%)

Branch coverage included in aggregate %.

229 of 255 new or added lines in 3 files covered. (89.8%)

1115 existing lines in 52 files now uncovered.

53688 of 63970 relevant lines covered (83.93%)

13910352.73 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.85
/src/tallies/filter_cell_instance.cpp
1
#include "openmc/tallies/filter_cell_instance.h"
2

3
#include <cassert>
4
#include <string>
5

6
#include <fmt/core.h>
7

8
#include "openmc/capi.h"
9
#include "openmc/cell.h"
10
#include "openmc/error.h"
11
#include "openmc/geometry.h"
12
#include "openmc/xml_interface.h"
13

14
namespace openmc {
15

16
CellInstanceFilter::CellInstanceFilter(span<CellInstance> instances)
×
17
{
18
  this->set_cell_instances(instances);
×
19
}
×
20

21
void CellInstanceFilter::from_xml(pugi::xml_node node)
4✔
22
{
23
  // Get cell IDs/instances
24
  auto cells = get_node_array<int32_t>(node, "bins");
4✔
25
  assert(cells.size() % 2 == 0);
4!
26

27
  // Convert into vector of CellInstance
28
  vector<CellInstance> instances;
4✔
29
  for (int64_t i = 0; i < cells.size() / 2; ++i) {
84✔
30
    int32_t cell_id = cells[2 * i];
80✔
31
    int64_t instance = cells[2 * i + 1];
80✔
32
    auto search = model::cell_map.find(cell_id);
80✔
33
    if (search == model::cell_map.end()) {
80!
34
      throw std::runtime_error {fmt::format(
×
35
        "Could not find cell {} specified on tally filter.", cell_id)};
×
36
    }
37
    int64_t index = search->second;
80✔
38
    instances.push_back({index, instance});
80✔
39
  }
40

41
  this->set_cell_instances(instances);
4✔
42
}
4✔
43

44
void CellInstanceFilter::set_cell_instances(span<CellInstance> instances)
4✔
45
{
46
  // Clear existing cells
47
  cell_instances_.clear();
4✔
48
  cell_instances_.reserve(instances.size());
4✔
49
  cells_.clear();
4✔
50
  map_.clear();
4✔
51

52
  // Update cells and mapping
53
  for (auto& x : instances) {
84✔
54
    assert(x.index_cell >= 0);
80!
55
    assert(x.index_cell < model::cells.size());
80!
56
    cell_instances_.push_back(x);
80✔
57
    cells_.insert(x.index_cell);
80✔
58
    map_[x] = cell_instances_.size() - 1;
80✔
59
  }
60

61
  n_bins_ = cell_instances_.size();
4✔
62

63
  material_cells_only_ = true;
4✔
64
  for (const auto& cell_inst : cell_instances_) {
36!
65
    const auto& c = *model::cells[cell_inst.index_cell];
36✔
66
    if (c.type_ == Fill::MATERIAL)
36✔
67
      continue;
32✔
68
    material_cells_only_ = false;
4✔
69
    break;
4✔
70
  }
71
}
4✔
72

73
void CellInstanceFilter::get_all_bins(
1,383,816✔
74
  const Particle& p, TallyEstimator estimator, FilterMatch& match) const
75
{
76
  int64_t index_cell = p.lowest_coord().cell();
1,383,816✔
77
  int64_t instance = p.cell_instance();
1,383,816✔
78

79
  if (cells_.count(index_cell) > 0) {
1,383,816✔
80
    auto search = map_.find({index_cell, instance});
374,452✔
81
    if (search != map_.end()) {
374,452!
82
      int index_bin = search->second;
374,452✔
83
      match.bins_.push_back(index_bin);
374,452✔
84
      match.weights_.push_back(1.0);
374,452✔
85
    }
86
  }
87

88
  if (material_cells_only_)
1,383,816!
UNCOV
89
    return;
×
90

91
  for (int i = 0; i < p.n_coord() - 1; i++) {
3,119,588✔
92
    int64_t index_cell = p.coord(i).cell();
1,735,772✔
93
    // if this cell isn't used on the filter, move on
94
    if (cells_.count(index_cell) == 0)
1,735,772✔
95
      continue;
1,383,816✔
96

97
    // if this cell is used in the filter, check the instance as well
98
    int64_t instance = cell_instance_at_level(p, i);
351,956✔
99
    auto search = map_.find({index_cell, instance});
351,956✔
100
    if (search != map_.end()) {
351,956!
101
      match.bins_.push_back(search->second);
351,956✔
102
      match.weights_.push_back(1.0);
351,956✔
103
    }
104
  }
105
}
106

107
void CellInstanceFilter::to_statepoint(hid_t filter_group) const
4✔
108
{
109
  Filter::to_statepoint(filter_group);
4✔
110
  size_t n = cell_instances_.size();
4✔
111
  xt::xtensor<size_t, 2> data({n, 2});
4✔
112
  for (int64_t i = 0; i < n; ++i) {
84✔
113
    const auto& x = cell_instances_[i];
80✔
114
    data(i, 0) = model::cells[x.index_cell]->id_;
80✔
115
    data(i, 1) = x.instance;
80✔
116
  }
117
  write_dataset(filter_group, "bins", data);
4✔
118
}
4✔
119

120
std::string CellInstanceFilter::text_label(int bin) const
80✔
121
{
122
  const auto& x = cell_instances_[bin];
80✔
123
  auto cell_id = model::cells[x.index_cell]->id_;
80✔
124
  return "Cell " + std::to_string(cell_id) + ", Instance " +
160✔
125
         std::to_string(x.instance);
240✔
126
}
127

128
} // namespace openmc
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc