• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4929

16 Jan 2026 02:32AM UTC coverage: 66.723% (+0.02%) from 66.708%
#4929

push

travis-ci

web-flow
enh: interp supports using non-null prev/next values to fill (#34236)

281 of 327 new or added lines in 11 files covered. (85.93%)

539 existing lines in 127 files now uncovered.

203225 of 304580 relevant lines covered (66.72%)

128590777.46 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

75.4
/source/dnode/mnode/impl/src/mndTopic.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *f
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "mndTopic.h"
17
#include "audit.h"
18
#include "mndConsumer.h"
19
#include "mndDb.h"
20
#include "mndDnode.h"
21
#include "mndMnode.h"
22
#include "mndPrivilege.h"
23
#include "mndShow.h"
24
#include "mndStb.h"
25
#include "mndSubscribe.h"
26
#include "mndTrans.h"
27
#include "mndUser.h"
28
#include "mndVgroup.h"
29
#include "osMemPool.h"
30
#include "parser.h"
31
#include "tlockfree.h"
32
#include "tname.h"
33

34
#define MND_TOPIC_VER_SUPPORT_OWNER 4
35
#define MND_TOPIC_VER_NUMBER        MND_TOPIC_VER_SUPPORT_OWNER
36
#define MND_TOPIC_RESERVE_SIZE      64
37

38
SHashObj *topicsToReload = NULL;
39

40
SSdbRaw *mndTopicActionEncode(SMqTopicObj *pTopic);
41
SSdbRow *mndTopicActionDecode(SSdbRaw *pRaw);
42

43
static int32_t mndTopicActionInsert(SSdb *pSdb, SMqTopicObj *pTopic);
44
static int32_t mndTopicActionDelete(SSdb *pSdb, SMqTopicObj *pTopic);
45
static int32_t mndTopicActionUpdate(SSdb *pSdb, SMqTopicObj *pOldTopic, SMqTopicObj *pNewTopic);
46
static int32_t mndProcessCreateTopicReq(SRpcMsg *pReq);
47
static int32_t mndProcessDropTopicReq(SRpcMsg *pReq);
48

49
static int32_t mndRetrieveTopic(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
50
static void    mndCancelGetNextTopic(SMnode *pMnode, void *pIter);
51
static int32_t processAst(SMqTopicObj *topicObj, const char *ast);
52

53
int32_t mndInitTopic(SMnode *pMnode) {
414,654✔
54
  SSdbTable table = {
414,654✔
55
      .sdbType = SDB_TOPIC,
56
      .keyType = SDB_KEY_BINARY,
57
      .encodeFp = (SdbEncodeFp)mndTopicActionEncode,
58
      .decodeFp = (SdbDecodeFp)mndTopicActionDecode,
59
      .insertFp = (SdbInsertFp)mndTopicActionInsert,
60
      .updateFp = (SdbUpdateFp)mndTopicActionUpdate,
61
      .deleteFp = (SdbDeleteFp)mndTopicActionDelete,
62
  };
63

64
  if (pMnode == NULL) {
414,654✔
65
    return TSDB_CODE_INVALID_PARA;
×
66
  }
67
  mndSetMsgHandle(pMnode, TDMT_MND_TMQ_CREATE_TOPIC, mndProcessCreateTopicReq);
414,654✔
68
  mndSetMsgHandle(pMnode, TDMT_MND_TMQ_DROP_TOPIC, mndProcessDropTopicReq);
414,654✔
69

70
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_TOPICS, mndRetrieveTopic);
414,654✔
71
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_TOPICS, mndCancelGetNextTopic);
414,654✔
72

73
  return sdbSetTable(pMnode->pSdb, table);
414,654✔
74
}
75

76
void mndCleanupTopic(SMnode *pMnode) {}
414,594✔
77

78
void mndTopicGetShowName(const char *fullTopic, char *topic) {
46,000✔
79
  if (fullTopic == NULL) {
46,000✔
80
    return;
×
81
  }
82
  char *tmp = strchr(fullTopic, '.');
46,000✔
83
  if (tmp == NULL) {
46,000✔
84
    tstrncpy(topic, fullTopic, TSDB_TOPIC_FNAME_LEN);
×
85
  } else {
86
    tstrncpy(topic, tmp + 1, TSDB_TOPIC_FNAME_LEN);
46,000✔
87
  }
88
}
89
SSdbRaw *mndTopicActionEncode(SMqTopicObj *pTopic) {
278,864✔
90
  if (pTopic == NULL) {
278,864✔
91
    return NULL;
×
92
  }
93
  int32_t code = 0;
278,864✔
94
  int32_t lino = 0;
278,864✔
95
  terrno = TSDB_CODE_OUT_OF_MEMORY;
278,864✔
96

97
  void *  swBuf = NULL;
278,864✔
98
  int32_t physicalPlanLen = 0;
278,864✔
99
  if (pTopic->physicalPlan) {
278,864✔
100
    physicalPlanLen = strlen(pTopic->physicalPlan) + 1;
278,864✔
101
  }
102

103
  int32_t schemaLen = 0;
278,864✔
104
  if (pTopic->schema.nCols) {
278,864✔
105
    schemaLen = taosEncodeSSchemaWrapper(NULL, &pTopic->schema);
431,646✔
106
  }
107

108
  int32_t  size = sizeof(SMqTopicObj) + physicalPlanLen + pTopic->sqlLen + schemaLen + MND_TOPIC_RESERVE_SIZE;
278,864✔
109
  SSdbRaw *pRaw = sdbAllocRaw(SDB_TOPIC, MND_TOPIC_VER_NUMBER, size);
278,864✔
110
  if (pRaw == NULL) {
278,864✔
111
    goto TOPIC_ENCODE_OVER;
×
112
  }
113

114
  int32_t dataPos = 0;
278,864✔
115
  SDB_SET_BINARY(pRaw, dataPos, pTopic->name, TSDB_TOPIC_FNAME_LEN, TOPIC_ENCODE_OVER);
278,864✔
116
  SDB_SET_BINARY(pRaw, dataPos, pTopic->db, TSDB_DB_FNAME_LEN, TOPIC_ENCODE_OVER);
278,864✔
117
  SDB_SET_BINARY(pRaw, dataPos, pTopic->createUser, TSDB_USER_LEN, TOPIC_ENCODE_OVER);
278,864✔
118
  SDB_SET_INT64(pRaw, dataPos, pTopic->createTime, TOPIC_ENCODE_OVER);
278,864✔
119
  SDB_SET_INT64(pRaw, dataPos, pTopic->updateTime, TOPIC_ENCODE_OVER);
278,864✔
120
  SDB_SET_INT64(pRaw, dataPos, pTopic->uid, TOPIC_ENCODE_OVER);
278,864✔
121
  SDB_SET_INT64(pRaw, dataPos, pTopic->dbUid, TOPIC_ENCODE_OVER);
278,864✔
122
  SDB_SET_INT32(pRaw, dataPos, pTopic->version, TOPIC_ENCODE_OVER);
278,864✔
123
  SDB_SET_INT8(pRaw, dataPos, pTopic->subType, TOPIC_ENCODE_OVER);
278,864✔
124
  SDB_SET_INT8(pRaw, dataPos, pTopic->withMeta, TOPIC_ENCODE_OVER);
278,864✔
125

126
  SDB_SET_INT64(pRaw, dataPos, pTopic->stbUid, TOPIC_ENCODE_OVER);
278,864✔
127
  SDB_SET_BINARY(pRaw, dataPos, pTopic->stbName, TSDB_TABLE_FNAME_LEN, TOPIC_ENCODE_OVER);
278,864✔
128
  SDB_SET_INT32(pRaw, dataPos, pTopic->sqlLen, TOPIC_ENCODE_OVER);
278,864✔
129
  SDB_SET_BINARY(pRaw, dataPos, pTopic->sql, pTopic->sqlLen, TOPIC_ENCODE_OVER);
278,864✔
130
  SDB_SET_INT32(pRaw, dataPos, physicalPlanLen, TOPIC_ENCODE_OVER);
278,864✔
131
  if (physicalPlanLen) {
278,864✔
132
    SDB_SET_BINARY(pRaw, dataPos, pTopic->physicalPlan, physicalPlanLen, TOPIC_ENCODE_OVER);
278,864✔
133
  }
134
  SDB_SET_INT32(pRaw, dataPos, schemaLen, TOPIC_ENCODE_OVER);
278,864✔
135
  if (schemaLen) {
278,864✔
136
    swBuf = taosMemoryMalloc(schemaLen);
215,823✔
137
    if (swBuf == NULL) {
215,823✔
138
      goto TOPIC_ENCODE_OVER;
×
139
    }
140
    void *aswBuf = swBuf;
215,823✔
141
    if (taosEncodeSSchemaWrapper(&aswBuf, &pTopic->schema) < 0) {
431,646✔
142
      goto TOPIC_ENCODE_OVER;
×
143
    }
144
    SDB_SET_BINARY(pRaw, dataPos, swBuf, schemaLen, TOPIC_ENCODE_OVER);
215,823✔
145
  }
146
  SDB_SET_INT64(pRaw, dataPos, pTopic->ownerId, TOPIC_ENCODE_OVER); // since ver 4
278,864✔
147
  SDB_SET_RESERVE(pRaw, dataPos, MND_TOPIC_RESERVE_SIZE, TOPIC_ENCODE_OVER);
278,864✔
148
  SDB_SET_DATALEN(pRaw, dataPos, TOPIC_ENCODE_OVER);
278,864✔
149

150
  terrno = TSDB_CODE_SUCCESS;
278,864✔
151

152
TOPIC_ENCODE_OVER:
278,864✔
153
  if (swBuf) taosMemoryFree(swBuf);
278,864✔
154
  if (terrno != TSDB_CODE_SUCCESS) {
278,864✔
155
    mError("topic:%s, failed to encode to raw:%p since %s", pTopic->name, pRaw, terrstr());
×
156
    sdbFreeRaw(pRaw);
×
157
    return NULL;
×
158
  }
159

160
  mDebug("topic:%s, encode to raw:%p, row:%p", pTopic->name, pRaw, pTopic);
278,864✔
161
  return pRaw;
278,864✔
162
}
163

164
SSdbRow *mndTopicActionDecode(SSdbRaw *pRaw) {
241,442✔
165
  if (pRaw == NULL) return NULL;
241,442✔
166
  int32_t code = 0;
241,442✔
167
  int32_t lino = 0;
241,442✔
168
  terrno = TSDB_CODE_OUT_OF_MEMORY;
241,442✔
169
  SSdbRow *    pRow = NULL;
241,442✔
170
  SMqTopicObj *pTopic = NULL;
241,442✔
171
  void *       buf = NULL;
241,442✔
172
  char*        ast = NULL;
241,442✔
173

174
  int8_t sver = 0;
241,442✔
175
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) goto TOPIC_DECODE_OVER;
241,442✔
176

177
  if (sver < 1 || sver > MND_TOPIC_VER_NUMBER) {
241,442✔
178
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
179
    goto TOPIC_DECODE_OVER;
×
180
  }
181

182
  pRow = sdbAllocRow(sizeof(SMqTopicObj));
241,442✔
183
  if (pRow == NULL) goto TOPIC_DECODE_OVER;
241,442✔
184

185
  pTopic = sdbGetRowObj(pRow);
241,442✔
186
  if (pTopic == NULL) goto TOPIC_DECODE_OVER;
241,442✔
187

188
  int32_t len = 0;
241,442✔
189
  int32_t dataPos = 0;
241,442✔
190
  SDB_GET_BINARY(pRaw, dataPos, pTopic->name, TSDB_TOPIC_FNAME_LEN, TOPIC_DECODE_OVER);
241,442✔
191
  SDB_GET_BINARY(pRaw, dataPos, pTopic->db, TSDB_DB_FNAME_LEN, TOPIC_DECODE_OVER);
241,442✔
192
  if (sver >= 2) {
241,442✔
193
    SDB_GET_BINARY(pRaw, dataPos, pTopic->createUser, TSDB_USER_LEN, TOPIC_DECODE_OVER);
241,442✔
194
  }
195
  SDB_GET_INT64(pRaw, dataPos, &pTopic->createTime, TOPIC_DECODE_OVER);
241,442✔
196
  SDB_GET_INT64(pRaw, dataPos, &pTopic->updateTime, TOPIC_DECODE_OVER);
241,442✔
197
  SDB_GET_INT64(pRaw, dataPos, &pTopic->uid, TOPIC_DECODE_OVER);
241,442✔
198
  SDB_GET_INT64(pRaw, dataPos, &pTopic->dbUid, TOPIC_DECODE_OVER);
241,442✔
199
  SDB_GET_INT32(pRaw, dataPos, &pTopic->version, TOPIC_DECODE_OVER);
241,442✔
200
  SDB_GET_INT8(pRaw, dataPos, &pTopic->subType, TOPIC_DECODE_OVER);
241,442✔
201
  SDB_GET_INT8(pRaw, dataPos, &pTopic->withMeta, TOPIC_DECODE_OVER);
241,442✔
202

203
  SDB_GET_INT64(pRaw, dataPos, &pTopic->stbUid, TOPIC_DECODE_OVER);
241,442✔
204
  if (sver >= 3) {
241,442✔
205
    SDB_GET_BINARY(pRaw, dataPos, pTopic->stbName, TSDB_TABLE_FNAME_LEN, TOPIC_DECODE_OVER);
241,442✔
206
  }
207
  SDB_GET_INT32(pRaw, dataPos, &pTopic->sqlLen, TOPIC_DECODE_OVER);
241,442✔
208
  pTopic->sql = taosMemoryCalloc(pTopic->sqlLen, sizeof(char));
241,442✔
209
  if (pTopic->sql == NULL) {
241,442✔
210
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
211
    goto TOPIC_DECODE_OVER;
×
212
  }
213
  SDB_GET_BINARY(pRaw, dataPos, pTopic->sql, pTopic->sqlLen, TOPIC_DECODE_OVER);
241,442✔
214

215
  if (sver < MND_TOPIC_VER_SUPPORT_OWNER) {
241,442✔
216
    int32_t astLen = 0;
×
217
    SDB_GET_INT32(pRaw, dataPos, &astLen, TOPIC_DECODE_OVER);
×
218
    if (astLen) {
×
219
      ast = taosMemoryCalloc(astLen, sizeof(char));
×
220
      if (ast == NULL) {
×
221
        terrno = TSDB_CODE_OUT_OF_MEMORY;
×
222
        goto TOPIC_DECODE_OVER;
×
223
      }
224
      SDB_GET_BINARY(pRaw, dataPos, ast, astLen, TOPIC_DECODE_OVER);
×
225
      terrno = processAst(pTopic, ast);
×
226
      if (terrno != TSDB_CODE_SUCCESS) {
×
227
        goto TOPIC_DECODE_OVER;
×
228
      }
229
    }
230
  } else {
231
    SDB_GET_INT32(pRaw, dataPos, &len, TOPIC_DECODE_OVER);
241,442✔
232
    if (len) {
241,442✔
233
      pTopic->physicalPlan = taosMemoryCalloc(len, sizeof(char));
241,442✔
234
      if (pTopic->physicalPlan == NULL) {
241,442✔
235
        terrno = TSDB_CODE_OUT_OF_MEMORY;
×
236
        goto TOPIC_DECODE_OVER;
×
237
      }
238
      SDB_GET_BINARY(pRaw, dataPos, pTopic->physicalPlan, len, TOPIC_DECODE_OVER);
241,442✔
239
    } else {
240
      pTopic->physicalPlan = NULL;
×
241
    }
242

243
    SDB_GET_INT32(pRaw, dataPos, &len, TOPIC_DECODE_OVER);
241,442✔
244
    if (len) {
241,442✔
245
      buf = taosMemoryMalloc(len);
188,708✔
246
      if (buf == NULL) {
188,708✔
247
        terrno = TSDB_CODE_OUT_OF_MEMORY;
×
248
        goto TOPIC_DECODE_OVER;
×
249
      }
250
      SDB_GET_BINARY(pRaw, dataPos, buf, len, TOPIC_DECODE_OVER);
188,708✔
251
      if (taosDecodeSSchemaWrapper(buf, &pTopic->schema) == NULL) {
377,416✔
252
        goto TOPIC_DECODE_OVER;
×
253
      }
254
    } else {
255
      pTopic->schema.nCols = 0;
52,734✔
256
      pTopic->schema.version = 0;
52,734✔
257
      pTopic->schema.pSchema = NULL;
52,734✔
258
    }
259
    SDB_GET_INT64(pRaw, dataPos, &pTopic->ownerId, TOPIC_DECODE_OVER);
241,442✔
260
  }
261

262
  SDB_GET_RESERVE(pRaw, dataPos, MND_TOPIC_RESERVE_SIZE, TOPIC_DECODE_OVER);
241,442✔
263
  terrno = TSDB_CODE_SUCCESS;
241,442✔
264

265
TOPIC_DECODE_OVER:
241,442✔
266
  taosMemoryFreeClear(buf);
241,442✔
267
  taosMemoryFreeClear(ast);
241,442✔
268

269
  if (terrno != TSDB_CODE_SUCCESS) {
241,442✔
270
    mError("topic:%s, failed to decode from raw:%p since %s", pTopic == NULL ? "null" : pTopic->name, pRaw, terrstr());
×
271
    taosMemoryFreeClear(pRow);
×
272
    return NULL;
×
273
  }
274

275
  mDebug("topic:%s, decode from raw:%p, row:%p", pTopic->name, pRaw, pTopic);
241,442✔
276
  return pRow;
241,442✔
277
}
278

279
static int32_t mndTopicActionInsert(SSdb *pSdb, SMqTopicObj *pTopic) {
143,611✔
280
  mDebug("topic:%s perform insert action", pTopic != NULL ? pTopic->name : "null");
143,611✔
281
  return 0;
143,611✔
282
}
283

284
static int32_t mndTopicActionDelete(SSdb *pSdb, SMqTopicObj *pTopic) {
241,442✔
285
  if (pTopic == NULL) return 0;
241,442✔
286
  mDebug("%p topic:%s perform delete action", pTopic, pTopic->name);
241,442✔
287
  taosMemoryFreeClear(pTopic->sql);
241,442✔
288
  taosMemoryFreeClear(pTopic->physicalPlan);
241,442✔
289
  if (pTopic->schema.nCols) taosMemoryFreeClear(pTopic->schema.pSchema);
241,442✔
290
  return 0;
241,442✔
291
}
292

293
static int32_t mndTopicActionUpdate(SSdb *pSdb, SMqTopicObj *pOldTopic, SMqTopicObj *pNewTopic) {
×
294
  if (pOldTopic == NULL || pNewTopic == NULL) return 0;
×
295
  mDebug("topic:%s perform update action", pOldTopic->name);
×
296
  taosWLockLatch(&pOldTopic->lock);
×
297
  SMqTopicObj tmpTopic = *pOldTopic;
×
298
  (void)memcpy(pOldTopic, pNewTopic, offsetof(SMqTopicObj, lock));
×
299
  *pNewTopic = tmpTopic;
×
300
  taosWUnLockLatch(&pOldTopic->lock);
×
301
  return 0;
×
302
}
303

304
int32_t mndAcquireTopic(SMnode *pMnode, const char *topicName, SMqTopicObj **pTopic) {
2,177,360✔
305
  if (pMnode == NULL || topicName == NULL || pTopic == NULL) {
2,177,360✔
306
    return TSDB_CODE_INVALID_PARA;
×
307
  }
308
  SSdb *pSdb = pMnode->pSdb;
2,177,360✔
309
  *pTopic = sdbAcquire(pSdb, SDB_TOPIC, topicName);
2,177,360✔
310
  if (*pTopic == NULL) {
2,177,360✔
311
    return TSDB_CODE_MND_TOPIC_NOT_EXIST;
132,777✔
312
  }
313
  return TSDB_CODE_SUCCESS;
2,044,583✔
314
}
315

316
void mndReleaseTopic(SMnode *pMnode, SMqTopicObj *pTopic) {
2,260,916✔
317
  if (pMnode == NULL) return;
2,260,916✔
318
  SSdb *pSdb = pMnode->pSdb;
2,260,916✔
319
  sdbRelease(pSdb, pTopic);
2,260,916✔
320
}
321

322
static int32_t mndCheckCreateTopicReq(SCMCreateTopicReq *pCreate) {
124,739✔
323
  if (pCreate == NULL) return TSDB_CODE_INVALID_PARA;
124,739✔
324
  if (pCreate->sql == NULL) return TSDB_CODE_MND_INVALID_TOPIC;
124,739✔
325

326
  if (pCreate->subType == TOPIC_SUB_TYPE__COLUMN) {
124,739✔
327
    if (pCreate->ast == NULL || pCreate->ast[0] == 0) return TSDB_CODE_MND_INVALID_TOPIC;
91,279✔
328
  } else if (pCreate->subType == TOPIC_SUB_TYPE__TABLE) {
33,460✔
329
    if (pCreate->subStbName[0] == 0) return TSDB_CODE_MND_INVALID_TOPIC;
9,429✔
330
  } else if (pCreate->subType == TOPIC_SUB_TYPE__DB) {
24,031✔
331
    if (pCreate->subDbName[0] == 0) return TSDB_CODE_MND_INVALID_TOPIC;
24,031✔
332
  }
333

334
  return 0;
124,739✔
335
}
336

337
static int32_t processAst(SMqTopicObj *topicObj, const char *ast) {
121,983✔
338
  SNode *     pAst = NULL;
121,983✔
339
  SQueryPlan *pPlan = NULL;
121,983✔
340
  int32_t     code = TSDB_CODE_SUCCESS;
121,983✔
341
  int32_t     lino = 0;
121,983✔
342

343
  PRINT_LOG_START
121,983✔
344
  if (ast == NULL) {
121,983✔
345
    topicObj->physicalPlan = taosStrdup("");
27,703✔
346
    goto END;
27,703✔
347
  }
348
  qDebugL("%s topic:%s ast %s", __func__, topicObj->name, ast);
94,280✔
349
  MND_TMQ_RETURN_CHECK(nodesStringToNode(ast, &pAst));
94,280✔
350
  MND_TMQ_RETURN_CHECK(qExtractResultSchema(pAst, &topicObj->schema.nCols, &topicObj->schema.pSchema));
94,280✔
351

352
  SPlanContext cxt = {.pAstRoot = pAst, .topicQuery = true};
94,280✔
353
  MND_TMQ_RETURN_CHECK(qCreateQueryPlan(&cxt, &pPlan, NULL));
94,280✔
354
  if (pPlan == NULL) {
94,280✔
355
    code = TSDB_CODE_MND_INVALID_TOPIC_QUERY;
×
356
    goto END;
×
357
  }
358
  int32_t levelNum = LIST_LENGTH(pPlan->pSubplans);
94,280✔
359
  if (levelNum != 1) {
94,280✔
360
    code = TSDB_CODE_MND_INVALID_TOPIC_QUERY;
×
361
    goto END;
×
362
  }
363

364
  SNodeListNode *pNodeListNode = (SNodeListNode *)nodesListGetNode(pPlan->pSubplans, 0);
94,280✔
365
  MND_TMQ_NULL_CHECK(pNodeListNode);
94,280✔
366
  int32_t opNum = LIST_LENGTH(pNodeListNode->pNodeList);
94,280✔
367
  if (opNum != 1) {
94,280✔
368
    code = TSDB_CODE_MND_INVALID_TOPIC_QUERY;
×
369
    goto END;
×
370
  }
371

372
  code = nodesNodeToString(nodesListGetNode(pNodeListNode->pNodeList, 0), false, &topicObj->physicalPlan, NULL);
94,280✔
373

374
END:
121,983✔
375
  nodesDestroyNode(pAst);
121,983✔
376
  qDestroyQueryPlan(pPlan);
121,983✔
377
  PRINT_LOG_END
121,983✔
378
  return code;
121,983✔
379
}
380

381
static int32_t mndCreateTopic(SMnode *pMnode, SRpcMsg *pReq, SCMCreateTopicReq *pCreate, SDbObj *pDb,
121,983✔
382
                              SUserObj *pOperUser) {
383
  if (pMnode == NULL || pReq == NULL || pCreate == NULL || pDb == NULL || pOperUser == NULL)
121,983✔
384
    return TSDB_CODE_INVALID_PARA;
×
385
  STrans *    pTrans = NULL;
121,983✔
386
  int32_t     code = 0;
121,983✔
387
  int32_t     lino = 0;
121,983✔
388
  SMqTopicObj topicObj = {0};
121,983✔
389

390
  PRINT_LOG_START
121,983✔
391
  mInfo("start to create topic:%s", pCreate->name);
121,983✔
392
  pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB, pReq, "create-topic");
121,983✔
393
  MND_TMQ_NULL_CHECK(pTrans);
121,983✔
394
  mndTransSetDbName(pTrans, pDb->name, NULL);
121,983✔
395
  MND_TMQ_RETURN_CHECK(mndTransCheckConflict(pMnode, pTrans));
121,983✔
396

397
  tstrncpy(topicObj.name, pCreate->name, TSDB_TOPIC_FNAME_LEN);
121,983✔
398
  tstrncpy(topicObj.db, pDb->name, TSDB_DB_FNAME_LEN);
121,983✔
399
  tstrncpy(topicObj.createUser, pOperUser->name, TSDB_USER_LEN);
121,983✔
400
  topicObj.ownerId = pOperUser->uid;
121,983✔
401

402
  // MND_TMQ_RETURN_CHECK(mndCheckTopicPrivilege(pMnode, RPC_MSG_USER(pReq), MND_OPER_CREATE_TOPIC, &topicObj));
403
  if (pDb) {
121,983✔
404
    // already checked in parser, just check db use privilege here
405
    MND_TMQ_RETURN_CHECK(
121,983✔
406
        mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_DB_USE, PRIV_OBJ_DB, pDb->ownerId, pDb->name, NULL));
407
  }
408

409
  topicObj.createTime = taosGetTimestampMs();
121,983✔
410
  topicObj.updateTime = topicObj.createTime;
121,983✔
411
  topicObj.uid = mndGenerateUid(pCreate->name, strlen(pCreate->name));
121,983✔
412
  topicObj.dbUid = pDb->uid;
121,983✔
413
  topicObj.version = 1;
121,983✔
414
  topicObj.sql = taosStrdup(pCreate->sql);
121,983✔
415
  MND_TMQ_NULL_CHECK(topicObj.sql);
121,983✔
416
  topicObj.sqlLen = strlen(pCreate->sql) + 1;
121,983✔
417
  topicObj.subType = pCreate->subType;
121,983✔
418
  topicObj.withMeta = pCreate->withMeta;
121,983✔
419
  taosInitRWLatch(&topicObj.lock);
121,983✔
420

421
  MND_TMQ_RETURN_CHECK(processAst(&topicObj, pCreate->ast));
121,983✔
422

423
  if (pCreate->subStbName[0] != 0) {
121,983✔
424
    tstrncpy(topicObj.stbName, pCreate->subStbName, TSDB_TABLE_FNAME_LEN);
90,706✔
425
    SStbObj *pStb = mndAcquireStb(pMnode, topicObj.stbName);
90,706✔
426
    MND_TMQ_NULL_CHECK(pStb);
90,706✔
427
    char stbName[TSDB_TABLE_NAME_LEN] = {0};
89,263✔
428
    mndExtractTbNameFromStbFullName(pStb->name, stbName, TSDB_TABLE_NAME_LEN);
89,263✔
429
    MND_TMQ_RETURN_CHECK(
89,263✔
430
        mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_TOPIC_CREATE, PRIV_OBJ_DB, pStb->ownerId, pDb->name, NULL));
431
    MND_TMQ_RETURN_CHECK(
89,263✔
432
        mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_TBL_SELECT, PRIV_OBJ_TBL, pStb->ownerId, pDb->name, stbName));
433
    topicObj.stbUid = pStb->uid;
89,263✔
434
    mndReleaseStb(pMnode, pStb);
89,263✔
435
  }
436

437
  if (pCreate->subType == TOPIC_SUB_TYPE__DB) {
120,540✔
438
    MND_TMQ_RETURN_CHECK(
23,026✔
439
        mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_TOPIC_CREATE, PRIV_OBJ_DB, pDb->ownerId, pDb->name, NULL));
440
    MND_TMQ_RETURN_CHECK(mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_TBL_SELECT, PRIV_OBJ_TBL, 0, pDb->name, "*"));
23,026✔
441
  } else if (pCreate->subType == TOPIC_SUB_TYPE__COLUMN) {
97,514✔
442
    // TODO: check privilege on table
443
  }
444

445
  SSdbRaw *pCommitRaw = mndTopicActionEncode(&topicObj);
120,540✔
446
  MND_TMQ_NULL_CHECK(pCommitRaw);
120,540✔
447
  code = mndTransAppendCommitlog(pTrans, pCommitRaw);
120,540✔
448
  if (code != 0) {
120,540✔
449
    sdbFreeRaw(pCommitRaw);
×
450
    goto END;
×
451
  }
452

453
  MND_TMQ_RETURN_CHECK(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
120,540✔
454
  MND_TMQ_RETURN_CHECK(mndTransPrepare(pMnode, pTrans));
120,540✔
455

456
END:
121,983✔
457
  PRINT_LOG_END
121,983✔
458
  taosMemoryFreeClear(topicObj.sql);
121,983✔
459
  taosMemoryFreeClear(topicObj.physicalPlan);
121,983✔
460
  if (topicObj.schema.nCols) {
121,983✔
461
    taosMemoryFreeClear(topicObj.schema.pSchema);
94,280✔
462
  }
463
  mndTransDrop(pTrans);
121,983✔
464
  return code;
121,983✔
465
}
466

467
static int32_t mndReloadTopic(SMnode *pMnode, SRpcMsg *pReq, SCMCreateTopicReq *pCreate, SDbObj *pDb,
×
468
                              const char *userName, SMqTopicObj *topicObjOri) {
469
  if (pMnode == NULL || pReq == NULL || pCreate == NULL || pDb == NULL || userName == NULL)
×
470
    return TSDB_CODE_INVALID_PARA;
×
471
  STrans *    pTrans = NULL;
×
472
  int32_t     code = 0;
×
473
  int32_t     lino = 0;
×
474
  SMqTopicObj topicObj = {0};
×
475

476
  PRINT_LOG_START
×
477
  mInfo("start to reload topic:%s", pCreate->name);
×
478
  pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB, pReq, "reload-topic");
×
479
  MND_TMQ_NULL_CHECK(pTrans);
×
480
  mndTransSetDbName(pTrans, pDb->name, NULL);
×
481
  MND_TMQ_RETURN_CHECK(mndTransCheckConflict(pMnode, pTrans));
×
482

483
  tstrncpy(topicObj.name, pCreate->name, TSDB_TOPIC_FNAME_LEN);
×
484
  tstrncpy(topicObj.db, pDb->name, TSDB_DB_FNAME_LEN);
×
485
  tstrncpy(topicObj.createUser, userName, TSDB_USER_LEN);
×
486

487
  MND_TMQ_RETURN_CHECK(mndCheckTopicPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_CREATE_TOPIC, &topicObj));
×
488

489
  taosRLockLatch(&topicObjOri->lock);
×
490
  topicObj.createTime = topicObjOri->createTime;
×
491
  topicObj.updateTime = taosGetTimestampMs();
×
492
  topicObj.uid = topicObjOri->uid;
×
493
  topicObj.dbUid = pDb->uid;
×
494
  topicObj.version = topicObjOri->version + 1;
×
495
  topicObj.sql = taosStrdup(pCreate->sql);
×
496
  topicObj.sqlLen = strlen(pCreate->sql) + 1;
×
497
  topicObj.subType = pCreate->subType;
×
498
  topicObj.withMeta = pCreate->withMeta;
×
499
  taosInitRWLatch(&topicObj.lock);
×
500
  taosRUnLockLatch(&topicObjOri->lock);
×
501

502
  MND_TMQ_RETURN_CHECK(processAst(&topicObj, pCreate->ast));
×
503

504
  if (pCreate->subStbName[0] != 0) {
×
505
    tstrncpy(topicObj.stbName, pCreate->subStbName, TSDB_TABLE_FNAME_LEN);
×
506
    SStbObj *pStb = mndAcquireStb(pMnode, topicObj.stbName);
×
507
    MND_TMQ_NULL_CHECK(pStb);
×
508
    topicObj.stbUid = pStb->uid;
×
509
    mndReleaseStb(pMnode, pStb);
×
510
  }
511

512
  SSdbRaw *pCommitRaw = mndTopicActionEncode(&topicObj);
×
513
  MND_TMQ_NULL_CHECK(pCommitRaw);
×
514
  code = mndTransAppendCommitlog(pTrans, pCommitRaw);
×
515
  if (code != 0) {
×
516
    sdbFreeRaw(pCommitRaw);
×
517
    goto END;
×
518
  }
519

520
  MND_TMQ_RETURN_CHECK(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
×
521
  MND_TMQ_RETURN_CHECK(mndTransPrepare(pMnode, pTrans));
×
522

523
END:
×
524
  PRINT_LOG_END
×
525
  taosMemoryFreeClear(topicObj.sql);
×
526
  taosMemoryFreeClear(topicObj.physicalPlan);
×
527
  if (topicObj.schema.nCols) {
×
528
    taosMemoryFreeClear(topicObj.schema.pSchema);
×
529
  }
530
  mndTransDrop(pTrans);
×
531
  return code;
×
532
}
533

534
static int32_t creatTopic(SRpcMsg *pReq, SCMCreateTopicReq *createTopicReq, SUserObj *pOperUser) {
124,739✔
535
  SMqTopicObj *pTopic = NULL;
124,739✔
536
  SDbObj *     pDb = NULL;
124,739✔
537
  int32_t      code = TSDB_CODE_SUCCESS;
124,739✔
538
  int32_t      lino = 0;
124,739✔
539
  SMnode *     pMnode = pReq->info.node;
124,739✔
540
  int64_t      tss = taosGetTimestampMs();
124,739✔
541

542
  PRINT_LOG_START
124,739✔
543
  mInfo("topic:%s start to create, sql:%s", createTopicReq->name, createTopicReq->sql);
124,739✔
544
  code = mndAcquireTopic(pMnode, createTopicReq->name, &pTopic);
124,739✔
545
  if (code == TSDB_CODE_SUCCESS) {
124,739✔
546
    mndReleaseTopic(pMnode, pTopic);
698✔
547
    if (createTopicReq->igExists) {
698✔
548
      mInfo("topic:%s already exist, ignore exist is set", createTopicReq->name);
698✔
549
    } else {
550
      code = TSDB_CODE_MND_TOPIC_ALREADY_EXIST;
×
551
    }
552
    goto END;
698✔
553
  } else if (code != TSDB_CODE_MND_TOPIC_NOT_EXIST) {
124,041✔
554
    goto END;
×
555
  }
556

557
  pDb = mndAcquireDb(pMnode, createTopicReq->subDbName);
124,041✔
558
  MND_TMQ_NULL_CHECK(pDb);
124,041✔
559

560
  if (pDb->cfg.walRetentionPeriod == 0) {
123,387✔
561
    code = TSDB_CODE_MND_DB_RETENTION_PERIOD_ZERO;
×
562
    goto END;
×
563
  }
564

565
  if (sdbGetSize(pMnode->pSdb, SDB_TOPIC) >= tmqMaxTopicNum) {
123,387✔
566
    code = TSDB_CODE_TMQ_TOPIC_OUT_OF_RANGE;
1,404✔
567
    goto END;
1,404✔
568
  }
569

570
  MND_TMQ_RETURN_CHECK(grantCheck(TSDB_GRANT_SUBSCRIPTION));
121,983✔
571
  MND_TMQ_RETURN_CHECK(mndCreateTopic(pMnode, pReq, createTopicReq, pDb, pOperUser));
121,983✔
572
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
120,540✔
573
    int64_t tse = taosGetTimestampMs();
120,540✔
574
    double  duration = (double)(tse - tss);
120,540✔
575
    duration = duration / 1000;
120,540✔
576
    auditRecord(pReq, pMnode->clusterId, "createTopic", createTopicReq->subDbName, createTopicReq->name,
120,540✔
577
                createTopicReq->sql, strlen(createTopicReq->sql), duration, 0);
120,540✔
578
  }
579
  code = TSDB_CODE_ACTION_IN_PROGRESS;
120,540✔
580

581
END:
124,739✔
582
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
124,739✔
583
    mError("%s failed, topic:%s since %s", __func__, createTopicReq->name, tstrerror(code));
3,501✔
584
  } else {
585
    mInfo("topic:%s create successfully", createTopicReq->name);
121,238✔
586
  }
587
  mndReleaseDb(pMnode, pDb);
124,739✔
588
  return code;
124,739✔
589
}
590

591
static int32_t reloadTopic(SRpcMsg *pReq, SCMCreateTopicReq *createTopicReq) {
×
592
  SMnode *     pMnode = pReq->info.node;
×
593
  int32_t      code = TSDB_CODE_SUCCESS;
×
594
  int32_t      lino = 0;
×
595
  SDbObj *     pDb = NULL;
×
596
  SMqTopicObj *pTopic = NULL;
×
597
  int64_t      tss = taosGetTimestampMs();
×
598

599
  PRINT_LOG_START
×
600
  code = mndAcquireTopic(pMnode, createTopicReq->name, &pTopic);
×
601
  if (code != 0) {
×
602
    if (createTopicReq->igExists) {
×
603
      mInfo("topic:%s, not exist, ignore not exist is set", createTopicReq->name);
×
604
      code = 0;
×
605
      goto END;
×
606
    } else {
607
      mError("topic:%s, failed to reload since %s", createTopicReq->name, tstrerror(code));
×
608
      goto END;
×
609
    }
610
  }
611

612
  pDb = mndAcquireDb(pMnode, createTopicReq->subDbName);
×
613
  MND_TMQ_NULL_CHECK(pDb);
×
614

615
  MND_TMQ_RETURN_CHECK(grantCheck(TSDB_GRANT_SUBSCRIPTION));
×
616
  MND_TMQ_RETURN_CHECK(mndReloadTopic(pMnode, pReq, createTopicReq, pDb, RPC_MSG_USER(pReq), pTopic));
×
617

618
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
×
619
    int64_t tse = taosGetTimestampMs();
×
620
    double  duration = (double)(tse - tss);
×
621
    duration = duration / 1000;
×
622
    auditRecord(pReq, pMnode->clusterId, "reloadTopic", createTopicReq->subDbName, createTopicReq->name,
×
623
                createTopicReq->sql, strlen(createTopicReq->sql), duration, 0);
×
624
  }
625

626
  code = TSDB_CODE_ACTION_IN_PROGRESS;
×
627

628
  if (topicsToReload == NULL) {
×
629
    topicsToReload = taosHashInit(4, taosGetDefaultHashFunction(TSDB_DATA_TYPE_BINARY), true, HASH_NO_LOCK);
×
630
    MND_TMQ_NULL_CHECK(topicsToReload);
×
631
  }
632
  MND_TMQ_RETURN_CHECK(
×
633
      taosHashPut(topicsToReload, createTopicReq->name, strlen(createTopicReq->name), createTopicReq->name, 1));
634
  mInfo("topic:%s, marked to reload", createTopicReq->name);
×
635

636
END:
×
637
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
×
638
    mError("%s failed, topic:%s since %s", __func__, createTopicReq->name, tstrerror(code));
×
639
  } else {
640
    mInfo("topic:%s create successfully", createTopicReq->name);
×
641
  }
642
  mndReleaseTopic(pMnode, pTopic);
×
643
  mndReleaseDb(pMnode, pDb);
×
644

645
  return code;
×
646
}
647

648
static int32_t mndProcessCreateTopicReq(SRpcMsg *pReq) {
124,739✔
649
  if (pReq == NULL || pReq->contLen <= 0) {
124,739✔
650
    return TSDB_CODE_INVALID_MSG;
×
651
  }
652
  SMnode *pMnode = pReq->info.node;
124,739✔
653
  SUserObj *pOperUser = NULL;
124,739✔
654
  int32_t code = TSDB_CODE_SUCCESS;
124,739✔
655
  int32_t lino = 0;
124,739✔
656

657
  SCMCreateTopicReq createTopicReq = {0};
124,739✔
658

659
  PRINT_LOG_START
124,739✔
660
  MND_TMQ_RETURN_CHECK(tDeserializeSCMCreateTopicReq(pReq->pCont, pReq->contLen, &createTopicReq));
124,739✔
661

662
  if ((code = mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser)) != 0) goto END;
124,739✔
663

664
  mInfo("topic:%s start to create, sql:%s", createTopicReq.name, createTopicReq.sql);
124,739✔
665

666
  MND_TMQ_RETURN_CHECK(mndCheckCreateTopicReq(&createTopicReq));
124,739✔
667

668
  if (createTopicReq.reload) {
124,739✔
669
    MND_TMQ_RETURN_CHECK(reloadTopic(pReq, &createTopicReq));
×
670
  } else {
671
    MND_TMQ_RETURN_CHECK(creatTopic(pReq, &createTopicReq, pOperUser));
124,739✔
672
  }
673

674
END:
124,687✔
675
  tFreeSCMCreateTopicReq(&createTopicReq);
124,739✔
676
  mndReleaseUser(pMnode, pOperUser);
124,739✔
677
  return code;
124,739✔
678
}
679

680
static int32_t mndDropTopic(SMnode *pMnode, STrans *pTrans, SRpcMsg *pReq, SMqTopicObj *pTopic) {
97,003✔
681
  if (pMnode == NULL || pTrans == NULL || pReq == NULL || pTopic == NULL) {
97,003✔
682
    return TSDB_CODE_INVALID_MSG;
×
683
  }
684
  int32_t  code = 0;
97,003✔
685
  int32_t  lino = 0;
97,003✔
686
  SSdbRaw *pCommitRaw = NULL;
97,003✔
687
  PRINT_LOG_START
97,003✔
688
  MND_TMQ_RETURN_CHECK(mndUserRemoveTopic(pMnode, pTrans, pTopic->name));
97,003✔
689
  pCommitRaw = mndTopicActionEncode(pTopic);
97,003✔
690
  MND_TMQ_NULL_CHECK(pCommitRaw);
97,003✔
691
  code = mndTransAppendCommitlog(pTrans, pCommitRaw);
97,003✔
692
  if (code != 0) {
97,003✔
693
    sdbFreeRaw(pCommitRaw);
×
694
    goto END;
×
695
  }
696
  MND_TMQ_RETURN_CHECK(sdbSetRawStatus(pCommitRaw, SDB_STATUS_DROPPED));
97,003✔
697
  MND_TMQ_RETURN_CHECK(mndTransPrepare(pMnode, pTrans));
97,003✔
698

699
END:
97,003✔
700
  PRINT_LOG_END
97,003✔
701
  return code;
97,003✔
702
}
703

704
bool checkTopic(SArray *topics, char *topicName) {
102,348✔
705
  if (topics == NULL || topicName == NULL) {
102,348✔
706
    return false;
×
707
  }
708
  int32_t sz = taosArrayGetSize(topics);
102,348✔
709
  for (int32_t i = 0; i < sz; i++) {
102,971✔
710
    char *name = taosArrayGetP(topics, i);
1,637✔
711
    if (name && strcmp(name, topicName) == 0) {
1,637✔
712
      return true;
1,014✔
713
    }
714
  }
715
  return false;
101,334✔
716
}
717

718
static int32_t checkConsumer(STrans *pTrans, SMqConsumerObj *pConsumer, bool deleteConsumer, char *topicName) {
33,526✔
719
  int32_t         code = 0;
33,526✔
720
  int32_t         lino = 0;
33,526✔
721
  SMqConsumerObj *pConsumerNew = NULL;
33,526✔
722

723
  taosRLockLatch(&pConsumer->lock);
33,526✔
724
  bool found1 = checkTopic(pConsumer->assignedTopics, topicName);
33,526✔
725
  bool found2 = checkTopic(pConsumer->rebRemovedTopics, topicName);
33,526✔
726
  bool found3 = checkTopic(pConsumer->rebNewTopics, topicName);
33,526✔
727
  if (found1 || found2 || found3) {
33,526✔
728
    if (deleteConsumer) {
687✔
729
      MND_TMQ_RETURN_CHECK(tNewSMqConsumerObj(pConsumer->consumerId, pConsumer->cgroup, CONSUMER_CLEAR, NULL, NULL, &pConsumerNew));
687✔
730
      MND_TMQ_RETURN_CHECK(mndSetConsumerDropLogs(pTrans, pConsumerNew));
687✔
731
      tDeleteSMqConsumerObj(pConsumerNew);
687✔
732
      pConsumerNew = NULL;
687✔
733
    } else {
UNCOV
734
      mError("topic:%s, failed to drop since subscribed by consumer:0x%" PRIx64 ", in consumer group %s", topicName,
×
735
             pConsumer->consumerId, pConsumer->cgroup);
UNCOV
736
      code = TSDB_CODE_MND_TOPIC_SUBSCRIBED;
×
UNCOV
737
      goto END;
×
738
    }
739
  }
740
END:
33,526✔
741
  taosRUnLockLatch(&pConsumer->lock);
33,526✔
742
  tDeleteSMqConsumerObj(pConsumerNew);
33,526✔
743
  return code;
33,526✔
744
}
745

746
static int32_t mndCheckConsumerByTopic(SMnode *pMnode, STrans *pTrans, char *topicName, bool deleteConsumer) {
97,003✔
747
  if (pMnode == NULL || pTrans == NULL || topicName == NULL) {
97,003✔
748
    return TSDB_CODE_INVALID_MSG;
×
749
  }
750
  int32_t         code = 0;
97,003✔
751
  int32_t         lino = 0;
97,003✔
752
  SSdb *          pSdb = pMnode->pSdb;
97,003✔
753
  void *          pIter = NULL;
97,003✔
754
  SMqConsumerObj *pConsumer = NULL;
97,003✔
755

756
  PRINT_LOG_START
97,003✔
757
  while (1) {
758
    pIter = sdbFetch(pSdb, SDB_CONSUMER, pIter, (void **)&pConsumer);
130,529✔
759
    if (pIter == NULL) {
130,529✔
760
      break;
97,003✔
761
    }
762

763
    MND_TMQ_RETURN_CHECK(checkConsumer(pTrans, pConsumer, deleteConsumer, topicName));
33,526✔
764
    sdbRelease(pSdb, pConsumer);
33,526✔
765
  }
766

767
END:
97,003✔
768
  PRINT_LOG_END
97,003✔
769
  sdbRelease(pSdb, pConsumer);
97,003✔
770
  sdbCancelFetch(pSdb, pIter);
97,003✔
771
  return code;
97,003✔
772
}
773

774
static int32_t mndProcessDropTopicReq(SRpcMsg *pReq) {
105,314✔
775
  if (pReq == NULL) {
105,314✔
776
    return TSDB_CODE_INVALID_MSG;
×
777
  }
778
  SMnode *       pMnode = pReq->info.node;
105,314✔
779
  SMDropTopicReq dropReq = {0};
105,314✔
780
  int32_t        code = 0;
105,314✔
781
  int32_t        lino = 0;
105,314✔
782
  SMqTopicObj *  pTopic = NULL;
105,314✔
783
  STrans *       pTrans = NULL;
105,314✔
784
  SUserObj      *pOperUser = NULL;
105,314✔
785
  int64_t        tss = taosGetTimestampMs();
105,314✔
786

787
  PRINT_LOG_START
105,314✔
788
  MND_TMQ_RETURN_CHECK(tDeserializeSMDropTopicReq(pReq->pCont, pReq->contLen, &dropReq));
105,314✔
789

790
  code = mndAcquireTopic(pMnode, dropReq.name, &pTopic);
105,314✔
791
  if (code != 0) {
105,314✔
792
    if (dropReq.igNotExists) {
7,293✔
793
      mInfo("topic:%s, not exist, ignore not exist is set", dropReq.name);
7,293✔
794
      code = 0;
7,293✔
795
    }
796
    goto END;
7,293✔
797
  }
798
  taosRLockLatch(&pTopic->lock);
98,021✔
799

800
  pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB, pReq, "drop-topic");
98,021✔
801
  MND_TMQ_NULL_CHECK(pTrans);
98,021✔
802

803
  mndTransSetDbName(pTrans, pTopic->db, NULL);
98,021✔
804
  MND_TMQ_RETURN_CHECK(mndTransCheckConflict(pMnode, pTrans));
98,021✔
805
  mInfo("trans:%d, used to drop topic:%s, force:%d", pTrans->id, pTopic->name, dropReq.force);
97,172✔
806

807
  MND_TMQ_RETURN_CHECK(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser));
97,172✔
808

809
  // MND_TMQ_RETURN_CHECK(mndCheckTopicPrivilege(pMnode, RPC_MSG_USER(pReq), MND_OPER_DROP_TOPIC, pTopic));
810
  // MND_TMQ_RETURN_CHECK(mndCheckDbPrivilegeByName(pMnode, RPC_MSG_USER(pReq), MND_OPER_READ_DB, pTopic->db));
811
  MND_TMQ_RETURN_CHECK(mndCheckDbPrivilegeByNameRecF(pMnode, pOperUser, PRIV_DB_USE, PRIV_OBJ_DB, pTopic->db, NULL));
97,172✔
812
  MND_TMQ_RETURN_CHECK(mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_DROP, PRIV_OBJ_TOPIC, pTopic->ownerId,
97,172✔
813
                                                pTopic->db, mndGetDbStr(pTopic->name)));
814
  MND_TMQ_RETURN_CHECK(mndCheckConsumerByTopic(pMnode, pTrans, dropReq.name, dropReq.force));
97,003✔
815
  MND_TMQ_RETURN_CHECK(mndDropSubByTopic(pMnode, pTrans, dropReq.name, dropReq.force));
97,003✔
816
  MND_TMQ_RETURN_CHECK(mndDropTopic(pMnode, pTrans, pReq, pTopic));
97,003✔
817
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
97,003✔
818
    int64_t tse = taosGetTimestampMs();
97,003✔
819
    double  duration = (double)(tse - tss);
97,003✔
820
    duration = duration / 1000;
97,003✔
821
    auditRecord(pReq, pMnode->clusterId, "dropTopic", pTopic->db, dropReq.name, dropReq.sql, dropReq.sqlLen, duration,
97,003✔
822
                0);
823
  }
824

825
  code = TSDB_CODE_ACTION_IN_PROGRESS;
97,003✔
826

827
END:
105,314✔
828
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
105,314✔
829
    mError("%s failed, topic:%s since %s", __func__, dropReq.name, tstrerror(code));
1,018✔
830
  } else {
831
    mInfo("topic:%s dropped successfully", dropReq.name);
104,296✔
832
  }
833
  if (pTopic != NULL) {
105,314✔
834
    taosRUnLockLatch(&pTopic->lock);
98,021✔
835
  }
836
  mndReleaseTopic(pMnode, pTopic);
105,314✔
837
  mndReleaseUser(pMnode, pOperUser);
105,314✔
838
  mndTransDrop(pTrans);
105,314✔
839
  tFreeSMDropTopicReq(&dropReq);
105,314✔
840
  return code;
105,314✔
841
}
842

843
int32_t mndGetNumOfTopics(SMnode *pMnode, char *dbName, int32_t *pNumOfTopics) {
112,073✔
844
  if (pMnode == NULL || dbName == NULL || pNumOfTopics == NULL) {
112,073✔
845
    return TSDB_CODE_INVALID_MSG;
×
846
  }
847
  *pNumOfTopics = 0;
112,073✔
848

849
  SSdb *  pSdb = pMnode->pSdb;
112,073✔
850
  SDbObj *pDb = mndAcquireDb(pMnode, dbName);
112,073✔
851
  if (pDb == NULL) {
112,073✔
852
    return TSDB_CODE_MND_DB_NOT_SELECTED;
×
853
  }
854

855
  int32_t numOfTopics = 0;
112,073✔
856
  void *  pIter = NULL;
112,073✔
857
  while (1) {
×
858
    SMqTopicObj *pTopic = NULL;
112,073✔
859
    pIter = sdbFetch(pSdb, SDB_TOPIC, pIter, (void **)&pTopic);
112,073✔
860
    if (pIter == NULL) {
112,073✔
861
      break;
112,073✔
862
    }
863
    taosRLockLatch(&pTopic->lock);
×
864
    if (pTopic->dbUid == pDb->uid) {
×
865
      numOfTopics++;
×
866
    }
867
    taosRUnLockLatch(&pTopic->lock);
×
868

869
    sdbRelease(pSdb, pTopic);
×
870
  }
871

872
  *pNumOfTopics = numOfTopics;
112,073✔
873
  mndReleaseDb(pMnode, pDb);
112,073✔
874
  return 0;
112,073✔
875
}
876

877
static void schemaToJson(SSchema *schema, int32_t nCols, char *schemaJson) {
48,639✔
878
  if (schema == NULL || schemaJson == NULL) {
48,639✔
879
    return;
×
880
  }
881
  char *  string = NULL;
48,639✔
882
  int32_t code = 0;
48,639✔
883
  int32_t lino = 0;
48,639✔
884

885
  cJSON *cbytes = NULL;
48,639✔
886
  cJSON *ctype = NULL;
48,639✔
887
  cJSON *cname = NULL;
48,639✔
888
  cJSON *column = NULL;
48,639✔
889
  cJSON *columns = cJSON_CreateArray();
48,639✔
890
  MND_TMQ_NULL_CHECK(columns);
48,639✔
891
  for (int i = 0; i < nCols; i++) {
544,360✔
892
    column = cJSON_CreateObject();
495,721✔
893
    MND_TMQ_NULL_CHECK(column);
495,721✔
894
    SSchema *s = schema + i;
495,721✔
895
    cname = cJSON_CreateString(s->name);
495,721✔
896
    MND_TMQ_NULL_CHECK(cname);
495,721✔
897
    MND_TMQ_CONDITION_CHECK(cJSON_AddItemToObject(column, "name", cname), 0);
495,721✔
898
    cname = NULL;  // ownership transferred to column object
495,721✔
899

900
    ctype = cJSON_CreateString(tDataTypes[s->type].name);
495,721✔
901
    MND_TMQ_NULL_CHECK(ctype);
495,721✔
902
    MND_TMQ_CONDITION_CHECK(cJSON_AddItemToObject(column, "type", ctype), 0);
495,721✔
903
    ctype = NULL;  // ownership transferred to column object
495,721✔
904

905
    int32_t length = 0;
495,721✔
906
    if (s->type == TSDB_DATA_TYPE_BINARY || s->type == TSDB_DATA_TYPE_VARBINARY || s->type == TSDB_DATA_TYPE_GEOMETRY) {
495,721✔
907
      length = s->bytes - VARSTR_HEADER_SIZE;
92,577✔
908
    } else if (s->type == TSDB_DATA_TYPE_NCHAR || s->type == TSDB_DATA_TYPE_JSON) {
403,144✔
909
      length = (s->bytes - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE;
62,664✔
910
    } else {
911
      length = s->bytes;
340,480✔
912
    }
913
    cbytes = cJSON_CreateNumber(length);
495,721✔
914
    MND_TMQ_NULL_CHECK(cbytes);
495,721✔
915
    MND_TMQ_CONDITION_CHECK(cJSON_AddItemToObject(column, "length", cbytes), 0);
495,721✔
916
    cbytes = NULL;  // ownership transferred to column object
495,721✔
917

918
    MND_TMQ_CONDITION_CHECK(cJSON_AddItemToArray(columns, column), 0);
495,721✔
919
    column = NULL;  // ownership transferred to columns array
495,721✔
920
  }
921

922
END:
48,639✔
923
  string = cJSON_PrintUnformatted(columns);
48,639✔
924
  cJSON_Delete(columns);
48,639✔
925
  cJSON_Delete(column);
48,639✔
926
  cJSON_Delete(cname);
48,639✔
927
  cJSON_Delete(ctype);
48,639✔
928
  cJSON_Delete(cbytes);
48,639✔
929

930
  size_t len = strlen(string);
48,639✔
931
  if (string && len <= TSDB_SHOW_SCHEMA_JSON_LEN) {
48,639✔
932
    STR_TO_VARSTR(schemaJson, string);
48,639✔
933
  } else {
934
    mError("mndRetrieveTopic build schema error json:%p, json len:%zu", string, len);
×
935
    STR_TO_VARSTR(schemaJson, "NULL");
×
936
  }
937
  taosMemoryFree(string);
48,639✔
938
}
939

940
static int32_t buildResult(SMqTopicObj *pTopic, int32_t *numOfRows, SMnode *pMnode, SSDataBlock *pBlock) {
50,060✔
941
  SColumnInfoData *pColInfo = NULL;
50,060✔
942
  SName            n = {0};
50,060✔
943
  int32_t          cols = 0;
50,060✔
944
  char *           schemaJson = NULL;
50,060✔
945
  char *           sql = NULL;
50,060✔
946
  int32_t          code = 0;
50,060✔
947
  int32_t          lino = 0;
50,060✔
948

949
  taosRLockLatch(&pTopic->lock);
50,060✔
950

951
  char        topicName[TSDB_TOPIC_NAME_LEN + VARSTR_HEADER_SIZE + 5] = {0};
50,060✔
952
  const char *pName = mndGetDbStr(pTopic->name);
50,060✔
953
  STR_TO_VARSTR(topicName, pName);
50,060✔
954

955
  pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
50,060✔
956
  MND_TMQ_NULL_CHECK(pColInfo);
50,060✔
957
  MND_TMQ_RETURN_CHECK(colDataSetVal(pColInfo, *numOfRows, (const char *)topicName, false));
50,060✔
958

959
  char dbName[TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
50,060✔
960
  MND_TMQ_RETURN_CHECK(tNameFromString(&n, pTopic->db, T_NAME_ACCT | T_NAME_DB));
50,060✔
961
  MND_TMQ_RETURN_CHECK(tNameGetDbName(&n, varDataVal(dbName)));
50,060✔
962
  varDataSetLen(dbName, strlen(varDataVal(dbName)));
50,060✔
963

964
  pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
50,060✔
965
  MND_TMQ_NULL_CHECK(pColInfo);
50,060✔
966
  MND_TMQ_RETURN_CHECK(colDataSetVal(pColInfo, *numOfRows, (const char *)dbName, false));
50,060✔
967

968
  pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
50,060✔
969
  MND_TMQ_NULL_CHECK(pColInfo);
50,060✔
970
  MND_TMQ_RETURN_CHECK(colDataSetVal(pColInfo, *numOfRows, (const char *)&pTopic->createTime, false));
50,060✔
971

972
  sql = taosMemoryMalloc(strlen(pTopic->sql) + VARSTR_HEADER_SIZE);
50,060✔
973
  MND_TMQ_NULL_CHECK(sql);
50,060✔
974
  STR_TO_VARSTR(sql, pTopic->sql);
50,060✔
975

976
  pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
50,060✔
977
  MND_TMQ_NULL_CHECK(pColInfo);
50,060✔
978
  MND_TMQ_RETURN_CHECK(colDataSetVal(pColInfo, *numOfRows, (const char *)sql, false));
50,060✔
979

980
  taosMemoryFreeClear(sql);
50,060✔
981

982
  schemaJson = taosMemoryMalloc(TSDB_SHOW_SCHEMA_JSON_LEN + VARSTR_HEADER_SIZE);
50,060✔
983
  MND_TMQ_NULL_CHECK(schemaJson);
50,060✔
984
  if (pTopic->subType == TOPIC_SUB_TYPE__COLUMN) {
50,060✔
985
    schemaToJson(pTopic->schema.pSchema, pTopic->schema.nCols, schemaJson);
48,298✔
986
  } else if (pTopic->subType == TOPIC_SUB_TYPE__TABLE) {
1,762✔
987
    SStbObj *pStb = mndAcquireStb(pMnode, pTopic->stbName);
341✔
988
    if (pStb == NULL) {
341✔
989
      STR_TO_VARSTR(schemaJson, "NULL");
×
990
      mError("mndRetrieveTopic mndAcquireStb null stbName:%s", pTopic->stbName);
×
991
    } else {
992
      schemaToJson(pStb->pColumns, pStb->numOfColumns, schemaJson);
341✔
993
      mndReleaseStb(pMnode, pStb);
341✔
994
    }
995
  } else {
996
    STR_TO_VARSTR(schemaJson, "NULL");
1,421✔
997
  }
998

999
  pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
50,060✔
1000
  MND_TMQ_NULL_CHECK(pColInfo);
50,060✔
1001
  MND_TMQ_RETURN_CHECK(colDataSetVal(pColInfo, *numOfRows, (const char *)schemaJson, false));
50,060✔
1002
  taosMemoryFreeClear(schemaJson);
50,060✔
1003

1004
  (*numOfRows)++;
50,060✔
1005

1006
END:
50,060✔
1007
  taosRUnLockLatch(&pTopic->lock);
50,060✔
1008

1009
  taosMemoryFreeClear(sql);
50,060✔
1010
  taosMemoryFreeClear(schemaJson);
50,060✔
1011
  return code;
50,060✔
1012
}
1013

1014
static int32_t mndRetrieveTopic(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rowsCapacity) {
17,982✔
1015
  if (pReq == NULL || pShow == NULL || pBlock == NULL) {
17,982✔
1016
    return TSDB_CODE_INVALID_MSG;
×
1017
  }
1018
  SMnode      *pMnode = pReq->info.node;
17,982✔
1019
  SSdb        *pSdb = pMnode->pSdb;
17,982✔
1020
  int32_t      numOfRows = 0;
17,982✔
1021
  SMqTopicObj *pTopic = NULL;
17,982✔
1022
  SUserObj    *pOperUser = NULL;
17,982✔
1023
  int32_t      code = 0, lino = 0;
17,982✔
1024
  char        *sql = NULL;
17,982✔
1025
  char        *schemaJson = NULL;
17,982✔
1026
  char         objFName[TSDB_OBJ_FNAME_LEN + 1] = {0};
17,982✔
1027
  bool         showAll = false;
17,982✔
1028

1029
  MND_TMQ_RETURN_CHECK(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser));
17,982✔
1030
  (void)snprintf(objFName, sizeof(objFName), "%d.*", pOperUser->acctId);
17,982✔
1031
  int32_t objLevel = privObjGetLevel(PRIV_OBJ_TOPIC);
17,982✔
1032
  showAll = (0 == mndCheckSysObjPrivilege(pMnode, pOperUser, PRIV_CM_SHOW, PRIV_OBJ_TOPIC, 0, objFName,
17,982✔
1033
                                          objLevel == 0 ? NULL : "*"));  // 1.*.*
1034

1035
  PRINT_LOG_START
17,982✔
1036

1037
  while (numOfRows < rowsCapacity) {
68,042✔
1038
    pShow->pIter = sdbFetch(pSdb, SDB_TOPIC, pShow->pIter, (void **)&pTopic);
68,042✔
1039
    if (pShow->pIter == NULL) break;
68,042✔
1040

1041
    if (!showAll) {
50,060✔
1042
      if (mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_SHOW, PRIV_OBJ_TOPIC, pTopic->ownerId, pTopic->db,
×
1043
                                   objLevel == 0 ? NULL : mndGetDbStr(pTopic->name)) != 0) {  // 1.topic1
×
1044
        sdbRelease(pSdb, pTopic);
×
1045
        continue;
×
1046
      }
1047
    }
1048

1049
    MND_TMQ_RETURN_CHECK(buildResult(pTopic, &numOfRows, pMnode, pBlock));
50,060✔
1050
    sdbRelease(pSdb, pTopic);
50,060✔
1051
    pTopic = NULL;
50,060✔
1052
  }
1053
  pShow->numOfRows += numOfRows;
17,982✔
1054

1055
END:
17,982✔
1056
  sdbCancelFetch(pSdb, pShow->pIter);
17,982✔
1057
  sdbRelease(pSdb, pTopic);
17,982✔
1058
  mndReleaseUser(pMnode, pOperUser);
17,982✔
1059
  if (code != TSDB_CODE_SUCCESS) {
17,982✔
1060
    mError("%s failed since %s", __func__, tstrerror(code));
×
1061
    return code;
×
1062
  } else {
1063
    mDebug("%s retrieved %d rows successfully", __func__, numOfRows);
17,982✔
1064
    return numOfRows;
17,982✔
1065
  }
1066
}
1067

1068
static void mndCancelGetNextTopic(SMnode *pMnode, void *pIter) {
×
1069
  if (pMnode == NULL) return;
×
1070
  SSdb *pSdb = pMnode->pSdb;
×
1071
  sdbCancelFetchByType(pSdb, pIter, SDB_TOPIC);
×
1072
}
1073

1074
bool mndTopicExistsForDb(SMnode *pMnode, SDbObj *pDb) {
621,792✔
1075
  if (pMnode == NULL || pDb == NULL) {
621,792✔
1076
    return false;
×
1077
  }
1078
  SSdb *       pSdb = pMnode->pSdb;
621,792✔
1079
  void *       pIter = NULL;
621,792✔
1080
  SMqTopicObj *pTopic = NULL;
621,792✔
1081

1082
  while (1) {
49,972✔
1083
    pIter = sdbFetch(pSdb, SDB_TOPIC, pIter, (void **)&pTopic);
671,764✔
1084
    if (pIter == NULL) {
671,764✔
1085
      break;
621,441✔
1086
    }
1087

1088
    taosRLockLatch(&pTopic->lock);
50,323✔
1089
    bool found = pTopic->dbUid == pDb->uid;
50,323✔
1090
    taosRUnLockLatch(&pTopic->lock);
50,323✔
1091

1092
    if (found) {
50,323✔
1093
      sdbRelease(pSdb, pTopic);
351✔
1094
      sdbCancelFetch(pSdb, pIter);
351✔
1095
      return true;
351✔
1096
    }
1097

1098
    sdbRelease(pSdb, pTopic);
49,972✔
1099
  }
1100

1101
  return false;
621,441✔
1102
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc